rogue(6): General cleanup.

* Move externs to common rogue.h
* Constify
* Various cleanups
* Several bugfixes from NetBSD

phantasia(6): General cleanup.

* Staticize
* Constify
* Collect externs
* Add attributes
* Sync logic with NetBSD (except for style)

hack(6): Suppress warnings.

Add FALLTHROUGH directives were needed, fix few format issues.

games: Do not override default CFLAGS.

Preserve system default CFLAGS. Override is only needed in case of boot2.

mille(6): General cleanup.

* Constification.
* Braces.
* Do not use increments/decrements on booleans.
* Add few missing fallthrough.

Fix gcc80 -Wbool-operation warnings in fortune(6) and hack(6).

games: Fix -Wint-in-bool-context warnings.

These cases were the last two in base.

Fix gcc80 -Wnonnull-compare.

For arguments that are checked against NULL in the function, we don't
want a nonnull attribute, because that will cause the NULL check to be
optimized away in higher -O

Fix gcc80 -Wnonnull-compare.

For arguments that are checked against NULL in the function, we don't
want a nonnull attribute, because that will cause the NULL check to be
optimized away in higher -O levels and it will also trigger a
-Wnonnull-compare warning.

See also 0f037c78525bfb7df49de8338826e15137859b1d commit message.

show more ...

{bs,quiz}(6): Compare pointers with NULL, not '\0'.

Simplify some Makefiles.

If there is just one source file that is named ${PROG}.c, SRCS does
not need to be set.

morse(6): correct email for original author

Obtained-From: FreeBSD

morse(6): add static where appropriate

Add __attribute__((__noreturn__)) to various function prototypes in games/.

This general cleanup is useful in various ways. It helps the compiler
optimize better and it also helps later GCCs detect

Add __attribute__((__noreturn__)) to various function prototypes in games/.

This general cleanup is useful in various ways. It helps the compiler
optimize better and it also helps later GCCs detect better when to give
-Wimplicit-fallthrough warnings and when not.

Found-with: -Wsuggest-attribute=noreturn

show more ...

wump(6): Staticize.

worms(6): Staticize.

worm(6): Staticize and remove some "return" (crash() never returns).

sail(6): pl_main() never returns, so don't pretend it does.

pig(6): Staticize.

number(6): Staticize and remove a wrong prototype.

hangman(6): Move __dead2 to the prototype.

arithmetic(6): Staticize.

morse(6): Avoid -Wshadow warning with gcc47.

morse.c:465:8: warning: declaration of 'isblank' shadows a global declaration [-Wshadow]
In file included from morse.c:43:0:
/usr/include/ctype.h:211:5:

morse(6): Avoid -Wshadow warning with gcc47.

morse.c:465:8: warning: declaration of 'isblank' shadows a global declaration [-Wshadow]
In file included from morse.c:43:0:
/usr/include/ctype.h:211:5: warning: shadowed declaration is here [-Wshadow]

show more ...

morse(6): Add decoding functionality for dot-dash code.

Our -d was already taken so use -r option for "reverse" mode.

Usage examples through command line ("--" for safety) and pipe:
_# morse -r --

morse(6): Add decoding functionality for dot-dash code.

Our -d was already taken so use -r option for "reverse" mode.

Usage examples through command line ("--" for safety) and pipe:
_# morse -r -- .... .- -.-. -.- .. -. --.
HACKING
_# cat <<EOF | morse -r
.---
-...
---
-..
--..
EOF
JBODZ

Also it woks as most inefficient way to capitalize words too:
_# morse -s meow | morse -r
MEOW

Pointed-by: tuxillo
Decoding-shamelessly-stolen-from: OpenBSD

show more ...

games: Make benefits for the glorious curses lib.

Consolidate all private ncurses handling in top level Makefile.inc in games/.
Will simplify upcoming base ncurses library update.

While there, perf

games: Make benefits for the glorious curses lib.

Consolidate all private ncurses handling in top level Makefile.inc in games/.
Will simplify upcoming base ncurses library update.

While there, perfom the same for private crypto lib even if it a single case.

show more ...

fortune(6): Pre-emptive CENSORSHIP.

First let's get it straight. It is censorship and let's not sugar coat it.

The FO has fallen, N is falling and naturally we are next.
I'm only doing this to prev

fortune(6): Pre-emptive CENSORSHIP.

First let's get it straight. It is censorship and let's not sugar coat it.

The FO has fallen, N is falling and naturally we are next.
I'm only doing this to prevent certain discussions taking place on the mailing
lists or irc over the holidays and to explictly show irony of all this ${thing}.
It is SAD to see that various projects went from technical to being PC infested.
So much for being the flagmans of OSS developments & examples to other projects.
(slow ironic clapping insert here)
Such slabnij individuals with "hurt feelings" always are causing developers to
get distracted from their hacking on source or making hardware work properly.
Also, these actions opens up the door wider for "other" topics into discussions.

I'm not going to mention the name of certain evil* person so that this would not
get "flagged". Absurdity is already way beyond any reasonable levels. Clearly
there are some perpetually offended snoflakes, who have nothing better to do
other than look for ways to get offended or to trigger other people in real life
and over the internet. Why not just choose one? If someone wants to let some
accumulated steam off, there are places over the internet where one can have a
constructive conversation about certain topics. If you can not handle the raw,
unredacted, straight opinions, you must be new there, please kindly go back to
reddit safe spaces. Just do *not* bring those talks over into the projects!
It is very likely that not everybody feels the same or even cares.
This is literally "Look what you made me do!", so here we go.

I'm going to consider cookies removal *only* and *only* if some things are
declared illegal by the country/state law with a reference to look it up where
it clearly states what is illegal to quote (including if that applies to the
translated text variants). No "probably" stuff. Either it's illegal or it's not.
If you are not sure, you should consult with your country/state lawyers first.

By going trough MSM and lists it is clear that some find offensive *not* the
quotes by itself but the mere mention of certain letter combinations. Since I do
not share identical ideology as most westerners (I was born in 19 88, USSR, and
with collapse of Soviet union and 19 91 events my fundation is a different myth)
I'm expanding "grep ${pattern} datfiles/fortune" to include Stalin for lulz too.
Many Lithuanians and Ukrainians find "admirating" that historic figure offensive
too, mainly because of "free" trips to Siberia, brothers and sisters separated
from parents, etc. Still it is not for me to judge the history nor rewrite it.

For now I'm keeping all Communism/Capitalism cookies just as a satire. But I'm
moving the qoute by Adolfo Guzman too, cause "sorry it matched the patternTM".
Doing this solves the following issues:
* does not single out any specific individual (just a pattern right?);
* clearly expresses irony and shows how some are so biased and have no
understanding that their actions have consequences.

If for some reason you still find something offensive, check out "man 6 fortune"
for "-o" flag. Of course, if (for some reason) you do not want the potentially
"offensive" aphorisms on your disk, you can opt out:
* echo 'INSTALL_OFFENSIVE_FORTUNES=NO\!\!\!\!' >> /etc/make.conf
* standard buildworld/installworld
* make upgrade
and problem solved.

If still find things like fortune(6), hangman(6), pig(6) or maybe even tetris(6)
"offensive", set NO_GAMES=YES and get rid of all games distrib (I don't judge).
Since we are source based distribution (and no, BSD does *not* stand for Binary
Software Distribution) we provide installation images just for convenience. We
do not support binary base upgrades, only the standard source tree build ones.

To be clear, I had some of these fortune cookies added over a year ago in:
6c5aea60b8d9d163c6caa536036e82e7472b84bc and nobody so far complained about it.
It is still very strange that previously those were OK. So what has changed now?

What if I'm offended by software bugs? Should I remove that sofware or try to
fix it? What if someone is offended by the license say GPL, CDDL or even Apache?
So far censorship applies only to games/fortune/.

All of this is just something to think about & no further talks will take place.
Respect others and respect yourself. Also, don't get offended to get offended.
I can only hope that infinity will forgive me, but this needs to be done.

show more ...