Clean-up patch: use `void *' instead of old-fashioned ClientData/Address.

Thus, Lst_ForEach no longer needs returning a status.
In fact, it can become a macro based on Lst_ForEachFrom.
This also introduces Lst_Every, as a shortcut for the very common case where
Lst_ForEach

Thus, Lst_ForEach no longer needs returning a status.
In fact, it can become a macro based on Lst_ForEachFrom.
This also introduces Lst_Every, as a shortcut for the very common case where
Lst_ForEach does not need any user data.

Finally, make consistent use of a few function typedefs, instead of having
explicit void (*)(Lst) arguments all over the place.

show more ...

Remove idiotic, braindead casts T* -> void*
They serve no purpose, except hiding potential bugs.

In particular, remove (ClientData) cast from macro, showing potentially
troublesome use of Hashes to

Remove idiotic, braindead casts T* -> void*
They serve no purpose, except hiding potential bugs.

In particular, remove (ClientData) cast from macro, showing potentially
troublesome use of Hashes to store time_t.

show more ...

Finish changing all Var_Parse arguments to size_t. Thanks to millert@
for reminding me.

Rearrange Lst_Find interface to conform better with other functions.

Nothing ever checks ReturnStatus on Lst_Insert, Lst_Append, Lst_AtFront,
Lst_AtEnd, Lst_Concat, Lst_Remove, Lst_Replace.

Don't bother returning one.

NIL, NILGNODE, etc, are only glorified NULL.
Get rid of them.

Get rid of list.h, nothing uses it anyway.

make does not use circular lists, get rid of the extra weight.

Var_Subst is actually two distinct functions folded into one:
split the function specific to for.c out, and give them more sensible
arguments at the same time.

This makes .for loop handling more eff

Var_Subst is actually two distinct functions folded into one:
split the function specific to for.c out, and give them more sensible
arguments at the same time.

This makes .for loop handling more efficient, as we have some heuristic
to evaluate the size of the buffer needed...

show more ...

Allocate buffers as static data structures.
This cuts down quite a lot of malloc, since in actual use,
buffer usage is mostly static.

Remove unneeded extraneous zeros at the end of buffers.

Actually, one of these needs to be there, because of two bugs in cond.c

Split Buf_GetAll into Buf_Retrieve/Buf_Size.
(idiotic to retrieve size every time when it's used half the time)

Start cleaning up buf.c in earnest.

- Buf_Discard is only used to remove all the bytes in a buffer,
replace with Buf_Reset,
- buffer values are not read unless accessed first through Buf_GetAll,
no

Start cleaning up buf.c in earnest.

- Buf_Discard is only used to remove all the bytes in a buffer,
replace with Buf_Reset,
- buffer values are not read unless accessed first through Buf_GetAll,
no need to null-terminate it at every point.
- Buf_Expand need not check if the expansion is needed. That's Buf_AddChar
and Buf_AddChars responsability (otherwise, Buf_AddChar checks twice)
- Buf_Overflow only handles overflow. Adding the character is done in
every case anyway.

show more ...

Introduce `common usage' buf patterns and use them.

Extra parameter no longer needed, ditch.

Instead of retrieving var values from the environment again and again,
it is much better to keep them in the global context, marked read-only.

This also makes the next simplification possible, since

Instead of retrieving var values from the environment again and again,
it is much better to keep them in the global context, marked read-only.

This also makes the next simplification possible, since var values need no
longer be free'd by client code.

(reviewed by ho@, like other patches)

show more ...

Clean up buffers interface somewhat:

- buf.c deals exclusively with chars. Be explicit about it, and remove
extraneous dumb casts to char (can hide real type errors).
- buffer sizes are size_t. Note

Clean up buffers interface somewhat:

- buf.c deals exclusively with chars. Be explicit about it, and remove
extraneous dumb casts to char (can hide real type errors).
- buffer sizes are size_t. Note that bp->left can never become NULL.
- Buf_GetAll is happy with a NULL pointer for the size, remove unneeded
extra pointers.
- Propagate size_t to all places where buffer functions are used.

show more ...

Kill Str_FindSubString, it's strstr.

Turn on strict-prototypes, add missing prototypes.
Move main prototype to main.c, as this is not used
from any other file.

Close open bug.

Bug-fix: when expanding a specific variable v in $A,
check that v is PRECISELY A.

Other BSDs, take notice.

Fix
.if defined(VAR) && ${VAR:m}

cond.c has special code (set err to 0) to tell VarParse it shouldn't care
if the variable is not defined.

But this was not completely added, namely the path that de

Fix
.if defined(VAR) && ${VAR:m}

cond.c has special code (set err to 0) to tell VarParse it shouldn't care
if the variable is not defined.

But this was not completely added, namely the path that deals with
modifiers was blissfully unaware of that.

show more ...

Add :L/:U modificators (lowercase/uppercase)
To use to get ports building more user-friendly.

Modifications from netbsd:
- don't interfere with MACHINE/MACHINE_ARCH defines for bootstrap
- type clean-up, time_t, and printing `unknown' ints
- fix TARGET/MEMBER bug in archive rules
- memmove...

Modifications from netbsd:
- don't interfere with MACHINE/MACHINE_ARCH defines for bootstrap
- type clean-up, time_t, and printing `unknown' ints
- fix TARGET/MEMBER bug in archive rules
- memmove...
- cleaner Error handler.
- reentrant brk_string
- .MAKE env variable
- preliminary scaffolding for .NOPATH

Other improvements:
- efree
- shellneed streamlined
- display Stop in .CURDIR after an error.
- document most features and misfeatures.
- add a few OpenBSD notes to the tutorial.

show more ...

portable bootstrap thing; lidl@eng.us.uu.net

Y2K fixes from Andreas.Gunnarsson@emw.ericsson.se; culled from various places