1 //===- VerifyDiagnosticConsumer.cpp - Verifying Diagnostic Client ---------===//
2 //
3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4 // See https://llvm.org/LICENSE.txt for license information.
5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6 //
7 //===----------------------------------------------------------------------===//
8 //
9 // This is a concrete diagnostic client, which buffers the diagnostic messages.
10 //
11 //===----------------------------------------------------------------------===//
12 
13 #include "clang/Frontend/VerifyDiagnosticConsumer.h"
14 #include "clang/Basic/CharInfo.h"
15 #include "clang/Basic/Diagnostic.h"
16 #include "clang/Basic/DiagnosticOptions.h"
17 #include "clang/Basic/FileManager.h"
18 #include "clang/Basic/LLVM.h"
19 #include "clang/Basic/SourceLocation.h"
20 #include "clang/Basic/SourceManager.h"
21 #include "clang/Basic/TokenKinds.h"
22 #include "clang/Frontend/FrontendDiagnostic.h"
23 #include "clang/Frontend/TextDiagnosticBuffer.h"
24 #include "clang/Lex/HeaderSearch.h"
25 #include "clang/Lex/Lexer.h"
26 #include "clang/Lex/PPCallbacks.h"
27 #include "clang/Lex/Preprocessor.h"
28 #include "clang/Lex/Token.h"
29 #include "llvm/ADT/STLExtras.h"
30 #include "llvm/ADT/SmallPtrSet.h"
31 #include "llvm/ADT/SmallString.h"
32 #include "llvm/ADT/StringRef.h"
33 #include "llvm/ADT/Twine.h"
34 #include "llvm/Support/ErrorHandling.h"
35 #include "llvm/Support/Regex.h"
36 #include "llvm/Support/raw_ostream.h"
37 #include <algorithm>
38 #include <cassert>
39 #include <cstddef>
40 #include <cstring>
41 #include <iterator>
42 #include <memory>
43 #include <string>
44 #include <utility>
45 #include <vector>
46 
47 using namespace clang;
48 
49 using Directive = VerifyDiagnosticConsumer::Directive;
50 using DirectiveList = VerifyDiagnosticConsumer::DirectiveList;
51 using ExpectedData = VerifyDiagnosticConsumer::ExpectedData;
52 
53 #ifndef NDEBUG
54 
55 namespace {
56 
57 class VerifyFileTracker : public PPCallbacks {
58   VerifyDiagnosticConsumer &Verify;
59   SourceManager &SM;
60 
61 public:
VerifyFileTracker(VerifyDiagnosticConsumer & Verify,SourceManager & SM)62   VerifyFileTracker(VerifyDiagnosticConsumer &Verify, SourceManager &SM)
63       : Verify(Verify), SM(SM) {}
64 
65   /// Hook into the preprocessor and update the list of parsed
66   /// files when the preprocessor indicates a new file is entered.
FileChanged(SourceLocation Loc,FileChangeReason Reason,SrcMgr::CharacteristicKind FileType,FileID PrevFID)67   void FileChanged(SourceLocation Loc, FileChangeReason Reason,
68                    SrcMgr::CharacteristicKind FileType,
69                    FileID PrevFID) override {
70     Verify.UpdateParsedFileStatus(SM, SM.getFileID(Loc),
71                                   VerifyDiagnosticConsumer::IsParsed);
72   }
73 };
74 
75 } // namespace
76 
77 #endif
78 
79 //===----------------------------------------------------------------------===//
80 // Checking diagnostics implementation.
81 //===----------------------------------------------------------------------===//
82 
83 using DiagList = TextDiagnosticBuffer::DiagList;
84 using const_diag_iterator = TextDiagnosticBuffer::const_iterator;
85 
86 namespace {
87 
88 /// StandardDirective - Directive with string matching.
89 class StandardDirective : public Directive {
90 public:
StandardDirective(SourceLocation DirectiveLoc,SourceLocation DiagnosticLoc,bool MatchAnyFileAndLine,bool MatchAnyLine,StringRef Text,unsigned Min,unsigned Max)91   StandardDirective(SourceLocation DirectiveLoc, SourceLocation DiagnosticLoc,
92                     bool MatchAnyFileAndLine, bool MatchAnyLine, StringRef Text,
93                     unsigned Min, unsigned Max)
94       : Directive(DirectiveLoc, DiagnosticLoc, MatchAnyFileAndLine,
95                   MatchAnyLine, Text, Min, Max) {}
96 
isValid(std::string & Error)97   bool isValid(std::string &Error) override {
98     // all strings are considered valid; even empty ones
99     return true;
100   }
101 
match(StringRef S)102   bool match(StringRef S) override { return S.contains(Text); }
103 };
104 
105 /// RegexDirective - Directive with regular-expression matching.
106 class RegexDirective : public Directive {
107 public:
RegexDirective(SourceLocation DirectiveLoc,SourceLocation DiagnosticLoc,bool MatchAnyFileAndLine,bool MatchAnyLine,StringRef Text,unsigned Min,unsigned Max,StringRef RegexStr)108   RegexDirective(SourceLocation DirectiveLoc, SourceLocation DiagnosticLoc,
109                  bool MatchAnyFileAndLine, bool MatchAnyLine, StringRef Text,
110                  unsigned Min, unsigned Max, StringRef RegexStr)
111       : Directive(DirectiveLoc, DiagnosticLoc, MatchAnyFileAndLine,
112                   MatchAnyLine, Text, Min, Max),
113         Regex(RegexStr) {}
114 
isValid(std::string & Error)115   bool isValid(std::string &Error) override {
116     return Regex.isValid(Error);
117   }
118 
match(StringRef S)119   bool match(StringRef S) override {
120     return Regex.match(S);
121   }
122 
123 private:
124   llvm::Regex Regex;
125 };
126 
127 class ParseHelper
128 {
129 public:
ParseHelper(StringRef S)130   ParseHelper(StringRef S)
131       : Begin(S.begin()), End(S.end()), C(Begin), P(Begin) {}
132 
133   // Return true if string literal is next.
Next(StringRef S)134   bool Next(StringRef S) {
135     P = C;
136     PEnd = C + S.size();
137     if (PEnd > End)
138       return false;
139     return memcmp(P, S.data(), S.size()) == 0;
140   }
141 
142   // Return true if number is next.
143   // Output N only if number is next.
Next(unsigned & N)144   bool Next(unsigned &N) {
145     unsigned TMP = 0;
146     P = C;
147     PEnd = P;
148     for (; PEnd < End && *PEnd >= '0' && *PEnd <= '9'; ++PEnd) {
149       TMP *= 10;
150       TMP += *PEnd - '0';
151     }
152     if (PEnd == C)
153       return false;
154     N = TMP;
155     return true;
156   }
157 
158   // Return true if a marker is next.
159   // A marker is the longest match for /#[A-Za-z0-9_-]+/.
NextMarker()160   bool NextMarker() {
161     P = C;
162     if (P == End || *P != '#')
163       return false;
164     PEnd = P;
165     ++PEnd;
166     while ((isAlphanumeric(*PEnd) || *PEnd == '-' || *PEnd == '_') &&
167            PEnd < End)
168       ++PEnd;
169     return PEnd > P + 1;
170   }
171 
172   // Return true if string literal S is matched in content.
173   // When true, P marks begin-position of the match, and calling Advance sets C
174   // to end-position of the match.
175   // If S is the empty string, then search for any letter instead (makes sense
176   // with FinishDirectiveToken=true).
177   // If EnsureStartOfWord, then skip matches that don't start a new word.
178   // If FinishDirectiveToken, then assume the match is the start of a comment
179   // directive for -verify, and extend the match to include the entire first
180   // token of that directive.
Search(StringRef S,bool EnsureStartOfWord=false,bool FinishDirectiveToken=false)181   bool Search(StringRef S, bool EnsureStartOfWord = false,
182               bool FinishDirectiveToken = false) {
183     do {
184       if (!S.empty()) {
185         P = std::search(C, End, S.begin(), S.end());
186         PEnd = P + S.size();
187       }
188       else {
189         P = C;
190         while (P != End && !isLetter(*P))
191           ++P;
192         PEnd = P + 1;
193       }
194       if (P == End)
195         break;
196       // If not start of word but required, skip and search again.
197       if (EnsureStartOfWord
198                // Check if string literal starts a new word.
199           && !(P == Begin || isWhitespace(P[-1])
200                // Or it could be preceded by the start of a comment.
201                || (P > (Begin + 1) && (P[-1] == '/' || P[-1] == '*')
202                                    &&  P[-2] == '/')))
203         continue;
204       if (FinishDirectiveToken) {
205         while (PEnd != End && (isAlphanumeric(*PEnd)
206                                || *PEnd == '-' || *PEnd == '_'))
207           ++PEnd;
208         // Put back trailing digits and hyphens to be parsed later as a count
209         // or count range.  Because -verify prefixes must start with letters,
210         // we know the actual directive we found starts with a letter, so
211         // we won't put back the entire directive word and thus record an empty
212         // string.
213         assert(isLetter(*P) && "-verify prefix must start with a letter");
214         while (isDigit(PEnd[-1]) || PEnd[-1] == '-')
215           --PEnd;
216       }
217       return true;
218     } while (Advance());
219     return false;
220   }
221 
222   // Return true if a CloseBrace that closes the OpenBrace at the current nest
223   // level is found. When true, P marks begin-position of CloseBrace.
SearchClosingBrace(StringRef OpenBrace,StringRef CloseBrace)224   bool SearchClosingBrace(StringRef OpenBrace, StringRef CloseBrace) {
225     unsigned Depth = 1;
226     P = C;
227     while (P < End) {
228       StringRef S(P, End - P);
229       if (S.starts_with(OpenBrace)) {
230         ++Depth;
231         P += OpenBrace.size();
232       } else if (S.starts_with(CloseBrace)) {
233         --Depth;
234         if (Depth == 0) {
235           PEnd = P + CloseBrace.size();
236           return true;
237         }
238         P += CloseBrace.size();
239       } else {
240         ++P;
241       }
242     }
243     return false;
244   }
245 
246   // Advance 1-past previous next/search.
247   // Behavior is undefined if previous next/search failed.
Advance()248   bool Advance() {
249     C = PEnd;
250     return C < End;
251   }
252 
253   // Return the text matched by the previous next/search.
254   // Behavior is undefined if previous next/search failed.
Match()255   StringRef Match() { return StringRef(P, PEnd - P); }
256 
257   // Skip zero or more whitespace.
SkipWhitespace()258   void SkipWhitespace() {
259     for (; C < End && isWhitespace(*C); ++C)
260       ;
261   }
262 
263   // Return true if EOF reached.
Done()264   bool Done() {
265     return !(C < End);
266   }
267 
268   // Beginning of expected content.
269   const char * const Begin;
270 
271   // End of expected content (1-past).
272   const char * const End;
273 
274   // Position of next char in content.
275   const char *C;
276 
277   // Previous next/search subject start.
278   const char *P;
279 
280 private:
281   // Previous next/search subject end (1-past).
282   const char *PEnd = nullptr;
283 };
284 
285 // The information necessary to create a directive.
286 struct UnattachedDirective {
287   DirectiveList *DL = nullptr;
288   bool RegexKind = false;
289   SourceLocation DirectivePos, ContentBegin;
290   std::string Text;
291   unsigned Min = 1, Max = 1;
292 };
293 
294 // Attach the specified directive to the line of code indicated by
295 // \p ExpectedLoc.
attachDirective(DiagnosticsEngine & Diags,const UnattachedDirective & UD,SourceLocation ExpectedLoc,bool MatchAnyFileAndLine=false,bool MatchAnyLine=false)296 void attachDirective(DiagnosticsEngine &Diags, const UnattachedDirective &UD,
297                      SourceLocation ExpectedLoc,
298                      bool MatchAnyFileAndLine = false,
299                      bool MatchAnyLine = false) {
300   // Construct new directive.
301   std::unique_ptr<Directive> D = Directive::create(
302       UD.RegexKind, UD.DirectivePos, ExpectedLoc, MatchAnyFileAndLine,
303       MatchAnyLine, UD.Text, UD.Min, UD.Max);
304 
305   std::string Error;
306   if (!D->isValid(Error)) {
307     Diags.Report(UD.ContentBegin, diag::err_verify_invalid_content)
308       << (UD.RegexKind ? "regex" : "string") << Error;
309   }
310 
311   UD.DL->push_back(std::move(D));
312 }
313 
314 } // anonymous
315 
316 // Tracker for markers in the input files. A marker is a comment of the form
317 //
318 //   n = 123; // #123
319 //
320 // ... that can be referred to by a later expected-* directive:
321 //
322 //   // expected-error@#123 {{undeclared identifier 'n'}}
323 //
324 // Marker declarations must be at the start of a comment or preceded by
325 // whitespace to distinguish them from uses of markers in directives.
326 class VerifyDiagnosticConsumer::MarkerTracker {
327   DiagnosticsEngine &Diags;
328 
329   struct Marker {
330     SourceLocation DefLoc;
331     SourceLocation RedefLoc;
332     SourceLocation UseLoc;
333   };
334   llvm::StringMap<Marker> Markers;
335 
336   // Directives that couldn't be created yet because they name an unknown
337   // marker.
338   llvm::StringMap<llvm::SmallVector<UnattachedDirective, 2>> DeferredDirectives;
339 
340 public:
MarkerTracker(DiagnosticsEngine & Diags)341   MarkerTracker(DiagnosticsEngine &Diags) : Diags(Diags) {}
342 
343   // Register a marker.
addMarker(StringRef MarkerName,SourceLocation Pos)344   void addMarker(StringRef MarkerName, SourceLocation Pos) {
345     auto InsertResult = Markers.insert(
346         {MarkerName, Marker{Pos, SourceLocation(), SourceLocation()}});
347 
348     Marker &M = InsertResult.first->second;
349     if (!InsertResult.second) {
350       // Marker was redefined.
351       M.RedefLoc = Pos;
352     } else {
353       // First definition: build any deferred directives.
354       auto Deferred = DeferredDirectives.find(MarkerName);
355       if (Deferred != DeferredDirectives.end()) {
356         for (auto &UD : Deferred->second) {
357           if (M.UseLoc.isInvalid())
358             M.UseLoc = UD.DirectivePos;
359           attachDirective(Diags, UD, Pos);
360         }
361         DeferredDirectives.erase(Deferred);
362       }
363     }
364   }
365 
366   // Register a directive at the specified marker.
addDirective(StringRef MarkerName,const UnattachedDirective & UD)367   void addDirective(StringRef MarkerName, const UnattachedDirective &UD) {
368     auto MarkerIt = Markers.find(MarkerName);
369     if (MarkerIt != Markers.end()) {
370       Marker &M = MarkerIt->second;
371       if (M.UseLoc.isInvalid())
372         M.UseLoc = UD.DirectivePos;
373       return attachDirective(Diags, UD, M.DefLoc);
374     }
375     DeferredDirectives[MarkerName].push_back(UD);
376   }
377 
378   // Ensure we have no remaining deferred directives, and no
379   // multiply-defined-and-used markers.
finalize()380   void finalize() {
381     for (auto &MarkerInfo : Markers) {
382       StringRef Name = MarkerInfo.first();
383       Marker &M = MarkerInfo.second;
384       if (M.RedefLoc.isValid() && M.UseLoc.isValid()) {
385         Diags.Report(M.UseLoc, diag::err_verify_ambiguous_marker) << Name;
386         Diags.Report(M.DefLoc, diag::note_verify_ambiguous_marker) << Name;
387         Diags.Report(M.RedefLoc, diag::note_verify_ambiguous_marker) << Name;
388       }
389     }
390 
391     for (auto &DeferredPair : DeferredDirectives) {
392       Diags.Report(DeferredPair.second.front().DirectivePos,
393                    diag::err_verify_no_such_marker)
394           << DeferredPair.first();
395     }
396   }
397 };
398 
399 /// ParseDirective - Go through the comment and see if it indicates expected
400 /// diagnostics. If so, then put them in the appropriate directive list.
401 ///
402 /// Returns true if any valid directives were found.
ParseDirective(StringRef S,ExpectedData * ED,SourceManager & SM,Preprocessor * PP,SourceLocation Pos,VerifyDiagnosticConsumer::DirectiveStatus & Status,VerifyDiagnosticConsumer::MarkerTracker & Markers)403 static bool ParseDirective(StringRef S, ExpectedData *ED, SourceManager &SM,
404                            Preprocessor *PP, SourceLocation Pos,
405                            VerifyDiagnosticConsumer::DirectiveStatus &Status,
406                            VerifyDiagnosticConsumer::MarkerTracker &Markers) {
407   DiagnosticsEngine &Diags = PP ? PP->getDiagnostics() : SM.getDiagnostics();
408 
409   // First, scan the comment looking for markers.
410   for (ParseHelper PH(S); !PH.Done();) {
411     if (!PH.Search("#", true))
412       break;
413     PH.C = PH.P;
414     if (!PH.NextMarker()) {
415       PH.Next("#");
416       PH.Advance();
417       continue;
418     }
419     PH.Advance();
420     Markers.addMarker(PH.Match(), Pos);
421   }
422 
423   // A single comment may contain multiple directives.
424   bool FoundDirective = false;
425   for (ParseHelper PH(S); !PH.Done();) {
426     // Search for the initial directive token.
427     // If one prefix, save time by searching only for its directives.
428     // Otherwise, search for any potential directive token and check it later.
429     const auto &Prefixes = Diags.getDiagnosticOptions().VerifyPrefixes;
430     if (!(Prefixes.size() == 1 ? PH.Search(*Prefixes.begin(), true, true)
431                                : PH.Search("", true, true)))
432       break;
433 
434     StringRef DToken = PH.Match();
435     PH.Advance();
436 
437     // Default directive kind.
438     UnattachedDirective D;
439     const char *KindStr = "string";
440 
441     // Parse the initial directive token in reverse so we can easily determine
442     // its exact actual prefix.  If we were to parse it from the front instead,
443     // it would be harder to determine where the prefix ends because there
444     // might be multiple matching -verify prefixes because some might prefix
445     // others.
446 
447     // Regex in initial directive token: -re
448     if (DToken.ends_with("-re")) {
449       D.RegexKind = true;
450       KindStr = "regex";
451       DToken = DToken.substr(0, DToken.size()-3);
452     }
453 
454     // Type in initial directive token: -{error|warning|note|no-diagnostics}
455     bool NoDiag = false;
456     StringRef DType;
457     if (DToken.ends_with(DType = "-error"))
458       D.DL = ED ? &ED->Errors : nullptr;
459     else if (DToken.ends_with(DType = "-warning"))
460       D.DL = ED ? &ED->Warnings : nullptr;
461     else if (DToken.ends_with(DType = "-remark"))
462       D.DL = ED ? &ED->Remarks : nullptr;
463     else if (DToken.ends_with(DType = "-note"))
464       D.DL = ED ? &ED->Notes : nullptr;
465     else if (DToken.ends_with(DType = "-no-diagnostics")) {
466       NoDiag = true;
467       if (D.RegexKind)
468         continue;
469     } else
470       continue;
471     DToken = DToken.substr(0, DToken.size()-DType.size());
472 
473     // What's left in DToken is the actual prefix.  That might not be a -verify
474     // prefix even if there is only one -verify prefix (for example, the full
475     // DToken is foo-bar-warning, but foo is the only -verify prefix).
476     if (!std::binary_search(Prefixes.begin(), Prefixes.end(), DToken))
477       continue;
478 
479     if (NoDiag) {
480       if (Status == VerifyDiagnosticConsumer::HasOtherExpectedDirectives)
481         Diags.Report(Pos, diag::err_verify_invalid_no_diags)
482           << /*IsExpectedNoDiagnostics=*/true;
483       else
484         Status = VerifyDiagnosticConsumer::HasExpectedNoDiagnostics;
485       continue;
486     }
487     if (Status == VerifyDiagnosticConsumer::HasExpectedNoDiagnostics) {
488       Diags.Report(Pos, diag::err_verify_invalid_no_diags)
489         << /*IsExpectedNoDiagnostics=*/false;
490       continue;
491     }
492     Status = VerifyDiagnosticConsumer::HasOtherExpectedDirectives;
493 
494     // If a directive has been found but we're not interested
495     // in storing the directive information, return now.
496     if (!D.DL)
497       return true;
498 
499     // Next optional token: @
500     SourceLocation ExpectedLoc;
501     StringRef Marker;
502     bool MatchAnyFileAndLine = false;
503     bool MatchAnyLine = false;
504     if (!PH.Next("@")) {
505       ExpectedLoc = Pos;
506     } else {
507       PH.Advance();
508       unsigned Line = 0;
509       bool FoundPlus = PH.Next("+");
510       if (FoundPlus || PH.Next("-")) {
511         // Relative to current line.
512         PH.Advance();
513         bool Invalid = false;
514         unsigned ExpectedLine = SM.getSpellingLineNumber(Pos, &Invalid);
515         if (!Invalid && PH.Next(Line) && (FoundPlus || Line < ExpectedLine)) {
516           if (FoundPlus) ExpectedLine += Line;
517           else ExpectedLine -= Line;
518           ExpectedLoc = SM.translateLineCol(SM.getFileID(Pos), ExpectedLine, 1);
519         }
520       } else if (PH.Next(Line)) {
521         // Absolute line number.
522         if (Line > 0)
523           ExpectedLoc = SM.translateLineCol(SM.getFileID(Pos), Line, 1);
524       } else if (PH.NextMarker()) {
525         Marker = PH.Match();
526       } else if (PP && PH.Search(":")) {
527         // Specific source file.
528         StringRef Filename(PH.C, PH.P-PH.C);
529         PH.Advance();
530 
531         if (Filename == "*") {
532           MatchAnyFileAndLine = true;
533           if (!PH.Next("*")) {
534             Diags.Report(Pos.getLocWithOffset(PH.C - PH.Begin),
535                          diag::err_verify_missing_line)
536                 << "'*'";
537             continue;
538           }
539           MatchAnyLine = true;
540           ExpectedLoc = SourceLocation();
541         } else {
542           // Lookup file via Preprocessor, like a #include.
543           OptionalFileEntryRef File =
544               PP->LookupFile(Pos, Filename, false, nullptr, nullptr, nullptr,
545                              nullptr, nullptr, nullptr, nullptr, nullptr);
546           if (!File) {
547             Diags.Report(Pos.getLocWithOffset(PH.C - PH.Begin),
548                          diag::err_verify_missing_file)
549                 << Filename << KindStr;
550             continue;
551           }
552 
553           FileID FID = SM.translateFile(*File);
554           if (FID.isInvalid())
555             FID = SM.createFileID(*File, Pos, SrcMgr::C_User);
556 
557           if (PH.Next(Line) && Line > 0)
558             ExpectedLoc = SM.translateLineCol(FID, Line, 1);
559           else if (PH.Next("*")) {
560             MatchAnyLine = true;
561             ExpectedLoc = SM.translateLineCol(FID, 1, 1);
562           }
563         }
564       } else if (PH.Next("*")) {
565         MatchAnyLine = true;
566         ExpectedLoc = SourceLocation();
567       }
568 
569       if (ExpectedLoc.isInvalid() && !MatchAnyLine && Marker.empty()) {
570         Diags.Report(Pos.getLocWithOffset(PH.C-PH.Begin),
571                      diag::err_verify_missing_line) << KindStr;
572         continue;
573       }
574       PH.Advance();
575     }
576 
577     // Skip optional whitespace.
578     PH.SkipWhitespace();
579 
580     // Next optional token: positive integer or a '+'.
581     if (PH.Next(D.Min)) {
582       PH.Advance();
583       // A positive integer can be followed by a '+' meaning min
584       // or more, or by a '-' meaning a range from min to max.
585       if (PH.Next("+")) {
586         D.Max = Directive::MaxCount;
587         PH.Advance();
588       } else if (PH.Next("-")) {
589         PH.Advance();
590         if (!PH.Next(D.Max) || D.Max < D.Min) {
591           Diags.Report(Pos.getLocWithOffset(PH.C-PH.Begin),
592                        diag::err_verify_invalid_range) << KindStr;
593           continue;
594         }
595         PH.Advance();
596       } else {
597         D.Max = D.Min;
598       }
599     } else if (PH.Next("+")) {
600       // '+' on its own means "1 or more".
601       D.Max = Directive::MaxCount;
602       PH.Advance();
603     }
604 
605     // Skip optional whitespace.
606     PH.SkipWhitespace();
607 
608     // Next token: {{
609     if (!PH.Next("{{")) {
610       Diags.Report(Pos.getLocWithOffset(PH.C-PH.Begin),
611                    diag::err_verify_missing_start) << KindStr;
612       continue;
613     }
614     llvm::SmallString<8> CloseBrace("}}");
615     const char *const DelimBegin = PH.C;
616     PH.Advance();
617     // Count the number of opening braces for `string` kinds
618     for (; !D.RegexKind && PH.Next("{"); PH.Advance())
619       CloseBrace += '}';
620     const char* const ContentBegin = PH.C; // mark content begin
621     // Search for closing brace
622     StringRef OpenBrace(DelimBegin, ContentBegin - DelimBegin);
623     if (!PH.SearchClosingBrace(OpenBrace, CloseBrace)) {
624       Diags.Report(Pos.getLocWithOffset(PH.C - PH.Begin),
625                    diag::err_verify_missing_end)
626           << KindStr << CloseBrace;
627       continue;
628     }
629     const char* const ContentEnd = PH.P; // mark content end
630     PH.Advance();
631 
632     D.DirectivePos = Pos;
633     D.ContentBegin = Pos.getLocWithOffset(ContentBegin - PH.Begin);
634 
635     // Build directive text; convert \n to newlines.
636     StringRef NewlineStr = "\\n";
637     StringRef Content(ContentBegin, ContentEnd-ContentBegin);
638     size_t CPos = 0;
639     size_t FPos;
640     while ((FPos = Content.find(NewlineStr, CPos)) != StringRef::npos) {
641       D.Text += Content.substr(CPos, FPos-CPos);
642       D.Text += '\n';
643       CPos = FPos + NewlineStr.size();
644     }
645     if (D.Text.empty())
646       D.Text.assign(ContentBegin, ContentEnd);
647 
648     // Check that regex directives contain at least one regex.
649     if (D.RegexKind && D.Text.find("{{") == StringRef::npos) {
650       Diags.Report(D.ContentBegin, diag::err_verify_missing_regex) << D.Text;
651       return false;
652     }
653 
654     if (Marker.empty())
655       attachDirective(Diags, D, ExpectedLoc, MatchAnyFileAndLine, MatchAnyLine);
656     else
657       Markers.addDirective(Marker, D);
658     FoundDirective = true;
659   }
660 
661   return FoundDirective;
662 }
663 
VerifyDiagnosticConsumer(DiagnosticsEngine & Diags_)664 VerifyDiagnosticConsumer::VerifyDiagnosticConsumer(DiagnosticsEngine &Diags_)
665     : Diags(Diags_), PrimaryClient(Diags.getClient()),
666       PrimaryClientOwner(Diags.takeClient()),
667       Buffer(new TextDiagnosticBuffer()), Markers(new MarkerTracker(Diags)),
668       Status(HasNoDirectives) {
669   if (Diags.hasSourceManager())
670     setSourceManager(Diags.getSourceManager());
671 }
672 
~VerifyDiagnosticConsumer()673 VerifyDiagnosticConsumer::~VerifyDiagnosticConsumer() {
674   assert(!ActiveSourceFiles && "Incomplete parsing of source files!");
675   assert(!CurrentPreprocessor && "CurrentPreprocessor should be invalid!");
676   SrcManager = nullptr;
677   CheckDiagnostics();
678   assert(!Diags.ownsClient() &&
679          "The VerifyDiagnosticConsumer takes over ownership of the client!");
680 }
681 
682 // DiagnosticConsumer interface.
683 
BeginSourceFile(const LangOptions & LangOpts,const Preprocessor * PP)684 void VerifyDiagnosticConsumer::BeginSourceFile(const LangOptions &LangOpts,
685                                                const Preprocessor *PP) {
686   // Attach comment handler on first invocation.
687   if (++ActiveSourceFiles == 1) {
688     if (PP) {
689       CurrentPreprocessor = PP;
690       this->LangOpts = &LangOpts;
691       setSourceManager(PP->getSourceManager());
692       const_cast<Preprocessor *>(PP)->addCommentHandler(this);
693 #ifndef NDEBUG
694       // Debug build tracks parsed files.
695       const_cast<Preprocessor *>(PP)->addPPCallbacks(
696                       std::make_unique<VerifyFileTracker>(*this, *SrcManager));
697 #endif
698     }
699   }
700 
701   assert((!PP || CurrentPreprocessor == PP) && "Preprocessor changed!");
702   PrimaryClient->BeginSourceFile(LangOpts, PP);
703 }
704 
EndSourceFile()705 void VerifyDiagnosticConsumer::EndSourceFile() {
706   assert(ActiveSourceFiles && "No active source files!");
707   PrimaryClient->EndSourceFile();
708 
709   // Detach comment handler once last active source file completed.
710   if (--ActiveSourceFiles == 0) {
711     if (CurrentPreprocessor)
712       const_cast<Preprocessor *>(CurrentPreprocessor)->
713           removeCommentHandler(this);
714 
715     // Diagnose any used-but-not-defined markers.
716     Markers->finalize();
717 
718     // Check diagnostics once last file completed.
719     CheckDiagnostics();
720     CurrentPreprocessor = nullptr;
721     LangOpts = nullptr;
722   }
723 }
724 
HandleDiagnostic(DiagnosticsEngine::Level DiagLevel,const Diagnostic & Info)725 void VerifyDiagnosticConsumer::HandleDiagnostic(
726       DiagnosticsEngine::Level DiagLevel, const Diagnostic &Info) {
727   if (Info.hasSourceManager()) {
728     // If this diagnostic is for a different source manager, ignore it.
729     if (SrcManager && &Info.getSourceManager() != SrcManager)
730       return;
731 
732     setSourceManager(Info.getSourceManager());
733   }
734 
735 #ifndef NDEBUG
736   // Debug build tracks unparsed files for possible
737   // unparsed expected-* directives.
738   if (SrcManager) {
739     SourceLocation Loc = Info.getLocation();
740     if (Loc.isValid()) {
741       ParsedStatus PS = IsUnparsed;
742 
743       Loc = SrcManager->getExpansionLoc(Loc);
744       FileID FID = SrcManager->getFileID(Loc);
745 
746       auto FE = SrcManager->getFileEntryRefForID(FID);
747       if (FE && CurrentPreprocessor && SrcManager->isLoadedFileID(FID)) {
748         // If the file is a modules header file it shall not be parsed
749         // for expected-* directives.
750         HeaderSearch &HS = CurrentPreprocessor->getHeaderSearchInfo();
751         if (HS.findModuleForHeader(*FE))
752           PS = IsUnparsedNoDirectives;
753       }
754 
755       UpdateParsedFileStatus(*SrcManager, FID, PS);
756     }
757   }
758 #endif
759 
760   // Send the diagnostic to the buffer, we will check it once we reach the end
761   // of the source file (or are destructed).
762   Buffer->HandleDiagnostic(DiagLevel, Info);
763 }
764 
765 /// HandleComment - Hook into the preprocessor and extract comments containing
766 ///  expected errors and warnings.
HandleComment(Preprocessor & PP,SourceRange Comment)767 bool VerifyDiagnosticConsumer::HandleComment(Preprocessor &PP,
768                                              SourceRange Comment) {
769   SourceManager &SM = PP.getSourceManager();
770 
771   // If this comment is for a different source manager, ignore it.
772   if (SrcManager && &SM != SrcManager)
773     return false;
774 
775   SourceLocation CommentBegin = Comment.getBegin();
776 
777   const char *CommentRaw = SM.getCharacterData(CommentBegin);
778   StringRef C(CommentRaw, SM.getCharacterData(Comment.getEnd()) - CommentRaw);
779 
780   if (C.empty())
781     return false;
782 
783   // Fold any "\<EOL>" sequences
784   size_t loc = C.find('\\');
785   if (loc == StringRef::npos) {
786     ParseDirective(C, &ED, SM, &PP, CommentBegin, Status, *Markers);
787     return false;
788   }
789 
790   std::string C2;
791   C2.reserve(C.size());
792 
793   for (size_t last = 0;; loc = C.find('\\', last)) {
794     if (loc == StringRef::npos || loc == C.size()) {
795       C2 += C.substr(last);
796       break;
797     }
798     C2 += C.substr(last, loc-last);
799     last = loc + 1;
800 
801     if (C[last] == '\n' || C[last] == '\r') {
802       ++last;
803 
804       // Escape \r\n  or \n\r, but not \n\n.
805       if (last < C.size())
806         if (C[last] == '\n' || C[last] == '\r')
807           if (C[last] != C[last-1])
808             ++last;
809     } else {
810       // This was just a normal backslash.
811       C2 += '\\';
812     }
813   }
814 
815   if (!C2.empty())
816     ParseDirective(C2, &ED, SM, &PP, CommentBegin, Status, *Markers);
817   return false;
818 }
819 
820 #ifndef NDEBUG
821 /// Lex the specified source file to determine whether it contains
822 /// any expected-* directives.  As a Lexer is used rather than a full-blown
823 /// Preprocessor, directives inside skipped #if blocks will still be found.
824 ///
825 /// \return true if any directives were found.
findDirectives(SourceManager & SM,FileID FID,const LangOptions & LangOpts)826 static bool findDirectives(SourceManager &SM, FileID FID,
827                            const LangOptions &LangOpts) {
828   // Create a raw lexer to pull all the comments out of FID.
829   if (FID.isInvalid())
830     return false;
831 
832   // Create a lexer to lex all the tokens of the main file in raw mode.
833   llvm::MemoryBufferRef FromFile = SM.getBufferOrFake(FID);
834   Lexer RawLex(FID, FromFile, SM, LangOpts);
835 
836   // Return comments as tokens, this is how we find expected diagnostics.
837   RawLex.SetCommentRetentionState(true);
838 
839   Token Tok;
840   Tok.setKind(tok::comment);
841   VerifyDiagnosticConsumer::DirectiveStatus Status =
842     VerifyDiagnosticConsumer::HasNoDirectives;
843   while (Tok.isNot(tok::eof)) {
844     RawLex.LexFromRawLexer(Tok);
845     if (!Tok.is(tok::comment)) continue;
846 
847     std::string Comment = RawLex.getSpelling(Tok, SM, LangOpts);
848     if (Comment.empty()) continue;
849 
850     // We don't care about tracking markers for this phase.
851     VerifyDiagnosticConsumer::MarkerTracker Markers(SM.getDiagnostics());
852 
853     // Find first directive.
854     if (ParseDirective(Comment, nullptr, SM, nullptr, Tok.getLocation(),
855                        Status, Markers))
856       return true;
857   }
858   return false;
859 }
860 #endif // !NDEBUG
861 
862 /// Takes a list of diagnostics that have been generated but not matched
863 /// by an expected-* directive and produces a diagnostic to the user from this.
PrintUnexpected(DiagnosticsEngine & Diags,SourceManager * SourceMgr,const_diag_iterator diag_begin,const_diag_iterator diag_end,const char * Kind)864 static unsigned PrintUnexpected(DiagnosticsEngine &Diags, SourceManager *SourceMgr,
865                                 const_diag_iterator diag_begin,
866                                 const_diag_iterator diag_end,
867                                 const char *Kind) {
868   if (diag_begin == diag_end) return 0;
869 
870   SmallString<256> Fmt;
871   llvm::raw_svector_ostream OS(Fmt);
872   for (const_diag_iterator I = diag_begin, E = diag_end; I != E; ++I) {
873     if (I->first.isInvalid() || !SourceMgr)
874       OS << "\n  (frontend)";
875     else {
876       OS << "\n ";
877       if (OptionalFileEntryRef File =
878               SourceMgr->getFileEntryRefForID(SourceMgr->getFileID(I->first)))
879         OS << " File " << File->getName();
880       OS << " Line " << SourceMgr->getPresumedLineNumber(I->first);
881     }
882     OS << ": " << I->second;
883   }
884 
885   std::string Prefix = *Diags.getDiagnosticOptions().VerifyPrefixes.begin();
886   std::string KindStr = Prefix + "-" + Kind;
887   Diags.Report(diag::err_verify_inconsistent_diags).setForceEmit()
888       << KindStr << /*Unexpected=*/true << OS.str();
889   return std::distance(diag_begin, diag_end);
890 }
891 
892 /// Takes a list of diagnostics that were expected to have been generated
893 /// but were not and produces a diagnostic to the user from this.
PrintExpected(DiagnosticsEngine & Diags,SourceManager & SourceMgr,std::vector<Directive * > & DL,const char * Kind)894 static unsigned PrintExpected(DiagnosticsEngine &Diags,
895                               SourceManager &SourceMgr,
896                               std::vector<Directive *> &DL, const char *Kind) {
897   if (DL.empty())
898     return 0;
899 
900   SmallString<256> Fmt;
901   llvm::raw_svector_ostream OS(Fmt);
902   for (const auto *D : DL) {
903     if (D->DiagnosticLoc.isInvalid() || D->MatchAnyFileAndLine)
904       OS << "\n  File *";
905     else
906       OS << "\n  File " << SourceMgr.getFilename(D->DiagnosticLoc);
907     if (D->MatchAnyLine)
908       OS << " Line *";
909     else
910       OS << " Line " << SourceMgr.getPresumedLineNumber(D->DiagnosticLoc);
911     if (D->DirectiveLoc != D->DiagnosticLoc)
912       OS << " (directive at "
913          << SourceMgr.getFilename(D->DirectiveLoc) << ':'
914          << SourceMgr.getPresumedLineNumber(D->DirectiveLoc) << ')';
915     OS << ": " << D->Text;
916   }
917 
918   std::string Prefix = *Diags.getDiagnosticOptions().VerifyPrefixes.begin();
919   std::string KindStr = Prefix + "-" + Kind;
920   Diags.Report(diag::err_verify_inconsistent_diags).setForceEmit()
921       << KindStr << /*Unexpected=*/false << OS.str();
922   return DL.size();
923 }
924 
925 /// Determine whether two source locations come from the same file.
IsFromSameFile(SourceManager & SM,SourceLocation DirectiveLoc,SourceLocation DiagnosticLoc)926 static bool IsFromSameFile(SourceManager &SM, SourceLocation DirectiveLoc,
927                            SourceLocation DiagnosticLoc) {
928   while (DiagnosticLoc.isMacroID())
929     DiagnosticLoc = SM.getImmediateMacroCallerLoc(DiagnosticLoc);
930 
931   if (SM.isWrittenInSameFile(DirectiveLoc, DiagnosticLoc))
932     return true;
933 
934   const FileEntry *DiagFile = SM.getFileEntryForID(SM.getFileID(DiagnosticLoc));
935   if (!DiagFile && SM.isWrittenInMainFile(DirectiveLoc))
936     return true;
937 
938   return (DiagFile == SM.getFileEntryForID(SM.getFileID(DirectiveLoc)));
939 }
940 
941 /// CheckLists - Compare expected to seen diagnostic lists and return the
942 /// the difference between them.
CheckLists(DiagnosticsEngine & Diags,SourceManager & SourceMgr,const char * Label,DirectiveList & Left,const_diag_iterator d2_begin,const_diag_iterator d2_end,bool IgnoreUnexpected)943 static unsigned CheckLists(DiagnosticsEngine &Diags, SourceManager &SourceMgr,
944                            const char *Label,
945                            DirectiveList &Left,
946                            const_diag_iterator d2_begin,
947                            const_diag_iterator d2_end,
948                            bool IgnoreUnexpected) {
949   std::vector<Directive *> LeftOnly;
950   DiagList Right(d2_begin, d2_end);
951 
952   for (auto &Owner : Left) {
953     Directive &D = *Owner;
954     unsigned LineNo1 = SourceMgr.getPresumedLineNumber(D.DiagnosticLoc);
955 
956     for (unsigned i = 0; i < D.Max; ++i) {
957       DiagList::iterator II, IE;
958       for (II = Right.begin(), IE = Right.end(); II != IE; ++II) {
959         if (!D.MatchAnyLine) {
960           unsigned LineNo2 = SourceMgr.getPresumedLineNumber(II->first);
961           if (LineNo1 != LineNo2)
962             continue;
963         }
964 
965         if (!D.DiagnosticLoc.isInvalid() && !D.MatchAnyFileAndLine &&
966             !IsFromSameFile(SourceMgr, D.DiagnosticLoc, II->first))
967           continue;
968 
969         const std::string &RightText = II->second;
970         if (D.match(RightText))
971           break;
972       }
973       if (II == IE) {
974         // Not found.
975         if (i >= D.Min) break;
976         LeftOnly.push_back(&D);
977       } else {
978         // Found. The same cannot be found twice.
979         Right.erase(II);
980       }
981     }
982   }
983   // Now all that's left in Right are those that were not matched.
984   unsigned num = PrintExpected(Diags, SourceMgr, LeftOnly, Label);
985   if (!IgnoreUnexpected)
986     num += PrintUnexpected(Diags, &SourceMgr, Right.begin(), Right.end(), Label);
987   return num;
988 }
989 
990 /// CheckResults - This compares the expected results to those that
991 /// were actually reported. It emits any discrepencies. Return "true" if there
992 /// were problems. Return "false" otherwise.
CheckResults(DiagnosticsEngine & Diags,SourceManager & SourceMgr,const TextDiagnosticBuffer & Buffer,ExpectedData & ED)993 static unsigned CheckResults(DiagnosticsEngine &Diags, SourceManager &SourceMgr,
994                              const TextDiagnosticBuffer &Buffer,
995                              ExpectedData &ED) {
996   // We want to capture the delta between what was expected and what was
997   // seen.
998   //
999   //   Expected \ Seen - set expected but not seen
1000   //   Seen \ Expected - set seen but not expected
1001   unsigned NumProblems = 0;
1002 
1003   const DiagnosticLevelMask DiagMask =
1004     Diags.getDiagnosticOptions().getVerifyIgnoreUnexpected();
1005 
1006   // See if there are error mismatches.
1007   NumProblems += CheckLists(Diags, SourceMgr, "error", ED.Errors,
1008                             Buffer.err_begin(), Buffer.err_end(),
1009                             bool(DiagnosticLevelMask::Error & DiagMask));
1010 
1011   // See if there are warning mismatches.
1012   NumProblems += CheckLists(Diags, SourceMgr, "warning", ED.Warnings,
1013                             Buffer.warn_begin(), Buffer.warn_end(),
1014                             bool(DiagnosticLevelMask::Warning & DiagMask));
1015 
1016   // See if there are remark mismatches.
1017   NumProblems += CheckLists(Diags, SourceMgr, "remark", ED.Remarks,
1018                             Buffer.remark_begin(), Buffer.remark_end(),
1019                             bool(DiagnosticLevelMask::Remark & DiagMask));
1020 
1021   // See if there are note mismatches.
1022   NumProblems += CheckLists(Diags, SourceMgr, "note", ED.Notes,
1023                             Buffer.note_begin(), Buffer.note_end(),
1024                             bool(DiagnosticLevelMask::Note & DiagMask));
1025 
1026   return NumProblems;
1027 }
1028 
UpdateParsedFileStatus(SourceManager & SM,FileID FID,ParsedStatus PS)1029 void VerifyDiagnosticConsumer::UpdateParsedFileStatus(SourceManager &SM,
1030                                                       FileID FID,
1031                                                       ParsedStatus PS) {
1032   // Check SourceManager hasn't changed.
1033   setSourceManager(SM);
1034 
1035 #ifndef NDEBUG
1036   if (FID.isInvalid())
1037     return;
1038 
1039   OptionalFileEntryRef FE = SM.getFileEntryRefForID(FID);
1040 
1041   if (PS == IsParsed) {
1042     // Move the FileID from the unparsed set to the parsed set.
1043     UnparsedFiles.erase(FID);
1044     ParsedFiles.insert(std::make_pair(FID, FE ? &FE->getFileEntry() : nullptr));
1045   } else if (!ParsedFiles.count(FID) && !UnparsedFiles.count(FID)) {
1046     // Add the FileID to the unparsed set if we haven't seen it before.
1047 
1048     // Check for directives.
1049     bool FoundDirectives;
1050     if (PS == IsUnparsedNoDirectives)
1051       FoundDirectives = false;
1052     else
1053       FoundDirectives = !LangOpts || findDirectives(SM, FID, *LangOpts);
1054 
1055     // Add the FileID to the unparsed set.
1056     UnparsedFiles.insert(std::make_pair(FID,
1057                                       UnparsedFileStatus(FE, FoundDirectives)));
1058   }
1059 #endif
1060 }
1061 
CheckDiagnostics()1062 void VerifyDiagnosticConsumer::CheckDiagnostics() {
1063   // Ensure any diagnostics go to the primary client.
1064   DiagnosticConsumer *CurClient = Diags.getClient();
1065   std::unique_ptr<DiagnosticConsumer> Owner = Diags.takeClient();
1066   Diags.setClient(PrimaryClient, false);
1067 
1068 #ifndef NDEBUG
1069   // In a debug build, scan through any files that may have been missed
1070   // during parsing and issue a fatal error if directives are contained
1071   // within these files.  If a fatal error occurs, this suggests that
1072   // this file is being parsed separately from the main file, in which
1073   // case consider moving the directives to the correct place, if this
1074   // is applicable.
1075   if (!UnparsedFiles.empty()) {
1076     // Generate a cache of parsed FileEntry pointers for alias lookups.
1077     llvm::SmallPtrSet<const FileEntry *, 8> ParsedFileCache;
1078     for (const auto &I : ParsedFiles)
1079       if (const FileEntry *FE = I.second)
1080         ParsedFileCache.insert(FE);
1081 
1082     // Iterate through list of unparsed files.
1083     for (const auto &I : UnparsedFiles) {
1084       const UnparsedFileStatus &Status = I.second;
1085       OptionalFileEntryRef FE = Status.getFile();
1086 
1087       // Skip files that have been parsed via an alias.
1088       if (FE && ParsedFileCache.count(*FE))
1089         continue;
1090 
1091       // Report a fatal error if this file contained directives.
1092       if (Status.foundDirectives()) {
1093         llvm::report_fatal_error("-verify directives found after rather"
1094                                  " than during normal parsing of " +
1095                                  (FE ? FE->getName() : "(unknown)"));
1096       }
1097     }
1098 
1099     // UnparsedFiles has been processed now, so clear it.
1100     UnparsedFiles.clear();
1101   }
1102 #endif // !NDEBUG
1103 
1104   if (SrcManager) {
1105     // Produce an error if no expected-* directives could be found in the
1106     // source file(s) processed.
1107     if (Status == HasNoDirectives) {
1108       Diags.Report(diag::err_verify_no_directives).setForceEmit();
1109       ++NumErrors;
1110       Status = HasNoDirectivesReported;
1111     }
1112 
1113     // Check that the expected diagnostics occurred.
1114     NumErrors += CheckResults(Diags, *SrcManager, *Buffer, ED);
1115   } else {
1116     const DiagnosticLevelMask DiagMask =
1117         ~Diags.getDiagnosticOptions().getVerifyIgnoreUnexpected();
1118     if (bool(DiagnosticLevelMask::Error & DiagMask))
1119       NumErrors += PrintUnexpected(Diags, nullptr, Buffer->err_begin(),
1120                                    Buffer->err_end(), "error");
1121     if (bool(DiagnosticLevelMask::Warning & DiagMask))
1122       NumErrors += PrintUnexpected(Diags, nullptr, Buffer->warn_begin(),
1123                                    Buffer->warn_end(), "warn");
1124     if (bool(DiagnosticLevelMask::Remark & DiagMask))
1125       NumErrors += PrintUnexpected(Diags, nullptr, Buffer->remark_begin(),
1126                                    Buffer->remark_end(), "remark");
1127     if (bool(DiagnosticLevelMask::Note & DiagMask))
1128       NumErrors += PrintUnexpected(Diags, nullptr, Buffer->note_begin(),
1129                                    Buffer->note_end(), "note");
1130   }
1131 
1132   Diags.setClient(CurClient, Owner.release() != nullptr);
1133 
1134   // Reset the buffer, we have processed all the diagnostics in it.
1135   Buffer.reset(new TextDiagnosticBuffer());
1136   ED.Reset();
1137 }
1138 
create(bool RegexKind,SourceLocation DirectiveLoc,SourceLocation DiagnosticLoc,bool MatchAnyFileAndLine,bool MatchAnyLine,StringRef Text,unsigned Min,unsigned Max)1139 std::unique_ptr<Directive> Directive::create(bool RegexKind,
1140                                              SourceLocation DirectiveLoc,
1141                                              SourceLocation DiagnosticLoc,
1142                                              bool MatchAnyFileAndLine,
1143                                              bool MatchAnyLine, StringRef Text,
1144                                              unsigned Min, unsigned Max) {
1145   if (!RegexKind)
1146     return std::make_unique<StandardDirective>(DirectiveLoc, DiagnosticLoc,
1147                                                MatchAnyFileAndLine,
1148                                                MatchAnyLine, Text, Min, Max);
1149 
1150   // Parse the directive into a regular expression.
1151   std::string RegexStr;
1152   StringRef S = Text;
1153   while (!S.empty()) {
1154     if (S.consume_front("{{")) {
1155       size_t RegexMatchLength = S.find("}}");
1156       assert(RegexMatchLength != StringRef::npos);
1157       // Append the regex, enclosed in parentheses.
1158       RegexStr += "(";
1159       RegexStr.append(S.data(), RegexMatchLength);
1160       RegexStr += ")";
1161       S = S.drop_front(RegexMatchLength + 2);
1162     } else {
1163       size_t VerbatimMatchLength = S.find("{{");
1164       if (VerbatimMatchLength == StringRef::npos)
1165         VerbatimMatchLength = S.size();
1166       // Escape and append the fixed string.
1167       RegexStr += llvm::Regex::escape(S.substr(0, VerbatimMatchLength));
1168       S = S.drop_front(VerbatimMatchLength);
1169     }
1170   }
1171 
1172   return std::make_unique<RegexDirective>(DirectiveLoc, DiagnosticLoc,
1173                                           MatchAnyFileAndLine, MatchAnyLine,
1174                                           Text, Min, Max, RegexStr);
1175 }
1176