1 // error-pattern:cargo-clippy
2 
3 #![feature(box_patterns)]
4 #![feature(drain_filter)]
5 #![feature(in_band_lifetimes)]
6 #![feature(iter_zip)]
7 #![feature(once_cell)]
8 #![feature(rustc_private)]
9 #![feature(stmt_expr_attributes)]
10 #![feature(control_flow_enum)]
11 #![recursion_limit = "512"]
12 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
13 #![allow(clippy::missing_docs_in_private_items, clippy::must_use_candidate)]
14 #![warn(trivial_casts, trivial_numeric_casts)]
15 // warn on lints, that are included in `rust-lang/rust`s bootstrap
16 #![warn(rust_2018_idioms, unused_lifetimes)]
17 // warn on rustc internal lints
18 #![warn(rustc::internal)]
19 
20 // FIXME: switch to something more ergonomic here, once available.
21 // (Currently there is no way to opt into sysroot crates without `extern crate`.)
22 extern crate rustc_ast;
23 extern crate rustc_ast_pretty;
24 extern crate rustc_data_structures;
25 extern crate rustc_driver;
26 extern crate rustc_errors;
27 extern crate rustc_hir;
28 extern crate rustc_hir_pretty;
29 extern crate rustc_index;
30 extern crate rustc_infer;
31 extern crate rustc_lexer;
32 extern crate rustc_lint;
33 extern crate rustc_middle;
34 extern crate rustc_mir_dataflow;
35 extern crate rustc_parse;
36 extern crate rustc_parse_format;
37 extern crate rustc_session;
38 extern crate rustc_span;
39 extern crate rustc_target;
40 extern crate rustc_trait_selection;
41 extern crate rustc_typeck;
42 
43 #[macro_use]
44 extern crate clippy_utils;
45 
46 use clippy_utils::parse_msrv;
47 use rustc_data_structures::fx::FxHashSet;
48 use rustc_lint::LintId;
49 use rustc_session::Session;
50 
51 /// Macro used to declare a Clippy lint.
52 ///
53 /// Every lint declaration consists of 4 parts:
54 ///
55 /// 1. The documentation, which is used for the website
56 /// 2. The `LINT_NAME`. See [lint naming][lint_naming] on lint naming conventions.
57 /// 3. The `lint_level`, which is a mapping from *one* of our lint groups to `Allow`, `Warn` or
58 ///    `Deny`. The lint level here has nothing to do with what lint groups the lint is a part of.
59 /// 4. The `description` that contains a short explanation on what's wrong with code where the
60 ///    lint is triggered.
61 ///
62 /// Currently the categories `style`, `correctness`, `suspicious`, `complexity` and `perf` are
63 /// enabled by default. As said in the README.md of this repository, if the lint level mapping
64 /// changes, please update README.md.
65 ///
66 /// # Example
67 ///
68 /// ```
69 /// #![feature(rustc_private)]
70 /// extern crate rustc_session;
71 /// use rustc_session::declare_tool_lint;
72 /// use clippy_lints::declare_clippy_lint;
73 ///
74 /// declare_clippy_lint! {
75 ///     /// ### What it does
76 ///     /// Checks for ... (describe what the lint matches).
77 ///     ///
78 ///     /// ### Why is this bad?
79 ///     /// Supply the reason for linting the code.
80 ///     ///
81 ///     /// ### Example
82 ///     /// ```rust
83 ///     /// // Bad
84 ///     /// Insert a short example of code that triggers the lint
85 ///     ///
86 ///     /// // Good
87 ///     /// Insert a short example of improved code that doesn't trigger the lint
88 ///     /// ```
89 ///     pub LINT_NAME,
90 ///     pedantic,
91 ///     "description"
92 /// }
93 /// ```
94 /// [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints
95 #[macro_export]
96 macro_rules! declare_clippy_lint {
97     { $(#[$attr:meta])* pub $name:tt, style, $description:tt } => {
98         declare_tool_lint! {
99             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
100         }
101     };
102     { $(#[$attr:meta])* pub $name:tt, correctness, $description:tt } => {
103         declare_tool_lint! {
104             $(#[$attr])* pub clippy::$name, Deny, $description, report_in_external_macro: true
105         }
106     };
107     { $(#[$attr:meta])* pub $name:tt, suspicious, $description:tt } => {
108         declare_tool_lint! {
109             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
110         }
111     };
112     { $(#[$attr:meta])* pub $name:tt, complexity, $description:tt } => {
113         declare_tool_lint! {
114             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
115         }
116     };
117     { $(#[$attr:meta])* pub $name:tt, perf, $description:tt } => {
118         declare_tool_lint! {
119             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
120         }
121     };
122     { $(#[$attr:meta])* pub $name:tt, pedantic, $description:tt } => {
123         declare_tool_lint! {
124             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
125         }
126     };
127     { $(#[$attr:meta])* pub $name:tt, restriction, $description:tt } => {
128         declare_tool_lint! {
129             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
130         }
131     };
132     { $(#[$attr:meta])* pub $name:tt, cargo, $description:tt } => {
133         declare_tool_lint! {
134             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
135         }
136     };
137     { $(#[$attr:meta])* pub $name:tt, nursery, $description:tt } => {
138         declare_tool_lint! {
139             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
140         }
141     };
142     { $(#[$attr:meta])* pub $name:tt, internal, $description:tt } => {
143         declare_tool_lint! {
144             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
145         }
146     };
147     { $(#[$attr:meta])* pub $name:tt, internal_warn, $description:tt } => {
148         declare_tool_lint! {
149             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
150         }
151     };
152 }
153 
154 #[cfg(feature = "metadata-collector-lint")]
155 mod deprecated_lints;
156 mod utils;
157 
158 // begin lints modules, do not remove this comment, it’s used in `update_lints`
159 mod absurd_extreme_comparisons;
160 mod approx_const;
161 mod arithmetic;
162 mod as_conversions;
163 mod asm_syntax;
164 mod assertions_on_constants;
165 mod assign_ops;
166 mod async_yields_async;
167 mod attrs;
168 mod await_holding_invalid;
169 mod bit_mask;
170 mod blacklisted_name;
171 mod blocks_in_if_conditions;
172 mod bool_assert_comparison;
173 mod booleans;
174 mod bytecount;
175 mod cargo_common_metadata;
176 mod case_sensitive_file_extension_comparisons;
177 mod casts;
178 mod checked_conversions;
179 mod cognitive_complexity;
180 mod collapsible_if;
181 mod collapsible_match;
182 mod comparison_chain;
183 mod copies;
184 mod copy_iterator;
185 mod create_dir;
186 mod dbg_macro;
187 mod default;
188 mod default_numeric_fallback;
189 mod dereference;
190 mod derivable_impls;
191 mod derive;
192 mod disallowed_method;
193 mod disallowed_script_idents;
194 mod disallowed_type;
195 mod doc;
196 mod double_comparison;
197 mod double_parens;
198 mod drop_forget_ref;
199 mod duration_subsec;
200 mod else_if_without_else;
201 mod empty_enum;
202 mod entry;
203 mod enum_clike;
204 mod enum_variants;
205 mod eq_op;
206 mod equatable_if_let;
207 mod erasing_op;
208 mod escape;
209 mod eta_reduction;
210 mod eval_order_dependence;
211 mod excessive_bools;
212 mod exhaustive_items;
213 mod exit;
214 mod explicit_write;
215 mod fallible_impl_from;
216 mod feature_name;
217 mod float_equality_without_abs;
218 mod float_literal;
219 mod floating_point_arithmetic;
220 mod format;
221 mod format_args;
222 mod formatting;
223 mod from_over_into;
224 mod from_str_radix_10;
225 mod functions;
226 mod future_not_send;
227 mod get_last_with_len;
228 mod identity_op;
229 mod if_let_mutex;
230 mod if_not_else;
231 mod if_then_some_else_none;
232 mod implicit_hasher;
233 mod implicit_return;
234 mod implicit_saturating_sub;
235 mod inconsistent_struct_constructor;
236 mod indexing_slicing;
237 mod infinite_iter;
238 mod inherent_impl;
239 mod inherent_to_string;
240 mod inline_fn_without_body;
241 mod int_plus_one;
242 mod integer_division;
243 mod invalid_upcast_comparisons;
244 mod items_after_statements;
245 mod iter_not_returning_iterator;
246 mod large_const_arrays;
247 mod large_enum_variant;
248 mod large_stack_arrays;
249 mod len_zero;
250 mod let_if_seq;
251 mod let_underscore;
252 mod lifetimes;
253 mod literal_representation;
254 mod loops;
255 mod macro_use;
256 mod main_recursion;
257 mod manual_assert;
258 mod manual_async_fn;
259 mod manual_map;
260 mod manual_non_exhaustive;
261 mod manual_ok_or;
262 mod manual_strip;
263 mod manual_unwrap_or;
264 mod map_clone;
265 mod map_err_ignore;
266 mod map_unit_fn;
267 mod match_on_vec_items;
268 mod match_result_ok;
269 mod match_str_case_mismatch;
270 mod matches;
271 mod mem_forget;
272 mod mem_replace;
273 mod methods;
274 mod minmax;
275 mod misc;
276 mod misc_early;
277 mod missing_const_for_fn;
278 mod missing_doc;
279 mod missing_enforced_import_rename;
280 mod missing_inline;
281 mod module_style;
282 mod modulo_arithmetic;
283 mod multiple_crate_versions;
284 mod mut_key;
285 mod mut_mut;
286 mod mut_mutex_lock;
287 mod mut_reference;
288 mod mutable_debug_assertion;
289 mod mutex_atomic;
290 mod needless_arbitrary_self_type;
291 mod needless_bitwise_bool;
292 mod needless_bool;
293 mod needless_borrow;
294 mod needless_borrowed_ref;
295 mod needless_continue;
296 mod needless_for_each;
297 mod needless_option_as_deref;
298 mod needless_pass_by_value;
299 mod needless_question_mark;
300 mod needless_update;
301 mod neg_cmp_op_on_partial_ord;
302 mod neg_multiply;
303 mod new_without_default;
304 mod no_effect;
305 mod non_copy_const;
306 mod non_expressive_names;
307 mod non_octal_unix_permissions;
308 mod non_send_fields_in_send_ty;
309 mod nonstandard_macro_braces;
310 mod open_options;
311 mod option_env_unwrap;
312 mod option_if_let_else;
313 mod overflow_check_conditional;
314 mod panic_in_result_fn;
315 mod panic_unimplemented;
316 mod partialeq_ne_impl;
317 mod pass_by_ref_or_value;
318 mod path_buf_push_overwrite;
319 mod pattern_type_mismatch;
320 mod precedence;
321 mod ptr;
322 mod ptr_eq;
323 mod ptr_offset_with_cast;
324 mod question_mark;
325 mod ranges;
326 mod redundant_clone;
327 mod redundant_closure_call;
328 mod redundant_else;
329 mod redundant_field_names;
330 mod redundant_pub_crate;
331 mod redundant_slicing;
332 mod redundant_static_lifetimes;
333 mod ref_option_ref;
334 mod reference;
335 mod regex;
336 mod repeat_once;
337 mod returns;
338 mod same_name_method;
339 mod self_assignment;
340 mod self_named_constructors;
341 mod semicolon_if_nothing_returned;
342 mod serde_api;
343 mod shadow;
344 mod single_component_path_imports;
345 mod size_of_in_element_count;
346 mod slow_vector_initialization;
347 mod stable_sort_primitive;
348 mod strings;
349 mod strlen_on_c_strings;
350 mod suspicious_operation_groupings;
351 mod suspicious_trait_impl;
352 mod swap;
353 mod tabs_in_doc_comments;
354 mod temporary_assignment;
355 mod to_digit_is_some;
356 mod to_string_in_display;
357 mod trailing_empty_array;
358 mod trait_bounds;
359 mod transmute;
360 mod transmuting_null;
361 mod try_err;
362 mod types;
363 mod undocumented_unsafe_blocks;
364 mod undropped_manually_drops;
365 mod unicode;
366 mod uninit_vec;
367 mod unit_hash;
368 mod unit_return_expecting_ord;
369 mod unit_types;
370 mod unnamed_address;
371 mod unnecessary_self_imports;
372 mod unnecessary_sort_by;
373 mod unnecessary_wraps;
374 mod unnested_or_patterns;
375 mod unsafe_removed_from_name;
376 mod unused_async;
377 mod unused_io_amount;
378 mod unused_self;
379 mod unused_unit;
380 mod unwrap;
381 mod unwrap_in_result;
382 mod upper_case_acronyms;
383 mod use_self;
384 mod useless_conversion;
385 mod vec;
386 mod vec_init_then_push;
387 mod vec_resize_to_zero;
388 mod verbose_file_reads;
389 mod wildcard_dependencies;
390 mod wildcard_imports;
391 mod write;
392 mod zero_div_zero;
393 mod zero_sized_map_values;
394 // end lints modules, do not remove this comment, it’s used in `update_lints`
395 
396 pub use crate::utils::conf::Conf;
397 use crate::utils::conf::TryConf;
398 
399 /// Register all pre expansion lints
400 ///
401 /// Pre-expansion lints run before any macro expansion has happened.
402 ///
403 /// Note that due to the architecture of the compiler, currently `cfg_attr` attributes on crate
404 /// level (i.e `#![cfg_attr(...)]`) will still be expanded even when using a pre-expansion pass.
405 ///
406 /// Used in `./src/driver.rs`.
register_pre_expansion_lints(store: &mut rustc_lint::LintStore)407 pub fn register_pre_expansion_lints(store: &mut rustc_lint::LintStore) {
408     // NOTE: Do not add any more pre-expansion passes. These should be removed eventually.
409     store.register_pre_expansion_pass(|| Box::new(write::Write::default()));
410     store.register_pre_expansion_pass(|| Box::new(attrs::EarlyAttributes));
411     store.register_pre_expansion_pass(|| Box::new(dbg_macro::DbgMacro));
412 }
413 
414 #[doc(hidden)]
read_conf(sess: &Session) -> Conf415 pub fn read_conf(sess: &Session) -> Conf {
416     let file_name = match utils::conf::lookup_conf_file() {
417         Ok(Some(path)) => path,
418         Ok(None) => return Conf::default(),
419         Err(error) => {
420             sess.struct_err(&format!("error finding Clippy's configuration file: {}", error))
421                 .emit();
422             return Conf::default();
423         },
424     };
425 
426     let TryConf { conf, errors } = utils::conf::read(&file_name);
427     // all conf errors are non-fatal, we just use the default conf in case of error
428     for error in errors {
429         sess.struct_err(&format!(
430             "error reading Clippy's configuration file `{}`: {}",
431             file_name.display(),
432             error
433         ))
434         .emit();
435     }
436 
437     conf
438 }
439 
440 /// Register all lints and lint groups with the rustc plugin registry
441 ///
442 /// Used in `./src/driver.rs`.
443 #[allow(clippy::too_many_lines)]
444 #[rustfmt::skip]
register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf)445 pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
446     register_removed_non_tool_lints(store);
447 
448     include!("lib.deprecated.rs");
449 
450     include!("lib.register_lints.rs");
451     include!("lib.register_restriction.rs");
452     include!("lib.register_pedantic.rs");
453 
454     #[cfg(feature = "internal-lints")]
455     include!("lib.register_internal.rs");
456 
457     include!("lib.register_all.rs");
458     include!("lib.register_style.rs");
459     include!("lib.register_complexity.rs");
460     include!("lib.register_correctness.rs");
461     include!("lib.register_suspicious.rs");
462     include!("lib.register_perf.rs");
463     include!("lib.register_cargo.rs");
464     include!("lib.register_nursery.rs");
465 
466     #[cfg(feature = "metadata-collector-lint")]
467     {
468         if std::env::var("ENABLE_METADATA_COLLECTION").eq(&Ok("1".to_string())) {
469             store.register_late_pass(|| Box::new(utils::internal_lints::metadata_collector::MetadataCollector::new()));
470             return;
471         }
472     }
473 
474     // all the internal lints
475     #[cfg(feature = "internal-lints")]
476     {
477         store.register_early_pass(|| Box::new(utils::internal_lints::ClippyLintsInternal));
478         store.register_early_pass(|| Box::new(utils::internal_lints::ProduceIce));
479         store.register_late_pass(|| Box::new(utils::inspector::DeepCodeInspector));
480         store.register_late_pass(|| Box::new(utils::internal_lints::CollapsibleCalls));
481         store.register_late_pass(|| Box::new(utils::internal_lints::CompilerLintFunctions::new()));
482         store.register_late_pass(|| Box::new(utils::internal_lints::IfChainStyle));
483         store.register_late_pass(|| Box::new(utils::internal_lints::InvalidPaths));
484         store.register_late_pass(|| Box::new(utils::internal_lints::InterningDefinedSymbol::default()));
485         store.register_late_pass(|| Box::new(utils::internal_lints::LintWithoutLintPass::default()));
486         store.register_late_pass(|| Box::new(utils::internal_lints::MatchTypeOnDiagItem));
487         store.register_late_pass(|| Box::new(utils::internal_lints::OuterExpnDataPass));
488     }
489 
490     store.register_late_pass(|| Box::new(utils::author::Author));
491     store.register_late_pass(|| Box::new(await_holding_invalid::AwaitHolding));
492     store.register_late_pass(|| Box::new(serde_api::SerdeApi));
493     let vec_box_size_threshold = conf.vec_box_size_threshold;
494     let type_complexity_threshold = conf.type_complexity_threshold;
495     let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
496     store.register_late_pass(move || Box::new(types::Types::new(
497         vec_box_size_threshold,
498         type_complexity_threshold,
499         avoid_breaking_exported_api,
500     )));
501     store.register_late_pass(|| Box::new(booleans::NonminimalBool));
502     store.register_late_pass(|| Box::new(needless_bitwise_bool::NeedlessBitwiseBool));
503     store.register_late_pass(|| Box::new(eq_op::EqOp));
504     store.register_late_pass(|| Box::new(enum_clike::UnportableVariant));
505     store.register_late_pass(|| Box::new(float_literal::FloatLiteral));
506     let verbose_bit_mask_threshold = conf.verbose_bit_mask_threshold;
507     store.register_late_pass(move || Box::new(bit_mask::BitMask::new(verbose_bit_mask_threshold)));
508     store.register_late_pass(|| Box::new(ptr::Ptr));
509     store.register_late_pass(|| Box::new(ptr_eq::PtrEq));
510     store.register_late_pass(|| Box::new(needless_bool::NeedlessBool));
511     store.register_late_pass(|| Box::new(needless_option_as_deref::OptionNeedlessDeref));
512     store.register_late_pass(|| Box::new(needless_bool::BoolComparison));
513     store.register_late_pass(|| Box::new(needless_for_each::NeedlessForEach));
514     store.register_late_pass(|| Box::new(misc::MiscLints));
515     store.register_late_pass(|| Box::new(eta_reduction::EtaReduction));
516     store.register_late_pass(|| Box::new(identity_op::IdentityOp));
517     store.register_late_pass(|| Box::new(erasing_op::ErasingOp));
518     store.register_late_pass(|| Box::new(mut_mut::MutMut));
519     store.register_late_pass(|| Box::new(mut_reference::UnnecessaryMutPassed));
520     store.register_late_pass(|| Box::new(len_zero::LenZero));
521     store.register_late_pass(|| Box::new(attrs::Attributes));
522     store.register_late_pass(|| Box::new(blocks_in_if_conditions::BlocksInIfConditions));
523     store.register_late_pass(|| Box::new(collapsible_match::CollapsibleMatch));
524     store.register_late_pass(|| Box::new(unicode::Unicode));
525     store.register_late_pass(|| Box::new(uninit_vec::UninitVec));
526     store.register_late_pass(|| Box::new(unit_hash::UnitHash));
527     store.register_late_pass(|| Box::new(unit_return_expecting_ord::UnitReturnExpectingOrd));
528     store.register_late_pass(|| Box::new(strings::StringAdd));
529     store.register_late_pass(|| Box::new(implicit_return::ImplicitReturn));
530     store.register_late_pass(|| Box::new(implicit_saturating_sub::ImplicitSaturatingSub));
531     store.register_late_pass(|| Box::new(default_numeric_fallback::DefaultNumericFallback));
532     store.register_late_pass(|| Box::new(inconsistent_struct_constructor::InconsistentStructConstructor));
533     store.register_late_pass(|| Box::new(non_octal_unix_permissions::NonOctalUnixPermissions));
534     store.register_early_pass(|| Box::new(unnecessary_self_imports::UnnecessarySelfImports));
535 
536     let msrv = conf.msrv.as_ref().and_then(|s| {
537         parse_msrv(s, None, None).or_else(|| {
538             sess.err(&format!("error reading Clippy's configuration file. `{}` is not a valid Rust version", s));
539             None
540         })
541     });
542 
543     let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
544     store.register_late_pass(move || Box::new(approx_const::ApproxConstant::new(msrv)));
545     store.register_late_pass(move || Box::new(methods::Methods::new(avoid_breaking_exported_api, msrv)));
546     store.register_late_pass(move || Box::new(matches::Matches::new(msrv)));
547     store.register_early_pass(move || Box::new(manual_non_exhaustive::ManualNonExhaustive::new(msrv)));
548     store.register_late_pass(move || Box::new(manual_strip::ManualStrip::new(msrv)));
549     store.register_early_pass(move || Box::new(redundant_static_lifetimes::RedundantStaticLifetimes::new(msrv)));
550     store.register_early_pass(move || Box::new(redundant_field_names::RedundantFieldNames::new(msrv)));
551     store.register_late_pass(move || Box::new(checked_conversions::CheckedConversions::new(msrv)));
552     store.register_late_pass(move || Box::new(mem_replace::MemReplace::new(msrv)));
553     store.register_late_pass(move || Box::new(ranges::Ranges::new(msrv)));
554     store.register_late_pass(move || Box::new(from_over_into::FromOverInto::new(msrv)));
555     store.register_late_pass(move || Box::new(use_self::UseSelf::new(msrv)));
556     store.register_late_pass(move || Box::new(missing_const_for_fn::MissingConstForFn::new(msrv)));
557     store.register_late_pass(move || Box::new(needless_question_mark::NeedlessQuestionMark));
558     store.register_late_pass(move || Box::new(casts::Casts::new(msrv)));
559     store.register_early_pass(move || Box::new(unnested_or_patterns::UnnestedOrPatterns::new(msrv)));
560 
561     store.register_late_pass(|| Box::new(size_of_in_element_count::SizeOfInElementCount));
562     store.register_late_pass(|| Box::new(same_name_method::SameNameMethod));
563     store.register_late_pass(|| Box::new(map_clone::MapClone));
564     store.register_late_pass(|| Box::new(map_err_ignore::MapErrIgnore));
565     store.register_late_pass(|| Box::new(shadow::Shadow::default()));
566     store.register_late_pass(|| Box::new(unit_types::UnitTypes));
567     store.register_late_pass(|| Box::new(loops::Loops));
568     store.register_late_pass(|| Box::new(main_recursion::MainRecursion::default()));
569     store.register_late_pass(|| Box::new(lifetimes::Lifetimes));
570     store.register_late_pass(|| Box::new(entry::HashMapPass));
571     store.register_late_pass(|| Box::new(minmax::MinMaxPass));
572     store.register_late_pass(|| Box::new(open_options::OpenOptions));
573     store.register_late_pass(|| Box::new(zero_div_zero::ZeroDiv));
574     store.register_late_pass(|| Box::new(mutex_atomic::Mutex));
575     store.register_late_pass(|| Box::new(needless_update::NeedlessUpdate));
576     store.register_late_pass(|| Box::new(needless_borrow::NeedlessBorrow::default()));
577     store.register_late_pass(|| Box::new(needless_borrowed_ref::NeedlessBorrowedRef));
578     store.register_late_pass(|| Box::new(no_effect::NoEffect));
579     store.register_late_pass(|| Box::new(temporary_assignment::TemporaryAssignment));
580     store.register_late_pass(|| Box::new(transmute::Transmute));
581     let cognitive_complexity_threshold = conf.cognitive_complexity_threshold;
582     store.register_late_pass(move || Box::new(cognitive_complexity::CognitiveComplexity::new(cognitive_complexity_threshold)));
583     let too_large_for_stack = conf.too_large_for_stack;
584     store.register_late_pass(move || Box::new(escape::BoxedLocal{too_large_for_stack}));
585     store.register_late_pass(move || Box::new(vec::UselessVec{too_large_for_stack}));
586     store.register_late_pass(|| Box::new(panic_unimplemented::PanicUnimplemented));
587     store.register_late_pass(|| Box::new(strings::StringLitAsBytes));
588     store.register_late_pass(|| Box::new(derive::Derive));
589     store.register_late_pass(|| Box::new(derivable_impls::DerivableImpls));
590     store.register_late_pass(|| Box::new(get_last_with_len::GetLastWithLen));
591     store.register_late_pass(|| Box::new(drop_forget_ref::DropForgetRef));
592     store.register_late_pass(|| Box::new(empty_enum::EmptyEnum));
593     store.register_late_pass(|| Box::new(absurd_extreme_comparisons::AbsurdExtremeComparisons));
594     store.register_late_pass(|| Box::new(invalid_upcast_comparisons::InvalidUpcastComparisons));
595     store.register_late_pass(|| Box::new(regex::Regex));
596     store.register_late_pass(|| Box::new(copies::CopyAndPaste));
597     store.register_late_pass(|| Box::new(copy_iterator::CopyIterator));
598     store.register_late_pass(|| Box::new(format::UselessFormat));
599     store.register_late_pass(|| Box::new(swap::Swap));
600     store.register_late_pass(|| Box::new(overflow_check_conditional::OverflowCheckConditional));
601     store.register_late_pass(|| Box::new(new_without_default::NewWithoutDefault::default()));
602     let blacklisted_names = conf.blacklisted_names.iter().cloned().collect::<FxHashSet<_>>();
603     store.register_late_pass(move || Box::new(blacklisted_name::BlacklistedName::new(blacklisted_names.clone())));
604     let too_many_arguments_threshold = conf.too_many_arguments_threshold;
605     let too_many_lines_threshold = conf.too_many_lines_threshold;
606     store.register_late_pass(move || Box::new(functions::Functions::new(too_many_arguments_threshold, too_many_lines_threshold)));
607     let doc_valid_idents = conf.doc_valid_idents.iter().cloned().collect::<FxHashSet<_>>();
608     store.register_late_pass(move || Box::new(doc::DocMarkdown::new(doc_valid_idents.clone())));
609     store.register_late_pass(|| Box::new(neg_multiply::NegMultiply));
610     store.register_late_pass(|| Box::new(mem_forget::MemForget));
611     store.register_late_pass(|| Box::new(arithmetic::Arithmetic::default()));
612     store.register_late_pass(|| Box::new(assign_ops::AssignOps));
613     store.register_late_pass(|| Box::new(let_if_seq::LetIfSeq));
614     store.register_late_pass(|| Box::new(eval_order_dependence::EvalOrderDependence));
615     store.register_late_pass(|| Box::new(missing_doc::MissingDoc::new()));
616     store.register_late_pass(|| Box::new(missing_inline::MissingInline));
617     store.register_late_pass(move || Box::new(exhaustive_items::ExhaustiveItems));
618     store.register_late_pass(|| Box::new(match_result_ok::MatchResultOk));
619     store.register_late_pass(|| Box::new(partialeq_ne_impl::PartialEqNeImpl));
620     store.register_late_pass(|| Box::new(unused_io_amount::UnusedIoAmount));
621     let enum_variant_size_threshold = conf.enum_variant_size_threshold;
622     store.register_late_pass(move || Box::new(large_enum_variant::LargeEnumVariant::new(enum_variant_size_threshold)));
623     store.register_late_pass(|| Box::new(explicit_write::ExplicitWrite));
624     store.register_late_pass(|| Box::new(needless_pass_by_value::NeedlessPassByValue));
625     let pass_by_ref_or_value = pass_by_ref_or_value::PassByRefOrValue::new(
626         conf.trivial_copy_size_limit,
627         conf.pass_by_value_size_limit,
628         conf.avoid_breaking_exported_api,
629         &sess.target,
630     );
631     store.register_late_pass(move || Box::new(pass_by_ref_or_value));
632     store.register_late_pass(|| Box::new(ref_option_ref::RefOptionRef));
633     store.register_late_pass(|| Box::new(try_err::TryErr));
634     store.register_late_pass(|| Box::new(bytecount::ByteCount));
635     store.register_late_pass(|| Box::new(infinite_iter::InfiniteIter));
636     store.register_late_pass(|| Box::new(inline_fn_without_body::InlineFnWithoutBody));
637     store.register_late_pass(|| Box::new(useless_conversion::UselessConversion::default()));
638     store.register_late_pass(|| Box::new(implicit_hasher::ImplicitHasher));
639     store.register_late_pass(|| Box::new(fallible_impl_from::FallibleImplFrom));
640     store.register_late_pass(|| Box::new(double_comparison::DoubleComparisons));
641     store.register_late_pass(|| Box::new(question_mark::QuestionMark));
642     store.register_early_pass(|| Box::new(suspicious_operation_groupings::SuspiciousOperationGroupings));
643     store.register_late_pass(|| Box::new(suspicious_trait_impl::SuspiciousImpl));
644     store.register_late_pass(|| Box::new(map_unit_fn::MapUnit));
645     store.register_late_pass(|| Box::new(inherent_impl::MultipleInherentImpl));
646     store.register_late_pass(|| Box::new(neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd));
647     store.register_late_pass(|| Box::new(unwrap::Unwrap));
648     store.register_late_pass(|| Box::new(duration_subsec::DurationSubsec));
649     store.register_late_pass(|| Box::new(indexing_slicing::IndexingSlicing));
650     store.register_late_pass(|| Box::new(non_copy_const::NonCopyConst));
651     store.register_late_pass(|| Box::new(ptr_offset_with_cast::PtrOffsetWithCast));
652     store.register_late_pass(|| Box::new(redundant_clone::RedundantClone));
653     store.register_late_pass(|| Box::new(slow_vector_initialization::SlowVectorInit));
654     store.register_late_pass(|| Box::new(unnecessary_sort_by::UnnecessarySortBy));
655     store.register_late_pass(move || Box::new(unnecessary_wraps::UnnecessaryWraps::new(avoid_breaking_exported_api)));
656     store.register_late_pass(|| Box::new(assertions_on_constants::AssertionsOnConstants));
657     store.register_late_pass(|| Box::new(transmuting_null::TransmutingNull));
658     store.register_late_pass(|| Box::new(path_buf_push_overwrite::PathBufPushOverwrite));
659     store.register_late_pass(|| Box::new(integer_division::IntegerDivision));
660     store.register_late_pass(|| Box::new(inherent_to_string::InherentToString));
661     let max_trait_bounds = conf.max_trait_bounds;
662     store.register_late_pass(move || Box::new(trait_bounds::TraitBounds::new(max_trait_bounds)));
663     store.register_late_pass(|| Box::new(comparison_chain::ComparisonChain));
664     store.register_late_pass(|| Box::new(mut_key::MutableKeyType));
665     store.register_late_pass(|| Box::new(modulo_arithmetic::ModuloArithmetic));
666     store.register_early_pass(|| Box::new(reference::DerefAddrOf));
667     store.register_early_pass(|| Box::new(reference::RefInDeref));
668     store.register_early_pass(|| Box::new(double_parens::DoubleParens));
669     store.register_late_pass(|| Box::new(to_string_in_display::ToStringInDisplay::new()));
670     store.register_early_pass(|| Box::new(unsafe_removed_from_name::UnsafeNameRemoval));
671     store.register_early_pass(|| Box::new(else_if_without_else::ElseIfWithoutElse));
672     store.register_early_pass(|| Box::new(int_plus_one::IntPlusOne));
673     store.register_early_pass(|| Box::new(formatting::Formatting));
674     store.register_early_pass(|| Box::new(misc_early::MiscEarlyLints));
675     store.register_early_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
676     store.register_late_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
677     store.register_early_pass(|| Box::new(unused_unit::UnusedUnit));
678     store.register_late_pass(|| Box::new(returns::Return));
679     store.register_early_pass(|| Box::new(collapsible_if::CollapsibleIf));
680     store.register_early_pass(|| Box::new(items_after_statements::ItemsAfterStatements));
681     store.register_early_pass(|| Box::new(precedence::Precedence));
682     store.register_early_pass(|| Box::new(needless_continue::NeedlessContinue));
683     store.register_early_pass(|| Box::new(redundant_else::RedundantElse));
684     store.register_late_pass(|| Box::new(create_dir::CreateDir));
685     store.register_early_pass(|| Box::new(needless_arbitrary_self_type::NeedlessArbitrarySelfType));
686     let cargo_ignore_publish = conf.cargo_ignore_publish;
687     store.register_late_pass(move || Box::new(cargo_common_metadata::CargoCommonMetadata::new(cargo_ignore_publish)));
688     store.register_late_pass(|| Box::new(multiple_crate_versions::MultipleCrateVersions));
689     store.register_late_pass(|| Box::new(wildcard_dependencies::WildcardDependencies));
690     let literal_representation_lint_fraction_readability = conf.unreadable_literal_lint_fractions;
691     store.register_early_pass(move || Box::new(literal_representation::LiteralDigitGrouping::new(literal_representation_lint_fraction_readability)));
692     let literal_representation_threshold = conf.literal_representation_threshold;
693     store.register_early_pass(move || Box::new(literal_representation::DecimalLiteralRepresentation::new(literal_representation_threshold)));
694     let enum_variant_name_threshold = conf.enum_variant_name_threshold;
695     store.register_late_pass(move || Box::new(enum_variants::EnumVariantNames::new(enum_variant_name_threshold, avoid_breaking_exported_api)));
696     store.register_early_pass(|| Box::new(tabs_in_doc_comments::TabsInDocComments));
697     let upper_case_acronyms_aggressive = conf.upper_case_acronyms_aggressive;
698     store.register_late_pass(move || Box::new(upper_case_acronyms::UpperCaseAcronyms::new(avoid_breaking_exported_api, upper_case_acronyms_aggressive)));
699     store.register_late_pass(|| Box::new(default::Default::default()));
700     store.register_late_pass(|| Box::new(unused_self::UnusedSelf));
701     store.register_late_pass(|| Box::new(mutable_debug_assertion::DebugAssertWithMutCall));
702     store.register_late_pass(|| Box::new(exit::Exit));
703     store.register_late_pass(|| Box::new(to_digit_is_some::ToDigitIsSome));
704     let array_size_threshold = conf.array_size_threshold;
705     store.register_late_pass(move || Box::new(large_stack_arrays::LargeStackArrays::new(array_size_threshold)));
706     store.register_late_pass(move || Box::new(large_const_arrays::LargeConstArrays::new(array_size_threshold)));
707     store.register_late_pass(|| Box::new(floating_point_arithmetic::FloatingPointArithmetic));
708     store.register_early_pass(|| Box::new(as_conversions::AsConversions));
709     store.register_late_pass(|| Box::new(let_underscore::LetUnderscore));
710     store.register_early_pass(|| Box::new(single_component_path_imports::SingleComponentPathImports));
711     let max_fn_params_bools = conf.max_fn_params_bools;
712     let max_struct_bools = conf.max_struct_bools;
713     store.register_early_pass(move || Box::new(excessive_bools::ExcessiveBools::new(max_struct_bools, max_fn_params_bools)));
714     store.register_early_pass(|| Box::new(option_env_unwrap::OptionEnvUnwrap));
715     let warn_on_all_wildcard_imports = conf.warn_on_all_wildcard_imports;
716     store.register_late_pass(move || Box::new(wildcard_imports::WildcardImports::new(warn_on_all_wildcard_imports)));
717     store.register_late_pass(|| Box::new(verbose_file_reads::VerboseFileReads));
718     store.register_late_pass(|| Box::new(redundant_pub_crate::RedundantPubCrate::default()));
719     store.register_late_pass(|| Box::new(unnamed_address::UnnamedAddress));
720     store.register_late_pass(|| Box::new(dereference::Dereferencing::default()));
721     store.register_late_pass(|| Box::new(option_if_let_else::OptionIfLetElse));
722     store.register_late_pass(|| Box::new(future_not_send::FutureNotSend));
723     store.register_late_pass(|| Box::new(if_let_mutex::IfLetMutex));
724     store.register_late_pass(|| Box::new(if_not_else::IfNotElse));
725     store.register_late_pass(|| Box::new(equatable_if_let::PatternEquality));
726     store.register_late_pass(|| Box::new(mut_mutex_lock::MutMutexLock));
727     store.register_late_pass(|| Box::new(match_on_vec_items::MatchOnVecItems));
728     store.register_late_pass(|| Box::new(manual_async_fn::ManualAsyncFn));
729     store.register_late_pass(|| Box::new(vec_resize_to_zero::VecResizeToZero));
730     store.register_late_pass(|| Box::new(panic_in_result_fn::PanicInResultFn));
731     let single_char_binding_names_threshold = conf.single_char_binding_names_threshold;
732     store.register_early_pass(move || Box::new(non_expressive_names::NonExpressiveNames {
733         single_char_binding_names_threshold,
734     }));
735     let macro_matcher = conf.standard_macro_braces.iter().cloned().collect::<FxHashSet<_>>();
736     store.register_early_pass(move || Box::new(nonstandard_macro_braces::MacroBraces::new(&macro_matcher)));
737     store.register_late_pass(|| Box::new(macro_use::MacroUseImports::default()));
738     store.register_late_pass(|| Box::new(pattern_type_mismatch::PatternTypeMismatch));
739     store.register_late_pass(|| Box::new(stable_sort_primitive::StableSortPrimitive));
740     store.register_late_pass(|| Box::new(repeat_once::RepeatOnce));
741     store.register_late_pass(|| Box::new(unwrap_in_result::UnwrapInResult));
742     store.register_late_pass(|| Box::new(self_assignment::SelfAssignment));
743     store.register_late_pass(|| Box::new(manual_unwrap_or::ManualUnwrapOr));
744     store.register_late_pass(|| Box::new(manual_ok_or::ManualOkOr));
745     store.register_late_pass(|| Box::new(float_equality_without_abs::FloatEqualityWithoutAbs));
746     store.register_late_pass(|| Box::new(semicolon_if_nothing_returned::SemicolonIfNothingReturned));
747     store.register_late_pass(|| Box::new(async_yields_async::AsyncYieldsAsync));
748     let disallowed_methods = conf.disallowed_methods.clone();
749     store.register_late_pass(move || Box::new(disallowed_method::DisallowedMethod::new(disallowed_methods.clone())));
750     store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86AttSyntax));
751     store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86IntelSyntax));
752     store.register_late_pass(|| Box::new(undropped_manually_drops::UndroppedManuallyDrops));
753     store.register_late_pass(|| Box::new(strings::StrToString));
754     store.register_late_pass(|| Box::new(strings::StringToString));
755     store.register_late_pass(|| Box::new(zero_sized_map_values::ZeroSizedMapValues));
756     store.register_late_pass(|| Box::new(vec_init_then_push::VecInitThenPush::default()));
757     store.register_late_pass(|| Box::new(case_sensitive_file_extension_comparisons::CaseSensitiveFileExtensionComparisons));
758     store.register_late_pass(|| Box::new(redundant_slicing::RedundantSlicing));
759     store.register_late_pass(|| Box::new(from_str_radix_10::FromStrRadix10));
760     store.register_late_pass(|| Box::new(manual_map::ManualMap));
761     store.register_late_pass(move || Box::new(if_then_some_else_none::IfThenSomeElseNone::new(msrv)));
762     store.register_late_pass(|| Box::new(bool_assert_comparison::BoolAssertComparison));
763     store.register_early_pass(move || Box::new(module_style::ModStyle));
764     store.register_late_pass(|| Box::new(unused_async::UnusedAsync));
765     let disallowed_types = conf.disallowed_types.clone();
766     store.register_late_pass(move || Box::new(disallowed_type::DisallowedType::new(disallowed_types.clone())));
767     let import_renames = conf.enforced_import_renames.clone();
768     store.register_late_pass(move || Box::new(missing_enforced_import_rename::ImportRename::new(import_renames.clone())));
769     let scripts = conf.allowed_scripts.clone();
770     store.register_early_pass(move || Box::new(disallowed_script_idents::DisallowedScriptIdents::new(&scripts)));
771     store.register_late_pass(|| Box::new(strlen_on_c_strings::StrlenOnCStrings));
772     store.register_late_pass(move || Box::new(self_named_constructors::SelfNamedConstructors));
773     store.register_late_pass(move || Box::new(feature_name::FeatureName));
774     store.register_late_pass(move || Box::new(iter_not_returning_iterator::IterNotReturningIterator));
775     store.register_late_pass(move || Box::new(manual_assert::ManualAssert));
776     let enable_raw_pointer_heuristic_for_send = conf.enable_raw_pointer_heuristic_for_send;
777     store.register_late_pass(move || Box::new(non_send_fields_in_send_ty::NonSendFieldInSendTy::new(enable_raw_pointer_heuristic_for_send)));
778     store.register_late_pass(move || Box::new(undocumented_unsafe_blocks::UndocumentedUnsafeBlocks::default()));
779     store.register_late_pass(|| Box::new(match_str_case_mismatch::MatchStrCaseMismatch));
780     store.register_late_pass(move || Box::new(format_args::FormatArgs));
781     store.register_late_pass(|| Box::new(trailing_empty_array::TrailingEmptyArray));
782     // add lints here, do not remove this comment, it's used in `new_lint`
783 }
784 
785 #[rustfmt::skip]
register_removed_non_tool_lints(store: &mut rustc_lint::LintStore)786 fn register_removed_non_tool_lints(store: &mut rustc_lint::LintStore) {
787     store.register_removed(
788         "should_assert_eq",
789         "`assert!()` will be more flexible with RFC 2011",
790     );
791     store.register_removed(
792         "extend_from_slice",
793         "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
794     );
795     store.register_removed(
796         "range_step_by_zero",
797         "`iterator.step_by(0)` panics nowadays",
798     );
799     store.register_removed(
800         "unstable_as_slice",
801         "`Vec::as_slice` has been stabilized in 1.7",
802     );
803     store.register_removed(
804         "unstable_as_mut_slice",
805         "`Vec::as_mut_slice` has been stabilized in 1.7",
806     );
807     store.register_removed(
808         "misaligned_transmute",
809         "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
810     );
811     store.register_removed(
812         "assign_ops",
813         "using compound assignment operators (e.g., `+=`) is harmless",
814     );
815     store.register_removed(
816         "if_let_redundant_pattern_matching",
817         "this lint has been changed to redundant_pattern_matching",
818     );
819     store.register_removed(
820         "unsafe_vector_initialization",
821         "the replacement suggested by this lint had substantially different behavior",
822     );
823     store.register_removed(
824         "reverse_range_loop",
825         "this lint is now included in reversed_empty_ranges",
826     );
827 }
828 
829 /// Register renamed lints.
830 ///
831 /// Used in `./src/driver.rs`.
register_renamed(ls: &mut rustc_lint::LintStore)832 pub fn register_renamed(ls: &mut rustc_lint::LintStore) {
833     // NOTE: when renaming a lint, add a corresponding test to tests/ui/rename.rs
834     ls.register_renamed("clippy::stutter", "clippy::module_name_repetitions");
835     ls.register_renamed("clippy::new_without_default_derive", "clippy::new_without_default");
836     ls.register_renamed("clippy::cyclomatic_complexity", "clippy::cognitive_complexity");
837     ls.register_renamed("clippy::const_static_lifetime", "clippy::redundant_static_lifetimes");
838     ls.register_renamed("clippy::option_and_then_some", "clippy::bind_instead_of_map");
839     ls.register_renamed("clippy::box_vec", "clippy::box_collection");
840     ls.register_renamed("clippy::block_in_if_condition_expr", "clippy::blocks_in_if_conditions");
841     ls.register_renamed("clippy::block_in_if_condition_stmt", "clippy::blocks_in_if_conditions");
842     ls.register_renamed("clippy::option_map_unwrap_or", "clippy::map_unwrap_or");
843     ls.register_renamed("clippy::option_map_unwrap_or_else", "clippy::map_unwrap_or");
844     ls.register_renamed("clippy::result_map_unwrap_or_else", "clippy::map_unwrap_or");
845     ls.register_renamed("clippy::option_unwrap_used", "clippy::unwrap_used");
846     ls.register_renamed("clippy::result_unwrap_used", "clippy::unwrap_used");
847     ls.register_renamed("clippy::option_expect_used", "clippy::expect_used");
848     ls.register_renamed("clippy::result_expect_used", "clippy::expect_used");
849     ls.register_renamed("clippy::for_loop_over_option", "clippy::for_loops_over_fallibles");
850     ls.register_renamed("clippy::for_loop_over_result", "clippy::for_loops_over_fallibles");
851     ls.register_renamed("clippy::identity_conversion", "clippy::useless_conversion");
852     ls.register_renamed("clippy::zero_width_space", "clippy::invisible_characters");
853     ls.register_renamed("clippy::single_char_push_str", "clippy::single_char_add_str");
854     ls.register_renamed("clippy::if_let_some_result", "clippy::match_result_ok");
855 
856     // uplifted lints
857     ls.register_renamed("clippy::invalid_ref", "invalid_value");
858     ls.register_renamed("clippy::into_iter_on_array", "array_into_iter");
859     ls.register_renamed("clippy::unused_label", "unused_labels");
860     ls.register_renamed("clippy::drop_bounds", "drop_bounds");
861     ls.register_renamed("clippy::temporary_cstring_as_ptr", "temporary_cstring_as_ptr");
862     ls.register_renamed("clippy::panic_params", "non_fmt_panics");
863     ls.register_renamed("clippy::unknown_clippy_lints", "unknown_lints");
864     ls.register_renamed("clippy::invalid_atomic_ordering", "invalid_atomic_ordering");
865     ls.register_renamed("clippy::mem_discriminant_non_enum", "enum_intrinsics_non_enums");
866 }
867 
868 // only exists to let the dogfood integration test works.
869 // Don't run clippy as an executable directly
870 #[allow(dead_code)]
main()871 fn main() {
872     panic!("Please use the cargo-clippy executable");
873 }
874