Searched hist:"0137 fdc0" (Results 1 – 2 of 2) sorted by relevance
/qemu/hw/misc/ |
H A D | cbus.c | 0137fdc0 Wed Mar 09 11:19:37 GMT 2016 Markus Armbruster <armbru@redhat.com> include/hw/hw.h: Don't include qemu-common.h
qemu-common.h should only be included by .c files. Its file comment explains why: "No header file should depend on qemu-common.h, as this would easily lead to circular header dependencies."
hw/hw.h includes qemu-common.h, but its users generally need only hw_error() and qemu/module.h from it. Move the former to hw/hw.h, include the latter there, and drop the ill-advised include. hw/misc/cbus.c now misses hw_error(), so include hw/hw.h there.
Signed-off-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
/qemu/include/hw/ |
H A D | hw.h | 0137fdc0 Wed Mar 09 11:19:37 GMT 2016 Markus Armbruster <armbru@redhat.com> include/hw/hw.h: Don't include qemu-common.h
qemu-common.h should only be included by .c files. Its file comment explains why: "No header file should depend on qemu-common.h, as this would easily lead to circular header dependencies."
hw/hw.h includes qemu-common.h, but its users generally need only hw_error() and qemu/module.h from it. Move the former to hw/hw.h, include the latter there, and drop the ill-advised include. hw/misc/cbus.c now misses hw_error(), so include hw/hw.h there.
Signed-off-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|