#include "library/coverartutils.h" #include #include #include "library/coverartcache.h" #include "sources/soundsourceproxy.h" #include "test/librarytest.h" #include "track/track.h" namespace { const QDir kTestDir(QDir::current().absoluteFilePath("src/test/id3-test-data")); const QString kReferencePNGLocationTest(kTestDir.absoluteFilePath("reference_cover.png")); const QString kReferenceJPGLocationTest(kTestDir.absoluteFilePath("cover_test.jpg")); bool isSupportedFileExtension(const QString& fileExtension) { return 0 < SoundSourceProxy::getSupportedFileExtensions().count(fileExtension); } void extractEmbeddedCover( const QString& trackLocation, const SecurityTokenPointer& pToken, const QImage& expectedImage) { const QImage actualImage( CoverArtUtils::extractEmbeddedCover(trackLocation, pToken)); ASSERT_FALSE(actualImage.isNull()); EXPECT_EQ(expectedImage, actualImage); } } // anonymous namespace // First inherit from LibraryTest to construct an QApplication instance // needed by CoverArtCache for the default QPixmapCache. // LibraryTest is required to instantiate the GlobalTrackCache singleton. class CoverArtUtilTest : public LibraryTest, CoverArtCache { }; TEST_F(CoverArtUtilTest, extractEmbeddedCover) { QImage referencePNGImage = QImage(kReferencePNGLocationTest); QImage referenceJPGImage = QImage(kReferenceJPGLocationTest); // We never need to acquire security tokens for tests since we don't run // them in a sandboxed environment. SecurityTokenPointer pToken; if (isSupportedFileExtension("aiff")) { extractEmbeddedCover( kTestDir.absoluteFilePath("cover-test.aiff"), pToken, referencePNGImage); } if (isSupportedFileExtension("flac")) { extractEmbeddedCover( kTestDir.absoluteFilePath("cover-test.flac"), pToken, referencePNGImage); } if (isSupportedFileExtension("m4a")) { extractEmbeddedCover( kTestDir.absoluteFilePath("cover-test-itunes-12.3.0-aac.m4a"), pToken, referencePNGImage); extractEmbeddedCover( kTestDir.absoluteFilePath("cover-test-itunes-12.7.0-aac.m4a"), pToken, referencePNGImage); extractEmbeddedCover( kTestDir.absoluteFilePath("cover-test-itunes-12.7.0-alac.m4a"), pToken, referencePNGImage); } if (isSupportedFileExtension("mp3")) { // PNG extractEmbeddedCover( kTestDir.absoluteFilePath("cover-test-png.mp3"), pToken, referencePNGImage); // JPEG extractEmbeddedCover( kTestDir.absoluteFilePath("cover-test-jpg.mp3"), pToken, referenceJPGImage); } if (isSupportedFileExtension("ogg")) { extractEmbeddedCover( kTestDir.absoluteFilePath("cover-test.ogg"), pToken, referencePNGImage); } if (isSupportedFileExtension("opus")) { // opus extractEmbeddedCover( kTestDir.absoluteFilePath("cover-test.opus"), pToken, referencePNGImage); } if (isSupportedFileExtension("wav")) { extractEmbeddedCover( kTestDir.absoluteFilePath("cover-test.wav"), pToken, referencePNGImage); } if (isSupportedFileExtension("wv")) { extractEmbeddedCover( kTestDir.absoluteFilePath("cover-test.wv"), pToken, referencePNGImage); } } TEST_F(CoverArtUtilTest, searchImage) { // creating a temp track directory QTemporaryDir tempTrackDir; ASSERT_TRUE(tempTrackDir.isValid()); QString trackdir = QString(tempTrackDir.path()); const QString kTrackLocationTest(kTestDir.absoluteFilePath("cover-test-png.mp3")); TrackPointer pTrack(Track::newTemporary(kTrackLocationTest)); QList covers; CoverInfoRelative res; // looking for cover in an empty directory res = CoverArtUtils::selectCoverArtForTrack(*pTrack, covers); CoverInfoRelative expected1; expected1.source = CoverInfo::GUESSED; EXPECT_EQ(expected1, res); // Looking for a track with embedded cover. pTrack = Track::newTemporary(kTrackLocationTest); SoundSourceProxy(pTrack).updateTrackFromSource(); CoverInfo result = pTrack->getCoverInfoWithLocation(); EXPECT_EQ(result.type, CoverInfo::METADATA); EXPECT_EQ(result.source, CoverInfo::GUESSED); EXPECT_EQ(result.coverLocation, QString()); EXPECT_NE(result.hash, CoverInfoRelative().hash); const char* format("jpg"); const QString qFormat(format); // Since we already parsed this image from the metadata in // kTrackLocationTest, hang on to it since we use it as a template for // stuff below. result.trackLocation = kTrackLocationTest; const QImage img = result.loadImage().image; EXPECT_EQ(img.isNull(), false); QString trackBaseName = "cover-test"; QString trackAlbum = "album_name"; // Search Strategy // 0. If we have just one file, we will get it. // 1. %track-file-base%.jpg in the track directory for %track-file-base%.mp3 // 2. %album%.jpg // 3. cover.jpg // 4. front.jpg // 5. album.jpg // 6. folder.jpg // 7. if just one file exists take that otherwise none. // All the following expect the same image/hash to be selected. CoverInfoRelative expected2; expected2.hash = CoverInfoRelative().hash; // All the following expect FILE and GUESSED. expected2.type = CoverInfo::FILE; expected2.source = CoverInfo::GUESSED; // 0. saving just one cover in our temp track dir QString cLoc_foo = QString(trackdir % "/" % "foo." % qFormat); EXPECT_TRUE(img.save(cLoc_foo, format)); // looking for cover in an directory with one image will select that one. expected2.coverLocation = "foo.jpg"; expected2.hash = CoverImageUtils::calculateHash(QImage(cLoc_foo)); covers << QFileInfo(cLoc_foo); CoverInfoRelative res2 = CoverArtUtils::selectCoverArtForTrack( trackBaseName, trackAlbum, covers); EXPECT_EQ(expected2, res2); QFile::remove(cLoc_foo); QStringList extraCovers; // adding some extra images (bigger) just to populate the track dir. QString cLoc_big1 = QString(trackdir % "/" % "big1." % qFormat); EXPECT_TRUE(img.scaled(1000,1000).save(cLoc_big1, format)); extraCovers << cLoc_big1; QString cLoc_big2 = QString(trackdir % "/" % "big2." % qFormat); EXPECT_TRUE(img.scaled(900,900).save(cLoc_big2, format)); extraCovers << cLoc_big2; QString cLoc_big3 = QString(trackdir % "/" % "big3." % qFormat); EXPECT_TRUE(img.scaled(800,800).save(cLoc_big3, format)); extraCovers << cLoc_big3; // saving more covers using the preferred names in the right order QList prefCovers; // 1. track_filename.jpg QString cLoc_filename = QString(trackdir % "/cover-test." % qFormat); EXPECT_TRUE(img.scaled(500,500).save(cLoc_filename, format)); prefCovers << QFileInfo(cLoc_filename); // 2. album_name.jpg QString cLoc_albumName = QString(trackdir % "/album_name." % qFormat); EXPECT_TRUE(img.scaled(500,500).save(cLoc_albumName, format)); prefCovers << QFileInfo(cLoc_albumName); // 3. cover.jpg QString cLoc_cover = QString(trackdir % "/" % "cover." % qFormat); EXPECT_TRUE(img.scaled(400,400).save(cLoc_cover, format)); prefCovers << QFileInfo(cLoc_cover); // 4. front.jpg QString cLoc_front = QString(trackdir % "/" % "front." % qFormat); EXPECT_TRUE(img.scaled(300,300).save(cLoc_front, format)); prefCovers << QFileInfo(cLoc_front); // 5. album.jpg QString cLoc_album = QString(trackdir % "/" % "album." % qFormat); EXPECT_TRUE(img.scaled(100,100).save(cLoc_album, format)); prefCovers << QFileInfo(cLoc_album); // 6. folder.jpg QString cLoc_folder = QString(trackdir % "/" % "folder." % qFormat); EXPECT_TRUE(img.scaled(100,100).save(cLoc_folder, format)); prefCovers << QFileInfo(cLoc_folder); // 8. other1.jpg QString cLoc_other1 = QString(trackdir % "/" % "other1." % qFormat); EXPECT_TRUE(img.scaled(10,10).save(cLoc_other1, format)); prefCovers << QFileInfo(cLoc_other1); // 7. other2.jpg QString cLoc_other2 = QString(trackdir % "/" % "other2." % qFormat); EXPECT_TRUE(img.scaled(10,10).save(cLoc_other2, format)); prefCovers << QFileInfo(cLoc_other2); // we must find covers in the right order EXPECT_EQ(8, prefCovers.size()); // Remove the covers one by one from the front, checking that each one is // selected as we remove the previously-most-preferable cover. while (!prefCovers.isEmpty()) { QFileInfo cover = prefCovers.first(); // We expect no cover selected for other1 since there are 2 covers, // neither of which match our preferred cover names. other2 will be // selected once we get to it since it is the only cover available. if (cover.baseName() == "other1") { expected2.type = CoverInfo::NONE; expected2.coverLocation = QString(); expected2.hash = CoverInfoRelative().hash; } else { expected2.type = CoverInfo::FILE; expected2.coverLocation = cover.fileName(); expected2.hash = CoverImageUtils::calculateHash(QImage(cover.filePath())); } res2 = CoverArtUtils::selectCoverArtForTrack(trackBaseName, trackAlbum, prefCovers); EXPECT_QSTRING_EQ(expected2.coverLocation, res2.coverLocation); EXPECT_EQ(expected2.hash, res2.hash); EXPECT_EQ(expected2, res2); QFile::remove(cover.filePath()); prefCovers.pop_front(); } // // Additional tests // // what is chosen when cover.jpg and cover.JPG exists? // (it must always prefer the lighter cover) QString cLoc_coverJPG = trackdir % "/" % "cover." % "JPG"; EXPECT_TRUE(img.scaled(200,200).save(cLoc_coverJPG, "JPG")); prefCovers.append(QFileInfo(cLoc_coverJPG)); QString cLoc_coverjpg = trackdir % "/" % "cover." % "jpg"; EXPECT_TRUE(img.scaled(400,400).save(cLoc_coverjpg, "jpg")); prefCovers.append(QFileInfo(cLoc_coverjpg)); extraCovers << cLoc_coverJPG << cLoc_coverjpg; res2 = CoverArtUtils::selectCoverArtForTrack(trackBaseName, trackAlbum, prefCovers); expected2.hash = CoverImageUtils::calculateHash(QImage(cLoc_coverJPG)); expected2.coverLocation = "cover.JPG"; EXPECT_EQ(expected2, res2); // As we are looking for %album%.jpg and %base_track.jpg%, // we need to check if everything works with UTF8 chars. trackBaseName = QString::fromUtf8("track_ðÑöæäî"); trackAlbum = QString::fromUtf8("öæäîðÑ_album"); prefCovers.clear(); // 2. album_name.jpg cLoc_albumName = QString(trackdir % "/" % trackAlbum % "." % qFormat); EXPECT_TRUE(img.save(cLoc_albumName, format)); prefCovers.append(QFileInfo(cLoc_albumName)); res2 = CoverArtUtils::selectCoverArtForTrack(trackBaseName, trackAlbum, prefCovers); expected2.hash = CoverImageUtils::calculateHash(QImage(cLoc_albumName)); expected2.coverLocation = trackAlbum % ".jpg"; EXPECT_EQ(expected2, res2); // 1. track_filename.jpg cLoc_filename = QString(trackdir % "/" % trackBaseName % "." % qFormat); EXPECT_TRUE(img.save(cLoc_filename, format)); prefCovers.append(QFileInfo(cLoc_filename)); res2 = CoverArtUtils::selectCoverArtForTrack(trackBaseName, trackAlbum, prefCovers); expected2.hash = CoverImageUtils::calculateHash(QImage(cLoc_filename)); expected2.coverLocation = trackBaseName % ".jpg"; EXPECT_EQ(expected2, res2); QFile::remove(cLoc_filename); QFile::remove(cLoc_albumName); // cleaning temp dir foreach (QString loc, extraCovers) { QFile::remove(loc); } }