1# -*- coding: utf-8 -*-
2"""QGIS Unit tests for QgsGeometryValidator.
3
4.. note:: This program is free software; you can redistribute it and/or modify
5it under the terms of the GNU General Public License as published by
6the Free Software Foundation; either version 2 of the License, or
7(at your option) any later version.
8"""
9__author__ = 'Nyall Dawson'
10__date__ = '03/10/2016'
11__copyright__ = 'Copyright 2016, The QGIS Project'
12
13from qgis.core import (
14    QgsGeometry,
15    QgsGeometryValidator,
16    QgsPointXY
17)
18
19from qgis.testing import (
20    unittest,
21    start_app
22)
23
24from qgis.PyQt.QtTest import QSignalSpy
25
26app = start_app()
27
28
29class TestQgsGeometryValidator(unittest.TestCase):
30
31    def testIssue15660(self):
32        """ Test crash when validating geometry (#15660) """
33        g = QgsGeometry.fromWkt(
34            "Polygon ((0.44256348235389709 -47.87645625696347906, -2.88231630340906797 -47.90003919913998232,"
35            "-2.88589842578005751 -48.91215450743293047, -2.8858984257800584 -48.91215450743293047,"
36            "-2.88589842578005751 -48.91215450743292337, -2.88589842632776516 -48.9121545074024624,"
37            "-3.24858148608664266 -48.89198543875494352, -3.27689849271356159 -49.40119850743292318,"
38            "-4.37689842578006072 -49.40119850743292318, -4.3768984257800625 -49.40119850743293739,"
39            "-6.11689842578005738 -49.40119850743293739, -6.11689842578006093 -49.40119850743292318,"
40            "-7.03689842578006086 -49.40119850743292318, -7.02239489567359776 -48.93302358132471852,"
41            "-7.02177188091450688 -48.91291272055079276, -7.02177188393206286 -48.91291272045731375,"
42            "-7.02141642578006309 -48.9014385074329212, -7.7002102410998674 -48.88041051649613422,"
43            "-7.70077301577442341 -48.89187793078160382, -7.70077301577442341 -48.89187793078160382,"
44            "-7.70233865095334291 -48.92378019651650334, -7.72576842578006051 -49.40119850743292318,"
45            "-9.26576842578005966 -49.40119850743292318, -9.26576842578006321 -49.40119850743293739,"
46            "-13.28076842578006023 -49.40119850743293739, -13.04700849136197149 -44.82717853953759857,"
47            "-12.22739168108193297 -44.85224022031006541, -12.22501286465108805 -44.774446133668377,"
48            "-12.22288921611744783 -44.774511069530881, -12.2155540445085915 -44.53462318893357264,"
49            "-13.0310217329353506 -44.50968822589503304, -12.87640859053235687 -41.29089836691012749,"
50            "-7.83390711693117936 -41.74840291007100745, -7.88211379129075596 -42.99075321817508666,"
51            "-7.43245210877673657 -43.00820115628285123, -7.50410812906098013 -44.67868742523263847,"
52            "-7.52086717830689011 -44.67817497540850979, -7.52820234991574644 -44.91806285600581816,"
53            "-7.51439432253991058 -44.91848507095944854, -7.57421591980290287 -46.3130804785479242,"
54            "-8.32385639731993621 -46.28985691678211367, -8.44985043007881842 -48.85718773355701217,"
55            "-6.26478736265246283 -48.92487774800262912, -6.18500945357052245 -46.35611749220839073,"
56            "-6.94163842159974198 -46.33267751510010157, -6.82382190915497944 -40.77447960826383166,"
57            "-5.48772831582523146 -40.77837853452808758, -5.48973219643841759 -39.92687558952010107,"
58            "-2.75658441771447116 -40.04490036239724304, -3.1241861109063862 -46.6551270968877958,"
59            "-2.78977790434136885 -46.6737244011090695, -2.78977790434136796 -46.6737244011090695,"
60            "-2.71083842578005996 -44.83541850743291945, -2.71083842578005729 -44.83541850743291945,"
61            "-0.86779302740823816 -44.89143693883772812, -0.86745855610774569 -44.87743669555854353,"
62            "0.29843811058281489 -44.90401226269042922, 0.20437651721061911 -46.69301920907949466,"
63            "0.50389019278376956 -46.71008040893148916, 0.44256348235389709 -47.87645625696347906))")
64
65        self.assertTrue(g)
66        # make sure validating this geometry doesn't crash QGIS
67        QgsGeometryValidator.validateGeometry(g)
68
69    def test_linestring_duplicate_nodes(self):
70        g = QgsGeometry.fromWkt("LineString (1 1, 1 1, 1 1, 1 2, 1 3, 1 3, 1 3, 1 4, 1 5, 1 6, 1 6)")
71
72        validator = QgsGeometryValidator(g)
73        spy = QSignalSpy(validator.errorFound)
74        validator.run()
75
76        self.assertEqual(len(spy), 3)
77        self.assertEqual(spy[0][0].where(), QgsPointXY(1, 6))
78        self.assertEqual(spy[0][0].what(), 'line 1 contains 2 duplicate nodes starting at vertex 10')
79
80        self.assertEqual(spy[1][0].where(), QgsPointXY(1, 3))
81        self.assertEqual(spy[1][0].what(), 'line 1 contains 3 duplicate nodes starting at vertex 5')
82
83        self.assertEqual(spy[2][0].where(), QgsPointXY(1, 1))
84        self.assertEqual(spy[2][0].what(), 'line 1 contains 3 duplicate nodes starting at vertex 1')
85
86    def test_ring_intersections(self):
87        # no intersections
88        g = QgsGeometry.fromWkt("Polygon ((0 0, 10 0, 10 10, 0 10, 0 0),(1 1, 5 1, 1 9, 1 1), (6 9, 2 9, 6 1, 6 9))")
89
90        validator = QgsGeometryValidator(g)
91        spy = QSignalSpy(validator.errorFound)
92        validator.run()
93
94        self.assertEqual(len(spy), 0)
95
96        # two interior rings intersecting
97        g = QgsGeometry.fromWkt("Polygon ((0 0, 10 0, 10 10, 0 10, 0 0),(1 1, 5 1, 1 9, 1 1), (2 2, 5 2, 2 9, 2 2))")
98
99        validator = QgsGeometryValidator(g)
100        spy = QSignalSpy(validator.errorFound)
101        validator.run()
102
103        self.assertEqual(len(spy), 2)
104
105        self.assertEqual(spy[0][0].where(), QgsPointXY(4.5, 2))
106        self.assertEqual(spy[0][0].what(), 'segment 1 of ring 1 of polygon 0 intersects segment 0 of ring 2 of polygon 0 at 4.5, 2')
107
108        self.assertEqual(spy[1][0].where(), QgsPointXY(2, 7))
109        self.assertEqual(spy[1][0].what(), 'segment 1 of ring 1 of polygon 0 intersects segment 2 of ring 2 of polygon 0 at 2, 7')
110
111    def test_line_vertices(self):
112        # valid line
113        g = QgsGeometry.fromWkt("LineString (0 0, 10 0)")
114
115        validator = QgsGeometryValidator(g)
116        spy = QSignalSpy(validator.errorFound)
117        validator.run()
118        self.assertEqual(len(spy), 0)
119
120        # not enough vertices
121        g = QgsGeometry.fromWkt("LineString (1 0)")
122
123        validator = QgsGeometryValidator(g)
124        spy = QSignalSpy(validator.errorFound)
125        validator.run()
126        self.assertEqual(len(spy), 1)
127
128        self.assertEqual(spy[0][0].where(), QgsPointXY())
129        self.assertEqual(spy[0][0].what(), 'line 0 with less than two points')
130
131        g = QgsGeometry.fromWkt("LineString ()")
132
133        validator = QgsGeometryValidator(g)
134        spy = QSignalSpy(validator.errorFound)
135        validator.run()
136        self.assertEqual(len(spy), 1)
137
138        self.assertEqual(spy[0][0].where(), QgsPointXY())
139        self.assertEqual(spy[0][0].what(), 'line 0 with less than two points')
140
141    def test_ring_vertex_count(self):
142        # valid ring
143        g = QgsGeometry.fromWkt("Polygon ((0 0, 10 0, 10 10, 0 0))")
144
145        validator = QgsGeometryValidator(g)
146        spy = QSignalSpy(validator.errorFound)
147        validator.run()
148        self.assertEqual(len(spy), 0)
149
150        # not enough vertices
151        g = QgsGeometry.fromWkt("Polygon ((0 0, 10 0, 10 10))")
152
153        validator = QgsGeometryValidator(g)
154        spy = QSignalSpy(validator.errorFound)
155        validator.run()
156        self.assertEqual(len(spy), 1)
157
158        self.assertEqual(spy[0][0].where(), QgsPointXY())
159        self.assertEqual(spy[0][0].what(), 'ring 0 with less than four points')
160
161        g = QgsGeometry.fromWkt("Polygon ((0 0, 10 0, 0 0))")
162
163        validator = QgsGeometryValidator(g)
164        spy = QSignalSpy(validator.errorFound)
165        validator.run()
166        self.assertEqual(len(spy), 1)
167
168        self.assertEqual(spy[0][0].where(), QgsPointXY())
169        self.assertEqual(spy[0][0].what(), 'ring 0 with less than four points')
170
171        g = QgsGeometry.fromWkt("Polygon ((0 0, 10 0))")
172
173        validator = QgsGeometryValidator(g)
174        spy = QSignalSpy(validator.errorFound)
175        validator.run()
176        self.assertEqual(len(spy), 1)
177
178        self.assertEqual(spy[0][0].where(), QgsPointXY())
179        self.assertEqual(spy[0][0].what(), 'ring 0 with less than four points')
180
181        g = QgsGeometry.fromWkt("Polygon ((0 0))")
182
183        validator = QgsGeometryValidator(g)
184        spy = QSignalSpy(validator.errorFound)
185        validator.run()
186        self.assertEqual(len(spy), 1)
187
188        self.assertEqual(spy[0][0].where(), QgsPointXY())
189        self.assertEqual(spy[0][0].what(), 'ring 0 with less than four points')
190
191        g = QgsGeometry.fromWkt("Polygon (())")
192
193        validator = QgsGeometryValidator(g)
194        spy = QSignalSpy(validator.errorFound)
195        validator.run()
196        self.assertEqual(len(spy), 0)
197
198        g = QgsGeometry.fromWkt("Polygon ((0 0, 10 0, 10 10, 0 0),(1 1, 2 1, 2 2))")
199
200        validator = QgsGeometryValidator(g)
201        spy = QSignalSpy(validator.errorFound)
202        validator.run()
203        self.assertEqual(len(spy), 1)
204
205        self.assertEqual(spy[0][0].where(), QgsPointXY())
206        self.assertEqual(spy[0][0].what(), 'ring 1 with less than four points')
207
208        g = QgsGeometry.fromWkt("Polygon ((0 0, 10 0, 10 10, 0 0),(1 1, 2 1, 2 2, 1 1))")
209
210        validator = QgsGeometryValidator(g)
211        spy = QSignalSpy(validator.errorFound)
212        validator.run()
213        self.assertEqual(len(spy), 0)
214
215        g = QgsGeometry.fromWkt("Polygon ((0 0, 10 0, 10 10, 0 10, 0 0),(1 1, 2 1, 2 2, 1 1),(3 3, 3 4, 4 4))")
216
217        validator = QgsGeometryValidator(g)
218        spy = QSignalSpy(validator.errorFound)
219        validator.run()
220        self.assertEqual(len(spy), 1)
221
222        self.assertEqual(spy[0][0].where(), QgsPointXY())
223        self.assertEqual(spy[0][0].what(), 'ring 2 with less than four points')
224
225    def test_ring_closed(self):
226        # valid ring
227        g = QgsGeometry.fromWkt("Polygon ((0 0, 10 0, 10 10, 0 0))")
228
229        validator = QgsGeometryValidator(g)
230        spy = QSignalSpy(validator.errorFound)
231        validator.run()
232        self.assertEqual(len(spy), 0)
233
234        # not closed
235        g = QgsGeometry.fromWkt("Polygon ((0 0, 10 0, 10 10, 1 1))")
236
237        validator = QgsGeometryValidator(g)
238        spy = QSignalSpy(validator.errorFound)
239        validator.run()
240        self.assertEqual(len(spy), 1)
241
242        self.assertEqual(spy[0][0].where(), QgsPointXY(0, 0))
243        self.assertEqual(spy[0][0].what(), 'ring 0 not closed')
244
245        g = QgsGeometry.fromWkt("Polygon ((0 0, 10 0, 10 10, 0 0),(1 1, 2 1, 2 2, 1.1 1))")
246
247        validator = QgsGeometryValidator(g)
248        spy = QSignalSpy(validator.errorFound)
249        validator.run()
250        self.assertEqual(len(spy), 1)
251
252        self.assertEqual(spy[0][0].where(), QgsPointXY(1, 1))
253        self.assertEqual(spy[0][0].what(), 'ring 1 not closed')
254
255        g = QgsGeometry.fromWkt("Polygon ((0 0, 10 0, 10 10, 0 10, 0 0),(1 1, 2 1, 2 2, 1 1),(3 3, 3 4, 4 4, 3.1 3))")
256
257        validator = QgsGeometryValidator(g)
258        spy = QSignalSpy(validator.errorFound)
259        validator.run()
260        self.assertEqual(len(spy), 1)
261
262        self.assertEqual(spy[0][0].where(), QgsPointXY(3, 3))
263        self.assertEqual(spy[0][0].what(), 'ring 2 not closed')
264
265        # not closed but 2d closed
266        g = QgsGeometry.fromWkt("POLYGONZ((1 1 0, 1 2 1, 2 2 2, 2 1 3, 1 1 4))")
267
268        validator = QgsGeometryValidator(g)
269        spy = QSignalSpy(validator.errorFound)
270        validator.run()
271        self.assertEqual(len(spy), 1)
272
273        self.assertEqual(spy[0][0].where(), QgsPointXY(1, 1))
274        self.assertEqual(spy[0][0].what(), 'ring 0 not closed, Z mismatch: 0 vs 4')
275
276
277if __name__ == '__main__':
278    unittest.main()
279