1Return-Path: <stefan@datenfreihafen.org> 2X-Original-To: notmuch@notmuchmail.org 3Delivered-To: notmuch@notmuchmail.org 4Received: from localhost (localhost [127.0.0.1]) 5 by olra.theworths.org (Postfix) with ESMTP id 912FF431FBF 6 for <notmuch@notmuchmail.org>; Sun, 22 Nov 2009 10:33:44 -0800 (PST) 7X-Virus-Scanned: Debian amavisd-new at olra.theworths.org 8Received: from olra.theworths.org ([127.0.0.1]) 9 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) 10 with ESMTP id 9T+Abdbhab0i for <notmuch@notmuchmail.org>; 11 Sun, 22 Nov 2009 10:33:43 -0800 (PST) 12Received: from sirius.lasnet.de (sirius.lasnet.de [78.47.116.19]) 13 by olra.theworths.org (Postfix) with ESMTP id 39D1C431FAE 14 for <notmuch@notmuchmail.org>; Sun, 22 Nov 2009 10:33:43 -0800 (PST) 15Received: from p5b0353d3.dip.t-dialin.net ([91.3.83.211] helo=excalibur) 16 by sirius.lasnet.de with esmtpsa 17 (Cipher TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63 #1) 18 id 1NCHFh-0000dR-It by authid <stefan@sostec.de> with cram_md5; 19 Sun, 22 Nov 2009 19:33:40 +0100 20Received: from stefan by excalibur with local (Exim 4.69) 21 (envelope-from <stefan@excalibur.local>) 22 id 1NCHFi-0002ot-2C; Sun, 22 Nov 2009 19:33:38 +0100 23Date: Sun, 22 Nov 2009 19:33:38 +0100 24From: Stefan Schmidt <stefan@datenfreihafen.org> 25To: Keith Packard <keithp@keithp.com> 26Message-ID: <20091122183338.GB5735@excalibur.local> 27References: <yes> <1258848661-4660-1-git-send-email-stefan@datenfreihafen.org> 28 <yunvdh3pfm9.fsf@aiko.keithp.com> 29MIME-Version: 1.0 30Content-Type: multipart/signed; micalg=pgp-sha1; 31 protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc" 32Content-Disposition: inline 33In-Reply-To: <yunvdh3pfm9.fsf@aiko.keithp.com> 34X-Mailer: Mutt http://www.mutt.org/ 35X-KeyID: 0xDDF51665 36X-Website: http://www.datenfreihafen.org/ 37User-Agent: Mutt/1.5.20 (2009-06-14) 38Cc: notmuch@notmuchmail.org 39Subject: Re: [notmuch] [PATCH 1/2] lib/message: Add function to get maildir 40 flags. 41X-BeenThere: notmuch@notmuchmail.org 42X-Mailman-Version: 2.1.12 43Precedence: list 44List-Id: "Use and development of the notmuch mail system." 45 <notmuch.notmuchmail.org> 46List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>, 47 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe> 48List-Archive: <http://notmuchmail.org/pipermail/notmuch> 49List-Post: <mailto:notmuch@notmuchmail.org> 50List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help> 51List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>, 52 <mailto:notmuch-request@notmuchmail.org?subject=subscribe> 53X-List-Received-Date: Sun, 22 Nov 2009 18:33:44 -0000 54 55 56--C7zPtVaVf+AK4Oqc 57Content-Type: text/plain; charset=us-ascii 58Content-Disposition: inline 59Content-Transfer-Encoding: quoted-printable 60 61Hello. 62 63On Sat, 2009-11-21 at 16:28, Keith Packard wrote: 64> On Sun, 22 Nov 2009 01:11:00 +0100, Stefan Schmidt <stefan@datenfreihafen= 65=2Eorg> wrote: 66>=20 67> > +const char * 68> > +notmuch_message_get_flags (notmuch_message_t *message) 69>=20 70> This function should interpret the flags that it finds and return a 71> suitable set of notmuch tags. I'd suggest that 'unread' messages get 72> both 'unread' and 'inbox' tags, as Maildir doesn't distinguish between 73> 'don't show this to be by default again please' and 'I've read this 74> message'. It seems best to hide the maildir-specific details inside the 75> library instead of exposing them. 76 77Thanks for the review. On a second thought the interface was really a bit u= 78gly. 79:) 80 81I'm just back to my box and going through the outstanding mails shows me th= 82at 83Michiel Buddingh has a more complete patch on the 84convert-maildir-flags-into-tags issue which Carl has tagged for review. Will 85wait what comes out of it and if anything is left for me to. :) 86 87regards 88Stefan Schmidt 89 90--C7zPtVaVf+AK4Oqc 91Content-Type: application/pgp-signature; name="signature.asc" 92Content-Description: Digital signature 93Content-Disposition: inline 94 95-----BEGIN PGP SIGNATURE----- 96Version: GnuPG v1.4.10 (GNU/Linux) 97Comment: http://www.datenfreihafen.org/contact.html 98 99iEYEARECAAYFAksJhAIACgkQbNSsvd31FmWDDgCgswbE3BE2XeExPzBBJf86efDw 100aFwAoMc3vaBmTjB2kG5ORUmk1E/ICBXK 101=k8v5 102-----END PGP SIGNATURE----- 103 104--C7zPtVaVf+AK4Oqc-- 105 106