1From: Joe Perches <joe@perches.com> 2Subject: rfc: rewrite commit subject line for subsystem maintainer 3 preference tool 4Date: Tue, 16 Nov 2010 06:51:17 -0800 5Lines: 36 6Message-ID: <1289919077.28741.50.camel@Joe-Laptop> 7References: <20101115134939.GC12986@rakim.wolfsonmicro.main> 8 <1289840957.16461.138.camel@Joe-Laptop> 9 <20101115173031.GI12986@rakim.wolfsonmicro.main> 10 <1289842444.16461.140.camel@Joe-Laptop> 11 <20101115182708.GJ12986@rakim.wolfsonmicro.main> 12 <1289845830.16461.149.camel@Joe-Laptop> 13 <20101115190738.GF3338@sirena.org.uk> 14 <1289848458.16461.150.camel@Joe-Laptop> 15 <20101115193407.GK12986@rakim.wolfsonmicro.main> 16 <1289850773.16461.166.camel@Joe-Laptop> 17 <20101116104921.GL12986@rakim.wolfsonmicro.main> 18Mime-Version: 1.0 19Content-Type: text/plain; charset="UTF-8" 20Content-Transfer-Encoding: 7bit 21Cc: Jiri Kosina <trivial@kernel.org>, 22 Andrew Morton <akpm@linux-foundation.org>, 23 Florian Mickler <florian@mickler.org>, 24 alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org 25To: Mark Brown <broonie@opensource.wolfsonmicro.com> 26X-From: linux-kernel-owner@vger.kernel.org Tue Nov 16 15:51:41 2010 27Return-path: <linux-kernel-owner@vger.kernel.org> 28Envelope-to: glk-linux-kernel-3@lo.gmane.org 29Received: from vger.kernel.org ([209.132.180.67]) 30 by lo.gmane.org with esmtp (Exim 4.69) 31 (envelope-from <linux-kernel-owner@vger.kernel.org>) 32 id 1PIMsn-0003tR-Ee 33 for glk-linux-kernel-3@lo.gmane.org; Tue, 16 Nov 2010 15:51:41 +0100 34Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand 35 id S1758690Ab0KPOvV (ORCPT <rfc822;glk-linux-kernel-3@m.gmane.org>); 36 Tue, 16 Nov 2010 09:51:21 -0500 37Received: from mail.perches.com ([173.55.12.10]:1433 "EHLO mail.perches.com" 38 rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP 39 id S1755918Ab0KPOvU (ORCPT <rfc822;linux-kernel@vger.kernel.org>); 40 Tue, 16 Nov 2010 09:51:20 -0500 41Received: from [192.168.1.162] (unknown [192.168.1.162]) 42 by mail.perches.com (Postfix) with ESMTP id 38D5C24368; 43 Tue, 16 Nov 2010 06:49:10 -0800 (PST) 44In-Reply-To: <20101116104921.GL12986@rakim.wolfsonmicro.main> 45X-Mailer: Evolution 2.30.3 46Sender: linux-kernel-owner@vger.kernel.org 47Precedence: bulk 48List-ID: <linux-kernel.vger.kernel.org> 49X-Mailing-List: linux-kernel@vger.kernel.org 50Archived-At: <http://permalink.gmane.org/gmane.linux.kernel/1063175> 51 52On Tue, 2010-11-16 at 10:49 +0000, Mark Brown wrote: 53> On Mon, Nov 15, 2010 at 11:52:53AM -0800, Joe Perches wrote: 54> > On Mon, 2010-11-15 at 19:34 +0000, Mark Brown wrote: 55> > > It appears your scripts are already hooked into get_maintainers.pl which 56> > > would seem the obvious place to do this? Sadly I don't do perl, though 57> > > it looks like you're doing pretty much all the work on that anyway. 58> > Sadly, no it's not the right place. 59> To query MAINTAINERS? I'd assume that's where you'd want to put that 60> stuff? 61 62I trimmed cc's and added Andrew Morton and Florian Mickler. 63First thread link for them: http://lkml.org/lkml/2010/11/15/262 64 65I use get_maintainer to find email addresses with 66"git send-email --cc-cmd=" but sure it could be extended 67to find some other new information in the MAINTAINERS file. 68 69Anyway, I think that get_maintainers isn't the proper tool 70to rewrite commit subject lines, though it could certainly 71do the lookup of a key in the MAINTAINERS file. 72 73Maybe add a new MAINTAINERS section line something like: 74 "C: CommitSubjectGrammarStyle" 75where CommitSubjectGrammarStyle is something more 76information rich than "style 1", "style 2". 77 78Perhaps you'll propose a grammar to convert path to header 79and go through and add these "C:" style entries to the 80sections you maintain. 81 82Also, what would you expect the output to be when a single 83patch modified files from 2 subsystems that use different 84styles? 85 86cheers, Joe 87 88 89 90