1Litecoin Core version 0.18.1 is now available from: 2 3 <https://download.litecoin.org/litecoin-0.18.1/> 4 5This is a major version release, including new features, various bug 6fixes and performance improvements, as well as updated translations. 7 8Please report bugs using the issue tracker at GitHub: 9 10 <https://github.com/litecoin-project/litecoin/issues> 11 12To receive security and update notifications, please subscribe to: 13 14 <https://groups.google.com/forum/#!forum/litecoin-dev> 15 16How to Upgrade 17============== 18 19If you are running an older version, shut it down. Wait until it has 20completely shut down (which might take a few minutes for older 21versions), then run the installer (on Windows) or just copy over 22`/Applications/Litecoin-Qt` (on Mac) or `litecoind`/`litecoin-qt` (on 23Linux). 24 25The first time you run version 0.15.0 or newer, your chainstate database 26will be converted to a new format, which will take anywhere from a few 27minutes to half an hour, depending on the speed of your machine. 28 29Note that the block database format also changed in version 0.8.0 and 30there is no automatic upgrade code from before version 0.8 to version 310.15.0 or later. Upgrading directly from 0.7.x and earlier without 32redownloading the blockchain is not supported. However, as usual, old 33wallet versions are still supported. 34 35Compatibility 36============== 37 38Litecoin Core is supported and extensively tested on operating systems 39using the Linux kernel, macOS 10.10+, and Windows 7 and newer. It is not 40recommended to use Litecoin Core on unsupported systems. 41 42Litecoin Core should also work on most other Unix-like systems but is not 43as frequently tested on them. 44 45From 0.17.0 onwards, macOS <10.10 is no longer supported. 0.17.0 is 46built using Qt 5.9.x, which doesn't support versions of macOS older than 4710.10. Additionally, Litecoin Core does not yet change appearance when 48macOS "dark mode" is activated. 49 50In addition to previously-supported CPU platforms, this release's 51pre-compiled distribution also provides binaries for the RISC-V 52platform. 53 54Known issues 55============ 56 57Wallet GUI 58---------- 59 60For advanced users who have both (1) enabled coin control features, and 61(2) are using multiple wallets loaded at the same time: The coin control 62input selection dialog can erroneously retain wrong-wallet state when 63switching wallets using the dropdown menu. For now, it is recommended 64not to use coin control features with multiple wallets loaded. 65 66Notable changes 67=============== 68 69Mining 70------ 71 72- Calls to `getblocktemplate` will fail if the segwit rule is not 73 specified. Calling `getblocktemplate` without segwit specified is 74 almost certainly a misconfiguration since doing so results in lower 75 rewards for the miner. Failed calls will produce an error message 76 describing how to enable the segwit rule. 77 78Configuration option changes 79---------------------------- 80 81- A warning is printed if an unrecognized section name is used in the 82 configuration file. Recognized sections are `[test]`, `[main]`, and 83 `[regtest]`. 84 85- Four new options are available for configuring the maximum number of 86 messages that ZMQ will queue in memory (the "high water mark") before 87 dropping additional messages. The default value is 1,000, the same as 88 was used for previous releases. See the [ZMQ 89 documentation](https://github.com/litecoin-project/litecoin/blob/master/doc/zmq.md#usage) 90 for details. 91 92- The `rpcallowip` option can no longer be used to automatically listen 93 on all network interfaces. Instead, the `rpcbind` parameter must be 94 used to specify the IP addresses to listen on. Listening for RPC 95 commands over a public network connection is insecure and should be 96 disabled, so a warning is now printed if a user selects such a 97 configuration. If you need to expose RPC in order to use a tool like 98 Docker, ensure you only bind RPC to your localhost, e.g. `docker run 99 [...] -p 127.0.0.1:9332:9332` (this is an extra `:9332` over the 100 normal Docker port specification). 101 102- The `rpcpassword` option now causes a startup error if the password 103 set in the configuration file contains a hash character (#), as it's 104 ambiguous whether the hash character is meant for the password or as a 105 comment. 106 107- The `whitelistforcerelay` option is used to relay transactions from 108 whitelisted peers even when not accepted to the mempool. This option 109 now defaults to being off, so that changes in policy and 110 disconnect/ban behavior will not cause a node that is whitelisting 111 another to be dropped by peers. Users can still explicitly enable 112 this behavior with the command line option (and may want to consider 113 [contacting](mailto:contact@litecoin.org) the Litecoin Core 114 project to let us know about their use-case, as this feature could be 115 deprecated in the future). 116 117Wallet changes 118-------------- 119When creating a transaction with a fee above `-maxtxfee` (default 0.1 LTC), 120the RPC commands `walletcreatefundedpsbt` and `fundrawtransaction` will now fail 121instead of rounding down the fee. Beware that the `feeRate` argument is specified 122in LTC per kilobyte, not litoshi per byte. 123 124Documentation 125------------- 126 127- A new short [document](https://github.com/litecoin-project/litecoin/blob/master/doc/JSON-RPC-interface.md) 128 about the JSON-RPC interface describes cases where the results of an 129 RPC might contain inconsistencies between data sourced from different 130 subsystems, such as wallet state and mempool state. A note is added 131 to the [REST interface documentation](https://github.com/litecoin-project/litecoin/blob/master/doc/REST-interface.md) 132 indicating that the same rules apply. 133 134- Further information is added to the [JSON-RPC 135 documentation](https://github.com/litecoin-project/litecoin/blob/master/doc/JSON-RPC-interface.md) 136 about how to secure this interface. 137 138- A new [document](https://github.com/litecoin-project/litecoin/blob/master/doc/litecoin-conf.md) 139 about the `litecoin.conf` file describes how to use it to configure 140 Litecoin Core. 141 142- A new document introduces Litecoin Core's BIP174 [Partially-Signed 143 Litecoin Transactions 144 (PSBT)](https://github.com/litecoin-project/litecoin/blob/master/doc/psbt.md) 145 interface, which is used to allow multiple programs to collaboratively 146 work to create, sign, and broadcast new transactions. This is useful 147 for offline (cold storage) wallets, multisig wallets, coinjoin 148 implementations, and many other cases where two or more programs need 149 to interact to generate a complete transaction. 150 151- The [output script 152 descriptor](https://github.com/litecoin-project/litecoin/blob/master/doc/descriptors.md) 153 documentation has been updated with information about new features in 154 this still-developing language for describing the output scripts that 155 a wallet or other program wants to receive notifications for, such as 156 which addresses it wants to know received payments. The language is 157 currently used in multiple new and updated RPCs described in these 158 release notes and is expected to be adapted to other RPCs and to the 159 underlying wallet structure. 160 161Build system changes 162-------------------- 163 164- A new `--disable-bip70` option may be passed to `./configure` to 165 prevent Litecoin-Qt from being built with support for the BIP70 payment 166 protocol or from linking libssl. As the payment protocol has exposed 167 Litecoin Core to libssl vulnerabilities in the past, builders who don't 168 need BIP70 support are encouraged to use this option to reduce their 169 exposure to future vulnerabilities. 170 171- The minimum required version of Qt (when building the GUI) has been 172 increased from 5.2 to 5.5.1 (the [depends 173 system](https://github.com/litecoin-project/litecoin/blob/master/depends/README.md) 174 provides 5.9.7) 175 176New RPCs 177-------- 178 179- `getnodeaddresses` returns peer addresses known to this node. It may 180 be used to find nodes to connect to without using a DNS seeder. 181 182- `listwalletdir` returns a list of wallets in the wallet directory 183 (either the default wallet directory or the directory configured by 184 the `-walletdir` parameter). 185 186- `getrpcinfo` returns runtime details of the RPC server. At the moment, 187 it returns an array of the currently active commands and how long 188 they've been running. 189 190- `deriveaddresses` returns one or more addresses corresponding to an 191 [output descriptor](https://github.com/litecoin-project/litecoin/blob/master/doc/descriptors.md). 192 193- `getdescriptorinfo` accepts a descriptor and returns information about 194 it, including its computed checksum. 195 196- `joinpsbts` merges multiple distinct PSBTs into a single PSBT. The 197 multiple PSBTs must have different inputs. The resulting PSBT will 198 contain every input and output from all of the PSBTs. Any signatures 199 provided in any of the PSBTs will be dropped. 200 201- `analyzepsbt` examines a PSBT and provides information about what 202 the PSBT contains and the next steps that need to be taken in order 203 to complete the transaction. For each input of a PSBT, `analyzepsbt` 204 provides information about what information is missing for that 205 input, including whether a UTXO needs to be provided, what pubkeys 206 still need to be provided, which scripts need to be provided, and 207 what signatures are still needed. Every input will also list which 208 role is needed to complete that input, and `analyzepsbt` will also 209 list the next role in general needed to complete the PSBT. 210 `analyzepsbt` will also provide the estimated fee rate and estimated 211 virtual size of the completed transaction if it has enough 212 information to do so. 213 214- `utxoupdatepsbt` searches the set of Unspent Transaction Outputs 215 (UTXOs) to find the outputs being spent by the partial transaction. 216 PSBTs need to have the UTXOs being spent to be provided because 217 the signing algorithm requires information from the UTXO being spent. 218 For segwit inputs, only the UTXO itself is necessary. For 219 non-segwit outputs, the entire previous transaction is needed so 220 that signers can be sure that they are signing the correct thing. 221 Unfortunately, because the UTXO set only contains UTXOs and not full 222 transactions, `utxoupdatepsbt` will only add the UTXO for segwit 223 inputs. 224 225Updated RPCs 226------------ 227 228Note: some low-level RPC changes mainly useful for testing are described 229in the Low-level Changes section below. 230 231- `getpeerinfo` now returns an additional `minfeefilter` field set to 232 the peer's BIP133 fee filter. You can use this to detect that you 233 have peers that are willing to accept transactions below the default 234 minimum relay fee. 235 236- The mempool RPCs, such as `getrawmempool` with `verbose=true`, now 237 return an additional "bip125-replaceable" value indicating whether the 238 transaction (or its unconfirmed ancestors) opts-in to asking nodes and 239 miners to replace it with a higher-feerate transaction spending any of 240 the same inputs. 241 242- `settxfee` previously silently ignored attempts to set the fee below 243 the allowed minimums. It now prints a warning. The special value of 244 "0" may still be used to request the minimum value. 245 246- `getaddressinfo` now provides an `ischange` field indicating whether 247 the wallet used the address in a change output. 248 249- `importmulti` has been updated to support P2WSH, P2WPKH, P2SH-P2WPKH, 250 and P2SH-P2WSH. Requests for P2WSH and P2SH-P2WSH accept an additional 251 `witnessscript` parameter. 252 253- `importmulti` now returns an additional `warnings` field for each 254 request with an array of strings explaining when fields are being 255 ignored or are inconsistent, if there are any. 256 257- `getaddressinfo` now returns an additional `solvable` boolean field 258 when Litecoin Core knows enough about the address's scriptPubKey, 259 optional redeemScript, and optional witnessScript in order for the 260 wallet to be able to generate an unsigned input spending funds sent to 261 that address. 262 263- The `getaddressinfo`, `listunspent`, and `scantxoutset` RPCs now 264 return an additional `desc` field that contains an output descriptor 265 containing all key paths and signing information for the address 266 (except for the private key). The `desc` field is only returned for 267 `getaddressinfo` and `listunspent` when the address is solvable. 268 269- `importprivkey` will preserve previously-set labels for addresses or 270 public keys corresponding to the private key being imported. For 271 example, if you imported a watch-only address with the label "cold 272 wallet" in earlier releases of Litecoin Core, subsequently importing 273 the private key would default to resetting the address's label to the 274 default empty-string label (""). In this release, the previous label 275 of "cold wallet" will be retained. If you optionally specify any 276 label besides the default when calling `importprivkey`, the new label 277 will be applied to the address. 278 279- See the [Mining](#mining) section for changes to `getblocktemplate`. 280 281- `getmininginfo` now omits `currentblockweight` and `currentblocktx` 282 when a block was never assembled via RPC on this node. 283 284- The `getrawtransaction` RPC & REST endpoints no longer check the 285 unspent UTXO set for a transaction. The remaining behaviors are as 286 follows: 1. If a blockhash is provided, check the corresponding block. 287 2. If no blockhash is provided, check the mempool. 3. If no blockhash 288 is provided but txindex is enabled, also check txindex. 289 290- `unloadwallet` is now synchronous, meaning it will not return until 291 the wallet is fully unloaded. 292 293- `importmulti` now supports importing of addresses from descriptors. A 294 "desc" parameter can be provided instead of the "scriptPubKey" in a 295 request, as well as an optional range for ranged descriptors to 296 specify the start and end of the range to import. Descriptors with key 297 origin information imported through `importmulti` will have their key 298 origin information stored in the wallet for use with creating PSBTs. 299 More information about descriptors can be found 300 [here](https://github.com/litecoin-project/litecoin/blob/master/doc/descriptors.md). 301 302- `listunspent` has been modified so that it also returns 303 `witnessScript`, the witness script in the case of a P2WSH or 304 P2SH-P2WSH output. 305 306- `createwallet` now has an optional `blank` argument that can be used 307 to create a blank wallet. Blank wallets do not have any keys or HD 308 seed. They cannot be opened in software older than 0.18. Once a blank 309 wallet has a HD seed set (by using `sethdseed`) or private keys, 310 scripts, addresses, and other watch only things have been imported, 311 the wallet is no longer blank and can be opened in 0.17.x. Encrypting 312 a blank wallet will also set a HD seed for it. 313 314Deprecated or removed RPCs 315-------------------------- 316 317- `signrawtransaction` is removed after being deprecated and hidden 318 behind a special configuration option in version 0.17.0. 319 320- The 'account' API is removed after being deprecated in v0.17. The 321 'label' API was introduced in v0.17 as a replacement for accounts. 322 See the [release notes from 323 v0.17](https://github.com/litecoin-project/litecoin/blob/master/doc/release-notes/release-notes-0.17.0.md#label-and-account-apis-for-wallet) 324 for a full description of the changes from the 'account' API to the 325 'label' API. 326 327- `addwitnessaddress` is removed after being deprecated in version 328 0.16.0. 329 330- `generate` is deprecated and will be fully removed in a subsequent 331 major version. This RPC is only used for testing, but its 332 implementation reached across multiple subsystems (wallet and mining), 333 so it is being deprecated to simplify the wallet-node interface. 334 Projects that are using `generate` for testing purposes should 335 transition to using the `generatetoaddress` RPC, which does not 336 require or use the wallet component. Calling `generatetoaddress` with 337 an address returned by the `getnewaddress` RPC gives the same 338 functionality as the old `generate` RPC. To continue using `generate` 339 in this version, restart litecoind with the `-deprecatedrpc=generate` 340 configuration option. 341 342- Be reminded that parts of the `validateaddress` command have been 343 deprecated and moved to `getaddressinfo`. The following deprecated 344 fields have moved to `getaddressinfo`: `ismine`, `iswatchonly`, 345 `script`, `hex`, `pubkeys`, `sigsrequired`, `pubkey`, `embedded`, 346 `iscompressed`, `label`, `timestamp`, `hdkeypath`, `hdmasterkeyid`. 347 348- The `addresses` field has been removed from the `validateaddress` 349 and `getaddressinfo` RPC methods. This field was confusing since 350 it referred to public keys using their P2PKH address. Clients 351 should use the `embedded.address` field for P2SH or P2WSH wrapped 352 addresses, and `pubkeys` for inspecting multisig participants. 353 354REST changes 355------------ 356 357- A new `/rest/blockhashbyheight/` endpoint is added for fetching the 358 hash of the block in the current best blockchain based on its height 359 (how many blocks it is after the Genesis Block). 360 361Graphical User Interface (GUI) 362------------------------------ 363 364- A new Window menu is added alongside the existing File, Settings, and 365 Help menus. Several items from the other menus that opened new 366 windows have been moved to this new Window menu. 367 368- In the Send tab, the checkbox for "pay only the required fee" has been 369 removed. Instead, the user can simply decrease the value in the 370 Custom Feerate field all the way down to the node's configured minimum 371 relay fee. 372 373- In the Overview tab, the watch-only balance will be the only balance 374 shown if the wallet was created using the `createwallet` RPC and the 375 `disable_private_keys` parameter was set to true. 376 377- The launch-on-startup option is no longer available on macOS if 378 compiled with macosx min version greater than 10.11 (use 379 CXXFLAGS="-mmacosx-version-min=10.11" 380 CFLAGS="-mmacosx-version-min=10.11" for setting the deployment sdk 381 version) 382 383Tools 384----- 385 386- A new `litecoin-wallet` tool is now distributed alongside Litecoin 387 Core's other executables. Without needing to use any RPCs, this tool 388 can currently create a new wallet file or display some basic 389 information about an existing wallet, such as whether the wallet is 390 encrypted, whether it uses an HD seed, how many transactions it 391 contains, and how many address book entries it has. 392 393Planned changes 394=============== 395 396This section describes planned changes to Litecoin Core that may affect 397other Litecoin software and services. 398 399- Since version 0.16.0, Litecoin Core’s built-in wallet has defaulted to 400 generating P2SH-wrapped segwit addresses when users want to receive 401 payments. These addresses are backwards compatible with all 402 widely-used software. Starting with Litecoin Core 0.20 (expected about 403 a year after 0.18), Litecoin Core will default to native segwit 404 addresses (bech32) that provide additional fee savings and other 405 benefits. Currently, many wallets and services already support sending 406 to bech32 addresses, and if the Litecoin Core project sees enough 407 additional adoption, it will instead default to bech32 receiving 408 addresses in Litecoin Core 0.20. 409 P2SH-wrapped segwit addresses will continue to be provided if the user 410 requests them in the GUI or by RPC, and anyone who doesn’t want the 411 update will be able to configure their default address type. 412 (Similarly, pioneering users who want to change their default now may 413 set the `addresstype=bech32` configuration option in any Litecoin Core 414 release from 0.16.0 up.) 415 416Deprecated P2P messages 417----------------------- 418 419- BIP 61 reject messages are now deprecated. Reject messages have no use 420 case on the P2P network and are only logged for debugging by most 421 network nodes. Furthermore, they increase bandwidth and can be harmful 422 for privacy and security. It has been possible to disable BIP 61 423 messages since v0.17 with the `-enablebip61=0` option. BIP 61 messages 424 will be disabled by default in a future version, before being removed 425 entirely. 426 427Low-level changes 428================= 429 430This section describes RPC changes mainly useful for testing, mostly not 431relevant in production. The changes are mentioned for completeness. 432 433RPC 434--- 435 436- The `submitblock` RPC previously returned the reason a rejected block 437 was invalid the first time it processed that block, but returned a 438 generic "duplicate" rejection message on subsequent occasions it 439 processed the same block. It now always returns the fundamental 440 reason for rejecting an invalid block and only returns "duplicate" for 441 valid blocks it has already accepted. 442 443- A new `submitheader` RPC allows submitting block headers independently 444 from their block. This is likely only useful for testing. 445 446- The `signrawtransactionwithkey` and `signrawtransactionwithwallet` 447 RPCs have been modified so that they also optionally accept a 448 `witnessScript`, the witness script in the case of a P2WSH or 449 P2SH-P2WSH output. This is compatible with the change to 450 `listunspent`. 451 452- For the `walletprocesspsbt` and `walletcreatefundedpsbt` RPCs, if the 453 `bip32derivs` parameter is set to true but the key metadata for a 454 public key has not been updated yet, then that key will have a 455 derivation path as if it were just an independent key (i.e. no 456 derivation path and its master fingerprint is itself). 457 458Configuration 459------------- 460 461- The `-usehd` configuration option was removed in version 0.16. From 462 that version onwards, all new wallets created are hierarchical 463 deterministic wallets. This release makes specifying `-usehd` an 464 invalid configuration option. 465 466Network 467------- 468 469- This release allows peers that your node automatically disconnected 470 for misbehavior (e.g. sending invalid data) to reconnect to your node 471 if you have unused incoming connection slots. If your slots fill up, 472 a misbehaving node will be disconnected to make room for nodes without 473 a history of problems (unless the misbehaving node helps your node in 474 some other way, such as by connecting to a part of the Internet from 475 which you don't have many other peers). Previously, Litecoin Core 476 banned the IP addresses of misbehaving peers for a period of time 477 (default of 1 day); this was easily circumvented by attackers with 478 multiple IP addresses. If you manually ban a peer, such as by using 479 the `setban` RPC, all connections from that peer will still be 480 rejected. 481 482Wallet 483------- 484 485- The key metadata will need to be upgraded the first time that the HD 486 seed is available. For unencrypted wallets this will occur on wallet 487 loading. For encrypted wallets this will occur the first time the 488 wallet is unlocked. 489 490- Newly encrypted wallets will no longer require restarting the 491 software. Instead such wallets will be completely unloaded and 492 reloaded to achieve the same effect. 493 494- A sub-project of Litecoin Core now provides Hardware Wallet Interaction 495 (HWI) scripts that allow command-line users to use several popular 496 hardware key management devices with Litecoin Core. See their [project 497 page](https://github.com/bitcoin-core/HWI#readme) for details. 498 499Security 500-------- 501 502- This release changes the Random Number Generator (RNG) used from 503 OpenSSL to Litecoin Core's own implementation, although entropy 504 gathered by Litecoin Core is fed out to OpenSSL and then read back in 505 when the program needs strong randomness. This moves Litecoin Core a 506 little closer to no longer needing to depend on OpenSSL, a dependency 507 that has caused security issues in the past. The new implementation 508 gathers entropy from multiple sources, including from hardware 509 supporting the rdseed CPU instruction. 510 511Changes for particular platforms 512-------------------------------- 513 514- On macOS, Litecoin Core now opts out of application CPU throttling 515 ("app nap") during initial blockchain download, when catching up from 516 over 100 blocks behind the current chain tip, or when reindexing chain 517 data. This helps prevent these operations from taking an excessively 518 long time because the operating system is attempting to conserve 519 power. 520 5210.18.1 change log 522================= 523 524### Consensus 525- #14247 Fix crash bug with duplicate inputs within a transaction (TheBlueMatt) 526 527### Mining 528- #14811 Mining: Enforce that segwit option must be set in GBT (jnewbery) 529 530### Block and transaction handling 531- #13310 Report progress in ReplayBlocks while rolling forward (promag) 532- #13783 validation: Pass tx pool reference into CheckSequenceLocks (MarcoFalke) 533- #14834 validation: Assert that pindexPrev is non-null when required (kallewoof) 534- #14085 index: Fix for indexers skipping genesis block (jimpo) 535- #14963 mempool, validation: Explain `cs_main` locking semantics (MarcoFalke) 536- #15193 Default `-whitelistforcerelay` to off (sdaftuar) 537- #15429 Update `assumevalid`, `minimumchainwork`, and `getchaintxstats` to height 563378 (gmaxwell) 538- #15552 Granular invalidateblock and RewindBlockIndex (MarcoFalke) 539- #14841 Move CheckBlock() call to critical section (hebasto) 540 541### P2P protocol and network code 542- #14025 Remove dead code for nVersion=10300 (MarcoFalke) 543- #12254 BIP 158: Compact Block Filters for Light Clients (jimpo) 544- #14073 blockfilter: Avoid out-of-bounds script access (jimpo) 545- #14140 Switch nPrevNodeCount to vNodesSize (pstratem) 546- #14027 Skip stale tip checking if outbound connections are off or if reindexing (gmaxwell) 547- #14532 Never bind `INADDR_ANY` by default, and warn when doing so explicitly (luke-jr) 548- #14733 Make peer timeout configurable, speed up very slow test and ensure correct code path tested (zallarak) 549- #14336 Implement poll (pstratem) 550- #15051 IsReachable is the inverse of IsLimited (DRY). Includes unit tests (mmachicao) 551- #15138 Drop IsLimited in favor of IsReachable (Empact) 552- #14605 Return of the Banman (dongcarl) 553- #14970 Add dnsseed.emzy.de to DNS seeds (Emzy) 554- #14929 Allow connections from misbehavior banned peers (gmaxwell) 555- #15345 Correct comparison of addr count (dongcarl) 556- #15201 Add missing locking annotation for vNodes. vNodes is guarded by cs_vNodes (practicalswift) 557- #14626 Select orphan transaction uniformly for eviction (sipa) 558- #15486 Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups (sdaftuar) 559- #15990 Add tests and documentation for blocksonly (MarcoFalke) 560- #16021 Avoid logging transaction decode errors to stderr (MarcoFalke) 561- #16405 fix: tor: Call `event_base_loopbreak` from the event's callback (promag) 562- #16412 Make poll in InterruptibleRecv only filter for POLLIN events (tecnovert) 563 564### Wallet 565- #13962 Remove unused `dummy_tx` variable from FillPSBT (dongcarl) 566- #13967 Don't report `minversion` wallet entry as unknown (instagibbs) 567- #13988 Add checks for settxfee reasonableness (ajtowns) 568- #12559 Avoid locking `cs_main` in some wallet RPC (promag) 569- #13631 Add CMerkleTx::IsImmatureCoinBase method (Empact) 570- #14023 Remove accounts RPCs (jnewbery) 571- #13825 Kill accounts (jnewbery) 572- #10605 Add AssertLockHeld assertions in CWallet::ListCoins (ryanofsky) 573- #12490 Remove deprecated wallet rpc features from `bitcoin_server` (jnewbery) 574- #14138 Set `encrypted_batch` to nullptr after delete. Avoid double free in the case of NDEBUG (practicalswift) 575- #14168 Remove `ENABLE_WALLET` from `libbitcoin_server.a` (jnewbery) 576- #12493 Reopen CDBEnv after encryption instead of shutting down (achow101) 577- #14282 Remove `-usehd` option (jnewbery) 578- #14146 Remove trailing separators from `-walletdir` arg (PierreRochard) 579- #14291 Add ListWalletDir utility function (promag) 580- #14468 Deprecate `generate` RPC method (jnewbery) 581- #11634 Add missing `cs_wallet`/`cs_KeyStore` locks to wallet (practicalswift) 582- #14296 Remove `addwitnessaddress` (jnewbery) 583- #14451 Add BIP70 deprecation warning and allow building GUI without BIP70 support (jameshilliard) 584- #14320 Fix duplicate fileid detection (ken2812221) 585- #14561 Remove `fs::relative` call and fix listwalletdir tests (promag) 586- #14454 Add SegWit support to importmulti (MeshCollider) 587- #14410 rpcwallet: `ischange` field for `getaddressinfo` RPC (mrwhythat) 588- #14350 Add WalletLocation class (promag) 589- #14689 Require a public key to be retrieved when signing a P2PKH input (achow101) 590- #14478 Show error to user when corrupt wallet unlock fails (MeshCollider) 591- #14411 Restore ability to list incoming transactions by label (ryanofsky) 592- #14552 Detect duplicate wallet by comparing the db filename (ken2812221) 593- #14678 Remove redundant KeyOriginInfo access, already done in CreateSig (instagibbs) 594- #14477 Add ability to convert solvability info to descriptor (sipa) 595- #14380 Fix assert crash when specified change output spend size is unknown (instagibbs) 596- #14760 Log env path in `BerkeleyEnvironment::Flush` (promag) 597- #14646 Add expansion cache functions to descriptors (unused for now) (sipa) 598- #13076 Fix ScanForWalletTransactions to return an enum indicating scan result: `success` / `failure` / `user_abort` (Empact) 599- #14821 Replace CAffectedKeysVisitor with descriptor based logic (sipa) 600- #14957 Initialize `stop_block` in CWallet::ScanForWalletTransactions (Empact) 601- #14565 Overhaul `importmulti` logic (sipa) 602- #15039 Avoid leaking nLockTime fingerprint when anti-fee-sniping (MarcoFalke) 603- #14268 Introduce SafeDbt to handle Dbt with free or `memory_cleanse` raii-style (Empact) 604- #14711 Remove uses of chainActive and mapBlockIndex in wallet code (ryanofsky) 605- #15279 Clarify rescanblockchain doc (MarcoFalke) 606- #15292 Remove `boost::optional`-related false positive -Wmaybe-uninitialized warnings on GCC compiler (hebasto) 607- #13926 [Tools] bitcoin-wallet - a tool for creating and managing wallets offline (jnewbery) 608- #11911 Free BerkeleyEnvironment instances when not in use (ryanofsky) 609- #15235 Do not import private keys to wallets with private keys disabled (achow101) 610- #15263 Descriptor expansions only need pubkey entries for PKH/WPKH (sipa) 611- #15322 Add missing `cs_db` lock (promag) 612- #15297 Releases dangling files on `BerkeleyEnvironment::Close` (promag) 613- #14491 Allow descriptor imports with importmulti (MeshCollider) 614- #15365 Add lock annotation for mapAddressBook (MarcoFalke) 615- #15226 Allow creating blank (empty) wallets (alternative) (achow101) 616- #15390 [wallet-tool] Close bdb when flushing wallet (jnewbery) 617- #15334 Log absolute paths for the wallets (hebasto) 618- #14978 Factor out PSBT utilities from RPCs for use in GUI code; related refactoring (gwillen) 619- #14481 Add P2SH-P2WSH support to listunspent RPC (MeshCollider) 620- #14021 Import key origin data through descriptors in importmulti (achow101) 621- #14075 Import watch only pubkeys to the keypool if private keys are disabled (achow101) 622- #15368 Descriptor checksums (sipa) 623- #15433 Use a single wallet batch for `UpgradeKeyMetadata` (jonasschnelli) 624- #15408 Remove unused `TransactionError` constants (MarcoFalke) 625- #15583 Log and ignore errors in ListWalletDir and IsBerkeleyBtree (promag) 626- #14195 Pass privkey export DER compression flag correctly (fingera) 627- #15299 Fix assertion in `CKey::SignCompact` (promag) 628- #14437 Start to separate wallet from node (ryanofsky) 629- #15749 Fix: importmulti only imports origin info for PKH outputs (sipa) 630- #15913 Add -ignorepartialspends to list of ignored wallet options (luke-jr) 631 632### RPC and other APIs 633- #12842 Prevent concurrent `savemempool` (promag) 634- #13987 Report `minfeefilter` value in `getpeerinfo` RPC (ajtowns) 635- #13891 Remove getinfo deprecation warning (jnewbery) 636- #13399 Add `submitheader` (MarcoFalke) 637- #12676 Show `bip125-replaceable` flag, when retrieving mempool entries (dexX7) 638- #13723 PSBT key path cleanups (sipa) 639- #14008 Preserve a format of RPC command definitions (kostyantyn) 640- #9332 Let wallet `importmulti` RPC accept labels for standard scriptPubKeys (ryanofsky) 641- #13983 Return more specific reject reason for submitblock (MarcoFalke) 642- #13152 Add getnodeaddresses RPC command (chris-belcher) 643- #14298 rest: Improve performance for JSON calls (alecalve) 644- #14297 Remove warning for removed estimatefee RPC (jnewbery) 645- #14373 Consistency fixes for RPC descriptions (ch4ot1c) 646- #14150 Add key origin support to descriptors (sipa) 647- #14518 Always throw in getblockstats if `-txindex` is required (promag) 648- #14060 ZMQ: add options to configure outbound message high water mark, aka SNDHWM (mruddy) 649- #13381 Add possibility to preserve labels on importprivkey (marcoagner) 650- #14530 Use `RPCHelpMan` to generate RPC doc strings (MarcoFalke) 651- #14720 Correctly name RPC arguments (MarcoFalke) 652- #14726 Use `RPCHelpMan` for all RPCs (MarcoFalke) 653- #14796 Pass argument descriptions to `RPCHelpMan` (MarcoFalke) 654- #14670 http: Fix HTTP server shutdown (promag) 655- #14885 Assert that named arguments are unique in `RPCHelpMan` (promag) 656- #14877 Document default values for optional arguments (MarcoFalke) 657- #14875 RPCHelpMan: Support required arguments after optional ones (MarcoFalke) 658- #14993 Fix data race (UB) in InterruptRPC() (practicalswift) 659- #14653 rpcwallet: Add missing transaction categories to RPC helptexts (andrewtoth) 660- #14981 Clarify RPC `getrawtransaction`'s time help text (benthecarman) 661- #12151 Remove `cs_main` lock from blockToJSON and blockheaderToJSON (promag) 662- #15078 Document `bytessent_per_msg` and `bytesrecv_per_msg` (MarcoFalke) 663- #15057 Correct `reconsiderblock `help text, add test (MarcoFalke) 664- #12153 Avoid permanent `cs_main` lock in `getblockheader` (promag) 665- #14982 Add `getrpcinfo` command (promag) 666- #15122 Expand help text for `importmulti` changes (jnewbery) 667- #15186 remove duplicate solvable field from `getaddressinfo` (fanquake) 668- #15209 zmq: log outbound message high water mark when reusing socket (fanquake) 669- #15177 rest: Improve tests and documention of /headers and /block (promag) 670- #14353 rest: Add blockhash call, fetch blockhash by height (jonasschnelli) 671- #15248 Compile on GCC4.8 (MarcoFalke) 672- #14987 RPCHelpMan: Pass through Result and Examples (MarcoFalke) 673- #15159 Remove lookup to UTXO set from GetTransaction (amitiuttarwar) 674- #15245 remove deprecated mentions of signrawtransaction from fundraw help (instagibbs) 675- #14667 Add `deriveaddresses` RPC util method (Sjors) 676- #15357 Don't ignore `-maxtxfee` when wallet is disabled (JBaczuk) 677- #15337 Fix for segfault if combinepsbt called with empty inputs (benthecarman) 678- #14918 RPCHelpMan: Check default values are given at compile-time (MarcoFalke) 679- #15383 mining: Omit uninitialized currentblockweight, currentblocktx (MarcoFalke) 680- #13932 Additional utility RPCs for PSBT (achow101) 681- #15401 Actually throw help when passed invalid number of params (MarcoFalke) 682- #15471 rpc/gui: Remove 'Unknown block versions being mined' warning (laanwj) 683- #15497 Consistent range arguments in scantxoutset/importmulti/deriveaddresses (sipa) 684- #15510 deriveaddresses: add range to CRPCConvertParam (Sjors) 685- #15582 Fix overflow bug in analyzepsbt fee: CAmount instead of int (sipa) 686- #13424 Consistently validate txid / blockhash length and encoding in rpc calls (Empact) 687- #15750 Remove the addresses field from the getaddressinfo return object (jnewbery) 688- #15991 Bugfix: fix pruneblockchain returned prune height (jonasschnelli) 689- #15899 Document iswitness flag and fix bug in converttopsbt (MarcoFalke) 690- #16026 Ensure that uncompressed public keys in a multisig always returns a legacy address (achow101) 691- #14039 Disallow extended encoding for non-witness transactions (sipa) 692- #16210 add 2nd arg to signrawtransactionwithkey examples (dooglus) 693- #16250 signrawtransactionwithkey: report error when missing redeemScript/witnessScript (ajtowns) 694 695### GUI 696- #13634 Compile `boost::signals2` only once (MarcoFalke) 697- #13248 Make proxy icon from statusbar clickable (mess110) 698- #12818 TransactionView: highlight replacement tx after fee bump (Sjors) 699- #13529 Use new Qt5 connect syntax (promag) 700- #14162 Also log and print messages or questions like bitcoind (MarcoFalke) 701- #14385 Avoid system harfbuzz and bz2 (theuni) 702- #14450 Fix QCompleter popup regression (hebasto) 703- #14177 Set C locale for amountWidget (hebasto) 704- #14374 Add `Blocksdir` to Debug window (hebasto) 705- #14554 Remove unused `adjustedTime` parameter (hebasto) 706- #14228 Enable system tray icon by default if available (hebasto) 707- #14608 Remove the "Pay only required fee…" checkbox (hebasto) 708- #14521 qt, docs: Fix `bitcoin-qt -version` output formatting (hebasto) 709- #13966 When private key is disabled, only show watch-only balance (ken2812221) 710- #14828 Remove hidden columns in coin control dialog (promag) 711- #14783 Fix `boost::signals2::no_slots_error` in early calls to InitWarning (promag) 712- #14854 Cleanup SplashScreen class (hebasto) 713- #14801 Use window() instead of obsolete topLevelWidget() (hebasto) 714- #14573 Add Window menu (promag) 715- #14979 Restore < Qt5.6 compatibility for addAction (jonasschnelli) 716- #14975 Refactoring with QString::toNSString() (hebasto) 717- #15000 Fix broken notificator on GNOME (hebasto) 718- #14375 Correct misleading "overridden options" label (hebasto) 719- #15007 Notificator class refactoring (hebasto) 720- #14784 Use `WalletModel*` instead of the wallet name as map key (promag) 721- #11625 Add BitcoinApplication & RPCConsole tests (ryanofsky) 722- #14517 Fix start with the `-min` option (hebasto) 723- #13216 implements concept for different disk sizes on intro (marcoagner) 724- #15114 Replace remaining 0 with nullptr (Empact) 725- #14594 Fix minimized window bug on Linux (hebasto) 726- #14556 Fix confirmed transaction labeled "open" (#13299) (hebasto) 727- #15149 Show current wallet name in window title (promag) 728- #15136 "Peers" tab overhaul (hebasto) 729- #14250 Remove redundant stopThread() and stopExecutor() signals (hebasto) 730- #15040 Add workaround for QProgressDialog bug on macOS (hebasto) 731- #15101 Add WalletController (promag) 732- #15178 Improve "help-console" message (hebasto) 733- #15210 Fix window title update (promag) 734- #15167 Fix wallet selector size adjustment (hebasto) 735- #15208 Remove macOS launch-at-startup when compiled with > macOS 10.11, fix memory mismanagement (jonasschnelli) 736- #15163 Correct units for "-dbcache" and "-prune" (hebasto) 737- #15225 Change the receive button to respond to keypool state changing (achow101) 738- #15280 Fix shutdown order (promag) 739- #15203 Fix issue #9683 "gui, wallet: random abort (segmentation fault) (dooglus) 740- #15091 Fix model overlay header sync (jonasschnelli) 741- #15153 Add Open Wallet menu (promag) 742- #15183 Fix `m_assumed_blockchain_size` variable value (marcoagner) 743- #15063 If BIP70 is disabled, attempt to fall back to BIP21 parsing (luke-jr) 744- #15195 Add Close Wallet action (promag) 745- #15462 Fix async open wallet call order (promag) 746- #15801 Bugfix: GUI: Options: Initialise prune setting range before loading current value, and remove upper bound limit (luke-jr) 747- #16044 fix the bug of OPEN CONFIGURATION FILE on Mac (shannon1916) 748- #15957 Show "No wallets available" in open menu instead of nothing (meshcollider) 749- #16118 Enable open wallet menu on setWalletController (promag) 750- #16135 Set progressDialog to nullptr (promag) 751- #16231 Fix open wallet menu initialization order (promag) 752- #16254 Set `AA_EnableHighDpiScaling` attribute early (hebasto) 753- #16122 Enable console line edit on setClientModel (promag) 754- #16348 Assert QMetaObject::invokeMethod result (promag) 755 756### Build system 757- #13955 gitian: Bump descriptors for (0.)18 (fanquake) 758- #13899 Enable -Wredundant-decls where available. Remove redundant redeclarations (practicalswift) 759- #13665 Add RISC-V support to gitian (ken2812221) 760- #14062 Generate MSVC project files via python script (ken2812221) 761- #14037 Add README.md to linux release tarballs (hebasto) 762- #14183 Remove unused Qt 4 dependencies (ken2812221) 763- #14127 Avoid getifaddrs when unavailable (greenaddress) 764- #14184 Scripts and tools: increased timeout downloading (cisba) 765- #14204 Move `interfaces/*` to `libbitcoin_server` (laanwj) 766- #14208 Actually remove `ENABLE_WALLET` (jnewbery) 767- #14212 Remove libssl from LDADD unless GUI (MarcoFalke) 768- #13578 Upgrade zeromq to 4.2.5 and avoid deprecated zeromq API functions (mruddy) 769- #14281 lcov: filter /usr/lib/ from coverage reports (MarcoFalke) 770- #14325 gitian: Use versioned unsigned tarballs instead of generically named ones (achow101) 771- #14253 During 'make clean', remove some files that are currently missed (murrayn) 772- #14455 Unbreak `make clean` (jamesob) 773- #14495 Warn (don't fail!) on spelling errors (practicalswift) 774- #14496 Pin to specific versions of Python packages we install from PyPI in Travis (practicalswift) 775- #14568 Fix Qt link order for Windows build (ken2812221) 776- #14252 Run functional tests and benchmarks under the undefined behaviour sanitizer (UBSan) (practicalswift) 777- #14612 Include full version number in released file names (achow101) 778- #14840 Remove duplicate libconsensus linking in test make (AmirAbrams) 779- #14564 Adjust configure so that only BIP70 is disabled when protobuf is missing instead of the GUI (jameshilliard) 780- #14883 Add `--retry 5` to curl opts in `install_db4.sh` (qubenix) 781- #14701 Add `CLIENT_VERSION_BUILD` to CFBundleGetInfoString (fanquake) 782- #14849 Qt 5.9.7 (fanquake) 783- #15020 Add names to Travis jobs (gkrizek) 784- #15047 Allow to configure --with-sanitizers=fuzzer (MarcoFalke) 785- #15154 Configure: bitcoin-tx doesn't need libevent, so don't pull it in (luke-jr) 786- #15175 Drop macports support (Empact) 787- #15308 Restore compatibility with older boost (Empact) 788- #15407 msvc: Fix silent merge conflict between #13926 and #14372 part II (ken2812221) 789- #15388 Makefile.am: add rule for src/bitcoin-wallet (Sjors) 790- #15393 Bump minimum Qt version to 5.5.1 (Sjors) 791- #15285 Prefer Python 3.4 even if newer versions are present on the system (Sjors) 792- #15398 msvc: Add rapidcheck property tests (ken2812221) 793- #15431 msvc: scripted-diff: Remove NDEBUG pre-define in project file (ken2812221) 794- #15549 gitian: Improve error handling (laanwj) 795- #15548 use full version string in setup.exe (MarcoFalke) 796- #11526 Visual Studio build configuration for Bitcoin Core (sipsorcery) 797- #15110 build\_msvc: Fix the build problem in `libbitcoin_server` (Mr-Leshiy) 798- #14372 msvc: build secp256k1 and leveldb locally (ken2812221) 799- #15325 msvc: Fix silent merge conflict between #13926 and #14372 (ken2812221) 800- #15391 Add compile time verification of assumptions we're currently making implicitly/tacitly (practicalswift) 801- #15503 msvc: Use a single file to specify the include path (ken2812221) 802- #13765 contrib: Add gitian build support for github pull request (ken2812221) 803- #15809 gitignore: plist and dat (jamesob) 804- #15985 Add test for GCC bug 90348 (sipa) 805- #15947 Install bitcoin-wallet manpage (domob1812) 806- #15983 build with -fstack-reuse=none (MarcoFalke) 807 808### Tests and QA 809- #15405 appveyor: Clean cache when build configuration changes (Sjors) 810- #13953 Fix deprecation in bitcoin-util-test.py (isghe) 811- #13963 Replace usage of tostring() with tobytes() (dongcarl) 812- #13964 ci: Add appveyor ci (ken2812221) 813- #13997 appveyor: fetch the latest port data (ken2812221) 814- #13707 Add usage note to check-rpc-mappings.py (masonicboom) 815- #14036 travis: Run unit tests --with-sanitizers=undefined (MarcoFalke) 816- #13861 Add testing of `value_ret` for SelectCoinsBnB (Empact) 817- #13863 travis: Move script sections to files in `.travis/` subject to shellcheck (scravy) 818- #14081 travis: Fix missing differentiation between unit and functional tests (scravy) 819- #14042 travis: Add cxxflags=-wno-psabi at arm job (ken2812221) 820- #14051 Make `combine_logs.py` handle multi-line logs (jnewbery) 821- #14093 Fix accidental trunction from int to bool (practicalswift) 822- #14108 Add missing locking annotations and locks (`g_cs_orphans`) (practicalswift) 823- #14088 Don't assert(…) with side effects (practicalswift) 824- #14086 appveyor: Use clcache to speed up build (ken2812221) 825- #13954 Warn (don't fail!) on spelling errors. Fix typos reported by codespell (practicalswift) 826- #12775 Integration of property based testing into Bitcoin Core (Christewart) 827- #14119 Read reject reasons from debug log, not P2P messages (MarcoFalke) 828- #14189 Fix silent merge conflict in `wallet_importmulti` (MarcoFalke) 829- #13419 Speed up `knapsack_solver_test` by not recreating wallet 100 times (lucash-dev) 830- #14199 Remove redundant BIP174 test from `rpc_psbt.json` (araspitzu) 831- #14179 Fixups to "Run all tests even if wallet is not compiled" (MarcoFalke) 832- #14225 Reorder tests and move most of extended tests up to normal tests (ken2812221) 833- #14236 `generate` --> `generatetoaddress` change to allow tests run without wallet (sanket1729) 834- #14287 Use MakeUnique to construct objects owned by `unique_ptrs` (practicalswift) 835- #14007 Run functional test on Windows and enable it on Appveyor (ken2812221) 836- #14275 Write the notification message to different files to avoid race condition in `feature_notifications.py` (ken2812221) 837- #14306 appveyor: Move AppVeyor YAML to dot-file-style YAML (MitchellCash) 838- #14305 Enforce critical class instance attributes in functional tests, fix segwit test specificity (JustinTArthur) 839- #12246 Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled (luke-jr) 840- #14316 Exclude all tests with difference parameters in `--exclude` list (ken2812221) 841- #14381 Add missing call to `skip_if_no_cli()` (practicalswift) 842- #14389 travis: Set codespell version to avoid breakage (MarcoFalke) 843- #14398 Don't access out of bounds array index: array[sizeof(array)] (Empact) 844- #14419 Remove `rpc_zmq.py` (jnewbery) 845- #14241 appveyor: Script improvement (ken2812221) 846- #14413 Allow closed RPC handler in `assert_start_raises_init_error` (ken2812221) 847- #14324 Run more tests with wallet disabled (MarcoFalke) 848- #13649 Allow arguments to be forwarded to flake8 in lint-python.sh (jamesob) 849- #14465 Stop node before removing the notification file (ken2812221) 850- #14460 Improve 'CAmount' tests (hebasto) 851- #14456 forward timeouts properly in `send_blocks_and_test` (jamesob) 852- #14527 Revert "Make qt wallet test compatible with qt4" (MarcoFalke) 853- #14504 Show the progress of functional tests (isghe) 854- #14559 appveyor: Enable multiwallet tests (ken2812221) 855- #13515 travis: Enable qt for all jobs (ken2812221) 856- #14571 Test that nodes respond to `getdata` with `notfound` (MarcoFalke) 857- #14569 Print dots by default in functional tests (ken2812221) 858- #14631 Move deterministic address import to `setup_nodes` (jnewbery) 859- #14630 test: Remove travis specific code (MarcoFalke) 860- #14528 travis: Compile once on xenial (MarcoFalke) 861- #14092 Dry run `bench_bitcoin` as part `make check` to allow for quick identification of assertion/sanitizer failures in benchmarking code (practicalswift) 862- #14664 `example_test.py`: fixup coinbase height argument, derive number clearly (instagibbs) 863- #14522 Add invalid P2P message tests (jamesob) 864- #14619 Fix value display name in `test_runner` help text (merland) 865- #14672 Send fewer spam messages in `p2p_invalid_messages` (jamesob) 866- #14673 travis: Fail the ubsan travis build in case of newly introduced ubsan errors (practicalswift) 867- #14665 appveyor: Script improvement part II (ken2812221) 868- #14365 Add Python dead code linter (vulture) to Travis (practicalswift) 869- #14693 `test_node`: `get_mem_rss` fixups (MarcoFalke) 870- #14714 util.h: explicitly include required QString header (1Il1) 871- #14705 travis: Avoid timeout on verify-commits check (MarcoFalke) 872- #14770 travis: Do not specify sudo in `.travis` (scravy) 873- #14719 Check specific reject reasons in `feature_block` (MarcoFalke) 874- #14771 Add `BOOST_REQUIRE` to getters returning optional (MarcoFalke) 875- #14777 Add regtest for JSON-RPC batch calls (domob1812) 876- #14764 travis: Run thread sanitizer on unit tests (MarcoFalke) 877- #14400 Add Benchmark to test input de-duplication worst case (JeremyRubin) 878- #14812 Fix `p2p_invalid_messages` on macOS (jamesob) 879- #14813 Add `wallet_encryption` error tests (MarcoFalke) 880- #14820 Fix `descriptor_tests` not checking ToString output of public descriptors (ryanofsky) 881- #14794 Add AddressSanitizer (ASan) Travis build (practicalswift) 882- #14819 Bugfix: `test/functional/mempool_accept`: Ensure oversize transaction is actually oversize (luke-jr) 883- #14822 bench: Destroy wallet txs instead of leaking their memory (MarcoFalke) 884- #14683 Better `combine_logs.py` behavior (jamesob) 885- #14231 travis: Save cache even when build or test fail (ken2812221) 886- #14816 Add CScriptNum decode python implementation in functional suite (instagibbs) 887- #14861 Modify `rpc_bind` to conform to #14532 behaviour (dongcarl) 888- #14864 Run scripted-diff in subshell (dongcarl) 889- #14795 Allow `test_runner` command line to receive parameters for each test (marcoagner) 890- #14788 Possible fix the permission error when the tests open the cookie file (ken2812221) 891- #14857 `wallet_keypool_topup.py`: Test for all keypool address types (instagibbs) 892- #14886 Refactor importmulti tests (jnewbery) 893- #14908 Removed implicit CTransaction constructor calls from tests and benchmarks (lucash-dev) 894- #14903 Handle ImportError explicitly, improve comparisons against None (daniel-s-ingram) 895- #14884 travis: Enforce python 3.4 support through linter (Sjors) 896- #14940 Add test for truncated pushdata script (MarcoFalke) 897- #14926 consensus: Check that final transactions are valid (MarcoFalke) 898- #14937 travis: Fix travis would always be green even if it fail (ken2812221) 899- #14953 Make `g_insecure_rand_ctx` `thread_local` (MarcoFalke) 900- #14931 mempool: Verify prioritization is dumped correctly (MarcoFalke) 901- #14935 Test for expected return values when calling functions returning a success code (practicalswift) 902- #14969 Fix `cuckoocache_tests` TSAN failure introduced in 14935 (practicalswift) 903- #14964 Fix race in `mempool_accept` (MarcoFalke) 904- #14829 travis: Enable functional tests in the threadsanitizer (tsan) build job (practicalswift) 905- #14985 Remove `thread_local` from `test_bitcoin` (MarcoFalke) 906- #15005 Bump timeout to run tests in travis thread sanitizer (MarcoFalke) 907- #15013 Avoid race in `p2p_timeouts` (MarcoFalke) 908- #14960 lint/format-strings: Correctly exclude escaped percent symbols (luke-jr) 909- #14930 pruning: Check that verifychain can be called when pruned (MarcoFalke) 910- #15022 Upgrade Travis OS to Xenial (gkrizek) 911- #14738 Fix running `wallet_listtransactions.py` individually through `test_runner.py` (kristapsk) 912- #15026 Rename `rpc_timewait` to `rpc_timeout` (MarcoFalke) 913- #15069 Fix `rpc_net.py` `pong` race condition (Empact) 914- #14790 Allow running `rpc_bind.py` --nonloopback test without IPv6 (kristapsk) 915- #14457 add invalid tx templates for use in functional tests (jamesob) 916- #14855 Correct ineffectual WithOrVersion from `transactions_tests` (Empact) 917- #15099 Use `std::vector` API for construction of test data (domob1812) 918- #15102 Run `invalid_txs.InputMissing` test in `feature_block` (MarcoFalke) 919- #15059 Add basic test for BIP34 (MarcoFalke) 920- #15108 Tidy up `wallet_importmulti.py` (amitiuttarwar) 921- #15164 Ignore shellcheck warning SC2236 (promag) 922- #15170 refactor/lint: Add ignored shellcheck suggestions to an array (koalaman) 923- #14958 Remove race between connecting and shutdown on separate connections (promag) 924- #15166 Pin shellcheck version (practicalswift) 925- #15196 Update all `subprocess.check_output` functions to be Python 3.4 compatible (gkrizek) 926- #15043 Build fuzz targets into seperate executables (MarcoFalke) 927- #15276 travis: Compile once on trusty (MarcoFalke) 928- #15246 Add tests for invalid message headers (MarcoFalke) 929- #15301 When testing with --usecli, unify RPC arg to cli arg conversion and handle dicts and lists (achow101) 930- #15247 Use wallet to retrieve raw transactions (MarcoFalke) 931- #15303 travis: Remove unused `functional_tests_config` (MarcoFalke) 932- #15330 Fix race in `p2p_invalid_messages` (MarcoFalke) 933- #15324 Make bloom tests deterministic (MarcoFalke) 934- #15328 travis: Revert "run extended tests once daily" (MarcoFalke) 935- #15327 Make test `updatecoins_simulation_test` deterministic (practicalswift) 936- #14519 add utility to easily profile node performance with perf (jamesob) 937- #15349 travis: Only exit early if compilation took longer than 30 min (MarcoFalke) 938- #15350 Drop RPC connection if --usecli (promag) 939- #15370 test: Remove unused --force option (MarcoFalke) 940- #14543 minor `p2p_sendheaders` fix of height in coinbase (instagibbs) 941- #13787 Test for Windows encoding issue (ken2812221) 942- #15378 Added missing tests for RPC wallet errors (benthecarman) 943- #15238 remove some magic mining constants in functional tests (instagibbs) 944- #15411 travis: Combine --disable-bip70 into existing job (MarcoFalke) 945- #15295 fuzz: Add `test/fuzz/test_runner.py` and run it in travis (MarcoFalke) 946- #15413 Add missing `cs_main` locks required when accessing pcoinsdbview, pcoinsTip or pblocktree (practicalswift) 947- #15399 fuzz: Script validation flags (MarcoFalke) 948- #15410 txindex: interrupt threadGroup before calling destructor (MarcoFalke) 949- #15397 Remove manual byte editing in `wallet_tx_clone` func test (instagibbs) 950- #15415 functional: allow custom cwd, use tmpdir as default (Sjors) 951- #15404 Remove `-txindex` to start nodes (amitiuttarwar) 952- #15439 remove `byte.hex()` to keep compatibility (AkioNak) 953- #15419 Always refresh cache to be out of ibd (MarcoFalke) 954- #15507 Bump timeout on tests that timeout on windows (MarcoFalke) 955- #15506 appveyor: fix cache issue and reduce dependencies build time (ken2812221) 956- #15485 add `rpc_misc.py`, mv test getmemoryinfo, add test mallocinfo (adamjonas) 957- #15321 Add `cs_main` lock annotations for mapBlockIndex (MarcoFalke) 958- #14128 lint: Make sure we read the command line inputs using UTF-8 decoding in python (ken2812221) 959- #14115 lint: Make all linters work under the default macos dev environment (build-osx.md) (practicalswift) 960- #15219 lint: Enable python linters via an array (Empact) 961- #15826 Pure python EC (sipa) 962- #15893 Add test for superfluous witness record in deserialization (instagibbs) 963- #14818 Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions (luke-jr) 964- #15831 Add test that addmultisigaddress fails for watchonly addresses (MarcoFalke) 965 966### Platform support 967- #13866 utils: Use `_wfopen` and `_wfreopen` on windows (ken2812221) 968- #13886 utils: Run commands using UTF-8 string on windows (ken2812221) 969- #14192 utils: Convert `fs::filesystem_error` messages from local multibyte to UTF-8 on windows (ken2812221) 970- #13877 utils: Make fs::path::string() always return UTF-8 string on windows (ken2812221) 971- #13883 utils: Convert windows args to UTF-8 string (ken2812221) 972- #13878 utils: Add fstream wrapper to allow to pass unicode filename on windows (ken2812221) 973- #14426 utils: Fix broken windows filelock (ken2812221) 974- #14686 Fix windows build error if `--disable-bip70` (ken2812221) 975- #14922 windows: Set `_WIN32_WINNT` to 0x0601 (Windows 7) (ken2812221) 976- #13888 Call unicode API on Windows (ken2812221) 977- #15468 Use `fsbridge::ifstream` to fix Windows path issue (ken2812221) 978- #13734 Drop `boost::scoped_array` and use `wchar_t` API explicitly on Windows (ken2812221) 979- #13884 Enable bdb unicode support for Windows (ken2812221) 980 981### Miscellaneous 982- #13935 contrib: Adjust output to current test format (AkioNak) 983- #14097 validation: Log FormatStateMessage on ConnectBlock error in ConnectTip (MarcoFalke) 984- #13724 contrib: Support ARM and RISC-V symbol check (ken2812221) 985- #13159 Don't close old debug log file handle prematurely when trying to re-open (on SIGHUP) (practicalswift) 986- #14186 bitcoin-cli: don't translate command line options (HashUnlimited) 987- #14057 logging: Only log `using config file path_to_bitcoin.conf` message on startup if conf file exists (leishman) 988- #14164 Update univalue subtree (MarcoFalke) 989- #14272 init: Remove deprecated args from hidden args (MarcoFalke) 990- #14494 Error if # is used in rpcpassword in conf (MeshCollider) 991- #14742 Properly generate salt in rpcauth.py (dongcarl) 992- #14708 Warn unrecognised sections in the config file (AkioNak) 993- #14756 Improve rpcauth.py by using argparse and getpass modules (promag) 994- #14785 scripts: Fix detection of copyright holders (cornelius) 995- #14831 scripts: Use `#!/usr/bin/env bash` instead of `#!/bin/bash` (vim88) 996- #14869 Scripts: Add trusted key for samuel dobson (laanwj) 997- #14809 Tools: improve verify-commits.py script (jlopp) 998- #14624 Some simple improvements to the RNG code (sipa) 999- #14947 scripts: Remove python 2 import workarounds (practicalswift) 1000- #15087 Error if rpcpassword contains hash in conf sections (MeshCollider) 1001- #14433 Add checksum in gitian build scripts for ossl (TheCharlatan) 1002- #15165 contrib: Allow use of github api authentication in github-merge (laanwj) 1003- #14409 utils and libraries: Make 'blocksdir' always net specific (hebasto) 1004- #14839 threads: Fix unitialized members in `sched_param` (fanquake) 1005- #14955 Switch all RNG code to the built-in PRNG (sipa) 1006- #15258 Scripts and tools: Fix `devtools/copyright_header.py` to always honor exclusions (Empact) 1007- #12255 Update bitcoin.service to conform to init.md (dongcarl) 1008- #15266 memory: Construct globals on first use (MarcoFalke) 1009- #15347 Fix build after pr 15266 merged (hebasto) 1010- #15351 Update linearize-hashes.py (OverlordQ) 1011- #15358 util: Add setuphelpoptions() (MarcoFalke) 1012- #15216 Scripts and tools: Replace script name with a special parameter (hebasto) 1013- #15250 Use RdSeed when available, and reduce RdRand load (sipa) 1014- #15278 Improve PID file error handling (hebasto) 1015- #15270 Pull leveldb subtree (MarcoFalke) 1016- #15456 Enable PID file creation on WIN (riordant) 1017- #12783 macOS: disable AppNap during sync (krab) 1018- #13910 Log progress while verifying blocks at level 4 (domob1812) 1019- #15124 Fail AppInitMain if either disk space check fails (Empact) 1020- #15117 Fix invalid memory write in case of failing mmap(…) in PosixLockedPageAllocator::AllocateLocked (practicalswift) 1021- #14357 streams: Fix broken `streams_vector_reader` test. Remove unused `seek(size_t)` 1022- #11640 Make `LOCK`, `LOCK2`, `TRY_LOCK` work with CWaitableCriticalSection (ryanofsky) 1023- #14074 Use `std::unordered_set` instead of `set` in blockfilter interface (jimpo) 1024- #15275 Add gitian PGP key for hebasto (hebasto) 1025- #16095 Catch by reference not value in wallettool (kristapsk) 1026- #16205 Replace fprintf with tfm::format (MarcoFalke) 1027 1028### Documentation 1029- #14120 Notes about control port and read access to cookie (JBaczuk) 1030- #14135 correct GetDifficulty doc after #13288 (fanquake) 1031- #14013 Add new regtest ports in man following #10825 ports reattributions (ariard) 1032- #14149 Remove misleading checkpoints comment in CMainParams (MarcoFalke) 1033- #14153 Add disable-wallet section to OSX build instructions, update line in Unix instructions (bitstein) 1034- #13662 Explain when reindex-chainstate can be used instead of reindex (Sjors) 1035- #14207 `-help-debug` implies `-help` (laanwj) 1036- #14213 Fix reference to lint-locale-dependence.sh (hebasto) 1037- #14206 Document `-checklevel` levels (laanwj) 1038- #14217 Add GitHub PR template (MarcoFalke) 1039- #14331 doxygen: Fix member comments (MarcoFalke) 1040- #14264 Split depends installation instructions per arch (MarcoFalke) 1041- #14393 Add missing apt-get install (poiuty) 1042- #14428 Fix macOS files description in qt/README.md (hebasto) 1043- #14390 release process: RPC documentation (karel-3d) 1044- #14472 getblocktemplate: use SegWit in example (Sjors) 1045- #14497 Add doc/bitcoin-conf.md (hebasto) 1046- #14526 Document lint tests (fanquake) 1047- #14511 Remove explicit storage requirement from README.md (merland) 1048- #14600 Clarify commit message guidelines (merland) 1049- #14617 FreeBSD: Document Python 3 requirement for 'gmake check' (murrayn) 1050- #14592 Add external interface consistency guarantees (MarcoFalke) 1051- #14625 Make clear function argument case in dev notes (dongcarl) 1052- #14515 Update OpenBSD build guide for 6.4 (fanquake) 1053- #14436 Add comment explaining recentRejects-DoS behavior (jamesob) 1054- #14684 conf: Remove deprecated options from docs, Other cleanup (MarcoFalke) 1055- #14731 Improve scripted-diff developer docs (dongcarl) 1056- #14778 A few minor formatting fixes and clarifications to descriptors.md (jnewbery) 1057- #14448 Clarify rpcwallet flag url change (JBaczuk) 1058- #14808 Clarify RPC rawtransaction documentation (jlopp) 1059- #14804 Less confusing documentation for `torpassword` (fanquake) 1060- #14848 Fix broken Gmane URL in security-check.py (cyounkins-bot) 1061- #14882 developer-notes.md: Point out that UniValue deviates from upstream (Sjors) 1062- #14909 Update minimum required Qt (fanquake) 1063- #14914 Add nice table to files.md (emilengler) 1064- #14741 Indicate `-rpcauth` option password hashing alg (dongcarl) 1065- #14950 Add NSIS setup/install steps to windows docs (fanquake) 1066- #13930 Better explain GetAncestor check for `m_failed_blocks` in AcceptBlockHeader (Sjors) 1067- #14973 Improve Windows native build instructions (murrayn) 1068- #15073 Botbot.me (IRC logs) not available anymore (anduck) 1069- #15038 Get more info about GUI-related issue on Linux (hebasto) 1070- #14832 Add more Doxygen information to Developer Notes (ch4ot1c) 1071- #15128 Fix download link in doc/README.md (merland) 1072- #15127 Clarifying testing instructions (benthecarman) 1073- #15132 Add FreeBSD build notes link to doc/README.md (fanquake) 1074- #15173 Explain what .python-version does (Sjors) 1075- #15223 Add information about security to the JSON-RPC doc (harding) 1076- #15249 Update python docs to reflect that wildcard imports are disallowed (Empact) 1077- #15176 Get rid of badly named `doc/README_osx.md` (merland) 1078- #15272 Correct logging return type and RPC example (fanquake) 1079- #15244 Gdb attaching to process during tests has non-sudo solution (instagibbs) 1080- #15332 Small updates to `getrawtransaction` description (amitiuttarwar) 1081- #15354 Add missing `bitcoin-wallet` tool manpages (MarcoFalke) 1082- #15343 netaddress: Make IPv4 loopback comment more descriptive (dongcarl) 1083- #15353 Minor textual improvements in `translation_strings_policy.md` (merland) 1084- #15426 importmulti: add missing description of keypool option (harding) 1085- #15425 Add missing newline to listunspent help for witnessScript (harding) 1086- #15348 Add separate productivity notes document (dongcarl) 1087- #15416 Update FreeBSD build guide for 12.0 (fanquake) 1088- #15222 Add info about factors that affect dependency list (merland) 1089- #13676 Explain that mempool memory is added to `-dbcache` (Sjors) 1090- #15273 Slight tweak to the verify-commits script directions (droark) 1091- #15477 Remove misleading hint in getrawtransaction (MarcoFalke) 1092- #15489 Update release process for snap package (MarcoFalke) 1093- #15524 doc: Remove berkeleydb PPA from linux build instructions (MarcoFalke) 1094- #15559 Correct `analyzepsbt` rpc doc (fanquake) 1095- #15194 Add comment describing `fDisconnect` behavior (dongcarl) 1096- #15754 getrpcinfo docs (benthecarman) 1097- #15763 Update bips.md for 0.18.0 (sipa) 1098- #15757 List new RPCs in psbt.md and descriptors.md (sipa) 1099- #15765 correct bitcoinconsensus_version in shared-libraries.md (fanquake) 1100- #15792 describe onlynet option in doc/tor.md (jonatack) 1101- #15802 mention creating application support bitcoin folder on OSX (JimmyMow) 1102- #15799 Clarify RPC versioning (MarcoFalke) 1103- #15890 Remove text about txes always relayed from -whitelist (harding) 1104 1105Credits 1106======= 1107 1108Thanks to everyone who directly contributed to this release: 1109 1110- [The Bitcoin Core Developers](https://github.com/bitcoin/bitcoin/tree/master/doc/release-notes) 1111- Adrian Gallagher 1112- aunyks 1113- coblee 1114- cryptonexii 1115- EP1JUNE 1116- gabrieldov 1117- jmutkawoa 1118- Martin Smith 1119- NeMO84 1120- OlegKozhemiakin 1121- ppm0 1122- romanornr 1123- shaolinfry 1124- spl0i7 1125- stedwms 1126- ultragtx 1127- VKoskiv 1128- voidmain 1129- wbsmolen 1130- xinxi