xref: /dragonfly/sys/dev/drm/i915/intel_dp_mst.c (revision a05eeebf)
1 /*
2  * Copyright © 2008 Intel Corporation
3  *             2014 Red Hat Inc.
4  *
5  * Permission is hereby granted, free of charge, to any person obtaining a
6  * copy of this software and associated documentation files (the "Software"),
7  * to deal in the Software without restriction, including without limitation
8  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9  * and/or sell copies of the Software, and to permit persons to whom the
10  * Software is furnished to do so, subject to the following conditions:
11  *
12  * The above copyright notice and this permission notice (including the next
13  * paragraph) shall be included in all copies or substantial portions of the
14  * Software.
15  *
16  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
19  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
21  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
22  * IN THE SOFTWARE.
23  *
24  */
25 
26 #include <drm/drmP.h>
27 #include "i915_drv.h"
28 #include "intel_drv.h"
29 #include <drm/drm_atomic_helper.h>
30 #include <drm/drm_crtc_helper.h>
31 #include <drm/drm_edid.h>
32 
33 #if 0
34 static bool intel_dp_mst_compute_config(struct intel_encoder *encoder,
35 					struct intel_crtc_state *pipe_config)
36 {
37 	struct drm_device *dev = encoder->base.dev;
38 	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
39 	struct intel_digital_port *intel_dig_port = intel_mst->primary;
40 	struct intel_dp *intel_dp = &intel_dig_port->dp;
41 	struct drm_atomic_state *state;
42 	int bpp, i;
43 	int lane_count, slots, rate;
44 	struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
45 	struct drm_connector *drm_connector;
46 	struct intel_connector *connector, *found = NULL;
47 	struct drm_connector_state *connector_state;
48 	int mst_pbn;
49 
50 	pipe_config->dp_encoder_is_mst = true;
51 	pipe_config->has_pch_encoder = false;
52 	pipe_config->has_dp_encoder = true;
53 	bpp = 24;
54 	/*
55 	 * for MST we always configure max link bw - the spec doesn't
56 	 * seem to suggest we should do otherwise.
57 	 */
58 	lane_count = drm_dp_max_lane_count(intel_dp->dpcd);
59 
60 	rate = intel_dp_max_link_rate(intel_dp);
61 
62 	if (intel_dp->num_sink_rates) {
63 		intel_dp->link_bw = 0;
64 		intel_dp->rate_select = intel_dp_rate_select(intel_dp, rate);
65 	} else {
66 		intel_dp->link_bw = drm_dp_link_rate_to_bw_code(rate);
67 		intel_dp->rate_select = 0;
68 	}
69 
70 	intel_dp->lane_count = lane_count;
71 
72 	pipe_config->pipe_bpp = 24;
73 	pipe_config->port_clock = rate;
74 
75 	state = pipe_config->base.state;
76 
77 	for_each_connector_in_state(state, drm_connector, connector_state, i) {
78 		connector = to_intel_connector(drm_connector);
79 
80 		if (connector_state->best_encoder == &encoder->base) {
81 			found = connector;
82 			break;
83 		}
84 	}
85 
86 	if (!found) {
87 		DRM_ERROR("can't find connector\n");
88 		return false;
89 	}
90 
91 	mst_pbn = drm_dp_calc_pbn_mode(adjusted_mode->clock, bpp);
92 
93 	pipe_config->pbn = mst_pbn;
94 	slots = drm_dp_find_vcpi_slots(&intel_dp->mst_mgr, mst_pbn);
95 
96 	intel_link_compute_m_n(bpp, lane_count,
97 			       adjusted_mode->crtc_clock,
98 			       pipe_config->port_clock,
99 			       &pipe_config->dp_m_n);
100 
101 	pipe_config->dp_m_n.tu = slots;
102 
103 	if (IS_HASWELL(dev) || IS_BROADWELL(dev))
104 		hsw_dp_set_ddi_pll_sel(pipe_config);
105 
106 	return true;
107 
108 }
109 
110 static void intel_mst_disable_dp(struct intel_encoder *encoder)
111 {
112 	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
113 	struct intel_digital_port *intel_dig_port = intel_mst->primary;
114 	struct intel_dp *intel_dp = &intel_dig_port->dp;
115 	int ret;
116 
117 	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
118 
119 	drm_dp_mst_reset_vcpi_slots(&intel_dp->mst_mgr, intel_mst->port);
120 
121 	ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
122 	if (ret) {
123 		DRM_ERROR("failed to update payload %d\n", ret);
124 	}
125 }
126 
127 static void intel_mst_post_disable_dp(struct intel_encoder *encoder)
128 {
129 	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
130 	struct intel_digital_port *intel_dig_port = intel_mst->primary;
131 	struct intel_dp *intel_dp = &intel_dig_port->dp;
132 
133 	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
134 
135 	/* this can fail */
136 	drm_dp_check_act_status(&intel_dp->mst_mgr);
137 	/* and this can also fail */
138 	drm_dp_update_payload_part2(&intel_dp->mst_mgr);
139 
140 	drm_dp_mst_deallocate_vcpi(&intel_dp->mst_mgr, intel_mst->port);
141 
142 	intel_dp->active_mst_links--;
143 	intel_mst->port = NULL;
144 	if (intel_dp->active_mst_links == 0) {
145 		intel_dig_port->base.post_disable(&intel_dig_port->base);
146 		intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
147 	}
148 }
149 
150 static void intel_mst_pre_enable_dp(struct intel_encoder *encoder)
151 {
152 	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
153 	struct intel_digital_port *intel_dig_port = intel_mst->primary;
154 	struct intel_dp *intel_dp = &intel_dig_port->dp;
155 	struct drm_device *dev = encoder->base.dev;
156 	struct drm_i915_private *dev_priv = dev->dev_private;
157 	enum port port = intel_dig_port->port;
158 	int ret;
159 	uint32_t temp;
160 	struct intel_connector *found = NULL, *connector;
161 	int slots;
162 	struct drm_crtc *crtc = encoder->base.crtc;
163 	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
164 
165 	for_each_intel_connector(dev, connector) {
166 		if (connector->base.state->best_encoder == &encoder->base) {
167 			found = connector;
168 			break;
169 		}
170 	}
171 
172 	if (!found) {
173 		DRM_ERROR("can't find connector\n");
174 		return;
175 	}
176 
177 	/* MST encoders are bound to a crtc, not to a connector,
178 	 * force the mapping here for get_hw_state.
179 	 */
180 	found->encoder = encoder;
181 
182 	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
183 	intel_mst->port = found->port;
184 
185 	if (intel_dp->active_mst_links == 0) {
186 		enum port port = intel_ddi_get_encoder_port(encoder);
187 
188 		/* FIXME: add support for SKL */
189 		if (INTEL_INFO(dev)->gen < 9)
190 			I915_WRITE(PORT_CLK_SEL(port),
191 				   intel_crtc->config->ddi_pll_sel);
192 
193 		intel_ddi_init_dp_buf_reg(&intel_dig_port->base);
194 
195 		intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON);
196 
197 
198 		intel_dp_start_link_train(intel_dp);
199 		intel_dp_complete_link_train(intel_dp);
200 		intel_dp_stop_link_train(intel_dp);
201 	}
202 
203 	ret = drm_dp_mst_allocate_vcpi(&intel_dp->mst_mgr,
204 				       intel_mst->port,
205 				       intel_crtc->config->pbn, &slots);
206 	if (ret == false) {
207 		DRM_ERROR("failed to allocate vcpi\n");
208 		return;
209 	}
210 
211 
212 	intel_dp->active_mst_links++;
213 	temp = I915_READ(DP_TP_STATUS(port));
214 	I915_WRITE(DP_TP_STATUS(port), temp);
215 
216 	ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
217 }
218 
219 static void intel_mst_enable_dp(struct intel_encoder *encoder)
220 {
221 	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
222 	struct intel_digital_port *intel_dig_port = intel_mst->primary;
223 	struct intel_dp *intel_dp = &intel_dig_port->dp;
224 	struct drm_device *dev = intel_dig_port->base.base.dev;
225 	struct drm_i915_private *dev_priv = dev->dev_private;
226 	enum port port = intel_dig_port->port;
227 	int ret;
228 
229 	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
230 
231 	if (wait_for((I915_READ(DP_TP_STATUS(port)) & DP_TP_STATUS_ACT_SENT),
232 		     1))
233 		DRM_ERROR("Timed out waiting for ACT sent\n");
234 
235 	ret = drm_dp_check_act_status(&intel_dp->mst_mgr);
236 
237 	ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr);
238 }
239 
240 static bool intel_dp_mst_enc_get_hw_state(struct intel_encoder *encoder,
241 				      enum pipe *pipe)
242 {
243 	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
244 	*pipe = intel_mst->pipe;
245 	if (intel_mst->port)
246 		return true;
247 	return false;
248 }
249 
250 static void intel_dp_mst_enc_get_config(struct intel_encoder *encoder,
251 					struct intel_crtc_state *pipe_config)
252 {
253 	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
254 	struct intel_digital_port *intel_dig_port = intel_mst->primary;
255 	struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
256 	struct drm_device *dev = encoder->base.dev;
257 	struct drm_i915_private *dev_priv = dev->dev_private;
258 	enum transcoder cpu_transcoder = pipe_config->cpu_transcoder;
259 	u32 temp, flags = 0;
260 
261 	pipe_config->has_dp_encoder = true;
262 
263 	temp = I915_READ(TRANS_DDI_FUNC_CTL(cpu_transcoder));
264 	if (temp & TRANS_DDI_PHSYNC)
265 		flags |= DRM_MODE_FLAG_PHSYNC;
266 	else
267 		flags |= DRM_MODE_FLAG_NHSYNC;
268 	if (temp & TRANS_DDI_PVSYNC)
269 		flags |= DRM_MODE_FLAG_PVSYNC;
270 	else
271 		flags |= DRM_MODE_FLAG_NVSYNC;
272 
273 	switch (temp & TRANS_DDI_BPC_MASK) {
274 	case TRANS_DDI_BPC_6:
275 		pipe_config->pipe_bpp = 18;
276 		break;
277 	case TRANS_DDI_BPC_8:
278 		pipe_config->pipe_bpp = 24;
279 		break;
280 	case TRANS_DDI_BPC_10:
281 		pipe_config->pipe_bpp = 30;
282 		break;
283 	case TRANS_DDI_BPC_12:
284 		pipe_config->pipe_bpp = 36;
285 		break;
286 	default:
287 		break;
288 	}
289 	pipe_config->base.adjusted_mode.flags |= flags;
290 	intel_dp_get_m_n(crtc, pipe_config);
291 
292 	intel_ddi_clock_get(&intel_dig_port->base, pipe_config);
293 }
294 
295 static int intel_dp_mst_get_ddc_modes(struct drm_connector *connector)
296 {
297 	struct intel_connector *intel_connector = to_intel_connector(connector);
298 	struct intel_dp *intel_dp = intel_connector->mst_port;
299 	struct edid *edid;
300 	int ret;
301 
302 	edid = drm_dp_mst_get_edid(connector, &intel_dp->mst_mgr, intel_connector->port);
303 	if (!edid)
304 		return 0;
305 
306 	ret = intel_connector_update_modes(connector, edid);
307 	kfree(edid);
308 
309 	return ret;
310 }
311 
312 static enum drm_connector_status
313 intel_dp_mst_detect(struct drm_connector *connector, bool force)
314 {
315 	struct intel_connector *intel_connector = to_intel_connector(connector);
316 	struct intel_dp *intel_dp = intel_connector->mst_port;
317 
318 	return drm_dp_mst_detect_port(connector, &intel_dp->mst_mgr, intel_connector->port);
319 }
320 
321 static int
322 intel_dp_mst_set_property(struct drm_connector *connector,
323 			  struct drm_property *property,
324 			  uint64_t val)
325 {
326 	return 0;
327 }
328 
329 static void
330 intel_dp_mst_connector_destroy(struct drm_connector *connector)
331 {
332 	struct intel_connector *intel_connector = to_intel_connector(connector);
333 
334 	if (!IS_ERR_OR_NULL(intel_connector->edid))
335 		kfree(intel_connector->edid);
336 
337 	drm_connector_cleanup(connector);
338 	kfree(connector);
339 }
340 
341 static const struct drm_connector_funcs intel_dp_mst_connector_funcs = {
342 	.dpms = drm_atomic_helper_connector_dpms,
343 	.detect = intel_dp_mst_detect,
344 	.fill_modes = drm_helper_probe_single_connector_modes,
345 	.set_property = intel_dp_mst_set_property,
346 	.atomic_get_property = intel_connector_atomic_get_property,
347 	.destroy = intel_dp_mst_connector_destroy,
348 	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
349 	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
350 };
351 
352 static int intel_dp_mst_get_modes(struct drm_connector *connector)
353 {
354 	return intel_dp_mst_get_ddc_modes(connector);
355 }
356 
357 static enum drm_mode_status
358 intel_dp_mst_mode_valid(struct drm_connector *connector,
359 			struct drm_display_mode *mode)
360 {
361 	/* TODO - validate mode against available PBN for link */
362 	if (mode->clock < 10000)
363 		return MODE_CLOCK_LOW;
364 
365 	if (mode->flags & DRM_MODE_FLAG_DBLCLK)
366 		return MODE_H_ILLEGAL;
367 
368 	return MODE_OK;
369 }
370 
371 static struct drm_encoder *intel_mst_atomic_best_encoder(struct drm_connector *connector,
372 							 struct drm_connector_state *state)
373 {
374 	struct intel_connector *intel_connector = to_intel_connector(connector);
375 	struct intel_dp *intel_dp = intel_connector->mst_port;
376 	struct intel_crtc *crtc = to_intel_crtc(state->crtc);
377 
378 	return &intel_dp->mst_encoders[crtc->pipe]->base.base;
379 }
380 
381 static struct drm_encoder *intel_mst_best_encoder(struct drm_connector *connector)
382 {
383 	struct intel_connector *intel_connector = to_intel_connector(connector);
384 	struct intel_dp *intel_dp = intel_connector->mst_port;
385 	return &intel_dp->mst_encoders[0]->base.base;
386 }
387 
388 static const struct drm_connector_helper_funcs intel_dp_mst_connector_helper_funcs = {
389 	.get_modes = intel_dp_mst_get_modes,
390 	.mode_valid = intel_dp_mst_mode_valid,
391 	.atomic_best_encoder = intel_mst_atomic_best_encoder,
392 	.best_encoder = intel_mst_best_encoder,
393 };
394 #endif
395 
396 static void intel_dp_mst_encoder_destroy(struct drm_encoder *encoder)
397 {
398 	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(encoder);
399 
400 	drm_encoder_cleanup(encoder);
401 	kfree(intel_mst);
402 }
403 
404 static const struct drm_encoder_funcs intel_dp_mst_enc_funcs = {
405 	.destroy = intel_dp_mst_encoder_destroy,
406 };
407 
408 #if 0
409 static bool intel_dp_mst_get_hw_state(struct intel_connector *connector)
410 {
411 	if (connector->encoder && connector->base.state->crtc) {
412 		enum pipe pipe;
413 		if (!connector->encoder->get_hw_state(connector->encoder, &pipe))
414 			return false;
415 		return true;
416 	}
417 	return false;
418 }
419 
420 static void intel_connector_add_to_fbdev(struct intel_connector *connector)
421 {
422 #ifdef CONFIG_DRM_FBDEV_EMULATION
423 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
424 	drm_fb_helper_add_one_connector(&dev_priv->fbdev->helper, &connector->base);
425 #endif
426 }
427 
428 static void intel_connector_remove_from_fbdev(struct intel_connector *connector)
429 {
430 #ifdef CONFIG_DRM_FBDEV_EMULATION
431 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
432 	drm_fb_helper_remove_one_connector(&dev_priv->fbdev->helper, &connector->base);
433 #endif
434 }
435 
436 static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port, const char *pathprop)
437 {
438 	struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);
439 	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
440 	struct drm_device *dev = intel_dig_port->base.base.dev;
441 	struct intel_connector *intel_connector;
442 	struct drm_connector *connector;
443 	int i;
444 
445 	intel_connector = intel_connector_alloc();
446 	if (!intel_connector)
447 		return NULL;
448 
449 	connector = &intel_connector->base;
450 	drm_connector_init(dev, connector, &intel_dp_mst_connector_funcs, DRM_MODE_CONNECTOR_DisplayPort);
451 	drm_connector_helper_add(connector, &intel_dp_mst_connector_helper_funcs);
452 
453 	intel_connector->unregister = intel_connector_unregister;
454 	intel_connector->get_hw_state = intel_dp_mst_get_hw_state;
455 	intel_connector->mst_port = intel_dp;
456 	intel_connector->port = port;
457 
458 	for (i = PIPE_A; i <= PIPE_C; i++) {
459 		drm_mode_connector_attach_encoder(&intel_connector->base,
460 						  &intel_dp->mst_encoders[i]->base.base);
461 	}
462 	intel_dp_add_properties(intel_dp, connector);
463 
464 	drm_object_attach_property(&connector->base, dev->mode_config.path_property, 0);
465 	drm_object_attach_property(&connector->base, dev->mode_config.tile_property, 0);
466 
467 	drm_mode_connector_set_path_property(connector, pathprop);
468 	return connector;
469 }
470 
471 static void intel_dp_register_mst_connector(struct drm_connector *connector)
472 {
473 	struct intel_connector *intel_connector = to_intel_connector(connector);
474 	struct drm_device *dev = connector->dev;
475 	drm_modeset_lock_all(dev);
476 	intel_connector_add_to_fbdev(intel_connector);
477 	drm_modeset_unlock_all(dev);
478 	drm_connector_register(&intel_connector->base);
479 }
480 
481 static void intel_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr,
482 					   struct drm_connector *connector)
483 {
484 	struct intel_connector *intel_connector = to_intel_connector(connector);
485 	struct drm_device *dev = connector->dev;
486 
487 	/* need to nuke the connector */
488 	drm_modeset_lock_all(dev);
489 	if (connector->state->crtc) {
490 		struct drm_mode_set set;
491 		int ret;
492 
493 		memset(&set, 0, sizeof(set));
494 		set.crtc = connector->state->crtc,
495 
496 		ret = drm_atomic_helper_set_config(&set);
497 
498 		WARN(ret, "Disabling mst crtc failed with %i\n", ret);
499 	}
500 	drm_modeset_unlock_all(dev);
501 
502 	intel_connector->unregister(intel_connector);
503 
504 	drm_modeset_lock_all(dev);
505 	intel_connector_remove_from_fbdev(intel_connector);
506 	drm_connector_cleanup(connector);
507 	drm_modeset_unlock_all(dev);
508 
509 	kfree(intel_connector);
510 	DRM_DEBUG_KMS("\n");
511 }
512 
513 static void intel_dp_mst_hotplug(struct drm_dp_mst_topology_mgr *mgr)
514 {
515 	struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);
516 	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
517 	struct drm_device *dev = intel_dig_port->base.base.dev;
518 
519 	drm_kms_helper_hotplug_event(dev);
520 }
521 
522 static struct drm_dp_mst_topology_cbs mst_cbs = {
523 	.add_connector = intel_dp_add_mst_connector,
524 	.register_connector = intel_dp_register_mst_connector,
525 	.destroy_connector = intel_dp_destroy_mst_connector,
526 	.hotplug = intel_dp_mst_hotplug,
527 };
528 
529 static struct intel_dp_mst_encoder *
530 intel_dp_create_fake_mst_encoder(struct intel_digital_port *intel_dig_port, enum pipe pipe)
531 {
532 	struct intel_dp_mst_encoder *intel_mst;
533 	struct intel_encoder *intel_encoder;
534 	struct drm_device *dev = intel_dig_port->base.base.dev;
535 
536 	intel_mst = kzalloc(sizeof(*intel_mst), GFP_KERNEL);
537 
538 	if (!intel_mst)
539 		return NULL;
540 
541 	intel_mst->pipe = pipe;
542 	intel_encoder = &intel_mst->base;
543 	intel_mst->primary = intel_dig_port;
544 
545 	drm_encoder_init(dev, &intel_encoder->base, &intel_dp_mst_enc_funcs,
546 			 DRM_MODE_ENCODER_DPMST);
547 
548 	intel_encoder->type = INTEL_OUTPUT_DP_MST;
549 	intel_encoder->crtc_mask = 0x7;
550 	intel_encoder->cloneable = 0;
551 
552 	intel_encoder->compute_config = intel_dp_mst_compute_config;
553 	intel_encoder->disable = intel_mst_disable_dp;
554 	intel_encoder->post_disable = intel_mst_post_disable_dp;
555 	intel_encoder->pre_enable = intel_mst_pre_enable_dp;
556 	intel_encoder->enable = intel_mst_enable_dp;
557 	intel_encoder->get_hw_state = intel_dp_mst_enc_get_hw_state;
558 	intel_encoder->get_config = intel_dp_mst_enc_get_config;
559 
560 	return intel_mst;
561 
562 }
563 
564 static bool
565 intel_dp_create_fake_mst_encoders(struct intel_digital_port *intel_dig_port)
566 {
567 	int i;
568 	struct intel_dp *intel_dp = &intel_dig_port->dp;
569 
570 	for (i = PIPE_A; i <= PIPE_C; i++)
571 		intel_dp->mst_encoders[i] = intel_dp_create_fake_mst_encoder(intel_dig_port, i);
572 	return true;
573 }
574 #endif
575 
576 int
577 intel_dp_mst_encoder_init(struct intel_digital_port *intel_dig_port, int conn_base_id)
578 {
579 	struct intel_dp *intel_dp = &intel_dig_port->dp;
580 #if 0
581 	struct drm_device *dev = intel_dig_port->base.base.dev;
582 	int ret;
583 
584 	intel_dp->can_mst = true;
585 	intel_dp->mst_mgr.cbs = &mst_cbs;
586 
587 	/* create encoders */
588 	intel_dp_create_fake_mst_encoders(intel_dig_port);
589 	ret = drm_dp_mst_topology_mgr_init(&intel_dp->mst_mgr, dev->dev, &intel_dp->aux, 16, 3, conn_base_id);
590 	if (ret) {
591 		intel_dp->can_mst = false;
592 		return ret;
593 	}
594 #endif
595 	intel_dp->can_mst = false;
596 	return 0;
597 }
598 
599 void
600 intel_dp_mst_encoder_cleanup(struct intel_digital_port *intel_dig_port)
601 {
602 	struct intel_dp *intel_dp = &intel_dig_port->dp;
603 
604 	if (!intel_dp->can_mst)
605 		return;
606 
607 #if 0
608 	drm_dp_mst_topology_mgr_destroy(&intel_dp->mst_mgr);
609 #endif
610 	/* encoders will get killed by normal cleanup */
611 }
612