xref: /dragonfly/sys/dev/netif/iwm/if_iwm_mac_ctxt.c (revision 44753b81)
1 /*	$OpenBSD: if_iwm.c,v 1.39 2015/03/23 00:35:19 jsg Exp $	*/
2 
3 /*
4  * Copyright (c) 2014 genua mbh <info@genua.de>
5  * Copyright (c) 2014 Fixup Software Ltd.
6  *
7  * Permission to use, copy, modify, and distribute this software for any
8  * purpose with or without fee is hereby granted, provided that the above
9  * copyright notice and this permission notice appear in all copies.
10  *
11  * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
12  * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
13  * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
14  * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
15  * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
16  * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
17  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
18  */
19 
20 /*-
21  * Based on BSD-licensed source modules in the Linux iwlwifi driver,
22  * which were used as the reference documentation for this implementation.
23  *
24  * Driver version we are currently based off of is
25  * Linux 3.14.3 (tag id a2df521e42b1d9a23f620ac79dbfe8655a8391dd)
26  *
27  ***********************************************************************
28  *
29  * This file is provided under a dual BSD/GPLv2 license.  When using or
30  * redistributing this file, you may do so under either license.
31  *
32  * GPL LICENSE SUMMARY
33  *
34  * Copyright(c) 2007 - 2013 Intel Corporation. All rights reserved.
35  *
36  * This program is free software; you can redistribute it and/or modify
37  * it under the terms of version 2 of the GNU General Public License as
38  * published by the Free Software Foundation.
39  *
40  * This program is distributed in the hope that it will be useful, but
41  * WITHOUT ANY WARRANTY; without even the implied warranty of
42  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
43  * General Public License for more details.
44  *
45  * You should have received a copy of the GNU General Public License
46  * along with this program; if not, write to the Free Software
47  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110,
48  * USA
49  *
50  * The full GNU General Public License is included in this distribution
51  * in the file called COPYING.
52  *
53  * Contact Information:
54  *  Intel Linux Wireless <ilw@linux.intel.com>
55  * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
56  *
57  *
58  * BSD LICENSE
59  *
60  * Copyright(c) 2005 - 2013 Intel Corporation. All rights reserved.
61  * All rights reserved.
62  *
63  * Redistribution and use in source and binary forms, with or without
64  * modification, are permitted provided that the following conditions
65  * are met:
66  *
67  *  * Redistributions of source code must retain the above copyright
68  *    notice, this list of conditions and the following disclaimer.
69  *  * Redistributions in binary form must reproduce the above copyright
70  *    notice, this list of conditions and the following disclaimer in
71  *    the documentation and/or other materials provided with the
72  *    distribution.
73  *  * Neither the name Intel Corporation nor the names of its
74  *    contributors may be used to endorse or promote products derived
75  *    from this software without specific prior written permission.
76  *
77  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
78  * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
79  * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
80  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
81  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
82  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
83  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
84  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
85  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
86  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
87  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
88  */
89 
90 /*-
91  * Copyright (c) 2007-2010 Damien Bergamini <damien.bergamini@free.fr>
92  *
93  * Permission to use, copy, modify, and distribute this software for any
94  * purpose with or without fee is hereby granted, provided that the above
95  * copyright notice and this permission notice appear in all copies.
96  *
97  * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
98  * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
99  * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
100  * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
101  * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
102  * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
103  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
104  */
105 #include <sys/cdefs.h>
106 __FBSDID("$FreeBSD$");
107 
108 #include <sys/param.h>
109 #include <sys/bus.h>
110 #include <sys/endian.h>
111 #include <sys/firmware.h>
112 #include <sys/kernel.h>
113 #include <sys/malloc.h>
114 #include <sys/mbuf.h>
115 #include <sys/rman.h>
116 #include <sys/sysctl.h>
117 #include <sys/linker.h>
118 
119 #include <machine/endian.h>
120 
121 #include <bus/pci/pcivar.h>
122 #include <bus/pci/pcireg.h>
123 
124 #include <net/bpf.h>
125 
126 #include <net/if.h>
127 #include <net/if_var.h>
128 #include <net/if_arp.h>
129 #include <net/if_dl.h>
130 #include <net/if_media.h>
131 #include <net/if_types.h>
132 
133 #include <netinet/in.h>
134 #include <netinet/in_systm.h>
135 #include <netinet/if_ether.h>
136 #include <netinet/ip.h>
137 
138 #include <netproto/802_11/ieee80211_var.h>
139 #include <netproto/802_11/ieee80211_regdomain.h>
140 #include <netproto/802_11/ieee80211_ratectl.h>
141 #include <netproto/802_11/ieee80211_radiotap.h>
142 
143 #include "if_iwmreg.h"
144 #include "if_iwmvar.h"
145 #include "if_iwm_debug.h"
146 #include "if_iwm_util.h"
147 #include "if_iwm_mac_ctxt.h"
148 
149 static void
150 iwm_mvm_ack_rates(struct iwm_softc *sc, int is2ghz,
151 	int *cck_rates, int *ofdm_rates, struct iwm_node *in)
152 {
153 	int lowest_present_ofdm = 100;
154 	int lowest_present_cck = 100;
155 	uint8_t cck = 0;
156 	uint8_t ofdm = 0;
157 	int i;
158 	struct ieee80211_rateset *rs = &in->in_ni.ni_rates;
159 
160 	if (is2ghz) {
161 		for (i = IWM_FIRST_CCK_RATE; i <= IWM_LAST_CCK_RATE; i++) {
162 			if ((iwm_ridx2rate(rs, i) & IEEE80211_RATE_BASIC) == 0)
163 				continue;
164 			cck |= (1 << i);
165 			if (lowest_present_cck > i)
166 				lowest_present_cck = i;
167 		}
168 	}
169 	for (i = IWM_FIRST_OFDM_RATE; i <= IWM_LAST_NON_HT_RATE; i++) {
170 		if ((iwm_ridx2rate(rs, i) & IEEE80211_RATE_BASIC) == 0)
171 			continue;
172 		ofdm |= (1 << (i - IWM_FIRST_OFDM_RATE));
173 		if (lowest_present_ofdm > i)
174 			lowest_present_ofdm = i;
175 	}
176 
177 	/*
178 	 * Now we've got the basic rates as bitmaps in the ofdm and cck
179 	 * variables. This isn't sufficient though, as there might not
180 	 * be all the right rates in the bitmap. E.g. if the only basic
181 	 * rates are 5.5 Mbps and 11 Mbps, we still need to add 1 Mbps
182 	 * and 6 Mbps because the 802.11-2007 standard says in 9.6:
183 	 *
184 	 *    [...] a STA responding to a received frame shall transmit
185 	 *    its Control Response frame [...] at the highest rate in the
186 	 *    BSSBasicRateSet parameter that is less than or equal to the
187 	 *    rate of the immediately previous frame in the frame exchange
188 	 *    sequence ([...]) and that is of the same modulation class
189 	 *    ([...]) as the received frame. If no rate contained in the
190 	 *    BSSBasicRateSet parameter meets these conditions, then the
191 	 *    control frame sent in response to a received frame shall be
192 	 *    transmitted at the highest mandatory rate of the PHY that is
193 	 *    less than or equal to the rate of the received frame, and
194 	 *    that is of the same modulation class as the received frame.
195 	 *
196 	 * As a consequence, we need to add all mandatory rates that are
197 	 * lower than all of the basic rates to these bitmaps.
198 	 */
199 
200 	if (IWM_RATE_24M_INDEX < lowest_present_ofdm)
201 		ofdm |= IWM_RATE_BIT_MSK(24) >> IWM_FIRST_OFDM_RATE;
202 	if (IWM_RATE_12M_INDEX < lowest_present_ofdm)
203 		ofdm |= IWM_RATE_BIT_MSK(12) >> IWM_FIRST_OFDM_RATE;
204 	/* 6M already there or needed so always add */
205 	ofdm |= IWM_RATE_BIT_MSK(6) >> IWM_FIRST_OFDM_RATE;
206 
207 	/*
208 	 * CCK is a bit more complex with DSSS vs. HR/DSSS vs. ERP.
209 	 * Note, however:
210 	 *  - if no CCK rates are basic, it must be ERP since there must
211 	 *    be some basic rates at all, so they're OFDM => ERP PHY
212 	 *    (or we're in 5 GHz, and the cck bitmap will never be used)
213 	 *  - if 11M is a basic rate, it must be ERP as well, so add 5.5M
214 	 *  - if 5.5M is basic, 1M and 2M are mandatory
215 	 *  - if 2M is basic, 1M is mandatory
216 	 *  - if 1M is basic, that's the only valid ACK rate.
217 	 * As a consequence, it's not as complicated as it sounds, just add
218 	 * any lower rates to the ACK rate bitmap.
219 	 */
220 	if (IWM_RATE_11M_INDEX < lowest_present_cck)
221 		cck |= IWM_RATE_BIT_MSK(11) >> IWM_FIRST_CCK_RATE;
222 	if (IWM_RATE_5M_INDEX < lowest_present_cck)
223 		cck |= IWM_RATE_BIT_MSK(5) >> IWM_FIRST_CCK_RATE;
224 	if (IWM_RATE_2M_INDEX < lowest_present_cck)
225 		cck |= IWM_RATE_BIT_MSK(2) >> IWM_FIRST_CCK_RATE;
226 	/* 1M already there or needed so always add */
227 	cck |= IWM_RATE_BIT_MSK(1) >> IWM_FIRST_CCK_RATE;
228 
229 	*cck_rates = cck;
230 	*ofdm_rates = ofdm;
231 }
232 
233 static void
234 iwm_mvm_mac_ctxt_cmd_common(struct iwm_softc *sc, struct iwm_node *in,
235 	struct iwm_mac_ctx_cmd *cmd, uint32_t action)
236 {
237 	struct ieee80211com *ic = &sc->sc_ic;
238 	struct ieee80211vap *vap = TAILQ_FIRST(&ic->ic_vaps);
239 	struct ieee80211_node *ni = vap->iv_bss;
240 	struct iwm_vap *ivp = IWM_VAP(vap);
241 	int cck_ack_rates, ofdm_ack_rates;
242 	int i;
243 	int is2ghz;
244 
245 	/*
246 	 * id is the MAC address ID - something to do with MAC filtering.
247 	 * color - not sure.
248 	 *
249 	 * These are both functions of the vap, not of the node.
250 	 * So, for now, hard-code both to 0 (default).
251 	 */
252 	cmd->id_and_color = htole32(IWM_FW_CMD_ID_AND_COLOR(ivp->id,
253 	    ivp->color));
254 	cmd->action = htole32(action);
255 
256 	cmd->mac_type = htole32(IWM_FW_MAC_TYPE_BSS_STA);
257 
258 	/*
259 	 * The TSF ID is one of four TSF tracking resources in the firmware.
260 	 * Read the iwlwifi/mvm code for more details.
261 	 *
262 	 * For now, just hard-code it to TSF tracking ID 0; we only support
263 	 * a single STA mode VAP.
264 	 *
265 	 * It's per-vap, not per-node.
266 	 */
267 	cmd->tsf_id = htole32(IWM_DEFAULT_TSFID);
268 
269 	IEEE80211_ADDR_COPY(cmd->node_addr, vap->iv_myaddr);
270 
271 	/*
272 	 * XXX should we error out if in_assoc is 1 and ni == NULL?
273 	 */
274 #if 0
275 	if (in->in_assoc) {
276 		IEEE80211_ADDR_COPY(cmd->bssid_addr, ni->ni_bssid);
277 	} else {
278 		/* eth broadcast address */
279 		IEEE80211_ADDR_COPY(cmd->bssid_addr, ieee80211broadcastaddr);
280 	}
281 #else
282 	/*
283 	 * XXX This workaround makes the firmware behave more correctly once
284 	 *     we are associated, regularly giving us statistics notifications,
285 	 *     as well as signaling missed beacons to us.
286 	 *     Since we only call iwm_mvm_mac_ctxt_add() and
287 	 *     iwm_mvm_mac_ctxt_changed() when already authenticating or
288 	 *     associating, ni->ni_bssid should always make sense here.
289 	 */
290 	IEEE80211_ADDR_COPY(cmd->bssid_addr, ni->ni_bssid);
291 #endif
292 
293 	/*
294 	 * Default to 2ghz if no node information is given.
295 	 */
296 	if (in && in->in_ni.ni_chan != IEEE80211_CHAN_ANYC) {
297 		is2ghz = !! IEEE80211_IS_CHAN_2GHZ(in->in_ni.ni_chan);
298 	} else {
299 		is2ghz = 1;
300 	}
301 	iwm_mvm_ack_rates(sc, is2ghz, &cck_ack_rates, &ofdm_ack_rates, in);
302 	cmd->cck_rates = htole32(cck_ack_rates);
303 	cmd->ofdm_rates = htole32(ofdm_ack_rates);
304 
305 	cmd->cck_short_preamble
306 	    = htole32((ic->ic_flags & IEEE80211_F_SHPREAMBLE)
307 	      ? IWM_MAC_FLG_SHORT_PREAMBLE : 0);
308 	cmd->short_slot
309 	    = htole32((ic->ic_flags & IEEE80211_F_SHSLOT)
310 	      ? IWM_MAC_FLG_SHORT_SLOT : 0);
311 
312 	/* XXX TODO: set wme parameters; also handle getting updated wme parameters */
313 	for (i = 0; i < IWM_AC_NUM+1; i++) {
314 		int txf = i;
315 
316 		cmd->ac[txf].cw_min = htole16(0x0f);
317 		cmd->ac[txf].cw_max = htole16(0x3f);
318 		cmd->ac[txf].aifsn = 1;
319 		cmd->ac[txf].fifos_mask = (1 << txf);
320 		cmd->ac[txf].edca_txop = 0;
321 	}
322 
323 	if (ic->ic_flags & IEEE80211_F_USEPROT)
324 		cmd->protection_flags |= htole32(IWM_MAC_PROT_FLG_TGG_PROTECT);
325 
326 	cmd->filter_flags = htole32(IWM_MAC_FILTER_ACCEPT_GRP);
327 }
328 
329 static int
330 iwm_mvm_mac_ctxt_send_cmd(struct iwm_softc *sc, struct iwm_mac_ctx_cmd *cmd)
331 {
332 	int ret = iwm_mvm_send_cmd_pdu(sc, IWM_MAC_CONTEXT_CMD, IWM_CMD_SYNC,
333 				       sizeof(*cmd), cmd);
334 	if (ret)
335 		device_printf(sc->sc_dev,
336 		    "%s: Failed to send MAC context (action:%d): %d\n",
337 		    __func__, le32toh(cmd->action), ret);
338 	return ret;
339 }
340 
341 /*
342  * Fill the specific data for mac context of type station or p2p client
343  */
344 static void
345 iwm_mvm_mac_ctxt_cmd_fill_sta(struct iwm_softc *sc, struct iwm_node *in,
346 	struct iwm_mac_data_sta *ctxt_sta, int force_assoc_off)
347 {
348 	struct ieee80211_node *ni = &in->in_ni;
349 	unsigned dtim_period, dtim_count;
350 	struct ieee80211com *ic = &sc->sc_ic;
351 	struct ieee80211vap *vap = TAILQ_FIRST(&ic->ic_vaps);
352 
353 	/* will this work? */
354 	dtim_period = vap->iv_dtim_period;
355 	dtim_count = vap->iv_dtim_count;
356 	IWM_DPRINTF(sc, IWM_DEBUG_RESET | IWM_DEBUG_BEACON | IWM_DEBUG_CMD,
357 	    "%s: force_assoc_off=%d\n", __func__, force_assoc_off);
358 	IWM_DPRINTF(sc, IWM_DEBUG_RESET | IWM_DEBUG_BEACON | IWM_DEBUG_CMD,
359 	    "DTIM: period=%d count=%d\n", dtim_period, dtim_count);
360 	IWM_DPRINTF(sc, IWM_DEBUG_RESET | IWM_DEBUG_BEACON | IWM_DEBUG_CMD,
361 	    "BEACON: tsf: %llu, ni_intval=%d\n",
362 	    (unsigned long long) le64toh(ni->ni_tstamp.tsf),
363 	    ni->ni_intval);
364 
365 	/* We need the dtim_period to set the MAC as associated */
366 	if (in->in_assoc && dtim_period && !force_assoc_off) {
367 		uint64_t tsf;
368 		uint32_t dtim_offs;
369 
370 		/*
371 		 * The DTIM count counts down, so when it is N that means N
372 		 * more beacon intervals happen until the DTIM TBTT. Therefore
373 		 * add this to the current time. If that ends up being in the
374 		 * future, the firmware will handle it.
375 		 *
376 		 * Also note that the system_timestamp (which we get here as
377 		 * "sync_device_ts") and TSF timestamp aren't at exactly the
378 		 * same offset in the frame -- the TSF is at the first symbol
379 		 * of the TSF, the system timestamp is at signal acquisition
380 		 * time. This means there's an offset between them of at most
381 		 * a few hundred microseconds (24 * 8 bits + PLCP time gives
382 		 * 384us in the longest case), this is currently not relevant
383 		 * as the firmware wakes up around 2ms before the TBTT.
384 		 */
385 		dtim_offs = dtim_count * ni->ni_intval;
386 		/* convert TU to usecs */
387 		dtim_offs *= 1024;
388 
389 		/*
390 		 * net80211: TSF is in 802.11 order, so convert up to local
391 		 * ordering before we manipulate things.
392 		 */
393 		tsf = le64toh(ni->ni_tstamp.tsf);
394 
395 		ctxt_sta->dtim_tsf = htole64(tsf + dtim_offs);
396 		ctxt_sta->dtim_time = htole32(tsf + dtim_offs);
397 
398 		IWM_DPRINTF(sc, IWM_DEBUG_RESET | IWM_DEBUG_BEACON | IWM_DEBUG_CMD,
399 		    "DTIM TBTT is 0x%llx/0x%x, offset %d\n",
400 		    (long long)le64toh(ctxt_sta->dtim_tsf),
401 		    le32toh(ctxt_sta->dtim_time), dtim_offs);
402 
403 		ctxt_sta->is_assoc = htole32(1);
404 	} else {
405 		ctxt_sta->is_assoc = htole32(0);
406 	}
407 
408 	IWM_DPRINTF(sc, IWM_DEBUG_RESET | IWM_DEBUG_CMD | IWM_DEBUG_BEACON,
409 	    "%s: ni_intval: %d, bi_reciprocal: %d, dtim_interval: %d, dtim_reciprocal: %d\n",
410 	    __func__,
411 	    ni->ni_intval,
412 	    iwm_mvm_reciprocal(ni->ni_intval),
413 	    ni->ni_intval * dtim_period,
414 	    iwm_mvm_reciprocal(ni->ni_intval * dtim_period));
415 
416 	ctxt_sta->bi = htole32(ni->ni_intval);
417 	ctxt_sta->bi_reciprocal = htole32(iwm_mvm_reciprocal(ni->ni_intval));
418 	ctxt_sta->dtim_interval = htole32(ni->ni_intval * dtim_period);
419 	ctxt_sta->dtim_reciprocal =
420 	    htole32(iwm_mvm_reciprocal(ni->ni_intval * dtim_period));
421 
422 	/* 10 = CONN_MAX_LISTEN_INTERVAL */
423 	ctxt_sta->listen_interval = htole32(10);
424 	IWM_DPRINTF(sc, IWM_DEBUG_RESET | IWM_DEBUG_CMD | IWM_DEBUG_BEACON,
425 	    "%s: associd=%d\n", __func__, IEEE80211_AID(ni->ni_associd));
426 	ctxt_sta->assoc_id = htole32(IEEE80211_AID(ni->ni_associd));
427 }
428 
429 static int
430 iwm_mvm_mac_ctxt_cmd_station(struct iwm_softc *sc, struct ieee80211vap *vap,
431 	uint32_t action)
432 {
433 	struct ieee80211_node *ni = vap->iv_bss;
434 	struct iwm_node *in = IWM_NODE(ni);
435 	struct iwm_mac_ctx_cmd cmd = {};
436 
437 	IWM_DPRINTF(sc, IWM_DEBUG_RESET,
438 	    "%s: called; action=%d\n", __func__, action);
439 
440 	/* Fill the common data for all mac context types */
441 	iwm_mvm_mac_ctxt_cmd_common(sc, in, &cmd, action);
442 
443 	/* Allow beacons to pass through as long as we are not associated,or we
444 	 * do not have dtim period information */
445 	if (!in->in_assoc || !vap->iv_dtim_period)
446 		cmd.filter_flags |= htole32(IWM_MAC_FILTER_IN_BEACON);
447 	else
448 		cmd.filter_flags &= ~htole32(IWM_MAC_FILTER_IN_BEACON);
449 
450 	/* Fill the data specific for station mode */
451 	iwm_mvm_mac_ctxt_cmd_fill_sta(sc, in,
452 	    &cmd.sta, action == IWM_FW_CTXT_ACTION_ADD);
453 
454 	return iwm_mvm_mac_ctxt_send_cmd(sc, &cmd);
455 }
456 
457 static int
458 iwm_mvm_mac_ctx_send(struct iwm_softc *sc, struct ieee80211vap *vap,
459     uint32_t action)
460 {
461 	return iwm_mvm_mac_ctxt_cmd_station(sc, vap, action);
462 }
463 
464 int
465 iwm_mvm_mac_ctxt_add(struct iwm_softc *sc, struct ieee80211vap *vap)
466 {
467 	struct iwm_vap *iv = IWM_VAP(vap);
468 	int ret;
469 
470 	if (iv->is_uploaded != 0) {
471 		device_printf(sc->sc_dev, "%s: called; uploaded != 0\n",
472 		    __func__);
473 		return (EIO);
474 	}
475 
476 	ret = iwm_mvm_mac_ctx_send(sc, vap, IWM_FW_CTXT_ACTION_ADD);
477 	if (ret)
478 		return (ret);
479 	iv->is_uploaded = 1;
480 	return (0);
481 }
482 
483 int
484 iwm_mvm_mac_ctxt_changed(struct iwm_softc *sc, struct ieee80211vap *vap)
485 {
486 	struct iwm_vap *iv = IWM_VAP(vap);
487 
488 	if (iv->is_uploaded == 0) {
489 		device_printf(sc->sc_dev, "%s: called; uploaded = 0\n",
490 		    __func__);
491 		return (EIO);
492 	}
493 	return iwm_mvm_mac_ctx_send(sc, vap, IWM_FW_CTXT_ACTION_MODIFY);
494 }
495 
496 #if 0
497 static int
498 iwm_mvm_mac_ctxt_remove(struct iwm_softc *sc, struct iwm_node *in)
499 {
500 	struct iwm_mac_ctx_cmd cmd;
501 	int ret;
502 
503 	if (!in->in_uploaded) {
504 		device_printf(sc->sc_dev,
505 		    "attempt to remove !uploaded node %p", in);
506 		return EIO;
507 	}
508 
509 	memset(&cmd, 0, sizeof(cmd));
510 
511 	cmd.id_and_color = htole32(IWM_FW_CMD_ID_AND_COLOR(IWM_DEFAULT_MACID,
512 	    IWM_DEFAULT_COLOR));
513 	cmd.action = htole32(IWM_FW_CTXT_ACTION_REMOVE);
514 
515 	ret = iwm_mvm_send_cmd_pdu(sc,
516 	    IWM_MAC_CONTEXT_CMD, IWM_CMD_SYNC, sizeof(cmd), &cmd);
517 	if (ret) {
518 		device_printf(sc->sc_dev,
519 		    "Failed to remove MAC context: %d\n", ret);
520 		return ret;
521 	}
522 	in->in_uploaded = 0;
523 
524 	return 0;
525 }
526 #endif
527