1// RUN: %clang_cc1 -triple x86_64-apple-darwin -Wformat-nonliteral -fsyntax-only -fblocks -verify -Wno-objc-root-class %s
2
3//===----------------------------------------------------------------------===//
4// The following code is reduced using delta-debugging from
5// Foundation.h (Mac OS X).
6//
7// It includes the basic definitions for the test cases below.
8// Not including Foundation.h directly makes this test case both svelt and
9// portable to non-Mac platforms.
10//===----------------------------------------------------------------------===//
11
12#include <stdarg.h>
13
14typedef signed char BOOL;
15typedef unsigned int NSUInteger;
16typedef long NSInteger;
17@class NSString, Protocol;
18extern void NSLog(NSString *format, ...);
19extern void NSLogv(NSString *format, va_list args);
20typedef struct _NSZone NSZone;
21@class NSInvocation, NSMethodSignature, NSCoder, NSString, NSEnumerator;
22@protocol NSObject  - (BOOL)isEqual:(id)object; @end
23@protocol NSCopying  - (id)copyWithZone:(NSZone *)zone; @end
24@protocol NSMutableCopying  - (id)mutableCopyWithZone:(NSZone *)zone; @end
25@protocol NSCoding  - (void)encodeWithCoder:(NSCoder *)aCoder; @end
26@interface NSObject <NSObject> {} @end
27typedef float CGFloat;
28@interface NSString : NSObject <NSCopying, NSMutableCopying, NSCoding>    - (NSUInteger)length; @end
29@interface NSSimpleCString : NSString {} @end
30@interface NSConstantString : NSSimpleCString @end
31extern void *_NSConstantStringClassReference;
32
33typedef const struct __CFString * CFStringRef;
34extern void CFStringCreateWithFormat(CFStringRef format, ...) __attribute__((format(CFString, 1, 2)));
35#define CFSTR(cStr)  ((CFStringRef) __builtin___CFStringMakeConstantString ("" cStr ""))
36
37// This function is used instead of the builtin if -fno-constant-cfstrings.
38// The definition on Mac OS X is NOT annotated with format_arg as of 10.8,
39// but clang will implicitly add the attribute if it's not written.
40extern CFStringRef __CFStringMakeConstantString(const char *);
41
42int printf(const char * restrict, ...) ;
43
44//===----------------------------------------------------------------------===//
45// Test cases.
46//===----------------------------------------------------------------------===//
47
48void check_nslog(unsigned k) {
49  NSLog(@"%d%%", k); // no-warning
50  NSLog(@"%s%lb%d", "unix", 10,20); // expected-warning {{invalid conversion specifier 'b'}}
51}
52
53// Check type validation
54extern void NSLog2(int format, ...) __attribute__((format(__NSString__, 1, 2))); // expected-error {{format argument not an NSString}}
55extern void CFStringCreateWithFormat2(int *format, ...) __attribute__((format(CFString, 1, 2))); // expected-error {{format argument not a CFString}}
56
57// <rdar://problem/7068334> - Catch use of long long with int arguments.
58void rdar_7068334() {
59  long long test = 500;
60  printf("%i ",test); // expected-warning{{format specifies type 'int' but the argument has type 'long long'}}
61  NSLog(@"%i ",test); // expected-warning{{format specifies type 'int' but the argument has type 'long long'}}
62  CFStringCreateWithFormat(CFSTR("%i"),test); // expected-warning{{format specifies type 'int' but the argument has type 'long long'}}
63}
64
65// <rdar://problem/7697748>
66void rdar_7697748() {
67  NSLog(@"%@!"); // expected-warning{{more '%' conversions than data arguments}}
68}
69
70@protocol Foo;
71
72void test_p_conversion_with_objc_pointer(id x, id<Foo> y) {
73  printf("%p", x); // no-warning
74  printf("%p", y); // no-warning
75}
76
77// <rdar://problem/10696348>, PR 10274 - CFString and NSString formats are ignored
78extern void MyNSLog(NSString *format, ...) __attribute__((format(__NSString__, 1, 2)));
79extern void MyCFStringCreateWithFormat(CFStringRef format, ...) __attribute__((format(__CFString__, 1, 2)));
80
81void check_mylog() {
82  MyNSLog(@"%@"); // expected-warning {{more '%' conversions than data arguments}}
83  MyCFStringCreateWithFormat(CFSTR("%@")); // expected-warning {{more '%' conversions than data arguments}}
84}
85
86// PR 10275 - format function attribute isn't checked in Objective-C methods
87@interface Foo
88+ (id)fooWithFormat:(NSString *)fmt, ... __attribute__((format(__NSString__, 1, 2)));
89+ (id)fooWithCStringFormat:(const char *)format, ... __attribute__((format(__printf__, 1, 2)));
90@end
91
92void check_method() {
93  [Foo fooWithFormat:@"%@"]; // expected-warning {{more '%' conversions than data arguments}}
94  [Foo fooWithCStringFormat:"%@"]; // expected-warning {{invalid conversion specifier '@'}}
95}
96
97// Warn about using BOOL with %@
98void rdar10743758(id x) {
99  NSLog(@"%@ %@", x, (BOOL) 1); // expected-warning {{format specifies type 'id' but the argument has type 'BOOL' (aka 'signed char')}}
100}
101
102NSString *test_literal_propagation(void) {
103  const char * const s1 = "constant string %s"; // expected-note {{format string is defined here}}
104  printf(s1); // expected-warning {{more '%' conversions than data arguments}}
105  const char * const s5 = "constant string %s"; // expected-note {{format string is defined here}}
106  const char * const s2 = s5;
107  printf(s2); // expected-warning {{more '%' conversions than data arguments}}
108
109  const char * const s3 = (const char *)0;
110  printf(s3); // no-warning (NULL is a valid format string)
111
112  NSString * const ns1 = @"constant string %s"; // expected-note {{format string is defined here}}
113  NSLog(ns1); // expected-warning {{more '%' conversions than data arguments}}
114  NSString * const ns5 = @"constant string %s"; // expected-note {{format string is defined here}}
115  NSString * const ns2 = ns5;
116  NSLog(ns2); // expected-warning {{more '%' conversions than data arguments}}
117  NSString * ns3 = ns1;
118  NSLog(ns3); // expected-warning {{format string is not a string literal}}}
119}
120
121// Do not emit warnings when using NSLocalizedString
122#include "format-strings-system.h"
123
124// Test it inhibits diag only for macros in system headers
125#define MyNSLocalizedString(key) GetLocalizedString(key)
126#define MyNSAssert(fmt, arg) NSLog(fmt, arg, 0, 0)
127
128void check_NSLocalizedString() {
129  [Foo fooWithFormat:NSLocalizedString(@"format"), @"arg"]; // no-warning
130  [Foo fooWithFormat:MyNSLocalizedString(@"format"), @"arg"]; // expected-warning {{format string is not a string literal}}}
131}
132
133void check_NSAssert() {
134  NSAssert(@"Hello %@", @"World"); // no-warning
135  MyNSAssert(@"Hello %@", @"World"); // expected-warning  {{data argument not used by format string}}
136}
137
138typedef __WCHAR_TYPE__ wchar_t;
139
140// Test that %S, %C, %ls check for 16 bit types in ObjC strings, as described at
141// http://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/Strings/Articles/formatSpecifiers.html#//apple_ref/doc/uid/TP40004265
142
143void test_percent_S() {
144  const unsigned short data[] = { 'a', 'b', 0 };
145  const unsigned short* ptr = data;
146  NSLog(@"%S", ptr);  // no-warning
147
148  const wchar_t* wchar_ptr = L"ab";
149  NSLog(@"%S", wchar_ptr);  // expected-warning{{format specifies type 'const unichar *' (aka 'const unsigned short *') but the argument has type 'const wchar_t *'}}
150}
151
152void test_percent_ls() {
153  const unsigned short data[] = { 'a', 'b', 0 };
154  const unsigned short* ptr = data;
155  NSLog(@"%ls", ptr);  // no-warning
156
157  const wchar_t* wchar_ptr = L"ab";
158  NSLog(@"%ls", wchar_ptr);  // expected-warning{{format specifies type 'const unichar *' (aka 'const unsigned short *') but the argument has type 'const wchar_t *'}}
159}
160
161void test_percent_C() {
162  const unsigned short data = 'a';
163  NSLog(@"%C", data);  // no-warning
164
165  const wchar_t wchar_data = L'a';
166  NSLog(@"%C", wchar_data);  // expected-warning{{format specifies type 'unichar' (aka 'unsigned short') but the argument has type 'wchar_t'}}
167}
168
169// Test that %@ works with toll-free bridging (<rdar://problem/10814120>).
170void test_toll_free_bridging(CFStringRef x, id y) {
171  NSLog(@"%@", x); // no-warning
172  CFStringCreateWithFormat(CFSTR("%@"), x); // no-warning
173
174  NSLog(@"%@", y); // no-warning
175  CFStringCreateWithFormat(CFSTR("%@"), y); // no-warning
176}
177
178@interface Bar
179+ (void)log:(NSString *)fmt, ...;
180+ (void)log2:(NSString *)fmt, ... __attribute__((format(NSString, 1, 2)));
181@end
182
183@implementation Bar
184
185+ (void)log:(NSString *)fmt, ... {
186  va_list ap;
187  va_start(ap,fmt);
188  NSLogv(fmt, ap); // expected-warning{{format string is not a string literal}}
189  va_end(ap);
190}
191
192+ (void)log2:(NSString *)fmt, ... {
193  va_list ap;
194  va_start(ap,fmt);
195  NSLogv(fmt, ap); // no-warning
196  va_end(ap);
197}
198
199@end
200
201
202// Test that it is okay to use %p with the address of a block.
203void rdar11049844_aux();
204int rdar11049844() {
205  typedef void (^MyBlock)(void);
206  MyBlock x = ^void() { rdar11049844_aux(); };
207  printf("%p", x);  // no-warning
208}
209
210void test_nonBuiltinCFStrings() {
211  CFStringCreateWithFormat(__CFStringMakeConstantString("%@"), 1); // expected-warning{{format specifies type 'id' but the argument has type 'int'}}
212}
213
214
215// Don't crash on an invalid argument expression.
216// <rdar://problem/11890818>
217@interface NSDictionary : NSObject
218- (id)objectForKeyedSubscript:(id)key;
219@end
220
221void testInvalidFormatArgument(NSDictionary *dict) {
222  NSLog(@"no specifiers", dict[CFSTR("abc")]); // expected-error{{indexing expression is invalid because subscript type 'CFStringRef' (aka 'const struct __CFString *') is not an integral or Objective-C pointer type}}
223  NSLog(@"%@", dict[CFSTR("abc")]); // expected-error{{indexing expression is invalid because subscript type 'CFStringRef' (aka 'const struct __CFString *') is not an integral or Objective-C pointer type}}
224  NSLog(@"%@ %@", dict[CFSTR("abc")]); // expected-error{{indexing expression is invalid because subscript type 'CFStringRef' (aka 'const struct __CFString *') is not an integral or Objective-C pointer type}}
225
226  [Foo fooWithFormat:@"no specifiers", dict[CFSTR("abc")]]; // expected-error{{indexing expression is invalid because subscript type 'CFStringRef' (aka 'const struct __CFString *') is not an integral or Objective-C pointer type}}
227  [Foo fooWithFormat:@"%@", dict[CFSTR("abc")]]; // expected-error{{indexing expression is invalid because subscript type 'CFStringRef' (aka 'const struct __CFString *') is not an integral or Objective-C pointer type}}
228  [Foo fooWithFormat:@"%@ %@", dict[CFSTR("abc")]]; // expected-error{{indexing expression is invalid because subscript type 'CFStringRef' (aka 'const struct __CFString *') is not an integral or Objective-C pointer type}} expected-warning{{more '%' conversions than data arguments}}
229}
230
231
232// <rdar://problem/11825593>
233void testByValueObjectInFormat(Foo *obj) {
234  printf("%d %d %d", 1L, *obj, 1L); // expected-error {{cannot pass object with interface type 'Foo' by value to variadic function; expected type from format string was 'int'}} expected-warning 2 {{format specifies type 'int' but the argument has type 'long'}}
235  printf("%!", *obj); // expected-error {{cannot pass object with interface type 'Foo' by value through variadic function}} expected-warning {{invalid conversion specifier}}
236  printf(0, *obj); // expected-error {{cannot pass object with interface type 'Foo' by value through variadic function}}
237
238  [Bar log2:@"%d", *obj]; // expected-error {{cannot pass object with interface type 'Foo' by value to variadic method; expected type from format string was 'int'}}
239}
240
241// <rdar://problem/13557053>
242void testTypeOf(NSInteger dW, NSInteger dH) {
243  NSLog(@"dW %d  dH %d",({ __typeof__(dW) __a = (dW); __a < 0 ? -__a : __a; }),({ __typeof__(dH) __a = (dH); __a < 0 ? -__a : __a; })); // expected-warning 2 {{values of type 'NSInteger' should not be used as format arguments; add an explicit cast to 'long' instead}}
244}
245
246void testUnicode() {
247  NSLog(@"%C", 0x2022); // no-warning
248  NSLog(@"%C", 0x202200); // expected-warning{{format specifies type 'unichar' (aka 'unsigned short') but the argument has type 'int'}}
249}
250
251