1=encoding utf8 2 3=for comment 4Consistent formatting of this file is achieved with: 5 perl ./Porting/podtidy pod/perlgit.pod 6 7=head1 NAME 8 9perlgit - Detailed information about git and the Perl repository 10 11=head1 DESCRIPTION 12 13This document provides details on using git to develop Perl. If you are 14just interested in working on a quick patch, see L<perlhack> first. 15This document is intended for people who are regular contributors to 16Perl, including those with write access to the git repository. 17 18=head1 CLONING THE REPOSITORY 19 20All of Perl's source code is kept centrally in a Git repository at 21I<github.com>. 22 23You can make a read-only clone of the repository by running: 24 25 % git clone git@github.com:Perl/perl5.git perl 26 27If you cannot use that for firewall reasons, you can also clone via http: 28 29 % git clone https://github.com/Perl/perl5.git perl 30 31=head1 WORKING WITH THE REPOSITORY 32 33Once you have changed into the repository directory, you can inspect 34it. After a clone the repository will contain a single local branch, 35which will be the current branch as well, as indicated by the asterisk. 36 37 % git branch 38 * blead 39 40Using the -a switch to C<branch> will also show the remote tracking 41branches in the repository: 42 43 % git branch -a 44 * blead 45 origin/HEAD 46 origin/blead 47 ... 48 49The branches that begin with "origin" correspond to the "git remote" 50that you cloned from (which is named "origin"). Each branch on the 51remote will be exactly tracked by these branches. You should NEVER do 52work on these remote tracking branches. You only ever do work in a 53local branch. Local branches can be configured to automerge (on pull) 54from a designated remote tracking branch. This is the case with the 55default branch C<blead> which will be configured to merge from the 56remote tracking branch C<origin/blead>. 57 58You can see recent commits: 59 60 % git log 61 62And pull new changes from the repository, and update your local 63repository (must be clean first) 64 65 % git pull 66 67Assuming we are on the branch C<blead> immediately after a pull, this 68command would be more or less equivalent to: 69 70 % git fetch 71 % git merge origin/blead 72 73In fact if you want to update your local repository without touching 74your working directory you do: 75 76 % git fetch 77 78And if you want to update your remote-tracking branches for all defined 79remotes simultaneously you can do 80 81 % git remote update 82 83Neither of these last two commands will update your working directory, 84however both will update the remote-tracking branches in your 85repository. 86 87To make a local branch of a remote branch: 88 89 % git checkout -b maint-5.10 origin/maint-5.10 90 91To switch back to blead: 92 93 % git checkout blead 94 95=head2 Finding out your status 96 97The most common git command you will use will probably be 98 99 % git status 100 101This command will produce as output a description of the current state 102of the repository, including modified files and unignored untracked 103files, and in addition it will show things like what files have been 104staged for the next commit, and usually some useful information about 105how to change things. For instance the following: 106 107 % git status 108 On branch blead 109 Your branch is ahead of 'origin/blead' by 1 commit. 110 111 Changes to be committed: 112 (use "git reset HEAD <file>..." to unstage) 113 114 modified: pod/perlgit.pod 115 116 Changes not staged for commit: 117 (use "git add <file>..." to update what will be committed) 118 (use "git checkout -- <file>..." to discard changes in working 119 directory) 120 121 modified: pod/perlgit.pod 122 123 Untracked files: 124 (use "git add <file>..." to include in what will be committed) 125 126 deliberate.untracked 127 128This shows that there were changes to this document staged for commit, 129and that there were further changes in the working directory not yet 130staged. It also shows that there was an untracked file in the working 131directory, and as you can see shows how to change all of this. It also 132shows that there is one commit on the working branch C<blead> which has 133not been pushed to the C<origin> remote yet. B<NOTE>: This output 134is also what you see as a template if you do not provide a message to 135C<git commit>. 136 137=head2 Patch workflow 138 139First, please read L<perlhack> for details on hacking the Perl core. 140That document covers many details on how to create a good patch. 141 142If you already have a Perl repository, you should ensure that you're on 143the I<blead> branch, and your repository is up to date: 144 145 % git checkout blead 146 % git pull 147 148It's preferable to patch against the latest blead version, since this 149is where new development occurs for all changes other than critical bug 150fixes. Critical bug fix patches should be made against the relevant 151maint branches, or should be submitted with a note indicating all the 152branches where the fix should be applied. 153 154Now that we have everything up to date, we need to create a temporary 155new branch for these changes and switch into it: 156 157 % git checkout -b orange 158 159which is the short form of 160 161 % git branch orange 162 % git checkout orange 163 164Creating a topic branch makes it easier for the maintainers to rebase 165or merge back into the master blead for a more linear history. If you 166don't work on a topic branch the maintainer has to manually cherry pick 167your changes onto blead before they can be applied. 168 169That'll get you scolded on perl5-porters, so don't do that. Be Awesome. 170 171Then make your changes. For example, if Leon Brocard changes his name 172to Orange Brocard, we should change his name in the AUTHORS file: 173 174 % perl -pi -e 's{Leon Brocard}{Orange Brocard}' AUTHORS 175 176You can see what files are changed: 177 178 % git status 179 On branch orange 180 Changes to be committed: 181 (use "git reset HEAD <file>..." to unstage) 182 183 modified: AUTHORS 184 185And you can see the changes: 186 187 % git diff 188 diff --git a/AUTHORS b/AUTHORS 189 index 293dd70..722c93e 100644 190 --- a/AUTHORS 191 +++ b/AUTHORS 192 @@ -541,7 +541,7 @@ Lars Hecking <lhecking@nmrc.ucc.ie> 193 Laszlo Molnar <laszlo.molnar@eth.ericsson.se> 194 Leif Huhn <leif@hale.dkstat.com> 195 Len Johnson <lenjay@ibm.net> 196 -Leon Brocard <acme@astray.com> 197 +Orange Brocard <acme@astray.com> 198 Les Peters <lpeters@aol.net> 199 Lesley Binks <lesley.binks@gmail.com> 200 Lincoln D. Stein <lstein@cshl.org> 201 202Now commit your change locally: 203 204 % git commit -a -m 'Rename Leon Brocard to Orange Brocard' 205 Created commit 6196c1d: Rename Leon Brocard to Orange Brocard 206 1 files changed, 1 insertions(+), 1 deletions(-) 207 208The C<-a> option is used to include all files that git tracks that you 209have changed. If at this time, you only want to commit some of the 210files you have worked on, you can omit the C<-a> and use the command 211C<S<git add I<FILE ...>>> before doing the commit. C<S<git add 212--interactive>> allows you to even just commit portions of files 213instead of all the changes in them. 214 215The C<-m> option is used to specify the commit message. If you omit it, 216git will open a text editor for you to compose the message 217interactively. This is useful when the changes are more complex than 218the sample given here, and, depending on the editor, to know that the 219first line of the commit message doesn't exceed the 50 character legal 220maximum. See L<perlhack/Commit message> for more information about what 221makes a good commit message. 222 223Once you've finished writing your commit message and exited your 224editor, git will write your change to disk and tell you something like 225this: 226 227 Created commit daf8e63: explain git status and stuff about remotes 228 1 files changed, 83 insertions(+), 3 deletions(-) 229 230If you re-run C<git status>, you should see something like this: 231 232 % git status 233 On branch orange 234 Untracked files: 235 (use "git add <file>..." to include in what will be committed) 236 237 deliberate.untracked 238 239 nothing added to commit but untracked files present (use "git add" to 240 track) 241 242When in doubt, before you do anything else, check your status and read 243it carefully, many questions are answered directly by the git status 244output. 245 246You can examine your last commit with: 247 248 % git show HEAD 249 250and if you are not happy with either the description or the patch 251itself you can fix it up by editing the files once more and then issue: 252 253 % git commit -a --amend 254 255Now, create a fork on GitHub to push your branch to, and add it as a 256remote if you haven't already, as described in the GitHub documentation 257at L<https://help.github.com/en/articles/working-with-forks>: 258 259 % git remote add fork git@github.com:MyUser/perl5.git 260 261And push the branch to your fork: 262 263 % git push -u fork orange 264 265You should now submit a Pull Request (PR) on GitHub from the new branch 266to blead. For more information, see the GitHub documentation at 267L<https://help.github.com/en/articles/creating-a-pull-request-from-a-fork>. 268 269You can also send patch files to 270L<perl5-porters@perl.org|mailto:perl5-porters@perl.org> directly if the 271patch is not ready to be applied, but intended for discussion. 272 273To create a patch file for all your local changes: 274 275 % git format-patch -M blead.. 276 0001-Rename-Leon-Brocard-to-Orange-Brocard.patch 277 278Or for a lot of changes, e.g. from a topic branch: 279 280 % git format-patch --stdout -M blead.. > topic-branch-changes.patch 281 282If you want to delete your temporary branch, you may do so with: 283 284 % git checkout blead 285 % git branch -d orange 286 error: The branch 'orange' is not an ancestor of your current HEAD. 287 If you are sure you want to delete it, run 'git branch -D orange'. 288 % git branch -D orange 289 Deleted branch orange. 290 291=head2 A note on derived files 292 293Be aware that many files in the distribution are derivative--avoid 294patching them, because git won't see the changes to them, and the build 295process will overwrite them. Patch the originals instead. Most 296utilities (like perldoc) are in this category, i.e. patch 297F<utils/perldoc.PL> rather than F<utils/perldoc>. Similarly, don't 298create patches for files under F<$src_root/ext> from their copies found 299in F<$install_root/lib>. If you are unsure about the proper location of 300a file that may have gotten copied while building the source 301distribution, consult the F<MANIFEST>. 302 303=head2 Cleaning a working directory 304 305The command C<git clean> can with varying arguments be used as a 306replacement for C<make clean>. 307 308To reset your working directory to a pristine condition you can do: 309 310 % git clean -dxf 311 312However, be aware this will delete ALL untracked content. You can use 313 314 % git clean -Xf 315 316to remove all ignored untracked files, such as build and test 317byproduct, but leave any manually created files alone. 318 319If you only want to cancel some uncommitted edits, you can use C<git 320checkout> and give it a list of files to be reverted, or C<git checkout 321-f> to revert them all. 322 323If you want to cancel one or several commits, you can use C<git reset>. 324 325=head2 Bisecting 326 327C<git> provides a built-in way to determine which commit should be blamed 328for introducing a given bug. C<git bisect> performs a binary search of 329history to locate the first failing commit. It is fast, powerful and 330flexible, but requires some setup and to automate the process an auxiliary 331shell script is needed. 332 333The core provides a wrapper program, F<Porting/bisect.pl>, which attempts to 334simplify as much as possible, making bisecting as simple as running a Perl 335one-liner. For example, if you want to know when this became an error: 336 337 perl -e 'my $a := 2' 338 339you simply run this: 340 341 .../Porting/bisect.pl -e 'my $a := 2;' 342 343Using F<Porting/bisect.pl>, with one command (and no other files) it's easy to 344find out 345 346=over 4 347 348=item * 349 350Which commit caused this example code to break? 351 352=item * 353 354Which commit caused this example code to start working? 355 356=item * 357 358Which commit added the first file to match this regex? 359 360=item * 361 362Which commit removed the last file to match this regex? 363 364=back 365 366usually without needing to know which versions of perl to use as start and 367end revisions, as F<Porting/bisect.pl> automatically searches to find the 368earliest stable version for which the test case passes. Run 369C<Porting/bisect.pl --help> for the full documentation, including how to 370set the C<Configure> and build time options. 371 372If you require more flexibility than F<Porting/bisect.pl> has to offer, you'll 373need to run C<git bisect> yourself. It's most useful to use C<git bisect run> 374to automate the building and testing of perl revisions. For this you'll need 375a shell script for C<git> to call to test a particular revision. An example 376script is F<Porting/bisect-example.sh>, which you should copy B<outside> of 377the repository, as the bisect process will reset the state to a clean checkout 378as it runs. The instructions below assume that you copied it as F<~/run> and 379then edited it as appropriate. 380 381You first enter in bisect mode with: 382 383 % git bisect start 384 385For example, if the bug is present on C<HEAD> but wasn't in 5.10.0, 386C<git> will learn about this when you enter: 387 388 % git bisect bad 389 % git bisect good perl-5.10.0 390 Bisecting: 853 revisions left to test after this 391 392This results in checking out the median commit between C<HEAD> and 393C<perl-5.10.0>. You can then run the bisecting process with: 394 395 % git bisect run ~/run 396 397When the first bad commit is isolated, C<git bisect> will tell you so: 398 399 ca4cfd28534303b82a216cfe83a1c80cbc3b9dc5 is first bad commit 400 commit ca4cfd28534303b82a216cfe83a1c80cbc3b9dc5 401 Author: Dave Mitchell <davem@fdisolutions.com> 402 Date: Sat Feb 9 14:56:23 2008 +0000 403 404 [perl #49472] Attributes + Unknown Error 405 ... 406 407 bisect run success 408 409You can peek into the bisecting process with C<git bisect log> and 410C<git bisect visualize>. C<git bisect reset> will get you out of bisect 411mode. 412 413Please note that the first C<good> state must be an ancestor of the 414first C<bad> state. If you want to search for the commit that I<solved> 415some bug, you have to negate your test case (i.e. exit with C<1> if OK 416and C<0> if not) and still mark the lower bound as C<good> and the 417upper as C<bad>. The "first bad commit" has then to be understood as 418the "first commit where the bug is solved". 419 420C<git help bisect> has much more information on how you can tweak your 421binary searches. 422 423Following bisection you may wish to configure, build and test perl at 424commits identified by the bisection process. Sometimes, particularly 425with older perls, C<make> may fail during this process. In this case 426you may be able to patch the source code at the older commit point. To 427do so, please follow the suggestions provided in 428L<perlhack/Building perl at older commits>. 429 430=head2 Topic branches and rewriting history 431 432Individual committers should create topic branches under 433B<yourname>/B<some_descriptive_name>: 434 435 % branch="$yourname/$some_descriptive_name" 436 % git checkout -b $branch 437 ... do local edits, commits etc ... 438 % git push origin -u $branch 439 440Should you be stuck with an ancient version of git (prior to 1.7), then 441C<git push> will not have the C<-u> switch, and you have to replace the 442last step with the following sequence: 443 444 % git push origin $branch:refs/heads/$branch 445 % git config branch.$branch.remote origin 446 % git config branch.$branch.merge refs/heads/$branch 447 448If you want to make changes to someone else's topic branch, you should 449check with its creator before making any change to it. 450 451You 452might sometimes find that the original author has edited the branch's 453history. There are lots of good reasons for this. Sometimes, an author 454might simply be rebasing the branch onto a newer source point. 455Sometimes, an author might have found an error in an early commit which 456they wanted to fix before merging the branch to blead. 457 458Currently the master repository is configured to forbid 459non-fast-forward merges. This means that the branches within can not be 460rebased and pushed as a single step. 461 462The only way you will ever be allowed to rebase or modify the history 463of a pushed branch is to delete it and push it as a new branch under 464the same name. Please think carefully about doing this. It may be 465better to sequentially rename your branches so that it is easier for 466others working with you to cherry-pick their local changes onto the new 467version. (XXX: needs explanation). 468 469If you want to rebase a personal topic branch, you will have to delete 470your existing topic branch and push as a new version of it. You can do 471this via the following formula (see the explanation about C<refspec>'s 472in the git push documentation for details) after you have rebased your 473branch: 474 475 # first rebase 476 % git checkout $user/$topic 477 % git fetch 478 % git rebase origin/blead 479 480 # then "delete-and-push" 481 % git push origin :$user/$topic 482 % git push origin $user/$topic 483 484B<NOTE:> it is forbidden at the repository level to delete any of the 485"primary" branches. That is any branch matching 486C<m!^(blead|maint|perl)!>. Any attempt to do so will result in git 487producing an error like this: 488 489 % git push origin :blead 490 *** It is forbidden to delete blead/maint branches in this repository 491 error: hooks/update exited with error code 1 492 error: hook declined to update refs/heads/blead 493 To ssh://perl5.git.perl.org/perl 494 ! [remote rejected] blead (hook declined) 495 error: failed to push some refs to 'ssh://perl5.git.perl.org/perl' 496 497As a matter of policy we do B<not> edit the history of the blead and 498maint-* branches. If a typo (or worse) sneaks into a commit to blead or 499maint-*, we'll fix it in another commit. The only types of updates 500allowed on these branches are "fast-forwards", where all history is 501preserved. 502 503Annotated tags in the canonical perl.git repository will never be 504deleted or modified. Think long and hard about whether you want to push 505a local tag to perl.git before doing so. (Pushing simple tags is 506not allowed.) 507 508=head2 Grafts 509 510The perl history contains one mistake which was not caught in the 511conversion: a merge was recorded in the history between blead and 512maint-5.10 where no merge actually occurred. Due to the nature of git, 513this is now impossible to fix in the public repository. You can remove 514this mis-merge locally by adding the following line to your 515C<.git/info/grafts> file: 516 517 296f12bbbbaa06de9be9d09d3dcf8f4528898a49 434946e0cb7a32589ed92d18008aaa1d88515930 518 519It is particularly important to have this graft line if any bisecting 520is done in the area of the "merge" in question. 521 522=head1 WRITE ACCESS TO THE GIT REPOSITORY 523 524Once you have write access, you will need to modify the URL for the 525origin remote to enable pushing. Edit F<.git/config> with the 526git-config(1) command: 527 528 % git config remote.origin.url git@github.com:Perl/perl5.git 529 530You can also set up your user name and e-mail address. Most people do 531this once globally in their F<~/.gitconfig> by doing something like: 532 533 % git config --global user.name "Ævar Arnfjörð Bjarmason" 534 % git config --global user.email avarab@gmail.com 535 536However, if you'd like to override that just for perl, 537execute something like the following in F<perl>: 538 539 % git config user.email avar@cpan.org 540 541It is also possible to keep C<origin> as a git remote, and add a new 542remote for ssh access: 543 544 % git remote add camel git@github.com:Perl/perl5.git 545 546This allows you to update your local repository by pulling from 547C<origin>, which is faster and doesn't require you to authenticate, and 548to push your changes back with the C<camel> remote: 549 550 % git fetch camel 551 % git push camel 552 553The C<fetch> command just updates the C<camel> refs, as the objects 554themselves should have been fetched when pulling from C<origin>. 555 556=head2 Working with Github pull requests 557 558Pull requests typically originate from outside of the C<Perl/perl.git> 559repository, so if you want to test or work with it locally a vanilla 560C<git fetch> from the C<Perl/perl5.git> repository won't fetch it. 561 562However Github does provide a mechanism to fetch a pull request to a 563local branch. They are available on Github remotes under C<pull/>, so 564you can use C<< git fetch pull/I<PRID>/head:I<localname> >> to make a 565local copy. eg. to fetch pull request 9999 to the local branch 566C<local-branch-name> run: 567 568 git fetch origin pull/9999/head:local-branch-name 569 570and then: 571 572 git checkout local-branch-name 573 574Note: this branch is not rebased on C<blead>, so instead of the 575checkout above, you might want: 576 577 git rebase origin/blead local-branch-name 578 579which rebases C<local-branch-name> on C<blead>, and checks it out. 580 581Alternatively you can configure the remote to fetch all pull requests 582as remote-tracking branches. To do this edit the remote in 583F<.git/config>, for example if your github remote is C<origin> you'd 584have: 585 586 [remote "origin"] 587 url = git@github.com:/Perl/perl5.git 588 fetch = +refs/heads/*:refs/remotes/origin/* 589 590Add a line to map the remote pull request branches to remote-tracking 591branches: 592 593 [remote "origin"] 594 url = git@github.com:/Perl/perl5.git 595 fetch = +refs/heads/*:refs/remotes/origin/* 596 fetch = +refs/pull/*/head:refs/remotes/origin/pull/* 597 598and then do a fetch as normal: 599 600 git fetch origin 601 602This will create a remote-tracking branch for every pull request, including 603closed requests. 604 605To remove those remote-tracking branches, remove the line added above 606and prune: 607 608 git fetch -p origin # or git remote prune origin 609 610=head2 Accepting a patch 611 612If you have received a patch file generated using the above section, 613you should try out the patch. 614 615First we need to create a temporary new branch for these changes and 616switch into it: 617 618 % git checkout -b experimental 619 620Patches that were formatted by C<git format-patch> are applied with 621C<git am>: 622 623 % git am 0001-Rename-Leon-Brocard-to-Orange-Brocard.patch 624 Applying Rename Leon Brocard to Orange Brocard 625 626Note that some UNIX mail systems can mess with text attachments containing 627'From '. This will fix them up: 628 629 % perl -pi -e's/^>From /From /' \ 630 0001-Rename-Leon-Brocard-to-Orange-Brocard.patch 631 632If just a raw diff is provided, it is also possible use this two-step 633process: 634 635 % git apply bugfix.diff 636 % git commit -a -m "Some fixing" \ 637 --author="That Guy <that.guy@internets.com>" 638 639Now we can inspect the change: 640 641 % git show HEAD 642 commit b1b3dab48344cff6de4087efca3dbd63548ab5e2 643 Author: Leon Brocard <acme@astray.com> 644 Date: Fri Dec 19 17:02:59 2008 +0000 645 646 Rename Leon Brocard to Orange Brocard 647 648 diff --git a/AUTHORS b/AUTHORS 649 index 293dd70..722c93e 100644 650 --- a/AUTHORS 651 +++ b/AUTHORS 652 @@ -541,7 +541,7 @@ Lars Hecking <lhecking@nmrc.ucc.ie> 653 Laszlo Molnar <laszlo.molnar@eth.ericsson.se> 654 Leif Huhn <leif@hale.dkstat.com> 655 Len Johnson <lenjay@ibm.net> 656 -Leon Brocard <acme@astray.com> 657 +Orange Brocard <acme@astray.com> 658 Les Peters <lpeters@aol.net> 659 Lesley Binks <lesley.binks@gmail.com> 660 Lincoln D. Stein <lstein@cshl.org> 661 662If you are a committer to Perl and you think the patch is good, you can 663then merge it into blead then push it out to the main repository: 664 665 % git checkout blead 666 % git merge experimental 667 % git push origin blead 668 669If you want to delete your temporary branch, you may do so with: 670 671 % git checkout blead 672 % git branch -d experimental 673 error: The branch 'experimental' is not an ancestor of your current 674 HEAD. If you are sure you want to delete it, run 'git branch -D 675 experimental'. 676 % git branch -D experimental 677 Deleted branch experimental. 678 679=head2 Committing to blead 680 681The 'blead' branch will become the next production release of Perl. 682 683Before pushing I<any> local change to blead, it's incredibly important 684that you do a few things, lest other committers come after you with 685pitchforks and torches: 686 687=over 688 689=item * 690 691Make sure you have a good commit message. See L<perlhack/Commit 692message> for details. 693 694=item * 695 696Run the test suite. You might not think that one typo fix would break a 697test file. You'd be wrong. Here's an example of where not running the 698suite caused problems. A patch was submitted that added a couple of 699tests to an existing F<.t>. It couldn't possibly affect anything else, so 700no need to test beyond the single affected F<.t>, right? But, the 701submitter's email address had changed since the last of their 702submissions, and this caused other tests to fail. Running the test 703target given in the next item would have caught this problem. 704 705=item * 706 707If you don't run the full test suite, at least C<make test_porting>. 708This will run basic sanity checks. To see which sanity checks, have a 709look in F<t/porting>. 710 711=item * 712 713If you make any changes that affect miniperl or core routines that have 714different code paths for miniperl, be sure to run C<make minitest>. 715This will catch problems that even the full test suite will not catch 716because it runs a subset of tests under miniperl rather than perl. 717 718=back 719 720=head2 On merging and rebasing 721 722Simple, one-off commits pushed to the 'blead' branch should be simple 723commits that apply cleanly. In other words, you should make sure your 724work is committed against the current position of blead, so that you can 725push back to the master repository without merging. 726 727Sometimes, blead will move while you're building or testing your 728changes. When this happens, your push will be rejected with a message 729like this: 730 731 To ssh://perl5.git.perl.org/perl.git 732 ! [rejected] blead -> blead (non-fast-forward) 733 error: failed to push some refs to 'ssh://perl5.git.perl.org/perl.git' 734 To prevent you from losing history, non-fast-forward updates were 735 rejected Merge the remote changes (e.g. 'git pull') before pushing 736 again. See the 'Note about fast-forwards' section of 'git push --help' 737 for details. 738 739When this happens, you can just I<rebase> your work against the new 740position of blead, like this (assuming your remote for the master 741repository is "p5p"): 742 743 % git fetch p5p 744 % git rebase p5p/blead 745 746You will see your commits being re-applied, and you will then be able to 747push safely. More information about rebasing can be found in the 748documentation for the git-rebase(1) command. 749 750For larger sets of commits that only make sense together, or that would 751benefit from a summary of the set's purpose, you should use a merge 752commit. You should perform your work on a L<topic branch|/Topic 753branches and rewriting history>, which you should regularly rebase 754against blead to ensure that your code is not broken by blead moving. 755When you have finished your work, please perform a final rebase and 756test. Linear history is something that gets lost with every 757commit on blead, but a final rebase makes the history linear 758again, making it easier for future maintainers to see what has 759happened. Rebase as follows (assuming your work was on the 760branch C<< committer/somework >>): 761 762 % git checkout committer/somework 763 % git rebase blead 764 765Then you can merge it into master like this: 766 767 % git checkout blead 768 % git merge --no-ff --no-commit committer/somework 769 % git commit -a 770 771The switches above deserve explanation. C<--no-ff> indicates that even 772if all your work can be applied linearly against blead, a merge commit 773should still be prepared. This ensures that all your work will be shown 774as a side branch, with all its commits merged into the mainstream blead 775by the merge commit. 776 777C<--no-commit> means that the merge commit will be I<prepared> but not 778I<committed>. The commit is then actually performed when you run the 779next command, which will bring up your editor to describe the commit. 780Without C<--no-commit>, the commit would be made with nearly no useful 781message, which would greatly diminish the value of the merge commit as a 782placeholder for the work's description. 783 784When describing the merge commit, explain the purpose of the branch, and 785keep in mind that this description will probably be used by the 786eventual release engineer when reviewing the next perldelta document. 787 788=head2 Committing to maintenance versions 789 790Maintenance versions should only be altered to add critical bug fixes, 791see L<perlpolicy>. 792 793To commit to a maintenance version of perl, you need to create a local 794tracking branch: 795 796 % git checkout --track -b maint-5.005 origin/maint-5.005 797 798This creates a local branch named C<maint-5.005>, which tracks the 799remote branch C<origin/maint-5.005>. Then you can pull, commit, merge 800and push as before. 801 802You can also cherry-pick commits from blead and another branch, by 803using the C<git cherry-pick> command. It is recommended to use the 804B<-x> option to C<git cherry-pick> in order to record the SHA1 of the 805original commit in the new commit message. 806 807Before pushing any change to a maint version, make sure you've 808satisfied the steps in L</Committing to blead> above. 809 810=head2 Using a smoke-me branch to test changes 811 812Sometimes a change affects code paths which you cannot test on the OSes 813which are directly available to you and it would be wise to have users 814on other OSes test the change before you commit it to blead. 815 816Fortunately, there is a way to get your change smoke-tested on various 817OSes: push it to a "smoke-me" branch and wait for certain automated 818smoke-testers to report the results from their OSes. 819A "smoke-me" branch is identified by the branch name: specifically, as 820seen on github.com it must be a local branch whose first name 821component is precisely C<smoke-me>. 822 823The procedure for doing this is roughly as follows (using the example of 824tonyc's smoke-me branch called win32stat): 825 826First, make a local branch and switch to it: 827 828 % git checkout -b win32stat 829 830Make some changes, build perl and test your changes, then commit them to 831your local branch. Then push your local branch to a remote smoke-me 832branch: 833 834 % git push origin win32stat:smoke-me/tonyc/win32stat 835 836Now you can switch back to blead locally: 837 838 % git checkout blead 839 840and continue working on other things while you wait a day or two, 841keeping an eye on the results reported for your smoke-me branch at 842L<http://perl.develop-help.com/?b=smoke-me/tonyc/win32state>. 843 844If all is well then update your blead branch: 845 846 % git pull 847 848then checkout your smoke-me branch once more and rebase it on blead: 849 850 % git rebase blead win32stat 851 852Now switch back to blead and merge your smoke-me branch into it: 853 854 % git checkout blead 855 % git merge win32stat 856 857As described earlier, if there are many changes on your smoke-me branch 858then you should prepare a merge commit in which to give an overview of 859those changes by using the following command instead of the last 860command above: 861 862 % git merge win32stat --no-ff --no-commit 863 864You should now build perl and test your (merged) changes one last time 865(ideally run the whole test suite, but failing that at least run the 866F<t/porting/*.t> tests) before pushing your changes as usual: 867 868 % git push origin blead 869 870Finally, you should then delete the remote smoke-me branch: 871 872 % git push origin :smoke-me/tonyc/win32stat 873 874(which is likely to produce a warning like this, which can be ignored: 875 876 remote: fatal: ambiguous argument 877 'refs/heads/smoke-me/tonyc/win32stat': 878 unknown revision or path not in the working tree. 879 remote: Use '--' to separate paths from revisions 880 881) and then delete your local branch: 882 883 % git branch -d win32stat 884