1=head1 NAME 2 3perlhack - How to hack at the Perl internals 4 5=head1 DESCRIPTION 6 7This document attempts to explain how Perl development takes place, 8and ends with some suggestions for people wanting to become bona fide 9porters. 10 11The perl5-porters mailing list is where the Perl standard distribution 12is maintained and developed. The list can get anywhere from 10 to 150 13messages a day, depending on the heatedness of the debate. Most days 14there are two or three patches, extensions, features, or bugs being 15discussed at a time. 16 17A searchable archive of the list is at either: 18 19 http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/ 20 21or 22 23 http://archive.develooper.com/perl5-porters@perl.org/ 24 25List subscribers (the porters themselves) come in several flavours. 26Some are quiet curious lurkers, who rarely pitch in and instead watch 27the ongoing development to ensure they're forewarned of new changes or 28features in Perl. Some are representatives of vendors, who are there 29to make sure that Perl continues to compile and work on their 30platforms. Some patch any reported bug that they know how to fix, 31some are actively patching their pet area (threads, Win32, the regexp 32engine), while others seem to do nothing but complain. In other 33words, it's your usual mix of technical people. 34 35Over this group of porters presides Larry Wall. He has the final word 36in what does and does not change in the Perl language. Various 37releases of Perl are shepherded by a "pumpking", a porter 38responsible for gathering patches, deciding on a patch-by-patch, 39feature-by-feature basis what will and will not go into the release. 40For instance, Gurusamy Sarathy was the pumpking for the 5.6 release of 41Perl, and Jarkko Hietaniemi was the pumpking for the 5.8 release, and 42Rafael Garcia-Suarez holds the pumpking crown for the 5.10 release. 43 44In addition, various people are pumpkings for different things. For 45instance, Andy Dougherty and Jarkko Hietaniemi did a grand job as the 46I<Configure> pumpkin up till the 5.8 release. For the 5.10 release 47H.Merijn Brand took over. 48 49Larry sees Perl development along the lines of the US government: 50there's the Legislature (the porters), the Executive branch (the 51pumpkings), and the Supreme Court (Larry). The legislature can 52discuss and submit patches to the executive branch all they like, but 53the executive branch is free to veto them. Rarely, the Supreme Court 54will side with the executive branch over the legislature, or the 55legislature over the executive branch. Mostly, however, the 56legislature and the executive branch are supposed to get along and 57work out their differences without impeachment or court cases. 58 59You might sometimes see reference to Rule 1 and Rule 2. Larry's power 60as Supreme Court is expressed in The Rules: 61 62=over 4 63 64=item 1 65 66Larry is always by definition right about how Perl should behave. 67This means he has final veto power on the core functionality. 68 69=item 2 70 71Larry is allowed to change his mind about any matter at a later date, 72regardless of whether he previously invoked Rule 1. 73 74=back 75 76Got that? Larry is always right, even when he was wrong. It's rare 77to see either Rule exercised, but they are often alluded to. 78 79New features and extensions to the language are contentious, because 80the criteria used by the pumpkings, Larry, and other porters to decide 81which features should be implemented and incorporated are not codified 82in a few small design goals as with some other languages. Instead, 83the heuristics are flexible and often difficult to fathom. Here is 84one person's list, roughly in decreasing order of importance, of 85heuristics that new features have to be weighed against: 86 87=over 4 88 89=item Does concept match the general goals of Perl? 90 91These haven't been written anywhere in stone, but one approximation 92is: 93 94 1. Keep it fast, simple, and useful. 95 2. Keep features/concepts as orthogonal as possible. 96 3. No arbitrary limits (platforms, data sizes, cultures). 97 4. Keep it open and exciting to use/patch/advocate Perl everywhere. 98 5. Either assimilate new technologies, or build bridges to them. 99 100=item Where is the implementation? 101 102All the talk in the world is useless without an implementation. In 103almost every case, the person or people who argue for a new feature 104will be expected to be the ones who implement it. Porters capable 105of coding new features have their own agendas, and are not available 106to implement your (possibly good) idea. 107 108=item Backwards compatibility 109 110It's a cardinal sin to break existing Perl programs. New warnings are 111contentious--some say that a program that emits warnings is not 112broken, while others say it is. Adding keywords has the potential to 113break programs, changing the meaning of existing token sequences or 114functions might break programs. 115 116=item Could it be a module instead? 117 118Perl 5 has extension mechanisms, modules and XS, specifically to avoid 119the need to keep changing the Perl interpreter. You can write modules 120that export functions, you can give those functions prototypes so they 121can be called like built-in functions, you can even write XS code to 122mess with the runtime data structures of the Perl interpreter if you 123want to implement really complicated things. If it can be done in a 124module instead of in the core, it's highly unlikely to be added. 125 126=item Is the feature generic enough? 127 128Is this something that only the submitter wants added to the language, 129or would it be broadly useful? Sometimes, instead of adding a feature 130with a tight focus, the porters might decide to wait until someone 131implements the more generalized feature. For instance, instead of 132implementing a "delayed evaluation" feature, the porters are waiting 133for a macro system that would permit delayed evaluation and much more. 134 135=item Does it potentially introduce new bugs? 136 137Radical rewrites of large chunks of the Perl interpreter have the 138potential to introduce new bugs. The smaller and more localized the 139change, the better. 140 141=item Does it preclude other desirable features? 142 143A patch is likely to be rejected if it closes off future avenues of 144development. For instance, a patch that placed a true and final 145interpretation on prototypes is likely to be rejected because there 146are still options for the future of prototypes that haven't been 147addressed. 148 149=item Is the implementation robust? 150 151Good patches (tight code, complete, correct) stand more chance of 152going in. Sloppy or incorrect patches might be placed on the back 153burner until the pumpking has time to fix, or might be discarded 154altogether without further notice. 155 156=item Is the implementation generic enough to be portable? 157 158The worst patches make use of a system-specific features. It's highly 159unlikely that non-portable additions to the Perl language will be 160accepted. 161 162=item Is the implementation tested? 163 164Patches which change behaviour (fixing bugs or introducing new features) 165must include regression tests to verify that everything works as expected. 166Without tests provided by the original author, how can anyone else changing 167perl in the future be sure that they haven't unwittingly broken the behaviour 168the patch implements? And without tests, how can the patch's author be 169confident that his/her hard work put into the patch won't be accidentally 170thrown away by someone in the future? 171 172=item Is there enough documentation? 173 174Patches without documentation are probably ill-thought out or 175incomplete. Nothing can be added without documentation, so submitting 176a patch for the appropriate manpages as well as the source code is 177always a good idea. 178 179=item Is there another way to do it? 180 181Larry said "Although the Perl Slogan is I<There's More Than One Way 182to Do It>, I hesitate to make 10 ways to do something". This is a 183tricky heuristic to navigate, though--one man's essential addition is 184another man's pointless cruft. 185 186=item Does it create too much work? 187 188Work for the pumpking, work for Perl programmers, work for module 189authors, ... Perl is supposed to be easy. 190 191=item Patches speak louder than words 192 193Working code is always preferred to pie-in-the-sky ideas. A patch to 194add a feature stands a much higher chance of making it to the language 195than does a random feature request, no matter how fervently argued the 196request might be. This ties into "Will it be useful?", as the fact 197that someone took the time to make the patch demonstrates a strong 198desire for the feature. 199 200=back 201 202If you're on the list, you might hear the word "core" bandied 203around. It refers to the standard distribution. "Hacking on the 204core" means you're changing the C source code to the Perl 205interpreter. "A core module" is one that ships with Perl. 206 207=head2 Keeping in sync 208 209The source code to the Perl interpreter, in its different versions, is 210kept in a repository managed by the git revision control system. The 211pumpkings and a few others have write access to the repository to check in 212changes. 213 214How to clone and use the git perl repository is described in L<perlrepository>. 215 216You can also choose to use rsync to get a copy of the current source tree 217for the bleadperl branch and all maintenance branches : 218 219 $ rsync -avz rsync://perl5.git.perl.org/APC/perl-current . 220 $ rsync -avz rsync://perl5.git.perl.org/APC/perl-5.10.x . 221 $ rsync -avz rsync://perl5.git.perl.org/APC/perl-5.8.x . 222 $ rsync -avz rsync://perl5.git.perl.org/APC/perl-5.6.x . 223 $ rsync -avz rsync://perl5.git.perl.org/APC/perl-5.005xx . 224 225(Add the C<--delete> option to remove leftover files) 226 227You may also want to subscribe to the perl5-changes mailing list to 228receive a copy of each patch that gets submitted to the maintenance 229and development "branches" of the perl repository. See 230http://lists.perl.org/ for subscription information. 231 232If you are a member of the perl5-porters mailing list, it is a good 233thing to keep in touch with the most recent changes. If not only to 234verify if what you would have posted as a bug report isn't already 235solved in the most recent available perl development branch, also 236known as perl-current, bleading edge perl, bleedperl or bleadperl. 237 238Needless to say, the source code in perl-current is usually in a perpetual 239state of evolution. You should expect it to be very buggy. Do B<not> use 240it for any purpose other than testing and development. 241 242=head2 Perlbug administration 243 244There is a single remote administrative interface for modifying bug status, 245category, open issues etc. using the B<RT> bugtracker system, maintained 246by Robert Spier. Become an administrator, and close any bugs you can get 247your sticky mitts on: 248 249 http://bugs.perl.org/ 250 251To email the bug system administrators: 252 253 "perlbug-admin" <perlbug-admin@perl.org> 254 255=head2 Submitting patches 256 257Always submit patches to I<perl5-porters@perl.org>. If you're 258patching a core module and there's an author listed, send the author a 259copy (see L<Patching a core module>). This lets other porters review 260your patch, which catches a surprising number of errors in patches. 261Please patch against the latest B<development> version. (e.g., even if 262you're fixing a bug in the 5.8 track, patch against the C<blead> branch in 263the git repository.) 264 265If changes are accepted, they are applied to the development branch. Then 266the maintenance pumpking decides which of those patches is to be 267backported to the maint branch. Only patches that survive the heat of the 268development branch get applied to maintenance versions. 269 270Your patch should update the documentation and test suite. See 271L<Writing a test>. If you have added or removed files in the distribution, 272edit the MANIFEST file accordingly, sort the MANIFEST file using 273C<make manisort>, and include those changes as part of your patch. 274 275Patching documentation also follows the same order: if accepted, a patch 276is first applied to B<development>, and if relevant then it's backported 277to B<maintenance>. (With an exception for some patches that document 278behaviour that only appears in the maintenance branch, but which has 279changed in the development version.) 280 281To report a bug in Perl, use the program I<perlbug> which comes with 282Perl (if you can't get Perl to work, send mail to the address 283I<perlbug@perl.org> or I<perlbug@perl.com>). Reporting bugs through 284I<perlbug> feeds into the automated bug-tracking system, access to 285which is provided through the web at http://rt.perl.org/rt3/ . It 286often pays to check the archives of the perl5-porters mailing list to 287see whether the bug you're reporting has been reported before, and if 288so whether it was considered a bug. See above for the location of 289the searchable archives. 290 291The CPAN testers ( http://testers.cpan.org/ ) are a group of 292volunteers who test CPAN modules on a variety of platforms. Perl 293Smokers ( http://www.nntp.perl.org/group/perl.daily-build and 294http://www.nntp.perl.org/group/perl.daily-build.reports/ ) 295automatically test Perl source releases on platforms with various 296configurations. Both efforts welcome volunteers. In order to get 297involved in smoke testing of the perl itself visit 298L<http://search.cpan.org/dist/Test-Smoke>. In order to start smoke 299testing CPAN modules visit L<http://search.cpan.org/dist/CPAN-YACSmoke/> 300or L<http://search.cpan.org/dist/POE-Component-CPAN-YACSmoke/> or 301L<http://search.cpan.org/dist/CPAN-Reporter/>. 302 303It's a good idea to read and lurk for a while before chipping in. 304That way you'll get to see the dynamic of the conversations, learn the 305personalities of the players, and hopefully be better prepared to make 306a useful contribution when do you speak up. 307 308If after all this you still think you want to join the perl5-porters 309mailing list, send mail to I<perl5-porters-subscribe@perl.org>. To 310unsubscribe, send mail to I<perl5-porters-unsubscribe@perl.org>. 311 312To hack on the Perl guts, you'll need to read the following things: 313 314=over 3 315 316=item L<perlguts> 317 318This is of paramount importance, since it's the documentation of what 319goes where in the Perl source. Read it over a couple of times and it 320might start to make sense - don't worry if it doesn't yet, because the 321best way to study it is to read it in conjunction with poking at Perl 322source, and we'll do that later on. 323 324Gisle Aas's illustrated perlguts (aka: illguts) is wonderful, although 325a little out of date wrt some size details; the various SV structures 326have since been reworked for smaller memory footprint. The 327fundamentals are right however, and the pictures are very helpful. 328 329http://www.perl.org/tpc/1998/Perl_Language_and_Modules/Perl%20Illustrated/ 330 331=item L<perlxstut> and L<perlxs> 332 333A working knowledge of XSUB programming is incredibly useful for core 334hacking; XSUBs use techniques drawn from the PP code, the portion of the 335guts that actually executes a Perl program. It's a lot gentler to learn 336those techniques from simple examples and explanation than from the core 337itself. 338 339=item L<perlapi> 340 341The documentation for the Perl API explains what some of the internal 342functions do, as well as the many macros used in the source. 343 344=item F<Porting/pumpkin.pod> 345 346This is a collection of words of wisdom for a Perl porter; some of it is 347only useful to the pumpkin holder, but most of it applies to anyone 348wanting to go about Perl development. 349 350=item The perl5-porters FAQ 351 352This should be available from http://dev.perl.org/perl5/docs/p5p-faq.html . 353It contains hints on reading perl5-porters, information on how 354perl5-porters works and how Perl development in general works. 355 356=back 357 358=head2 Finding Your Way Around 359 360Perl maintenance can be split into a number of areas, and certain people 361(pumpkins) will have responsibility for each area. These areas sometimes 362correspond to files or directories in the source kit. Among the areas are: 363 364=over 3 365 366=item Core modules 367 368Modules shipped as part of the Perl core live in the F<lib/> and F<ext/> 369subdirectories: F<lib/> is for the pure-Perl modules, and F<ext/> 370contains the core XS modules. 371 372=item Tests 373 374There are tests for nearly all the modules, built-ins and major bits 375of functionality. Test files all have a .t suffix. Module tests live 376in the F<lib/> and F<ext/> directories next to the module being 377tested. Others live in F<t/>. See L<Writing a test> 378 379=item Documentation 380 381Documentation maintenance includes looking after everything in the 382F<pod/> directory, (as well as contributing new documentation) and 383the documentation to the modules in core. 384 385=item Configure 386 387The configure process is the way we make Perl portable across the 388myriad of operating systems it supports. Responsibility for the 389configure, build and installation process, as well as the overall 390portability of the core code rests with the configure pumpkin - others 391help out with individual operating systems. 392 393The files involved are the operating system directories, (F<win32/>, 394F<os2/>, F<vms/> and so on) the shell scripts which generate F<config.h> 395and F<Makefile>, as well as the metaconfig files which generate 396F<Configure>. (metaconfig isn't included in the core distribution.) 397 398=item Interpreter 399 400And of course, there's the core of the Perl interpreter itself. Let's 401have a look at that in a little more detail. 402 403=back 404 405Before we leave looking at the layout, though, don't forget that 406F<MANIFEST> contains not only the file names in the Perl distribution, 407but short descriptions of what's in them, too. For an overview of the 408important files, try this: 409 410 perl -lne 'print if /^[^\/]+\.[ch]\s+/' MANIFEST 411 412=head2 Elements of the interpreter 413 414The work of the interpreter has two main stages: compiling the code 415into the internal representation, or bytecode, and then executing it. 416L<perlguts/Compiled code> explains exactly how the compilation stage 417happens. 418 419Here is a short breakdown of perl's operation: 420 421=over 3 422 423=item Startup 424 425The action begins in F<perlmain.c>. (or F<miniperlmain.c> for miniperl) 426This is very high-level code, enough to fit on a single screen, and it 427resembles the code found in L<perlembed>; most of the real action takes 428place in F<perl.c> 429 430F<perlmain.c> is generated by L<writemain> from F<miniperlmain.c> at 431make time, so you should make perl to follow this along. 432 433First, F<perlmain.c> allocates some memory and constructs a Perl 434interpreter, along these lines: 435 436 1 PERL_SYS_INIT3(&argc,&argv,&env); 437 2 438 3 if (!PL_do_undump) { 439 4 my_perl = perl_alloc(); 440 5 if (!my_perl) 441 6 exit(1); 442 7 perl_construct(my_perl); 443 8 PL_perl_destruct_level = 0; 444 9 } 445 446Line 1 is a macro, and its definition is dependent on your operating 447system. Line 3 references C<PL_do_undump>, a global variable - all 448global variables in Perl start with C<PL_>. This tells you whether the 449current running program was created with the C<-u> flag to perl and then 450F<undump>, which means it's going to be false in any sane context. 451 452Line 4 calls a function in F<perl.c> to allocate memory for a Perl 453interpreter. It's quite a simple function, and the guts of it looks like 454this: 455 456 my_perl = (PerlInterpreter*)PerlMem_malloc(sizeof(PerlInterpreter)); 457 458Here you see an example of Perl's system abstraction, which we'll see 459later: C<PerlMem_malloc> is either your system's C<malloc>, or Perl's 460own C<malloc> as defined in F<malloc.c> if you selected that option at 461configure time. 462 463Next, in line 7, we construct the interpreter using perl_construct, 464also in F<perl.c>; this sets up all the special variables that Perl 465needs, the stacks, and so on. 466 467Now we pass Perl the command line options, and tell it to go: 468 469 exitstatus = perl_parse(my_perl, xs_init, argc, argv, (char **)NULL); 470 if (!exitstatus) 471 perl_run(my_perl); 472 473 exitstatus = perl_destruct(my_perl); 474 475 perl_free(my_perl); 476 477C<perl_parse> is actually a wrapper around C<S_parse_body>, as defined 478in F<perl.c>, which processes the command line options, sets up any 479statically linked XS modules, opens the program and calls C<yyparse> to 480parse it. 481 482=item Parsing 483 484The aim of this stage is to take the Perl source, and turn it into an op 485tree. We'll see what one of those looks like later. Strictly speaking, 486there's three things going on here. 487 488C<yyparse>, the parser, lives in F<perly.c>, although you're better off 489reading the original YACC input in F<perly.y>. (Yes, Virginia, there 490B<is> a YACC grammar for Perl!) The job of the parser is to take your 491code and "understand" it, splitting it into sentences, deciding which 492operands go with which operators and so on. 493 494The parser is nobly assisted by the lexer, which chunks up your input 495into tokens, and decides what type of thing each token is: a variable 496name, an operator, a bareword, a subroutine, a core function, and so on. 497The main point of entry to the lexer is C<yylex>, and that and its 498associated routines can be found in F<toke.c>. Perl isn't much like 499other computer languages; it's highly context sensitive at times, it can 500be tricky to work out what sort of token something is, or where a token 501ends. As such, there's a lot of interplay between the tokeniser and the 502parser, which can get pretty frightening if you're not used to it. 503 504As the parser understands a Perl program, it builds up a tree of 505operations for the interpreter to perform during execution. The routines 506which construct and link together the various operations are to be found 507in F<op.c>, and will be examined later. 508 509=item Optimization 510 511Now the parsing stage is complete, and the finished tree represents 512the operations that the Perl interpreter needs to perform to execute our 513program. Next, Perl does a dry run over the tree looking for 514optimisations: constant expressions such as C<3 + 4> will be computed 515now, and the optimizer will also see if any multiple operations can be 516replaced with a single one. For instance, to fetch the variable C<$foo>, 517instead of grabbing the glob C<*foo> and looking at the scalar 518component, the optimizer fiddles the op tree to use a function which 519directly looks up the scalar in question. The main optimizer is C<peep> 520in F<op.c>, and many ops have their own optimizing functions. 521 522=item Running 523 524Now we're finally ready to go: we have compiled Perl byte code, and all 525that's left to do is run it. The actual execution is done by the 526C<runops_standard> function in F<run.c>; more specifically, it's done by 527these three innocent looking lines: 528 529 while ((PL_op = CALL_FPTR(PL_op->op_ppaddr)(aTHX))) { 530 PERL_ASYNC_CHECK(); 531 } 532 533You may be more comfortable with the Perl version of that: 534 535 PERL_ASYNC_CHECK() while $Perl::op = &{$Perl::op->{function}}; 536 537Well, maybe not. Anyway, each op contains a function pointer, which 538stipulates the function which will actually carry out the operation. 539This function will return the next op in the sequence - this allows for 540things like C<if> which choose the next op dynamically at run time. 541The C<PERL_ASYNC_CHECK> makes sure that things like signals interrupt 542execution if required. 543 544The actual functions called are known as PP code, and they're spread 545between four files: F<pp_hot.c> contains the "hot" code, which is most 546often used and highly optimized, F<pp_sys.c> contains all the 547system-specific functions, F<pp_ctl.c> contains the functions which 548implement control structures (C<if>, C<while> and the like) and F<pp.c> 549contains everything else. These are, if you like, the C code for Perl's 550built-in functions and operators. 551 552Note that each C<pp_> function is expected to return a pointer to the next 553op. Calls to perl subs (and eval blocks) are handled within the same 554runops loop, and do not consume extra space on the C stack. For example, 555C<pp_entersub> and C<pp_entertry> just push a C<CxSUB> or C<CxEVAL> block 556struct onto the context stack which contain the address of the op 557following the sub call or eval. They then return the first op of that sub 558or eval block, and so execution continues of that sub or block. Later, a 559C<pp_leavesub> or C<pp_leavetry> op pops the C<CxSUB> or C<CxEVAL>, 560retrieves the return op from it, and returns it. 561 562=item Exception handing 563 564Perl's exception handing (i.e. C<die> etc.) is built on top of the low-level 565C<setjmp()>/C<longjmp()> C-library functions. These basically provide a 566way to capture the current PC and SP registers and later restore them; i.e. 567a C<longjmp()> continues at the point in code where a previous C<setjmp()> 568was done, with anything further up on the C stack being lost. This is why 569code should always save values using C<SAVE_FOO> rather than in auto 570variables. 571 572The perl core wraps C<setjmp()> etc in the macros C<JMPENV_PUSH> and 573C<JMPENV_JUMP>. The basic rule of perl exceptions is that C<exit>, and 574C<die> (in the absence of C<eval>) perform a C<JMPENV_JUMP(2)>, while 575C<die> within C<eval> does a C<JMPENV_JUMP(3)>. 576 577At entry points to perl, such as C<perl_parse()>, C<perl_run()> and 578C<call_sv(cv, G_EVAL)> each does a C<JMPENV_PUSH>, then enter a runops 579loop or whatever, and handle possible exception returns. For a 2 return, 580final cleanup is performed, such as popping stacks and calling C<CHECK> or 581C<END> blocks. Amongst other things, this is how scope cleanup still 582occurs during an C<exit>. 583 584If a C<die> can find a C<CxEVAL> block on the context stack, then the 585stack is popped to that level and the return op in that block is assigned 586to C<PL_restartop>; then a C<JMPENV_JUMP(3)> is performed. This normally 587passes control back to the guard. In the case of C<perl_run> and 588C<call_sv>, a non-null C<PL_restartop> triggers re-entry to the runops 589loop. The is the normal way that C<die> or C<croak> is handled within an 590C<eval>. 591 592Sometimes ops are executed within an inner runops loop, such as tie, sort 593or overload code. In this case, something like 594 595 sub FETCH { eval { die } } 596 597would cause a longjmp right back to the guard in C<perl_run>, popping both 598runops loops, which is clearly incorrect. One way to avoid this is for the 599tie code to do a C<JMPENV_PUSH> before executing C<FETCH> in the inner 600runops loop, but for efficiency reasons, perl in fact just sets a flag, 601using C<CATCH_SET(TRUE)>. The C<pp_require>, C<pp_entereval> and 602C<pp_entertry> ops check this flag, and if true, they call C<docatch>, 603which does a C<JMPENV_PUSH> and starts a new runops level to execute the 604code, rather than doing it on the current loop. 605 606As a further optimisation, on exit from the eval block in the C<FETCH>, 607execution of the code following the block is still carried on in the inner 608loop. When an exception is raised, C<docatch> compares the C<JMPENV> 609level of the C<CxEVAL> with C<PL_top_env> and if they differ, just 610re-throws the exception. In this way any inner loops get popped. 611 612Here's an example. 613 614 1: eval { tie @a, 'A' }; 615 2: sub A::TIEARRAY { 616 3: eval { die }; 617 4: die; 618 5: } 619 620To run this code, C<perl_run> is called, which does a C<JMPENV_PUSH> then 621enters a runops loop. This loop executes the eval and tie ops on line 1, 622with the eval pushing a C<CxEVAL> onto the context stack. 623 624The C<pp_tie> does a C<CATCH_SET(TRUE)>, then starts a second runops loop 625to execute the body of C<TIEARRAY>. When it executes the entertry op on 626line 3, C<CATCH_GET> is true, so C<pp_entertry> calls C<docatch> which 627does a C<JMPENV_PUSH> and starts a third runops loop, which then executes 628the die op. At this point the C call stack looks like this: 629 630 Perl_pp_die 631 Perl_runops # third loop 632 S_docatch_body 633 S_docatch 634 Perl_pp_entertry 635 Perl_runops # second loop 636 S_call_body 637 Perl_call_sv 638 Perl_pp_tie 639 Perl_runops # first loop 640 S_run_body 641 perl_run 642 main 643 644and the context and data stacks, as shown by C<-Dstv>, look like: 645 646 STACK 0: MAIN 647 CX 0: BLOCK => 648 CX 1: EVAL => AV() PV("A"\0) 649 retop=leave 650 STACK 1: MAGIC 651 CX 0: SUB => 652 retop=(null) 653 CX 1: EVAL => * 654 retop=nextstate 655 656The die pops the first C<CxEVAL> off the context stack, sets 657C<PL_restartop> from it, does a C<JMPENV_JUMP(3)>, and control returns to 658the top C<docatch>. This then starts another third-level runops level, 659which executes the nextstate, pushmark and die ops on line 4. At the point 660that the second C<pp_die> is called, the C call stack looks exactly like 661that above, even though we are no longer within an inner eval; this is 662because of the optimization mentioned earlier. However, the context stack 663now looks like this, ie with the top CxEVAL popped: 664 665 STACK 0: MAIN 666 CX 0: BLOCK => 667 CX 1: EVAL => AV() PV("A"\0) 668 retop=leave 669 STACK 1: MAGIC 670 CX 0: SUB => 671 retop=(null) 672 673The die on line 4 pops the context stack back down to the CxEVAL, leaving 674it as: 675 676 STACK 0: MAIN 677 CX 0: BLOCK => 678 679As usual, C<PL_restartop> is extracted from the C<CxEVAL>, and a 680C<JMPENV_JUMP(3)> done, which pops the C stack back to the docatch: 681 682 S_docatch 683 Perl_pp_entertry 684 Perl_runops # second loop 685 S_call_body 686 Perl_call_sv 687 Perl_pp_tie 688 Perl_runops # first loop 689 S_run_body 690 perl_run 691 main 692 693In this case, because the C<JMPENV> level recorded in the C<CxEVAL> 694differs from the current one, C<docatch> just does a C<JMPENV_JUMP(3)> 695and the C stack unwinds to: 696 697 perl_run 698 main 699 700Because C<PL_restartop> is non-null, C<run_body> starts a new runops loop 701and execution continues. 702 703=back 704 705=head2 Internal Variable Types 706 707You should by now have had a look at L<perlguts>, which tells you about 708Perl's internal variable types: SVs, HVs, AVs and the rest. If not, do 709that now. 710 711These variables are used not only to represent Perl-space variables, but 712also any constants in the code, as well as some structures completely 713internal to Perl. The symbol table, for instance, is an ordinary Perl 714hash. Your code is represented by an SV as it's read into the parser; 715any program files you call are opened via ordinary Perl filehandles, and 716so on. 717 718The core L<Devel::Peek|Devel::Peek> module lets us examine SVs from a 719Perl program. Let's see, for instance, how Perl treats the constant 720C<"hello">. 721 722 % perl -MDevel::Peek -e 'Dump("hello")' 723 1 SV = PV(0xa041450) at 0xa04ecbc 724 2 REFCNT = 1 725 3 FLAGS = (POK,READONLY,pPOK) 726 4 PV = 0xa0484e0 "hello"\0 727 5 CUR = 5 728 6 LEN = 6 729 730Reading C<Devel::Peek> output takes a bit of practise, so let's go 731through it line by line. 732 733Line 1 tells us we're looking at an SV which lives at C<0xa04ecbc> in 734memory. SVs themselves are very simple structures, but they contain a 735pointer to a more complex structure. In this case, it's a PV, a 736structure which holds a string value, at location C<0xa041450>. Line 2 737is the reference count; there are no other references to this data, so 738it's 1. 739 740Line 3 are the flags for this SV - it's OK to use it as a PV, it's a 741read-only SV (because it's a constant) and the data is a PV internally. 742Next we've got the contents of the string, starting at location 743C<0xa0484e0>. 744 745Line 5 gives us the current length of the string - note that this does 746B<not> include the null terminator. Line 6 is not the length of the 747string, but the length of the currently allocated buffer; as the string 748grows, Perl automatically extends the available storage via a routine 749called C<SvGROW>. 750 751You can get at any of these quantities from C very easily; just add 752C<Sv> to the name of the field shown in the snippet, and you've got a 753macro which will return the value: C<SvCUR(sv)> returns the current 754length of the string, C<SvREFCOUNT(sv)> returns the reference count, 755C<SvPV(sv, len)> returns the string itself with its length, and so on. 756More macros to manipulate these properties can be found in L<perlguts>. 757 758Let's take an example of manipulating a PV, from C<sv_catpvn>, in F<sv.c> 759 760 1 void 761 2 Perl_sv_catpvn(pTHX_ register SV *sv, register const char *ptr, register STRLEN len) 762 3 { 763 4 STRLEN tlen; 764 5 char *junk; 765 766 6 junk = SvPV_force(sv, tlen); 767 7 SvGROW(sv, tlen + len + 1); 768 8 if (ptr == junk) 769 9 ptr = SvPVX(sv); 770 10 Move(ptr,SvPVX(sv)+tlen,len,char); 771 11 SvCUR(sv) += len; 772 12 *SvEND(sv) = '\0'; 773 13 (void)SvPOK_only_UTF8(sv); /* validate pointer */ 774 14 SvTAINT(sv); 775 15 } 776 777This is a function which adds a string, C<ptr>, of length C<len> onto 778the end of the PV stored in C<sv>. The first thing we do in line 6 is 779make sure that the SV B<has> a valid PV, by calling the C<SvPV_force> 780macro to force a PV. As a side effect, C<tlen> gets set to the current 781value of the PV, and the PV itself is returned to C<junk>. 782 783In line 7, we make sure that the SV will have enough room to accommodate 784the old string, the new string and the null terminator. If C<LEN> isn't 785big enough, C<SvGROW> will reallocate space for us. 786 787Now, if C<junk> is the same as the string we're trying to add, we can 788grab the string directly from the SV; C<SvPVX> is the address of the PV 789in the SV. 790 791Line 10 does the actual catenation: the C<Move> macro moves a chunk of 792memory around: we move the string C<ptr> to the end of the PV - that's 793the start of the PV plus its current length. We're moving C<len> bytes 794of type C<char>. After doing so, we need to tell Perl we've extended the 795string, by altering C<CUR> to reflect the new length. C<SvEND> is a 796macro which gives us the end of the string, so that needs to be a 797C<"\0">. 798 799Line 13 manipulates the flags; since we've changed the PV, any IV or NV 800values will no longer be valid: if we have C<$a=10; $a.="6";> we don't 801want to use the old IV of 10. C<SvPOK_only_utf8> is a special UTF-8-aware 802version of C<SvPOK_only>, a macro which turns off the IOK and NOK flags 803and turns on POK. The final C<SvTAINT> is a macro which launders tainted 804data if taint mode is turned on. 805 806AVs and HVs are more complicated, but SVs are by far the most common 807variable type being thrown around. Having seen something of how we 808manipulate these, let's go on and look at how the op tree is 809constructed. 810 811=head2 Op Trees 812 813First, what is the op tree, anyway? The op tree is the parsed 814representation of your program, as we saw in our section on parsing, and 815it's the sequence of operations that Perl goes through to execute your 816program, as we saw in L</Running>. 817 818An op is a fundamental operation that Perl can perform: all the built-in 819functions and operators are ops, and there are a series of ops which 820deal with concepts the interpreter needs internally - entering and 821leaving a block, ending a statement, fetching a variable, and so on. 822 823The op tree is connected in two ways: you can imagine that there are two 824"routes" through it, two orders in which you can traverse the tree. 825First, parse order reflects how the parser understood the code, and 826secondly, execution order tells perl what order to perform the 827operations in. 828 829The easiest way to examine the op tree is to stop Perl after it has 830finished parsing, and get it to dump out the tree. This is exactly what 831the compiler backends L<B::Terse|B::Terse>, L<B::Concise|B::Concise> 832and L<B::Debug|B::Debug> do. 833 834Let's have a look at how Perl sees C<$a = $b + $c>: 835 836 % perl -MO=Terse -e '$a=$b+$c' 837 1 LISTOP (0x8179888) leave 838 2 OP (0x81798b0) enter 839 3 COP (0x8179850) nextstate 840 4 BINOP (0x8179828) sassign 841 5 BINOP (0x8179800) add [1] 842 6 UNOP (0x81796e0) null [15] 843 7 SVOP (0x80fafe0) gvsv GV (0x80fa4cc) *b 844 8 UNOP (0x81797e0) null [15] 845 9 SVOP (0x8179700) gvsv GV (0x80efeb0) *c 846 10 UNOP (0x816b4f0) null [15] 847 11 SVOP (0x816dcf0) gvsv GV (0x80fa460) *a 848 849Let's start in the middle, at line 4. This is a BINOP, a binary 850operator, which is at location C<0x8179828>. The specific operator in 851question is C<sassign> - scalar assignment - and you can find the code 852which implements it in the function C<pp_sassign> in F<pp_hot.c>. As a 853binary operator, it has two children: the add operator, providing the 854result of C<$b+$c>, is uppermost on line 5, and the left hand side is on 855line 10. 856 857Line 10 is the null op: this does exactly nothing. What is that doing 858there? If you see the null op, it's a sign that something has been 859optimized away after parsing. As we mentioned in L</Optimization>, 860the optimization stage sometimes converts two operations into one, for 861example when fetching a scalar variable. When this happens, instead of 862rewriting the op tree and cleaning up the dangling pointers, it's easier 863just to replace the redundant operation with the null op. Originally, 864the tree would have looked like this: 865 866 10 SVOP (0x816b4f0) rv2sv [15] 867 11 SVOP (0x816dcf0) gv GV (0x80fa460) *a 868 869That is, fetch the C<a> entry from the main symbol table, and then look 870at the scalar component of it: C<gvsv> (C<pp_gvsv> into F<pp_hot.c>) 871happens to do both these things. 872 873The right hand side, starting at line 5 is similar to what we've just 874seen: we have the C<add> op (C<pp_add> also in F<pp_hot.c>) add together 875two C<gvsv>s. 876 877Now, what's this about? 878 879 1 LISTOP (0x8179888) leave 880 2 OP (0x81798b0) enter 881 3 COP (0x8179850) nextstate 882 883C<enter> and C<leave> are scoping ops, and their job is to perform any 884housekeeping every time you enter and leave a block: lexical variables 885are tidied up, unreferenced variables are destroyed, and so on. Every 886program will have those first three lines: C<leave> is a list, and its 887children are all the statements in the block. Statements are delimited 888by C<nextstate>, so a block is a collection of C<nextstate> ops, with 889the ops to be performed for each statement being the children of 890C<nextstate>. C<enter> is a single op which functions as a marker. 891 892That's how Perl parsed the program, from top to bottom: 893 894 Program 895 | 896 Statement 897 | 898 = 899 / \ 900 / \ 901 $a + 902 / \ 903 $b $c 904 905However, it's impossible to B<perform> the operations in this order: 906you have to find the values of C<$b> and C<$c> before you add them 907together, for instance. So, the other thread that runs through the op 908tree is the execution order: each op has a field C<op_next> which points 909to the next op to be run, so following these pointers tells us how perl 910executes the code. We can traverse the tree in this order using 911the C<exec> option to C<B::Terse>: 912 913 % perl -MO=Terse,exec -e '$a=$b+$c' 914 1 OP (0x8179928) enter 915 2 COP (0x81798c8) nextstate 916 3 SVOP (0x81796c8) gvsv GV (0x80fa4d4) *b 917 4 SVOP (0x8179798) gvsv GV (0x80efeb0) *c 918 5 BINOP (0x8179878) add [1] 919 6 SVOP (0x816dd38) gvsv GV (0x80fa468) *a 920 7 BINOP (0x81798a0) sassign 921 8 LISTOP (0x8179900) leave 922 923This probably makes more sense for a human: enter a block, start a 924statement. Get the values of C<$b> and C<$c>, and add them together. 925Find C<$a>, and assign one to the other. Then leave. 926 927The way Perl builds up these op trees in the parsing process can be 928unravelled by examining F<perly.y>, the YACC grammar. Let's take the 929piece we need to construct the tree for C<$a = $b + $c> 930 931 1 term : term ASSIGNOP term 932 2 { $$ = newASSIGNOP(OPf_STACKED, $1, $2, $3); } 933 3 | term ADDOP term 934 4 { $$ = newBINOP($2, 0, scalar($1), scalar($3)); } 935 936If you're not used to reading BNF grammars, this is how it works: You're 937fed certain things by the tokeniser, which generally end up in upper 938case. Here, C<ADDOP>, is provided when the tokeniser sees C<+> in your 939code. C<ASSIGNOP> is provided when C<=> is used for assigning. These are 940"terminal symbols", because you can't get any simpler than them. 941 942The grammar, lines one and three of the snippet above, tells you how to 943build up more complex forms. These complex forms, "non-terminal symbols" 944are generally placed in lower case. C<term> here is a non-terminal 945symbol, representing a single expression. 946 947The grammar gives you the following rule: you can make the thing on the 948left of the colon if you see all the things on the right in sequence. 949This is called a "reduction", and the aim of parsing is to completely 950reduce the input. There are several different ways you can perform a 951reduction, separated by vertical bars: so, C<term> followed by C<=> 952followed by C<term> makes a C<term>, and C<term> followed by C<+> 953followed by C<term> can also make a C<term>. 954 955So, if you see two terms with an C<=> or C<+>, between them, you can 956turn them into a single expression. When you do this, you execute the 957code in the block on the next line: if you see C<=>, you'll do the code 958in line 2. If you see C<+>, you'll do the code in line 4. It's this code 959which contributes to the op tree. 960 961 | term ADDOP term 962 { $$ = newBINOP($2, 0, scalar($1), scalar($3)); } 963 964What this does is creates a new binary op, and feeds it a number of 965variables. The variables refer to the tokens: C<$1> is the first token in 966the input, C<$2> the second, and so on - think regular expression 967backreferences. C<$$> is the op returned from this reduction. So, we 968call C<newBINOP> to create a new binary operator. The first parameter to 969C<newBINOP>, a function in F<op.c>, is the op type. It's an addition 970operator, so we want the type to be C<ADDOP>. We could specify this 971directly, but it's right there as the second token in the input, so we 972use C<$2>. The second parameter is the op's flags: 0 means "nothing 973special". Then the things to add: the left and right hand side of our 974expression, in scalar context. 975 976=head2 Stacks 977 978When perl executes something like C<addop>, how does it pass on its 979results to the next op? The answer is, through the use of stacks. Perl 980has a number of stacks to store things it's currently working on, and 981we'll look at the three most important ones here. 982 983=over 3 984 985=item Argument stack 986 987Arguments are passed to PP code and returned from PP code using the 988argument stack, C<ST>. The typical way to handle arguments is to pop 989them off the stack, deal with them how you wish, and then push the result 990back onto the stack. This is how, for instance, the cosine operator 991works: 992 993 NV value; 994 value = POPn; 995 value = Perl_cos(value); 996 XPUSHn(value); 997 998We'll see a more tricky example of this when we consider Perl's macros 999below. C<POPn> gives you the NV (floating point value) of the top SV on 1000the stack: the C<$x> in C<cos($x)>. Then we compute the cosine, and push 1001the result back as an NV. The C<X> in C<XPUSHn> means that the stack 1002should be extended if necessary - it can't be necessary here, because we 1003know there's room for one more item on the stack, since we've just 1004removed one! The C<XPUSH*> macros at least guarantee safety. 1005 1006Alternatively, you can fiddle with the stack directly: C<SP> gives you 1007the first element in your portion of the stack, and C<TOP*> gives you 1008the top SV/IV/NV/etc. on the stack. So, for instance, to do unary 1009negation of an integer: 1010 1011 SETi(-TOPi); 1012 1013Just set the integer value of the top stack entry to its negation. 1014 1015Argument stack manipulation in the core is exactly the same as it is in 1016XSUBs - see L<perlxstut>, L<perlxs> and L<perlguts> for a longer 1017description of the macros used in stack manipulation. 1018 1019=item Mark stack 1020 1021I say "your portion of the stack" above because PP code doesn't 1022necessarily get the whole stack to itself: if your function calls 1023another function, you'll only want to expose the arguments aimed for the 1024called function, and not (necessarily) let it get at your own data. The 1025way we do this is to have a "virtual" bottom-of-stack, exposed to each 1026function. The mark stack keeps bookmarks to locations in the argument 1027stack usable by each function. For instance, when dealing with a tied 1028variable, (internally, something with "P" magic) Perl has to call 1029methods for accesses to the tied variables. However, we need to separate 1030the arguments exposed to the method to the argument exposed to the 1031original function - the store or fetch or whatever it may be. Here's 1032roughly how the tied C<push> is implemented; see C<av_push> in F<av.c>: 1033 1034 1 PUSHMARK(SP); 1035 2 EXTEND(SP,2); 1036 3 PUSHs(SvTIED_obj((SV*)av, mg)); 1037 4 PUSHs(val); 1038 5 PUTBACK; 1039 6 ENTER; 1040 7 call_method("PUSH", G_SCALAR|G_DISCARD); 1041 8 LEAVE; 1042 1043Let's examine the whole implementation, for practice: 1044 1045 1 PUSHMARK(SP); 1046 1047Push the current state of the stack pointer onto the mark stack. This is 1048so that when we've finished adding items to the argument stack, Perl 1049knows how many things we've added recently. 1050 1051 2 EXTEND(SP,2); 1052 3 PUSHs(SvTIED_obj((SV*)av, mg)); 1053 4 PUSHs(val); 1054 1055We're going to add two more items onto the argument stack: when you have 1056a tied array, the C<PUSH> subroutine receives the object and the value 1057to be pushed, and that's exactly what we have here - the tied object, 1058retrieved with C<SvTIED_obj>, and the value, the SV C<val>. 1059 1060 5 PUTBACK; 1061 1062Next we tell Perl to update the global stack pointer from our internal 1063variable: C<dSP> only gave us a local copy, not a reference to the global. 1064 1065 6 ENTER; 1066 7 call_method("PUSH", G_SCALAR|G_DISCARD); 1067 8 LEAVE; 1068 1069C<ENTER> and C<LEAVE> localise a block of code - they make sure that all 1070variables are tidied up, everything that has been localised gets 1071its previous value returned, and so on. Think of them as the C<{> and 1072C<}> of a Perl block. 1073 1074To actually do the magic method call, we have to call a subroutine in 1075Perl space: C<call_method> takes care of that, and it's described in 1076L<perlcall>. We call the C<PUSH> method in scalar context, and we're 1077going to discard its return value. The call_method() function 1078removes the top element of the mark stack, so there is nothing for 1079the caller to clean up. 1080 1081=item Save stack 1082 1083C doesn't have a concept of local scope, so perl provides one. We've 1084seen that C<ENTER> and C<LEAVE> are used as scoping braces; the save 1085stack implements the C equivalent of, for example: 1086 1087 { 1088 local $foo = 42; 1089 ... 1090 } 1091 1092See L<perlguts/Localising Changes> for how to use the save stack. 1093 1094=back 1095 1096=head2 Millions of Macros 1097 1098One thing you'll notice about the Perl source is that it's full of 1099macros. Some have called the pervasive use of macros the hardest thing 1100to understand, others find it adds to clarity. Let's take an example, 1101the code which implements the addition operator: 1102 1103 1 PP(pp_add) 1104 2 { 1105 3 dSP; dATARGET; tryAMAGICbin(add,opASSIGN); 1106 4 { 1107 5 dPOPTOPnnrl_ul; 1108 6 SETn( left + right ); 1109 7 RETURN; 1110 8 } 1111 9 } 1112 1113Every line here (apart from the braces, of course) contains a macro. The 1114first line sets up the function declaration as Perl expects for PP code; 1115line 3 sets up variable declarations for the argument stack and the 1116target, the return value of the operation. Finally, it tries to see if 1117the addition operation is overloaded; if so, the appropriate subroutine 1118is called. 1119 1120Line 5 is another variable declaration - all variable declarations start 1121with C<d> - which pops from the top of the argument stack two NVs (hence 1122C<nn>) and puts them into the variables C<right> and C<left>, hence the 1123C<rl>. These are the two operands to the addition operator. Next, we 1124call C<SETn> to set the NV of the return value to the result of adding 1125the two values. This done, we return - the C<RETURN> macro makes sure 1126that our return value is properly handled, and we pass the next operator 1127to run back to the main run loop. 1128 1129Most of these macros are explained in L<perlapi>, and some of the more 1130important ones are explained in L<perlxs> as well. Pay special attention 1131to L<perlguts/Background and PERL_IMPLICIT_CONTEXT> for information on 1132the C<[pad]THX_?> macros. 1133 1134=head2 The .i Targets 1135 1136You can expand the macros in a F<foo.c> file by saying 1137 1138 make foo.i 1139 1140which will expand the macros using cpp. Don't be scared by the results. 1141 1142=head1 SOURCE CODE STATIC ANALYSIS 1143 1144Various tools exist for analysing C source code B<statically>, as 1145opposed to B<dynamically>, that is, without executing the code. 1146It is possible to detect resource leaks, undefined behaviour, type 1147mismatches, portability problems, code paths that would cause illegal 1148memory accesses, and other similar problems by just parsing the C code 1149and looking at the resulting graph, what does it tell about the 1150execution and data flows. As a matter of fact, this is exactly 1151how C compilers know to give warnings about dubious code. 1152 1153=head2 lint, splint 1154 1155The good old C code quality inspector, C<lint>, is available in 1156several platforms, but please be aware that there are several 1157different implementations of it by different vendors, which means that 1158the flags are not identical across different platforms. 1159 1160There is a lint variant called C<splint> (Secure Programming Lint) 1161available from http://www.splint.org/ that should compile on any 1162Unix-like platform. 1163 1164There are C<lint> and <splint> targets in Makefile, but you may have 1165to diddle with the flags (see above). 1166 1167=head2 Coverity 1168 1169Coverity (http://www.coverity.com/) is a product similar to lint and 1170as a testbed for their product they periodically check several open 1171source projects, and they give out accounts to open source developers 1172to the defect databases. 1173 1174=head2 cpd (cut-and-paste detector) 1175 1176The cpd tool detects cut-and-paste coding. If one instance of the 1177cut-and-pasted code changes, all the other spots should probably be 1178changed, too. Therefore such code should probably be turned into a 1179subroutine or a macro. 1180 1181cpd (http://pmd.sourceforge.net/cpd.html) is part of the pmd project 1182(http://pmd.sourceforge.net/). pmd was originally written for static 1183analysis of Java code, but later the cpd part of it was extended to 1184parse also C and C++. 1185 1186Download the pmd-bin-X.Y.zip () from the SourceForge site, extract the 1187pmd-X.Y.jar from it, and then run that on source code thusly: 1188 1189 java -cp pmd-X.Y.jar net.sourceforge.pmd.cpd.CPD --minimum-tokens 100 --files /some/where/src --language c > cpd.txt 1190 1191You may run into memory limits, in which case you should use the -Xmx option: 1192 1193 java -Xmx512M ... 1194 1195=head2 gcc warnings 1196 1197Though much can be written about the inconsistency and coverage 1198problems of gcc warnings (like C<-Wall> not meaning "all the 1199warnings", or some common portability problems not being covered by 1200C<-Wall>, or C<-ansi> and C<-pedantic> both being a poorly defined 1201collection of warnings, and so forth), gcc is still a useful tool in 1202keeping our coding nose clean. 1203 1204The C<-Wall> is by default on. 1205 1206The C<-ansi> (and its sidekick, C<-pedantic>) would be nice to be on 1207always, but unfortunately they are not safe on all platforms, they can 1208for example cause fatal conflicts with the system headers (Solaris 1209being a prime example). If Configure C<-Dgccansipedantic> is used, 1210the C<cflags> frontend selects C<-ansi -pedantic> for the platforms 1211where they are known to be safe. 1212 1213Starting from Perl 5.9.4 the following extra flags are added: 1214 1215=over 4 1216 1217=item * 1218 1219C<-Wendif-labels> 1220 1221=item * 1222 1223C<-Wextra> 1224 1225=item * 1226 1227C<-Wdeclaration-after-statement> 1228 1229=back 1230 1231The following flags would be nice to have but they would first need 1232their own Augean stablemaster: 1233 1234=over 4 1235 1236=item * 1237 1238C<-Wpointer-arith> 1239 1240=item * 1241 1242C<-Wshadow> 1243 1244=item * 1245 1246C<-Wstrict-prototypes> 1247 1248=back 1249 1250The C<-Wtraditional> is another example of the annoying tendency of 1251gcc to bundle a lot of warnings under one switch -- it would be 1252impossible to deploy in practice because it would complain a lot -- but 1253it does contain some warnings that would be beneficial to have available 1254on their own, such as the warning about string constants inside macros 1255containing the macro arguments: this behaved differently pre-ANSI 1256than it does in ANSI, and some C compilers are still in transition, 1257AIX being an example. 1258 1259=head2 Warnings of other C compilers 1260 1261Other C compilers (yes, there B<are> other C compilers than gcc) often 1262have their "strict ANSI" or "strict ANSI with some portability extensions" 1263modes on, like for example the Sun Workshop has its C<-Xa> mode on 1264(though implicitly), or the DEC (these days, HP...) has its C<-std1> 1265mode on. 1266 1267=head2 DEBUGGING 1268 1269You can compile a special debugging version of Perl, which allows you 1270to use the C<-D> option of Perl to tell more about what Perl is doing. 1271But sometimes there is no alternative than to dive in with a debugger, 1272either to see the stack trace of a core dump (very useful in a bug 1273report), or trying to figure out what went wrong before the core dump 1274happened, or how did we end up having wrong or unexpected results. 1275 1276=head2 Poking at Perl 1277 1278To really poke around with Perl, you'll probably want to build Perl for 1279debugging, like this: 1280 1281 ./Configure -d -D optimize=-g 1282 make 1283 1284C<-g> is a flag to the C compiler to have it produce debugging 1285information which will allow us to step through a running program, 1286and to see in which C function we are at (without the debugging 1287information we might see only the numerical addresses of the functions, 1288which is not very helpful). 1289 1290F<Configure> will also turn on the C<DEBUGGING> compilation symbol which 1291enables all the internal debugging code in Perl. There are a whole bunch 1292of things you can debug with this: L<perlrun> lists them all, and the 1293best way to find out about them is to play about with them. The most 1294useful options are probably 1295 1296 l Context (loop) stack processing 1297 t Trace execution 1298 o Method and overloading resolution 1299 c String/numeric conversions 1300 1301Some of the functionality of the debugging code can be achieved using XS 1302modules. 1303 1304 -Dr => use re 'debug' 1305 -Dx => use O 'Debug' 1306 1307=head2 Using a source-level debugger 1308 1309If the debugging output of C<-D> doesn't help you, it's time to step 1310through perl's execution with a source-level debugger. 1311 1312=over 3 1313 1314=item * 1315 1316We'll use C<gdb> for our examples here; the principles will apply to 1317any debugger (many vendors call their debugger C<dbx>), but check the 1318manual of the one you're using. 1319 1320=back 1321 1322To fire up the debugger, type 1323 1324 gdb ./perl 1325 1326Or if you have a core dump: 1327 1328 gdb ./perl core 1329 1330You'll want to do that in your Perl source tree so the debugger can read 1331the source code. You should see the copyright message, followed by the 1332prompt. 1333 1334 (gdb) 1335 1336C<help> will get you into the documentation, but here are the most 1337useful commands: 1338 1339=over 3 1340 1341=item run [args] 1342 1343Run the program with the given arguments. 1344 1345=item break function_name 1346 1347=item break source.c:xxx 1348 1349Tells the debugger that we'll want to pause execution when we reach 1350either the named function (but see L<perlguts/Internal Functions>!) or the given 1351line in the named source file. 1352 1353=item step 1354 1355Steps through the program a line at a time. 1356 1357=item next 1358 1359Steps through the program a line at a time, without descending into 1360functions. 1361 1362=item continue 1363 1364Run until the next breakpoint. 1365 1366=item finish 1367 1368Run until the end of the current function, then stop again. 1369 1370=item 'enter' 1371 1372Just pressing Enter will do the most recent operation again - it's a 1373blessing when stepping through miles of source code. 1374 1375=item print 1376 1377Execute the given C code and print its results. B<WARNING>: Perl makes 1378heavy use of macros, and F<gdb> does not necessarily support macros 1379(see later L</"gdb macro support">). You'll have to substitute them 1380yourself, or to invoke cpp on the source code files 1381(see L</"The .i Targets">) 1382So, for instance, you can't say 1383 1384 print SvPV_nolen(sv) 1385 1386but you have to say 1387 1388 print Perl_sv_2pv_nolen(sv) 1389 1390=back 1391 1392You may find it helpful to have a "macro dictionary", which you can 1393produce by saying C<cpp -dM perl.c | sort>. Even then, F<cpp> won't 1394recursively apply those macros for you. 1395 1396=head2 gdb macro support 1397 1398Recent versions of F<gdb> have fairly good macro support, but 1399in order to use it you'll need to compile perl with macro definitions 1400included in the debugging information. Using F<gcc> version 3.1, this 1401means configuring with C<-Doptimize=-g3>. Other compilers might use a 1402different switch (if they support debugging macros at all). 1403 1404=head2 Dumping Perl Data Structures 1405 1406One way to get around this macro hell is to use the dumping functions in 1407F<dump.c>; these work a little like an internal 1408L<Devel::Peek|Devel::Peek>, but they also cover OPs and other structures 1409that you can't get at from Perl. Let's take an example. We'll use the 1410C<$a = $b + $c> we used before, but give it a bit of context: 1411C<$b = "6XXXX"; $c = 2.3;>. Where's a good place to stop and poke around? 1412 1413What about C<pp_add>, the function we examined earlier to implement the 1414C<+> operator: 1415 1416 (gdb) break Perl_pp_add 1417 Breakpoint 1 at 0x46249f: file pp_hot.c, line 309. 1418 1419Notice we use C<Perl_pp_add> and not C<pp_add> - see L<perlguts/Internal Functions>. 1420With the breakpoint in place, we can run our program: 1421 1422 (gdb) run -e '$b = "6XXXX"; $c = 2.3; $a = $b + $c' 1423 1424Lots of junk will go past as gdb reads in the relevant source files and 1425libraries, and then: 1426 1427 Breakpoint 1, Perl_pp_add () at pp_hot.c:309 1428 309 dSP; dATARGET; tryAMAGICbin(add,opASSIGN); 1429 (gdb) step 1430 311 dPOPTOPnnrl_ul; 1431 (gdb) 1432 1433We looked at this bit of code before, and we said that C<dPOPTOPnnrl_ul> 1434arranges for two C<NV>s to be placed into C<left> and C<right> - let's 1435slightly expand it: 1436 1437 #define dPOPTOPnnrl_ul NV right = POPn; \ 1438 SV *leftsv = TOPs; \ 1439 NV left = USE_LEFT(leftsv) ? SvNV(leftsv) : 0.0 1440 1441C<POPn> takes the SV from the top of the stack and obtains its NV either 1442directly (if C<SvNOK> is set) or by calling the C<sv_2nv> function. 1443C<TOPs> takes the next SV from the top of the stack - yes, C<POPn> uses 1444C<TOPs> - but doesn't remove it. We then use C<SvNV> to get the NV from 1445C<leftsv> in the same way as before - yes, C<POPn> uses C<SvNV>. 1446 1447Since we don't have an NV for C<$b>, we'll have to use C<sv_2nv> to 1448convert it. If we step again, we'll find ourselves there: 1449 1450 Perl_sv_2nv (sv=0xa0675d0) at sv.c:1669 1451 1669 if (!sv) 1452 (gdb) 1453 1454We can now use C<Perl_sv_dump> to investigate the SV: 1455 1456 SV = PV(0xa057cc0) at 0xa0675d0 1457 REFCNT = 1 1458 FLAGS = (POK,pPOK) 1459 PV = 0xa06a510 "6XXXX"\0 1460 CUR = 5 1461 LEN = 6 1462 $1 = void 1463 1464We know we're going to get C<6> from this, so let's finish the 1465subroutine: 1466 1467 (gdb) finish 1468 Run till exit from #0 Perl_sv_2nv (sv=0xa0675d0) at sv.c:1671 1469 0x462669 in Perl_pp_add () at pp_hot.c:311 1470 311 dPOPTOPnnrl_ul; 1471 1472We can also dump out this op: the current op is always stored in 1473C<PL_op>, and we can dump it with C<Perl_op_dump>. This'll give us 1474similar output to L<B::Debug|B::Debug>. 1475 1476 { 1477 13 TYPE = add ===> 14 1478 TARG = 1 1479 FLAGS = (SCALAR,KIDS) 1480 { 1481 TYPE = null ===> (12) 1482 (was rv2sv) 1483 FLAGS = (SCALAR,KIDS) 1484 { 1485 11 TYPE = gvsv ===> 12 1486 FLAGS = (SCALAR) 1487 GV = main::b 1488 } 1489 } 1490 1491# finish this later # 1492 1493=head2 Patching 1494 1495All right, we've now had a look at how to navigate the Perl sources and 1496some things you'll need to know when fiddling with them. Let's now get 1497on and create a simple patch. Here's something Larry suggested: if a 1498C<U> is the first active format during a C<pack>, (for example, 1499C<pack "U3C8", @stuff>) then the resulting string should be treated as 1500UTF-8 encoded. 1501 1502How do we prepare to fix this up? First we locate the code in question - 1503the C<pack> happens at runtime, so it's going to be in one of the F<pp> 1504files. Sure enough, C<pp_pack> is in F<pp.c>. Since we're going to be 1505altering this file, let's copy it to F<pp.c~>. 1506 1507[Well, it was in F<pp.c> when this tutorial was written. It has now been 1508split off with C<pp_unpack> to its own file, F<pp_pack.c>] 1509 1510Now let's look over C<pp_pack>: we take a pattern into C<pat>, and then 1511loop over the pattern, taking each format character in turn into 1512C<datum_type>. Then for each possible format character, we swallow up 1513the other arguments in the pattern (a field width, an asterisk, and so 1514on) and convert the next chunk input into the specified format, adding 1515it onto the output SV C<cat>. 1516 1517How do we know if the C<U> is the first format in the C<pat>? Well, if 1518we have a pointer to the start of C<pat> then, if we see a C<U> we can 1519test whether we're still at the start of the string. So, here's where 1520C<pat> is set up: 1521 1522 STRLEN fromlen; 1523 register char *pat = SvPVx(*++MARK, fromlen); 1524 register char *patend = pat + fromlen; 1525 register I32 len; 1526 I32 datumtype; 1527 SV *fromstr; 1528 1529We'll have another string pointer in there: 1530 1531 STRLEN fromlen; 1532 register char *pat = SvPVx(*++MARK, fromlen); 1533 register char *patend = pat + fromlen; 1534 + char *patcopy; 1535 register I32 len; 1536 I32 datumtype; 1537 SV *fromstr; 1538 1539And just before we start the loop, we'll set C<patcopy> to be the start 1540of C<pat>: 1541 1542 items = SP - MARK; 1543 MARK++; 1544 sv_setpvn(cat, "", 0); 1545 + patcopy = pat; 1546 while (pat < patend) { 1547 1548Now if we see a C<U> which was at the start of the string, we turn on 1549the C<UTF8> flag for the output SV, C<cat>: 1550 1551 + if (datumtype == 'U' && pat==patcopy+1) 1552 + SvUTF8_on(cat); 1553 if (datumtype == '#') { 1554 while (pat < patend && *pat != '\n') 1555 pat++; 1556 1557Remember that it has to be C<patcopy+1> because the first character of 1558the string is the C<U> which has been swallowed into C<datumtype!> 1559 1560Oops, we forgot one thing: what if there are spaces at the start of the 1561pattern? C<pack(" U*", @stuff)> will have C<U> as the first active 1562character, even though it's not the first thing in the pattern. In this 1563case, we have to advance C<patcopy> along with C<pat> when we see spaces: 1564 1565 if (isSPACE(datumtype)) 1566 continue; 1567 1568needs to become 1569 1570 if (isSPACE(datumtype)) { 1571 patcopy++; 1572 continue; 1573 } 1574 1575OK. That's the C part done. Now we must do two additional things before 1576this patch is ready to go: we've changed the behaviour of Perl, and so 1577we must document that change. We must also provide some more regression 1578tests to make sure our patch works and doesn't create a bug somewhere 1579else along the line. 1580 1581The regression tests for each operator live in F<t/op/>, and so we 1582make a copy of F<t/op/pack.t> to F<t/op/pack.t~>. Now we can add our 1583tests to the end. First, we'll test that the C<U> does indeed create 1584Unicode strings. 1585 1586t/op/pack.t has a sensible ok() function, but if it didn't we could 1587use the one from t/test.pl. 1588 1589 require './test.pl'; 1590 plan( tests => 159 ); 1591 1592so instead of this: 1593 1594 print 'not ' unless "1.20.300.4000" eq sprintf "%vd", pack("U*",1,20,300,4000); 1595 print "ok $test\n"; $test++; 1596 1597we can write the more sensible (see L<Test::More> for a full 1598explanation of is() and other testing functions). 1599 1600 is( "1.20.300.4000", sprintf "%vd", pack("U*",1,20,300,4000), 1601 "U* produces Unicode" ); 1602 1603Now we'll test that we got that space-at-the-beginning business right: 1604 1605 is( "1.20.300.4000", sprintf "%vd", pack(" U*",1,20,300,4000), 1606 " with spaces at the beginning" ); 1607 1608And finally we'll test that we don't make Unicode strings if C<U> is B<not> 1609the first active format: 1610 1611 isnt( v1.20.300.4000, sprintf "%vd", pack("C0U*",1,20,300,4000), 1612 "U* not first isn't Unicode" ); 1613 1614Mustn't forget to change the number of tests which appears at the top, 1615or else the automated tester will get confused. This will either look 1616like this: 1617 1618 print "1..156\n"; 1619 1620or this: 1621 1622 plan( tests => 156 ); 1623 1624We now compile up Perl, and run it through the test suite. Our new 1625tests pass, hooray! 1626 1627Finally, the documentation. The job is never done until the paperwork is 1628over, so let's describe the change we've just made. The relevant place 1629is F<pod/perlfunc.pod>; again, we make a copy, and then we'll insert 1630this text in the description of C<pack>: 1631 1632 =item * 1633 1634 If the pattern begins with a C<U>, the resulting string will be treated 1635 as UTF-8-encoded Unicode. You can force UTF-8 encoding on in a string 1636 with an initial C<U0>, and the bytes that follow will be interpreted as 1637 Unicode characters. If you don't want this to happen, you can begin your 1638 pattern with C<C0> (or anything else) to force Perl not to UTF-8 encode your 1639 string, and then follow this with a C<U*> somewhere in your pattern. 1640 1641All done. Now let's create the patch. F<Porting/patching.pod> tells us 1642that if we're making major changes, we should copy the entire directory 1643to somewhere safe before we begin fiddling, and then do 1644 1645 diff -ruN old new > patch 1646 1647However, we know which files we've changed, and we can simply do this: 1648 1649 diff -u pp.c~ pp.c > patch 1650 diff -u t/op/pack.t~ t/op/pack.t >> patch 1651 diff -u pod/perlfunc.pod~ pod/perlfunc.pod >> patch 1652 1653We end up with a patch looking a little like this: 1654 1655 --- pp.c~ Fri Jun 02 04:34:10 2000 1656 +++ pp.c Fri Jun 16 11:37:25 2000 1657 @@ -4375,6 +4375,7 @@ 1658 register I32 items; 1659 STRLEN fromlen; 1660 register char *pat = SvPVx(*++MARK, fromlen); 1661 + char *patcopy; 1662 register char *patend = pat + fromlen; 1663 register I32 len; 1664 I32 datumtype; 1665 @@ -4405,6 +4406,7 @@ 1666 ... 1667 1668And finally, we submit it, with our rationale, to perl5-porters. Job 1669done! 1670 1671=head2 Patching a core module 1672 1673This works just like patching anything else, with an extra 1674consideration. Many core modules also live on CPAN. If this is so, 1675patch the CPAN version instead of the core and send the patch off to 1676the module maintainer (with a copy to p5p). This will help the module 1677maintainer keep the CPAN version in sync with the core version without 1678constantly scanning p5p. 1679 1680The list of maintainers of core modules is usefully documented in 1681F<Porting/Maintainers.pl>. 1682 1683=head2 Adding a new function to the core 1684 1685If, as part of a patch to fix a bug, or just because you have an 1686especially good idea, you decide to add a new function to the core, 1687discuss your ideas on p5p well before you start work. It may be that 1688someone else has already attempted to do what you are considering and 1689can give lots of good advice or even provide you with bits of code 1690that they already started (but never finished). 1691 1692You have to follow all of the advice given above for patching. It is 1693extremely important to test any addition thoroughly and add new tests 1694to explore all boundary conditions that your new function is expected 1695to handle. If your new function is used only by one module (e.g. toke), 1696then it should probably be named S_your_function (for static); on the 1697other hand, if you expect it to accessible from other functions in 1698Perl, you should name it Perl_your_function. See L<perlguts/Internal Functions> 1699for more details. 1700 1701The location of any new code is also an important consideration. Don't 1702just create a new top level .c file and put your code there; you would 1703have to make changes to Configure (so the Makefile is created properly), 1704as well as possibly lots of include files. This is strictly pumpking 1705business. 1706 1707It is better to add your function to one of the existing top level 1708source code files, but your choice is complicated by the nature of 1709the Perl distribution. Only the files that are marked as compiled 1710static are located in the perl executable. Everything else is located 1711in the shared library (or DLL if you are running under WIN32). So, 1712for example, if a function was only used by functions located in 1713toke.c, then your code can go in toke.c. If, however, you want to call 1714the function from universal.c, then you should put your code in another 1715location, for example util.c. 1716 1717In addition to writing your c-code, you will need to create an 1718appropriate entry in embed.pl describing your function, then run 1719'make regen_headers' to create the entries in the numerous header 1720files that perl needs to compile correctly. See L<perlguts/Internal Functions> 1721for information on the various options that you can set in embed.pl. 1722You will forget to do this a few (or many) times and you will get 1723warnings during the compilation phase. Make sure that you mention 1724this when you post your patch to P5P; the pumpking needs to know this. 1725 1726When you write your new code, please be conscious of existing code 1727conventions used in the perl source files. See L<perlstyle> for 1728details. Although most of the guidelines discussed seem to focus on 1729Perl code, rather than c, they all apply (except when they don't ;). 1730See also I<Porting/patching.pod> file in the Perl source distribution 1731for lots of details about both formatting and submitting patches of 1732your changes. 1733 1734Lastly, TEST TEST TEST TEST TEST any code before posting to p5p. 1735Test on as many platforms as you can find. Test as many perl 1736Configure options as you can (e.g. MULTIPLICITY). If you have 1737profiling or memory tools, see L<EXTERNAL TOOLS FOR DEBUGGING PERL> 1738below for how to use them to further test your code. Remember that 1739most of the people on P5P are doing this on their own time and 1740don't have the time to debug your code. 1741 1742=head2 Writing a test 1743 1744Every module and built-in function has an associated test file (or 1745should...). If you add or change functionality, you have to write a 1746test. If you fix a bug, you have to write a test so that bug never 1747comes back. If you alter the docs, it would be nice to test what the 1748new documentation says. 1749 1750In short, if you submit a patch you probably also have to patch the 1751tests. 1752 1753For modules, the test file is right next to the module itself. 1754F<lib/strict.t> tests F<lib/strict.pm>. This is a recent innovation, 1755so there are some snags (and it would be wonderful for you to brush 1756them out), but it basically works that way. Everything else lives in 1757F<t/>. 1758 1759If you add a new test directory under F<t/>, it is imperative that you 1760add that directory to F<t/HARNESS> and F<t/TEST>. 1761 1762=over 3 1763 1764=item F<t/base/> 1765 1766Testing of the absolute basic functionality of Perl. Things like 1767C<if>, basic file reads and writes, simple regexes, etc. These are 1768run first in the test suite and if any of them fail, something is 1769I<really> broken. 1770 1771=item F<t/cmd/> 1772 1773These test the basic control structures, C<if/else>, C<while>, 1774subroutines, etc. 1775 1776=item F<t/comp/> 1777 1778Tests basic issues of how Perl parses and compiles itself. 1779 1780=item F<t/io/> 1781 1782Tests for built-in IO functions, including command line arguments. 1783 1784=item F<t/lib/> 1785 1786The old home for the module tests, you shouldn't put anything new in 1787here. There are still some bits and pieces hanging around in here 1788that need to be moved. Perhaps you could move them? Thanks! 1789 1790=item F<t/mro/> 1791 1792Tests for perl's method resolution order implementations 1793(see L<mro>). 1794 1795=item F<t/op/> 1796 1797Tests for perl's built in functions that don't fit into any of the 1798other directories. 1799 1800=item F<t/pod/> 1801 1802Tests for POD directives. There are still some tests for the Pod 1803modules hanging around in here that need to be moved out into F<lib/>. 1804 1805=item F<t/run/> 1806 1807Testing features of how perl actually runs, including exit codes and 1808handling of PERL* environment variables. 1809 1810=item F<t/uni/> 1811 1812Tests for the core support of Unicode. 1813 1814=item F<t/win32/> 1815 1816Windows-specific tests. 1817 1818=item F<t/x2p> 1819 1820A test suite for the s2p converter. 1821 1822=back 1823 1824The core uses the same testing style as the rest of Perl, a simple 1825"ok/not ok" run through Test::Harness, but there are a few special 1826considerations. 1827 1828There are three ways to write a test in the core. Test::More, 1829t/test.pl and ad hoc C<print $test ? "ok 42\n" : "not ok 42\n">. The 1830decision of which to use depends on what part of the test suite you're 1831working on. This is a measure to prevent a high-level failure (such 1832as Config.pm breaking) from causing basic functionality tests to fail. 1833 1834=over 4 1835 1836=item t/base t/comp 1837 1838Since we don't know if require works, or even subroutines, use ad hoc 1839tests for these two. Step carefully to avoid using the feature being 1840tested. 1841 1842=item t/cmd t/run t/io t/op 1843 1844Now that basic require() and subroutines are tested, you can use the 1845t/test.pl library which emulates the important features of Test::More 1846while using a minimum of core features. 1847 1848You can also conditionally use certain libraries like Config, but be 1849sure to skip the test gracefully if it's not there. 1850 1851=item t/lib ext lib 1852 1853Now that the core of Perl is tested, Test::More can be used. You can 1854also use the full suite of core modules in the tests. 1855 1856=back 1857 1858When you say "make test" Perl uses the F<t/TEST> program to run the 1859test suite (except under Win32 where it uses F<t/harness> instead.) 1860All tests are run from the F<t/> directory, B<not> the directory 1861which contains the test. This causes some problems with the tests 1862in F<lib/>, so here's some opportunity for some patching. 1863 1864You must be triply conscious of cross-platform concerns. This usually 1865boils down to using File::Spec and avoiding things like C<fork()> and 1866C<system()> unless absolutely necessary. 1867 1868=head2 Special Make Test Targets 1869 1870There are various special make targets that can be used to test Perl 1871slightly differently than the standard "test" target. Not all them 1872are expected to give a 100% success rate. Many of them have several 1873aliases, and many of them are not available on certain operating 1874systems. 1875 1876=over 4 1877 1878=item coretest 1879 1880Run F<perl> on all core tests (F<t/*> and F<lib/[a-z]*> pragma tests). 1881 1882(Not available on Win32) 1883 1884=item test.deparse 1885 1886Run all the tests through B::Deparse. Not all tests will succeed. 1887 1888(Not available on Win32) 1889 1890=item test.taintwarn 1891 1892Run all tests with the B<-t> command-line switch. Not all tests 1893are expected to succeed (until they're specifically fixed, of course). 1894 1895(Not available on Win32) 1896 1897=item minitest 1898 1899Run F<miniperl> on F<t/base>, F<t/comp>, F<t/cmd>, F<t/run>, F<t/io>, 1900F<t/op>, F<t/uni> and F<t/mro> tests. 1901 1902=item test.valgrind check.valgrind utest.valgrind ucheck.valgrind 1903 1904(Only in Linux) Run all the tests using the memory leak + naughty 1905memory access tool "valgrind". The log files will be named 1906F<testname.valgrind>. 1907 1908=item test.third check.third utest.third ucheck.third 1909 1910(Only in Tru64) Run all the tests using the memory leak + naughty 1911memory access tool "Third Degree". The log files will be named 1912F<perl.3log.testname>. 1913 1914=item test.torture torturetest 1915 1916Run all the usual tests and some extra tests. As of Perl 5.8.0 the 1917only extra tests are Abigail's JAPHs, F<t/japh/abigail.t>. 1918 1919You can also run the torture test with F<t/harness> by giving 1920C<-torture> argument to F<t/harness>. 1921 1922=item utest ucheck test.utf8 check.utf8 1923 1924Run all the tests with -Mutf8. Not all tests will succeed. 1925 1926(Not available on Win32) 1927 1928=item minitest.utf16 test.utf16 1929 1930Runs the tests with UTF-16 encoded scripts, encoded with different 1931versions of this encoding. 1932 1933C<make utest.utf16> runs the test suite with a combination of C<-utf8> and 1934C<-utf16> arguments to F<t/TEST>. 1935 1936(Not available on Win32) 1937 1938=item test_harness 1939 1940Run the test suite with the F<t/harness> controlling program, instead of 1941F<t/TEST>. F<t/harness> is more sophisticated, and uses the 1942L<Test::Harness> module, thus using this test target supposes that perl 1943mostly works. The main advantage for our purposes is that it prints a 1944detailed summary of failed tests at the end. Also, unlike F<t/TEST>, it 1945doesn't redirect stderr to stdout. 1946 1947Note that under Win32 F<t/harness> is always used instead of F<t/TEST>, so 1948there is no special "test_harness" target. 1949 1950Under Win32's "test" target you may use the TEST_SWITCHES and TEST_FILES 1951environment variables to control the behaviour of F<t/harness>. This means 1952you can say 1953 1954 nmake test TEST_FILES="op/*.t" 1955 nmake test TEST_SWITCHES="-torture" TEST_FILES="op/*.t" 1956 1957=item test-notty test_notty 1958 1959Sets PERL_SKIP_TTY_TEST to true before running normal test. 1960 1961=back 1962 1963=head2 Running tests by hand 1964 1965You can run part of the test suite by hand by using one the following 1966commands from the F<t/> directory : 1967 1968 ./perl -I../lib TEST list-of-.t-files 1969 1970or 1971 1972 ./perl -I../lib harness list-of-.t-files 1973 1974(if you don't specify test scripts, the whole test suite will be run.) 1975 1976=head3 Using t/harness for testing 1977 1978If you use C<harness> for testing you have several command line options 1979available to you. The arguments are as follows, and are in the order 1980that they must appear if used together. 1981 1982 harness -v -torture -re=pattern LIST OF FILES TO TEST 1983 harness -v -torture -re LIST OF PATTERNS TO MATCH 1984 1985If C<LIST OF FILES TO TEST> is omitted the file list is obtained from 1986the manifest. The file list may include shell wildcards which will be 1987expanded out. 1988 1989=over 4 1990 1991=item -v 1992 1993Run the tests under verbose mode so you can see what tests were run, 1994and debug output. 1995 1996=item -torture 1997 1998Run the torture tests as well as the normal set. 1999 2000=item -re=PATTERN 2001 2002Filter the file list so that all the test files run match PATTERN. 2003Note that this form is distinct from the B<-re LIST OF PATTERNS> form below 2004in that it allows the file list to be provided as well. 2005 2006=item -re LIST OF PATTERNS 2007 2008Filter the file list so that all the test files run match 2009/(LIST|OF|PATTERNS)/. Note that with this form the patterns 2010are joined by '|' and you cannot supply a list of files, instead 2011the test files are obtained from the MANIFEST. 2012 2013=back 2014 2015You can run an individual test by a command similar to 2016 2017 ./perl -I../lib patho/to/foo.t 2018 2019except that the harnesses set up some environment variables that may 2020affect the execution of the test : 2021 2022=over 4 2023 2024=item PERL_CORE=1 2025 2026indicates that we're running this test part of the perl core test suite. 2027This is useful for modules that have a dual life on CPAN. 2028 2029=item PERL_DESTRUCT_LEVEL=2 2030 2031is set to 2 if it isn't set already (see L</PERL_DESTRUCT_LEVEL>) 2032 2033=item PERL 2034 2035(used only by F<t/TEST>) if set, overrides the path to the perl executable 2036that should be used to run the tests (the default being F<./perl>). 2037 2038=item PERL_SKIP_TTY_TEST 2039 2040if set, tells to skip the tests that need a terminal. It's actually set 2041automatically by the Makefile, but can also be forced artificially by 2042running 'make test_notty'. 2043 2044=back 2045 2046=head3 Other environment variables that may influence tests 2047 2048=over 4 2049 2050=item PERL_TEST_Net_Ping 2051 2052Setting this variable runs all the Net::Ping modules tests, 2053otherwise some tests that interact with the outside world are skipped. 2054See L<perl58delta>. 2055 2056=item PERL_TEST_NOVREXX 2057 2058Setting this variable skips the vrexx.t tests for OS2::REXX. 2059 2060=item PERL_TEST_NUMCONVERTS 2061 2062This sets a variable in op/numconvert.t. 2063 2064=back 2065 2066See also the documentation for the Test and Test::Harness modules, 2067for more environment variables that affect testing. 2068 2069=head2 Common problems when patching Perl source code 2070 2071Perl source plays by ANSI C89 rules: no C99 (or C++) extensions. In 2072some cases we have to take pre-ANSI requirements into consideration. 2073You don't care about some particular platform having broken Perl? 2074I hear there is still a strong demand for J2EE programmers. 2075 2076=head2 Perl environment problems 2077 2078=over 4 2079 2080=item * 2081 2082Not compiling with threading 2083 2084Compiling with threading (-Duseithreads) completely rewrites 2085the function prototypes of Perl. You better try your changes 2086with that. Related to this is the difference between "Perl_-less" 2087and "Perl_-ly" APIs, for example: 2088 2089 Perl_sv_setiv(aTHX_ ...); 2090 sv_setiv(...); 2091 2092The first one explicitly passes in the context, which is needed for e.g. 2093threaded builds. The second one does that implicitly; do not get them 2094mixed. If you are not passing in a aTHX_, you will need to do a dTHX 2095(or a dVAR) as the first thing in the function. 2096 2097See L<perlguts/"How multiple interpreters and concurrency are supported"> 2098for further discussion about context. 2099 2100=item * 2101 2102Not compiling with -DDEBUGGING 2103 2104The DEBUGGING define exposes more code to the compiler, 2105therefore more ways for things to go wrong. You should try it. 2106 2107=item * 2108 2109Introducing (non-read-only) globals 2110 2111Do not introduce any modifiable globals, truly global or file static. 2112They are bad form and complicate multithreading and other forms of 2113concurrency. The right way is to introduce them as new interpreter 2114variables, see F<intrpvar.h> (at the very end for binary compatibility). 2115 2116Introducing read-only (const) globals is okay, as long as you verify 2117with e.g. C<nm libperl.a|egrep -v ' [TURtr] '> (if your C<nm> has 2118BSD-style output) that the data you added really is read-only. 2119(If it is, it shouldn't show up in the output of that command.) 2120 2121If you want to have static strings, make them constant: 2122 2123 static const char etc[] = "..."; 2124 2125If you want to have arrays of constant strings, note carefully 2126the right combination of C<const>s: 2127 2128 static const char * const yippee[] = 2129 {"hi", "ho", "silver"}; 2130 2131There is a way to completely hide any modifiable globals (they are all 2132moved to heap), the compilation setting C<-DPERL_GLOBAL_STRUCT_PRIVATE>. 2133It is not normally used, but can be used for testing, read more 2134about it in L<perlguts/"Background and PERL_IMPLICIT_CONTEXT">. 2135 2136=item * 2137 2138Not exporting your new function 2139 2140Some platforms (Win32, AIX, VMS, OS/2, to name a few) require any 2141function that is part of the public API (the shared Perl library) 2142to be explicitly marked as exported. See the discussion about 2143F<embed.pl> in L<perlguts>. 2144 2145=item * 2146 2147Exporting your new function 2148 2149The new shiny result of either genuine new functionality or your 2150arduous refactoring is now ready and correctly exported. So what 2151could possibly go wrong? 2152 2153Maybe simply that your function did not need to be exported in the 2154first place. Perl has a long and not so glorious history of exporting 2155functions that it should not have. 2156 2157If the function is used only inside one source code file, make it 2158static. See the discussion about F<embed.pl> in L<perlguts>. 2159 2160If the function is used across several files, but intended only for 2161Perl's internal use (and this should be the common case), do not 2162export it to the public API. See the discussion about F<embed.pl> 2163in L<perlguts>. 2164 2165=back 2166 2167=head2 Portability problems 2168 2169The following are common causes of compilation and/or execution 2170failures, not common to Perl as such. The C FAQ is good bedtime 2171reading. Please test your changes with as many C compilers and 2172platforms as possible -- we will, anyway, and it's nice to save 2173oneself from public embarrassment. 2174 2175If using gcc, you can add the C<-std=c89> option which will hopefully 2176catch most of these unportabilities. (However it might also catch 2177incompatibilities in your system's header files.) 2178 2179Use the Configure C<-Dgccansipedantic> flag to enable the gcc 2180C<-ansi -pedantic> flags which enforce stricter ANSI rules. 2181 2182If using the C<gcc -Wall> note that not all the possible warnings 2183(like C<-Wunitialized>) are given unless you also compile with C<-O>. 2184 2185Note that if using gcc, starting from Perl 5.9.5 the Perl core source 2186code files (the ones at the top level of the source code distribution, 2187but not e.g. the extensions under ext/) are automatically compiled 2188with as many as possible of the C<-std=c89>, C<-ansi>, C<-pedantic>, 2189and a selection of C<-W> flags (see cflags.SH). 2190 2191Also study L<perlport> carefully to avoid any bad assumptions 2192about the operating system, filesystems, and so forth. 2193 2194You may once in a while try a "make microperl" to see whether we 2195can still compile Perl with just the bare minimum of interfaces. 2196(See README.micro.) 2197 2198Do not assume an operating system indicates a certain compiler. 2199 2200=over 4 2201 2202=item * 2203 2204Casting pointers to integers or casting integers to pointers 2205 2206 void castaway(U8* p) 2207 { 2208 IV i = p; 2209 2210or 2211 2212 void castaway(U8* p) 2213 { 2214 IV i = (IV)p; 2215 2216Both are bad, and broken, and unportable. Use the PTR2IV() 2217macro that does it right. (Likewise, there are PTR2UV(), PTR2NV(), 2218INT2PTR(), and NUM2PTR().) 2219 2220=item * 2221 2222Casting between data function pointers and data pointers 2223 2224Technically speaking casting between function pointers and data 2225pointers is unportable and undefined, but practically speaking 2226it seems to work, but you should use the FPTR2DPTR() and DPTR2FPTR() 2227macros. Sometimes you can also play games with unions. 2228 2229=item * 2230 2231Assuming sizeof(int) == sizeof(long) 2232 2233There are platforms where longs are 64 bits, and platforms where ints 2234are 64 bits, and while we are out to shock you, even platforms where 2235shorts are 64 bits. This is all legal according to the C standard. 2236(In other words, "long long" is not a portable way to specify 64 bits, 2237and "long long" is not even guaranteed to be any wider than "long".) 2238 2239Instead, use the definitions IV, UV, IVSIZE, I32SIZE, and so forth. 2240Avoid things like I32 because they are B<not> guaranteed to be 2241I<exactly> 32 bits, they are I<at least> 32 bits, nor are they 2242guaranteed to be B<int> or B<long>. If you really explicitly need 224364-bit variables, use I64 and U64, but only if guarded by HAS_QUAD. 2244 2245=item * 2246 2247Assuming one can dereference any type of pointer for any type of data 2248 2249 char *p = ...; 2250 long pony = *p; /* BAD */ 2251 2252Many platforms, quite rightly so, will give you a core dump instead 2253of a pony if the p happens not be correctly aligned. 2254 2255=item * 2256 2257Lvalue casts 2258 2259 (int)*p = ...; /* BAD */ 2260 2261Simply not portable. Get your lvalue to be of the right type, 2262or maybe use temporary variables, or dirty tricks with unions. 2263 2264=item * 2265 2266Assume B<anything> about structs (especially the ones you 2267don't control, like the ones coming from the system headers) 2268 2269=over 8 2270 2271=item * 2272 2273That a certain field exists in a struct 2274 2275=item * 2276 2277That no other fields exist besides the ones you know of 2278 2279=item * 2280 2281That a field is of certain signedness, sizeof, or type 2282 2283=item * 2284 2285That the fields are in a certain order 2286 2287=over 8 2288 2289=item * 2290 2291While C guarantees the ordering specified in the struct definition, 2292between different platforms the definitions might differ 2293 2294=back 2295 2296=item * 2297 2298That the sizeof(struct) or the alignments are the same everywhere 2299 2300=over 8 2301 2302=item * 2303 2304There might be padding bytes between the fields to align the fields - 2305the bytes can be anything 2306 2307=item * 2308 2309Structs are required to be aligned to the maximum alignment required 2310by the fields - which for native types is for usually equivalent to 2311sizeof() of the field 2312 2313=back 2314 2315=back 2316 2317=item * 2318 2319Assuming the character set is ASCIIish 2320 2321Perl can compile and run under EBCDIC platforms. See L<perlebcdic>. 2322This is transparent for the most part, but because the character sets 2323differ, you shouldn't use numeric (decimal, octal, nor hex) constants 2324to refer to characters. You can safely say 'A', but not 0x41. 2325You can safely say '\n', but not \012. 2326If a character doesn't have a trivial input form, you can 2327create a #define for it in both C<utfebcdic.h> and C<utf8.h>, so that 2328it resolves to different values depending on the character set being used. 2329(There are three different EBCDIC character sets defined in C<utfebcdic.h>, 2330so it might be best to insert the #define three times in that file.) 2331 2332Also, the range 'A' - 'Z' in ASCII is an unbroken sequence of 26 upper case 2333alphabetic characters. That is not true in EBCDIC. Nor for 'a' to 'z'. 2334But '0' - '9' is an unbroken range in both systems. Don't assume anything 2335about other ranges. 2336 2337Many of the comments in the existing code ignore the possibility of EBCDIC, 2338and may be wrong therefore, even if the code works. 2339This is actually a tribute to the successful transparent insertion of being 2340able to handle EBCDIC without having to change pre-existing code. 2341 2342UTF-8 and UTF-EBCDIC are two different encodings used to represent Unicode 2343code points as sequences of bytes. Macros 2344with the same names (but different definitions) 2345in C<utf8.h> and C<utfebcdic.h> 2346are used to allow the calling code to think that there is only one such 2347encoding. 2348This is almost always referred to as C<utf8>, but it means the EBCDIC version 2349as well. Again, comments in the code may well be wrong even if the code itself 2350is right. 2351For example, the concept of C<invariant characters> differs between ASCII and 2352EBCDIC. 2353On ASCII platforms, only characters that do not have the high-order 2354bit set (i.e. whose ordinals are strict ASCII, 0 - 127) 2355are invariant, and the documentation and comments in the code 2356may assume that, 2357often referring to something like, say, C<hibit>. 2358The situation differs and is not so simple on EBCDIC machines, but as long as 2359the code itself uses the C<NATIVE_IS_INVARIANT()> macro appropriately, it 2360works, even if the comments are wrong. 2361 2362=item * 2363 2364Assuming the character set is just ASCII 2365 2366ASCII is a 7 bit encoding, but bytes have 8 bits in them. The 128 extra 2367characters have different meanings depending on the locale. Absent a locale, 2368currently these extra characters are generally considered to be unassigned, 2369and this has presented some problems. 2370This is scheduled to be changed in 5.12 so that these characters will 2371be considered to be Latin-1 (ISO-8859-1). 2372 2373=item * 2374 2375Mixing #define and #ifdef 2376 2377 #define BURGLE(x) ... \ 2378 #ifdef BURGLE_OLD_STYLE /* BAD */ 2379 ... do it the old way ... \ 2380 #else 2381 ... do it the new way ... \ 2382 #endif 2383 2384You cannot portably "stack" cpp directives. For example in the above 2385you need two separate BURGLE() #defines, one for each #ifdef branch. 2386 2387=item * 2388 2389Adding non-comment stuff after #endif or #else 2390 2391 #ifdef SNOSH 2392 ... 2393 #else !SNOSH /* BAD */ 2394 ... 2395 #endif SNOSH /* BAD */ 2396 2397The #endif and #else cannot portably have anything non-comment after 2398them. If you want to document what is going (which is a good idea 2399especially if the branches are long), use (C) comments: 2400 2401 #ifdef SNOSH 2402 ... 2403 #else /* !SNOSH */ 2404 ... 2405 #endif /* SNOSH */ 2406 2407The gcc option C<-Wendif-labels> warns about the bad variant 2408(by default on starting from Perl 5.9.4). 2409 2410=item * 2411 2412Having a comma after the last element of an enum list 2413 2414 enum color { 2415 CERULEAN, 2416 CHARTREUSE, 2417 CINNABAR, /* BAD */ 2418 }; 2419 2420is not portable. Leave out the last comma. 2421 2422Also note that whether enums are implicitly morphable to ints 2423varies between compilers, you might need to (int). 2424 2425=item * 2426 2427Using //-comments 2428 2429 // This function bamfoodles the zorklator. /* BAD */ 2430 2431That is C99 or C++. Perl is C89. Using the //-comments is silently 2432allowed by many C compilers but cranking up the ANSI C89 strictness 2433(which we like to do) causes the compilation to fail. 2434 2435=item * 2436 2437Mixing declarations and code 2438 2439 void zorklator() 2440 { 2441 int n = 3; 2442 set_zorkmids(n); /* BAD */ 2443 int q = 4; 2444 2445That is C99 or C++. Some C compilers allow that, but you shouldn't. 2446 2447The gcc option C<-Wdeclaration-after-statements> scans for such problems 2448(by default on starting from Perl 5.9.4). 2449 2450=item * 2451 2452Introducing variables inside for() 2453 2454 for(int i = ...; ...; ...) { /* BAD */ 2455 2456That is C99 or C++. While it would indeed be awfully nice to have that 2457also in C89, to limit the scope of the loop variable, alas, we cannot. 2458 2459=item * 2460 2461Mixing signed char pointers with unsigned char pointers 2462 2463 int foo(char *s) { ... } 2464 ... 2465 unsigned char *t = ...; /* Or U8* t = ... */ 2466 foo(t); /* BAD */ 2467 2468While this is legal practice, it is certainly dubious, and downright 2469fatal in at least one platform: for example VMS cc considers this a 2470fatal error. One cause for people often making this mistake is that a 2471"naked char" and therefore dereferencing a "naked char pointer" have 2472an undefined signedness: it depends on the compiler and the flags of 2473the compiler and the underlying platform whether the result is signed 2474or unsigned. For this very same reason using a 'char' as an array 2475index is bad. 2476 2477=item * 2478 2479Macros that have string constants and their arguments as substrings of 2480the string constants 2481 2482 #define FOO(n) printf("number = %d\n", n) /* BAD */ 2483 FOO(10); 2484 2485Pre-ANSI semantics for that was equivalent to 2486 2487 printf("10umber = %d\10"); 2488 2489which is probably not what you were expecting. Unfortunately at least 2490one reasonably common and modern C compiler does "real backward 2491compatibility" here, in AIX that is what still happens even though the 2492rest of the AIX compiler is very happily C89. 2493 2494=item * 2495 2496Using printf formats for non-basic C types 2497 2498 IV i = ...; 2499 printf("i = %d\n", i); /* BAD */ 2500 2501While this might by accident work in some platform (where IV happens 2502to be an C<int>), in general it cannot. IV might be something larger. 2503Even worse the situation is with more specific types (defined by Perl's 2504configuration step in F<config.h>): 2505 2506 Uid_t who = ...; 2507 printf("who = %d\n", who); /* BAD */ 2508 2509The problem here is that Uid_t might be not only not C<int>-wide 2510but it might also be unsigned, in which case large uids would be 2511printed as negative values. 2512 2513There is no simple solution to this because of printf()'s limited 2514intelligence, but for many types the right format is available as 2515with either 'f' or '_f' suffix, for example: 2516 2517 IVdf /* IV in decimal */ 2518 UVxf /* UV is hexadecimal */ 2519 2520 printf("i = %"IVdf"\n", i); /* The IVdf is a string constant. */ 2521 2522 Uid_t_f /* Uid_t in decimal */ 2523 2524 printf("who = %"Uid_t_f"\n", who); 2525 2526Or you can try casting to a "wide enough" type: 2527 2528 printf("i = %"IVdf"\n", (IV)something_very_small_and_signed); 2529 2530Also remember that the C<%p> format really does require a void pointer: 2531 2532 U8* p = ...; 2533 printf("p = %p\n", (void*)p); 2534 2535The gcc option C<-Wformat> scans for such problems. 2536 2537=item * 2538 2539Blindly using variadic macros 2540 2541gcc has had them for a while with its own syntax, and C99 brought 2542them with a standardized syntax. Don't use the former, and use 2543the latter only if the HAS_C99_VARIADIC_MACROS is defined. 2544 2545=item * 2546 2547Blindly passing va_list 2548 2549Not all platforms support passing va_list to further varargs (stdarg) 2550functions. The right thing to do is to copy the va_list using the 2551Perl_va_copy() if the NEED_VA_COPY is defined. 2552 2553=item * 2554 2555Using gcc statement expressions 2556 2557 val = ({...;...;...}); /* BAD */ 2558 2559While a nice extension, it's not portable. The Perl code does 2560admittedly use them if available to gain some extra speed 2561(essentially as a funky form of inlining), but you shouldn't. 2562 2563=item * 2564 2565Binding together several statements in a macro 2566 2567Use the macros STMT_START and STMT_END. 2568 2569 STMT_START { 2570 ... 2571 } STMT_END 2572 2573=item * 2574 2575Testing for operating systems or versions when should be testing for features 2576 2577 #ifdef __FOONIX__ /* BAD */ 2578 foo = quux(); 2579 #endif 2580 2581Unless you know with 100% certainty that quux() is only ever available 2582for the "Foonix" operating system B<and> that is available B<and> 2583correctly working for B<all> past, present, B<and> future versions of 2584"Foonix", the above is very wrong. This is more correct (though still 2585not perfect, because the below is a compile-time check): 2586 2587 #ifdef HAS_QUUX 2588 foo = quux(); 2589 #endif 2590 2591How does the HAS_QUUX become defined where it needs to be? Well, if 2592Foonix happens to be UNIXy enough to be able to run the Configure 2593script, and Configure has been taught about detecting and testing 2594quux(), the HAS_QUUX will be correctly defined. In other platforms, 2595the corresponding configuration step will hopefully do the same. 2596 2597In a pinch, if you cannot wait for Configure to be educated, 2598or if you have a good hunch of where quux() might be available, 2599you can temporarily try the following: 2600 2601 #if (defined(__FOONIX__) || defined(__BARNIX__)) 2602 # define HAS_QUUX 2603 #endif 2604 2605 ... 2606 2607 #ifdef HAS_QUUX 2608 foo = quux(); 2609 #endif 2610 2611But in any case, try to keep the features and operating systems separate. 2612 2613=back 2614 2615=head2 Problematic System Interfaces 2616 2617=over 4 2618 2619=item * 2620 2621malloc(0), realloc(0), calloc(0, 0) are non-portable. To be portable 2622allocate at least one byte. (In general you should rarely need to 2623work at this low level, but instead use the various malloc wrappers.) 2624 2625=item * 2626 2627snprintf() - the return type is unportable. Use my_snprintf() instead. 2628 2629=back 2630 2631=head2 Security problems 2632 2633Last but not least, here are various tips for safer coding. 2634 2635=over 4 2636 2637=item * 2638 2639Do not use gets() 2640 2641Or we will publicly ridicule you. Seriously. 2642 2643=item * 2644 2645Do not use strcpy() or strcat() or strncpy() or strncat() 2646 2647Use my_strlcpy() and my_strlcat() instead: they either use the native 2648implementation, or Perl's own implementation (borrowed from the public 2649domain implementation of INN). 2650 2651=item * 2652 2653Do not use sprintf() or vsprintf() 2654 2655If you really want just plain byte strings, use my_snprintf() 2656and my_vsnprintf() instead, which will try to use snprintf() and 2657vsnprintf() if those safer APIs are available. If you want something 2658fancier than a plain byte string, use SVs and Perl_sv_catpvf(). 2659 2660=back 2661 2662=head1 EXTERNAL TOOLS FOR DEBUGGING PERL 2663 2664Sometimes it helps to use external tools while debugging and 2665testing Perl. This section tries to guide you through using 2666some common testing and debugging tools with Perl. This is 2667meant as a guide to interfacing these tools with Perl, not 2668as any kind of guide to the use of the tools themselves. 2669 2670B<NOTE 1>: Running under memory debuggers such as Purify, valgrind, or 2671Third Degree greatly slows down the execution: seconds become minutes, 2672minutes become hours. For example as of Perl 5.8.1, the 2673ext/Encode/t/Unicode.t takes extraordinarily long to complete under 2674e.g. Purify, Third Degree, and valgrind. Under valgrind it takes more 2675than six hours, even on a snappy computer-- the said test must be 2676doing something that is quite unfriendly for memory debuggers. If you 2677don't feel like waiting, that you can simply kill away the perl 2678process. 2679 2680B<NOTE 2>: To minimize the number of memory leak false alarms (see 2681L</PERL_DESTRUCT_LEVEL> for more information), you have to have 2682environment variable PERL_DESTRUCT_LEVEL set to 2. The F<TEST> 2683and harness scripts do that automatically. But if you are running 2684some of the tests manually-- for csh-like shells: 2685 2686 setenv PERL_DESTRUCT_LEVEL 2 2687 2688and for Bourne-type shells: 2689 2690 PERL_DESTRUCT_LEVEL=2 2691 export PERL_DESTRUCT_LEVEL 2692 2693or in UNIXy environments you can also use the C<env> command: 2694 2695 env PERL_DESTRUCT_LEVEL=2 valgrind ./perl -Ilib ... 2696 2697B<NOTE 3>: There are known memory leaks when there are compile-time 2698errors within eval or require, seeing C<S_doeval> in the call stack 2699is a good sign of these. Fixing these leaks is non-trivial, 2700unfortunately, but they must be fixed eventually. 2701 2702B<NOTE 4>: L<DynaLoader> will not clean up after itself completely 2703unless Perl is built with the Configure option 2704C<-Accflags=-DDL_UNLOAD_ALL_AT_EXIT>. 2705 2706=head2 Rational Software's Purify 2707 2708Purify is a commercial tool that is helpful in identifying 2709memory overruns, wild pointers, memory leaks and other such 2710badness. Perl must be compiled in a specific way for 2711optimal testing with Purify. Purify is available under 2712Windows NT, Solaris, HP-UX, SGI, and Siemens Unix. 2713 2714=head2 Purify on Unix 2715 2716On Unix, Purify creates a new Perl binary. To get the most 2717benefit out of Purify, you should create the perl to Purify 2718using: 2719 2720 sh Configure -Accflags=-DPURIFY -Doptimize='-g' \ 2721 -Uusemymalloc -Dusemultiplicity 2722 2723where these arguments mean: 2724 2725=over 4 2726 2727=item -Accflags=-DPURIFY 2728 2729Disables Perl's arena memory allocation functions, as well as 2730forcing use of memory allocation functions derived from the 2731system malloc. 2732 2733=item -Doptimize='-g' 2734 2735Adds debugging information so that you see the exact source 2736statements where the problem occurs. Without this flag, all 2737you will see is the source filename of where the error occurred. 2738 2739=item -Uusemymalloc 2740 2741Disable Perl's malloc so that Purify can more closely monitor 2742allocations and leaks. Using Perl's malloc will make Purify 2743report most leaks in the "potential" leaks category. 2744 2745=item -Dusemultiplicity 2746 2747Enabling the multiplicity option allows perl to clean up 2748thoroughly when the interpreter shuts down, which reduces the 2749number of bogus leak reports from Purify. 2750 2751=back 2752 2753Once you've compiled a perl suitable for Purify'ing, then you 2754can just: 2755 2756 make pureperl 2757 2758which creates a binary named 'pureperl' that has been Purify'ed. 2759This binary is used in place of the standard 'perl' binary 2760when you want to debug Perl memory problems. 2761 2762As an example, to show any memory leaks produced during the 2763standard Perl testset you would create and run the Purify'ed 2764perl as: 2765 2766 make pureperl 2767 cd t 2768 ../pureperl -I../lib harness 2769 2770which would run Perl on test.pl and report any memory problems. 2771 2772Purify outputs messages in "Viewer" windows by default. If 2773you don't have a windowing environment or if you simply 2774want the Purify output to unobtrusively go to a log file 2775instead of to the interactive window, use these following 2776options to output to the log file "perl.log": 2777 2778 setenv PURIFYOPTIONS "-chain-length=25 -windows=no \ 2779 -log-file=perl.log -append-logfile=yes" 2780 2781If you plan to use the "Viewer" windows, then you only need this option: 2782 2783 setenv PURIFYOPTIONS "-chain-length=25" 2784 2785In Bourne-type shells: 2786 2787 PURIFYOPTIONS="..." 2788 export PURIFYOPTIONS 2789 2790or if you have the "env" utility: 2791 2792 env PURIFYOPTIONS="..." ../pureperl ... 2793 2794=head2 Purify on NT 2795 2796Purify on Windows NT instruments the Perl binary 'perl.exe' 2797on the fly. There are several options in the makefile you 2798should change to get the most use out of Purify: 2799 2800=over 4 2801 2802=item DEFINES 2803 2804You should add -DPURIFY to the DEFINES line so the DEFINES 2805line looks something like: 2806 2807 DEFINES = -DWIN32 -D_CONSOLE -DNO_STRICT $(CRYPT_FLAG) -DPURIFY=1 2808 2809to disable Perl's arena memory allocation functions, as 2810well as to force use of memory allocation functions derived 2811from the system malloc. 2812 2813=item USE_MULTI = define 2814 2815Enabling the multiplicity option allows perl to clean up 2816thoroughly when the interpreter shuts down, which reduces the 2817number of bogus leak reports from Purify. 2818 2819=item #PERL_MALLOC = define 2820 2821Disable Perl's malloc so that Purify can more closely monitor 2822allocations and leaks. Using Perl's malloc will make Purify 2823report most leaks in the "potential" leaks category. 2824 2825=item CFG = Debug 2826 2827Adds debugging information so that you see the exact source 2828statements where the problem occurs. Without this flag, all 2829you will see is the source filename of where the error occurred. 2830 2831=back 2832 2833As an example, to show any memory leaks produced during the 2834standard Perl testset you would create and run Purify as: 2835 2836 cd win32 2837 make 2838 cd ../t 2839 purify ../perl -I../lib harness 2840 2841which would instrument Perl in memory, run Perl on test.pl, 2842then finally report any memory problems. 2843 2844=head2 valgrind 2845 2846The excellent valgrind tool can be used to find out both memory leaks 2847and illegal memory accesses. As of version 3.3.0, Valgrind only 2848supports Linux on x86, x86-64 and PowerPC. The special "test.valgrind" 2849target can be used to run the tests under valgrind. Found errors 2850and memory leaks are logged in files named F<testfile.valgrind>. 2851 2852Valgrind also provides a cachegrind tool, invoked on perl as: 2853 2854 VG_OPTS=--tool=cachegrind make test.valgrind 2855 2856As system libraries (most notably glibc) are also triggering errors, 2857valgrind allows to suppress such errors using suppression files. The 2858default suppression file that comes with valgrind already catches a lot 2859of them. Some additional suppressions are defined in F<t/perl.supp>. 2860 2861To get valgrind and for more information see 2862 2863 http://developer.kde.org/~sewardj/ 2864 2865=head2 Compaq's/Digital's/HP's Third Degree 2866 2867Third Degree is a tool for memory leak detection and memory access checks. 2868It is one of the many tools in the ATOM toolkit. The toolkit is only 2869available on Tru64 (formerly known as Digital UNIX formerly known as 2870DEC OSF/1). 2871 2872When building Perl, you must first run Configure with -Doptimize=-g 2873and -Uusemymalloc flags, after that you can use the make targets 2874"perl.third" and "test.third". (What is required is that Perl must be 2875compiled using the C<-g> flag, you may need to re-Configure.) 2876 2877The short story is that with "atom" you can instrument the Perl 2878executable to create a new executable called F<perl.third>. When the 2879instrumented executable is run, it creates a log of dubious memory 2880traffic in file called F<perl.3log>. See the manual pages of atom and 2881third for more information. The most extensive Third Degree 2882documentation is available in the Compaq "Tru64 UNIX Programmer's 2883Guide", chapter "Debugging Programs with Third Degree". 2884 2885The "test.third" leaves a lot of files named F<foo_bar.3log> in the t/ 2886subdirectory. There is a problem with these files: Third Degree is so 2887effective that it finds problems also in the system libraries. 2888Therefore you should used the Porting/thirdclean script to cleanup 2889the F<*.3log> files. 2890 2891There are also leaks that for given certain definition of a leak, 2892aren't. See L</PERL_DESTRUCT_LEVEL> for more information. 2893 2894=head2 PERL_DESTRUCT_LEVEL 2895 2896If you want to run any of the tests yourself manually using e.g. 2897valgrind, or the pureperl or perl.third executables, please note that 2898by default perl B<does not> explicitly cleanup all the memory it has 2899allocated (such as global memory arenas) but instead lets the exit() 2900of the whole program "take care" of such allocations, also known as 2901"global destruction of objects". 2902 2903There is a way to tell perl to do complete cleanup: set the 2904environment variable PERL_DESTRUCT_LEVEL to a non-zero value. 2905The t/TEST wrapper does set this to 2, and this is what you 2906need to do too, if you don't want to see the "global leaks": 2907For example, for "third-degreed" Perl: 2908 2909 env PERL_DESTRUCT_LEVEL=2 ./perl.third -Ilib t/foo/bar.t 2910 2911(Note: the mod_perl apache module uses also this environment variable 2912for its own purposes and extended its semantics. Refer to the mod_perl 2913documentation for more information. Also, spawned threads do the 2914equivalent of setting this variable to the value 1.) 2915 2916If, at the end of a run you get the message I<N scalars leaked>, you can 2917recompile with C<-DDEBUG_LEAKING_SCALARS>, which will cause the addresses 2918of all those leaked SVs to be dumped along with details as to where each 2919SV was originally allocated. This information is also displayed by 2920Devel::Peek. Note that the extra details recorded with each SV increases 2921memory usage, so it shouldn't be used in production environments. It also 2922converts C<new_SV()> from a macro into a real function, so you can use 2923your favourite debugger to discover where those pesky SVs were allocated. 2924 2925If you see that you're leaking memory at runtime, but neither valgrind 2926nor C<-DDEBUG_LEAKING_SCALARS> will find anything, you're probably 2927leaking SVs that are still reachable and will be properly cleaned up 2928during destruction of the interpreter. In such cases, using the C<-Dm> 2929switch can point you to the source of the leak. If the executable was 2930built with C<-DDEBUG_LEAKING_SCALARS>, C<-Dm> will output SV allocations 2931in addition to memory allocations. Each SV allocation has a distinct 2932serial number that will be written on creation and destruction of the SV. 2933So if you're executing the leaking code in a loop, you need to look for 2934SVs that are created, but never destroyed between each cycle. If such an 2935SV is found, set a conditional breakpoint within C<new_SV()> and make it 2936break only when C<PL_sv_serial> is equal to the serial number of the 2937leaking SV. Then you will catch the interpreter in exactly the state 2938where the leaking SV is allocated, which is sufficient in many cases to 2939find the source of the leak. 2940 2941As C<-Dm> is using the PerlIO layer for output, it will by itself 2942allocate quite a bunch of SVs, which are hidden to avoid recursion. 2943You can bypass the PerlIO layer if you use the SV logging provided 2944by C<-DPERL_MEM_LOG> instead. 2945 2946=head2 PERL_MEM_LOG 2947 2948If compiled with C<-DPERL_MEM_LOG>, all Newx() and Renew() allocations 2949and Safefree() in the Perl core go through logging functions, which is 2950handy for breakpoint setting. If also compiled with C<-DPERL_MEM_LOG_STDERR>, 2951the allocations and frees are logged to STDERR (or more precisely, to the 2952file descriptor 2) in these logging functions, with the calling source code 2953file and line number (and C function name, if supported by the C compiler). 2954 2955This logging is somewhat similar to C<-Dm> but independent of C<-DDEBUGGING>, 2956and at a higher level (the C<-Dm> is directly at the point of C<malloc()>, 2957while the C<PERL_MEM_LOG> is at the level of C<New()>). 2958 2959In addition to memory allocations, SV allocations will be logged, just as 2960with C<-Dm>. However, since the logging doesn't use PerlIO, all SV allocations 2961are logged and no extra SV allocations are introduced by enabling the logging. 2962If compiled with C<-DDEBUG_LEAKING_SCALARS>, the serial number for each SV 2963allocation is also logged. 2964 2965You can control the logging from your environment if you compile with 2966C<-DPERL_MEM_LOG_ENV>. Then you need to explicitly set C<PERL_MEM_LOG> and/or 2967C<PERL_SV_LOG> to a non-zero value to enable logging of memory and/or SV 2968allocations. 2969 2970=head2 Profiling 2971 2972Depending on your platform there are various of profiling Perl. 2973 2974There are two commonly used techniques of profiling executables: 2975I<statistical time-sampling> and I<basic-block counting>. 2976 2977The first method takes periodically samples of the CPU program 2978counter, and since the program counter can be correlated with the code 2979generated for functions, we get a statistical view of in which 2980functions the program is spending its time. The caveats are that very 2981small/fast functions have lower probability of showing up in the 2982profile, and that periodically interrupting the program (this is 2983usually done rather frequently, in the scale of milliseconds) imposes 2984an additional overhead that may skew the results. The first problem 2985can be alleviated by running the code for longer (in general this is a 2986good idea for profiling), the second problem is usually kept in guard 2987by the profiling tools themselves. 2988 2989The second method divides up the generated code into I<basic blocks>. 2990Basic blocks are sections of code that are entered only in the 2991beginning and exited only at the end. For example, a conditional jump 2992starts a basic block. Basic block profiling usually works by 2993I<instrumenting> the code by adding I<enter basic block #nnnn> 2994book-keeping code to the generated code. During the execution of the 2995code the basic block counters are then updated appropriately. The 2996caveat is that the added extra code can skew the results: again, the 2997profiling tools usually try to factor their own effects out of the 2998results. 2999 3000=head2 Gprof Profiling 3001 3002gprof is a profiling tool available in many UNIX platforms, 3003it uses F<statistical time-sampling>. 3004 3005You can build a profiled version of perl called "perl.gprof" by 3006invoking the make target "perl.gprof" (What is required is that Perl 3007must be compiled using the C<-pg> flag, you may need to re-Configure). 3008Running the profiled version of Perl will create an output file called 3009F<gmon.out> is created which contains the profiling data collected 3010during the execution. 3011 3012The gprof tool can then display the collected data in various ways. 3013Usually gprof understands the following options: 3014 3015=over 4 3016 3017=item -a 3018 3019Suppress statically defined functions from the profile. 3020 3021=item -b 3022 3023Suppress the verbose descriptions in the profile. 3024 3025=item -e routine 3026 3027Exclude the given routine and its descendants from the profile. 3028 3029=item -f routine 3030 3031Display only the given routine and its descendants in the profile. 3032 3033=item -s 3034 3035Generate a summary file called F<gmon.sum> which then may be given 3036to subsequent gprof runs to accumulate data over several runs. 3037 3038=item -z 3039 3040Display routines that have zero usage. 3041 3042=back 3043 3044For more detailed explanation of the available commands and output 3045formats, see your own local documentation of gprof. 3046 3047quick hint: 3048 3049 $ sh Configure -des -Dusedevel -Doptimize='-g' -Accflags='-pg' -Aldflags='-pg' && make 3050 $ ./perl someprog # creates gmon.out in current directory 3051 $ gprof perl > out 3052 $ view out 3053 3054=head2 GCC gcov Profiling 3055 3056Starting from GCC 3.0 I<basic block profiling> is officially available 3057for the GNU CC. 3058 3059You can build a profiled version of perl called F<perl.gcov> by 3060invoking the make target "perl.gcov" (what is required that Perl must 3061be compiled using gcc with the flags C<-fprofile-arcs 3062-ftest-coverage>, you may need to re-Configure). 3063 3064Running the profiled version of Perl will cause profile output to be 3065generated. For each source file an accompanying ".da" file will be 3066created. 3067 3068To display the results you use the "gcov" utility (which should 3069be installed if you have gcc 3.0 or newer installed). F<gcov> is 3070run on source code files, like this 3071 3072 gcov sv.c 3073 3074which will cause F<sv.c.gcov> to be created. The F<.gcov> files 3075contain the source code annotated with relative frequencies of 3076execution indicated by "#" markers. 3077 3078Useful options of F<gcov> include C<-b> which will summarise the 3079basic block, branch, and function call coverage, and C<-c> which 3080instead of relative frequencies will use the actual counts. For 3081more information on the use of F<gcov> and basic block profiling 3082with gcc, see the latest GNU CC manual, as of GCC 3.0 see 3083 3084 http://gcc.gnu.org/onlinedocs/gcc-3.0/gcc.html 3085 3086and its section titled "8. gcov: a Test Coverage Program" 3087 3088 http://gcc.gnu.org/onlinedocs/gcc-3.0/gcc_8.html#SEC132 3089 3090quick hint: 3091 3092 $ sh Configure -des -Doptimize='-g' -Accflags='-fprofile-arcs -ftest-coverage' \ 3093 -Aldflags='-fprofile-arcs -ftest-coverage' && make perl.gcov 3094 $ rm -f regexec.c.gcov regexec.gcda 3095 $ ./perl.gcov 3096 $ gcov regexec.c 3097 $ view regexec.c.gcov 3098 3099=head2 Pixie Profiling 3100 3101Pixie is a profiling tool available on IRIX and Tru64 (aka Digital 3102UNIX aka DEC OSF/1) platforms. Pixie does its profiling using 3103I<basic-block counting>. 3104 3105You can build a profiled version of perl called F<perl.pixie> by 3106invoking the make target "perl.pixie" (what is required is that Perl 3107must be compiled using the C<-g> flag, you may need to re-Configure). 3108 3109In Tru64 a file called F<perl.Addrs> will also be silently created, 3110this file contains the addresses of the basic blocks. Running the 3111profiled version of Perl will create a new file called "perl.Counts" 3112which contains the counts for the basic block for that particular 3113program execution. 3114 3115To display the results you use the F<prof> utility. The exact 3116incantation depends on your operating system, "prof perl.Counts" in 3117IRIX, and "prof -pixie -all -L. perl" in Tru64. 3118 3119In IRIX the following prof options are available: 3120 3121=over 4 3122 3123=item -h 3124 3125Reports the most heavily used lines in descending order of use. 3126Useful for finding the hotspot lines. 3127 3128=item -l 3129 3130Groups lines by procedure, with procedures sorted in descending order of use. 3131Within a procedure, lines are listed in source order. 3132Useful for finding the hotspots of procedures. 3133 3134=back 3135 3136In Tru64 the following options are available: 3137 3138=over 4 3139 3140=item -p[rocedures] 3141 3142Procedures sorted in descending order by the number of cycles executed 3143in each procedure. Useful for finding the hotspot procedures. 3144(This is the default option.) 3145 3146=item -h[eavy] 3147 3148Lines sorted in descending order by the number of cycles executed in 3149each line. Useful for finding the hotspot lines. 3150 3151=item -i[nvocations] 3152 3153The called procedures are sorted in descending order by number of calls 3154made to the procedures. Useful for finding the most used procedures. 3155 3156=item -l[ines] 3157 3158Grouped by procedure, sorted by cycles executed per procedure. 3159Useful for finding the hotspots of procedures. 3160 3161=item -testcoverage 3162 3163The compiler emitted code for these lines, but the code was unexecuted. 3164 3165=item -z[ero] 3166 3167Unexecuted procedures. 3168 3169=back 3170 3171For further information, see your system's manual pages for pixie and prof. 3172 3173=head2 Miscellaneous tricks 3174 3175=over 4 3176 3177=item * 3178 3179Those debugging perl with the DDD frontend over gdb may find the 3180following useful: 3181 3182You can extend the data conversion shortcuts menu, so for example you 3183can display an SV's IV value with one click, without doing any typing. 3184To do that simply edit ~/.ddd/init file and add after: 3185 3186 ! Display shortcuts. 3187 Ddd*gdbDisplayShortcuts: \ 3188 /t () // Convert to Bin\n\ 3189 /d () // Convert to Dec\n\ 3190 /x () // Convert to Hex\n\ 3191 /o () // Convert to Oct(\n\ 3192 3193the following two lines: 3194 3195 ((XPV*) (())->sv_any )->xpv_pv // 2pvx\n\ 3196 ((XPVIV*) (())->sv_any )->xiv_iv // 2ivx 3197 3198so now you can do ivx and pvx lookups or you can plug there the 3199sv_peek "conversion": 3200 3201 Perl_sv_peek(my_perl, (SV*)()) // sv_peek 3202 3203(The my_perl is for threaded builds.) 3204Just remember that every line, but the last one, should end with \n\ 3205 3206Alternatively edit the init file interactively via: 32073rd mouse button -> New Display -> Edit Menu 3208 3209Note: you can define up to 20 conversion shortcuts in the gdb 3210section. 3211 3212=item * 3213 3214If you see in a debugger a memory area mysteriously full of 0xABABABAB 3215or 0xEFEFEFEF, you may be seeing the effect of the Poison() macros, 3216see L<perlclib>. 3217 3218=item * 3219 3220Under ithreads the optree is read only. If you want to enforce this, to check 3221for write accesses from buggy code, compile with C<-DPL_OP_SLAB_ALLOC> to 3222enable the OP slab allocator and C<-DPERL_DEBUG_READONLY_OPS> to enable code 3223that allocates op memory via C<mmap>, and sets it read-only at run time. 3224Any write access to an op results in a C<SIGBUS> and abort. 3225 3226This code is intended for development only, and may not be portable even to 3227all Unix variants. Also, it is an 80% solution, in that it isn't able to make 3228all ops read only. Specifically it 3229 3230=over 3231 3232=item 1 3233 3234Only sets read-only on all slabs of ops at C<CHECK> time, hence ops allocated 3235later via C<require> or C<eval> will be re-write 3236 3237=item 2 3238 3239Turns an entire slab of ops read-write if the refcount of any op in the slab 3240needs to be decreased. 3241 3242=item 3 3243 3244Turns an entire slab of ops read-write if any op from the slab is freed. 3245 3246=back 3247 3248It's not possible to turn the slabs to read-only after an action requiring 3249read-write access, as either can happen during op tree building time, so 3250there may still be legitimate write access. 3251 3252However, as an 80% solution it is still effective, as currently it catches 3253a write access during the generation of F<Config.pm>, which means that we 3254can't yet build F<perl> with this enabled. 3255 3256=back 3257 3258 3259=head1 CONCLUSION 3260 3261We've had a brief look around the Perl source, how to maintain quality 3262of the source code, an overview of the stages F<perl> goes through 3263when it's running your code, how to use debuggers to poke at the Perl 3264guts, and finally how to analyse the execution of Perl. We took a very 3265simple problem and demonstrated how to solve it fully - with 3266documentation, regression tests, and finally a patch for submission to 3267p5p. Finally, we talked about how to use external tools to debug and 3268test Perl. 3269 3270I'd now suggest you read over those references again, and then, as soon 3271as possible, get your hands dirty. The best way to learn is by doing, 3272so: 3273 3274=over 3 3275 3276=item * 3277 3278Subscribe to perl5-porters, follow the patches and try and understand 3279them; don't be afraid to ask if there's a portion you're not clear on - 3280who knows, you may unearth a bug in the patch... 3281 3282=item * 3283 3284Keep up to date with the bleeding edge Perl distributions and get 3285familiar with the changes. Try and get an idea of what areas people are 3286working on and the changes they're making. 3287 3288=item * 3289 3290Do read the README associated with your operating system, e.g. README.aix 3291on the IBM AIX OS. Don't hesitate to supply patches to that README if 3292you find anything missing or changed over a new OS release. 3293 3294=item * 3295 3296Find an area of Perl that seems interesting to you, and see if you can 3297work out how it works. Scan through the source, and step over it in the 3298debugger. Play, poke, investigate, fiddle! You'll probably get to 3299understand not just your chosen area but a much wider range of F<perl>'s 3300activity as well, and probably sooner than you'd think. 3301 3302=back 3303 3304=over 3 3305 3306=item I<The Road goes ever on and on, down from the door where it began.> 3307 3308=back 3309 3310If you can do these things, you've started on the long road to Perl porting. 3311Thanks for wanting to help make Perl better - and happy hacking! 3312 3313=head2 Metaphoric Quotations 3314 3315If you recognized the quote about the Road above, you're in luck. 3316 3317Most software projects begin each file with a literal description of each 3318file's purpose. Perl instead begins each with a literary allusion to that 3319file's purpose. 3320 3321Like chapters in many books, all top-level Perl source files (along with a 3322few others here and there) begin with an epigramic inscription that alludes, 3323indirectly and metaphorically, to the material you're about to read. 3324 3325Quotations are taken from writings of J.R.R Tolkien pertaining to his 3326Legendarium, almost always from I<The Lord of the Rings>. Chapters and 3327page numbers are given using the following editions: 3328 3329=over 4 3330 3331=item * 3332 3333I<The Hobbit>, by J.R.R. Tolkien. The hardcover, 70th-anniversary 3334edition of 2007 was used, published in the UK by Harper Collins Publishers 3335and in the US by the Houghton Mifflin Company. 3336 3337=item * 3338 3339I<The Lord of the Rings>, by J.R.R. Tolkien. The hardcover, 334050th-anniversary edition of 2004 was used, published in the UK by Harper 3341Collins Publishers and in the US by the Houghton Mifflin Company. 3342 3343=item * 3344 3345I<The Lays of Beleriand>, by J.R.R. Tolkien and published posthumously by his 3346son and literary executor, C.J.R. Tolkien, being the 3rd of the 12 volumes 3347in Christopher's mammoth I<History of Middle Earth>. Page numbers derive 3348from the hardcover edition, first published in 1983 by George Allen & 3349Unwin; no page numbers changed for the special 3-volume omnibus edition of 33502002 or the various trade-paper editions, all again now by Harper Collins 3351or Houghton Mifflin. 3352 3353=back 3354 3355Other JRRT books fair game for quotes would thus include I<The Adventures of 3356Tom Bombadil>, I<The Silmarillion>, I<Unfinished Tales>, and I<The Tale of 3357the Children of Hurin>, all but the first posthumously assembled by CJRT. 3358But I<The Lord of the Rings> itself is perfectly fine and probably best to 3359quote from, provided you can find a suitable quote there. 3360 3361So if you were to supply a new, complete, top-level source file to add to 3362Perl, you should conform to this peculiar practice by yourself selecting an 3363appropriate quotation from Tolkien, retaining the original spelling and 3364punctuation and using the same format the rest of the quotes are in. 3365Indirect and oblique is just fine; remember, it's a metaphor, so being meta 3366is, after all, what it's for. 3367 3368=head1 AUTHOR 3369 3370This document was written by Nathan Torkington, and is maintained by 3371the perl5-porters mailing list. 3372 3373=head1 SEE ALSO 3374 3375L<perlrepository> 3376