1 #ifndef OSMIUM_AREA_PROBLEM_REPORTER_HPP 2 #define OSMIUM_AREA_PROBLEM_REPORTER_HPP 3 4 /* 5 6 This file is part of Osmium (https://osmcode.org/libosmium). 7 8 Copyright 2013-2021 Jochen Topf <jochen@topf.org> and others (see README). 9 10 Boost Software License - Version 1.0 - August 17th, 2003 11 12 Permission is hereby granted, free of charge, to any person or organization 13 obtaining a copy of the software and accompanying documentation covered by 14 this license (the "Software") to use, reproduce, display, distribute, 15 execute, and transmit the Software, and to prepare derivative works of the 16 Software, and to permit third-parties to whom the Software is furnished to 17 do so, all subject to the following: 18 19 The copyright notices in the Software and this entire statement, including 20 the above license grant, this restriction and the following disclaimer, 21 must be included in all copies of the Software, in whole or in part, and 22 all derivative works of the Software, unless such copies or derivative 23 works are solely in the form of machine-executable object code generated by 24 a source language processor. 25 26 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR 27 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, 28 FITNESS FOR A PARTICULAR PURPOSE, TITLE AND NON-INFRINGEMENT. IN NO EVENT 29 SHALL THE COPYRIGHT HOLDERS OR ANYONE DISTRIBUTING THE SOFTWARE BE LIABLE 30 FOR ANY DAMAGES OR OTHER LIABILITY, WHETHER IN CONTRACT, TORT OR OTHERWISE, 31 ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER 32 DEALINGS IN THE SOFTWARE. 33 34 */ 35 36 #include <osmium/osm/item_type.hpp> 37 #include <osmium/osm/location.hpp> 38 #include <osmium/osm/types.hpp> 39 40 #include <cstddef> 41 42 namespace osmium { 43 44 class NodeRef; 45 class Way; 46 47 namespace area { 48 49 /** 50 * When assembling a multipolygon/area from a multipolygon relation 51 * or a closed way several problems can be detected. This includes 52 * intersections between lines, wrong role attributes on relation 53 * members etc. These problems are reported by the area::Assembler 54 * class to the ProblemReporter class or one of its child classes. 55 * 56 * This is the parent class which does nothing with the reports. 57 * Child classes are expected to implement different ways of 58 * reporting the problems. 59 */ 60 class ProblemReporter { 61 62 protected: 63 64 // Type of object we are currently working on 65 osmium::item_type m_object_type = osmium::item_type::undefined; 66 67 // ID of the relation/way we are currently working on 68 osmium::object_id_type m_object_id = 0; 69 70 // Number of nodes in the area 71 size_t m_nodes = 0; 72 73 public: 74 75 ProblemReporter() = default; 76 77 ProblemReporter(const ProblemReporter&) = default; 78 ProblemReporter& operator=(const ProblemReporter&) = default; 79 80 ProblemReporter(ProblemReporter&&) noexcept = default; 81 ProblemReporter& operator=(ProblemReporter&&) noexcept = default; 82 83 virtual ~ProblemReporter() = default; 84 85 /** 86 * Set the object the next problem reports will be on. 87 * 88 * @param object_type The type of the object. 89 * @param object_id The ID of the object. 90 */ set_object(osmium::item_type object_type,osmium::object_id_type object_id)91 void set_object(osmium::item_type object_type, osmium::object_id_type object_id) noexcept { 92 m_object_type = object_type; 93 m_object_id = object_id; 94 } 95 object_id() const96 osmium::object_id_type object_id() const noexcept { 97 return m_object_id; 98 } 99 set_nodes(size_t nodes)100 void set_nodes(size_t nodes) noexcept { 101 m_nodes = nodes; 102 } 103 104 // Disable "unused-parameter" warning, so that the compiler will not complain. 105 // We can't remove the parameter names, because then doxygen will complain. 106 #pragma GCC diagnostic push 107 #pragma GCC diagnostic ignored "-Wunused-parameter" 108 109 /** 110 * Report a duplicate node, ie. two nodes with the same location. 111 * 112 * @param node_id1 ID of the first node. 113 * @param node_id2 ID of the second node. 114 * @param location Location of both nodes. 115 */ report_duplicate_node(osmium::object_id_type node_id1,osmium::object_id_type node_id2,osmium::Location location)116 virtual void report_duplicate_node(osmium::object_id_type node_id1, osmium::object_id_type node_id2, osmium::Location location) { 117 } 118 119 /** 120 * Report a node/location where rings touch. This is often wrong, 121 * but not necessarily so. 122 * 123 * @param node_id ID of the node. 124 * @param location Location of the node. 125 */ report_touching_ring(osmium::object_id_type node_id,osmium::Location location)126 virtual void report_touching_ring(osmium::object_id_type node_id, osmium::Location location) { 127 } 128 129 /** 130 * Report an intersection between two segments. 131 * 132 * @param way1_id ID of the first involved way. 133 * @param way1_seg_start Location where the segment of the first way with the intersection starts 134 * @param way1_seg_end Location where the segment of the first way with the intersection ends 135 * @param way2_id ID of the second involved way. 136 * @param way2_seg_start Location where the segment of the second way with the intersection starts 137 * @param way2_seg_end Location where the segment of the second way with the intersection ends 138 * @param intersection Location of the intersection. This might be slightly off the correct location due to rounding. 139 */ report_intersection(osmium::object_id_type way1_id,osmium::Location way1_seg_start,osmium::Location way1_seg_end,osmium::object_id_type way2_id,osmium::Location way2_seg_start,osmium::Location way2_seg_end,osmium::Location intersection)140 virtual void report_intersection(osmium::object_id_type way1_id, osmium::Location way1_seg_start, osmium::Location way1_seg_end, 141 osmium::object_id_type way2_id, osmium::Location way2_seg_start, osmium::Location way2_seg_end, osmium::Location intersection) { 142 } 143 144 /** 145 * Report a duplicate segments. Two or more segments are directly 146 * on top of each other. This can be a problem, if there is a 147 * spike for instance, or it could be okay, if there are touching 148 * inner rings. 149 * 150 * @param nr1 NodeRef of one end of the segment. 151 * @param nr2 NodeRef of the other end of the segment. 152 */ report_duplicate_segment(const osmium::NodeRef & nr1,const osmium::NodeRef & nr2)153 virtual void report_duplicate_segment(const osmium::NodeRef& nr1, const osmium::NodeRef& nr2) { 154 } 155 156 /** 157 * Report a duplicate segments. Two or more segments are directly 158 * on top of each other. This can be a problem, if there is a 159 * spike for instance, or it could be okay, if there are touching 160 * inner rings. 161 * 162 * @param nr1 NodeRef of one end of the segment. 163 * @param nr2 NodeRef of the other end of the segment. 164 */ report_overlapping_segment(const osmium::NodeRef & nr1,const osmium::NodeRef & nr2)165 virtual void report_overlapping_segment(const osmium::NodeRef& nr1, const osmium::NodeRef& nr2) { 166 } 167 168 /** 169 * Report an open ring. 170 * 171 * @param nr NodeRef of one end of the ring. 172 * @param way Optional pointer to way the end node is in. 173 */ report_ring_not_closed(const osmium::NodeRef & nr,const osmium::Way * way)174 virtual void report_ring_not_closed(const osmium::NodeRef& nr, const osmium::Way* way) { 175 } 176 177 /** 178 * Report a segment that should have role "outer", but has a different role. 179 * 180 * @param way_id ID of the way this segment is in. 181 * @param seg_start Start of the segment with the wrong role. 182 * @param seg_end End of the segment with the wrong role. 183 */ report_role_should_be_outer(osmium::object_id_type way_id,osmium::Location seg_start,osmium::Location seg_end)184 virtual void report_role_should_be_outer(osmium::object_id_type way_id, osmium::Location seg_start, osmium::Location seg_end) { 185 } 186 187 /** 188 * Report a segment that should have role "inner", but has a different role. 189 * 190 * @param way_id ID of the way this segment is in. 191 * @param seg_start Start of the segment with the wrong role. 192 * @param seg_end End of the segment with the wrong role. 193 */ report_role_should_be_inner(osmium::object_id_type way_id,osmium::Location seg_start,osmium::Location seg_end)194 virtual void report_role_should_be_inner(osmium::object_id_type way_id, osmium::Location seg_start, osmium::Location seg_end) { 195 } 196 197 /** 198 * Report a way that is in multiple rings. 199 * 200 * @param way The way. 201 */ report_way_in_multiple_rings(const osmium::Way & way)202 virtual void report_way_in_multiple_rings(const osmium::Way& way) { 203 } 204 205 /** 206 * Report a way with role inner that has the same tags as the 207 * relation or outer ways. 208 * 209 * @param way The way. 210 */ report_inner_with_same_tags(const osmium::Way & way)211 virtual void report_inner_with_same_tags(const osmium::Way& way) { 212 } 213 214 /** 215 * Report an invalid location in a way. 216 * 217 * @param way_id ID of the way the node is in. 218 * @param node_id ID of the node with the invalid location. 219 */ report_invalid_location(osmium::object_id_type way_id,osmium::object_id_type node_id)220 virtual void report_invalid_location(osmium::object_id_type way_id, osmium::object_id_type node_id) { 221 } 222 223 /** 224 * Report a way that is more than once in a relation. 225 * 226 * @param way The way 227 */ report_duplicate_way(const osmium::Way & way)228 virtual void report_duplicate_way(const osmium::Way& way) { 229 } 230 231 /** 232 * In addition to reporting specific problems, this is used to 233 * report all ways belonging to areas having problems. 234 * 235 * @param way The way 236 */ report_way(const osmium::Way & way)237 virtual void report_way(const osmium::Way& way) { 238 } 239 240 #pragma GCC diagnostic pop 241 242 }; // class ProblemReporter 243 244 } // namespace area 245 246 } // namespace osmium 247 248 #endif // OSMIUM_AREA_PROBLEM_REPORTER_HPP 249