1dnl TP_COMPILER_WARNINGS(VARIABLE, WERROR_BY_DEFAULT, DESIRABLE, UNDESIRABLE)
2dnl $1 (VARIABLE): the variable to put flags into
3dnl $2 (WERROR_BY_DEFAULT): a command returning true if -Werror should be the
4dnl     default
5dnl $3 (DESIRABLE): warning flags we want (e.g. all extra shadow)
6dnl $4 (UNDESIRABLE): warning flags we don't want (e.g.
7dnl   missing-field-initializers unused-parameter)
8AC_DEFUN([TP_COMPILER_WARNINGS],
9[
10  AC_REQUIRE([AC_ARG_ENABLE])dnl
11  AC_REQUIRE([AC_HELP_STRING])dnl
12  AC_REQUIRE([TP_COMPILER_FLAG])dnl
13
14  tp_warnings=""
15  for tp_flag in $3; do
16    TP_COMPILER_FLAG([-W$tp_flag], [tp_warnings="$tp_warnings -W$tp_flag"])
17  done
18
19  tp_error_flags="-Werror"
20  TP_COMPILER_FLAG([-Werror], [tp_werror=yes], [tp_werror=no])
21
22  for tp_flag in $4; do
23    TP_COMPILER_FLAG([-Wno-$tp_flag],
24      [tp_warnings="$tp_warnings -Wno-$tp_flag"])
25dnl Yes, we do need to use both -Wno-foo and -Wno-error=foo. Simon says:
26dnl     some warnings we explicitly don't want, like unused-parameter, but
27dnl     they're in -Wall. when a distro using cdbs compiles us, we have:
28dnl       -Werror -Wno-unused-parameter      -Wall
29dnl         ^ from us                         ^ from cdbs
30dnl     which turns -Wunused-parameter back on, in effect
31    TP_COMPILER_FLAG([-Wno-error=$tp_flag],
32      [tp_error_flags="$tp_error_flags -Wno-error=$tp_flag"], [tp_werror=no])
33  done
34
35  AC_ARG_ENABLE([Werror],
36    AC_HELP_STRING([--disable-Werror],
37      [compile without -Werror (normally enabled in development builds)]),
38    tp_werror=$enableval, :)
39
40  if test "x$tp_werror" = xyes && $2; then
41dnl We put -Wno-error=foo before -Wno-foo because clang interprets -Wall
42dnl -Werror -Wno-foo -Wno-error=foo as “make foo a non-fatal warning”, but does
43dnl what we want if you reverse them.
44    $1="$tp_error_flags $tp_warnings"
45  else
46    $1="$tp_warnings"
47  fi
48
49])
50