1<?xml version="1.0" encoding="utf-8"?> 2<feed xmlns="http://www.w3.org/2005/Atom" xml:lang="en-us" updated="2009-10-04T01:35:58+00:00"><title>Code Review - My issues</title><link href="http://codereview.appspot.com/" rel="alternate"></link><link href="http://codereview.appspot.com/rss/mine/rsc" rel="self"></link><id>http://codereview.appspot.com/</id><author><name>rietveld<></name></author><entry><title>rietveld: an attempt at pubsubhubbub 3</title><link href="http://codereview.appspot.com/126085" rel="alternate"></link><updated>2009-10-04T01:35:58+00:00</updated><author><name>email-address-removed</name></author><id>urn:md5:134d9179c41f806be79b3a5f7877d19a</id><summary type="html"> 4 An attempt at adding pubsubhubbub support to Rietveld. 5http://code.google.com/p/pubsubhubbub 6http://code.google.com/p/rietveld/issues/detail?id=155 7 8The server side of the protocol is trivial: 9 1. add a &lt;link rel=&quot;hub&quot; href=&quot;hub-server&quot;&gt; tag to all 10 feeds that will be pubsubhubbubbed. 11 2. every time one of those feeds changes, tell the hub 12 with a simple POST request. 13 14I have tested this by adding debug prints to a local hub 15server and checking that the server got the right publish 16requests. 17 18I can&#39;t quite get the server to work, but I think the bug 19is not in my code. I think that the server expects to be 20able to grab the feed and see the feed&#39;s actual URL in 21the link rel=&quot;self&quot;, but the default value for that drops 22the :port from the URL, and I cannot for the life of me 23figure out how to get the Atom generator deep inside 24django not to do that, or even where it is doing that, 25or even what code is running to generate the Atom feed. 26(I thought I knew but I added some assert False statements 27and it kept running!) 28 29Ignoring that particular problem, I would appreciate 30feedback on the right way to get the two values at 31the top of feeds.py marked NOTE(rsc). 32 33 34</summary></entry><entry><title>rietveld: correct tab handling 35</title><link href="http://codereview.appspot.com/124106" rel="alternate"></link><updated>2009-10-03T23:02:17+00:00</updated><author><name>email-address-removed</name></author><id>urn:md5:0a2a4f19bb815101f0ba2904aed7c35a</id><summary type="html"> 36 This fixes the buggy tab rendering that can be seen at 37http://codereview.appspot.com/116075/diff/1/2 38 39The fundamental problem was that the tab code was 40not being told what column the text began in, so it 41didn&#39;t know where to put the tab stops. Another problem 42was that some of the code assumed that string byte 43offsets were the same as column offsets, which is only 44true if there are no tabs. 45 46In the process of fixing this, I cleaned up the arguments 47to Fold and ExpandTabs and renamed them Break and 48_ExpandTabs so that I could be sure that I found all the 49call sites. I also wanted to verify that ExpandTabs was 50not being used from outside intra_region_diff.py. 51 52 53</summary></entry></feed> ` 54 55