xref: /dragonfly/sys/dev/drm/i915/intel_dp_mst.c (revision 0de090e1)
1 /*
2  * Copyright © 2008 Intel Corporation
3  *             2014 Red Hat Inc.
4  *
5  * Permission is hereby granted, free of charge, to any person obtaining a
6  * copy of this software and associated documentation files (the "Software"),
7  * to deal in the Software without restriction, including without limitation
8  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9  * and/or sell copies of the Software, and to permit persons to whom the
10  * Software is furnished to do so, subject to the following conditions:
11  *
12  * The above copyright notice and this permission notice (including the next
13  * paragraph) shall be included in all copies or substantial portions of the
14  * Software.
15  *
16  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
19  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
21  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
22  * IN THE SOFTWARE.
23  *
24  */
25 
26 #include <drm/drmP.h>
27 #include "i915_drv.h"
28 #include "intel_drv.h"
29 #include <drm/drm_atomic_helper.h>
30 #include <drm/drm_crtc_helper.h>
31 #include <drm/drm_edid.h>
32 
33 #if 0
34 static bool intel_dp_mst_compute_config(struct intel_encoder *encoder,
35 					struct intel_crtc_state *pipe_config)
36 {
37 	struct drm_device *dev = encoder->base.dev;
38 	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
39 	struct intel_digital_port *intel_dig_port = intel_mst->primary;
40 	struct intel_dp *intel_dp = &intel_dig_port->dp;
41 	struct drm_atomic_state *state;
42 	int bpp, i;
43 	int lane_count, slots;
44 	const struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
45 	struct drm_connector *drm_connector;
46 	struct intel_connector *connector, *found = NULL;
47 	struct drm_connector_state *connector_state;
48 	int mst_pbn;
49 
50 	pipe_config->dp_encoder_is_mst = true;
51 	pipe_config->has_pch_encoder = false;
52 	pipe_config->has_dp_encoder = true;
53 	bpp = 24;
54 	/*
55 	 * for MST we always configure max link bw - the spec doesn't
56 	 * seem to suggest we should do otherwise.
57 	 */
58 	lane_count = drm_dp_max_lane_count(intel_dp->dpcd);
59 
60 
61 	pipe_config->lane_count = lane_count;
62 
63 	pipe_config->pipe_bpp = 24;
64 	pipe_config->port_clock = intel_dp_max_link_rate(intel_dp);
65 
66 	state = pipe_config->base.state;
67 
68 	for_each_connector_in_state(state, drm_connector, connector_state, i) {
69 		connector = to_intel_connector(drm_connector);
70 
71 		if (connector_state->best_encoder == &encoder->base) {
72 			found = connector;
73 			break;
74 		}
75 	}
76 
77 	if (!found) {
78 		DRM_ERROR("can't find connector\n");
79 		return false;
80 	}
81 
82 	mst_pbn = drm_dp_calc_pbn_mode(adjusted_mode->crtc_clock, bpp);
83 
84 	pipe_config->pbn = mst_pbn;
85 	slots = drm_dp_find_vcpi_slots(&intel_dp->mst_mgr, mst_pbn);
86 
87 	intel_link_compute_m_n(bpp, lane_count,
88 			       adjusted_mode->crtc_clock,
89 			       pipe_config->port_clock,
90 			       &pipe_config->dp_m_n);
91 
92 	pipe_config->dp_m_n.tu = slots;
93 
94 	if (IS_HASWELL(dev) || IS_BROADWELL(dev))
95 		hsw_dp_set_ddi_pll_sel(pipe_config);
96 
97 	return true;
98 
99 }
100 
101 static void intel_mst_disable_dp(struct intel_encoder *encoder)
102 {
103 	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
104 	struct intel_digital_port *intel_dig_port = intel_mst->primary;
105 	struct intel_dp *intel_dp = &intel_dig_port->dp;
106 	int ret;
107 
108 	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
109 
110 	drm_dp_mst_reset_vcpi_slots(&intel_dp->mst_mgr, intel_mst->port);
111 
112 	ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
113 	if (ret) {
114 		DRM_ERROR("failed to update payload %d\n", ret);
115 	}
116 }
117 
118 static void intel_mst_post_disable_dp(struct intel_encoder *encoder)
119 {
120 	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
121 	struct intel_digital_port *intel_dig_port = intel_mst->primary;
122 	struct intel_dp *intel_dp = &intel_dig_port->dp;
123 
124 	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
125 
126 	/* this can fail */
127 	drm_dp_check_act_status(&intel_dp->mst_mgr);
128 	/* and this can also fail */
129 	drm_dp_update_payload_part2(&intel_dp->mst_mgr);
130 
131 	drm_dp_mst_deallocate_vcpi(&intel_dp->mst_mgr, intel_mst->port);
132 
133 	intel_dp->active_mst_links--;
134 	intel_mst->port = NULL;
135 	if (intel_dp->active_mst_links == 0) {
136 		intel_dig_port->base.post_disable(&intel_dig_port->base);
137 		intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
138 	}
139 }
140 
141 static void intel_mst_pre_enable_dp(struct intel_encoder *encoder)
142 {
143 	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
144 	struct intel_digital_port *intel_dig_port = intel_mst->primary;
145 	struct intel_dp *intel_dp = &intel_dig_port->dp;
146 	struct drm_device *dev = encoder->base.dev;
147 	struct drm_i915_private *dev_priv = dev->dev_private;
148 	enum port port = intel_dig_port->port;
149 	int ret;
150 	uint32_t temp;
151 	struct intel_connector *found = NULL, *connector;
152 	int slots;
153 	struct drm_crtc *crtc = encoder->base.crtc;
154 	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
155 
156 	for_each_intel_connector(dev, connector) {
157 		if (connector->base.state->best_encoder == &encoder->base) {
158 			found = connector;
159 			break;
160 		}
161 	}
162 
163 	if (!found) {
164 		DRM_ERROR("can't find connector\n");
165 		return;
166 	}
167 
168 	/* MST encoders are bound to a crtc, not to a connector,
169 	 * force the mapping here for get_hw_state.
170 	 */
171 	found->encoder = encoder;
172 
173 	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
174 	intel_mst->port = found->port;
175 
176 	if (intel_dp->active_mst_links == 0) {
177 		enum port port = intel_ddi_get_encoder_port(encoder);
178 
179 		intel_dp_set_link_params(intel_dp, intel_crtc->config);
180 
181 		/* FIXME: add support for SKL */
182 		if (INTEL_INFO(dev)->gen < 9)
183 			I915_WRITE(PORT_CLK_SEL(port),
184 				   intel_crtc->config->ddi_pll_sel);
185 
186 		intel_ddi_init_dp_buf_reg(&intel_dig_port->base);
187 
188 		intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON);
189 
190 
191 		intel_dp_start_link_train(intel_dp);
192 		intel_dp_stop_link_train(intel_dp);
193 	}
194 
195 	ret = drm_dp_mst_allocate_vcpi(&intel_dp->mst_mgr,
196 				       intel_mst->port,
197 				       intel_crtc->config->pbn, &slots);
198 	if (ret == false) {
199 		DRM_ERROR("failed to allocate vcpi\n");
200 		return;
201 	}
202 
203 
204 	intel_dp->active_mst_links++;
205 	temp = I915_READ(DP_TP_STATUS(port));
206 	I915_WRITE(DP_TP_STATUS(port), temp);
207 
208 	ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
209 }
210 
211 static void intel_mst_enable_dp(struct intel_encoder *encoder)
212 {
213 	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
214 	struct intel_digital_port *intel_dig_port = intel_mst->primary;
215 	struct intel_dp *intel_dp = &intel_dig_port->dp;
216 	struct drm_device *dev = intel_dig_port->base.base.dev;
217 	struct drm_i915_private *dev_priv = dev->dev_private;
218 	enum port port = intel_dig_port->port;
219 	int ret;
220 
221 	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
222 
223 	if (wait_for((I915_READ(DP_TP_STATUS(port)) & DP_TP_STATUS_ACT_SENT),
224 		     1))
225 		DRM_ERROR("Timed out waiting for ACT sent\n");
226 
227 	ret = drm_dp_check_act_status(&intel_dp->mst_mgr);
228 
229 	ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr);
230 }
231 
232 static bool intel_dp_mst_enc_get_hw_state(struct intel_encoder *encoder,
233 				      enum pipe *pipe)
234 {
235 	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
236 	*pipe = intel_mst->pipe;
237 	if (intel_mst->port)
238 		return true;
239 	return false;
240 }
241 
242 static void intel_dp_mst_enc_get_config(struct intel_encoder *encoder,
243 					struct intel_crtc_state *pipe_config)
244 {
245 	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
246 	struct intel_digital_port *intel_dig_port = intel_mst->primary;
247 	struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
248 	struct drm_device *dev = encoder->base.dev;
249 	struct drm_i915_private *dev_priv = dev->dev_private;
250 	enum transcoder cpu_transcoder = pipe_config->cpu_transcoder;
251 	u32 temp, flags = 0;
252 
253 	pipe_config->has_dp_encoder = true;
254 
255 	temp = I915_READ(TRANS_DDI_FUNC_CTL(cpu_transcoder));
256 	if (temp & TRANS_DDI_PHSYNC)
257 		flags |= DRM_MODE_FLAG_PHSYNC;
258 	else
259 		flags |= DRM_MODE_FLAG_NHSYNC;
260 	if (temp & TRANS_DDI_PVSYNC)
261 		flags |= DRM_MODE_FLAG_PVSYNC;
262 	else
263 		flags |= DRM_MODE_FLAG_NVSYNC;
264 
265 	switch (temp & TRANS_DDI_BPC_MASK) {
266 	case TRANS_DDI_BPC_6:
267 		pipe_config->pipe_bpp = 18;
268 		break;
269 	case TRANS_DDI_BPC_8:
270 		pipe_config->pipe_bpp = 24;
271 		break;
272 	case TRANS_DDI_BPC_10:
273 		pipe_config->pipe_bpp = 30;
274 		break;
275 	case TRANS_DDI_BPC_12:
276 		pipe_config->pipe_bpp = 36;
277 		break;
278 	default:
279 		break;
280 	}
281 	pipe_config->base.adjusted_mode.flags |= flags;
282 
283 	pipe_config->lane_count =
284 		((temp & DDI_PORT_WIDTH_MASK) >> DDI_PORT_WIDTH_SHIFT) + 1;
285 
286 	intel_dp_get_m_n(crtc, pipe_config);
287 
288 	intel_ddi_clock_get(&intel_dig_port->base, pipe_config);
289 }
290 
291 static int intel_dp_mst_get_ddc_modes(struct drm_connector *connector)
292 {
293 	struct intel_connector *intel_connector = to_intel_connector(connector);
294 	struct intel_dp *intel_dp = intel_connector->mst_port;
295 	struct edid *edid;
296 	int ret;
297 
298 	edid = drm_dp_mst_get_edid(connector, &intel_dp->mst_mgr, intel_connector->port);
299 	if (!edid)
300 		return 0;
301 
302 	ret = intel_connector_update_modes(connector, edid);
303 	kfree(edid);
304 
305 	return ret;
306 }
307 
308 static enum drm_connector_status
309 intel_dp_mst_detect(struct drm_connector *connector, bool force)
310 {
311 	struct intel_connector *intel_connector = to_intel_connector(connector);
312 	struct intel_dp *intel_dp = intel_connector->mst_port;
313 
314 	return drm_dp_mst_detect_port(connector, &intel_dp->mst_mgr, intel_connector->port);
315 }
316 
317 static int
318 intel_dp_mst_set_property(struct drm_connector *connector,
319 			  struct drm_property *property,
320 			  uint64_t val)
321 {
322 	return 0;
323 }
324 
325 static void
326 intel_dp_mst_connector_destroy(struct drm_connector *connector)
327 {
328 	struct intel_connector *intel_connector = to_intel_connector(connector);
329 
330 	if (!IS_ERR_OR_NULL(intel_connector->edid))
331 		kfree(intel_connector->edid);
332 
333 	drm_connector_cleanup(connector);
334 	kfree(connector);
335 }
336 
337 static const struct drm_connector_funcs intel_dp_mst_connector_funcs = {
338 	.dpms = drm_atomic_helper_connector_dpms,
339 	.detect = intel_dp_mst_detect,
340 	.fill_modes = drm_helper_probe_single_connector_modes,
341 	.set_property = intel_dp_mst_set_property,
342 	.atomic_get_property = intel_connector_atomic_get_property,
343 	.destroy = intel_dp_mst_connector_destroy,
344 	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
345 	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
346 };
347 
348 static int intel_dp_mst_get_modes(struct drm_connector *connector)
349 {
350 	return intel_dp_mst_get_ddc_modes(connector);
351 }
352 
353 static enum drm_mode_status
354 intel_dp_mst_mode_valid(struct drm_connector *connector,
355 			struct drm_display_mode *mode)
356 {
357 	/* TODO - validate mode against available PBN for link */
358 	if (mode->clock < 10000)
359 		return MODE_CLOCK_LOW;
360 
361 	if (mode->flags & DRM_MODE_FLAG_DBLCLK)
362 		return MODE_H_ILLEGAL;
363 
364 	return MODE_OK;
365 }
366 
367 static struct drm_encoder *intel_mst_atomic_best_encoder(struct drm_connector *connector,
368 							 struct drm_connector_state *state)
369 {
370 	struct intel_connector *intel_connector = to_intel_connector(connector);
371 	struct intel_dp *intel_dp = intel_connector->mst_port;
372 	struct intel_crtc *crtc = to_intel_crtc(state->crtc);
373 
374 	return &intel_dp->mst_encoders[crtc->pipe]->base.base;
375 }
376 
377 static struct drm_encoder *intel_mst_best_encoder(struct drm_connector *connector)
378 {
379 	struct intel_connector *intel_connector = to_intel_connector(connector);
380 	struct intel_dp *intel_dp = intel_connector->mst_port;
381 	return &intel_dp->mst_encoders[0]->base.base;
382 }
383 
384 static const struct drm_connector_helper_funcs intel_dp_mst_connector_helper_funcs = {
385 	.get_modes = intel_dp_mst_get_modes,
386 	.mode_valid = intel_dp_mst_mode_valid,
387 	.atomic_best_encoder = intel_mst_atomic_best_encoder,
388 	.best_encoder = intel_mst_best_encoder,
389 };
390 #endif
391 
392 static void intel_dp_mst_encoder_destroy(struct drm_encoder *encoder)
393 {
394 	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(encoder);
395 
396 	drm_encoder_cleanup(encoder);
397 	kfree(intel_mst);
398 }
399 
400 static const struct drm_encoder_funcs intel_dp_mst_enc_funcs = {
401 	.destroy = intel_dp_mst_encoder_destroy,
402 };
403 
404 #if 0
405 static bool intel_dp_mst_get_hw_state(struct intel_connector *connector)
406 {
407 	if (connector->encoder && connector->base.state->crtc) {
408 		enum pipe pipe;
409 		if (!connector->encoder->get_hw_state(connector->encoder, &pipe))
410 			return false;
411 		return true;
412 	}
413 	return false;
414 }
415 
416 static void intel_connector_add_to_fbdev(struct intel_connector *connector)
417 {
418 #ifdef CONFIG_DRM_FBDEV_EMULATION
419 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
420 	drm_fb_helper_add_one_connector(&dev_priv->fbdev->helper, &connector->base);
421 #endif
422 }
423 
424 static void intel_connector_remove_from_fbdev(struct intel_connector *connector)
425 {
426 #ifdef CONFIG_DRM_FBDEV_EMULATION
427 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
428 	drm_fb_helper_remove_one_connector(&dev_priv->fbdev->helper, &connector->base);
429 #endif
430 }
431 
432 static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port, const char *pathprop)
433 {
434 	struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);
435 	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
436 	struct drm_device *dev = intel_dig_port->base.base.dev;
437 	struct intel_connector *intel_connector;
438 	struct drm_connector *connector;
439 	int i;
440 
441 	intel_connector = intel_connector_alloc();
442 	if (!intel_connector)
443 		return NULL;
444 
445 	connector = &intel_connector->base;
446 	drm_connector_init(dev, connector, &intel_dp_mst_connector_funcs, DRM_MODE_CONNECTOR_DisplayPort);
447 	drm_connector_helper_add(connector, &intel_dp_mst_connector_helper_funcs);
448 
449 	intel_connector->unregister = intel_connector_unregister;
450 	intel_connector->get_hw_state = intel_dp_mst_get_hw_state;
451 	intel_connector->mst_port = intel_dp;
452 	intel_connector->port = port;
453 
454 	for (i = PIPE_A; i <= PIPE_C; i++) {
455 		drm_mode_connector_attach_encoder(&intel_connector->base,
456 						  &intel_dp->mst_encoders[i]->base.base);
457 	}
458 	intel_dp_add_properties(intel_dp, connector);
459 
460 	drm_object_attach_property(&connector->base, dev->mode_config.path_property, 0);
461 	drm_object_attach_property(&connector->base, dev->mode_config.tile_property, 0);
462 
463 	drm_mode_connector_set_path_property(connector, pathprop);
464 	return connector;
465 }
466 
467 static void intel_dp_register_mst_connector(struct drm_connector *connector)
468 {
469 	struct intel_connector *intel_connector = to_intel_connector(connector);
470 	struct drm_device *dev = connector->dev;
471 	drm_modeset_lock_all(dev);
472 	intel_connector_add_to_fbdev(intel_connector);
473 	drm_modeset_unlock_all(dev);
474 	drm_connector_register(&intel_connector->base);
475 }
476 
477 static void intel_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr,
478 					   struct drm_connector *connector)
479 {
480 	struct intel_connector *intel_connector = to_intel_connector(connector);
481 	struct drm_device *dev = connector->dev;
482 
483 	/* need to nuke the connector */
484 	drm_modeset_lock_all(dev);
485 	if (connector->state->crtc) {
486 		struct drm_mode_set set;
487 		int ret;
488 
489 		memset(&set, 0, sizeof(set));
490 		set.crtc = connector->state->crtc,
491 
492 		ret = drm_atomic_helper_set_config(&set);
493 
494 		WARN(ret, "Disabling mst crtc failed with %i\n", ret);
495 	}
496 	drm_modeset_unlock_all(dev);
497 
498 	intel_connector->unregister(intel_connector);
499 
500 	drm_modeset_lock_all(dev);
501 	intel_connector_remove_from_fbdev(intel_connector);
502 	drm_connector_cleanup(connector);
503 	drm_modeset_unlock_all(dev);
504 
505 	kfree(intel_connector);
506 	DRM_DEBUG_KMS("\n");
507 }
508 
509 static void intel_dp_mst_hotplug(struct drm_dp_mst_topology_mgr *mgr)
510 {
511 	struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);
512 	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
513 	struct drm_device *dev = intel_dig_port->base.base.dev;
514 
515 	drm_kms_helper_hotplug_event(dev);
516 }
517 
518 static struct drm_dp_mst_topology_cbs mst_cbs = {
519 	.add_connector = intel_dp_add_mst_connector,
520 	.register_connector = intel_dp_register_mst_connector,
521 	.destroy_connector = intel_dp_destroy_mst_connector,
522 	.hotplug = intel_dp_mst_hotplug,
523 };
524 
525 static struct intel_dp_mst_encoder *
526 intel_dp_create_fake_mst_encoder(struct intel_digital_port *intel_dig_port, enum pipe pipe)
527 {
528 	struct intel_dp_mst_encoder *intel_mst;
529 	struct intel_encoder *intel_encoder;
530 	struct drm_device *dev = intel_dig_port->base.base.dev;
531 
532 	intel_mst = kzalloc(sizeof(*intel_mst), GFP_KERNEL);
533 
534 	if (!intel_mst)
535 		return NULL;
536 
537 	intel_mst->pipe = pipe;
538 	intel_encoder = &intel_mst->base;
539 	intel_mst->primary = intel_dig_port;
540 
541 	drm_encoder_init(dev, &intel_encoder->base, &intel_dp_mst_enc_funcs,
542 			 DRM_MODE_ENCODER_DPMST);
543 
544 	intel_encoder->type = INTEL_OUTPUT_DP_MST;
545 	intel_encoder->crtc_mask = 0x7;
546 	intel_encoder->cloneable = 0;
547 
548 	intel_encoder->compute_config = intel_dp_mst_compute_config;
549 	intel_encoder->disable = intel_mst_disable_dp;
550 	intel_encoder->post_disable = intel_mst_post_disable_dp;
551 	intel_encoder->pre_enable = intel_mst_pre_enable_dp;
552 	intel_encoder->enable = intel_mst_enable_dp;
553 	intel_encoder->get_hw_state = intel_dp_mst_enc_get_hw_state;
554 	intel_encoder->get_config = intel_dp_mst_enc_get_config;
555 
556 	return intel_mst;
557 
558 }
559 
560 static bool
561 intel_dp_create_fake_mst_encoders(struct intel_digital_port *intel_dig_port)
562 {
563 	int i;
564 	struct intel_dp *intel_dp = &intel_dig_port->dp;
565 
566 	for (i = PIPE_A; i <= PIPE_C; i++)
567 		intel_dp->mst_encoders[i] = intel_dp_create_fake_mst_encoder(intel_dig_port, i);
568 	return true;
569 }
570 #endif
571 
572 int
573 intel_dp_mst_encoder_init(struct intel_digital_port *intel_dig_port, int conn_base_id)
574 {
575 	struct intel_dp *intel_dp = &intel_dig_port->dp;
576 #if 0
577 	struct drm_device *dev = intel_dig_port->base.base.dev;
578 	int ret;
579 
580 	intel_dp->can_mst = true;
581 	intel_dp->mst_mgr.cbs = &mst_cbs;
582 
583 	/* create encoders */
584 	intel_dp_create_fake_mst_encoders(intel_dig_port);
585 	ret = drm_dp_mst_topology_mgr_init(&intel_dp->mst_mgr, dev->dev, &intel_dp->aux, 16, 3, conn_base_id);
586 	if (ret) {
587 		intel_dp->can_mst = false;
588 		return ret;
589 	}
590 #endif
591 	intel_dp->can_mst = false;
592 	return 0;
593 }
594 
595 void
596 intel_dp_mst_encoder_cleanup(struct intel_digital_port *intel_dig_port)
597 {
598 	struct intel_dp *intel_dp = &intel_dig_port->dp;
599 
600 	if (!intel_dp->can_mst)
601 		return;
602 
603 #if 0
604 	drm_dp_mst_topology_mgr_destroy(&intel_dp->mst_mgr);
605 #endif
606 	/* encoders will get killed by normal cleanup */
607 }
608