1 /* 2 * Copyright 2008 Intel Corporation <hong.liu@intel.com> 3 * Copyright 2008 Red Hat <mjg@redhat.com> 4 * 5 * Permission is hereby granted, free of charge, to any person obtaining 6 * a copy of this software and associated documentation files (the 7 * "Software"), to deal in the Software without restriction, including 8 * without limitation the rights to use, copy, modify, merge, publish, 9 * distribute, sub license, and/or sell copies of the Software, and to 10 * permit persons to whom the Software is furnished to do so, subject to 11 * the following conditions: 12 * 13 * The above copyright notice and this permission notice (including the 14 * next paragraph) shall be included in all copies or substantial 15 * portions of the Software. 16 * 17 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, 18 * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF 19 * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND 20 * NON-INFRINGEMENT. IN NO EVENT SHALL INTEL AND/OR ITS SUPPLIERS BE 21 * LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN 22 * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN 23 * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE 24 * SOFTWARE. 25 * 26 */ 27 28 #include <linux/acpi.h> 29 #include <linux/dmi.h> 30 31 #include <drm/drmP.h> 32 #include <drm/i915_drm.h> 33 #include "i915_drv.h" 34 #include "intel_drv.h" 35 36 #include <contrib/dev/acpica/source/include/acpi.h> 37 #include <contrib/dev/acpica/source/include/accommon.h> 38 #include <dev/acpica/acpivar.h> 39 40 #define OPREGION_HEADER_OFFSET 0 41 #define OPREGION_ACPI_OFFSET 0x100 42 #define ACPI_CLID 0x01ac /* current lid state indicator */ 43 #define ACPI_CDCK 0x01b0 /* current docking state indicator */ 44 #define OPREGION_SWSCI_OFFSET 0x200 45 #define OPREGION_ASLE_OFFSET 0x300 46 #define OPREGION_VBT_OFFSET 0x400 47 #define OPREGION_ASLE_EXT_OFFSET 0x1C00 48 49 #define OPREGION_SIGNATURE "IntelGraphicsMem" 50 #define MBOX_ACPI (1<<0) 51 #define MBOX_SWSCI (1<<1) 52 #define MBOX_ASLE (1<<2) 53 #define MBOX_ASLE_EXT (1<<4) 54 55 struct opregion_header { 56 u8 signature[16]; 57 u32 size; 58 u32 opregion_ver; 59 u8 bios_ver[32]; 60 u8 vbios_ver[16]; 61 u8 driver_ver[16]; 62 u32 mboxes; 63 u32 driver_model; 64 u32 pcon; 65 u8 dver[32]; 66 u8 rsvd[124]; 67 } __packed; 68 69 /* OpRegion mailbox #1: public ACPI methods */ 70 struct opregion_acpi { 71 u32 drdy; /* driver readiness */ 72 u32 csts; /* notification status */ 73 u32 cevt; /* current event */ 74 u8 rsvd1[20]; 75 u32 didl[8]; /* supported display devices ID list */ 76 u32 cpdl[8]; /* currently presented display list */ 77 u32 cadl[8]; /* currently active display list */ 78 u32 nadl[8]; /* next active devices list */ 79 u32 aslp; /* ASL sleep time-out */ 80 u32 tidx; /* toggle table index */ 81 u32 chpd; /* current hotplug enable indicator */ 82 u32 clid; /* current lid state*/ 83 u32 cdck; /* current docking state */ 84 u32 sxsw; /* Sx state resume */ 85 u32 evts; /* ASL supported events */ 86 u32 cnot; /* current OS notification */ 87 u32 nrdy; /* driver status */ 88 u32 did2[7]; /* extended supported display devices ID list */ 89 u32 cpd2[7]; /* extended attached display devices list */ 90 u8 rsvd2[4]; 91 } __packed; 92 93 /* OpRegion mailbox #2: SWSCI */ 94 struct opregion_swsci { 95 u32 scic; /* SWSCI command|status|data */ 96 u32 parm; /* command parameters */ 97 u32 dslp; /* driver sleep time-out */ 98 u8 rsvd[244]; 99 } __packed; 100 101 /* OpRegion mailbox #3: ASLE */ 102 struct opregion_asle { 103 u32 ardy; /* driver readiness */ 104 u32 aslc; /* ASLE interrupt command */ 105 u32 tche; /* technology enabled indicator */ 106 u32 alsi; /* current ALS illuminance reading */ 107 u32 bclp; /* backlight brightness to set */ 108 u32 pfit; /* panel fitting state */ 109 u32 cblv; /* current brightness level */ 110 u16 bclm[20]; /* backlight level duty cycle mapping table */ 111 u32 cpfm; /* current panel fitting mode */ 112 u32 epfm; /* enabled panel fitting modes */ 113 u8 plut[74]; /* panel LUT and identifier */ 114 u32 pfmb; /* PWM freq and min brightness */ 115 u32 cddv; /* color correction default values */ 116 u32 pcft; /* power conservation features */ 117 u32 srot; /* supported rotation angles */ 118 u32 iuer; /* IUER events */ 119 u64 fdss; 120 u32 fdsp; 121 u32 stat; 122 u64 rvda; /* Physical address of raw vbt data */ 123 u32 rvds; /* Size of raw vbt data */ 124 u8 rsvd[58]; 125 } __packed; 126 127 /* OpRegion mailbox #5: ASLE ext */ 128 struct opregion_asle_ext { 129 u32 phed; /* Panel Header */ 130 u8 bddc[256]; /* Panel EDID */ 131 u8 rsvd[764]; 132 } __packed; 133 134 /* Driver readiness indicator */ 135 #define ASLE_ARDY_READY (1 << 0) 136 #define ASLE_ARDY_NOT_READY (0 << 0) 137 138 /* ASLE Interrupt Command (ASLC) bits */ 139 #define ASLC_SET_ALS_ILLUM (1 << 0) 140 #define ASLC_SET_BACKLIGHT (1 << 1) 141 #define ASLC_SET_PFIT (1 << 2) 142 #define ASLC_SET_PWM_FREQ (1 << 3) 143 #define ASLC_SUPPORTED_ROTATION_ANGLES (1 << 4) 144 #define ASLC_BUTTON_ARRAY (1 << 5) 145 #define ASLC_CONVERTIBLE_INDICATOR (1 << 6) 146 #define ASLC_DOCKING_INDICATOR (1 << 7) 147 #define ASLC_ISCT_STATE_CHANGE (1 << 8) 148 #define ASLC_REQ_MSK 0x1ff 149 /* response bits */ 150 #define ASLC_ALS_ILLUM_FAILED (1 << 10) 151 #define ASLC_BACKLIGHT_FAILED (1 << 12) 152 #define ASLC_PFIT_FAILED (1 << 14) 153 #define ASLC_PWM_FREQ_FAILED (1 << 16) 154 #define ASLC_ROTATION_ANGLES_FAILED (1 << 18) 155 #define ASLC_BUTTON_ARRAY_FAILED (1 << 20) 156 #define ASLC_CONVERTIBLE_FAILED (1 << 22) 157 #define ASLC_DOCKING_FAILED (1 << 24) 158 #define ASLC_ISCT_STATE_FAILED (1 << 26) 159 160 /* Technology enabled indicator */ 161 #define ASLE_TCHE_ALS_EN (1 << 0) 162 #define ASLE_TCHE_BLC_EN (1 << 1) 163 #define ASLE_TCHE_PFIT_EN (1 << 2) 164 #define ASLE_TCHE_PFMB_EN (1 << 3) 165 166 /* ASLE backlight brightness to set */ 167 #define ASLE_BCLP_VALID (1<<31) 168 #define ASLE_BCLP_MSK (~(1<<31)) 169 170 /* ASLE panel fitting request */ 171 #define ASLE_PFIT_VALID (1<<31) 172 #define ASLE_PFIT_CENTER (1<<0) 173 #define ASLE_PFIT_STRETCH_TEXT (1<<1) 174 #define ASLE_PFIT_STRETCH_GFX (1<<2) 175 176 /* PWM frequency and minimum brightness */ 177 #define ASLE_PFMB_BRIGHTNESS_MASK (0xff) 178 #define ASLE_PFMB_BRIGHTNESS_VALID (1<<8) 179 #define ASLE_PFMB_PWM_MASK (0x7ffffe00) 180 #define ASLE_PFMB_PWM_VALID (1<<31) 181 182 #define ASLE_CBLV_VALID (1<<31) 183 184 /* IUER */ 185 #define ASLE_IUER_DOCKING (1 << 7) 186 #define ASLE_IUER_CONVERTIBLE (1 << 6) 187 #define ASLE_IUER_ROTATION_LOCK_BTN (1 << 4) 188 #define ASLE_IUER_VOLUME_DOWN_BTN (1 << 3) 189 #define ASLE_IUER_VOLUME_UP_BTN (1 << 2) 190 #define ASLE_IUER_WINDOWS_BTN (1 << 1) 191 #define ASLE_IUER_POWER_BTN (1 << 0) 192 193 /* Software System Control Interrupt (SWSCI) */ 194 #define SWSCI_SCIC_INDICATOR (1 << 0) 195 #define SWSCI_SCIC_MAIN_FUNCTION_SHIFT 1 196 #define SWSCI_SCIC_MAIN_FUNCTION_MASK (0xf << 1) 197 #define SWSCI_SCIC_SUB_FUNCTION_SHIFT 8 198 #define SWSCI_SCIC_SUB_FUNCTION_MASK (0xff << 8) 199 #define SWSCI_SCIC_EXIT_PARAMETER_SHIFT 8 200 #define SWSCI_SCIC_EXIT_PARAMETER_MASK (0xff << 8) 201 #define SWSCI_SCIC_EXIT_STATUS_SHIFT 5 202 #define SWSCI_SCIC_EXIT_STATUS_MASK (7 << 5) 203 #define SWSCI_SCIC_EXIT_STATUS_SUCCESS 1 204 205 #define SWSCI_FUNCTION_CODE(main, sub) \ 206 ((main) << SWSCI_SCIC_MAIN_FUNCTION_SHIFT | \ 207 (sub) << SWSCI_SCIC_SUB_FUNCTION_SHIFT) 208 209 /* SWSCI: Get BIOS Data (GBDA) */ 210 #define SWSCI_GBDA 4 211 #define SWSCI_GBDA_SUPPORTED_CALLS SWSCI_FUNCTION_CODE(SWSCI_GBDA, 0) 212 #define SWSCI_GBDA_REQUESTED_CALLBACKS SWSCI_FUNCTION_CODE(SWSCI_GBDA, 1) 213 #define SWSCI_GBDA_BOOT_DISPLAY_PREF SWSCI_FUNCTION_CODE(SWSCI_GBDA, 4) 214 #define SWSCI_GBDA_PANEL_DETAILS SWSCI_FUNCTION_CODE(SWSCI_GBDA, 5) 215 #define SWSCI_GBDA_TV_STANDARD SWSCI_FUNCTION_CODE(SWSCI_GBDA, 6) 216 #define SWSCI_GBDA_INTERNAL_GRAPHICS SWSCI_FUNCTION_CODE(SWSCI_GBDA, 7) 217 #define SWSCI_GBDA_SPREAD_SPECTRUM SWSCI_FUNCTION_CODE(SWSCI_GBDA, 10) 218 219 /* SWSCI: System BIOS Callbacks (SBCB) */ 220 #define SWSCI_SBCB 6 221 #define SWSCI_SBCB_SUPPORTED_CALLBACKS SWSCI_FUNCTION_CODE(SWSCI_SBCB, 0) 222 #define SWSCI_SBCB_INIT_COMPLETION SWSCI_FUNCTION_CODE(SWSCI_SBCB, 1) 223 #define SWSCI_SBCB_PRE_HIRES_SET_MODE SWSCI_FUNCTION_CODE(SWSCI_SBCB, 3) 224 #define SWSCI_SBCB_POST_HIRES_SET_MODE SWSCI_FUNCTION_CODE(SWSCI_SBCB, 4) 225 #define SWSCI_SBCB_DISPLAY_SWITCH SWSCI_FUNCTION_CODE(SWSCI_SBCB, 5) 226 #define SWSCI_SBCB_SET_TV_FORMAT SWSCI_FUNCTION_CODE(SWSCI_SBCB, 6) 227 #define SWSCI_SBCB_ADAPTER_POWER_STATE SWSCI_FUNCTION_CODE(SWSCI_SBCB, 7) 228 #define SWSCI_SBCB_DISPLAY_POWER_STATE SWSCI_FUNCTION_CODE(SWSCI_SBCB, 8) 229 #define SWSCI_SBCB_SET_BOOT_DISPLAY SWSCI_FUNCTION_CODE(SWSCI_SBCB, 9) 230 #define SWSCI_SBCB_SET_PANEL_DETAILS SWSCI_FUNCTION_CODE(SWSCI_SBCB, 10) 231 #define SWSCI_SBCB_SET_INTERNAL_GFX SWSCI_FUNCTION_CODE(SWSCI_SBCB, 11) 232 #define SWSCI_SBCB_POST_HIRES_TO_DOS_FS SWSCI_FUNCTION_CODE(SWSCI_SBCB, 16) 233 #define SWSCI_SBCB_SUSPEND_RESUME SWSCI_FUNCTION_CODE(SWSCI_SBCB, 17) 234 #define SWSCI_SBCB_SET_SPREAD_SPECTRUM SWSCI_FUNCTION_CODE(SWSCI_SBCB, 18) 235 #define SWSCI_SBCB_POST_VBE_PM SWSCI_FUNCTION_CODE(SWSCI_SBCB, 19) 236 #define SWSCI_SBCB_ENABLE_DISABLE_AUDIO SWSCI_FUNCTION_CODE(SWSCI_SBCB, 21) 237 238 /* 239 * ACPI Specification, Revision 5.0, Appendix B.3.2 _DOD (Enumerate All Devices 240 * Attached to the Display Adapter). 241 */ 242 #define ACPI_DISPLAY_INDEX_SHIFT 0 243 #define ACPI_DISPLAY_INDEX_MASK (0xf << 0) 244 #define ACPI_DISPLAY_PORT_ATTACHMENT_SHIFT 4 245 #define ACPI_DISPLAY_PORT_ATTACHMENT_MASK (0xf << 4) 246 #define ACPI_DISPLAY_TYPE_SHIFT 8 247 #define ACPI_DISPLAY_TYPE_MASK (0xf << 8) 248 #define ACPI_DISPLAY_TYPE_OTHER (0 << 8) 249 #define ACPI_DISPLAY_TYPE_VGA (1 << 8) 250 #define ACPI_DISPLAY_TYPE_TV (2 << 8) 251 #define ACPI_DISPLAY_TYPE_EXTERNAL_DIGITAL (3 << 8) 252 #define ACPI_DISPLAY_TYPE_INTERNAL_DIGITAL (4 << 8) 253 #define ACPI_VENDOR_SPECIFIC_SHIFT 12 254 #define ACPI_VENDOR_SPECIFIC_MASK (0xf << 12) 255 #define ACPI_BIOS_CAN_DETECT (1 << 16) 256 #define ACPI_DEPENDS_ON_VGA (1 << 17) 257 #define ACPI_PIPE_ID_SHIFT 18 258 #define ACPI_PIPE_ID_MASK (7 << 18) 259 #define ACPI_DEVICE_ID_SCHEME (1 << 31) 260 261 #define MAX_DSLP 1500 262 263 static int swsci(struct drm_i915_private *dev_priv, 264 u32 function, u32 parm, u32 *parm_out) 265 { 266 struct opregion_swsci *swsci = dev_priv->opregion.swsci; 267 struct pci_dev *pdev = dev_priv->drm.pdev; 268 u32 main_function, sub_function, scic; 269 u16 swsci_val; 270 u32 dslp; 271 272 if (!swsci) 273 return -ENODEV; 274 275 main_function = (function & SWSCI_SCIC_MAIN_FUNCTION_MASK) >> 276 SWSCI_SCIC_MAIN_FUNCTION_SHIFT; 277 sub_function = (function & SWSCI_SCIC_SUB_FUNCTION_MASK) >> 278 SWSCI_SCIC_SUB_FUNCTION_SHIFT; 279 280 /* Check if we can call the function. See swsci_setup for details. */ 281 if (main_function == SWSCI_SBCB) { 282 if ((dev_priv->opregion.swsci_sbcb_sub_functions & 283 (1 << sub_function)) == 0) 284 return -EINVAL; 285 } else if (main_function == SWSCI_GBDA) { 286 if ((dev_priv->opregion.swsci_gbda_sub_functions & 287 (1 << sub_function)) == 0) 288 return -EINVAL; 289 } 290 291 /* Driver sleep timeout in ms. */ 292 dslp = swsci->dslp; 293 if (!dslp) { 294 /* The spec says 2ms should be the default, but it's too small 295 * for some machines. */ 296 dslp = 50; 297 } else if (dslp > MAX_DSLP) { 298 /* Hey bios, trust must be earned. */ 299 DRM_INFO_ONCE("ACPI BIOS requests an excessive sleep of %u ms, " 300 "using %u ms instead\n", dslp, MAX_DSLP); 301 dslp = MAX_DSLP; 302 } 303 304 /* The spec tells us to do this, but we are the only user... */ 305 scic = swsci->scic; 306 if (scic & SWSCI_SCIC_INDICATOR) { 307 DRM_DEBUG_DRIVER("SWSCI request already in progress\n"); 308 return -EBUSY; 309 } 310 311 scic = function | SWSCI_SCIC_INDICATOR; 312 313 swsci->parm = parm; 314 swsci->scic = scic; 315 316 /* Ensure SCI event is selected and event trigger is cleared. */ 317 pci_read_config_word(pdev, SWSCI, &swsci_val); 318 if (!(swsci_val & SWSCI_SCISEL) || (swsci_val & SWSCI_GSSCIE)) { 319 swsci_val |= SWSCI_SCISEL; 320 swsci_val &= ~SWSCI_GSSCIE; 321 pci_write_config_word(pdev, SWSCI, swsci_val); 322 } 323 324 /* Use event trigger to tell bios to check the mail. */ 325 swsci_val |= SWSCI_GSSCIE; 326 pci_write_config_word(pdev, SWSCI, swsci_val); 327 328 /* Poll for the result. */ 329 #define C (((scic = swsci->scic) & SWSCI_SCIC_INDICATOR) == 0) 330 if (wait_for(C, dslp)) { 331 DRM_DEBUG_DRIVER("SWSCI request timed out\n"); 332 return -ETIMEDOUT; 333 } 334 335 scic = (scic & SWSCI_SCIC_EXIT_STATUS_MASK) >> 336 SWSCI_SCIC_EXIT_STATUS_SHIFT; 337 338 /* Note: scic == 0 is an error! */ 339 if (scic != SWSCI_SCIC_EXIT_STATUS_SUCCESS) { 340 DRM_DEBUG_DRIVER("SWSCI request error %u\n", scic); 341 return -EIO; 342 } 343 344 if (parm_out) 345 *parm_out = swsci->parm; 346 347 return 0; 348 349 #undef C 350 } 351 352 #define DISPLAY_TYPE_CRT 0 353 #define DISPLAY_TYPE_TV 1 354 #define DISPLAY_TYPE_EXTERNAL_FLAT_PANEL 2 355 #define DISPLAY_TYPE_INTERNAL_FLAT_PANEL 3 356 357 int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder, 358 bool enable) 359 { 360 struct drm_i915_private *dev_priv = to_i915(intel_encoder->base.dev); 361 u32 parm = 0; 362 u32 type = 0; 363 u32 port; 364 365 /* don't care about old stuff for now */ 366 if (!HAS_DDI(dev_priv)) 367 return 0; 368 369 if (intel_encoder->type == INTEL_OUTPUT_DSI) 370 port = 0; 371 else 372 port = intel_ddi_get_encoder_port(intel_encoder); 373 374 if (port == PORT_E) { 375 port = 0; 376 } else { 377 parm |= 1 << port; 378 port++; 379 } 380 381 if (!enable) 382 parm |= 4 << 8; 383 384 switch (intel_encoder->type) { 385 case INTEL_OUTPUT_ANALOG: 386 type = DISPLAY_TYPE_CRT; 387 break; 388 case INTEL_OUTPUT_UNKNOWN: 389 case INTEL_OUTPUT_DP: 390 case INTEL_OUTPUT_HDMI: 391 case INTEL_OUTPUT_DP_MST: 392 type = DISPLAY_TYPE_EXTERNAL_FLAT_PANEL; 393 break; 394 case INTEL_OUTPUT_EDP: 395 case INTEL_OUTPUT_DSI: 396 type = DISPLAY_TYPE_INTERNAL_FLAT_PANEL; 397 break; 398 default: 399 WARN_ONCE(1, "unsupported intel_encoder type %d\n", 400 intel_encoder->type); 401 return -EINVAL; 402 } 403 404 parm |= type << (16 + port * 3); 405 406 return swsci(dev_priv, SWSCI_SBCB_DISPLAY_POWER_STATE, parm, NULL); 407 } 408 409 static const struct { 410 pci_power_t pci_power_state; 411 u32 parm; 412 } power_state_map[] = { 413 { PCI_D0, 0x00 }, 414 { PCI_D1, 0x01 }, 415 { PCI_D2, 0x02 }, 416 { PCI_D3hot, 0x04 }, 417 { PCI_D3cold, 0x04 }, 418 }; 419 420 int intel_opregion_notify_adapter(struct drm_i915_private *dev_priv, 421 pci_power_t state) 422 { 423 int i; 424 425 if (!HAS_DDI(dev_priv)) 426 return 0; 427 428 for (i = 0; i < ARRAY_SIZE(power_state_map); i++) { 429 if (state == power_state_map[i].pci_power_state) 430 return swsci(dev_priv, SWSCI_SBCB_ADAPTER_POWER_STATE, 431 power_state_map[i].parm, NULL); 432 } 433 434 return -EINVAL; 435 } 436 437 static u32 asle_set_backlight(struct drm_i915_private *dev_priv, u32 bclp) 438 { 439 struct intel_connector *connector; 440 struct opregion_asle *asle = dev_priv->opregion.asle; 441 struct drm_device *dev = &dev_priv->drm; 442 443 DRM_DEBUG_DRIVER("bclp = 0x%08x\n", bclp); 444 445 #ifndef __DragonFly__ 446 if (acpi_video_get_backlight_type() == acpi_backlight_native) { 447 DRM_DEBUG_KMS("opregion backlight request ignored\n"); 448 return 0; 449 } 450 #endif 451 452 if (!(bclp & ASLE_BCLP_VALID)) 453 return ASLC_BACKLIGHT_FAILED; 454 455 bclp &= ASLE_BCLP_MSK; 456 if (bclp > 255) 457 return ASLC_BACKLIGHT_FAILED; 458 459 drm_modeset_lock(&dev->mode_config.connection_mutex, NULL); 460 461 /* 462 * Update backlight on all connectors that support backlight (usually 463 * only one). 464 */ 465 DRM_DEBUG_KMS("updating opregion backlight %d/255\n", bclp); 466 for_each_intel_connector(dev, connector) 467 intel_panel_set_backlight_acpi(connector, bclp, 255); 468 asle->cblv = DIV_ROUND_UP(bclp * 100, 255) | ASLE_CBLV_VALID; 469 470 drm_modeset_unlock(&dev->mode_config.connection_mutex); 471 472 473 return 0; 474 } 475 476 static u32 asle_set_als_illum(struct drm_i915_private *dev_priv, u32 alsi) 477 { 478 /* alsi is the current ALS reading in lux. 0 indicates below sensor 479 range, 0xffff indicates above sensor range. 1-0xfffe are valid */ 480 DRM_DEBUG_DRIVER("Illum is not supported\n"); 481 return ASLC_ALS_ILLUM_FAILED; 482 } 483 484 static u32 asle_set_pwm_freq(struct drm_i915_private *dev_priv, u32 pfmb) 485 { 486 DRM_DEBUG_DRIVER("PWM freq is not supported\n"); 487 return ASLC_PWM_FREQ_FAILED; 488 } 489 490 static u32 asle_set_pfit(struct drm_i915_private *dev_priv, u32 pfit) 491 { 492 /* Panel fitting is currently controlled by the X code, so this is a 493 noop until modesetting support works fully */ 494 DRM_DEBUG_DRIVER("Pfit is not supported\n"); 495 return ASLC_PFIT_FAILED; 496 } 497 498 static u32 asle_set_supported_rotation_angles(struct drm_i915_private *dev_priv, u32 srot) 499 { 500 DRM_DEBUG_DRIVER("SROT is not supported\n"); 501 return ASLC_ROTATION_ANGLES_FAILED; 502 } 503 504 static u32 asle_set_button_array(struct drm_i915_private *dev_priv, u32 iuer) 505 { 506 if (!iuer) 507 DRM_DEBUG_DRIVER("Button array event is not supported (nothing)\n"); 508 if (iuer & ASLE_IUER_ROTATION_LOCK_BTN) 509 DRM_DEBUG_DRIVER("Button array event is not supported (rotation lock)\n"); 510 if (iuer & ASLE_IUER_VOLUME_DOWN_BTN) 511 DRM_DEBUG_DRIVER("Button array event is not supported (volume down)\n"); 512 if (iuer & ASLE_IUER_VOLUME_UP_BTN) 513 DRM_DEBUG_DRIVER("Button array event is not supported (volume up)\n"); 514 if (iuer & ASLE_IUER_WINDOWS_BTN) 515 DRM_DEBUG_DRIVER("Button array event is not supported (windows)\n"); 516 if (iuer & ASLE_IUER_POWER_BTN) 517 DRM_DEBUG_DRIVER("Button array event is not supported (power)\n"); 518 519 return ASLC_BUTTON_ARRAY_FAILED; 520 } 521 522 static u32 asle_set_convertible(struct drm_i915_private *dev_priv, u32 iuer) 523 { 524 if (iuer & ASLE_IUER_CONVERTIBLE) 525 DRM_DEBUG_DRIVER("Convertible is not supported (clamshell)\n"); 526 else 527 DRM_DEBUG_DRIVER("Convertible is not supported (slate)\n"); 528 529 return ASLC_CONVERTIBLE_FAILED; 530 } 531 532 static u32 asle_set_docking(struct drm_i915_private *dev_priv, u32 iuer) 533 { 534 if (iuer & ASLE_IUER_DOCKING) 535 DRM_DEBUG_DRIVER("Docking is not supported (docked)\n"); 536 else 537 DRM_DEBUG_DRIVER("Docking is not supported (undocked)\n"); 538 539 return ASLC_DOCKING_FAILED; 540 } 541 542 static u32 asle_isct_state(struct drm_i915_private *dev_priv) 543 { 544 DRM_DEBUG_DRIVER("ISCT is not supported\n"); 545 return ASLC_ISCT_STATE_FAILED; 546 } 547 548 static void asle_work(struct work_struct *work) 549 { 550 struct intel_opregion *opregion = 551 container_of(work, struct intel_opregion, asle_work); 552 struct drm_i915_private *dev_priv = 553 container_of(opregion, struct drm_i915_private, opregion); 554 struct opregion_asle *asle = dev_priv->opregion.asle; 555 u32 aslc_stat = 0; 556 u32 aslc_req; 557 558 if (!asle) 559 return; 560 561 aslc_req = asle->aslc; 562 563 if (!(aslc_req & ASLC_REQ_MSK)) { 564 DRM_DEBUG_DRIVER("No request on ASLC interrupt 0x%08x\n", 565 aslc_req); 566 return; 567 } 568 569 if (aslc_req & ASLC_SET_ALS_ILLUM) 570 aslc_stat |= asle_set_als_illum(dev_priv, asle->alsi); 571 572 if (aslc_req & ASLC_SET_BACKLIGHT) 573 aslc_stat |= asle_set_backlight(dev_priv, asle->bclp); 574 575 if (aslc_req & ASLC_SET_PFIT) 576 aslc_stat |= asle_set_pfit(dev_priv, asle->pfit); 577 578 if (aslc_req & ASLC_SET_PWM_FREQ) 579 aslc_stat |= asle_set_pwm_freq(dev_priv, asle->pfmb); 580 581 if (aslc_req & ASLC_SUPPORTED_ROTATION_ANGLES) 582 aslc_stat |= asle_set_supported_rotation_angles(dev_priv, 583 asle->srot); 584 585 if (aslc_req & ASLC_BUTTON_ARRAY) 586 aslc_stat |= asle_set_button_array(dev_priv, asle->iuer); 587 588 if (aslc_req & ASLC_CONVERTIBLE_INDICATOR) 589 aslc_stat |= asle_set_convertible(dev_priv, asle->iuer); 590 591 if (aslc_req & ASLC_DOCKING_INDICATOR) 592 aslc_stat |= asle_set_docking(dev_priv, asle->iuer); 593 594 if (aslc_req & ASLC_ISCT_STATE_CHANGE) 595 aslc_stat |= asle_isct_state(dev_priv); 596 597 asle->aslc = aslc_stat; 598 } 599 600 void intel_opregion_asle_intr(struct drm_i915_private *dev_priv) 601 { 602 if (dev_priv->opregion.asle) 603 schedule_work(&dev_priv->opregion.asle_work); 604 } 605 606 #define ACPI_EV_DISPLAY_SWITCH (1<<0) 607 #define ACPI_EV_LID (1<<1) 608 #define ACPI_EV_DOCK (1<<2) 609 610 static struct intel_opregion *system_opregion; 611 612 #if 0 613 static int intel_opregion_video_event(struct notifier_block *nb, 614 unsigned long val, void *data) 615 { 616 /* The only video events relevant to opregion are 0x80. These indicate 617 either a docking event, lid switch or display switch request. In 618 Linux, these are handled by the dock, button and video drivers. 619 */ 620 621 struct acpi_bus_event *event = data; 622 struct opregion_acpi *acpi; 623 int ret = NOTIFY_OK; 624 625 if (strcmp(event->device_class, ACPI_VIDEO_CLASS) != 0) 626 return NOTIFY_DONE; 627 628 if (!system_opregion) 629 return NOTIFY_DONE; 630 631 acpi = system_opregion->acpi; 632 633 if (event->type == 0x80 && ((acpi->cevt & 1) == 0)) 634 ret = NOTIFY_BAD; 635 636 acpi->csts = 0; 637 638 return ret; 639 } 640 641 static struct notifier_block intel_opregion_notifier = { 642 .notifier_call = intel_opregion_video_event, 643 }; 644 #endif 645 646 /* 647 * Initialise the DIDL field in opregion. This passes a list of devices to 648 * the firmware. Values are defined by section B.4.2 of the ACPI specification 649 * (version 3) 650 */ 651 652 static u32 get_did(struct intel_opregion *opregion, int i) 653 { 654 u32 did; 655 656 if (i < ARRAY_SIZE(opregion->acpi->didl)) { 657 did = opregion->acpi->didl[i]; 658 } else { 659 i -= ARRAY_SIZE(opregion->acpi->didl); 660 661 if (WARN_ON(i >= ARRAY_SIZE(opregion->acpi->did2))) 662 return 0; 663 664 did = opregion->acpi->did2[i]; 665 } 666 667 return did; 668 } 669 670 static void set_did(struct intel_opregion *opregion, int i, u32 val) 671 { 672 if (i < ARRAY_SIZE(opregion->acpi->didl)) { 673 opregion->acpi->didl[i] = val; 674 } else { 675 i -= ARRAY_SIZE(opregion->acpi->didl); 676 677 if (WARN_ON(i >= ARRAY_SIZE(opregion->acpi->did2))) 678 return; 679 680 opregion->acpi->did2[i] = val; 681 } 682 } 683 684 static u32 acpi_display_type(struct drm_connector *connector) 685 { 686 u32 display_type; 687 688 switch (connector->connector_type) { 689 case DRM_MODE_CONNECTOR_VGA: 690 case DRM_MODE_CONNECTOR_DVIA: 691 display_type = ACPI_DISPLAY_TYPE_VGA; 692 break; 693 case DRM_MODE_CONNECTOR_Composite: 694 case DRM_MODE_CONNECTOR_SVIDEO: 695 case DRM_MODE_CONNECTOR_Component: 696 case DRM_MODE_CONNECTOR_9PinDIN: 697 case DRM_MODE_CONNECTOR_TV: 698 display_type = ACPI_DISPLAY_TYPE_TV; 699 break; 700 case DRM_MODE_CONNECTOR_DVII: 701 case DRM_MODE_CONNECTOR_DVID: 702 case DRM_MODE_CONNECTOR_DisplayPort: 703 case DRM_MODE_CONNECTOR_HDMIA: 704 case DRM_MODE_CONNECTOR_HDMIB: 705 display_type = ACPI_DISPLAY_TYPE_EXTERNAL_DIGITAL; 706 break; 707 case DRM_MODE_CONNECTOR_LVDS: 708 case DRM_MODE_CONNECTOR_eDP: 709 case DRM_MODE_CONNECTOR_DSI: 710 display_type = ACPI_DISPLAY_TYPE_INTERNAL_DIGITAL; 711 break; 712 case DRM_MODE_CONNECTOR_Unknown: 713 case DRM_MODE_CONNECTOR_VIRTUAL: 714 display_type = ACPI_DISPLAY_TYPE_OTHER; 715 break; 716 default: 717 MISSING_CASE(connector->connector_type); 718 display_type = ACPI_DISPLAY_TYPE_OTHER; 719 break; 720 } 721 722 return display_type; 723 } 724 725 static void intel_didl_outputs(struct drm_i915_private *dev_priv) 726 { 727 struct intel_opregion *opregion = &dev_priv->opregion; 728 struct pci_dev *pdev = dev_priv->drm.pdev; 729 struct drm_connector *connector; 730 ACPI_HANDLE handle, acpi_cdev, acpi_video_bus; 731 u32 device_id; 732 ACPI_STATUS status; 733 u32 temp, max_outputs; 734 int i = 0; 735 736 handle = acpi_get_handle(pdev->dev.bsddev); 737 if (!handle) 738 return; 739 740 if (acpi_is_video_device(handle)) 741 acpi_video_bus = handle; 742 else { 743 acpi_cdev = NULL; 744 acpi_video_bus = NULL; 745 while (AcpiGetNextObject(ACPI_TYPE_DEVICE, handle, acpi_cdev, 746 &acpi_cdev) != AE_NOT_FOUND) { 747 if (acpi_is_video_device(acpi_cdev)) { 748 acpi_video_bus = acpi_cdev; 749 break; 750 } 751 } 752 } 753 754 if (!acpi_video_bus) { 755 DRM_DEBUG_KMS("No ACPI video bus found\n"); 756 return; 757 } 758 759 /* 760 * In theory, did2, the extended didl, gets added at opregion version 761 * 3.0. In practice, however, we're supposed to set it for earlier 762 * versions as well, since a BIOS that doesn't understand did2 should 763 * not look at it anyway. Use a variable so we can tweak this if a need 764 * arises later. 765 */ 766 max_outputs = ARRAY_SIZE(opregion->acpi->didl) + 767 ARRAY_SIZE(opregion->acpi->did2); 768 769 #ifdef __DragonFly__ 770 acpi_cdev = NULL; 771 #endif 772 while (AcpiGetNextObject(ACPI_TYPE_DEVICE, acpi_video_bus, acpi_cdev, 773 &acpi_cdev) != AE_NOT_FOUND) { 774 if (i >= max_outputs) { 775 DRM_DEBUG_KMS("More than %u outputs detected via ACPI\n", 776 max_outputs); 777 return; 778 } 779 status = acpi_GetInteger(acpi_cdev, "_ADR", &device_id); 780 if (ACPI_SUCCESS(status)) { 781 if (!device_id) 782 goto blind_set; 783 set_did(opregion, i++, (u32)(device_id & 0x0f0f)); 784 } 785 } 786 787 end: 788 DRM_DEBUG_KMS("%d outputs detected\n", i); 789 790 /* If fewer than max outputs, the list must be null terminated */ 791 if (i < max_outputs) 792 set_did(opregion, i, 0); 793 return; 794 795 blind_set: 796 i = 0; 797 list_for_each_entry(connector, 798 &dev_priv->drm.mode_config.connector_list, head) { 799 int display_type = acpi_display_type(connector); 800 if (i >= max_outputs) { 801 DRM_DEBUG_KMS("More than %u outputs in connector list\n", 802 max_outputs); 803 return; 804 } 805 806 temp = get_did(opregion, i); 807 set_did(opregion, i, temp | (1 << 31) | display_type | i); 808 i++; 809 } 810 goto end; 811 } 812 813 static void intel_setup_cadls(struct drm_i915_private *dev_priv) 814 { 815 struct intel_opregion *opregion = &dev_priv->opregion; 816 int i = 0; 817 u32 disp_id; 818 819 /* Initialize the CADL field by duplicating the DIDL values. 820 * Technically, this is not always correct as display outputs may exist, 821 * but not active. This initialization is necessary for some Clevo 822 * laptops that check this field before processing the brightness and 823 * display switching hotkeys. Just like DIDL, CADL is NULL-terminated if 824 * there are less than eight devices. */ 825 do { 826 disp_id = get_did(opregion, i); 827 opregion->acpi->cadl[i] = disp_id; 828 } while (++i < 8 && disp_id != 0); 829 } 830 831 void intel_opregion_register(struct drm_i915_private *dev_priv) 832 { 833 struct intel_opregion *opregion = &dev_priv->opregion; 834 835 if (!opregion->header) 836 return; 837 838 if (opregion->acpi) { 839 intel_didl_outputs(dev_priv); 840 intel_setup_cadls(dev_priv); 841 842 /* Notify BIOS we are ready to handle ACPI video ext notifs. 843 * Right now, all the events are handled by the ACPI video module. 844 * We don't actually need to do anything with them. */ 845 opregion->acpi->csts = 0; 846 opregion->acpi->drdy = 1; 847 848 system_opregion = opregion; 849 } 850 851 if (opregion->asle) { 852 opregion->asle->tche = ASLE_TCHE_BLC_EN; 853 opregion->asle->ardy = ASLE_ARDY_READY; 854 } 855 } 856 857 void intel_opregion_unregister(struct drm_i915_private *dev_priv) 858 { 859 struct intel_opregion *opregion = &dev_priv->opregion; 860 861 if (!opregion->header) 862 return; 863 864 if (opregion->asle) 865 opregion->asle->ardy = ASLE_ARDY_NOT_READY; 866 867 cancel_work_sync(&dev_priv->opregion.asle_work); 868 869 if (opregion->acpi) { 870 opregion->acpi->drdy = 0; 871 872 system_opregion = NULL; 873 } 874 875 /* just clear all opregion memory pointers now */ 876 iounmap(opregion->header); 877 if (opregion->rvda) { 878 iounmap(opregion->rvda); 879 opregion->rvda = NULL; 880 } 881 opregion->header = NULL; 882 opregion->acpi = NULL; 883 opregion->swsci = NULL; 884 opregion->asle = NULL; 885 opregion->vbt = NULL; 886 opregion->lid_state = NULL; 887 } 888 889 static void swsci_setup(struct drm_i915_private *dev_priv) 890 { 891 struct intel_opregion *opregion = &dev_priv->opregion; 892 bool requested_callbacks = false; 893 u32 tmp; 894 895 /* Sub-function code 0 is okay, let's allow them. */ 896 opregion->swsci_gbda_sub_functions = 1; 897 opregion->swsci_sbcb_sub_functions = 1; 898 899 /* We use GBDA to ask for supported GBDA calls. */ 900 if (swsci(dev_priv, SWSCI_GBDA_SUPPORTED_CALLS, 0, &tmp) == 0) { 901 /* make the bits match the sub-function codes */ 902 tmp <<= 1; 903 opregion->swsci_gbda_sub_functions |= tmp; 904 } 905 906 /* 907 * We also use GBDA to ask for _requested_ SBCB callbacks. The driver 908 * must not call interfaces that are not specifically requested by the 909 * bios. 910 */ 911 if (swsci(dev_priv, SWSCI_GBDA_REQUESTED_CALLBACKS, 0, &tmp) == 0) { 912 /* here, the bits already match sub-function codes */ 913 opregion->swsci_sbcb_sub_functions |= tmp; 914 requested_callbacks = true; 915 } 916 917 /* 918 * But we use SBCB to ask for _supported_ SBCB calls. This does not mean 919 * the callback is _requested_. But we still can't call interfaces that 920 * are not requested. 921 */ 922 if (swsci(dev_priv, SWSCI_SBCB_SUPPORTED_CALLBACKS, 0, &tmp) == 0) { 923 /* make the bits match the sub-function codes */ 924 u32 low = tmp & 0x7ff; 925 u32 high = tmp & ~0xfff; /* bit 11 is reserved */ 926 tmp = (high << 4) | (low << 1) | 1; 927 928 /* best guess what to do with supported wrt requested */ 929 if (requested_callbacks) { 930 u32 req = opregion->swsci_sbcb_sub_functions; 931 if ((req & tmp) != req) 932 DRM_DEBUG_DRIVER("SWSCI BIOS requested (%08x) SBCB callbacks that are not supported (%08x)\n", req, tmp); 933 /* XXX: for now, trust the requested callbacks */ 934 /* opregion->swsci_sbcb_sub_functions &= tmp; */ 935 } else { 936 opregion->swsci_sbcb_sub_functions |= tmp; 937 } 938 } 939 940 DRM_DEBUG_DRIVER("SWSCI GBDA callbacks %08x, SBCB callbacks %08x\n", 941 opregion->swsci_gbda_sub_functions, 942 opregion->swsci_sbcb_sub_functions); 943 } 944 945 static int intel_no_opregion_vbt_callback(const struct dmi_system_id *id) 946 { 947 DRM_DEBUG_KMS("Falling back to manually reading VBT from " 948 "VBIOS ROM for %s\n", id->ident); 949 return 1; 950 } 951 952 static const struct dmi_system_id intel_no_opregion_vbt[] = { 953 { 954 .callback = intel_no_opregion_vbt_callback, 955 .ident = "ThinkCentre A57", 956 .matches = { 957 DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), 958 DMI_MATCH(DMI_PRODUCT_NAME, "97027RG"), 959 }, 960 }, 961 { } 962 }; 963 964 int intel_opregion_setup(struct drm_i915_private *dev_priv) 965 { 966 struct intel_opregion *opregion = &dev_priv->opregion; 967 struct pci_dev *pdev = dev_priv->drm.pdev; 968 u32 asls, mboxes; 969 char buf[sizeof(OPREGION_SIGNATURE)]; 970 int err = 0; 971 char *base; 972 973 BUILD_BUG_ON(sizeof(struct opregion_header) != 0x100); 974 BUILD_BUG_ON(sizeof(struct opregion_acpi) != 0x100); 975 BUILD_BUG_ON(sizeof(struct opregion_swsci) != 0x100); 976 BUILD_BUG_ON(sizeof(struct opregion_asle) != 0x100); 977 BUILD_BUG_ON(sizeof(struct opregion_asle_ext) != 0x400); 978 979 pci_read_config_dword(pdev, ASLS, &asls); 980 DRM_DEBUG_DRIVER("graphic opregion physical addr: 0x%x\n", asls); 981 if (asls == 0) { 982 DRM_DEBUG_DRIVER("ACPI OpRegion not supported!\n"); 983 return -ENOTSUP; 984 } 985 986 INIT_WORK(&opregion->asle_work, asle_work); 987 988 base = (void *)pmap_mapbios(asls, OPREGION_SIZE); 989 if (!base) 990 return -ENOMEM; 991 992 memcpy(buf, base, sizeof(buf)); 993 994 if (memcmp(buf, OPREGION_SIGNATURE, 16)) { 995 DRM_DEBUG_DRIVER("opregion signature mismatch\n"); 996 err = -EINVAL; 997 goto err_out; 998 } 999 opregion->header = (struct opregion_header *)base; 1000 1001 opregion->lid_state = (u32 *)(base + ACPI_CLID); 1002 1003 mboxes = opregion->header->mboxes; 1004 if (mboxes & MBOX_ACPI) { 1005 DRM_DEBUG_DRIVER("Public ACPI methods supported\n"); 1006 opregion->acpi = (struct opregion_acpi *)(base + OPREGION_ACPI_OFFSET); 1007 } 1008 1009 if (mboxes & MBOX_SWSCI) { 1010 DRM_DEBUG_DRIVER("SWSCI supported\n"); 1011 opregion->swsci = (struct opregion_swsci *)(base + OPREGION_SWSCI_OFFSET); 1012 swsci_setup(dev_priv); 1013 } 1014 1015 if (mboxes & MBOX_ASLE) { 1016 DRM_DEBUG_DRIVER("ASLE supported\n"); 1017 opregion->asle = (struct opregion_asle *)(base + OPREGION_ASLE_OFFSET); 1018 1019 opregion->asle->ardy = ASLE_ARDY_NOT_READY; 1020 } 1021 1022 if (mboxes & MBOX_ASLE_EXT) 1023 DRM_DEBUG_DRIVER("ASLE extension supported\n"); 1024 1025 if (!dmi_check_system(intel_no_opregion_vbt)) { 1026 const void *vbt = NULL; 1027 u32 vbt_size = 0; 1028 1029 if (opregion->header->opregion_ver >= 2 && opregion->asle && 1030 opregion->asle->rvda && opregion->asle->rvds) { 1031 opregion->rvda = pmap_mapbios(opregion->asle->rvda, 1032 opregion->asle->rvds); 1033 vbt = opregion->rvda; 1034 vbt_size = opregion->asle->rvds; 1035 } 1036 1037 if (intel_bios_is_valid_vbt(vbt, vbt_size)) { 1038 DRM_DEBUG_KMS("Found valid VBT in ACPI OpRegion (RVDA)\n"); 1039 opregion->vbt = vbt; 1040 opregion->vbt_size = vbt_size; 1041 } else { 1042 vbt = base + OPREGION_VBT_OFFSET; 1043 vbt_size = OPREGION_ASLE_EXT_OFFSET - OPREGION_VBT_OFFSET; 1044 if (intel_bios_is_valid_vbt(vbt, vbt_size)) { 1045 DRM_DEBUG_KMS("Found valid VBT in ACPI OpRegion (Mailbox #4)\n"); 1046 opregion->vbt = vbt; 1047 opregion->vbt_size = vbt_size; 1048 } 1049 } 1050 } 1051 1052 return 0; 1053 1054 err_out: 1055 iounmap(base); 1056 return err; 1057 } 1058 1059 static int intel_use_opregion_panel_type_callback(const struct dmi_system_id *id) 1060 { 1061 DRM_INFO("Using panel type from OpRegion on %s\n", id->ident); 1062 return 1; 1063 } 1064 1065 static const struct dmi_system_id intel_use_opregion_panel_type[] = { 1066 { 1067 .callback = intel_use_opregion_panel_type_callback, 1068 .ident = "Conrac GmbH IX45GM2", 1069 .matches = {DMI_MATCH(DMI_SYS_VENDOR, "Conrac GmbH"), 1070 DMI_MATCH(DMI_PRODUCT_NAME, "IX45GM2"), 1071 }, 1072 }, 1073 { } 1074 }; 1075 1076 int 1077 intel_opregion_get_panel_type(struct drm_i915_private *dev_priv) 1078 { 1079 u32 panel_details; 1080 int ret; 1081 1082 ret = swsci(dev_priv, SWSCI_GBDA_PANEL_DETAILS, 0x0, &panel_details); 1083 if (ret) { 1084 DRM_DEBUG_KMS("Failed to get panel details from OpRegion (%d)\n", 1085 ret); 1086 return ret; 1087 } 1088 1089 ret = (panel_details >> 8) & 0xff; 1090 if (ret > 0x10) { 1091 DRM_DEBUG_KMS("Invalid OpRegion panel type 0x%x\n", ret); 1092 return -EINVAL; 1093 } 1094 1095 /* fall back to VBT panel type? */ 1096 if (ret == 0x0) { 1097 DRM_DEBUG_KMS("No panel type in OpRegion\n"); 1098 return -ENODEV; 1099 } 1100 1101 /* 1102 * So far we know that some machined must use it, others must not use it. 1103 * There doesn't seem to be any way to determine which way to go, except 1104 * via a quirk list :( 1105 */ 1106 if (!dmi_check_system(intel_use_opregion_panel_type)) { 1107 DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1); 1108 return -ENODEV; 1109 } 1110 1111 /* 1112 * FIXME On Dell XPS 13 9350 the OpRegion panel type (0) gives us 1113 * low vswing for eDP, whereas the VBT panel type (2) gives us normal 1114 * vswing instead. Low vswing results in some display flickers, so 1115 * let's simply ignore the OpRegion panel type on SKL for now. 1116 */ 1117 if (IS_SKYLAKE(dev_priv)) { 1118 DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1); 1119 return -ENODEV; 1120 } 1121 1122 /* 1123 * FIXME On Dell XPS 13 9350 the OpRegion panel type (0) gives us 1124 * low vswing for eDP, whereas the VBT panel type (2) gives us normal 1125 * vswing instead. Low vswing results in some display flickers, so 1126 * let's simply ignore the OpRegion panel type on SKL for now. 1127 */ 1128 if (IS_SKYLAKE(dev_priv)) { 1129 DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1); 1130 return -ENODEV; 1131 } 1132 1133 return ret - 1; 1134 } 1135