1 /* 2 * Copyright 2008 Intel Corporation <hong.liu@intel.com> 3 * Copyright 2008 Red Hat <mjg@redhat.com> 4 * 5 * Permission is hereby granted, free of charge, to any person obtaining 6 * a copy of this software and associated documentation files (the 7 * "Software"), to deal in the Software without restriction, including 8 * without limitation the rights to use, copy, modify, merge, publish, 9 * distribute, sub license, and/or sell copies of the Software, and to 10 * permit persons to whom the Software is furnished to do so, subject to 11 * the following conditions: 12 * 13 * The above copyright notice and this permission notice (including the 14 * next paragraph) shall be included in all copies or substantial 15 * portions of the Software. 16 * 17 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, 18 * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF 19 * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND 20 * NON-INFRINGEMENT. IN NO EVENT SHALL INTEL AND/OR ITS SUPPLIERS BE 21 * LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN 22 * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN 23 * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE 24 * SOFTWARE. 25 * 26 */ 27 28 #include <linux/dmi.h> 29 30 #include <drm/drmP.h> 31 #include <drm/i915_drm.h> 32 #include "i915_drv.h" 33 #include "intel_drv.h" 34 35 #include <contrib/dev/acpica/source/include/acpi.h> 36 #include <contrib/dev/acpica/source/include/accommon.h> 37 #include <dev/acpica/acpivar.h> 38 39 #define OPREGION_HEADER_OFFSET 0 40 #define OPREGION_ACPI_OFFSET 0x100 41 #define ACPI_CLID 0x01ac /* current lid state indicator */ 42 #define ACPI_CDCK 0x01b0 /* current docking state indicator */ 43 #define OPREGION_SWSCI_OFFSET 0x200 44 #define OPREGION_ASLE_OFFSET 0x300 45 #define OPREGION_VBT_OFFSET 0x400 46 #define OPREGION_ASLE_EXT_OFFSET 0x1C00 47 48 #define OPREGION_SIGNATURE "IntelGraphicsMem" 49 #define MBOX_ACPI (1<<0) 50 #define MBOX_SWSCI (1<<1) 51 #define MBOX_ASLE (1<<2) 52 #define MBOX_ASLE_EXT (1<<4) 53 54 struct opregion_header { 55 u8 signature[16]; 56 u32 size; 57 u32 opregion_ver; 58 u8 bios_ver[32]; 59 u8 vbios_ver[16]; 60 u8 driver_ver[16]; 61 u32 mboxes; 62 u32 driver_model; 63 u32 pcon; 64 u8 dver[32]; 65 u8 rsvd[124]; 66 } __packed; 67 68 /* OpRegion mailbox #1: public ACPI methods */ 69 struct opregion_acpi { 70 u32 drdy; /* driver readiness */ 71 u32 csts; /* notification status */ 72 u32 cevt; /* current event */ 73 u8 rsvd1[20]; 74 u32 didl[8]; /* supported display devices ID list */ 75 u32 cpdl[8]; /* currently presented display list */ 76 u32 cadl[8]; /* currently active display list */ 77 u32 nadl[8]; /* next active devices list */ 78 u32 aslp; /* ASL sleep time-out */ 79 u32 tidx; /* toggle table index */ 80 u32 chpd; /* current hotplug enable indicator */ 81 u32 clid; /* current lid state*/ 82 u32 cdck; /* current docking state */ 83 u32 sxsw; /* Sx state resume */ 84 u32 evts; /* ASL supported events */ 85 u32 cnot; /* current OS notification */ 86 u32 nrdy; /* driver status */ 87 u32 did2[7]; /* extended supported display devices ID list */ 88 u32 cpd2[7]; /* extended attached display devices list */ 89 u8 rsvd2[4]; 90 } __packed; 91 92 /* OpRegion mailbox #2: SWSCI */ 93 struct opregion_swsci { 94 u32 scic; /* SWSCI command|status|data */ 95 u32 parm; /* command parameters */ 96 u32 dslp; /* driver sleep time-out */ 97 u8 rsvd[244]; 98 } __packed; 99 100 /* OpRegion mailbox #3: ASLE */ 101 struct opregion_asle { 102 u32 ardy; /* driver readiness */ 103 u32 aslc; /* ASLE interrupt command */ 104 u32 tche; /* technology enabled indicator */ 105 u32 alsi; /* current ALS illuminance reading */ 106 u32 bclp; /* backlight brightness to set */ 107 u32 pfit; /* panel fitting state */ 108 u32 cblv; /* current brightness level */ 109 u16 bclm[20]; /* backlight level duty cycle mapping table */ 110 u32 cpfm; /* current panel fitting mode */ 111 u32 epfm; /* enabled panel fitting modes */ 112 u8 plut[74]; /* panel LUT and identifier */ 113 u32 pfmb; /* PWM freq and min brightness */ 114 u32 cddv; /* color correction default values */ 115 u32 pcft; /* power conservation features */ 116 u32 srot; /* supported rotation angles */ 117 u32 iuer; /* IUER events */ 118 u64 fdss; 119 u32 fdsp; 120 u32 stat; 121 u64 rvda; /* Physical address of raw vbt data */ 122 u32 rvds; /* Size of raw vbt data */ 123 u8 rsvd[58]; 124 } __packed; 125 126 /* OpRegion mailbox #5: ASLE ext */ 127 struct opregion_asle_ext { 128 u32 phed; /* Panel Header */ 129 u8 bddc[256]; /* Panel EDID */ 130 u8 rsvd[764]; 131 } __packed; 132 133 /* Driver readiness indicator */ 134 #define ASLE_ARDY_READY (1 << 0) 135 #define ASLE_ARDY_NOT_READY (0 << 0) 136 137 /* ASLE Interrupt Command (ASLC) bits */ 138 #define ASLC_SET_ALS_ILLUM (1 << 0) 139 #define ASLC_SET_BACKLIGHT (1 << 1) 140 #define ASLC_SET_PFIT (1 << 2) 141 #define ASLC_SET_PWM_FREQ (1 << 3) 142 #define ASLC_SUPPORTED_ROTATION_ANGLES (1 << 4) 143 #define ASLC_BUTTON_ARRAY (1 << 5) 144 #define ASLC_CONVERTIBLE_INDICATOR (1 << 6) 145 #define ASLC_DOCKING_INDICATOR (1 << 7) 146 #define ASLC_ISCT_STATE_CHANGE (1 << 8) 147 #define ASLC_REQ_MSK 0x1ff 148 /* response bits */ 149 #define ASLC_ALS_ILLUM_FAILED (1 << 10) 150 #define ASLC_BACKLIGHT_FAILED (1 << 12) 151 #define ASLC_PFIT_FAILED (1 << 14) 152 #define ASLC_PWM_FREQ_FAILED (1 << 16) 153 #define ASLC_ROTATION_ANGLES_FAILED (1 << 18) 154 #define ASLC_BUTTON_ARRAY_FAILED (1 << 20) 155 #define ASLC_CONVERTIBLE_FAILED (1 << 22) 156 #define ASLC_DOCKING_FAILED (1 << 24) 157 #define ASLC_ISCT_STATE_FAILED (1 << 26) 158 159 /* Technology enabled indicator */ 160 #define ASLE_TCHE_ALS_EN (1 << 0) 161 #define ASLE_TCHE_BLC_EN (1 << 1) 162 #define ASLE_TCHE_PFIT_EN (1 << 2) 163 #define ASLE_TCHE_PFMB_EN (1 << 3) 164 165 /* ASLE backlight brightness to set */ 166 #define ASLE_BCLP_VALID (1<<31) 167 #define ASLE_BCLP_MSK (~(1<<31)) 168 169 /* ASLE panel fitting request */ 170 #define ASLE_PFIT_VALID (1<<31) 171 #define ASLE_PFIT_CENTER (1<<0) 172 #define ASLE_PFIT_STRETCH_TEXT (1<<1) 173 #define ASLE_PFIT_STRETCH_GFX (1<<2) 174 175 /* PWM frequency and minimum brightness */ 176 #define ASLE_PFMB_BRIGHTNESS_MASK (0xff) 177 #define ASLE_PFMB_BRIGHTNESS_VALID (1<<8) 178 #define ASLE_PFMB_PWM_MASK (0x7ffffe00) 179 #define ASLE_PFMB_PWM_VALID (1<<31) 180 181 #define ASLE_CBLV_VALID (1<<31) 182 183 /* IUER */ 184 #define ASLE_IUER_DOCKING (1 << 7) 185 #define ASLE_IUER_CONVERTIBLE (1 << 6) 186 #define ASLE_IUER_ROTATION_LOCK_BTN (1 << 4) 187 #define ASLE_IUER_VOLUME_DOWN_BTN (1 << 3) 188 #define ASLE_IUER_VOLUME_UP_BTN (1 << 2) 189 #define ASLE_IUER_WINDOWS_BTN (1 << 1) 190 #define ASLE_IUER_POWER_BTN (1 << 0) 191 192 /* Software System Control Interrupt (SWSCI) */ 193 #define SWSCI_SCIC_INDICATOR (1 << 0) 194 #define SWSCI_SCIC_MAIN_FUNCTION_SHIFT 1 195 #define SWSCI_SCIC_MAIN_FUNCTION_MASK (0xf << 1) 196 #define SWSCI_SCIC_SUB_FUNCTION_SHIFT 8 197 #define SWSCI_SCIC_SUB_FUNCTION_MASK (0xff << 8) 198 #define SWSCI_SCIC_EXIT_PARAMETER_SHIFT 8 199 #define SWSCI_SCIC_EXIT_PARAMETER_MASK (0xff << 8) 200 #define SWSCI_SCIC_EXIT_STATUS_SHIFT 5 201 #define SWSCI_SCIC_EXIT_STATUS_MASK (7 << 5) 202 #define SWSCI_SCIC_EXIT_STATUS_SUCCESS 1 203 204 #define SWSCI_FUNCTION_CODE(main, sub) \ 205 ((main) << SWSCI_SCIC_MAIN_FUNCTION_SHIFT | \ 206 (sub) << SWSCI_SCIC_SUB_FUNCTION_SHIFT) 207 208 /* SWSCI: Get BIOS Data (GBDA) */ 209 #define SWSCI_GBDA 4 210 #define SWSCI_GBDA_SUPPORTED_CALLS SWSCI_FUNCTION_CODE(SWSCI_GBDA, 0) 211 #define SWSCI_GBDA_REQUESTED_CALLBACKS SWSCI_FUNCTION_CODE(SWSCI_GBDA, 1) 212 #define SWSCI_GBDA_BOOT_DISPLAY_PREF SWSCI_FUNCTION_CODE(SWSCI_GBDA, 4) 213 #define SWSCI_GBDA_PANEL_DETAILS SWSCI_FUNCTION_CODE(SWSCI_GBDA, 5) 214 #define SWSCI_GBDA_TV_STANDARD SWSCI_FUNCTION_CODE(SWSCI_GBDA, 6) 215 #define SWSCI_GBDA_INTERNAL_GRAPHICS SWSCI_FUNCTION_CODE(SWSCI_GBDA, 7) 216 #define SWSCI_GBDA_SPREAD_SPECTRUM SWSCI_FUNCTION_CODE(SWSCI_GBDA, 10) 217 218 /* SWSCI: System BIOS Callbacks (SBCB) */ 219 #define SWSCI_SBCB 6 220 #define SWSCI_SBCB_SUPPORTED_CALLBACKS SWSCI_FUNCTION_CODE(SWSCI_SBCB, 0) 221 #define SWSCI_SBCB_INIT_COMPLETION SWSCI_FUNCTION_CODE(SWSCI_SBCB, 1) 222 #define SWSCI_SBCB_PRE_HIRES_SET_MODE SWSCI_FUNCTION_CODE(SWSCI_SBCB, 3) 223 #define SWSCI_SBCB_POST_HIRES_SET_MODE SWSCI_FUNCTION_CODE(SWSCI_SBCB, 4) 224 #define SWSCI_SBCB_DISPLAY_SWITCH SWSCI_FUNCTION_CODE(SWSCI_SBCB, 5) 225 #define SWSCI_SBCB_SET_TV_FORMAT SWSCI_FUNCTION_CODE(SWSCI_SBCB, 6) 226 #define SWSCI_SBCB_ADAPTER_POWER_STATE SWSCI_FUNCTION_CODE(SWSCI_SBCB, 7) 227 #define SWSCI_SBCB_DISPLAY_POWER_STATE SWSCI_FUNCTION_CODE(SWSCI_SBCB, 8) 228 #define SWSCI_SBCB_SET_BOOT_DISPLAY SWSCI_FUNCTION_CODE(SWSCI_SBCB, 9) 229 #define SWSCI_SBCB_SET_PANEL_DETAILS SWSCI_FUNCTION_CODE(SWSCI_SBCB, 10) 230 #define SWSCI_SBCB_SET_INTERNAL_GFX SWSCI_FUNCTION_CODE(SWSCI_SBCB, 11) 231 #define SWSCI_SBCB_POST_HIRES_TO_DOS_FS SWSCI_FUNCTION_CODE(SWSCI_SBCB, 16) 232 #define SWSCI_SBCB_SUSPEND_RESUME SWSCI_FUNCTION_CODE(SWSCI_SBCB, 17) 233 #define SWSCI_SBCB_SET_SPREAD_SPECTRUM SWSCI_FUNCTION_CODE(SWSCI_SBCB, 18) 234 #define SWSCI_SBCB_POST_VBE_PM SWSCI_FUNCTION_CODE(SWSCI_SBCB, 19) 235 #define SWSCI_SBCB_ENABLE_DISABLE_AUDIO SWSCI_FUNCTION_CODE(SWSCI_SBCB, 21) 236 237 /* 238 * ACPI Specification, Revision 5.0, Appendix B.3.2 _DOD (Enumerate All Devices 239 * Attached to the Display Adapter). 240 */ 241 #define ACPI_DISPLAY_INDEX_SHIFT 0 242 #define ACPI_DISPLAY_INDEX_MASK (0xf << 0) 243 #define ACPI_DISPLAY_PORT_ATTACHMENT_SHIFT 4 244 #define ACPI_DISPLAY_PORT_ATTACHMENT_MASK (0xf << 4) 245 #define ACPI_DISPLAY_TYPE_SHIFT 8 246 #define ACPI_DISPLAY_TYPE_MASK (0xf << 8) 247 #define ACPI_DISPLAY_TYPE_OTHER (0 << 8) 248 #define ACPI_DISPLAY_TYPE_VGA (1 << 8) 249 #define ACPI_DISPLAY_TYPE_TV (2 << 8) 250 #define ACPI_DISPLAY_TYPE_EXTERNAL_DIGITAL (3 << 8) 251 #define ACPI_DISPLAY_TYPE_INTERNAL_DIGITAL (4 << 8) 252 #define ACPI_VENDOR_SPECIFIC_SHIFT 12 253 #define ACPI_VENDOR_SPECIFIC_MASK (0xf << 12) 254 #define ACPI_BIOS_CAN_DETECT (1 << 16) 255 #define ACPI_DEPENDS_ON_VGA (1 << 17) 256 #define ACPI_PIPE_ID_SHIFT 18 257 #define ACPI_PIPE_ID_MASK (7 << 18) 258 #define ACPI_DEVICE_ID_SCHEME (1 << 31) 259 260 #define MAX_DSLP 1500 261 262 static int swsci(struct drm_i915_private *dev_priv, 263 u32 function, u32 parm, u32 *parm_out) 264 { 265 struct opregion_swsci *swsci = dev_priv->opregion.swsci; 266 struct pci_dev *pdev = dev_priv->drm.pdev; 267 u32 main_function, sub_function, scic; 268 u16 swsci_val; 269 u32 dslp; 270 271 if (!swsci) 272 return -ENODEV; 273 274 main_function = (function & SWSCI_SCIC_MAIN_FUNCTION_MASK) >> 275 SWSCI_SCIC_MAIN_FUNCTION_SHIFT; 276 sub_function = (function & SWSCI_SCIC_SUB_FUNCTION_MASK) >> 277 SWSCI_SCIC_SUB_FUNCTION_SHIFT; 278 279 /* Check if we can call the function. See swsci_setup for details. */ 280 if (main_function == SWSCI_SBCB) { 281 if ((dev_priv->opregion.swsci_sbcb_sub_functions & 282 (1 << sub_function)) == 0) 283 return -EINVAL; 284 } else if (main_function == SWSCI_GBDA) { 285 if ((dev_priv->opregion.swsci_gbda_sub_functions & 286 (1 << sub_function)) == 0) 287 return -EINVAL; 288 } 289 290 /* Driver sleep timeout in ms. */ 291 dslp = swsci->dslp; 292 if (!dslp) { 293 /* The spec says 2ms should be the default, but it's too small 294 * for some machines. */ 295 dslp = 50; 296 } else if (dslp > MAX_DSLP) { 297 /* Hey bios, trust must be earned. */ 298 DRM_INFO_ONCE("ACPI BIOS requests an excessive sleep of %u ms, " 299 "using %u ms instead\n", dslp, MAX_DSLP); 300 dslp = MAX_DSLP; 301 } 302 303 /* The spec tells us to do this, but we are the only user... */ 304 scic = swsci->scic; 305 if (scic & SWSCI_SCIC_INDICATOR) { 306 DRM_DEBUG_DRIVER("SWSCI request already in progress\n"); 307 return -EBUSY; 308 } 309 310 scic = function | SWSCI_SCIC_INDICATOR; 311 312 swsci->parm = parm; 313 swsci->scic = scic; 314 315 /* Ensure SCI event is selected and event trigger is cleared. */ 316 pci_read_config_word(pdev, SWSCI, &swsci_val); 317 if (!(swsci_val & SWSCI_SCISEL) || (swsci_val & SWSCI_GSSCIE)) { 318 swsci_val |= SWSCI_SCISEL; 319 swsci_val &= ~SWSCI_GSSCIE; 320 pci_write_config_word(pdev, SWSCI, swsci_val); 321 } 322 323 /* Use event trigger to tell bios to check the mail. */ 324 swsci_val |= SWSCI_GSSCIE; 325 pci_write_config_word(pdev, SWSCI, swsci_val); 326 327 /* Poll for the result. */ 328 #define C (((scic = swsci->scic) & SWSCI_SCIC_INDICATOR) == 0) 329 if (wait_for(C, dslp)) { 330 DRM_DEBUG_DRIVER("SWSCI request timed out\n"); 331 return -ETIMEDOUT; 332 } 333 334 scic = (scic & SWSCI_SCIC_EXIT_STATUS_MASK) >> 335 SWSCI_SCIC_EXIT_STATUS_SHIFT; 336 337 /* Note: scic == 0 is an error! */ 338 if (scic != SWSCI_SCIC_EXIT_STATUS_SUCCESS) { 339 DRM_DEBUG_DRIVER("SWSCI request error %u\n", scic); 340 return -EIO; 341 } 342 343 if (parm_out) 344 *parm_out = swsci->parm; 345 346 return 0; 347 348 #undef C 349 } 350 351 #define DISPLAY_TYPE_CRT 0 352 #define DISPLAY_TYPE_TV 1 353 #define DISPLAY_TYPE_EXTERNAL_FLAT_PANEL 2 354 #define DISPLAY_TYPE_INTERNAL_FLAT_PANEL 3 355 356 int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder, 357 bool enable) 358 { 359 struct drm_i915_private *dev_priv = to_i915(intel_encoder->base.dev); 360 u32 parm = 0; 361 u32 type = 0; 362 u32 port; 363 364 /* don't care about old stuff for now */ 365 if (!HAS_DDI(dev_priv)) 366 return 0; 367 368 if (intel_encoder->type == INTEL_OUTPUT_DSI) 369 port = 0; 370 else 371 port = intel_ddi_get_encoder_port(intel_encoder); 372 373 if (port == PORT_E) { 374 port = 0; 375 } else { 376 parm |= 1 << port; 377 port++; 378 } 379 380 if (!enable) 381 parm |= 4 << 8; 382 383 switch (intel_encoder->type) { 384 case INTEL_OUTPUT_ANALOG: 385 type = DISPLAY_TYPE_CRT; 386 break; 387 case INTEL_OUTPUT_UNKNOWN: 388 case INTEL_OUTPUT_DP: 389 case INTEL_OUTPUT_HDMI: 390 case INTEL_OUTPUT_DP_MST: 391 type = DISPLAY_TYPE_EXTERNAL_FLAT_PANEL; 392 break; 393 case INTEL_OUTPUT_EDP: 394 case INTEL_OUTPUT_DSI: 395 type = DISPLAY_TYPE_INTERNAL_FLAT_PANEL; 396 break; 397 default: 398 WARN_ONCE(1, "unsupported intel_encoder type %d\n", 399 intel_encoder->type); 400 return -EINVAL; 401 } 402 403 parm |= type << (16 + port * 3); 404 405 return swsci(dev_priv, SWSCI_SBCB_DISPLAY_POWER_STATE, parm, NULL); 406 } 407 408 static const struct { 409 pci_power_t pci_power_state; 410 u32 parm; 411 } power_state_map[] = { 412 { PCI_D0, 0x00 }, 413 { PCI_D1, 0x01 }, 414 { PCI_D2, 0x02 }, 415 { PCI_D3hot, 0x04 }, 416 { PCI_D3cold, 0x04 }, 417 }; 418 419 int intel_opregion_notify_adapter(struct drm_i915_private *dev_priv, 420 pci_power_t state) 421 { 422 int i; 423 424 if (!HAS_DDI(dev_priv)) 425 return 0; 426 427 for (i = 0; i < ARRAY_SIZE(power_state_map); i++) { 428 if (state == power_state_map[i].pci_power_state) 429 return swsci(dev_priv, SWSCI_SBCB_ADAPTER_POWER_STATE, 430 power_state_map[i].parm, NULL); 431 } 432 433 return -EINVAL; 434 } 435 436 static u32 asle_set_backlight(struct drm_i915_private *dev_priv, u32 bclp) 437 { 438 struct intel_connector *connector; 439 struct opregion_asle *asle = dev_priv->opregion.asle; 440 struct drm_device *dev = &dev_priv->drm; 441 442 DRM_DEBUG_DRIVER("bclp = 0x%08x\n", bclp); 443 444 #ifndef __DragonFly__ 445 if (acpi_video_get_backlight_type() == acpi_backlight_native) { 446 DRM_DEBUG_KMS("opregion backlight request ignored\n"); 447 return 0; 448 } 449 #endif 450 451 if (!(bclp & ASLE_BCLP_VALID)) 452 return ASLC_BACKLIGHT_FAILED; 453 454 bclp &= ASLE_BCLP_MSK; 455 if (bclp > 255) 456 return ASLC_BACKLIGHT_FAILED; 457 458 drm_modeset_lock(&dev->mode_config.connection_mutex, NULL); 459 460 /* 461 * Update backlight on all connectors that support backlight (usually 462 * only one). 463 */ 464 DRM_DEBUG_KMS("updating opregion backlight %d/255\n", bclp); 465 for_each_intel_connector(dev, connector) 466 intel_panel_set_backlight_acpi(connector, bclp, 255); 467 asle->cblv = DIV_ROUND_UP(bclp * 100, 255) | ASLE_CBLV_VALID; 468 469 drm_modeset_unlock(&dev->mode_config.connection_mutex); 470 471 472 return 0; 473 } 474 475 static u32 asle_set_als_illum(struct drm_i915_private *dev_priv, u32 alsi) 476 { 477 /* alsi is the current ALS reading in lux. 0 indicates below sensor 478 range, 0xffff indicates above sensor range. 1-0xfffe are valid */ 479 DRM_DEBUG_DRIVER("Illum is not supported\n"); 480 return ASLC_ALS_ILLUM_FAILED; 481 } 482 483 static u32 asle_set_pwm_freq(struct drm_i915_private *dev_priv, u32 pfmb) 484 { 485 DRM_DEBUG_DRIVER("PWM freq is not supported\n"); 486 return ASLC_PWM_FREQ_FAILED; 487 } 488 489 static u32 asle_set_pfit(struct drm_i915_private *dev_priv, u32 pfit) 490 { 491 /* Panel fitting is currently controlled by the X code, so this is a 492 noop until modesetting support works fully */ 493 DRM_DEBUG_DRIVER("Pfit is not supported\n"); 494 return ASLC_PFIT_FAILED; 495 } 496 497 static u32 asle_set_supported_rotation_angles(struct drm_i915_private *dev_priv, u32 srot) 498 { 499 DRM_DEBUG_DRIVER("SROT is not supported\n"); 500 return ASLC_ROTATION_ANGLES_FAILED; 501 } 502 503 static u32 asle_set_button_array(struct drm_i915_private *dev_priv, u32 iuer) 504 { 505 if (!iuer) 506 DRM_DEBUG_DRIVER("Button array event is not supported (nothing)\n"); 507 if (iuer & ASLE_IUER_ROTATION_LOCK_BTN) 508 DRM_DEBUG_DRIVER("Button array event is not supported (rotation lock)\n"); 509 if (iuer & ASLE_IUER_VOLUME_DOWN_BTN) 510 DRM_DEBUG_DRIVER("Button array event is not supported (volume down)\n"); 511 if (iuer & ASLE_IUER_VOLUME_UP_BTN) 512 DRM_DEBUG_DRIVER("Button array event is not supported (volume up)\n"); 513 if (iuer & ASLE_IUER_WINDOWS_BTN) 514 DRM_DEBUG_DRIVER("Button array event is not supported (windows)\n"); 515 if (iuer & ASLE_IUER_POWER_BTN) 516 DRM_DEBUG_DRIVER("Button array event is not supported (power)\n"); 517 518 return ASLC_BUTTON_ARRAY_FAILED; 519 } 520 521 static u32 asle_set_convertible(struct drm_i915_private *dev_priv, u32 iuer) 522 { 523 if (iuer & ASLE_IUER_CONVERTIBLE) 524 DRM_DEBUG_DRIVER("Convertible is not supported (clamshell)\n"); 525 else 526 DRM_DEBUG_DRIVER("Convertible is not supported (slate)\n"); 527 528 return ASLC_CONVERTIBLE_FAILED; 529 } 530 531 static u32 asle_set_docking(struct drm_i915_private *dev_priv, u32 iuer) 532 { 533 if (iuer & ASLE_IUER_DOCKING) 534 DRM_DEBUG_DRIVER("Docking is not supported (docked)\n"); 535 else 536 DRM_DEBUG_DRIVER("Docking is not supported (undocked)\n"); 537 538 return ASLC_DOCKING_FAILED; 539 } 540 541 static u32 asle_isct_state(struct drm_i915_private *dev_priv) 542 { 543 DRM_DEBUG_DRIVER("ISCT is not supported\n"); 544 return ASLC_ISCT_STATE_FAILED; 545 } 546 547 static void asle_work(struct work_struct *work) 548 { 549 struct intel_opregion *opregion = 550 container_of(work, struct intel_opregion, asle_work); 551 struct drm_i915_private *dev_priv = 552 container_of(opregion, struct drm_i915_private, opregion); 553 struct opregion_asle *asle = dev_priv->opregion.asle; 554 u32 aslc_stat = 0; 555 u32 aslc_req; 556 557 if (!asle) 558 return; 559 560 aslc_req = asle->aslc; 561 562 if (!(aslc_req & ASLC_REQ_MSK)) { 563 DRM_DEBUG_DRIVER("No request on ASLC interrupt 0x%08x\n", 564 aslc_req); 565 return; 566 } 567 568 if (aslc_req & ASLC_SET_ALS_ILLUM) 569 aslc_stat |= asle_set_als_illum(dev_priv, asle->alsi); 570 571 if (aslc_req & ASLC_SET_BACKLIGHT) 572 aslc_stat |= asle_set_backlight(dev_priv, asle->bclp); 573 574 if (aslc_req & ASLC_SET_PFIT) 575 aslc_stat |= asle_set_pfit(dev_priv, asle->pfit); 576 577 if (aslc_req & ASLC_SET_PWM_FREQ) 578 aslc_stat |= asle_set_pwm_freq(dev_priv, asle->pfmb); 579 580 if (aslc_req & ASLC_SUPPORTED_ROTATION_ANGLES) 581 aslc_stat |= asle_set_supported_rotation_angles(dev_priv, 582 asle->srot); 583 584 if (aslc_req & ASLC_BUTTON_ARRAY) 585 aslc_stat |= asle_set_button_array(dev_priv, asle->iuer); 586 587 if (aslc_req & ASLC_CONVERTIBLE_INDICATOR) 588 aslc_stat |= asle_set_convertible(dev_priv, asle->iuer); 589 590 if (aslc_req & ASLC_DOCKING_INDICATOR) 591 aslc_stat |= asle_set_docking(dev_priv, asle->iuer); 592 593 if (aslc_req & ASLC_ISCT_STATE_CHANGE) 594 aslc_stat |= asle_isct_state(dev_priv); 595 596 asle->aslc = aslc_stat; 597 } 598 599 void intel_opregion_asle_intr(struct drm_i915_private *dev_priv) 600 { 601 if (dev_priv->opregion.asle) 602 schedule_work(&dev_priv->opregion.asle_work); 603 } 604 605 #define ACPI_EV_DISPLAY_SWITCH (1<<0) 606 #define ACPI_EV_LID (1<<1) 607 #define ACPI_EV_DOCK (1<<2) 608 609 static struct intel_opregion *system_opregion; 610 611 #if 0 612 static int intel_opregion_video_event(struct notifier_block *nb, 613 unsigned long val, void *data) 614 { 615 /* The only video events relevant to opregion are 0x80. These indicate 616 either a docking event, lid switch or display switch request. In 617 Linux, these are handled by the dock, button and video drivers. 618 */ 619 620 struct acpi_bus_event *event = data; 621 struct opregion_acpi *acpi; 622 int ret = NOTIFY_OK; 623 624 if (strcmp(event->device_class, ACPI_VIDEO_CLASS) != 0) 625 return NOTIFY_DONE; 626 627 if (!system_opregion) 628 return NOTIFY_DONE; 629 630 acpi = system_opregion->acpi; 631 632 if (event->type == 0x80 && ((acpi->cevt & 1) == 0)) 633 ret = NOTIFY_BAD; 634 635 acpi->csts = 0; 636 637 return ret; 638 } 639 640 static struct notifier_block intel_opregion_notifier = { 641 .notifier_call = intel_opregion_video_event, 642 }; 643 #endif 644 645 static int acpi_is_video_device(ACPI_HANDLE devh) { 646 ACPI_HANDLE h; 647 if (ACPI_FAILURE(AcpiGetHandle(devh, "_DOD", &h)) || 648 ACPI_FAILURE(AcpiGetHandle(devh, "_DOS", &h))) { 649 return 0; 650 } 651 return 1; 652 } 653 654 /* 655 * Initialise the DIDL field in opregion. This passes a list of devices to 656 * the firmware. Values are defined by section B.4.2 of the ACPI specification 657 * (version 3) 658 */ 659 660 static u32 get_did(struct intel_opregion *opregion, int i) 661 { 662 u32 did; 663 664 if (i < ARRAY_SIZE(opregion->acpi->didl)) { 665 did = opregion->acpi->didl[i]; 666 } else { 667 i -= ARRAY_SIZE(opregion->acpi->didl); 668 669 if (WARN_ON(i >= ARRAY_SIZE(opregion->acpi->did2))) 670 return 0; 671 672 did = opregion->acpi->did2[i]; 673 } 674 675 return did; 676 } 677 678 static void set_did(struct intel_opregion *opregion, int i, u32 val) 679 { 680 if (i < ARRAY_SIZE(opregion->acpi->didl)) { 681 opregion->acpi->didl[i] = val; 682 } else { 683 i -= ARRAY_SIZE(opregion->acpi->didl); 684 685 if (WARN_ON(i >= ARRAY_SIZE(opregion->acpi->did2))) 686 return; 687 688 opregion->acpi->did2[i] = val; 689 } 690 } 691 692 static u32 acpi_display_type(struct drm_connector *connector) 693 { 694 u32 display_type; 695 696 switch (connector->connector_type) { 697 case DRM_MODE_CONNECTOR_VGA: 698 case DRM_MODE_CONNECTOR_DVIA: 699 display_type = ACPI_DISPLAY_TYPE_VGA; 700 break; 701 case DRM_MODE_CONNECTOR_Composite: 702 case DRM_MODE_CONNECTOR_SVIDEO: 703 case DRM_MODE_CONNECTOR_Component: 704 case DRM_MODE_CONNECTOR_9PinDIN: 705 case DRM_MODE_CONNECTOR_TV: 706 display_type = ACPI_DISPLAY_TYPE_TV; 707 break; 708 case DRM_MODE_CONNECTOR_DVII: 709 case DRM_MODE_CONNECTOR_DVID: 710 case DRM_MODE_CONNECTOR_DisplayPort: 711 case DRM_MODE_CONNECTOR_HDMIA: 712 case DRM_MODE_CONNECTOR_HDMIB: 713 display_type = ACPI_DISPLAY_TYPE_EXTERNAL_DIGITAL; 714 break; 715 case DRM_MODE_CONNECTOR_LVDS: 716 case DRM_MODE_CONNECTOR_eDP: 717 case DRM_MODE_CONNECTOR_DSI: 718 display_type = ACPI_DISPLAY_TYPE_INTERNAL_DIGITAL; 719 break; 720 case DRM_MODE_CONNECTOR_Unknown: 721 case DRM_MODE_CONNECTOR_VIRTUAL: 722 display_type = ACPI_DISPLAY_TYPE_OTHER; 723 break; 724 default: 725 MISSING_CASE(connector->connector_type); 726 display_type = ACPI_DISPLAY_TYPE_OTHER; 727 break; 728 } 729 730 return display_type; 731 } 732 733 static void intel_didl_outputs(struct drm_i915_private *dev_priv) 734 { 735 struct intel_opregion *opregion = &dev_priv->opregion; 736 struct pci_dev *pdev = dev_priv->drm.pdev; 737 struct drm_connector *connector; 738 ACPI_HANDLE handle, acpi_cdev, acpi_video_bus; 739 u32 device_id; 740 ACPI_STATUS status; 741 u32 temp, max_outputs; 742 int i = 0; 743 744 handle = acpi_get_handle(pdev->dev.bsddev); 745 if (!handle) 746 return; 747 748 if (acpi_is_video_device(handle)) 749 acpi_video_bus = handle; 750 else { 751 acpi_cdev = NULL; 752 acpi_video_bus = NULL; 753 while (AcpiGetNextObject(ACPI_TYPE_DEVICE, handle, acpi_cdev, 754 &acpi_cdev) != AE_NOT_FOUND) { 755 if (acpi_is_video_device(acpi_cdev)) { 756 acpi_video_bus = acpi_cdev; 757 break; 758 } 759 } 760 } 761 762 if (!acpi_video_bus) { 763 DRM_DEBUG_KMS("No ACPI video bus found\n"); 764 return; 765 } 766 767 /* 768 * In theory, did2, the extended didl, gets added at opregion version 769 * 3.0. In practice, however, we're supposed to set it for earlier 770 * versions as well, since a BIOS that doesn't understand did2 should 771 * not look at it anyway. Use a variable so we can tweak this if a need 772 * arises later. 773 */ 774 max_outputs = ARRAY_SIZE(opregion->acpi->didl) + 775 ARRAY_SIZE(opregion->acpi->did2); 776 777 #ifdef __DragonFly__ 778 acpi_cdev = NULL; 779 #endif 780 while (AcpiGetNextObject(ACPI_TYPE_DEVICE, acpi_video_bus, acpi_cdev, 781 &acpi_cdev) != AE_NOT_FOUND) { 782 if (i >= max_outputs) { 783 DRM_DEBUG_KMS("More than %u outputs detected via ACPI\n", 784 max_outputs); 785 return; 786 } 787 status = acpi_GetInteger(acpi_cdev, "_ADR", &device_id); 788 if (ACPI_SUCCESS(status)) { 789 if (!device_id) 790 goto blind_set; 791 set_did(opregion, i++, (u32)(device_id & 0x0f0f)); 792 } 793 } 794 795 end: 796 DRM_DEBUG_KMS("%d outputs detected\n", i); 797 798 /* If fewer than max outputs, the list must be null terminated */ 799 if (i < max_outputs) 800 set_did(opregion, i, 0); 801 return; 802 803 blind_set: 804 i = 0; 805 list_for_each_entry(connector, 806 &dev_priv->drm.mode_config.connector_list, head) { 807 int display_type = acpi_display_type(connector); 808 if (i >= max_outputs) { 809 DRM_DEBUG_KMS("More than %u outputs in connector list\n", 810 max_outputs); 811 return; 812 } 813 814 temp = get_did(opregion, i); 815 set_did(opregion, i, temp | (1 << 31) | display_type | i); 816 i++; 817 } 818 goto end; 819 } 820 821 static void intel_setup_cadls(struct drm_i915_private *dev_priv) 822 { 823 struct intel_opregion *opregion = &dev_priv->opregion; 824 int i = 0; 825 u32 disp_id; 826 827 /* Initialize the CADL field by duplicating the DIDL values. 828 * Technically, this is not always correct as display outputs may exist, 829 * but not active. This initialization is necessary for some Clevo 830 * laptops that check this field before processing the brightness and 831 * display switching hotkeys. Just like DIDL, CADL is NULL-terminated if 832 * there are less than eight devices. */ 833 do { 834 disp_id = get_did(opregion, i); 835 opregion->acpi->cadl[i] = disp_id; 836 } while (++i < 8 && disp_id != 0); 837 } 838 839 void intel_opregion_register(struct drm_i915_private *dev_priv) 840 { 841 struct intel_opregion *opregion = &dev_priv->opregion; 842 843 if (!opregion->header) 844 return; 845 846 if (opregion->acpi) { 847 intel_didl_outputs(dev_priv); 848 intel_setup_cadls(dev_priv); 849 850 /* Notify BIOS we are ready to handle ACPI video ext notifs. 851 * Right now, all the events are handled by the ACPI video module. 852 * We don't actually need to do anything with them. */ 853 opregion->acpi->csts = 0; 854 opregion->acpi->drdy = 1; 855 856 system_opregion = opregion; 857 } 858 859 if (opregion->asle) { 860 opregion->asle->tche = ASLE_TCHE_BLC_EN; 861 opregion->asle->ardy = ASLE_ARDY_READY; 862 } 863 } 864 865 void intel_opregion_unregister(struct drm_i915_private *dev_priv) 866 { 867 struct intel_opregion *opregion = &dev_priv->opregion; 868 869 if (!opregion->header) 870 return; 871 872 if (opregion->asle) 873 opregion->asle->ardy = ASLE_ARDY_NOT_READY; 874 875 cancel_work_sync(&dev_priv->opregion.asle_work); 876 877 if (opregion->acpi) { 878 opregion->acpi->drdy = 0; 879 880 system_opregion = NULL; 881 } 882 883 /* just clear all opregion memory pointers now */ 884 iounmap(opregion->header); 885 if (opregion->rvda) { 886 iounmap(opregion->rvda); 887 opregion->rvda = NULL; 888 } 889 opregion->header = NULL; 890 opregion->acpi = NULL; 891 opregion->swsci = NULL; 892 opregion->asle = NULL; 893 opregion->vbt = NULL; 894 opregion->lid_state = NULL; 895 } 896 897 static void swsci_setup(struct drm_i915_private *dev_priv) 898 { 899 struct intel_opregion *opregion = &dev_priv->opregion; 900 bool requested_callbacks = false; 901 u32 tmp; 902 903 /* Sub-function code 0 is okay, let's allow them. */ 904 opregion->swsci_gbda_sub_functions = 1; 905 opregion->swsci_sbcb_sub_functions = 1; 906 907 /* We use GBDA to ask for supported GBDA calls. */ 908 if (swsci(dev_priv, SWSCI_GBDA_SUPPORTED_CALLS, 0, &tmp) == 0) { 909 /* make the bits match the sub-function codes */ 910 tmp <<= 1; 911 opregion->swsci_gbda_sub_functions |= tmp; 912 } 913 914 /* 915 * We also use GBDA to ask for _requested_ SBCB callbacks. The driver 916 * must not call interfaces that are not specifically requested by the 917 * bios. 918 */ 919 if (swsci(dev_priv, SWSCI_GBDA_REQUESTED_CALLBACKS, 0, &tmp) == 0) { 920 /* here, the bits already match sub-function codes */ 921 opregion->swsci_sbcb_sub_functions |= tmp; 922 requested_callbacks = true; 923 } 924 925 /* 926 * But we use SBCB to ask for _supported_ SBCB calls. This does not mean 927 * the callback is _requested_. But we still can't call interfaces that 928 * are not requested. 929 */ 930 if (swsci(dev_priv, SWSCI_SBCB_SUPPORTED_CALLBACKS, 0, &tmp) == 0) { 931 /* make the bits match the sub-function codes */ 932 u32 low = tmp & 0x7ff; 933 u32 high = tmp & ~0xfff; /* bit 11 is reserved */ 934 tmp = (high << 4) | (low << 1) | 1; 935 936 /* best guess what to do with supported wrt requested */ 937 if (requested_callbacks) { 938 u32 req = opregion->swsci_sbcb_sub_functions; 939 if ((req & tmp) != req) 940 DRM_DEBUG_DRIVER("SWSCI BIOS requested (%08x) SBCB callbacks that are not supported (%08x)\n", req, tmp); 941 /* XXX: for now, trust the requested callbacks */ 942 /* opregion->swsci_sbcb_sub_functions &= tmp; */ 943 } else { 944 opregion->swsci_sbcb_sub_functions |= tmp; 945 } 946 } 947 948 DRM_DEBUG_DRIVER("SWSCI GBDA callbacks %08x, SBCB callbacks %08x\n", 949 opregion->swsci_gbda_sub_functions, 950 opregion->swsci_sbcb_sub_functions); 951 } 952 953 static int intel_no_opregion_vbt_callback(const struct dmi_system_id *id) 954 { 955 DRM_DEBUG_KMS("Falling back to manually reading VBT from " 956 "VBIOS ROM for %s\n", id->ident); 957 return 1; 958 } 959 960 static const struct dmi_system_id intel_no_opregion_vbt[] = { 961 { 962 .callback = intel_no_opregion_vbt_callback, 963 .ident = "ThinkCentre A57", 964 .matches = { 965 DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), 966 DMI_MATCH(DMI_PRODUCT_NAME, "97027RG"), 967 }, 968 }, 969 { } 970 }; 971 972 int intel_opregion_setup(struct drm_i915_private *dev_priv) 973 { 974 struct intel_opregion *opregion = &dev_priv->opregion; 975 struct pci_dev *pdev = dev_priv->drm.pdev; 976 u32 asls, mboxes; 977 char buf[sizeof(OPREGION_SIGNATURE)]; 978 int err = 0; 979 char *base; 980 981 BUILD_BUG_ON(sizeof(struct opregion_header) != 0x100); 982 BUILD_BUG_ON(sizeof(struct opregion_acpi) != 0x100); 983 BUILD_BUG_ON(sizeof(struct opregion_swsci) != 0x100); 984 BUILD_BUG_ON(sizeof(struct opregion_asle) != 0x100); 985 BUILD_BUG_ON(sizeof(struct opregion_asle_ext) != 0x400); 986 987 pci_read_config_dword(pdev, ASLS, &asls); 988 DRM_DEBUG_DRIVER("graphic opregion physical addr: 0x%x\n", asls); 989 if (asls == 0) { 990 DRM_DEBUG_DRIVER("ACPI OpRegion not supported!\n"); 991 return -ENOTSUP; 992 } 993 994 INIT_WORK(&opregion->asle_work, asle_work); 995 996 base = (void *)pmap_mapbios(asls, OPREGION_SIZE); 997 if (!base) 998 return -ENOMEM; 999 1000 memcpy(buf, base, sizeof(buf)); 1001 1002 if (memcmp(buf, OPREGION_SIGNATURE, 16)) { 1003 DRM_DEBUG_DRIVER("opregion signature mismatch\n"); 1004 err = -EINVAL; 1005 goto err_out; 1006 } 1007 opregion->header = (struct opregion_header *)base; 1008 1009 opregion->lid_state = (u32 *)(base + ACPI_CLID); 1010 1011 mboxes = opregion->header->mboxes; 1012 if (mboxes & MBOX_ACPI) { 1013 DRM_DEBUG_DRIVER("Public ACPI methods supported\n"); 1014 opregion->acpi = (struct opregion_acpi *)(base + OPREGION_ACPI_OFFSET); 1015 } 1016 1017 if (mboxes & MBOX_SWSCI) { 1018 DRM_DEBUG_DRIVER("SWSCI supported\n"); 1019 opregion->swsci = (struct opregion_swsci *)(base + OPREGION_SWSCI_OFFSET); 1020 swsci_setup(dev_priv); 1021 } 1022 1023 if (mboxes & MBOX_ASLE) { 1024 DRM_DEBUG_DRIVER("ASLE supported\n"); 1025 opregion->asle = (struct opregion_asle *)(base + OPREGION_ASLE_OFFSET); 1026 1027 opregion->asle->ardy = ASLE_ARDY_NOT_READY; 1028 } 1029 1030 if (mboxes & MBOX_ASLE_EXT) 1031 DRM_DEBUG_DRIVER("ASLE extension supported\n"); 1032 1033 if (!dmi_check_system(intel_no_opregion_vbt)) { 1034 const void *vbt = NULL; 1035 u32 vbt_size = 0; 1036 1037 if (opregion->header->opregion_ver >= 2 && opregion->asle && 1038 opregion->asle->rvda && opregion->asle->rvds) { 1039 opregion->rvda = pmap_mapbios(opregion->asle->rvda, 1040 opregion->asle->rvds); 1041 vbt = opregion->rvda; 1042 vbt_size = opregion->asle->rvds; 1043 } 1044 1045 if (intel_bios_is_valid_vbt(vbt, vbt_size)) { 1046 DRM_DEBUG_KMS("Found valid VBT in ACPI OpRegion (RVDA)\n"); 1047 opregion->vbt = vbt; 1048 opregion->vbt_size = vbt_size; 1049 } else { 1050 vbt = base + OPREGION_VBT_OFFSET; 1051 vbt_size = OPREGION_ASLE_EXT_OFFSET - OPREGION_VBT_OFFSET; 1052 if (intel_bios_is_valid_vbt(vbt, vbt_size)) { 1053 DRM_DEBUG_KMS("Found valid VBT in ACPI OpRegion (Mailbox #4)\n"); 1054 opregion->vbt = vbt; 1055 opregion->vbt_size = vbt_size; 1056 } 1057 } 1058 } 1059 1060 return 0; 1061 1062 err_out: 1063 iounmap(base); 1064 return err; 1065 } 1066 1067 static int intel_use_opregion_panel_type_callback(const struct dmi_system_id *id) 1068 { 1069 DRM_INFO("Using panel type from OpRegion on %s\n", id->ident); 1070 return 1; 1071 } 1072 1073 static const struct dmi_system_id intel_use_opregion_panel_type[] = { 1074 { 1075 .callback = intel_use_opregion_panel_type_callback, 1076 .ident = "Conrac GmbH IX45GM2", 1077 .matches = {DMI_MATCH(DMI_SYS_VENDOR, "Conrac GmbH"), 1078 DMI_MATCH(DMI_PRODUCT_NAME, "IX45GM2"), 1079 }, 1080 }, 1081 { } 1082 }; 1083 1084 int 1085 intel_opregion_get_panel_type(struct drm_i915_private *dev_priv) 1086 { 1087 u32 panel_details; 1088 int ret; 1089 1090 ret = swsci(dev_priv, SWSCI_GBDA_PANEL_DETAILS, 0x0, &panel_details); 1091 if (ret) { 1092 DRM_DEBUG_KMS("Failed to get panel details from OpRegion (%d)\n", 1093 ret); 1094 return ret; 1095 } 1096 1097 ret = (panel_details >> 8) & 0xff; 1098 if (ret > 0x10) { 1099 DRM_DEBUG_KMS("Invalid OpRegion panel type 0x%x\n", ret); 1100 return -EINVAL; 1101 } 1102 1103 /* fall back to VBT panel type? */ 1104 if (ret == 0x0) { 1105 DRM_DEBUG_KMS("No panel type in OpRegion\n"); 1106 return -ENODEV; 1107 } 1108 1109 /* 1110 * So far we know that some machined must use it, others must not use it. 1111 * There doesn't seem to be any way to determine which way to go, except 1112 * via a quirk list :( 1113 */ 1114 if (!dmi_check_system(intel_use_opregion_panel_type)) { 1115 DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1); 1116 return -ENODEV; 1117 } 1118 1119 /* 1120 * FIXME On Dell XPS 13 9350 the OpRegion panel type (0) gives us 1121 * low vswing for eDP, whereas the VBT panel type (2) gives us normal 1122 * vswing instead. Low vswing results in some display flickers, so 1123 * let's simply ignore the OpRegion panel type on SKL for now. 1124 */ 1125 if (IS_SKYLAKE(dev_priv)) { 1126 DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1); 1127 return -ENODEV; 1128 } 1129 1130 /* 1131 * FIXME On Dell XPS 13 9350 the OpRegion panel type (0) gives us 1132 * low vswing for eDP, whereas the VBT panel type (2) gives us normal 1133 * vswing instead. Low vswing results in some display flickers, so 1134 * let's simply ignore the OpRegion panel type on SKL for now. 1135 */ 1136 if (IS_SKYLAKE(dev_priv)) { 1137 DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1); 1138 return -ENODEV; 1139 } 1140 1141 return ret - 1; 1142 } 1143