1 /*
2  * Copyright 2007-8 Advanced Micro Devices, Inc.
3  * Copyright 2008 Red Hat Inc.
4  *
5  * Permission is hereby granted, free of charge, to any person obtaining a
6  * copy of this software and associated documentation files (the "Software"),
7  * to deal in the Software without restriction, including without limitation
8  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9  * and/or sell copies of the Software, and to permit persons to whom the
10  * Software is furnished to do so, subject to the following conditions:
11  *
12  * The above copyright notice and this permission notice shall be included in
13  * all copies or substantial portions of the Software.
14  *
15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
18  * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
19  * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
20  * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
21  * OTHER DEALINGS IN THE SOFTWARE.
22  *
23  * Authors: Dave Airlie
24  *          Alex Deucher
25  */
26 #include <drm/drmP.h>
27 #include <drm/drm_edid.h>
28 #include <drm/drm_crtc_helper.h>
29 #include <drm/drm_fb_helper.h>
30 #include <drm/radeon_drm.h>
31 #include "radeon.h"
32 #include "atom.h"
33 
34 #include <linux/pm_runtime.h>
35 
36 void radeon_connector_hotplug(struct drm_connector *connector)
37 {
38 	struct drm_device *dev = connector->dev;
39 	struct radeon_device *rdev = dev->dev_private;
40 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
41 
42 	/* bail if the connector does not have hpd pin, e.g.,
43 	 * VGA, TV, etc.
44 	 */
45 	if (radeon_connector->hpd.hpd == RADEON_HPD_NONE)
46 		return;
47 
48 	radeon_hpd_set_polarity(rdev, radeon_connector->hpd.hpd);
49 
50 	/* if the connector is already off, don't turn it back on */
51 	/* FIXME: This access isn't protected by any locks. */
52 	if (connector->dpms != DRM_MODE_DPMS_ON)
53 		return;
54 
55 	/* just deal with DP (not eDP) here. */
56 	if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
57 		struct radeon_connector_atom_dig *dig_connector =
58 			radeon_connector->con_priv;
59 
60 		/* if existing sink type was not DP no need to retrain */
61 		if (dig_connector->dp_sink_type != CONNECTOR_OBJECT_ID_DISPLAYPORT)
62 			return;
63 
64 		/* first get sink type as it may be reset after (un)plug */
65 		dig_connector->dp_sink_type = radeon_dp_getsinktype(radeon_connector);
66 		/* don't do anything if sink is not display port, i.e.,
67 		 * passive dp->(dvi|hdmi) adaptor
68 		 */
69 		if (dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) {
70 			int saved_dpms = connector->dpms;
71 			/* Only turn off the display if it's physically disconnected */
72 			if (!radeon_hpd_sense(rdev, radeon_connector->hpd.hpd)) {
73 				drm_helper_connector_dpms(connector, DRM_MODE_DPMS_OFF);
74 			} else if (radeon_dp_needs_link_train(radeon_connector)) {
75 				/* set it to OFF so that drm_helper_connector_dpms()
76 				 * won't return immediately since the current state
77 				 * is ON at this point.
78 				 */
79 				connector->dpms = DRM_MODE_DPMS_OFF;
80 				drm_helper_connector_dpms(connector, DRM_MODE_DPMS_ON);
81 			}
82 			connector->dpms = saved_dpms;
83 		}
84 	}
85 }
86 
87 static void radeon_property_change_mode(struct drm_encoder *encoder)
88 {
89 	struct drm_crtc *crtc = encoder->crtc;
90 
91 	if (crtc && crtc->enabled) {
92 		drm_crtc_helper_set_mode(crtc, &crtc->mode,
93 					 crtc->x, crtc->y, crtc->primary->fb);
94 	}
95 }
96 
97 int radeon_get_monitor_bpc(struct drm_connector *connector)
98 {
99 	struct drm_device *dev = connector->dev;
100 	struct radeon_device *rdev = dev->dev_private;
101 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
102 	struct radeon_connector_atom_dig *dig_connector;
103 	int bpc = 8;
104 	int mode_clock, max_tmds_clock;
105 
106 	switch (connector->connector_type) {
107 	case DRM_MODE_CONNECTOR_DVII:
108 	case DRM_MODE_CONNECTOR_HDMIB:
109 		if (radeon_connector->use_digital) {
110 			if (drm_detect_hdmi_monitor(radeon_connector_edid(connector))) {
111 				if (connector->display_info.bpc)
112 					bpc = connector->display_info.bpc;
113 			}
114 		}
115 		break;
116 	case DRM_MODE_CONNECTOR_DVID:
117 	case DRM_MODE_CONNECTOR_HDMIA:
118 		if (drm_detect_hdmi_monitor(radeon_connector_edid(connector))) {
119 			if (connector->display_info.bpc)
120 				bpc = connector->display_info.bpc;
121 		}
122 		break;
123 	case DRM_MODE_CONNECTOR_DisplayPort:
124 		dig_connector = radeon_connector->con_priv;
125 		if ((dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) ||
126 		    (dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_eDP) ||
127 		    drm_detect_hdmi_monitor(radeon_connector_edid(connector))) {
128 			if (connector->display_info.bpc)
129 				bpc = connector->display_info.bpc;
130 		}
131 		break;
132 	case DRM_MODE_CONNECTOR_eDP:
133 	case DRM_MODE_CONNECTOR_LVDS:
134 		if (connector->display_info.bpc)
135 			bpc = connector->display_info.bpc;
136 		else if (ASIC_IS_DCE41(rdev) || ASIC_IS_DCE5(rdev)) {
137 			const struct drm_connector_helper_funcs *connector_funcs =
138 				connector->helper_private;
139 			struct drm_encoder *encoder = connector_funcs->best_encoder(connector);
140 			struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
141 			struct radeon_encoder_atom_dig *dig = radeon_encoder->enc_priv;
142 
143 			if (dig->lcd_misc & ATOM_PANEL_MISC_V13_6BIT_PER_COLOR)
144 				bpc = 6;
145 			else if (dig->lcd_misc & ATOM_PANEL_MISC_V13_8BIT_PER_COLOR)
146 				bpc = 8;
147 		}
148 		break;
149 	}
150 
151 	if (drm_detect_hdmi_monitor(radeon_connector_edid(connector))) {
152 		/* hdmi deep color only implemented on DCE4+ */
153 		if ((bpc > 8) && !ASIC_IS_DCE4(rdev)) {
154 			DRM_DEBUG("%s: HDMI deep color %d bpc unsupported. Using 8 bpc.\n",
155 					  connector->name, bpc);
156 			bpc = 8;
157 		}
158 
159 		/*
160 		 * Pre DCE-8 hw can't handle > 12 bpc, and more than 12 bpc doesn't make
161 		 * much sense without support for > 12 bpc framebuffers. RGB 4:4:4 at
162 		 * 12 bpc is always supported on hdmi deep color sinks, as this is
163 		 * required by the HDMI-1.3 spec. Clamp to a safe 12 bpc maximum.
164 		 */
165 		if (bpc > 12) {
166 			DRM_DEBUG("%s: HDMI deep color %d bpc unsupported. Using 12 bpc.\n",
167 					  connector->name, bpc);
168 			bpc = 12;
169 		}
170 
171 		/* Any defined maximum tmds clock limit we must not exceed? */
172 		if (connector->max_tmds_clock > 0) {
173 			/* mode_clock is clock in kHz for mode to be modeset on this connector */
174 			mode_clock = radeon_connector->pixelclock_for_modeset;
175 
176 			/* Maximum allowable input clock in kHz */
177 			max_tmds_clock = connector->max_tmds_clock * 1000;
178 
179 			DRM_DEBUG("%s: hdmi mode dotclock %d kHz, max tmds input clock %d kHz.\n",
180 					  connector->name, mode_clock, max_tmds_clock);
181 
182 			/* Check if bpc is within clock limit. Try to degrade gracefully otherwise */
183 			if ((bpc == 12) && (mode_clock * 3/2 > max_tmds_clock)) {
184 				if ((connector->display_info.edid_hdmi_dc_modes & DRM_EDID_HDMI_DC_30) &&
185 					(mode_clock * 5/4 <= max_tmds_clock))
186 					bpc = 10;
187 				else
188 					bpc = 8;
189 
190 				DRM_DEBUG("%s: HDMI deep color 12 bpc exceeds max tmds clock. Using %d bpc.\n",
191 						  connector->name, bpc);
192 			}
193 
194 			if ((bpc == 10) && (mode_clock * 5/4 > max_tmds_clock)) {
195 				bpc = 8;
196 				DRM_DEBUG("%s: HDMI deep color 10 bpc exceeds max tmds clock. Using %d bpc.\n",
197 						  connector->name, bpc);
198 			}
199 		}
200 		else if (bpc > 8) {
201 			/* max_tmds_clock missing, but hdmi spec mandates it for deep color. */
202 			DRM_DEBUG("%s: Required max tmds clock for HDMI deep color missing. Using 8 bpc.\n",
203 					  connector->name);
204 			bpc = 8;
205 		}
206 	}
207 
208 	if ((radeon_deep_color == 0) && (bpc > 8)) {
209 		DRM_DEBUG("%s: Deep color disabled. Set radeon module param deep_color=1 to enable.\n",
210 				  connector->name);
211 		bpc = 8;
212 	}
213 
214 	DRM_DEBUG("%s: Display bpc=%d, returned bpc=%d\n",
215 			  connector->name, connector->display_info.bpc, bpc);
216 
217 	return bpc;
218 }
219 
220 static void
221 radeon_connector_update_scratch_regs(struct drm_connector *connector, enum drm_connector_status status)
222 {
223 	struct drm_device *dev = connector->dev;
224 	struct radeon_device *rdev = dev->dev_private;
225 	struct drm_encoder *best_encoder = NULL;
226 	struct drm_encoder *encoder = NULL;
227 	const struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
228 	bool connected;
229 	int i;
230 
231 	best_encoder = connector_funcs->best_encoder(connector);
232 
233 	for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
234 		if (connector->encoder_ids[i] == 0)
235 			break;
236 
237 		encoder = drm_encoder_find(connector->dev,
238 					   connector->encoder_ids[i]);
239 		if (!encoder)
240 			continue;
241 
242 		if ((encoder == best_encoder) && (status == connector_status_connected))
243 			connected = true;
244 		else
245 			connected = false;
246 
247 		if (rdev->is_atom_bios)
248 			radeon_atombios_connected_scratch_regs(connector, encoder, connected);
249 		else
250 			radeon_combios_connected_scratch_regs(connector, encoder, connected);
251 
252 	}
253 }
254 
255 static struct drm_encoder *radeon_find_encoder(struct drm_connector *connector, int encoder_type)
256 {
257 	struct drm_encoder *encoder;
258 	int i;
259 
260 	for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
261 		if (connector->encoder_ids[i] == 0)
262 			break;
263 
264 		encoder = drm_encoder_find(connector->dev, connector->encoder_ids[i]);
265 		if (!encoder)
266 			continue;
267 
268 		if (encoder->encoder_type == encoder_type)
269 			return encoder;
270 	}
271 	return NULL;
272 }
273 
274 struct edid *radeon_connector_edid(struct drm_connector *connector)
275 {
276 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
277 	struct drm_property_blob *edid_blob = connector->edid_blob_ptr;
278 
279 	if (radeon_connector->edid) {
280 		return radeon_connector->edid;
281 	} else if (edid_blob) {
282 		struct edid *edid = kmemdup(edid_blob->data, edid_blob->length, GFP_KERNEL);
283 		if (edid)
284 			radeon_connector->edid = edid;
285 	}
286 	return radeon_connector->edid;
287 }
288 
289 static void radeon_connector_get_edid(struct drm_connector *connector)
290 {
291 	struct drm_device *dev = connector->dev;
292 	struct radeon_device *rdev = dev->dev_private;
293 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
294 
295 	if (radeon_connector->edid)
296 		return;
297 
298 	/* on hw with routers, select right port */
299 	if (radeon_connector->router.ddc_valid)
300 		radeon_router_select_ddc_port(radeon_connector);
301 
302 	if ((radeon_connector_encoder_get_dp_bridge_encoder_id(connector) !=
303 	     ENCODER_OBJECT_ID_NONE) &&
304 	    radeon_connector->ddc_bus->has_aux) {
305 		radeon_connector->edid = drm_get_edid(connector,
306 						      &radeon_connector->ddc_bus->aux.ddc);
307 	} else if ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) ||
308 		   (connector->connector_type == DRM_MODE_CONNECTOR_eDP)) {
309 		struct radeon_connector_atom_dig *dig = radeon_connector->con_priv;
310 
311 		if ((dig->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT ||
312 		     dig->dp_sink_type == CONNECTOR_OBJECT_ID_eDP) &&
313 		    radeon_connector->ddc_bus->has_aux)
314 			radeon_connector->edid = drm_get_edid(&radeon_connector->base,
315 							      &radeon_connector->ddc_bus->aux.ddc);
316 		else if (radeon_connector->ddc_bus)
317 			radeon_connector->edid = drm_get_edid(&radeon_connector->base,
318 							      &radeon_connector->ddc_bus->adapter);
319 	} else if (radeon_connector->ddc_bus) {
320 		radeon_connector->edid = drm_get_edid(&radeon_connector->base,
321 						      &radeon_connector->ddc_bus->adapter);
322 	}
323 
324 	if (!radeon_connector->edid) {
325 		/* don't fetch the edid from the vbios if ddc fails and runpm is
326 		 * enabled so we report disconnected.
327 		 */
328 		if ((rdev->flags & RADEON_IS_PX) && (radeon_runtime_pm != 0))
329 			return;
330 
331 		if (rdev->is_atom_bios) {
332 			/* some laptops provide a hardcoded edid in rom for LCDs */
333 			if (((connector->connector_type == DRM_MODE_CONNECTOR_LVDS) ||
334 			     (connector->connector_type == DRM_MODE_CONNECTOR_eDP)))
335 				radeon_connector->edid = radeon_bios_get_hardcoded_edid(rdev);
336 		} else {
337 			/* some servers provide a hardcoded edid in rom for KVMs */
338 			radeon_connector->edid = radeon_bios_get_hardcoded_edid(rdev);
339 		}
340 	}
341 }
342 
343 static void radeon_connector_free_edid(struct drm_connector *connector)
344 {
345 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
346 
347 	if (radeon_connector->edid) {
348 		kfree(radeon_connector->edid);
349 		radeon_connector->edid = NULL;
350 	}
351 }
352 
353 static int radeon_ddc_get_modes(struct drm_connector *connector)
354 {
355 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
356 	int ret;
357 
358 	if (radeon_connector->edid) {
359 		drm_mode_connector_update_edid_property(connector, radeon_connector->edid);
360 		ret = drm_add_edid_modes(connector, radeon_connector->edid);
361 		drm_edid_to_eld(connector, radeon_connector->edid);
362 		return ret;
363 	}
364 	drm_mode_connector_update_edid_property(connector, NULL);
365 	return 0;
366 }
367 
368 static struct drm_encoder *radeon_best_single_encoder(struct drm_connector *connector)
369 {
370 	int enc_id = connector->encoder_ids[0];
371 	/* pick the encoder ids */
372 	if (enc_id)
373 		return drm_encoder_find(connector->dev, enc_id);
374 	return NULL;
375 }
376 
377 static void radeon_get_native_mode(struct drm_connector *connector)
378 {
379 	struct drm_encoder *encoder = radeon_best_single_encoder(connector);
380 	struct radeon_encoder *radeon_encoder;
381 
382 	if (encoder == NULL)
383 		return;
384 
385 	radeon_encoder = to_radeon_encoder(encoder);
386 
387 	if (!list_empty(&connector->probed_modes)) {
388 		struct drm_display_mode *preferred_mode =
389 			list_first_entry(&connector->probed_modes,
390 					 struct drm_display_mode, head);
391 
392 		radeon_encoder->native_mode = *preferred_mode;
393 	} else {
394 		radeon_encoder->native_mode.clock = 0;
395 	}
396 }
397 
398 /*
399  * radeon_connector_analog_encoder_conflict_solve
400  * - search for other connectors sharing this encoder
401  *   if priority is true, then set them disconnected if this is connected
402  *   if priority is false, set us disconnected if they are connected
403  */
404 static enum drm_connector_status
405 radeon_connector_analog_encoder_conflict_solve(struct drm_connector *connector,
406 					       struct drm_encoder *encoder,
407 					       enum drm_connector_status current_status,
408 					       bool priority)
409 {
410 	struct drm_device *dev = connector->dev;
411 	struct drm_connector *conflict;
412 	struct radeon_connector *radeon_conflict;
413 	int i;
414 
415 	list_for_each_entry(conflict, &dev->mode_config.connector_list, head) {
416 		if (conflict == connector)
417 			continue;
418 
419 		radeon_conflict = to_radeon_connector(conflict);
420 		for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
421 			if (conflict->encoder_ids[i] == 0)
422 				break;
423 
424 			/* if the IDs match */
425 			if (conflict->encoder_ids[i] == encoder->base.id) {
426 				if (conflict->status != connector_status_connected)
427 					continue;
428 
429 				if (radeon_conflict->use_digital)
430 					continue;
431 
432 				if (priority == true) {
433 					DRM_DEBUG_KMS("1: conflicting encoders switching off %s\n",
434 						      conflict->name);
435 					DRM_DEBUG_KMS("in favor of %s\n",
436 						      connector->name);
437 					conflict->status = connector_status_disconnected;
438 					radeon_connector_update_scratch_regs(conflict, connector_status_disconnected);
439 				} else {
440 					DRM_DEBUG_KMS("2: conflicting encoders switching off %s\n",
441 						      connector->name);
442 					DRM_DEBUG_KMS("in favor of %s\n",
443 						      conflict->name);
444 					current_status = connector_status_disconnected;
445 				}
446 				break;
447 			}
448 		}
449 	}
450 	return current_status;
451 
452 }
453 
454 static struct drm_display_mode *radeon_fp_native_mode(struct drm_encoder *encoder)
455 {
456 	struct drm_device *dev = encoder->dev;
457 	struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
458 	struct drm_display_mode *mode = NULL;
459 	struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
460 
461 	if (native_mode->hdisplay != 0 &&
462 	    native_mode->vdisplay != 0 &&
463 	    native_mode->clock != 0) {
464 		mode = drm_mode_duplicate(dev, native_mode);
465 		mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;
466 		drm_mode_set_name(mode);
467 
468 		DRM_DEBUG_KMS("Adding native panel mode %s\n", mode->name);
469 	} else if (native_mode->hdisplay != 0 &&
470 		   native_mode->vdisplay != 0) {
471 		/* mac laptops without an edid */
472 		/* Note that this is not necessarily the exact panel mode,
473 		 * but an approximation based on the cvt formula.  For these
474 		 * systems we should ideally read the mode info out of the
475 		 * registers or add a mode table, but this works and is much
476 		 * simpler.
477 		 */
478 		mode = drm_cvt_mode(dev, native_mode->hdisplay, native_mode->vdisplay, 60, true, false, false);
479 		mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;
480 		DRM_DEBUG_KMS("Adding cvt approximation of native panel mode %s\n", mode->name);
481 	}
482 	return mode;
483 }
484 
485 static void radeon_add_common_modes(struct drm_encoder *encoder, struct drm_connector *connector)
486 {
487 	struct drm_device *dev = encoder->dev;
488 	struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
489 	struct drm_display_mode *mode = NULL;
490 	struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
491 	int i;
492 	struct mode_size {
493 		int w;
494 		int h;
495 	} common_modes[17] = {
496 		{ 640,  480},
497 		{ 720,  480},
498 		{ 800,  600},
499 		{ 848,  480},
500 		{1024,  768},
501 		{1152,  768},
502 		{1280,  720},
503 		{1280,  800},
504 		{1280,  854},
505 		{1280,  960},
506 		{1280, 1024},
507 		{1440,  900},
508 		{1400, 1050},
509 		{1680, 1050},
510 		{1600, 1200},
511 		{1920, 1080},
512 		{1920, 1200}
513 	};
514 
515 	for (i = 0; i < 17; i++) {
516 		if (radeon_encoder->devices & (ATOM_DEVICE_TV_SUPPORT)) {
517 			if (common_modes[i].w > 1024 ||
518 			    common_modes[i].h > 768)
519 				continue;
520 		}
521 		if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT)) {
522 			if (common_modes[i].w > native_mode->hdisplay ||
523 			    common_modes[i].h > native_mode->vdisplay ||
524 			    (common_modes[i].w == native_mode->hdisplay &&
525 			     common_modes[i].h == native_mode->vdisplay))
526 				continue;
527 		}
528 		if (common_modes[i].w < 320 || common_modes[i].h < 200)
529 			continue;
530 
531 		mode = drm_cvt_mode(dev, common_modes[i].w, common_modes[i].h, 60, false, false, false);
532 		drm_mode_probed_add(connector, mode);
533 	}
534 }
535 
536 static int radeon_connector_set_property(struct drm_connector *connector, struct drm_property *property,
537 				  uint64_t val)
538 {
539 	struct drm_device *dev = connector->dev;
540 	struct radeon_device *rdev = dev->dev_private;
541 	struct drm_encoder *encoder;
542 	struct radeon_encoder *radeon_encoder;
543 
544 	if (property == rdev->mode_info.coherent_mode_property) {
545 		struct radeon_encoder_atom_dig *dig;
546 		bool new_coherent_mode;
547 
548 		/* need to find digital encoder on connector */
549 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
550 		if (!encoder)
551 			return 0;
552 
553 		radeon_encoder = to_radeon_encoder(encoder);
554 
555 		if (!radeon_encoder->enc_priv)
556 			return 0;
557 
558 		dig = radeon_encoder->enc_priv;
559 		new_coherent_mode = val ? true : false;
560 		if (dig->coherent_mode != new_coherent_mode) {
561 			dig->coherent_mode = new_coherent_mode;
562 			radeon_property_change_mode(&radeon_encoder->base);
563 		}
564 	}
565 
566 	if (property == rdev->mode_info.audio_property) {
567 		struct radeon_connector *radeon_connector = to_radeon_connector(connector);
568 		/* need to find digital encoder on connector */
569 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
570 		if (!encoder)
571 			return 0;
572 
573 		radeon_encoder = to_radeon_encoder(encoder);
574 
575 		if (radeon_connector->audio != val) {
576 			radeon_connector->audio = val;
577 			radeon_property_change_mode(&radeon_encoder->base);
578 		}
579 	}
580 
581 	if (property == rdev->mode_info.dither_property) {
582 		struct radeon_connector *radeon_connector = to_radeon_connector(connector);
583 		/* need to find digital encoder on connector */
584 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
585 		if (!encoder)
586 			return 0;
587 
588 		radeon_encoder = to_radeon_encoder(encoder);
589 
590 		if (radeon_connector->dither != val) {
591 			radeon_connector->dither = val;
592 			radeon_property_change_mode(&radeon_encoder->base);
593 		}
594 	}
595 
596 	if (property == rdev->mode_info.underscan_property) {
597 		/* need to find digital encoder on connector */
598 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
599 		if (!encoder)
600 			return 0;
601 
602 		radeon_encoder = to_radeon_encoder(encoder);
603 
604 		if (radeon_encoder->underscan_type != val) {
605 			radeon_encoder->underscan_type = val;
606 			radeon_property_change_mode(&radeon_encoder->base);
607 		}
608 	}
609 
610 	if (property == rdev->mode_info.underscan_hborder_property) {
611 		/* need to find digital encoder on connector */
612 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
613 		if (!encoder)
614 			return 0;
615 
616 		radeon_encoder = to_radeon_encoder(encoder);
617 
618 		if (radeon_encoder->underscan_hborder != val) {
619 			radeon_encoder->underscan_hborder = val;
620 			radeon_property_change_mode(&radeon_encoder->base);
621 		}
622 	}
623 
624 	if (property == rdev->mode_info.underscan_vborder_property) {
625 		/* need to find digital encoder on connector */
626 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
627 		if (!encoder)
628 			return 0;
629 
630 		radeon_encoder = to_radeon_encoder(encoder);
631 
632 		if (radeon_encoder->underscan_vborder != val) {
633 			radeon_encoder->underscan_vborder = val;
634 			radeon_property_change_mode(&radeon_encoder->base);
635 		}
636 	}
637 
638 	if (property == rdev->mode_info.tv_std_property) {
639 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TVDAC);
640 		if (!encoder) {
641 			encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_DAC);
642 		}
643 
644 		if (!encoder)
645 			return 0;
646 
647 		radeon_encoder = to_radeon_encoder(encoder);
648 		if (!radeon_encoder->enc_priv)
649 			return 0;
650 		if (ASIC_IS_AVIVO(rdev) || radeon_r4xx_atom) {
651 			struct radeon_encoder_atom_dac *dac_int;
652 			dac_int = radeon_encoder->enc_priv;
653 			dac_int->tv_std = val;
654 		} else {
655 			struct radeon_encoder_tv_dac *dac_int;
656 			dac_int = radeon_encoder->enc_priv;
657 			dac_int->tv_std = val;
658 		}
659 		radeon_property_change_mode(&radeon_encoder->base);
660 	}
661 
662 	if (property == rdev->mode_info.load_detect_property) {
663 		struct radeon_connector *radeon_connector =
664 			to_radeon_connector(connector);
665 
666 		if (val == 0)
667 			radeon_connector->dac_load_detect = false;
668 		else
669 			radeon_connector->dac_load_detect = true;
670 	}
671 
672 	if (property == rdev->mode_info.tmds_pll_property) {
673 		struct radeon_encoder_int_tmds *tmds = NULL;
674 		bool ret = false;
675 		/* need to find digital encoder on connector */
676 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
677 		if (!encoder)
678 			return 0;
679 
680 		radeon_encoder = to_radeon_encoder(encoder);
681 
682 		tmds = radeon_encoder->enc_priv;
683 		if (!tmds)
684 			return 0;
685 
686 		if (val == 0) {
687 			if (rdev->is_atom_bios)
688 				ret = radeon_atombios_get_tmds_info(radeon_encoder, tmds);
689 			else
690 				ret = radeon_legacy_get_tmds_info_from_combios(radeon_encoder, tmds);
691 		}
692 		if (val == 1 || ret == false) {
693 			radeon_legacy_get_tmds_info_from_table(radeon_encoder, tmds);
694 		}
695 		radeon_property_change_mode(&radeon_encoder->base);
696 	}
697 
698 	if (property == dev->mode_config.scaling_mode_property) {
699 		enum radeon_rmx_type rmx_type;
700 
701 		if (connector->encoder)
702 			radeon_encoder = to_radeon_encoder(connector->encoder);
703 		else {
704 			const struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
705 			radeon_encoder = to_radeon_encoder(connector_funcs->best_encoder(connector));
706 		}
707 
708 		switch (val) {
709 		default:
710 		case DRM_MODE_SCALE_NONE: rmx_type = RMX_OFF; break;
711 		case DRM_MODE_SCALE_CENTER: rmx_type = RMX_CENTER; break;
712 		case DRM_MODE_SCALE_ASPECT: rmx_type = RMX_ASPECT; break;
713 		case DRM_MODE_SCALE_FULLSCREEN: rmx_type = RMX_FULL; break;
714 		}
715 		if (radeon_encoder->rmx_type == rmx_type)
716 			return 0;
717 
718 		if ((rmx_type != DRM_MODE_SCALE_NONE) &&
719 		    (radeon_encoder->native_mode.clock == 0))
720 			return 0;
721 
722 		radeon_encoder->rmx_type = rmx_type;
723 
724 		radeon_property_change_mode(&radeon_encoder->base);
725 	}
726 
727 	return 0;
728 }
729 
730 static void radeon_fixup_lvds_native_mode(struct drm_encoder *encoder,
731 					  struct drm_connector *connector)
732 {
733 	struct radeon_encoder *radeon_encoder =	to_radeon_encoder(encoder);
734 	struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
735 	struct drm_display_mode *t, *mode;
736 
737 	/* If the EDID preferred mode doesn't match the native mode, use it */
738 	list_for_each_entry_safe(mode, t, &connector->probed_modes, head) {
739 		if (mode->type & DRM_MODE_TYPE_PREFERRED) {
740 			if (mode->hdisplay != native_mode->hdisplay ||
741 			    mode->vdisplay != native_mode->vdisplay)
742 				memcpy(native_mode, mode, sizeof(*mode));
743 		}
744 	}
745 
746 	/* Try to get native mode details from EDID if necessary */
747 	if (!native_mode->clock) {
748 		list_for_each_entry_safe(mode, t, &connector->probed_modes, head) {
749 			if (mode->hdisplay == native_mode->hdisplay &&
750 			    mode->vdisplay == native_mode->vdisplay) {
751 				*native_mode = *mode;
752 				drm_mode_set_crtcinfo(native_mode, CRTC_INTERLACE_HALVE_V);
753 				DRM_DEBUG_KMS("Determined LVDS native mode details from EDID\n");
754 				break;
755 			}
756 		}
757 	}
758 
759 	if (!native_mode->clock) {
760 		DRM_DEBUG_KMS("No LVDS native mode details, disabling RMX\n");
761 		radeon_encoder->rmx_type = RMX_OFF;
762 	}
763 }
764 
765 static int radeon_lvds_get_modes(struct drm_connector *connector)
766 {
767 	struct drm_encoder *encoder;
768 	int ret = 0;
769 	struct drm_display_mode *mode;
770 
771 	radeon_connector_get_edid(connector);
772 	ret = radeon_ddc_get_modes(connector);
773 	if (ret > 0) {
774 		encoder = radeon_best_single_encoder(connector);
775 		if (encoder) {
776 			radeon_fixup_lvds_native_mode(encoder, connector);
777 			/* add scaled modes */
778 			radeon_add_common_modes(encoder, connector);
779 		}
780 		return ret;
781 	}
782 
783 	encoder = radeon_best_single_encoder(connector);
784 	if (!encoder)
785 		return 0;
786 
787 	/* we have no EDID modes */
788 	mode = radeon_fp_native_mode(encoder);
789 	if (mode) {
790 		ret = 1;
791 		drm_mode_probed_add(connector, mode);
792 		/* add the width/height from vbios tables if available */
793 		connector->display_info.width_mm = mode->width_mm;
794 		connector->display_info.height_mm = mode->height_mm;
795 		/* add scaled modes */
796 		radeon_add_common_modes(encoder, connector);
797 	}
798 
799 	return ret;
800 }
801 
802 static int radeon_lvds_mode_valid(struct drm_connector *connector,
803 				  struct drm_display_mode *mode)
804 {
805 	struct drm_encoder *encoder = radeon_best_single_encoder(connector);
806 
807 	if ((mode->hdisplay < 320) || (mode->vdisplay < 240))
808 		return MODE_PANEL;
809 
810 	if (encoder) {
811 		struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
812 		struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
813 
814 		/* AVIVO hardware supports downscaling modes larger than the panel
815 		 * to the panel size, but I'm not sure this is desirable.
816 		 */
817 		if ((mode->hdisplay > native_mode->hdisplay) ||
818 		    (mode->vdisplay > native_mode->vdisplay))
819 			return MODE_PANEL;
820 
821 		/* if scaling is disabled, block non-native modes */
822 		if (radeon_encoder->rmx_type == RMX_OFF) {
823 			if ((mode->hdisplay != native_mode->hdisplay) ||
824 			    (mode->vdisplay != native_mode->vdisplay))
825 				return MODE_PANEL;
826 		}
827 	}
828 
829 	return MODE_OK;
830 }
831 
832 static enum drm_connector_status
833 radeon_lvds_detect(struct drm_connector *connector, bool force)
834 {
835 	struct drm_device *dev = connector->dev;
836 	struct radeon_device *rdev = dev->dev_private;
837 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
838 	struct drm_encoder *encoder = radeon_best_single_encoder(connector);
839 	enum drm_connector_status ret = connector_status_disconnected;
840 #ifdef PM_TODO
841 	int r;
842 
843 	r = pm_runtime_get_sync(connector->dev->dev);
844 	if (r < 0)
845 		return connector_status_disconnected;
846 #endif
847 
848 	if (encoder) {
849 		struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
850 		struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
851 
852 		/* check if panel is valid */
853 		if (native_mode->hdisplay >= 320 && native_mode->vdisplay >= 240)
854 			ret = connector_status_connected;
855 		/* don't fetch the edid from the vbios if ddc fails and runpm is
856 		 * enabled so we report disconnected.
857 		 */
858 		if ((rdev->flags & RADEON_IS_PX) && (radeon_runtime_pm != 0))
859 			ret = connector_status_disconnected;
860 	}
861 
862 	/* check for edid as well */
863 	radeon_connector_get_edid(connector);
864 	if (radeon_connector->edid)
865 		ret = connector_status_connected;
866 	/* check acpi lid status ??? */
867 
868 	radeon_connector_update_scratch_regs(connector, ret);
869 #ifdef PM_TODO
870 	pm_runtime_mark_last_busy(connector->dev->dev);
871 	pm_runtime_put_autosuspend(connector->dev->dev);
872 #endif
873 	return ret;
874 }
875 
876 static void radeon_connector_destroy(struct drm_connector *connector)
877 {
878 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
879 
880 	radeon_connector_free_edid(connector);
881 	kfree(radeon_connector->con_priv);
882 	drm_connector_unregister(connector);
883 	drm_connector_cleanup(connector);
884 	kfree(connector);
885 }
886 
887 static int radeon_lvds_set_property(struct drm_connector *connector,
888 				    struct drm_property *property,
889 				    uint64_t value)
890 {
891 	struct drm_device *dev = connector->dev;
892 	struct radeon_encoder *radeon_encoder;
893 	enum radeon_rmx_type rmx_type;
894 
895 	DRM_DEBUG_KMS("\n");
896 	if (property != dev->mode_config.scaling_mode_property)
897 		return 0;
898 
899 	if (connector->encoder)
900 		radeon_encoder = to_radeon_encoder(connector->encoder);
901 	else {
902 		const struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
903 		radeon_encoder = to_radeon_encoder(connector_funcs->best_encoder(connector));
904 	}
905 
906 	switch (value) {
907 	case DRM_MODE_SCALE_NONE: rmx_type = RMX_OFF; break;
908 	case DRM_MODE_SCALE_CENTER: rmx_type = RMX_CENTER; break;
909 	case DRM_MODE_SCALE_ASPECT: rmx_type = RMX_ASPECT; break;
910 	default:
911 	case DRM_MODE_SCALE_FULLSCREEN: rmx_type = RMX_FULL; break;
912 	}
913 	if (radeon_encoder->rmx_type == rmx_type)
914 		return 0;
915 
916 	radeon_encoder->rmx_type = rmx_type;
917 
918 	radeon_property_change_mode(&radeon_encoder->base);
919 	return 0;
920 }
921 
922 
923 static const struct drm_connector_helper_funcs radeon_lvds_connector_helper_funcs = {
924 	.get_modes = radeon_lvds_get_modes,
925 	.mode_valid = radeon_lvds_mode_valid,
926 	.best_encoder = radeon_best_single_encoder,
927 };
928 
929 static const struct drm_connector_funcs radeon_lvds_connector_funcs = {
930 	.dpms = drm_helper_connector_dpms,
931 	.detect = radeon_lvds_detect,
932 	.fill_modes = drm_helper_probe_single_connector_modes,
933 	.destroy = radeon_connector_destroy,
934 	.set_property = radeon_lvds_set_property,
935 };
936 
937 static int radeon_vga_get_modes(struct drm_connector *connector)
938 {
939 	int ret;
940 
941 	radeon_connector_get_edid(connector);
942 	ret = radeon_ddc_get_modes(connector);
943 
944 	radeon_get_native_mode(connector);
945 
946 	return ret;
947 }
948 
949 static int radeon_vga_mode_valid(struct drm_connector *connector,
950 				  struct drm_display_mode *mode)
951 {
952 	struct drm_device *dev = connector->dev;
953 	struct radeon_device *rdev = dev->dev_private;
954 
955 	/* XXX check mode bandwidth */
956 
957 	if ((mode->clock / 10) > rdev->clock.max_pixel_clock)
958 		return MODE_CLOCK_HIGH;
959 
960 	return MODE_OK;
961 }
962 
963 static enum drm_connector_status
964 radeon_vga_detect(struct drm_connector *connector, bool force)
965 {
966 	struct drm_device *dev = connector->dev;
967 	struct radeon_device *rdev = dev->dev_private;
968 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
969 	struct drm_encoder *encoder;
970 	const struct drm_encoder_helper_funcs *encoder_funcs;
971 	bool dret = false;
972 	enum drm_connector_status ret = connector_status_disconnected;
973 #ifdef PM_TODO
974 	int r;
975 
976 	r = pm_runtime_get_sync(connector->dev->dev);
977 	if (r < 0)
978 		return connector_status_disconnected;
979 #endif
980 
981 	encoder = radeon_best_single_encoder(connector);
982 	if (!encoder)
983 		ret = connector_status_disconnected;
984 
985 	if (radeon_connector->ddc_bus)
986 		dret = radeon_ddc_probe(radeon_connector, false);
987 	if (dret) {
988 		radeon_connector->detected_by_load = false;
989 		radeon_connector_free_edid(connector);
990 		radeon_connector_get_edid(connector);
991 
992 		if (!radeon_connector->edid) {
993 			DRM_ERROR("%s: probed a monitor but no|invalid EDID\n",
994 					connector->name);
995 			ret = connector_status_connected;
996 		} else {
997 			radeon_connector->use_digital =
998 				!!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL);
999 
1000 			/* some oems have boards with separate digital and analog connectors
1001 			 * with a shared ddc line (often vga + hdmi)
1002 			 */
1003 			if (radeon_connector->use_digital && radeon_connector->shared_ddc) {
1004 				radeon_connector_free_edid(connector);
1005 				ret = connector_status_disconnected;
1006 			} else {
1007 				ret = connector_status_connected;
1008 			}
1009 		}
1010 	} else {
1011 
1012 		/* if we aren't forcing don't do destructive polling */
1013 		if (!force) {
1014 			/* only return the previous status if we last
1015 			 * detected a monitor via load.
1016 			 */
1017 			if (radeon_connector->detected_by_load)
1018 				ret = connector->status;
1019 			goto out;
1020 		}
1021 
1022 		if (radeon_connector->dac_load_detect && encoder) {
1023 			encoder_funcs = encoder->helper_private;
1024 			ret = encoder_funcs->detect(encoder, connector);
1025 			if (ret != connector_status_disconnected)
1026 				radeon_connector->detected_by_load = true;
1027 		}
1028 	}
1029 
1030 	if (ret == connector_status_connected)
1031 		ret = radeon_connector_analog_encoder_conflict_solve(connector, encoder, ret, true);
1032 
1033 	/* RN50 and some RV100 asics in servers often have a hardcoded EDID in the
1034 	 * vbios to deal with KVMs. If we have one and are not able to detect a monitor
1035 	 * by other means, assume the CRT is connected and use that EDID.
1036 	 */
1037 	if ((!rdev->is_atom_bios) &&
1038 	    (ret == connector_status_disconnected) &&
1039 	    rdev->mode_info.bios_hardcoded_edid_size) {
1040 		ret = connector_status_connected;
1041 	}
1042 
1043 	radeon_connector_update_scratch_regs(connector, ret);
1044 
1045 out:
1046 #ifdef PM_TODO
1047 	pm_runtime_mark_last_busy(connector->dev->dev);
1048 	pm_runtime_put_autosuspend(connector->dev->dev);
1049 #endif
1050 
1051 	return ret;
1052 }
1053 
1054 static const struct drm_connector_helper_funcs radeon_vga_connector_helper_funcs = {
1055 	.get_modes = radeon_vga_get_modes,
1056 	.mode_valid = radeon_vga_mode_valid,
1057 	.best_encoder = radeon_best_single_encoder,
1058 };
1059 
1060 static const struct drm_connector_funcs radeon_vga_connector_funcs = {
1061 	.dpms = drm_helper_connector_dpms,
1062 	.detect = radeon_vga_detect,
1063 	.fill_modes = drm_helper_probe_single_connector_modes,
1064 	.destroy = radeon_connector_destroy,
1065 	.set_property = radeon_connector_set_property,
1066 };
1067 
1068 static int radeon_tv_get_modes(struct drm_connector *connector)
1069 {
1070 	struct drm_device *dev = connector->dev;
1071 	struct radeon_device *rdev = dev->dev_private;
1072 	struct drm_display_mode *tv_mode;
1073 	struct drm_encoder *encoder;
1074 
1075 	encoder = radeon_best_single_encoder(connector);
1076 	if (!encoder)
1077 		return 0;
1078 
1079 	/* avivo chips can scale any mode */
1080 	if (rdev->family >= CHIP_RS600)
1081 		/* add scaled modes */
1082 		radeon_add_common_modes(encoder, connector);
1083 	else {
1084 		/* only 800x600 is supported right now on pre-avivo chips */
1085 		tv_mode = drm_cvt_mode(dev, 800, 600, 60, false, false, false);
1086 		tv_mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
1087 		drm_mode_probed_add(connector, tv_mode);
1088 	}
1089 	return 1;
1090 }
1091 
1092 static int radeon_tv_mode_valid(struct drm_connector *connector,
1093 				struct drm_display_mode *mode)
1094 {
1095 	if ((mode->hdisplay > 1024) || (mode->vdisplay > 768))
1096 		return MODE_CLOCK_RANGE;
1097 	return MODE_OK;
1098 }
1099 
1100 static enum drm_connector_status
1101 radeon_tv_detect(struct drm_connector *connector, bool force)
1102 {
1103 	struct drm_encoder *encoder;
1104 	const struct drm_encoder_helper_funcs *encoder_funcs;
1105 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1106 	enum drm_connector_status ret = connector_status_disconnected;
1107 #ifdef PM_TODO
1108 	int r;
1109 #endif
1110 
1111 	if (!radeon_connector->dac_load_detect)
1112 		return ret;
1113 
1114 #ifdef PM_TODO
1115 	r = pm_runtime_get_sync(connector->dev->dev);
1116 	if (r < 0)
1117 		return connector_status_disconnected;
1118 #endif
1119 
1120 	encoder = radeon_best_single_encoder(connector);
1121 	if (!encoder)
1122 		ret = connector_status_disconnected;
1123 	else {
1124 		encoder_funcs = encoder->helper_private;
1125 		ret = encoder_funcs->detect(encoder, connector);
1126 	}
1127 	if (ret == connector_status_connected)
1128 		ret = radeon_connector_analog_encoder_conflict_solve(connector, encoder, ret, false);
1129 	radeon_connector_update_scratch_regs(connector, ret);
1130 #ifdef PM_TODO
1131 	pm_runtime_mark_last_busy(connector->dev->dev);
1132 	pm_runtime_put_autosuspend(connector->dev->dev);
1133 #endif
1134 	return ret;
1135 }
1136 
1137 static const struct drm_connector_helper_funcs radeon_tv_connector_helper_funcs = {
1138 	.get_modes = radeon_tv_get_modes,
1139 	.mode_valid = radeon_tv_mode_valid,
1140 	.best_encoder = radeon_best_single_encoder,
1141 };
1142 
1143 static const struct drm_connector_funcs radeon_tv_connector_funcs = {
1144 	.dpms = drm_helper_connector_dpms,
1145 	.detect = radeon_tv_detect,
1146 	.fill_modes = drm_helper_probe_single_connector_modes,
1147 	.destroy = radeon_connector_destroy,
1148 	.set_property = radeon_connector_set_property,
1149 };
1150 
1151 static bool radeon_check_hpd_status_unchanged(struct drm_connector *connector)
1152 {
1153 	struct drm_device *dev = connector->dev;
1154 	struct radeon_device *rdev = dev->dev_private;
1155 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1156 	enum drm_connector_status status;
1157 
1158 	/* We only trust HPD on R600 and newer ASICS. */
1159 	if (rdev->family >= CHIP_R600
1160 	  && radeon_connector->hpd.hpd != RADEON_HPD_NONE) {
1161 		if (radeon_hpd_sense(rdev, radeon_connector->hpd.hpd))
1162 			status = connector_status_connected;
1163 		else
1164 			status = connector_status_disconnected;
1165 		if (connector->status == status)
1166 			return true;
1167 	}
1168 
1169 	return false;
1170 }
1171 
1172 /*
1173  * DVI is complicated
1174  * Do a DDC probe, if DDC probe passes, get the full EDID so
1175  * we can do analog/digital monitor detection at this point.
1176  * If the monitor is an analog monitor or we got no DDC,
1177  * we need to find the DAC encoder object for this connector.
1178  * If we got no DDC, we do load detection on the DAC encoder object.
1179  * If we got analog DDC or load detection passes on the DAC encoder
1180  * we have to check if this analog encoder is shared with anyone else (TV)
1181  * if its shared we have to set the other connector to disconnected.
1182  */
1183 static enum drm_connector_status
1184 radeon_dvi_detect(struct drm_connector *connector, bool force)
1185 {
1186 	struct drm_device *dev = connector->dev;
1187 	struct radeon_device *rdev = dev->dev_private;
1188 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1189 	struct drm_encoder *encoder = NULL;
1190 	const struct drm_encoder_helper_funcs *encoder_funcs;
1191 	int i;
1192 	enum drm_connector_status ret = connector_status_disconnected;
1193 	bool dret = false, broken_edid = false;
1194 
1195 #ifdef PM_TODO
1196 	r = pm_runtime_get_sync(connector->dev->dev);
1197 	if (r < 0)
1198 		return connector_status_disconnected;
1199 #endif
1200 
1201 	if (!force && radeon_check_hpd_status_unchanged(connector)) {
1202 		ret = connector->status;
1203 		goto exit;
1204 	}
1205 
1206 	if (radeon_connector->ddc_bus)
1207 		dret = radeon_ddc_probe(radeon_connector, false);
1208 	if (dret) {
1209 		radeon_connector->detected_by_load = false;
1210 		radeon_connector_free_edid(connector);
1211 		radeon_connector_get_edid(connector);
1212 
1213 		if (!radeon_connector->edid) {
1214 			DRM_ERROR("%s: probed a monitor but no|invalid EDID\n",
1215 					connector->name);
1216 			/* rs690 seems to have a problem with connectors not existing and always
1217 			 * return a block of 0's. If we see this just stop polling on this output */
1218 			if ((rdev->family == CHIP_RS690 || rdev->family == CHIP_RS740) &&
1219 			    radeon_connector->base.null_edid_counter) {
1220 				ret = connector_status_disconnected;
1221 				DRM_ERROR("%s: detected RS690 floating bus bug, stopping ddc detect\n",
1222 					  connector->name);
1223 				radeon_connector->ddc_bus = NULL;
1224 			} else {
1225 				ret = connector_status_connected;
1226 				broken_edid = true; /* defer use_digital to later */
1227 			}
1228 		} else {
1229 			radeon_connector->use_digital =
1230 				!!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL);
1231 
1232 			/* some oems have boards with separate digital and analog connectors
1233 			 * with a shared ddc line (often vga + hdmi)
1234 			 */
1235 			if ((!radeon_connector->use_digital) && radeon_connector->shared_ddc) {
1236 				radeon_connector_free_edid(connector);
1237 				ret = connector_status_disconnected;
1238 			} else {
1239 				ret = connector_status_connected;
1240 			}
1241 			/* This gets complicated.  We have boards with VGA + HDMI with a
1242 			 * shared DDC line and we have boards with DVI-D + HDMI with a shared
1243 			 * DDC line.  The latter is more complex because with DVI<->HDMI adapters
1244 			 * you don't really know what's connected to which port as both are digital.
1245 			 */
1246 			if (radeon_connector->shared_ddc && (ret == connector_status_connected)) {
1247 				struct drm_connector *list_connector;
1248 				struct radeon_connector *list_radeon_connector;
1249 				list_for_each_entry(list_connector, &dev->mode_config.connector_list, head) {
1250 					if (connector == list_connector)
1251 						continue;
1252 					list_radeon_connector = to_radeon_connector(list_connector);
1253 					if (list_radeon_connector->shared_ddc &&
1254 					    (list_radeon_connector->ddc_bus->rec.i2c_id ==
1255 					     radeon_connector->ddc_bus->rec.i2c_id)) {
1256 						/* cases where both connectors are digital */
1257 						if (list_connector->connector_type != DRM_MODE_CONNECTOR_VGA) {
1258 							/* hpd is our only option in this case */
1259 							if (!radeon_hpd_sense(rdev, radeon_connector->hpd.hpd)) {
1260 								radeon_connector_free_edid(connector);
1261 								ret = connector_status_disconnected;
1262 							}
1263 						}
1264 					}
1265 				}
1266 			}
1267 		}
1268 	}
1269 
1270 	if ((ret == connector_status_connected) && (radeon_connector->use_digital == true))
1271 		goto out;
1272 
1273 	/* DVI-D and HDMI-A are digital only */
1274 	if ((connector->connector_type == DRM_MODE_CONNECTOR_DVID) ||
1275 	    (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA))
1276 		goto out;
1277 
1278 	/* if we aren't forcing don't do destructive polling */
1279 	if (!force) {
1280 		/* only return the previous status if we last
1281 		 * detected a monitor via load.
1282 		 */
1283 		if (radeon_connector->detected_by_load)
1284 			ret = connector->status;
1285 		goto out;
1286 	}
1287 
1288 	/* find analog encoder */
1289 	if (radeon_connector->dac_load_detect) {
1290 		for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
1291 			if (connector->encoder_ids[i] == 0)
1292 				break;
1293 
1294 			encoder = drm_encoder_find(connector->dev,
1295 						   connector->encoder_ids[i]);
1296 			if (!encoder)
1297 				continue;
1298 
1299 			if (encoder->encoder_type != DRM_MODE_ENCODER_DAC &&
1300 			    encoder->encoder_type != DRM_MODE_ENCODER_TVDAC)
1301 				continue;
1302 
1303 			encoder_funcs = encoder->helper_private;
1304 			if (encoder_funcs->detect) {
1305 				if (!broken_edid) {
1306 					if (ret != connector_status_connected) {
1307 						/* deal with analog monitors without DDC */
1308 						ret = encoder_funcs->detect(encoder, connector);
1309 						if (ret == connector_status_connected) {
1310 							radeon_connector->use_digital = false;
1311 						}
1312 						if (ret != connector_status_disconnected)
1313 							radeon_connector->detected_by_load = true;
1314 					}
1315 				} else {
1316 					enum drm_connector_status lret;
1317 					/* assume digital unless load detected otherwise */
1318 					radeon_connector->use_digital = true;
1319 					lret = encoder_funcs->detect(encoder, connector);
1320 					DRM_DEBUG_KMS("load_detect %x returned: %x\n",encoder->encoder_type,lret);
1321 					if (lret == connector_status_connected)
1322 						radeon_connector->use_digital = false;
1323 				}
1324 				break;
1325 			}
1326 		}
1327 	}
1328 
1329 	if ((ret == connector_status_connected) && (radeon_connector->use_digital == false) &&
1330 	    encoder) {
1331 		ret = radeon_connector_analog_encoder_conflict_solve(connector, encoder, ret, true);
1332 	}
1333 
1334 	/* RN50 and some RV100 asics in servers often have a hardcoded EDID in the
1335 	 * vbios to deal with KVMs. If we have one and are not able to detect a monitor
1336 	 * by other means, assume the DFP is connected and use that EDID.  In most
1337 	 * cases the DVI port is actually a virtual KVM port connected to the service
1338 	 * processor.
1339 	 */
1340 out:
1341 	if ((!rdev->is_atom_bios) &&
1342 	    (ret == connector_status_disconnected) &&
1343 	    rdev->mode_info.bios_hardcoded_edid_size) {
1344 		radeon_connector->use_digital = true;
1345 		ret = connector_status_connected;
1346 	}
1347 
1348 	/* updated in get modes as well since we need to know if it's analog or digital */
1349 	radeon_connector_update_scratch_regs(connector, ret);
1350 
1351 exit:
1352 #ifdef PM_TODO
1353 	pm_runtime_mark_last_busy(connector->dev->dev);
1354 	pm_runtime_put_autosuspend(connector->dev->dev);
1355 #endif
1356 
1357 	return ret;
1358 }
1359 
1360 /* okay need to be smart in here about which encoder to pick */
1361 static struct drm_encoder *radeon_dvi_encoder(struct drm_connector *connector)
1362 {
1363 	int enc_id = connector->encoder_ids[0];
1364 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1365 	struct drm_encoder *encoder;
1366 	int i;
1367 	for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
1368 		if (connector->encoder_ids[i] == 0)
1369 			break;
1370 
1371 		encoder = drm_encoder_find(connector->dev, connector->encoder_ids[i]);
1372 		if (!encoder)
1373 			continue;
1374 
1375 		if (radeon_connector->use_digital == true) {
1376 			if (encoder->encoder_type == DRM_MODE_ENCODER_TMDS)
1377 				return encoder;
1378 		} else {
1379 			if (encoder->encoder_type == DRM_MODE_ENCODER_DAC ||
1380 			    encoder->encoder_type == DRM_MODE_ENCODER_TVDAC)
1381 				return encoder;
1382 		}
1383 	}
1384 
1385 	/* see if we have a default encoder  TODO */
1386 
1387 	/* then check use digitial */
1388 	/* pick the first one */
1389 	if (enc_id)
1390 		return drm_encoder_find(connector->dev, enc_id);
1391 	return NULL;
1392 }
1393 
1394 static void radeon_dvi_force(struct drm_connector *connector)
1395 {
1396 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1397 	if (connector->force == DRM_FORCE_ON)
1398 		radeon_connector->use_digital = false;
1399 	if (connector->force == DRM_FORCE_ON_DIGITAL)
1400 		radeon_connector->use_digital = true;
1401 }
1402 
1403 static int radeon_dvi_mode_valid(struct drm_connector *connector,
1404 				  struct drm_display_mode *mode)
1405 {
1406 	struct drm_device *dev = connector->dev;
1407 	struct radeon_device *rdev = dev->dev_private;
1408 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1409 
1410 	/* XXX check mode bandwidth */
1411 
1412 	/* clocks over 135 MHz have heat issues with DVI on RV100 */
1413 	if (radeon_connector->use_digital &&
1414 	    (rdev->family == CHIP_RV100) &&
1415 	    (mode->clock > 135000))
1416 		return MODE_CLOCK_HIGH;
1417 
1418 	if (radeon_connector->use_digital && (mode->clock > 165000)) {
1419 		if ((radeon_connector->connector_object_id == CONNECTOR_OBJECT_ID_DUAL_LINK_DVI_I) ||
1420 		    (radeon_connector->connector_object_id == CONNECTOR_OBJECT_ID_DUAL_LINK_DVI_D) ||
1421 		    (radeon_connector->connector_object_id == CONNECTOR_OBJECT_ID_HDMI_TYPE_B))
1422 			return MODE_OK;
1423 		else if (ASIC_IS_DCE6(rdev) && drm_detect_hdmi_monitor(radeon_connector_edid(connector))) {
1424 			/* HDMI 1.3+ supports max clock of 340 Mhz */
1425 			if (mode->clock > 340000)
1426 				return MODE_CLOCK_HIGH;
1427 			else
1428 				return MODE_OK;
1429 		} else {
1430 			return MODE_CLOCK_HIGH;
1431 		}
1432 	}
1433 
1434 	/* check against the max pixel clock */
1435 	if ((mode->clock / 10) > rdev->clock.max_pixel_clock)
1436 		return MODE_CLOCK_HIGH;
1437 
1438 	return MODE_OK;
1439 }
1440 
1441 static const struct drm_connector_helper_funcs radeon_dvi_connector_helper_funcs = {
1442 	.get_modes = radeon_vga_get_modes,
1443 	.mode_valid = radeon_dvi_mode_valid,
1444 	.best_encoder = radeon_dvi_encoder,
1445 };
1446 
1447 static const struct drm_connector_funcs radeon_dvi_connector_funcs = {
1448 	.dpms = drm_helper_connector_dpms,
1449 	.detect = radeon_dvi_detect,
1450 	.fill_modes = drm_helper_probe_single_connector_modes,
1451 	.set_property = radeon_connector_set_property,
1452 	.destroy = radeon_connector_destroy,
1453 	.force = radeon_dvi_force,
1454 };
1455 
1456 static int radeon_dp_get_modes(struct drm_connector *connector)
1457 {
1458 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1459 	struct radeon_connector_atom_dig *radeon_dig_connector = radeon_connector->con_priv;
1460 	struct drm_encoder *encoder = radeon_best_single_encoder(connector);
1461 	int ret;
1462 
1463 	if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) ||
1464 	    (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)) {
1465 		struct drm_display_mode *mode;
1466 
1467 		if (connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
1468 			if (!radeon_dig_connector->edp_on)
1469 				atombios_set_edp_panel_power(connector,
1470 							     ATOM_TRANSMITTER_ACTION_POWER_ON);
1471 			radeon_connector_get_edid(connector);
1472 			ret = radeon_ddc_get_modes(connector);
1473 			if (!radeon_dig_connector->edp_on)
1474 				atombios_set_edp_panel_power(connector,
1475 							     ATOM_TRANSMITTER_ACTION_POWER_OFF);
1476 		} else {
1477 			/* need to setup ddc on the bridge */
1478 			if (radeon_connector_encoder_get_dp_bridge_encoder_id(connector) !=
1479 			    ENCODER_OBJECT_ID_NONE) {
1480 				if (encoder)
1481 					radeon_atom_ext_encoder_setup_ddc(encoder);
1482 			}
1483 			radeon_connector_get_edid(connector);
1484 			ret = radeon_ddc_get_modes(connector);
1485 		}
1486 
1487 		if (ret > 0) {
1488 			if (encoder) {
1489 				radeon_fixup_lvds_native_mode(encoder, connector);
1490 				/* add scaled modes */
1491 				radeon_add_common_modes(encoder, connector);
1492 			}
1493 			return ret;
1494 		}
1495 
1496 		if (!encoder)
1497 			return 0;
1498 
1499 		/* we have no EDID modes */
1500 		mode = radeon_fp_native_mode(encoder);
1501 		if (mode) {
1502 			ret = 1;
1503 			drm_mode_probed_add(connector, mode);
1504 			/* add the width/height from vbios tables if available */
1505 			connector->display_info.width_mm = mode->width_mm;
1506 			connector->display_info.height_mm = mode->height_mm;
1507 			/* add scaled modes */
1508 			radeon_add_common_modes(encoder, connector);
1509 		}
1510 	} else {
1511 		/* need to setup ddc on the bridge */
1512 		if (radeon_connector_encoder_get_dp_bridge_encoder_id(connector) !=
1513 			ENCODER_OBJECT_ID_NONE) {
1514 			if (encoder)
1515 				radeon_atom_ext_encoder_setup_ddc(encoder);
1516 		}
1517 		radeon_connector_get_edid(connector);
1518 		ret = radeon_ddc_get_modes(connector);
1519 
1520 		radeon_get_native_mode(connector);
1521 	}
1522 
1523 	return ret;
1524 }
1525 
1526 u16 radeon_connector_encoder_get_dp_bridge_encoder_id(struct drm_connector *connector)
1527 {
1528 	struct drm_encoder *encoder;
1529 	struct radeon_encoder *radeon_encoder;
1530 	int i;
1531 
1532 	for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
1533 		if (connector->encoder_ids[i] == 0)
1534 			break;
1535 
1536 		encoder = drm_encoder_find(connector->dev, connector->encoder_ids[i]);
1537 		if (!encoder)
1538 			continue;
1539 
1540 		radeon_encoder = to_radeon_encoder(encoder);
1541 
1542 		switch (radeon_encoder->encoder_id) {
1543 		case ENCODER_OBJECT_ID_TRAVIS:
1544 		case ENCODER_OBJECT_ID_NUTMEG:
1545 			return radeon_encoder->encoder_id;
1546 		default:
1547 			break;
1548 		}
1549 	}
1550 
1551 	return ENCODER_OBJECT_ID_NONE;
1552 }
1553 
1554 static bool radeon_connector_encoder_is_hbr2(struct drm_connector *connector)
1555 {
1556 	struct drm_encoder *encoder;
1557 	struct radeon_encoder *radeon_encoder;
1558 	int i;
1559 	bool found = false;
1560 
1561 	for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
1562 		if (connector->encoder_ids[i] == 0)
1563 			break;
1564 
1565 		encoder = drm_encoder_find(connector->dev, connector->encoder_ids[i]);
1566 		if (!encoder)
1567 			continue;
1568 
1569 		radeon_encoder = to_radeon_encoder(encoder);
1570 		if (radeon_encoder->caps & ATOM_ENCODER_CAP_RECORD_HBR2)
1571 			found = true;
1572 	}
1573 
1574 	return found;
1575 }
1576 
1577 bool radeon_connector_is_dp12_capable(struct drm_connector *connector)
1578 {
1579 	struct drm_device *dev = connector->dev;
1580 	struct radeon_device *rdev = dev->dev_private;
1581 
1582 	if (ASIC_IS_DCE5(rdev) &&
1583 	    (rdev->clock.default_dispclk >= 53900) &&
1584 	    radeon_connector_encoder_is_hbr2(connector)) {
1585 		return true;
1586 	}
1587 
1588 	return false;
1589 }
1590 
1591 static enum drm_connector_status
1592 radeon_dp_detect(struct drm_connector *connector, bool force)
1593 {
1594 	struct drm_device *dev = connector->dev;
1595 	struct radeon_device *rdev = dev->dev_private;
1596 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1597 	enum drm_connector_status ret = connector_status_disconnected;
1598 	struct radeon_connector_atom_dig *radeon_dig_connector = radeon_connector->con_priv;
1599 	struct drm_encoder *encoder = radeon_best_single_encoder(connector);
1600 #ifdef PM_TODO
1601 	int r;
1602 
1603 	r = pm_runtime_get_sync(connector->dev->dev);
1604 	if (r < 0)
1605 		return connector_status_disconnected;
1606 #endif
1607 
1608 	if (!force && radeon_check_hpd_status_unchanged(connector)) {
1609 		ret = connector->status;
1610 		goto out;
1611 	}
1612 
1613 	radeon_connector_free_edid(connector);
1614 
1615 	if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) ||
1616 	    (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)) {
1617 		if (encoder) {
1618 			struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
1619 			struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
1620 
1621 			/* check if panel is valid */
1622 			if (native_mode->hdisplay >= 320 && native_mode->vdisplay >= 240)
1623 				ret = connector_status_connected;
1624 			/* don't fetch the edid from the vbios if ddc fails and runpm is
1625 			 * enabled so we report disconnected.
1626 			 */
1627 			if ((rdev->flags & RADEON_IS_PX) && (radeon_runtime_pm != 0))
1628 				ret = connector_status_disconnected;
1629 		}
1630 		/* eDP is always DP */
1631 		radeon_dig_connector->dp_sink_type = CONNECTOR_OBJECT_ID_DISPLAYPORT;
1632 		if (!radeon_dig_connector->edp_on)
1633 			atombios_set_edp_panel_power(connector,
1634 						     ATOM_TRANSMITTER_ACTION_POWER_ON);
1635 		if (radeon_dp_getdpcd(radeon_connector))
1636 			ret = connector_status_connected;
1637 		if (!radeon_dig_connector->edp_on)
1638 			atombios_set_edp_panel_power(connector,
1639 						     ATOM_TRANSMITTER_ACTION_POWER_OFF);
1640 	} else if (radeon_connector_encoder_get_dp_bridge_encoder_id(connector) !=
1641 		   ENCODER_OBJECT_ID_NONE) {
1642 		/* DP bridges are always DP */
1643 		radeon_dig_connector->dp_sink_type = CONNECTOR_OBJECT_ID_DISPLAYPORT;
1644 		/* get the DPCD from the bridge */
1645 		radeon_dp_getdpcd(radeon_connector);
1646 
1647 		if (encoder) {
1648 			/* setup ddc on the bridge */
1649 			radeon_atom_ext_encoder_setup_ddc(encoder);
1650 			/* bridge chips are always aux */
1651 			if (radeon_ddc_probe(radeon_connector, true)) /* try DDC */
1652 				ret = connector_status_connected;
1653 			else if (radeon_connector->dac_load_detect) { /* try load detection */
1654 				const struct drm_encoder_helper_funcs *encoder_funcs = encoder->helper_private;
1655 				ret = encoder_funcs->detect(encoder, connector);
1656 			}
1657 		}
1658 	} else {
1659 		radeon_dig_connector->dp_sink_type = radeon_dp_getsinktype(radeon_connector);
1660 		if (radeon_hpd_sense(rdev, radeon_connector->hpd.hpd)) {
1661 			ret = connector_status_connected;
1662 			if (radeon_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT)
1663 				radeon_dp_getdpcd(radeon_connector);
1664 		} else {
1665 			if (radeon_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) {
1666 				if (radeon_dp_getdpcd(radeon_connector))
1667 					ret = connector_status_connected;
1668 			} else {
1669 				/* try non-aux ddc (DP to DVI/HDMI/etc. adapter) */
1670 				if (radeon_ddc_probe(radeon_connector, false))
1671 					ret = connector_status_connected;
1672 			}
1673 		}
1674 	}
1675 
1676 	radeon_connector_update_scratch_regs(connector, ret);
1677 out:
1678 #ifdef PM_TODO
1679 	pm_runtime_mark_last_busy(connector->dev->dev);
1680 	pm_runtime_put_autosuspend(connector->dev->dev);
1681 #endif
1682 
1683 	return ret;
1684 }
1685 
1686 static int radeon_dp_mode_valid(struct drm_connector *connector,
1687 				  struct drm_display_mode *mode)
1688 {
1689 	struct drm_device *dev = connector->dev;
1690 	struct radeon_device *rdev = dev->dev_private;
1691 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1692 	struct radeon_connector_atom_dig *radeon_dig_connector = radeon_connector->con_priv;
1693 
1694 	/* XXX check mode bandwidth */
1695 
1696 	if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) ||
1697 	    (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)) {
1698 		struct drm_encoder *encoder = radeon_best_single_encoder(connector);
1699 
1700 		if ((mode->hdisplay < 320) || (mode->vdisplay < 240))
1701 			return MODE_PANEL;
1702 
1703 		if (encoder) {
1704 			struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
1705 			struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
1706 
1707 			/* AVIVO hardware supports downscaling modes larger than the panel
1708 			 * to the panel size, but I'm not sure this is desirable.
1709 			 */
1710 			if ((mode->hdisplay > native_mode->hdisplay) ||
1711 			    (mode->vdisplay > native_mode->vdisplay))
1712 				return MODE_PANEL;
1713 
1714 			/* if scaling is disabled, block non-native modes */
1715 			if (radeon_encoder->rmx_type == RMX_OFF) {
1716 				if ((mode->hdisplay != native_mode->hdisplay) ||
1717 				    (mode->vdisplay != native_mode->vdisplay))
1718 					return MODE_PANEL;
1719 			}
1720 		}
1721 	} else {
1722 		if ((radeon_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) ||
1723 		    (radeon_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_eDP)) {
1724 			return radeon_dp_mode_valid_helper(connector, mode);
1725 		} else {
1726 			if (ASIC_IS_DCE6(rdev) && drm_detect_hdmi_monitor(radeon_connector_edid(connector))) {
1727 				/* HDMI 1.3+ supports max clock of 340 Mhz */
1728 				if (mode->clock > 340000)
1729 					return MODE_CLOCK_HIGH;
1730 			} else {
1731 				if (mode->clock > 165000)
1732 					return MODE_CLOCK_HIGH;
1733 			}
1734 		}
1735 	}
1736 
1737 	return MODE_OK;
1738 }
1739 
1740 static const struct drm_connector_helper_funcs radeon_dp_connector_helper_funcs = {
1741 	.get_modes = radeon_dp_get_modes,
1742 	.mode_valid = radeon_dp_mode_valid,
1743 	.best_encoder = radeon_dvi_encoder,
1744 };
1745 
1746 static const struct drm_connector_funcs radeon_dp_connector_funcs = {
1747 	.dpms = drm_helper_connector_dpms,
1748 	.detect = radeon_dp_detect,
1749 	.fill_modes = drm_helper_probe_single_connector_modes,
1750 	.set_property = radeon_connector_set_property,
1751 	.destroy = radeon_connector_destroy,
1752 	.force = radeon_dvi_force,
1753 };
1754 
1755 static const struct drm_connector_funcs radeon_edp_connector_funcs = {
1756 	.dpms = drm_helper_connector_dpms,
1757 	.detect = radeon_dp_detect,
1758 	.fill_modes = drm_helper_probe_single_connector_modes,
1759 	.set_property = radeon_lvds_set_property,
1760 	.destroy = radeon_connector_destroy,
1761 	.force = radeon_dvi_force,
1762 };
1763 
1764 static const struct drm_connector_funcs radeon_lvds_bridge_connector_funcs = {
1765 	.dpms = drm_helper_connector_dpms,
1766 	.detect = radeon_dp_detect,
1767 	.fill_modes = drm_helper_probe_single_connector_modes,
1768 	.set_property = radeon_lvds_set_property,
1769 	.destroy = radeon_connector_destroy,
1770 	.force = radeon_dvi_force,
1771 };
1772 
1773 void
1774 radeon_add_atom_connector(struct drm_device *dev,
1775 			  uint32_t connector_id,
1776 			  uint32_t supported_device,
1777 			  int connector_type,
1778 			  struct radeon_i2c_bus_rec *i2c_bus,
1779 			  uint32_t igp_lane_info,
1780 			  uint16_t connector_object_id,
1781 			  struct radeon_hpd *hpd,
1782 			  struct radeon_router *router)
1783 {
1784 	struct radeon_device *rdev = dev->dev_private;
1785 	struct drm_connector *connector;
1786 	struct radeon_connector *radeon_connector;
1787 	struct radeon_connector_atom_dig *radeon_dig_connector;
1788 	struct drm_encoder *encoder;
1789 	struct radeon_encoder *radeon_encoder;
1790 	uint32_t subpixel_order = SubPixelNone;
1791 	bool shared_ddc = false;
1792 	bool is_dp_bridge = false;
1793 	bool has_aux = false;
1794 
1795 	if (connector_type == DRM_MODE_CONNECTOR_Unknown)
1796 		return;
1797 
1798 	/* if the user selected tv=0 don't try and add the connector */
1799 	if (((connector_type == DRM_MODE_CONNECTOR_SVIDEO) ||
1800 	     (connector_type == DRM_MODE_CONNECTOR_Composite) ||
1801 	     (connector_type == DRM_MODE_CONNECTOR_9PinDIN)) &&
1802 	    (radeon_tv == 0))
1803 		return;
1804 
1805 	/* see if we already added it */
1806 	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
1807 		radeon_connector = to_radeon_connector(connector);
1808 		if (radeon_connector->connector_id == connector_id) {
1809 			radeon_connector->devices |= supported_device;
1810 			return;
1811 		}
1812 		if (radeon_connector->ddc_bus && i2c_bus->valid) {
1813 			if (radeon_connector->ddc_bus->rec.i2c_id == i2c_bus->i2c_id) {
1814 				radeon_connector->shared_ddc = true;
1815 				shared_ddc = true;
1816 			}
1817 			if (radeon_connector->router_bus && router->ddc_valid &&
1818 			    (radeon_connector->router.router_id == router->router_id)) {
1819 				radeon_connector->shared_ddc = false;
1820 				shared_ddc = false;
1821 			}
1822 		}
1823 	}
1824 
1825 	/* check if it's a dp bridge */
1826 	list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
1827 		radeon_encoder = to_radeon_encoder(encoder);
1828 		if (radeon_encoder->devices & supported_device) {
1829 			switch (radeon_encoder->encoder_id) {
1830 			case ENCODER_OBJECT_ID_TRAVIS:
1831 			case ENCODER_OBJECT_ID_NUTMEG:
1832 				is_dp_bridge = true;
1833 				break;
1834 			default:
1835 				break;
1836 			}
1837 		}
1838 	}
1839 
1840 	radeon_connector = kzalloc(sizeof(struct radeon_connector), GFP_KERNEL);
1841 	if (!radeon_connector)
1842 		return;
1843 
1844 	connector = &radeon_connector->base;
1845 
1846 	radeon_connector->connector_id = connector_id;
1847 	radeon_connector->devices = supported_device;
1848 	radeon_connector->shared_ddc = shared_ddc;
1849 	radeon_connector->connector_object_id = connector_object_id;
1850 	radeon_connector->hpd = *hpd;
1851 
1852 	radeon_connector->router = *router;
1853 	if (router->ddc_valid || router->cd_valid) {
1854 		radeon_connector->router_bus = radeon_i2c_lookup(rdev, &router->i2c_info);
1855 		if (!radeon_connector->router_bus)
1856 			DRM_ERROR("Failed to assign router i2c bus! Check dmesg for i2c errors.\n");
1857 	}
1858 
1859 	if (is_dp_bridge) {
1860 		radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
1861 		if (!radeon_dig_connector)
1862 			goto failed;
1863 		radeon_dig_connector->igp_lane_info = igp_lane_info;
1864 		radeon_connector->con_priv = radeon_dig_connector;
1865 		if (i2c_bus->valid) {
1866 			radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1867 			if (radeon_connector->ddc_bus)
1868 				has_aux = true;
1869 			else
1870 				DRM_ERROR("DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1871 		}
1872 		switch (connector_type) {
1873 		case DRM_MODE_CONNECTOR_VGA:
1874 		case DRM_MODE_CONNECTOR_DVIA:
1875 		default:
1876 			drm_connector_init(dev, &radeon_connector->base,
1877 					   &radeon_dp_connector_funcs, connector_type);
1878 			drm_connector_helper_add(&radeon_connector->base,
1879 						 &radeon_dp_connector_helper_funcs);
1880 			connector->interlace_allowed = true;
1881 			connector->doublescan_allowed = true;
1882 			radeon_connector->dac_load_detect = true;
1883 			drm_object_attach_property(&radeon_connector->base.base,
1884 						      rdev->mode_info.load_detect_property,
1885 						      1);
1886 			drm_object_attach_property(&radeon_connector->base.base,
1887 						   dev->mode_config.scaling_mode_property,
1888 						   DRM_MODE_SCALE_NONE);
1889 			break;
1890 		case DRM_MODE_CONNECTOR_DVII:
1891 		case DRM_MODE_CONNECTOR_DVID:
1892 		case DRM_MODE_CONNECTOR_HDMIA:
1893 		case DRM_MODE_CONNECTOR_HDMIB:
1894 		case DRM_MODE_CONNECTOR_DisplayPort:
1895 			drm_connector_init(dev, &radeon_connector->base,
1896 					   &radeon_dp_connector_funcs, connector_type);
1897 			drm_connector_helper_add(&radeon_connector->base,
1898 						 &radeon_dp_connector_helper_funcs);
1899 			drm_object_attach_property(&radeon_connector->base.base,
1900 						      rdev->mode_info.underscan_property,
1901 						      UNDERSCAN_OFF);
1902 			drm_object_attach_property(&radeon_connector->base.base,
1903 						      rdev->mode_info.underscan_hborder_property,
1904 						      0);
1905 			drm_object_attach_property(&radeon_connector->base.base,
1906 						      rdev->mode_info.underscan_vborder_property,
1907 						      0);
1908 
1909 			drm_object_attach_property(&radeon_connector->base.base,
1910 						      dev->mode_config.scaling_mode_property,
1911 						      DRM_MODE_SCALE_NONE);
1912 
1913 			drm_object_attach_property(&radeon_connector->base.base,
1914 						   rdev->mode_info.dither_property,
1915 						   RADEON_FMT_DITHER_DISABLE);
1916 
1917 			if (radeon_audio != 0)
1918 				drm_object_attach_property(&radeon_connector->base.base,
1919 							   rdev->mode_info.audio_property,
1920 							   RADEON_AUDIO_AUTO);
1921 
1922 			subpixel_order = SubPixelHorizontalRGB;
1923 			connector->interlace_allowed = true;
1924 			if (connector_type == DRM_MODE_CONNECTOR_HDMIB)
1925 				connector->doublescan_allowed = true;
1926 			else
1927 				connector->doublescan_allowed = false;
1928 			if (connector_type == DRM_MODE_CONNECTOR_DVII) {
1929 				radeon_connector->dac_load_detect = true;
1930 				drm_object_attach_property(&radeon_connector->base.base,
1931 							      rdev->mode_info.load_detect_property,
1932 							      1);
1933 			}
1934 			break;
1935 		case DRM_MODE_CONNECTOR_LVDS:
1936 		case DRM_MODE_CONNECTOR_eDP:
1937 			drm_connector_init(dev, &radeon_connector->base,
1938 					   &radeon_lvds_bridge_connector_funcs, connector_type);
1939 			drm_connector_helper_add(&radeon_connector->base,
1940 						 &radeon_dp_connector_helper_funcs);
1941 			drm_object_attach_property(&radeon_connector->base.base,
1942 						      dev->mode_config.scaling_mode_property,
1943 						      DRM_MODE_SCALE_FULLSCREEN);
1944 			subpixel_order = SubPixelHorizontalRGB;
1945 			connector->interlace_allowed = false;
1946 			connector->doublescan_allowed = false;
1947 			break;
1948 		}
1949 	} else {
1950 		switch (connector_type) {
1951 		case DRM_MODE_CONNECTOR_VGA:
1952 			drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
1953 			drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
1954 			if (i2c_bus->valid) {
1955 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1956 				if (!radeon_connector->ddc_bus)
1957 					DRM_ERROR("VGA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1958 			}
1959 			radeon_connector->dac_load_detect = true;
1960 			drm_object_attach_property(&radeon_connector->base.base,
1961 						      rdev->mode_info.load_detect_property,
1962 						      1);
1963 			if (ASIC_IS_AVIVO(rdev))
1964 				drm_object_attach_property(&radeon_connector->base.base,
1965 							   dev->mode_config.scaling_mode_property,
1966 							   DRM_MODE_SCALE_NONE);
1967 			/* no HPD on analog connectors */
1968 			radeon_connector->hpd.hpd = RADEON_HPD_NONE;
1969 			connector->polled = DRM_CONNECTOR_POLL_CONNECT;
1970 			connector->interlace_allowed = true;
1971 			connector->doublescan_allowed = true;
1972 			break;
1973 		case DRM_MODE_CONNECTOR_DVIA:
1974 			drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
1975 			drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
1976 			if (i2c_bus->valid) {
1977 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1978 				if (!radeon_connector->ddc_bus)
1979 					DRM_ERROR("DVIA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1980 			}
1981 			radeon_connector->dac_load_detect = true;
1982 			drm_object_attach_property(&radeon_connector->base.base,
1983 						      rdev->mode_info.load_detect_property,
1984 						      1);
1985 			if (ASIC_IS_AVIVO(rdev))
1986 				drm_object_attach_property(&radeon_connector->base.base,
1987 							   dev->mode_config.scaling_mode_property,
1988 							   DRM_MODE_SCALE_NONE);
1989 			/* no HPD on analog connectors */
1990 			radeon_connector->hpd.hpd = RADEON_HPD_NONE;
1991 			connector->interlace_allowed = true;
1992 			connector->doublescan_allowed = true;
1993 			break;
1994 		case DRM_MODE_CONNECTOR_DVII:
1995 		case DRM_MODE_CONNECTOR_DVID:
1996 			radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
1997 			if (!radeon_dig_connector)
1998 				goto failed;
1999 			radeon_dig_connector->igp_lane_info = igp_lane_info;
2000 			radeon_connector->con_priv = radeon_dig_connector;
2001 			drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
2002 			drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
2003 			if (i2c_bus->valid) {
2004 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2005 				if (!radeon_connector->ddc_bus)
2006 					DRM_ERROR("DVI: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2007 			}
2008 			subpixel_order = SubPixelHorizontalRGB;
2009 			drm_object_attach_property(&radeon_connector->base.base,
2010 						      rdev->mode_info.coherent_mode_property,
2011 						      1);
2012 			if (ASIC_IS_AVIVO(rdev)) {
2013 				drm_object_attach_property(&radeon_connector->base.base,
2014 							      rdev->mode_info.underscan_property,
2015 							      UNDERSCAN_OFF);
2016 				drm_object_attach_property(&radeon_connector->base.base,
2017 							      rdev->mode_info.underscan_hborder_property,
2018 							      0);
2019 				drm_object_attach_property(&radeon_connector->base.base,
2020 							      rdev->mode_info.underscan_vborder_property,
2021 							      0);
2022 				drm_object_attach_property(&radeon_connector->base.base,
2023 							   rdev->mode_info.dither_property,
2024 							   RADEON_FMT_DITHER_DISABLE);
2025 				drm_object_attach_property(&radeon_connector->base.base,
2026 							   dev->mode_config.scaling_mode_property,
2027 							   DRM_MODE_SCALE_NONE);
2028 			}
2029 			if (ASIC_IS_DCE2(rdev) && (radeon_audio != 0)) {
2030 				drm_object_attach_property(&radeon_connector->base.base,
2031 							   rdev->mode_info.audio_property,
2032 							   RADEON_AUDIO_AUTO);
2033 			}
2034 			if (connector_type == DRM_MODE_CONNECTOR_DVII) {
2035 				radeon_connector->dac_load_detect = true;
2036 				drm_object_attach_property(&radeon_connector->base.base,
2037 							      rdev->mode_info.load_detect_property,
2038 							      1);
2039 			}
2040 			connector->interlace_allowed = true;
2041 			if (connector_type == DRM_MODE_CONNECTOR_DVII)
2042 				connector->doublescan_allowed = true;
2043 			else
2044 				connector->doublescan_allowed = false;
2045 			break;
2046 		case DRM_MODE_CONNECTOR_HDMIA:
2047 		case DRM_MODE_CONNECTOR_HDMIB:
2048 			radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
2049 			if (!radeon_dig_connector)
2050 				goto failed;
2051 			radeon_dig_connector->igp_lane_info = igp_lane_info;
2052 			radeon_connector->con_priv = radeon_dig_connector;
2053 			drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
2054 			drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
2055 			if (i2c_bus->valid) {
2056 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2057 				if (!radeon_connector->ddc_bus)
2058 					DRM_ERROR("HDMI: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2059 			}
2060 			drm_object_attach_property(&radeon_connector->base.base,
2061 						      rdev->mode_info.coherent_mode_property,
2062 						      1);
2063 			if (ASIC_IS_AVIVO(rdev)) {
2064 				drm_object_attach_property(&radeon_connector->base.base,
2065 							      rdev->mode_info.underscan_property,
2066 							      UNDERSCAN_OFF);
2067 				drm_object_attach_property(&radeon_connector->base.base,
2068 							      rdev->mode_info.underscan_hborder_property,
2069 							      0);
2070 				drm_object_attach_property(&radeon_connector->base.base,
2071 							      rdev->mode_info.underscan_vborder_property,
2072 							      0);
2073 				drm_object_attach_property(&radeon_connector->base.base,
2074 							   rdev->mode_info.dither_property,
2075 							   RADEON_FMT_DITHER_DISABLE);
2076 				drm_object_attach_property(&radeon_connector->base.base,
2077 							   dev->mode_config.scaling_mode_property,
2078 							   DRM_MODE_SCALE_NONE);
2079 			}
2080 			if (ASIC_IS_DCE2(rdev) && (radeon_audio != 0)) {
2081 				drm_object_attach_property(&radeon_connector->base.base,
2082 							   rdev->mode_info.audio_property,
2083 							   RADEON_AUDIO_AUTO);
2084 			}
2085 			subpixel_order = SubPixelHorizontalRGB;
2086 			connector->interlace_allowed = true;
2087 			if (connector_type == DRM_MODE_CONNECTOR_HDMIB)
2088 				connector->doublescan_allowed = true;
2089 			else
2090 				connector->doublescan_allowed = false;
2091 			break;
2092 		case DRM_MODE_CONNECTOR_DisplayPort:
2093 			radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
2094 			if (!radeon_dig_connector)
2095 				goto failed;
2096 			radeon_dig_connector->igp_lane_info = igp_lane_info;
2097 			radeon_connector->con_priv = radeon_dig_connector;
2098 			drm_connector_init(dev, &radeon_connector->base, &radeon_dp_connector_funcs, connector_type);
2099 			drm_connector_helper_add(&radeon_connector->base, &radeon_dp_connector_helper_funcs);
2100 			if (i2c_bus->valid) {
2101 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2102 				if (radeon_connector->ddc_bus)
2103 					has_aux = true;
2104 				else
2105 					DRM_ERROR("DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2106 			}
2107 			subpixel_order = SubPixelHorizontalRGB;
2108 			drm_object_attach_property(&radeon_connector->base.base,
2109 						      rdev->mode_info.coherent_mode_property,
2110 						      1);
2111 			if (ASIC_IS_AVIVO(rdev)) {
2112 				drm_object_attach_property(&radeon_connector->base.base,
2113 							      rdev->mode_info.underscan_property,
2114 							      UNDERSCAN_OFF);
2115 				drm_object_attach_property(&radeon_connector->base.base,
2116 							      rdev->mode_info.underscan_hborder_property,
2117 							      0);
2118 				drm_object_attach_property(&radeon_connector->base.base,
2119 							      rdev->mode_info.underscan_vborder_property,
2120 							      0);
2121 				drm_object_attach_property(&radeon_connector->base.base,
2122 							   rdev->mode_info.dither_property,
2123 							   RADEON_FMT_DITHER_DISABLE);
2124 				drm_object_attach_property(&radeon_connector->base.base,
2125 							   dev->mode_config.scaling_mode_property,
2126 							   DRM_MODE_SCALE_NONE);
2127 			}
2128 			if (ASIC_IS_DCE2(rdev) && (radeon_audio != 0)) {
2129 				drm_object_attach_property(&radeon_connector->base.base,
2130 							   rdev->mode_info.audio_property,
2131 							   RADEON_AUDIO_AUTO);
2132 			}
2133 			connector->interlace_allowed = true;
2134 			/* in theory with a DP to VGA converter... */
2135 			connector->doublescan_allowed = false;
2136 			break;
2137 		case DRM_MODE_CONNECTOR_eDP:
2138 			radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
2139 			if (!radeon_dig_connector)
2140 				goto failed;
2141 			radeon_dig_connector->igp_lane_info = igp_lane_info;
2142 			radeon_connector->con_priv = radeon_dig_connector;
2143 			drm_connector_init(dev, &radeon_connector->base, &radeon_edp_connector_funcs, connector_type);
2144 			drm_connector_helper_add(&radeon_connector->base, &radeon_dp_connector_helper_funcs);
2145 			if (i2c_bus->valid) {
2146 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2147 				if (radeon_connector->ddc_bus)
2148 					has_aux = true;
2149 				else
2150 					DRM_ERROR("DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2151 			}
2152 			drm_object_attach_property(&radeon_connector->base.base,
2153 						      dev->mode_config.scaling_mode_property,
2154 						      DRM_MODE_SCALE_FULLSCREEN);
2155 			subpixel_order = SubPixelHorizontalRGB;
2156 			connector->interlace_allowed = false;
2157 			connector->doublescan_allowed = false;
2158 			break;
2159 		case DRM_MODE_CONNECTOR_SVIDEO:
2160 		case DRM_MODE_CONNECTOR_Composite:
2161 		case DRM_MODE_CONNECTOR_9PinDIN:
2162 			drm_connector_init(dev, &radeon_connector->base, &radeon_tv_connector_funcs, connector_type);
2163 			drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
2164 			radeon_connector->dac_load_detect = true;
2165 			drm_object_attach_property(&radeon_connector->base.base,
2166 						      rdev->mode_info.load_detect_property,
2167 						      1);
2168 			drm_object_attach_property(&radeon_connector->base.base,
2169 						      rdev->mode_info.tv_std_property,
2170 						      radeon_atombios_get_tv_info(rdev));
2171 			/* no HPD on analog connectors */
2172 			radeon_connector->hpd.hpd = RADEON_HPD_NONE;
2173 			connector->interlace_allowed = false;
2174 			connector->doublescan_allowed = false;
2175 			break;
2176 		case DRM_MODE_CONNECTOR_LVDS:
2177 			radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
2178 			if (!radeon_dig_connector)
2179 				goto failed;
2180 			radeon_dig_connector->igp_lane_info = igp_lane_info;
2181 			radeon_connector->con_priv = radeon_dig_connector;
2182 			drm_connector_init(dev, &radeon_connector->base, &radeon_lvds_connector_funcs, connector_type);
2183 			drm_connector_helper_add(&radeon_connector->base, &radeon_lvds_connector_helper_funcs);
2184 			if (i2c_bus->valid) {
2185 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2186 				if (!radeon_connector->ddc_bus)
2187 					DRM_ERROR("LVDS: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2188 			}
2189 			drm_object_attach_property(&radeon_connector->base.base,
2190 						      dev->mode_config.scaling_mode_property,
2191 						      DRM_MODE_SCALE_FULLSCREEN);
2192 			subpixel_order = SubPixelHorizontalRGB;
2193 			connector->interlace_allowed = false;
2194 			connector->doublescan_allowed = false;
2195 			break;
2196 		}
2197 	}
2198 
2199 	if (radeon_connector->hpd.hpd == RADEON_HPD_NONE) {
2200 		if (i2c_bus->valid)
2201 			connector->polled = DRM_CONNECTOR_POLL_CONNECT;
2202 	} else
2203 		connector->polled = DRM_CONNECTOR_POLL_HPD;
2204 
2205 	connector->display_info.subpixel_order = subpixel_order;
2206 	drm_connector_register(connector);
2207 
2208 	if (has_aux)
2209 		radeon_dp_aux_init(radeon_connector);
2210 
2211 	return;
2212 
2213 failed:
2214 	drm_connector_cleanup(connector);
2215 	kfree(connector);
2216 }
2217 
2218 void
2219 radeon_add_legacy_connector(struct drm_device *dev,
2220 			    uint32_t connector_id,
2221 			    uint32_t supported_device,
2222 			    int connector_type,
2223 			    struct radeon_i2c_bus_rec *i2c_bus,
2224 			    uint16_t connector_object_id,
2225 			    struct radeon_hpd *hpd)
2226 {
2227 	struct radeon_device *rdev = dev->dev_private;
2228 	struct drm_connector *connector;
2229 	struct radeon_connector *radeon_connector;
2230 	uint32_t subpixel_order = SubPixelNone;
2231 
2232 	if (connector_type == DRM_MODE_CONNECTOR_Unknown)
2233 		return;
2234 
2235 	/* if the user selected tv=0 don't try and add the connector */
2236 	if (((connector_type == DRM_MODE_CONNECTOR_SVIDEO) ||
2237 	     (connector_type == DRM_MODE_CONNECTOR_Composite) ||
2238 	     (connector_type == DRM_MODE_CONNECTOR_9PinDIN)) &&
2239 	    (radeon_tv == 0))
2240 		return;
2241 
2242 	/* see if we already added it */
2243 	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
2244 		radeon_connector = to_radeon_connector(connector);
2245 		if (radeon_connector->connector_id == connector_id) {
2246 			radeon_connector->devices |= supported_device;
2247 			return;
2248 		}
2249 	}
2250 
2251 	radeon_connector = kzalloc(sizeof(struct radeon_connector), GFP_KERNEL);
2252 	if (!radeon_connector)
2253 		return;
2254 
2255 	connector = &radeon_connector->base;
2256 
2257 	radeon_connector->connector_id = connector_id;
2258 	radeon_connector->devices = supported_device;
2259 	radeon_connector->connector_object_id = connector_object_id;
2260 	radeon_connector->hpd = *hpd;
2261 
2262 	switch (connector_type) {
2263 	case DRM_MODE_CONNECTOR_VGA:
2264 		drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
2265 		drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
2266 		if (i2c_bus->valid) {
2267 			radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2268 			if (!radeon_connector->ddc_bus)
2269 				DRM_ERROR("VGA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2270 		}
2271 		radeon_connector->dac_load_detect = true;
2272 		drm_object_attach_property(&radeon_connector->base.base,
2273 					      rdev->mode_info.load_detect_property,
2274 					      1);
2275 		/* no HPD on analog connectors */
2276 		radeon_connector->hpd.hpd = RADEON_HPD_NONE;
2277 		connector->polled = DRM_CONNECTOR_POLL_CONNECT;
2278 		connector->interlace_allowed = true;
2279 		connector->doublescan_allowed = true;
2280 		break;
2281 	case DRM_MODE_CONNECTOR_DVIA:
2282 		drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
2283 		drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
2284 		if (i2c_bus->valid) {
2285 			radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2286 			if (!radeon_connector->ddc_bus)
2287 				DRM_ERROR("DVIA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2288 		}
2289 		radeon_connector->dac_load_detect = true;
2290 		drm_object_attach_property(&radeon_connector->base.base,
2291 					      rdev->mode_info.load_detect_property,
2292 					      1);
2293 		/* no HPD on analog connectors */
2294 		radeon_connector->hpd.hpd = RADEON_HPD_NONE;
2295 		connector->interlace_allowed = true;
2296 		connector->doublescan_allowed = true;
2297 		break;
2298 	case DRM_MODE_CONNECTOR_DVII:
2299 	case DRM_MODE_CONNECTOR_DVID:
2300 		drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
2301 		drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
2302 		if (i2c_bus->valid) {
2303 			radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2304 			if (!radeon_connector->ddc_bus)
2305 				DRM_ERROR("DVI: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2306 		}
2307 		if (connector_type == DRM_MODE_CONNECTOR_DVII) {
2308 			radeon_connector->dac_load_detect = true;
2309 			drm_object_attach_property(&radeon_connector->base.base,
2310 						      rdev->mode_info.load_detect_property,
2311 						      1);
2312 		}
2313 		subpixel_order = SubPixelHorizontalRGB;
2314 		connector->interlace_allowed = true;
2315 		if (connector_type == DRM_MODE_CONNECTOR_DVII)
2316 			connector->doublescan_allowed = true;
2317 		else
2318 			connector->doublescan_allowed = false;
2319 		break;
2320 	case DRM_MODE_CONNECTOR_SVIDEO:
2321 	case DRM_MODE_CONNECTOR_Composite:
2322 	case DRM_MODE_CONNECTOR_9PinDIN:
2323 		drm_connector_init(dev, &radeon_connector->base, &radeon_tv_connector_funcs, connector_type);
2324 		drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
2325 		radeon_connector->dac_load_detect = true;
2326 		/* RS400,RC410,RS480 chipset seems to report a lot
2327 		 * of false positive on load detect, we haven't yet
2328 		 * found a way to make load detect reliable on those
2329 		 * chipset, thus just disable it for TV.
2330 		 */
2331 		if (rdev->family == CHIP_RS400 || rdev->family == CHIP_RS480)
2332 			radeon_connector->dac_load_detect = false;
2333 		drm_object_attach_property(&radeon_connector->base.base,
2334 					      rdev->mode_info.load_detect_property,
2335 					      radeon_connector->dac_load_detect);
2336 		drm_object_attach_property(&radeon_connector->base.base,
2337 					      rdev->mode_info.tv_std_property,
2338 					      radeon_combios_get_tv_info(rdev));
2339 		/* no HPD on analog connectors */
2340 		radeon_connector->hpd.hpd = RADEON_HPD_NONE;
2341 		connector->interlace_allowed = false;
2342 		connector->doublescan_allowed = false;
2343 		break;
2344 	case DRM_MODE_CONNECTOR_LVDS:
2345 		drm_connector_init(dev, &radeon_connector->base, &radeon_lvds_connector_funcs, connector_type);
2346 		drm_connector_helper_add(&radeon_connector->base, &radeon_lvds_connector_helper_funcs);
2347 		if (i2c_bus->valid) {
2348 			radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2349 			if (!radeon_connector->ddc_bus)
2350 				DRM_ERROR("LVDS: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2351 		}
2352 		drm_object_attach_property(&radeon_connector->base.base,
2353 					      dev->mode_config.scaling_mode_property,
2354 					      DRM_MODE_SCALE_FULLSCREEN);
2355 		subpixel_order = SubPixelHorizontalRGB;
2356 		connector->interlace_allowed = false;
2357 		connector->doublescan_allowed = false;
2358 		break;
2359 	}
2360 
2361 	if (radeon_connector->hpd.hpd == RADEON_HPD_NONE) {
2362 		if (i2c_bus->valid)
2363 			connector->polled = DRM_CONNECTOR_POLL_CONNECT;
2364 	} else
2365 		connector->polled = DRM_CONNECTOR_POLL_HPD;
2366 	connector->display_info.subpixel_order = subpixel_order;
2367 	drm_connector_register(connector);
2368 }
2369