13cbdda60SSimon J. Gerraty# RCSid: 2*5bcb7424SSimon J. Gerraty# $Id: warnings.mk,v 1.8 2014/04/02 19:20:23 sjg Exp $ 33cbdda60SSimon J. Gerraty# 43cbdda60SSimon J. Gerraty# @(#) Copyright (c) 2002, Simon J. Gerraty 53cbdda60SSimon J. Gerraty# 63cbdda60SSimon J. Gerraty# This file is provided in the hope that it will 73cbdda60SSimon J. Gerraty# be of use. There is absolutely NO WARRANTY. 83cbdda60SSimon J. Gerraty# Permission to copy, redistribute or otherwise 93cbdda60SSimon J. Gerraty# use this file is hereby granted provided that 103cbdda60SSimon J. Gerraty# the above copyright notice and this notice are 113cbdda60SSimon J. Gerraty# left intact. 123cbdda60SSimon J. Gerraty# 133cbdda60SSimon J. Gerraty# Please send copies of changes and bug-fixes to: 143cbdda60SSimon J. Gerraty# sjg@crufty.net 153cbdda60SSimon J. Gerraty# 163cbdda60SSimon J. Gerraty 173cbdda60SSimon J. Gerraty.ifndef _w_cflags 183cbdda60SSimon J. Gerraty 193cbdda60SSimon J. Gerraty# Any number of warnings sets can be added. 203cbdda60SSimon J. Gerraty.-include "warnings-sets.mk" 213cbdda60SSimon J. Gerraty 223cbdda60SSimon J. Gerraty# Modest defaults - put more elaborate sets in warnings-sets.mk 233cbdda60SSimon J. Gerraty# -Wunused etc are here so you can set 243cbdda60SSimon J. Gerraty# W_unused=-Wno-unused etc. 253cbdda60SSimon J. GerratyMIN_WARNINGS?= -Wall \ 263cbdda60SSimon J. Gerraty -Wformat \ 273cbdda60SSimon J. Gerraty -Wimplicit \ 283cbdda60SSimon J. Gerraty -Wunused \ 293cbdda60SSimon J. Gerraty -Wuninitialized 303cbdda60SSimon J. Gerraty 313cbdda60SSimon J. GerratyLOW_WARNINGS?= ${MIN_WARNINGS} -W -Wstrict-prototypes -Wmissing-prototypes 323cbdda60SSimon J. Gerraty 333cbdda60SSimon J. GerratyMEDIUM_WARNINGS?= ${LOW_WARNINGS} -Werror 343cbdda60SSimon J. Gerraty 353cbdda60SSimon J. GerratyHIGH_WARNINGS?= ${MEDIUM_WARNINGS} \ 363cbdda60SSimon J. Gerraty -Wcast-align \ 373cbdda60SSimon J. Gerraty -Wcast-qual \ 383cbdda60SSimon J. Gerraty -Wparentheses \ 393cbdda60SSimon J. Gerraty -Wpointer-arith \ 403cbdda60SSimon J. Gerraty -Wmissing-declarations \ 413cbdda60SSimon J. Gerraty -Wreturn-type \ 423cbdda60SSimon J. Gerraty -Wswitch \ 433cbdda60SSimon J. Gerraty -Wwrite-strings 443cbdda60SSimon J. Gerraty 45*5bcb7424SSimon J. GerratyEXTRA_WARNINGS?= ${HIGH_WARNINGS} -Wextra 46*5bcb7424SSimon J. Gerraty 473cbdda60SSimon J. Gerraty# The two step default makes it easier to test build with different defaults. 483cbdda60SSimon J. GerratyDEFAULT_WARNINGS_SET?= MIN 493cbdda60SSimon J. GerratyWARNINGS_SET?= ${DEFAULT_WARNINGS_SET} 503cbdda60SSimon J. Gerraty 513cbdda60SSimon J. Gerraty# If you add sets, besure to list them (you don't have to touch this list). 52*5bcb7424SSimon J. GerratyALL_WARNINGS_SETS+= MIN LOW MEDIUM HIGH EXTRA 533cbdda60SSimon J. Gerraty 54*5bcb7424SSimon J. Gerraty.if !empty(WARNINGS_SET) 55*5bcb7424SSimon J. Gerraty.for ws in ${WARNINGS_SET} 56*5bcb7424SSimon J. Gerraty.if empty(${ws}_WARNINGS) 57*5bcb7424SSimon J. Gerraty.if ${MAKE_VERSION:[1]:C/.*-//} >= 20050530 583cbdda60SSimon J. Gerraty.BEGIN: _empty_warnings 593cbdda60SSimon J. Gerraty_empty_warnings: .PHONY 603cbdda60SSimon J. Gerraty.else 613cbdda60SSimon J. Gerraty.BEGIN: 623cbdda60SSimon J. Gerraty.endif 63*5bcb7424SSimon J. Gerraty @echo "ERROR: Invalid: WARNINGS_SET=${ws}" 643cbdda60SSimon J. Gerraty @echo "ERROR: Try one of: ${ALL_WARNINGS_SETS:O:u}"; exit 1 653cbdda60SSimon J. Gerraty 663cbdda60SSimon J. Gerraty.endif 67*5bcb7424SSimon J. Gerraty.endfor 68*5bcb7424SSimon J. Gerraty.endif 693cbdda60SSimon J. Gerraty 703cbdda60SSimon J. Gerraty# Without -O or if we've set -O0 somewhere - to make debugging more effective, 713cbdda60SSimon J. Gerraty# we need to turn off -Wuninitialized as otherwise we get a warning that 723cbdda60SSimon J. Gerraty# -Werror turns into an error. To be safe, set W_uninitialized blank. 733cbdda60SSimon J. Gerraty_w_cflags:= ${CFLAGS} ${CPPFLAGS} 743cbdda60SSimon J. Gerraty.if ${_w_cflags:M-O*} == "" || ${_w_cflags:M-O0} != "" 753cbdda60SSimon J. GerratyW_uninitialized= 763cbdda60SSimon J. Gerraty.endif 773cbdda60SSimon J. Gerraty 783cbdda60SSimon J. Gerraty 793cbdda60SSimon J. Gerraty# .for loops have the [dis]advantage of being evaluated when read, 803cbdda60SSimon J. Gerraty# so adding to WARNINGS_SET[_${MACHINE_ARCH}] after this file is 813cbdda60SSimon J. Gerraty# read has no effect. 823cbdda60SSimon J. Gerraty# Replacing the above .for loops with the WARNINGS+= below solves that 833cbdda60SSimon J. Gerraty# but tiggers a double free bug in bmake-20040118 and earlier. 843cbdda60SSimon J. Gerraty# Don't try and read this too fast! 853cbdda60SSimon J. Gerraty# 863cbdda60SSimon J. Gerraty# The first :@ "loop" handles multiple sets in WARNINGS_SET 873cbdda60SSimon J. Gerraty# 883cbdda60SSimon J. Gerraty# In the second :@ "loop", the ::?= noise sets W_foo?=-Wfoo etc 893cbdda60SSimon J. Gerraty# which makes it easy to turn off override individual flags 903cbdda60SSimon J. Gerraty# (see W_uninitialized above). 913cbdda60SSimon J. Gerraty# 923cbdda60SSimon J. Gerraty# The last bit expands to ${W_foo_${.TARGET:T}:U${W_foo}} 933cbdda60SSimon J. Gerraty# which is the bit we ultimately want. It allows W_* to be set on a 943cbdda60SSimon J. Gerraty# per target basis. 953cbdda60SSimon J. Gerraty# 963cbdda60SSimon J. Gerraty# NOTE: that we force the target extension to be .o 973cbdda60SSimon J. Gerraty# 983cbdda60SSimon J. Gerraty 99*5bcb7424SSimon J. Gerraty# define this once, we use it a couple of times below (hence the doubled $$). 100*5bcb7424SSimon J. GerratyM_warnings_list = @s@$${$$s_WARNINGS}@:O:u:@w@$${$${w:C/-(.)/\1_/}::?=$$w} $${$${w:C/-(.)/\1_/}_${MACHINE_ARCH}_${.TARGET:T:R}.o:U$${$${w:C/-(.)/\1_/}_${.TARGET:T:R}.o:U$${$${w:C/-(.)/\1_/}_${MACHINE_ARCH}:U$${$${w:C/-(.)/\1_/}}}}}@ 101*5bcb7424SSimon J. Gerraty 102*5bcb7424SSimon J. Gerraty# first a list of warnings from the chosen set 103*5bcb7424SSimon J. Gerraty_warnings = ${WARNINGS_SET_${MACHINE_ARCH}:U${WARNINGS_SET}:${M_warnings_list}} 104*5bcb7424SSimon J. Gerraty# now a list of all -Wno-* overrides not just those defined by WARNINGS_SET 105*5bcb7424SSimon J. Gerraty# since things like -Wall imply lots of others. 106*5bcb7424SSimon J. Gerraty# this should be a super-set of the -Wno-* in _warnings, but 107*5bcb7424SSimon J. Gerraty# just in case... 108*5bcb7424SSimon J. Gerraty_no_warnings = ${_warnings:M-Wno-*} ${ALL_WARNINGS_SETS:${M_warnings_list}:M-Wno-*} 109*5bcb7424SSimon J. Gerraty# -Wno-* must follow any others 110*5bcb7424SSimon J. GerratyWARNINGS += ${_warnings:N-Wno-*} ${_no_warnings:O:u} 1113cbdda60SSimon J. Gerraty 1123cbdda60SSimon J. Gerraty.ifndef NO_CFLAGS_WARNINGS 1133cbdda60SSimon J. Gerraty# Just ${WARNINGS} should do, but this is more flexible? 1143cbdda60SSimon J. GerratyCFLAGS+= ${WARNINGS_${.TARGET:T:R}.o:U${WARNINGS}} 1153cbdda60SSimon J. Gerraty.endif 1163cbdda60SSimon J. Gerraty 1173cbdda60SSimon J. Gerraty# it is rather silly that g++ blows up on some warning flags 1183cbdda60SSimon J. GerratyNO_CXX_WARNINGS+= \ 1193cbdda60SSimon J. Gerraty missing-declarations \ 1203cbdda60SSimon J. Gerraty missing-prototypes \ 1213cbdda60SSimon J. Gerraty nested-externs \ 122*5bcb7424SSimon J. Gerraty shadow \ 1233cbdda60SSimon J. Gerraty strict-prototypes 1243cbdda60SSimon J. Gerraty 125*5bcb7424SSimon J. Gerraty.for s in ${SRCS:M*.c*:N*.c:N*h} 1263cbdda60SSimon J. Gerraty.for w in ${NO_CXX_WARNINGS} 1273cbdda60SSimon J. GerratyW_$w_${s:T:R}.o= 1283cbdda60SSimon J. Gerraty.endfor 1293cbdda60SSimon J. Gerraty.endfor 1303cbdda60SSimon J. Gerraty 1313cbdda60SSimon J. Gerraty.endif # _w_cflags 132