1 //== ReturnPointerRangeChecker.cpp ------------------------------*- C++ -*--==//
2 //
3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4 // See https://llvm.org/LICENSE.txt for license information.
5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6 //
7 //===----------------------------------------------------------------------===//
8 //
9 // This file defines ReturnPointerRangeChecker, which is a path-sensitive check
10 // which looks for an out-of-bound pointer being returned to callers.
11 //
12 //===----------------------------------------------------------------------===//
13 
14 #include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
15 #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
16 #include "clang/StaticAnalyzer/Core/Checker.h"
17 #include "clang/StaticAnalyzer/Core/CheckerManager.h"
18 #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
19 #include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h"
20 
21 using namespace clang;
22 using namespace ento;
23 
24 namespace {
25 class ReturnPointerRangeChecker :
26     public Checker< check::PreStmt<ReturnStmt> > {
27   mutable std::unique_ptr<BuiltinBug> BT;
28 
29 public:
30     void checkPreStmt(const ReturnStmt *RS, CheckerContext &C) const;
31 };
32 }
33 
34 void ReturnPointerRangeChecker::checkPreStmt(const ReturnStmt *RS,
35                                              CheckerContext &C) const {
36   ProgramStateRef state = C.getState();
37 
38   const Expr *RetE = RS->getRetValue();
39   if (!RetE)
40     return;
41 
42   SVal V = C.getSVal(RetE);
43   const MemRegion *R = V.getAsRegion();
44 
45   const ElementRegion *ER = dyn_cast_or_null<ElementRegion>(R);
46   if (!ER)
47     return;
48 
49   DefinedOrUnknownSVal Idx = ER->getIndex().castAs<DefinedOrUnknownSVal>();
50   // Zero index is always in bound, this also passes ElementRegions created for
51   // pointer casts.
52   if (Idx.isZeroConstant())
53     return;
54   // FIXME: All of this out-of-bounds checking should eventually be refactored
55   // into a common place.
56 
57   DefinedOrUnknownSVal NumElements
58     = C.getStoreManager().getSizeInElements(state, ER->getSuperRegion(),
59                                            ER->getValueType());
60 
61   ProgramStateRef StInBound = state->assumeInBound(Idx, NumElements, true);
62   ProgramStateRef StOutBound = state->assumeInBound(Idx, NumElements, false);
63   if (StOutBound && !StInBound) {
64     ExplodedNode *N = C.generateErrorNode(StOutBound);
65 
66     if (!N)
67       return;
68 
69     // FIXME: This bug correspond to CWE-466.  Eventually we should have bug
70     // types explicitly reference such exploit categories (when applicable).
71     if (!BT)
72       BT.reset(new BuiltinBug(
73           this, "Return of pointer value outside of expected range",
74           "Returned pointer value points outside the original object "
75           "(potential buffer overflow)"));
76 
77     // FIXME: It would be nice to eventually make this diagnostic more clear,
78     // e.g., by referencing the original declaration or by saying *why* this
79     // reference is outside the range.
80 
81     // Generate a report for this bug.
82     auto report =
83         std::make_unique<PathSensitiveBugReport>(*BT, BT->getDescription(), N);
84 
85     report->addRange(RetE->getSourceRange());
86     C.emitReport(std::move(report));
87   }
88 }
89 
90 void ento::registerReturnPointerRangeChecker(CheckerManager &mgr) {
91   mgr.registerChecker<ReturnPointerRangeChecker>();
92 }
93 
94 bool ento::shouldRegisterReturnPointerRangeChecker(const LangOptions &LO) {
95   return true;
96 }
97