xref: /freebsd/usr.sbin/nfscbd/nfscbd.c (revision 80c7cc1c)
103914b0bSRick Macklem /*-
203914b0bSRick Macklem  * Copyright (c) 2009 Rick Macklem, University of Guelph
303914b0bSRick Macklem  * All rights reserved.
403914b0bSRick Macklem  *
503914b0bSRick Macklem  * Redistribution and use in source and binary forms, with or without
603914b0bSRick Macklem  * modification, are permitted provided that the following conditions
703914b0bSRick Macklem  * are met:
803914b0bSRick Macklem  * 1. Redistributions of source code must retain the above copyright
903914b0bSRick Macklem  *    notice, this list of conditions and the following disclaimer.
1003914b0bSRick Macklem  * 2. Redistributions in binary form must reproduce the above copyright
1103914b0bSRick Macklem  *    notice, this list of conditions and the following disclaimer in the
1203914b0bSRick Macklem  *    documentation and/or other materials provided with the distribution.
1303914b0bSRick Macklem  *
1403914b0bSRick Macklem  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
1503914b0bSRick Macklem  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
1603914b0bSRick Macklem  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
1703914b0bSRick Macklem  * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
1803914b0bSRick Macklem  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
1903914b0bSRick Macklem  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
2003914b0bSRick Macklem  * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
2103914b0bSRick Macklem  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
2203914b0bSRick Macklem  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
2303914b0bSRick Macklem  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
2403914b0bSRick Macklem  * SUCH DAMAGE.
2503914b0bSRick Macklem  *
2603914b0bSRick Macklem  */
2703914b0bSRick Macklem 
2803914b0bSRick Macklem #include <sys/cdefs.h>
2903914b0bSRick Macklem __FBSDID("$FreeBSD$");
3003914b0bSRick Macklem 
3103914b0bSRick Macklem #include <sys/param.h>
3203914b0bSRick Macklem #include <sys/ioctl.h>
3303914b0bSRick Macklem #include <sys/linker.h>
3403914b0bSRick Macklem #include <sys/module.h>
3503914b0bSRick Macklem #include <sys/mount.h>
3603914b0bSRick Macklem #include <sys/socket.h>
3703914b0bSRick Macklem #include <sys/socketvar.h>
3803914b0bSRick Macklem #include <sys/stat.h>
3903914b0bSRick Macklem #include <sys/ucred.h>
4003914b0bSRick Macklem #include <sys/uio.h>
4103914b0bSRick Macklem #include <sys/vnode.h>
4203914b0bSRick Macklem #include <sys/wait.h>
4303914b0bSRick Macklem 
4403914b0bSRick Macklem #include <nfs/nfssvc.h>
4503914b0bSRick Macklem 
4603914b0bSRick Macklem #include <rpc/rpc.h>
4703914b0bSRick Macklem 
4865a57061SStanislav Sedov #include <fs/nfs/rpcv2.h>
4903914b0bSRick Macklem #include <fs/nfs/nfsproto.h>
5003914b0bSRick Macklem #include <fs/nfs/nfskpiport.h>
5103914b0bSRick Macklem #include <fs/nfs/nfs.h>
5203914b0bSRick Macklem 
5303914b0bSRick Macklem #include <err.h>
5403914b0bSRick Macklem #include <errno.h>
5503914b0bSRick Macklem #include <fcntl.h>
5603914b0bSRick Macklem #include <grp.h>
5703914b0bSRick Macklem #include <netdb.h>
5803914b0bSRick Macklem #include <pwd.h>
5903914b0bSRick Macklem #include <signal.h>
6003914b0bSRick Macklem #include <stdio.h>
6103914b0bSRick Macklem #include <stdlib.h>
6203914b0bSRick Macklem #include <string.h>
6303914b0bSRick Macklem #include <syslog.h>
6403914b0bSRick Macklem #include <unistd.h>
6503914b0bSRick Macklem 
6603914b0bSRick Macklem /* Global defs */
6703914b0bSRick Macklem #ifdef DEBUG
6803914b0bSRick Macklem #define	syslog(e, s)	fprintf(stderr,(s))
69bf70beceSEd Schouten static int	debug = 1;
7003914b0bSRick Macklem #else
71bf70beceSEd Schouten static int	debug = 0;
7203914b0bSRick Macklem #endif
7303914b0bSRick Macklem 
74bf70beceSEd Schouten static pid_t	children;
7503914b0bSRick Macklem 
769964058eSXin LI static void	nonfs(int);
779964058eSXin LI static void	reapchild(int);
789964058eSXin LI static void	usage(void);
799964058eSXin LI static void	cleanup(int);
809964058eSXin LI static void	child_cleanup(int);
819964058eSXin LI static void	nfscbd_exit(int);
829964058eSXin LI static void	killchildren(void);
8303914b0bSRick Macklem 
8403914b0bSRick Macklem /*
8503914b0bSRick Macklem  * Nfs callback server daemon.
8603914b0bSRick Macklem  *
8703914b0bSRick Macklem  * 1 - do file descriptor and signal cleanup
8803914b0bSRick Macklem  * 2 - fork the nfscbd(s)
8903914b0bSRick Macklem  * 4 - create callback server socket(s)
9003914b0bSRick Macklem  * 5 - set up server socket for rpc
9103914b0bSRick Macklem  *
9203914b0bSRick Macklem  * For connectionless protocols, just pass the socket into the kernel via.
9303914b0bSRick Macklem  * nfssvc().
9403914b0bSRick Macklem  * For connection based sockets, loop doing accepts. When you get a new
9503914b0bSRick Macklem  * socket from accept, pass the msgsock into the kernel via. nfssvc().
9603914b0bSRick Macklem  */
9703914b0bSRick Macklem int
989964058eSXin LI main(int argc, char *argv[])
9903914b0bSRick Macklem {
10003914b0bSRick Macklem 	struct nfscbd_args nfscbdargs;
10103914b0bSRick Macklem 	struct nfsd_nfscbd_args nfscbdargs2;
10203914b0bSRick Macklem 	struct sockaddr_in inetaddr, inetpeer;
10303914b0bSRick Macklem 	fd_set ready, sockbits;
1049964058eSXin LI 	int ch, connect_type_cnt, len, maxsock, msgsock, error;
10503914b0bSRick Macklem 	int nfssvc_flag, on, sock, tcpsock, ret, mustfreeai = 0;
1069964058eSXin LI 	char *cp, princname[128];
10703914b0bSRick Macklem 	char myname[MAXHOSTNAMELEN], *myfqdnname = NULL;
10803914b0bSRick Macklem 	struct addrinfo *aip, hints;
10903914b0bSRick Macklem 	pid_t pid;
11003914b0bSRick Macklem 	short myport = NFSV4_CBPORT;
11103914b0bSRick Macklem 
11203914b0bSRick Macklem 	if (modfind("nfscl") < 0) {
11303914b0bSRick Macklem 		/* Not present in kernel, try loading it */
11403914b0bSRick Macklem 		if (kldload("nfscl") < 0 ||
11503914b0bSRick Macklem 		    modfind("nfscl") < 0)
11603914b0bSRick Macklem 			errx(1, "nfscl is not available");
11703914b0bSRick Macklem 	}
11803914b0bSRick Macklem 	/*
11903914b0bSRick Macklem 	 * First, get our fully qualified host name, if possible.
12003914b0bSRick Macklem 	 */
12103914b0bSRick Macklem 	if (gethostname(myname, MAXHOSTNAMELEN) >= 0) {
12203914b0bSRick Macklem 		cp = strchr(myname, '.');
12303914b0bSRick Macklem 		if (cp != NULL && *(cp + 1) != '\0') {
12403914b0bSRick Macklem 			cp = myname;
12503914b0bSRick Macklem 		} else {
12603914b0bSRick Macklem 			/*
12703914b0bSRick Macklem 			 * No domain on myname, so try looking it up.
12803914b0bSRick Macklem 			 */
12903914b0bSRick Macklem 			cp = NULL;
13003914b0bSRick Macklem 			memset((void *)&hints, 0, sizeof (hints));
13103914b0bSRick Macklem 			hints.ai_flags = AI_CANONNAME;
13203914b0bSRick Macklem 			error = getaddrinfo(myname, NULL, &hints, &aip);
13303914b0bSRick Macklem 			if (error == 0) {
13403914b0bSRick Macklem 			    if (aip->ai_canonname != NULL &&
13503914b0bSRick Macklem 				(cp = strchr(aip->ai_canonname, '.')) != NULL
13603914b0bSRick Macklem 				&& *(cp + 1) != '\0') {
13703914b0bSRick Macklem 				    cp = aip->ai_canonname;
13803914b0bSRick Macklem 				    mustfreeai = 1;
13903914b0bSRick Macklem 			    } else {
14003914b0bSRick Macklem 				    freeaddrinfo(aip);
14103914b0bSRick Macklem 			    }
14203914b0bSRick Macklem 			}
14303914b0bSRick Macklem 		}
14403914b0bSRick Macklem 		if (cp == NULL)
14503914b0bSRick Macklem 			warnx("Can't get fully qualified host name");
14603914b0bSRick Macklem 		myfqdnname = cp;
14703914b0bSRick Macklem 	}
14803914b0bSRick Macklem 
14903914b0bSRick Macklem 	princname[0] = '\0';
15003914b0bSRick Macklem #define	GETOPT	"p:P:"
15103914b0bSRick Macklem #define	USAGE	"[ -p port_num ] [ -P client_principal ]"
15203914b0bSRick Macklem 	while ((ch = getopt(argc, argv, GETOPT)) != -1)
15303914b0bSRick Macklem 		switch (ch) {
15403914b0bSRick Macklem 		case 'p':
15503914b0bSRick Macklem 			myport = atoi(optarg);
15603914b0bSRick Macklem 			if (myport < 1) {
15703914b0bSRick Macklem 				warnx("port# non-positive, reset to %d",
15803914b0bSRick Macklem 				    NFSV4_CBPORT);
15903914b0bSRick Macklem 				myport = NFSV4_CBPORT;
16003914b0bSRick Macklem 			}
16103914b0bSRick Macklem 			break;
16203914b0bSRick Macklem 		case 'P':
16303914b0bSRick Macklem 			cp = optarg;
16403914b0bSRick Macklem 			if (cp != NULL && strlen(cp) > 0 &&
16503914b0bSRick Macklem 			    strlen(cp) < sizeof (princname)) {
16603914b0bSRick Macklem 				if (strchr(cp, '@') == NULL &&
16703914b0bSRick Macklem 				    myfqdnname != NULL)
16803914b0bSRick Macklem 					snprintf(princname, sizeof (princname),
16903914b0bSRick Macklem 					    "%s@%s", cp, myfqdnname);
17003914b0bSRick Macklem 				else
17103914b0bSRick Macklem 					strlcpy(princname, cp,
17203914b0bSRick Macklem 					    sizeof (princname));
17303914b0bSRick Macklem 			} else {
17403914b0bSRick Macklem 				warnx("client princ invalid. ignored\n");
17503914b0bSRick Macklem 			}
17603914b0bSRick Macklem 			break;
17703914b0bSRick Macklem 		default:
17803914b0bSRick Macklem 		case '?':
17903914b0bSRick Macklem 			usage();
18080c7cc1cSPedro F. Giffuni 		}
18103914b0bSRick Macklem 	argv += optind;
18203914b0bSRick Macklem 	argc -= optind;
18303914b0bSRick Macklem 
18403914b0bSRick Macklem 	if (argc > 0)
18503914b0bSRick Macklem 		usage();
18603914b0bSRick Macklem 
18703914b0bSRick Macklem 	if (mustfreeai)
18803914b0bSRick Macklem 		freeaddrinfo(aip);
18903914b0bSRick Macklem 	nfscbdargs2.principal = (const char *)princname;
19003914b0bSRick Macklem 	if (debug == 0) {
19103914b0bSRick Macklem 		daemon(0, 0);
19203914b0bSRick Macklem 		(void)signal(SIGTERM, SIG_IGN);
19303914b0bSRick Macklem 		(void)signal(SIGHUP, SIG_IGN);
19403914b0bSRick Macklem 		(void)signal(SIGINT, SIG_IGN);
19503914b0bSRick Macklem 		(void)signal(SIGQUIT, SIG_IGN);
19603914b0bSRick Macklem 	}
19703914b0bSRick Macklem 	(void)signal(SIGSYS, nonfs);
19803914b0bSRick Macklem 	(void)signal(SIGCHLD, reapchild);
19903914b0bSRick Macklem 
20003914b0bSRick Macklem 	openlog("nfscbd:", LOG_PID, LOG_DAEMON);
20103914b0bSRick Macklem 
20203914b0bSRick Macklem 	pid = fork();
20303914b0bSRick Macklem 	if (pid < 0) {
20403914b0bSRick Macklem 		syslog(LOG_ERR, "fork: %m");
20503914b0bSRick Macklem 		nfscbd_exit(1);
20603914b0bSRick Macklem 	} else if (pid > 0) {
20703914b0bSRick Macklem 		children = pid;
20803914b0bSRick Macklem 	} else {
20903914b0bSRick Macklem 		(void)signal(SIGUSR1, child_cleanup);
21003914b0bSRick Macklem 		setproctitle("server");
21103914b0bSRick Macklem 		nfssvc_flag = NFSSVC_NFSCBD;
21203914b0bSRick Macklem 		if (nfssvc(nfssvc_flag, &nfscbdargs2) < 0) {
21303914b0bSRick Macklem 			syslog(LOG_ERR, "nfssvc: %m");
21403914b0bSRick Macklem 			nfscbd_exit(1);
21503914b0bSRick Macklem 		}
21603914b0bSRick Macklem 		exit(0);
21703914b0bSRick Macklem 	}
21803914b0bSRick Macklem 	(void)signal(SIGUSR1, cleanup);
21903914b0bSRick Macklem 
22003914b0bSRick Macklem 	if ((sock = socket(AF_INET, SOCK_DGRAM, 0)) < 0) {
22103914b0bSRick Macklem 		syslog(LOG_ERR, "can't create udp socket");
22203914b0bSRick Macklem 		nfscbd_exit(1);
22303914b0bSRick Macklem 	}
22403914b0bSRick Macklem 	memset(&inetaddr, 0, sizeof inetaddr);
22503914b0bSRick Macklem 	inetaddr.sin_family = AF_INET;
22603914b0bSRick Macklem 	inetaddr.sin_addr.s_addr = INADDR_ANY;
22703914b0bSRick Macklem 	inetaddr.sin_port = htons(myport);
22803914b0bSRick Macklem 	inetaddr.sin_len = sizeof(inetaddr);
22903914b0bSRick Macklem 	ret = bind(sock, (struct sockaddr *)&inetaddr, sizeof(inetaddr));
23003914b0bSRick Macklem 	/* If bind() fails, this is a restart, so just skip UDP. */
23103914b0bSRick Macklem 	if (ret == 0) {
23203914b0bSRick Macklem 		len = sizeof(inetaddr);
23303914b0bSRick Macklem 		if (getsockname(sock, (struct sockaddr *)&inetaddr, &len) < 0){
23403914b0bSRick Macklem 			syslog(LOG_ERR, "can't get bound addr");
23503914b0bSRick Macklem 			nfscbd_exit(1);
23603914b0bSRick Macklem 		}
23703914b0bSRick Macklem 		nfscbdargs.port = ntohs(inetaddr.sin_port);
23803914b0bSRick Macklem 		if (nfscbdargs.port != myport) {
23903914b0bSRick Macklem 			syslog(LOG_ERR, "BAD PORT#");
24003914b0bSRick Macklem 			nfscbd_exit(1);
24103914b0bSRick Macklem 		}
24203914b0bSRick Macklem 		nfscbdargs.sock = sock;
24303914b0bSRick Macklem 		nfscbdargs.name = NULL;
24403914b0bSRick Macklem 		nfscbdargs.namelen = 0;
24503914b0bSRick Macklem 		if (nfssvc(NFSSVC_CBADDSOCK, &nfscbdargs) < 0) {
24603914b0bSRick Macklem 			syslog(LOG_ERR, "can't Add UDP socket");
24703914b0bSRick Macklem 			nfscbd_exit(1);
24803914b0bSRick Macklem 		}
24903914b0bSRick Macklem 	}
25003914b0bSRick Macklem 	(void)close(sock);
25103914b0bSRick Macklem 
25203914b0bSRick Macklem 	/* Now set up the master server socket waiting for tcp connections. */
25303914b0bSRick Macklem 	on = 1;
25403914b0bSRick Macklem 	FD_ZERO(&sockbits);
25503914b0bSRick Macklem 	connect_type_cnt = 0;
25603914b0bSRick Macklem 	if ((tcpsock = socket(AF_INET, SOCK_STREAM, 0)) < 0) {
25703914b0bSRick Macklem 		syslog(LOG_ERR, "can't create tcp socket");
25803914b0bSRick Macklem 		nfscbd_exit(1);
25903914b0bSRick Macklem 	}
26003914b0bSRick Macklem 	if (setsockopt(tcpsock,
26103914b0bSRick Macklem 	    SOL_SOCKET, SO_REUSEADDR, (char *)&on, sizeof(on)) < 0)
26203914b0bSRick Macklem 		syslog(LOG_ERR, "setsockopt SO_REUSEADDR: %m");
26303914b0bSRick Macklem 	/* sin_port is already set */
26403914b0bSRick Macklem 	inetaddr.sin_family = AF_INET;
26503914b0bSRick Macklem 	inetaddr.sin_addr.s_addr = INADDR_ANY;
26603914b0bSRick Macklem 	inetaddr.sin_port = htons(myport);
26703914b0bSRick Macklem 	inetaddr.sin_len = sizeof(inetaddr);
26803914b0bSRick Macklem 	if (bind(tcpsock,
26903914b0bSRick Macklem 	    (struct sockaddr *)&inetaddr, sizeof (inetaddr)) < 0) {
27003914b0bSRick Macklem 		syslog(LOG_ERR, "can't bind tcp addr");
27103914b0bSRick Macklem 		nfscbd_exit(1);
27203914b0bSRick Macklem 	}
27303914b0bSRick Macklem 	if (listen(tcpsock, 5) < 0) {
27403914b0bSRick Macklem 		syslog(LOG_ERR, "listen failed");
27503914b0bSRick Macklem 		nfscbd_exit(1);
27603914b0bSRick Macklem 	}
27703914b0bSRick Macklem 	FD_SET(tcpsock, &sockbits);
27803914b0bSRick Macklem 	maxsock = tcpsock;
27903914b0bSRick Macklem 	connect_type_cnt++;
28003914b0bSRick Macklem 
28103914b0bSRick Macklem 	setproctitle("master");
28203914b0bSRick Macklem 
28303914b0bSRick Macklem 	/*
28403914b0bSRick Macklem 	 * Loop forever accepting connections and passing the sockets
28503914b0bSRick Macklem 	 * into the kernel for the mounts.
28603914b0bSRick Macklem 	 */
28703914b0bSRick Macklem 	for (;;) {
28803914b0bSRick Macklem 		ready = sockbits;
28903914b0bSRick Macklem 		if (connect_type_cnt > 1) {
29003914b0bSRick Macklem 			if (select(maxsock + 1,
29103914b0bSRick Macklem 			    &ready, NULL, NULL, NULL) < 1) {
29203914b0bSRick Macklem 				syslog(LOG_ERR, "select failed: %m");
29303914b0bSRick Macklem 				nfscbd_exit(1);
29403914b0bSRick Macklem 			}
29503914b0bSRick Macklem 		}
29603914b0bSRick Macklem 		if (FD_ISSET(tcpsock, &ready)) {
29703914b0bSRick Macklem 			len = sizeof(inetpeer);
29803914b0bSRick Macklem 			if ((msgsock = accept(tcpsock,
29903914b0bSRick Macklem 			    (struct sockaddr *)&inetpeer, &len)) < 0) {
30003914b0bSRick Macklem 				syslog(LOG_ERR, "accept failed: %m");
30103914b0bSRick Macklem 				nfscbd_exit(1);
30203914b0bSRick Macklem 			}
30303914b0bSRick Macklem 			memset(inetpeer.sin_zero, 0,
30403914b0bSRick Macklem 			    sizeof (inetpeer.sin_zero));
30503914b0bSRick Macklem 			if (setsockopt(msgsock, SOL_SOCKET,
30603914b0bSRick Macklem 			    SO_KEEPALIVE, (char *)&on, sizeof(on)) < 0)
30703914b0bSRick Macklem 				syslog(LOG_ERR,
30803914b0bSRick Macklem 				    "setsockopt SO_KEEPALIVE: %m");
30903914b0bSRick Macklem 			nfscbdargs.sock = msgsock;
31003914b0bSRick Macklem 			nfscbdargs.name = (caddr_t)&inetpeer;
31103914b0bSRick Macklem 			nfscbdargs.namelen = sizeof(inetpeer);
31203914b0bSRick Macklem 			nfssvc(NFSSVC_CBADDSOCK, &nfscbdargs);
31303914b0bSRick Macklem 			(void)close(msgsock);
31403914b0bSRick Macklem 		}
31503914b0bSRick Macklem 	}
31603914b0bSRick Macklem }
31703914b0bSRick Macklem 
3189964058eSXin LI static void
31903914b0bSRick Macklem usage(void)
32003914b0bSRick Macklem {
32103914b0bSRick Macklem 
32203914b0bSRick Macklem 	errx(1, "usage: nfscbd %s", USAGE);
32303914b0bSRick Macklem }
32403914b0bSRick Macklem 
3259964058eSXin LI static void
3269964058eSXin LI nonfs(int signo __unused)
32703914b0bSRick Macklem {
32803914b0bSRick Macklem 	syslog(LOG_ERR, "missing system call: NFS not available");
32903914b0bSRick Macklem }
33003914b0bSRick Macklem 
3319964058eSXin LI static void
3329964058eSXin LI reapchild(int signo __unused)
33303914b0bSRick Macklem {
33403914b0bSRick Macklem 	pid_t pid;
33503914b0bSRick Macklem 
33603914b0bSRick Macklem 	while ((pid = wait3(NULL, WNOHANG, NULL)) > 0) {
33703914b0bSRick Macklem 		if (pid == children)
33803914b0bSRick Macklem 			children = -1;
33903914b0bSRick Macklem 	}
34003914b0bSRick Macklem }
34103914b0bSRick Macklem 
3429964058eSXin LI static void
34303914b0bSRick Macklem killchildren(void)
34403914b0bSRick Macklem {
34503914b0bSRick Macklem 
34603914b0bSRick Macklem 	if (children > 0)
34703914b0bSRick Macklem 		kill(children, SIGKILL);
34803914b0bSRick Macklem }
34903914b0bSRick Macklem 
35003914b0bSRick Macklem /*
35103914b0bSRick Macklem  * Cleanup master after SIGUSR1.
35203914b0bSRick Macklem  */
3539964058eSXin LI static void
3549964058eSXin LI cleanup(int signo __unused)
35503914b0bSRick Macklem {
35603914b0bSRick Macklem 	nfscbd_exit(0);
35703914b0bSRick Macklem }
35803914b0bSRick Macklem 
35903914b0bSRick Macklem /*
36003914b0bSRick Macklem  * Cleanup child after SIGUSR1.
36103914b0bSRick Macklem  */
3629964058eSXin LI static void
3639964058eSXin LI child_cleanup(int signo __unused)
36403914b0bSRick Macklem {
36503914b0bSRick Macklem 	exit(0);
36603914b0bSRick Macklem }
36703914b0bSRick Macklem 
3689964058eSXin LI static void
3699964058eSXin LI nfscbd_exit(int status __unused)
37003914b0bSRick Macklem {
37103914b0bSRick Macklem 	killchildren();
37203914b0bSRick Macklem 	exit(status);
37303914b0bSRick Macklem }
374