1 /*
2  * Copyright 2007-8 Advanced Micro Devices, Inc.
3  * Copyright 2008 Red Hat Inc.
4  *
5  * Permission is hereby granted, free of charge, to any person obtaining a
6  * copy of this software and associated documentation files (the "Software"),
7  * to deal in the Software without restriction, including without limitation
8  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9  * and/or sell copies of the Software, and to permit persons to whom the
10  * Software is furnished to do so, subject to the following conditions:
11  *
12  * The above copyright notice and this permission notice shall be included in
13  * all copies or substantial portions of the Software.
14  *
15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
18  * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
19  * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
20  * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
21  * OTHER DEALINGS IN THE SOFTWARE.
22  *
23  * Authors: Dave Airlie
24  *          Alex Deucher
25  */
26 
27 #include <drm/drm_edid.h>
28 #include <drm/drm_crtc_helper.h>
29 #include <drm/drm_fb_helper.h>
30 #include <drm/drm_dp_mst_helper.h>
31 #include <drm/drm_probe_helper.h>
32 #include <drm/radeon_drm.h>
33 #include "radeon.h"
34 #include "radeon_audio.h"
35 #include "atom.h"
36 
37 #include <linux/pm_runtime.h>
38 #include <linux/vga_switcheroo.h>
39 
40 static int radeon_dp_handle_hpd(struct drm_connector *connector)
41 {
42 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
43 	int ret;
44 
45 	ret = radeon_dp_mst_check_status(radeon_connector);
46 	if (ret == -EINVAL)
47 		return 1;
48 	return 0;
49 }
50 void radeon_connector_hotplug(struct drm_connector *connector)
51 {
52 	struct drm_device *dev = connector->dev;
53 	struct radeon_device *rdev = dev->dev_private;
54 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
55 
56 	if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
57 		struct radeon_connector_atom_dig *dig_connector =
58 			radeon_connector->con_priv;
59 
60 		if (radeon_connector->is_mst_connector)
61 			return;
62 		if (dig_connector->is_mst) {
63 			radeon_dp_handle_hpd(connector);
64 			return;
65 		}
66 	}
67 	/* bail if the connector does not have hpd pin, e.g.,
68 	 * VGA, TV, etc.
69 	 */
70 	if (radeon_connector->hpd.hpd == RADEON_HPD_NONE)
71 		return;
72 
73 	radeon_hpd_set_polarity(rdev, radeon_connector->hpd.hpd);
74 
75 	/* if the connector is already off, don't turn it back on */
76 	/* FIXME: This access isn't protected by any locks. */
77 	if (connector->dpms != DRM_MODE_DPMS_ON)
78 		return;
79 
80 	/* just deal with DP (not eDP) here. */
81 	if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
82 		struct radeon_connector_atom_dig *dig_connector =
83 			radeon_connector->con_priv;
84 
85 		/* if existing sink type was not DP no need to retrain */
86 		if (dig_connector->dp_sink_type != CONNECTOR_OBJECT_ID_DISPLAYPORT)
87 			return;
88 
89 		/* first get sink type as it may be reset after (un)plug */
90 		dig_connector->dp_sink_type = radeon_dp_getsinktype(radeon_connector);
91 		/* don't do anything if sink is not display port, i.e.,
92 		 * passive dp->(dvi|hdmi) adaptor
93 		 */
94 		if (dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT &&
95 		    radeon_hpd_sense(rdev, radeon_connector->hpd.hpd) &&
96 		    radeon_dp_needs_link_train(radeon_connector)) {
97 			/* Don't start link training before we have the DPCD */
98 			if (!radeon_dp_getdpcd(radeon_connector))
99 				return;
100 
101 			/* Turn the connector off and back on immediately, which
102 			 * will trigger link training
103 			 */
104 			drm_helper_connector_dpms(connector, DRM_MODE_DPMS_OFF);
105 			drm_helper_connector_dpms(connector, DRM_MODE_DPMS_ON);
106 		}
107 	}
108 }
109 
110 static void radeon_property_change_mode(struct drm_encoder *encoder)
111 {
112 	struct drm_crtc *crtc = encoder->crtc;
113 
114 	if (crtc && crtc->enabled) {
115 		drm_crtc_helper_set_mode(crtc, &crtc->mode,
116 					 crtc->x, crtc->y, crtc->primary->fb);
117 	}
118 }
119 
120 int radeon_get_monitor_bpc(struct drm_connector *connector)
121 {
122 	struct drm_device *dev = connector->dev;
123 	struct radeon_device *rdev = dev->dev_private;
124 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
125 	struct radeon_connector_atom_dig *dig_connector;
126 	int bpc = 8;
127 	int mode_clock, max_tmds_clock;
128 
129 	switch (connector->connector_type) {
130 	case DRM_MODE_CONNECTOR_DVII:
131 	case DRM_MODE_CONNECTOR_HDMIB:
132 		if (radeon_connector->use_digital) {
133 			if (drm_detect_hdmi_monitor(radeon_connector_edid(connector))) {
134 				if (connector->display_info.bpc)
135 					bpc = connector->display_info.bpc;
136 			}
137 		}
138 		break;
139 	case DRM_MODE_CONNECTOR_DVID:
140 	case DRM_MODE_CONNECTOR_HDMIA:
141 		if (drm_detect_hdmi_monitor(radeon_connector_edid(connector))) {
142 			if (connector->display_info.bpc)
143 				bpc = connector->display_info.bpc;
144 		}
145 		break;
146 	case DRM_MODE_CONNECTOR_DisplayPort:
147 		dig_connector = radeon_connector->con_priv;
148 		if ((dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) ||
149 		    (dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_eDP) ||
150 		    drm_detect_hdmi_monitor(radeon_connector_edid(connector))) {
151 			if (connector->display_info.bpc)
152 				bpc = connector->display_info.bpc;
153 		}
154 		break;
155 	case DRM_MODE_CONNECTOR_eDP:
156 	case DRM_MODE_CONNECTOR_LVDS:
157 		if (connector->display_info.bpc)
158 			bpc = connector->display_info.bpc;
159 		else if (ASIC_IS_DCE41(rdev) || ASIC_IS_DCE5(rdev)) {
160 			const struct drm_connector_helper_funcs *connector_funcs =
161 				connector->helper_private;
162 			struct drm_encoder *encoder = connector_funcs->best_encoder(connector);
163 			struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
164 			struct radeon_encoder_atom_dig *dig = radeon_encoder->enc_priv;
165 
166 			if (dig->lcd_misc & ATOM_PANEL_MISC_V13_6BIT_PER_COLOR)
167 				bpc = 6;
168 			else if (dig->lcd_misc & ATOM_PANEL_MISC_V13_8BIT_PER_COLOR)
169 				bpc = 8;
170 		}
171 		break;
172 	}
173 
174 	if (drm_detect_hdmi_monitor(radeon_connector_edid(connector))) {
175 		/* hdmi deep color only implemented on DCE4+ */
176 		if ((bpc > 8) && !ASIC_IS_DCE4(rdev)) {
177 			DRM_DEBUG("%s: HDMI deep color %d bpc unsupported. Using 8 bpc.\n",
178 					  connector->name, bpc);
179 			bpc = 8;
180 		}
181 
182 		/*
183 		 * Pre DCE-8 hw can't handle > 12 bpc, and more than 12 bpc doesn't make
184 		 * much sense without support for > 12 bpc framebuffers. RGB 4:4:4 at
185 		 * 12 bpc is always supported on hdmi deep color sinks, as this is
186 		 * required by the HDMI-1.3 spec. Clamp to a safe 12 bpc maximum.
187 		 */
188 		if (bpc > 12) {
189 			DRM_DEBUG("%s: HDMI deep color %d bpc unsupported. Using 12 bpc.\n",
190 					  connector->name, bpc);
191 			bpc = 12;
192 		}
193 
194 		/* Any defined maximum tmds clock limit we must not exceed? */
195 		if (connector->display_info.max_tmds_clock > 0) {
196 			/* mode_clock is clock in kHz for mode to be modeset on this connector */
197 			mode_clock = radeon_connector->pixelclock_for_modeset;
198 
199 			/* Maximum allowable input clock in kHz */
200 			max_tmds_clock = connector->display_info.max_tmds_clock;
201 
202 			DRM_DEBUG("%s: hdmi mode dotclock %d kHz, max tmds input clock %d kHz.\n",
203 					  connector->name, mode_clock, max_tmds_clock);
204 
205 			/* Check if bpc is within clock limit. Try to degrade gracefully otherwise */
206 			if ((bpc == 12) && (mode_clock * 3/2 > max_tmds_clock)) {
207 				if ((connector->display_info.edid_hdmi_dc_modes & DRM_EDID_HDMI_DC_30) &&
208 					(mode_clock * 5/4 <= max_tmds_clock))
209 					bpc = 10;
210 				else
211 					bpc = 8;
212 
213 				DRM_DEBUG("%s: HDMI deep color 12 bpc exceeds max tmds clock. Using %d bpc.\n",
214 						  connector->name, bpc);
215 			}
216 
217 			if ((bpc == 10) && (mode_clock * 5/4 > max_tmds_clock)) {
218 				bpc = 8;
219 				DRM_DEBUG("%s: HDMI deep color 10 bpc exceeds max tmds clock. Using %d bpc.\n",
220 						  connector->name, bpc);
221 			}
222 		}
223 		else if (bpc > 8) {
224 			/* max_tmds_clock missing, but hdmi spec mandates it for deep color. */
225 			DRM_DEBUG("%s: Required max tmds clock for HDMI deep color missing. Using 8 bpc.\n",
226 					  connector->name);
227 			bpc = 8;
228 		}
229 	}
230 
231 	if ((radeon_deep_color == 0) && (bpc > 8)) {
232 		DRM_DEBUG("%s: Deep color disabled. Set radeon module param deep_color=1 to enable.\n",
233 				  connector->name);
234 		bpc = 8;
235 	}
236 
237 	DRM_DEBUG("%s: Display bpc=%d, returned bpc=%d\n",
238 			  connector->name, connector->display_info.bpc, bpc);
239 
240 	return bpc;
241 }
242 
243 static void
244 radeon_connector_update_scratch_regs(struct drm_connector *connector, enum drm_connector_status status)
245 {
246 	struct drm_device *dev = connector->dev;
247 	struct radeon_device *rdev = dev->dev_private;
248 	struct drm_encoder *best_encoder;
249 	struct drm_encoder *encoder;
250 	const struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
251 	bool connected;
252 
253 	best_encoder = connector_funcs->best_encoder(connector);
254 
255 	drm_connector_for_each_possible_encoder(connector, encoder) {
256 		if ((encoder == best_encoder) && (status == connector_status_connected))
257 			connected = true;
258 		else
259 			connected = false;
260 
261 		if (rdev->is_atom_bios)
262 			radeon_atombios_connected_scratch_regs(connector, encoder, connected);
263 		else
264 			radeon_combios_connected_scratch_regs(connector, encoder, connected);
265 	}
266 }
267 
268 static struct drm_encoder *radeon_find_encoder(struct drm_connector *connector, int encoder_type)
269 {
270 	struct drm_encoder *encoder;
271 
272 	drm_connector_for_each_possible_encoder(connector, encoder) {
273 		if (encoder->encoder_type == encoder_type)
274 			return encoder;
275 	}
276 
277 	return NULL;
278 }
279 
280 struct edid *radeon_connector_edid(struct drm_connector *connector)
281 {
282 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
283 	struct drm_property_blob *edid_blob = connector->edid_blob_ptr;
284 
285 	if (radeon_connector->edid) {
286 		return radeon_connector->edid;
287 	} else if (edid_blob) {
288 		struct edid *edid = kmemdup(edid_blob->data, edid_blob->length, GFP_KERNEL);
289 		if (edid)
290 			radeon_connector->edid = edid;
291 	}
292 	return radeon_connector->edid;
293 }
294 
295 static void radeon_connector_get_edid(struct drm_connector *connector)
296 {
297 	struct drm_device *dev = connector->dev;
298 	struct radeon_device *rdev = dev->dev_private;
299 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
300 
301 	if (radeon_connector->edid)
302 		return;
303 
304 	/* on hw with routers, select right port */
305 	if (radeon_connector->router.ddc_valid)
306 		radeon_router_select_ddc_port(radeon_connector);
307 
308 	if ((radeon_connector_encoder_get_dp_bridge_encoder_id(connector) !=
309 	     ENCODER_OBJECT_ID_NONE) &&
310 	    radeon_connector->ddc_bus->has_aux) {
311 		radeon_connector->edid = drm_get_edid(connector,
312 						      &radeon_connector->ddc_bus->aux.ddc);
313 	} else if ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) ||
314 		   (connector->connector_type == DRM_MODE_CONNECTOR_eDP)) {
315 		struct radeon_connector_atom_dig *dig = radeon_connector->con_priv;
316 
317 		if ((dig->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT ||
318 		     dig->dp_sink_type == CONNECTOR_OBJECT_ID_eDP) &&
319 		    radeon_connector->ddc_bus->has_aux)
320 			radeon_connector->edid = drm_get_edid(&radeon_connector->base,
321 							      &radeon_connector->ddc_bus->aux.ddc);
322 		else if (radeon_connector->ddc_bus)
323 			radeon_connector->edid = drm_get_edid(&radeon_connector->base,
324 							      &radeon_connector->ddc_bus->adapter);
325 	} else if (vga_switcheroo_handler_flags() & VGA_SWITCHEROO_CAN_SWITCH_DDC &&
326 		   connector->connector_type == DRM_MODE_CONNECTOR_LVDS &&
327 		   radeon_connector->ddc_bus) {
328 		radeon_connector->edid = drm_get_edid_switcheroo(&radeon_connector->base,
329 								 &radeon_connector->ddc_bus->adapter);
330 	} else if (radeon_connector->ddc_bus) {
331 		radeon_connector->edid = drm_get_edid(&radeon_connector->base,
332 						      &radeon_connector->ddc_bus->adapter);
333 	}
334 
335 	if (!radeon_connector->edid) {
336 		/* don't fetch the edid from the vbios if ddc fails and runpm is
337 		 * enabled so we report disconnected.
338 		 */
339 		if ((rdev->flags & RADEON_IS_PX) && (radeon_runtime_pm != 0))
340 			return;
341 
342 		if (rdev->is_atom_bios) {
343 			/* some laptops provide a hardcoded edid in rom for LCDs */
344 			if (((connector->connector_type == DRM_MODE_CONNECTOR_LVDS) ||
345 			     (connector->connector_type == DRM_MODE_CONNECTOR_eDP)))
346 				radeon_connector->edid = radeon_bios_get_hardcoded_edid(rdev);
347 		} else {
348 			/* some servers provide a hardcoded edid in rom for KVMs */
349 			radeon_connector->edid = radeon_bios_get_hardcoded_edid(rdev);
350 		}
351 	}
352 }
353 
354 static void radeon_connector_free_edid(struct drm_connector *connector)
355 {
356 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
357 
358 	if (radeon_connector->edid) {
359 		kfree(radeon_connector->edid);
360 		radeon_connector->edid = NULL;
361 	}
362 }
363 
364 static int radeon_ddc_get_modes(struct drm_connector *connector)
365 {
366 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
367 	int ret;
368 
369 	if (radeon_connector->edid) {
370 		drm_connector_update_edid_property(connector, radeon_connector->edid);
371 		ret = drm_add_edid_modes(connector, radeon_connector->edid);
372 		return ret;
373 	}
374 	drm_connector_update_edid_property(connector, NULL);
375 	return 0;
376 }
377 
378 static struct drm_encoder *radeon_best_single_encoder(struct drm_connector *connector)
379 {
380 	struct drm_encoder *encoder;
381 
382 	/* pick the first one */
383 	drm_connector_for_each_possible_encoder(connector, encoder)
384 		return encoder;
385 
386 	return NULL;
387 }
388 
389 static void radeon_get_native_mode(struct drm_connector *connector)
390 {
391 	struct drm_encoder *encoder = radeon_best_single_encoder(connector);
392 	struct radeon_encoder *radeon_encoder;
393 
394 	if (encoder == NULL)
395 		return;
396 
397 	radeon_encoder = to_radeon_encoder(encoder);
398 
399 	if (!list_empty(&connector->probed_modes)) {
400 		struct drm_display_mode *preferred_mode =
401 			list_first_entry(&connector->probed_modes,
402 					 struct drm_display_mode, head);
403 
404 		radeon_encoder->native_mode = *preferred_mode;
405 	} else {
406 		radeon_encoder->native_mode.clock = 0;
407 	}
408 }
409 
410 /*
411  * radeon_connector_analog_encoder_conflict_solve
412  * - search for other connectors sharing this encoder
413  *   if priority is true, then set them disconnected if this is connected
414  *   if priority is false, set us disconnected if they are connected
415  */
416 static enum drm_connector_status
417 radeon_connector_analog_encoder_conflict_solve(struct drm_connector *connector,
418 					       struct drm_encoder *encoder,
419 					       enum drm_connector_status current_status,
420 					       bool priority)
421 {
422 	struct drm_device *dev = connector->dev;
423 	struct drm_connector *conflict;
424 	struct radeon_connector *radeon_conflict;
425 
426 	list_for_each_entry(conflict, &dev->mode_config.connector_list, head) {
427 		struct drm_encoder *enc;
428 
429 		if (conflict == connector)
430 			continue;
431 
432 		radeon_conflict = to_radeon_connector(conflict);
433 
434 		drm_connector_for_each_possible_encoder(conflict, enc) {
435 			/* if the IDs match */
436 			if (enc == encoder) {
437 				if (conflict->status != connector_status_connected)
438 					continue;
439 
440 				if (radeon_conflict->use_digital)
441 					continue;
442 
443 				if (priority) {
444 					DRM_DEBUG_KMS("1: conflicting encoders switching off %s\n",
445 						      conflict->name);
446 					DRM_DEBUG_KMS("in favor of %s\n",
447 						      connector->name);
448 					conflict->status = connector_status_disconnected;
449 					radeon_connector_update_scratch_regs(conflict, connector_status_disconnected);
450 				} else {
451 					DRM_DEBUG_KMS("2: conflicting encoders switching off %s\n",
452 						      connector->name);
453 					DRM_DEBUG_KMS("in favor of %s\n",
454 						      conflict->name);
455 					current_status = connector_status_disconnected;
456 				}
457 				break;
458 			}
459 		}
460 	}
461 	return current_status;
462 
463 }
464 
465 static struct drm_display_mode *radeon_fp_native_mode(struct drm_encoder *encoder)
466 {
467 	struct drm_device *dev = encoder->dev;
468 	struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
469 	struct drm_display_mode *mode = NULL;
470 	struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
471 
472 	if (native_mode->hdisplay != 0 &&
473 	    native_mode->vdisplay != 0 &&
474 	    native_mode->clock != 0) {
475 		mode = drm_mode_duplicate(dev, native_mode);
476 		mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;
477 		drm_mode_set_name(mode);
478 
479 		DRM_DEBUG_KMS("Adding native panel mode %s\n", mode->name);
480 	} else if (native_mode->hdisplay != 0 &&
481 		   native_mode->vdisplay != 0) {
482 		/* mac laptops without an edid */
483 		/* Note that this is not necessarily the exact panel mode,
484 		 * but an approximation based on the cvt formula.  For these
485 		 * systems we should ideally read the mode info out of the
486 		 * registers or add a mode table, but this works and is much
487 		 * simpler.
488 		 */
489 		mode = drm_cvt_mode(dev, native_mode->hdisplay, native_mode->vdisplay, 60, true, false, false);
490 		mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;
491 		DRM_DEBUG_KMS("Adding cvt approximation of native panel mode %s\n", mode->name);
492 	}
493 	return mode;
494 }
495 
496 static void radeon_add_common_modes(struct drm_encoder *encoder, struct drm_connector *connector)
497 {
498 	struct drm_device *dev = encoder->dev;
499 	struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
500 	struct drm_display_mode *mode = NULL;
501 	struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
502 	int i;
503 	struct mode_size {
504 		int w;
505 		int h;
506 	} common_modes[17] = {
507 		{ 640,  480},
508 		{ 720,  480},
509 		{ 800,  600},
510 		{ 848,  480},
511 		{1024,  768},
512 		{1152,  768},
513 		{1280,  720},
514 		{1280,  800},
515 		{1280,  854},
516 		{1280,  960},
517 		{1280, 1024},
518 		{1440,  900},
519 		{1400, 1050},
520 		{1680, 1050},
521 		{1600, 1200},
522 		{1920, 1080},
523 		{1920, 1200}
524 	};
525 
526 	for (i = 0; i < 17; i++) {
527 		if (radeon_encoder->devices & (ATOM_DEVICE_TV_SUPPORT)) {
528 			if (common_modes[i].w > 1024 ||
529 			    common_modes[i].h > 768)
530 				continue;
531 		}
532 		if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT)) {
533 			if (common_modes[i].w > native_mode->hdisplay ||
534 			    common_modes[i].h > native_mode->vdisplay ||
535 			    (common_modes[i].w == native_mode->hdisplay &&
536 			     common_modes[i].h == native_mode->vdisplay))
537 				continue;
538 		}
539 		if (common_modes[i].w < 320 || common_modes[i].h < 200)
540 			continue;
541 
542 		mode = drm_cvt_mode(dev, common_modes[i].w, common_modes[i].h, 60, false, false, false);
543 		drm_mode_probed_add(connector, mode);
544 	}
545 }
546 
547 static int radeon_connector_set_property(struct drm_connector *connector, struct drm_property *property,
548 				  uint64_t val)
549 {
550 	struct drm_device *dev = connector->dev;
551 	struct radeon_device *rdev = dev->dev_private;
552 	struct drm_encoder *encoder;
553 	struct radeon_encoder *radeon_encoder;
554 
555 	if (property == rdev->mode_info.coherent_mode_property) {
556 		struct radeon_encoder_atom_dig *dig;
557 		bool new_coherent_mode;
558 
559 		/* need to find digital encoder on connector */
560 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
561 		if (!encoder)
562 			return 0;
563 
564 		radeon_encoder = to_radeon_encoder(encoder);
565 
566 		if (!radeon_encoder->enc_priv)
567 			return 0;
568 
569 		dig = radeon_encoder->enc_priv;
570 		new_coherent_mode = val ? true : false;
571 		if (dig->coherent_mode != new_coherent_mode) {
572 			dig->coherent_mode = new_coherent_mode;
573 			radeon_property_change_mode(&radeon_encoder->base);
574 		}
575 	}
576 
577 	if (property == rdev->mode_info.audio_property) {
578 		struct radeon_connector *radeon_connector = to_radeon_connector(connector);
579 		/* need to find digital encoder on connector */
580 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
581 		if (!encoder)
582 			return 0;
583 
584 		radeon_encoder = to_radeon_encoder(encoder);
585 
586 		if (radeon_connector->audio != val) {
587 			radeon_connector->audio = val;
588 			radeon_property_change_mode(&radeon_encoder->base);
589 		}
590 	}
591 
592 	if (property == rdev->mode_info.dither_property) {
593 		struct radeon_connector *radeon_connector = to_radeon_connector(connector);
594 		/* need to find digital encoder on connector */
595 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
596 		if (!encoder)
597 			return 0;
598 
599 		radeon_encoder = to_radeon_encoder(encoder);
600 
601 		if (radeon_connector->dither != val) {
602 			radeon_connector->dither = val;
603 			radeon_property_change_mode(&radeon_encoder->base);
604 		}
605 	}
606 
607 	if (property == rdev->mode_info.underscan_property) {
608 		/* need to find digital encoder on connector */
609 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
610 		if (!encoder)
611 			return 0;
612 
613 		radeon_encoder = to_radeon_encoder(encoder);
614 
615 		if (radeon_encoder->underscan_type != val) {
616 			radeon_encoder->underscan_type = val;
617 			radeon_property_change_mode(&radeon_encoder->base);
618 		}
619 	}
620 
621 	if (property == rdev->mode_info.underscan_hborder_property) {
622 		/* need to find digital encoder on connector */
623 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
624 		if (!encoder)
625 			return 0;
626 
627 		radeon_encoder = to_radeon_encoder(encoder);
628 
629 		if (radeon_encoder->underscan_hborder != val) {
630 			radeon_encoder->underscan_hborder = val;
631 			radeon_property_change_mode(&radeon_encoder->base);
632 		}
633 	}
634 
635 	if (property == rdev->mode_info.underscan_vborder_property) {
636 		/* need to find digital encoder on connector */
637 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
638 		if (!encoder)
639 			return 0;
640 
641 		radeon_encoder = to_radeon_encoder(encoder);
642 
643 		if (radeon_encoder->underscan_vborder != val) {
644 			radeon_encoder->underscan_vborder = val;
645 			radeon_property_change_mode(&radeon_encoder->base);
646 		}
647 	}
648 
649 	if (property == rdev->mode_info.tv_std_property) {
650 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TVDAC);
651 		if (!encoder) {
652 			encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_DAC);
653 		}
654 
655 		if (!encoder)
656 			return 0;
657 
658 		radeon_encoder = to_radeon_encoder(encoder);
659 		if (!radeon_encoder->enc_priv)
660 			return 0;
661 		if (ASIC_IS_AVIVO(rdev) || radeon_r4xx_atom) {
662 			struct radeon_encoder_atom_dac *dac_int;
663 			dac_int = radeon_encoder->enc_priv;
664 			dac_int->tv_std = val;
665 		} else {
666 			struct radeon_encoder_tv_dac *dac_int;
667 			dac_int = radeon_encoder->enc_priv;
668 			dac_int->tv_std = val;
669 		}
670 		radeon_property_change_mode(&radeon_encoder->base);
671 	}
672 
673 	if (property == rdev->mode_info.load_detect_property) {
674 		struct radeon_connector *radeon_connector =
675 			to_radeon_connector(connector);
676 
677 		if (val == 0)
678 			radeon_connector->dac_load_detect = false;
679 		else
680 			radeon_connector->dac_load_detect = true;
681 	}
682 
683 	if (property == rdev->mode_info.tmds_pll_property) {
684 		struct radeon_encoder_int_tmds *tmds = NULL;
685 		bool ret = false;
686 		/* need to find digital encoder on connector */
687 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
688 		if (!encoder)
689 			return 0;
690 
691 		radeon_encoder = to_radeon_encoder(encoder);
692 
693 		tmds = radeon_encoder->enc_priv;
694 		if (!tmds)
695 			return 0;
696 
697 		if (val == 0) {
698 			if (rdev->is_atom_bios)
699 				ret = radeon_atombios_get_tmds_info(radeon_encoder, tmds);
700 			else
701 				ret = radeon_legacy_get_tmds_info_from_combios(radeon_encoder, tmds);
702 		}
703 		if (val == 1 || !ret)
704 			radeon_legacy_get_tmds_info_from_table(radeon_encoder, tmds);
705 
706 		radeon_property_change_mode(&radeon_encoder->base);
707 	}
708 
709 	if (property == dev->mode_config.scaling_mode_property) {
710 		enum radeon_rmx_type rmx_type;
711 
712 		if (connector->encoder)
713 			radeon_encoder = to_radeon_encoder(connector->encoder);
714 		else {
715 			const struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
716 			radeon_encoder = to_radeon_encoder(connector_funcs->best_encoder(connector));
717 		}
718 
719 		switch (val) {
720 		default:
721 		case DRM_MODE_SCALE_NONE: rmx_type = RMX_OFF; break;
722 		case DRM_MODE_SCALE_CENTER: rmx_type = RMX_CENTER; break;
723 		case DRM_MODE_SCALE_ASPECT: rmx_type = RMX_ASPECT; break;
724 		case DRM_MODE_SCALE_FULLSCREEN: rmx_type = RMX_FULL; break;
725 		}
726 		if (radeon_encoder->rmx_type == rmx_type)
727 			return 0;
728 
729 		if ((rmx_type != DRM_MODE_SCALE_NONE) &&
730 		    (radeon_encoder->native_mode.clock == 0))
731 			return 0;
732 
733 		radeon_encoder->rmx_type = rmx_type;
734 
735 		radeon_property_change_mode(&radeon_encoder->base);
736 	}
737 
738 	if (property == rdev->mode_info.output_csc_property) {
739 		if (connector->encoder)
740 			radeon_encoder = to_radeon_encoder(connector->encoder);
741 		else {
742 			const struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
743 			radeon_encoder = to_radeon_encoder(connector_funcs->best_encoder(connector));
744 		}
745 
746 		if (radeon_encoder->output_csc == val)
747 			return 0;
748 
749 		radeon_encoder->output_csc = val;
750 
751 		if (connector->encoder && connector->encoder->crtc) {
752 			struct drm_crtc *crtc  = connector->encoder->crtc;
753 			struct radeon_crtc *radeon_crtc = to_radeon_crtc(crtc);
754 
755 			radeon_crtc->output_csc = radeon_encoder->output_csc;
756 
757 			/*
758 			 * Our .gamma_set assumes the .gamma_store has been
759 			 * prefilled and don't care about its arguments.
760 			 */
761 			crtc->funcs->gamma_set(crtc, NULL, NULL, NULL, 0, NULL);
762 		}
763 	}
764 
765 	return 0;
766 }
767 
768 static void radeon_fixup_lvds_native_mode(struct drm_encoder *encoder,
769 					  struct drm_connector *connector)
770 {
771 	struct radeon_encoder *radeon_encoder =	to_radeon_encoder(encoder);
772 	struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
773 	struct drm_display_mode *t, *mode;
774 
775 	/* If the EDID preferred mode doesn't match the native mode, use it */
776 	list_for_each_entry_safe(mode, t, &connector->probed_modes, head) {
777 		if (mode->type & DRM_MODE_TYPE_PREFERRED) {
778 			if (mode->hdisplay != native_mode->hdisplay ||
779 			    mode->vdisplay != native_mode->vdisplay)
780 				memcpy(native_mode, mode, sizeof(*mode));
781 		}
782 	}
783 
784 	/* Try to get native mode details from EDID if necessary */
785 	if (!native_mode->clock) {
786 		list_for_each_entry_safe(mode, t, &connector->probed_modes, head) {
787 			if (mode->hdisplay == native_mode->hdisplay &&
788 			    mode->vdisplay == native_mode->vdisplay) {
789 				*native_mode = *mode;
790 				drm_mode_set_crtcinfo(native_mode, CRTC_INTERLACE_HALVE_V);
791 				DRM_DEBUG_KMS("Determined LVDS native mode details from EDID\n");
792 				break;
793 			}
794 		}
795 	}
796 
797 	if (!native_mode->clock) {
798 		DRM_DEBUG_KMS("No LVDS native mode details, disabling RMX\n");
799 		radeon_encoder->rmx_type = RMX_OFF;
800 	}
801 }
802 
803 static int radeon_lvds_get_modes(struct drm_connector *connector)
804 {
805 	struct drm_encoder *encoder;
806 	int ret = 0;
807 	struct drm_display_mode *mode;
808 
809 	radeon_connector_get_edid(connector);
810 	ret = radeon_ddc_get_modes(connector);
811 	if (ret > 0) {
812 		encoder = radeon_best_single_encoder(connector);
813 		if (encoder) {
814 			radeon_fixup_lvds_native_mode(encoder, connector);
815 			/* add scaled modes */
816 			radeon_add_common_modes(encoder, connector);
817 		}
818 		return ret;
819 	}
820 
821 	encoder = radeon_best_single_encoder(connector);
822 	if (!encoder)
823 		return 0;
824 
825 	/* we have no EDID modes */
826 	mode = radeon_fp_native_mode(encoder);
827 	if (mode) {
828 		ret = 1;
829 		drm_mode_probed_add(connector, mode);
830 		/* add the width/height from vbios tables if available */
831 		connector->display_info.width_mm = mode->width_mm;
832 		connector->display_info.height_mm = mode->height_mm;
833 		/* add scaled modes */
834 		radeon_add_common_modes(encoder, connector);
835 	}
836 
837 	return ret;
838 }
839 
840 static enum drm_mode_status radeon_lvds_mode_valid(struct drm_connector *connector,
841 				  struct drm_display_mode *mode)
842 {
843 	struct drm_encoder *encoder = radeon_best_single_encoder(connector);
844 
845 	if ((mode->hdisplay < 320) || (mode->vdisplay < 240))
846 		return MODE_PANEL;
847 
848 	if (encoder) {
849 		struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
850 		struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
851 
852 		/* AVIVO hardware supports downscaling modes larger than the panel
853 		 * to the panel size, but I'm not sure this is desirable.
854 		 */
855 		if ((mode->hdisplay > native_mode->hdisplay) ||
856 		    (mode->vdisplay > native_mode->vdisplay))
857 			return MODE_PANEL;
858 
859 		/* if scaling is disabled, block non-native modes */
860 		if (radeon_encoder->rmx_type == RMX_OFF) {
861 			if ((mode->hdisplay != native_mode->hdisplay) ||
862 			    (mode->vdisplay != native_mode->vdisplay))
863 				return MODE_PANEL;
864 		}
865 	}
866 
867 	return MODE_OK;
868 }
869 
870 static enum drm_connector_status
871 radeon_lvds_detect(struct drm_connector *connector, bool force)
872 {
873 	struct drm_device *dev = connector->dev;
874 	struct radeon_device *rdev = dev->dev_private;
875 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
876 	struct drm_encoder *encoder = radeon_best_single_encoder(connector);
877 	enum drm_connector_status ret = connector_status_disconnected;
878 	int r;
879 
880 	if (!drm_kms_helper_is_poll_worker()) {
881 		r = pm_runtime_get_sync(connector->dev->dev);
882 		if (r < 0)
883 			return connector_status_disconnected;
884 	}
885 
886 	if (encoder) {
887 		struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
888 		struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
889 
890 		/* check if panel is valid */
891 		if (native_mode->hdisplay >= 320 && native_mode->vdisplay >= 240)
892 			ret = connector_status_connected;
893 		/* don't fetch the edid from the vbios if ddc fails and runpm is
894 		 * enabled so we report disconnected.
895 		 */
896 		if ((rdev->flags & RADEON_IS_PX) && (radeon_runtime_pm != 0))
897 			ret = connector_status_disconnected;
898 	}
899 
900 	/* check for edid as well */
901 	radeon_connector_get_edid(connector);
902 	if (radeon_connector->edid)
903 		ret = connector_status_connected;
904 	/* check acpi lid status ??? */
905 
906 	radeon_connector_update_scratch_regs(connector, ret);
907 
908 	if (!drm_kms_helper_is_poll_worker()) {
909 		pm_runtime_mark_last_busy(connector->dev->dev);
910 		pm_runtime_put_autosuspend(connector->dev->dev);
911 	}
912 
913 	return ret;
914 }
915 
916 static void radeon_connector_unregister(struct drm_connector *connector)
917 {
918 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
919 
920 	if (radeon_connector->ddc_bus && radeon_connector->ddc_bus->has_aux) {
921 		drm_dp_aux_unregister(&radeon_connector->ddc_bus->aux);
922 		radeon_connector->ddc_bus->has_aux = false;
923 	}
924 }
925 
926 static void radeon_connector_destroy(struct drm_connector *connector)
927 {
928 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
929 
930 	radeon_connector_free_edid(connector);
931 	kfree(radeon_connector->con_priv);
932 	drm_connector_unregister(connector);
933 	drm_connector_cleanup(connector);
934 	kfree(connector);
935 }
936 
937 static int radeon_lvds_set_property(struct drm_connector *connector,
938 				    struct drm_property *property,
939 				    uint64_t value)
940 {
941 	struct drm_device *dev = connector->dev;
942 	struct radeon_encoder *radeon_encoder;
943 	enum radeon_rmx_type rmx_type;
944 
945 	DRM_DEBUG_KMS("\n");
946 	if (property != dev->mode_config.scaling_mode_property)
947 		return 0;
948 
949 	if (connector->encoder)
950 		radeon_encoder = to_radeon_encoder(connector->encoder);
951 	else {
952 		const struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
953 		radeon_encoder = to_radeon_encoder(connector_funcs->best_encoder(connector));
954 	}
955 
956 	switch (value) {
957 	case DRM_MODE_SCALE_NONE: rmx_type = RMX_OFF; break;
958 	case DRM_MODE_SCALE_CENTER: rmx_type = RMX_CENTER; break;
959 	case DRM_MODE_SCALE_ASPECT: rmx_type = RMX_ASPECT; break;
960 	default:
961 	case DRM_MODE_SCALE_FULLSCREEN: rmx_type = RMX_FULL; break;
962 	}
963 	if (radeon_encoder->rmx_type == rmx_type)
964 		return 0;
965 
966 	radeon_encoder->rmx_type = rmx_type;
967 
968 	radeon_property_change_mode(&radeon_encoder->base);
969 	return 0;
970 }
971 
972 
973 static const struct drm_connector_helper_funcs radeon_lvds_connector_helper_funcs = {
974 	.get_modes = radeon_lvds_get_modes,
975 	.mode_valid = radeon_lvds_mode_valid,
976 	.best_encoder = radeon_best_single_encoder,
977 };
978 
979 static const struct drm_connector_funcs radeon_lvds_connector_funcs = {
980 	.dpms = drm_helper_connector_dpms,
981 	.detect = radeon_lvds_detect,
982 	.fill_modes = drm_helper_probe_single_connector_modes,
983 	.early_unregister = radeon_connector_unregister,
984 	.destroy = radeon_connector_destroy,
985 	.set_property = radeon_lvds_set_property,
986 };
987 
988 static int radeon_vga_get_modes(struct drm_connector *connector)
989 {
990 	int ret;
991 
992 	radeon_connector_get_edid(connector);
993 	ret = radeon_ddc_get_modes(connector);
994 
995 	radeon_get_native_mode(connector);
996 
997 	return ret;
998 }
999 
1000 static enum drm_mode_status radeon_vga_mode_valid(struct drm_connector *connector,
1001 				  struct drm_display_mode *mode)
1002 {
1003 	struct drm_device *dev = connector->dev;
1004 	struct radeon_device *rdev = dev->dev_private;
1005 
1006 	/* XXX check mode bandwidth */
1007 
1008 	if ((mode->clock / 10) > rdev->clock.max_pixel_clock)
1009 		return MODE_CLOCK_HIGH;
1010 
1011 	return MODE_OK;
1012 }
1013 
1014 static enum drm_connector_status
1015 radeon_vga_detect(struct drm_connector *connector, bool force)
1016 {
1017 	struct drm_device *dev = connector->dev;
1018 	struct radeon_device *rdev = dev->dev_private;
1019 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1020 	struct drm_encoder *encoder;
1021 	const struct drm_encoder_helper_funcs *encoder_funcs;
1022 	bool dret = false;
1023 	enum drm_connector_status ret = connector_status_disconnected;
1024 	int r;
1025 
1026 	if (!drm_kms_helper_is_poll_worker()) {
1027 		r = pm_runtime_get_sync(connector->dev->dev);
1028 		if (r < 0)
1029 			return connector_status_disconnected;
1030 	}
1031 
1032 	encoder = radeon_best_single_encoder(connector);
1033 	if (!encoder)
1034 		ret = connector_status_disconnected;
1035 
1036 	if (radeon_connector->ddc_bus)
1037 		dret = radeon_ddc_probe(radeon_connector, false);
1038 	if (dret) {
1039 		radeon_connector->detected_by_load = false;
1040 		radeon_connector_free_edid(connector);
1041 		radeon_connector_get_edid(connector);
1042 
1043 		if (!radeon_connector->edid) {
1044 			DRM_ERROR("%s: probed a monitor but no|invalid EDID\n",
1045 					connector->name);
1046 			ret = connector_status_connected;
1047 		} else {
1048 			radeon_connector->use_digital =
1049 				!!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL);
1050 
1051 			/* some oems have boards with separate digital and analog connectors
1052 			 * with a shared ddc line (often vga + hdmi)
1053 			 */
1054 			if (radeon_connector->use_digital && radeon_connector->shared_ddc) {
1055 				radeon_connector_free_edid(connector);
1056 				ret = connector_status_disconnected;
1057 			} else {
1058 				ret = connector_status_connected;
1059 			}
1060 		}
1061 	} else {
1062 
1063 		/* if we aren't forcing don't do destructive polling */
1064 		if (!force) {
1065 			/* only return the previous status if we last
1066 			 * detected a monitor via load.
1067 			 */
1068 			if (radeon_connector->detected_by_load)
1069 				ret = connector->status;
1070 			goto out;
1071 		}
1072 
1073 		if (radeon_connector->dac_load_detect && encoder) {
1074 			encoder_funcs = encoder->helper_private;
1075 			ret = encoder_funcs->detect(encoder, connector);
1076 			if (ret != connector_status_disconnected)
1077 				radeon_connector->detected_by_load = true;
1078 		}
1079 	}
1080 
1081 	if (ret == connector_status_connected)
1082 		ret = radeon_connector_analog_encoder_conflict_solve(connector, encoder, ret, true);
1083 
1084 	/* RN50 and some RV100 asics in servers often have a hardcoded EDID in the
1085 	 * vbios to deal with KVMs. If we have one and are not able to detect a monitor
1086 	 * by other means, assume the CRT is connected and use that EDID.
1087 	 */
1088 	if ((!rdev->is_atom_bios) &&
1089 	    (ret == connector_status_disconnected) &&
1090 	    rdev->mode_info.bios_hardcoded_edid_size) {
1091 		ret = connector_status_connected;
1092 	}
1093 
1094 	radeon_connector_update_scratch_regs(connector, ret);
1095 
1096 out:
1097 	if (!drm_kms_helper_is_poll_worker()) {
1098 		pm_runtime_mark_last_busy(connector->dev->dev);
1099 		pm_runtime_put_autosuspend(connector->dev->dev);
1100 	}
1101 
1102 	return ret;
1103 }
1104 
1105 static const struct drm_connector_helper_funcs radeon_vga_connector_helper_funcs = {
1106 	.get_modes = radeon_vga_get_modes,
1107 	.mode_valid = radeon_vga_mode_valid,
1108 	.best_encoder = radeon_best_single_encoder,
1109 };
1110 
1111 static const struct drm_connector_funcs radeon_vga_connector_funcs = {
1112 	.dpms = drm_helper_connector_dpms,
1113 	.detect = radeon_vga_detect,
1114 	.fill_modes = drm_helper_probe_single_connector_modes,
1115 	.early_unregister = radeon_connector_unregister,
1116 	.destroy = radeon_connector_destroy,
1117 	.set_property = radeon_connector_set_property,
1118 };
1119 
1120 static int radeon_tv_get_modes(struct drm_connector *connector)
1121 {
1122 	struct drm_device *dev = connector->dev;
1123 	struct radeon_device *rdev = dev->dev_private;
1124 	struct drm_display_mode *tv_mode;
1125 	struct drm_encoder *encoder;
1126 
1127 	encoder = radeon_best_single_encoder(connector);
1128 	if (!encoder)
1129 		return 0;
1130 
1131 	/* avivo chips can scale any mode */
1132 	if (rdev->family >= CHIP_RS600)
1133 		/* add scaled modes */
1134 		radeon_add_common_modes(encoder, connector);
1135 	else {
1136 		/* only 800x600 is supported right now on pre-avivo chips */
1137 		tv_mode = drm_cvt_mode(dev, 800, 600, 60, false, false, false);
1138 		tv_mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
1139 		drm_mode_probed_add(connector, tv_mode);
1140 	}
1141 	return 1;
1142 }
1143 
1144 static enum drm_mode_status radeon_tv_mode_valid(struct drm_connector *connector,
1145 				struct drm_display_mode *mode)
1146 {
1147 	if ((mode->hdisplay > 1024) || (mode->vdisplay > 768))
1148 		return MODE_CLOCK_RANGE;
1149 	return MODE_OK;
1150 }
1151 
1152 static enum drm_connector_status
1153 radeon_tv_detect(struct drm_connector *connector, bool force)
1154 {
1155 	struct drm_encoder *encoder;
1156 	const struct drm_encoder_helper_funcs *encoder_funcs;
1157 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1158 	enum drm_connector_status ret = connector_status_disconnected;
1159 	int r;
1160 
1161 	if (!radeon_connector->dac_load_detect)
1162 		return ret;
1163 
1164 	if (!drm_kms_helper_is_poll_worker()) {
1165 		r = pm_runtime_get_sync(connector->dev->dev);
1166 		if (r < 0)
1167 			return connector_status_disconnected;
1168 	}
1169 
1170 	encoder = radeon_best_single_encoder(connector);
1171 	if (!encoder)
1172 		ret = connector_status_disconnected;
1173 	else {
1174 		encoder_funcs = encoder->helper_private;
1175 		ret = encoder_funcs->detect(encoder, connector);
1176 	}
1177 	if (ret == connector_status_connected)
1178 		ret = radeon_connector_analog_encoder_conflict_solve(connector, encoder, ret, false);
1179 	radeon_connector_update_scratch_regs(connector, ret);
1180 
1181 	if (!drm_kms_helper_is_poll_worker()) {
1182 		pm_runtime_mark_last_busy(connector->dev->dev);
1183 		pm_runtime_put_autosuspend(connector->dev->dev);
1184 	}
1185 
1186 	return ret;
1187 }
1188 
1189 static const struct drm_connector_helper_funcs radeon_tv_connector_helper_funcs = {
1190 	.get_modes = radeon_tv_get_modes,
1191 	.mode_valid = radeon_tv_mode_valid,
1192 	.best_encoder = radeon_best_single_encoder,
1193 };
1194 
1195 static const struct drm_connector_funcs radeon_tv_connector_funcs = {
1196 	.dpms = drm_helper_connector_dpms,
1197 	.detect = radeon_tv_detect,
1198 	.fill_modes = drm_helper_probe_single_connector_modes,
1199 	.early_unregister = radeon_connector_unregister,
1200 	.destroy = radeon_connector_destroy,
1201 	.set_property = radeon_connector_set_property,
1202 };
1203 
1204 static bool radeon_check_hpd_status_unchanged(struct drm_connector *connector)
1205 {
1206 	struct drm_device *dev = connector->dev;
1207 	struct radeon_device *rdev = dev->dev_private;
1208 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1209 	enum drm_connector_status status;
1210 
1211 	/* We only trust HPD on R600 and newer ASICS. */
1212 	if (rdev->family >= CHIP_R600
1213 	  && radeon_connector->hpd.hpd != RADEON_HPD_NONE) {
1214 		if (radeon_hpd_sense(rdev, radeon_connector->hpd.hpd))
1215 			status = connector_status_connected;
1216 		else
1217 			status = connector_status_disconnected;
1218 		if (connector->status == status)
1219 			return true;
1220 	}
1221 
1222 	return false;
1223 }
1224 
1225 /*
1226  * DVI is complicated
1227  * Do a DDC probe, if DDC probe passes, get the full EDID so
1228  * we can do analog/digital monitor detection at this point.
1229  * If the monitor is an analog monitor or we got no DDC,
1230  * we need to find the DAC encoder object for this connector.
1231  * If we got no DDC, we do load detection on the DAC encoder object.
1232  * If we got analog DDC or load detection passes on the DAC encoder
1233  * we have to check if this analog encoder is shared with anyone else (TV)
1234  * if its shared we have to set the other connector to disconnected.
1235  */
1236 static enum drm_connector_status
1237 radeon_dvi_detect(struct drm_connector *connector, bool force)
1238 {
1239 	struct drm_device *dev = connector->dev;
1240 	struct radeon_device *rdev = dev->dev_private;
1241 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1242 	struct drm_encoder *encoder = NULL;
1243 	const struct drm_encoder_helper_funcs *encoder_funcs;
1244 	int r;
1245 	enum drm_connector_status ret = connector_status_disconnected;
1246 	bool dret = false, broken_edid = false;
1247 
1248 	if (!drm_kms_helper_is_poll_worker()) {
1249 		r = pm_runtime_get_sync(connector->dev->dev);
1250 		if (r < 0)
1251 			return connector_status_disconnected;
1252 	}
1253 
1254 	if (radeon_connector->detected_hpd_without_ddc) {
1255 		force = true;
1256 		radeon_connector->detected_hpd_without_ddc = false;
1257 	}
1258 
1259 	if (!force && radeon_check_hpd_status_unchanged(connector)) {
1260 		ret = connector->status;
1261 		goto exit;
1262 	}
1263 
1264 	if (radeon_connector->ddc_bus) {
1265 		dret = radeon_ddc_probe(radeon_connector, false);
1266 
1267 		/* Sometimes the pins required for the DDC probe on DVI
1268 		 * connectors don't make contact at the same time that the ones
1269 		 * for HPD do. If the DDC probe fails even though we had an HPD
1270 		 * signal, try again later */
1271 		if (!dret && !force &&
1272 		    connector->status != connector_status_connected) {
1273 			DRM_DEBUG_KMS("hpd detected without ddc, retrying in 1 second\n");
1274 			radeon_connector->detected_hpd_without_ddc = true;
1275 			schedule_delayed_work(&rdev->hotplug_work,
1276 					      msecs_to_jiffies(1000));
1277 			goto exit;
1278 		}
1279 	}
1280 	if (dret) {
1281 		radeon_connector->detected_by_load = false;
1282 		radeon_connector_free_edid(connector);
1283 		radeon_connector_get_edid(connector);
1284 
1285 		if (!radeon_connector->edid) {
1286 			DRM_ERROR("%s: probed a monitor but no|invalid EDID\n",
1287 					connector->name);
1288 			/* rs690 seems to have a problem with connectors not existing and always
1289 			 * return a block of 0's. If we see this just stop polling on this output */
1290 			if ((rdev->family == CHIP_RS690 || rdev->family == CHIP_RS740) &&
1291 			    radeon_connector->base.null_edid_counter) {
1292 				ret = connector_status_disconnected;
1293 				DRM_ERROR("%s: detected RS690 floating bus bug, stopping ddc detect\n",
1294 					  connector->name);
1295 				radeon_connector->ddc_bus = NULL;
1296 			} else {
1297 				ret = connector_status_connected;
1298 				broken_edid = true; /* defer use_digital to later */
1299 			}
1300 		} else {
1301 			radeon_connector->use_digital =
1302 				!!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL);
1303 
1304 			/* some oems have boards with separate digital and analog connectors
1305 			 * with a shared ddc line (often vga + hdmi)
1306 			 */
1307 			if ((!radeon_connector->use_digital) && radeon_connector->shared_ddc) {
1308 				radeon_connector_free_edid(connector);
1309 				ret = connector_status_disconnected;
1310 			} else {
1311 				ret = connector_status_connected;
1312 			}
1313 			/* This gets complicated.  We have boards with VGA + HDMI with a
1314 			 * shared DDC line and we have boards with DVI-D + HDMI with a shared
1315 			 * DDC line.  The latter is more complex because with DVI<->HDMI adapters
1316 			 * you don't really know what's connected to which port as both are digital.
1317 			 */
1318 			if (radeon_connector->shared_ddc && (ret == connector_status_connected)) {
1319 				struct drm_connector *list_connector;
1320 				struct radeon_connector *list_radeon_connector;
1321 				list_for_each_entry(list_connector, &dev->mode_config.connector_list, head) {
1322 					if (connector == list_connector)
1323 						continue;
1324 					list_radeon_connector = to_radeon_connector(list_connector);
1325 					if (list_radeon_connector->shared_ddc &&
1326 					    (list_radeon_connector->ddc_bus->rec.i2c_id ==
1327 					     radeon_connector->ddc_bus->rec.i2c_id)) {
1328 						/* cases where both connectors are digital */
1329 						if (list_connector->connector_type != DRM_MODE_CONNECTOR_VGA) {
1330 							/* hpd is our only option in this case */
1331 							if (!radeon_hpd_sense(rdev, radeon_connector->hpd.hpd)) {
1332 								radeon_connector_free_edid(connector);
1333 								ret = connector_status_disconnected;
1334 							}
1335 						}
1336 					}
1337 				}
1338 			}
1339 		}
1340 	}
1341 
1342 	if ((ret == connector_status_connected) && (radeon_connector->use_digital == true))
1343 		goto out;
1344 
1345 	/* DVI-D and HDMI-A are digital only */
1346 	if ((connector->connector_type == DRM_MODE_CONNECTOR_DVID) ||
1347 	    (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA))
1348 		goto out;
1349 
1350 	/* if we aren't forcing don't do destructive polling */
1351 	if (!force) {
1352 		/* only return the previous status if we last
1353 		 * detected a monitor via load.
1354 		 */
1355 		if (radeon_connector->detected_by_load)
1356 			ret = connector->status;
1357 		goto out;
1358 	}
1359 
1360 	/* find analog encoder */
1361 	if (radeon_connector->dac_load_detect) {
1362 		drm_connector_for_each_possible_encoder(connector, encoder) {
1363 			if (encoder->encoder_type != DRM_MODE_ENCODER_DAC &&
1364 			    encoder->encoder_type != DRM_MODE_ENCODER_TVDAC)
1365 				continue;
1366 
1367 			encoder_funcs = encoder->helper_private;
1368 			if (encoder_funcs->detect) {
1369 				if (!broken_edid) {
1370 					if (ret != connector_status_connected) {
1371 						/* deal with analog monitors without DDC */
1372 						ret = encoder_funcs->detect(encoder, connector);
1373 						if (ret == connector_status_connected) {
1374 							radeon_connector->use_digital = false;
1375 						}
1376 						if (ret != connector_status_disconnected)
1377 							radeon_connector->detected_by_load = true;
1378 					}
1379 				} else {
1380 					enum drm_connector_status lret;
1381 					/* assume digital unless load detected otherwise */
1382 					radeon_connector->use_digital = true;
1383 					lret = encoder_funcs->detect(encoder, connector);
1384 					DRM_DEBUG_KMS("load_detect %x returned: %x\n",encoder->encoder_type,lret);
1385 					if (lret == connector_status_connected)
1386 						radeon_connector->use_digital = false;
1387 				}
1388 				break;
1389 			}
1390 		}
1391 	}
1392 
1393 	if ((ret == connector_status_connected) && (radeon_connector->use_digital == false) &&
1394 	    encoder) {
1395 		ret = radeon_connector_analog_encoder_conflict_solve(connector, encoder, ret, true);
1396 	}
1397 
1398 	/* RN50 and some RV100 asics in servers often have a hardcoded EDID in the
1399 	 * vbios to deal with KVMs. If we have one and are not able to detect a monitor
1400 	 * by other means, assume the DFP is connected and use that EDID.  In most
1401 	 * cases the DVI port is actually a virtual KVM port connected to the service
1402 	 * processor.
1403 	 */
1404 out:
1405 	if ((!rdev->is_atom_bios) &&
1406 	    (ret == connector_status_disconnected) &&
1407 	    rdev->mode_info.bios_hardcoded_edid_size) {
1408 		radeon_connector->use_digital = true;
1409 		ret = connector_status_connected;
1410 	}
1411 
1412 	/* updated in get modes as well since we need to know if it's analog or digital */
1413 	radeon_connector_update_scratch_regs(connector, ret);
1414 
1415 	if ((radeon_audio != 0) && radeon_connector->use_digital) {
1416 		const struct drm_connector_helper_funcs *connector_funcs =
1417 			connector->helper_private;
1418 
1419 		encoder = connector_funcs->best_encoder(connector);
1420 		if (encoder && (encoder->encoder_type == DRM_MODE_ENCODER_TMDS)) {
1421 			radeon_connector_get_edid(connector);
1422 			radeon_audio_detect(connector, encoder, ret);
1423 		}
1424 	}
1425 
1426 exit:
1427 	if (!drm_kms_helper_is_poll_worker()) {
1428 		pm_runtime_mark_last_busy(connector->dev->dev);
1429 		pm_runtime_put_autosuspend(connector->dev->dev);
1430 	}
1431 
1432 	return ret;
1433 }
1434 
1435 /* okay need to be smart in here about which encoder to pick */
1436 static struct drm_encoder *radeon_dvi_encoder(struct drm_connector *connector)
1437 {
1438 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1439 	struct drm_encoder *encoder;
1440 
1441 	drm_connector_for_each_possible_encoder(connector, encoder) {
1442 		if (radeon_connector->use_digital == true) {
1443 			if (encoder->encoder_type == DRM_MODE_ENCODER_TMDS)
1444 				return encoder;
1445 		} else {
1446 			if (encoder->encoder_type == DRM_MODE_ENCODER_DAC ||
1447 			    encoder->encoder_type == DRM_MODE_ENCODER_TVDAC)
1448 				return encoder;
1449 		}
1450 	}
1451 
1452 	/* see if we have a default encoder  TODO */
1453 
1454 	/* then check use digitial */
1455 	/* pick the first one */
1456 	drm_connector_for_each_possible_encoder(connector, encoder)
1457 		return encoder;
1458 
1459 	return NULL;
1460 }
1461 
1462 static void radeon_dvi_force(struct drm_connector *connector)
1463 {
1464 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1465 	if (connector->force == DRM_FORCE_ON)
1466 		radeon_connector->use_digital = false;
1467 	if (connector->force == DRM_FORCE_ON_DIGITAL)
1468 		radeon_connector->use_digital = true;
1469 }
1470 
1471 static enum drm_mode_status radeon_dvi_mode_valid(struct drm_connector *connector,
1472 				  struct drm_display_mode *mode)
1473 {
1474 	struct drm_device *dev = connector->dev;
1475 	struct radeon_device *rdev = dev->dev_private;
1476 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1477 
1478 	/* XXX check mode bandwidth */
1479 
1480 	/* clocks over 135 MHz have heat issues with DVI on RV100 */
1481 	if (radeon_connector->use_digital &&
1482 	    (rdev->family == CHIP_RV100) &&
1483 	    (mode->clock > 135000))
1484 		return MODE_CLOCK_HIGH;
1485 
1486 	if (radeon_connector->use_digital && (mode->clock > 165000)) {
1487 		if ((radeon_connector->connector_object_id == CONNECTOR_OBJECT_ID_DUAL_LINK_DVI_I) ||
1488 		    (radeon_connector->connector_object_id == CONNECTOR_OBJECT_ID_DUAL_LINK_DVI_D) ||
1489 		    (radeon_connector->connector_object_id == CONNECTOR_OBJECT_ID_HDMI_TYPE_B))
1490 			return MODE_OK;
1491 		else if (ASIC_IS_DCE6(rdev) && drm_detect_hdmi_monitor(radeon_connector_edid(connector))) {
1492 			/* HDMI 1.3+ supports max clock of 340 Mhz */
1493 			if (mode->clock > 340000)
1494 				return MODE_CLOCK_HIGH;
1495 			else
1496 				return MODE_OK;
1497 		} else {
1498 			return MODE_CLOCK_HIGH;
1499 		}
1500 	}
1501 
1502 	/* check against the max pixel clock */
1503 	if ((mode->clock / 10) > rdev->clock.max_pixel_clock)
1504 		return MODE_CLOCK_HIGH;
1505 
1506 	return MODE_OK;
1507 }
1508 
1509 static const struct drm_connector_helper_funcs radeon_dvi_connector_helper_funcs = {
1510 	.get_modes = radeon_vga_get_modes,
1511 	.mode_valid = radeon_dvi_mode_valid,
1512 	.best_encoder = radeon_dvi_encoder,
1513 };
1514 
1515 static const struct drm_connector_funcs radeon_dvi_connector_funcs = {
1516 	.dpms = drm_helper_connector_dpms,
1517 	.detect = radeon_dvi_detect,
1518 	.fill_modes = drm_helper_probe_single_connector_modes,
1519 	.set_property = radeon_connector_set_property,
1520 	.early_unregister = radeon_connector_unregister,
1521 	.destroy = radeon_connector_destroy,
1522 	.force = radeon_dvi_force,
1523 };
1524 
1525 static int radeon_dp_get_modes(struct drm_connector *connector)
1526 {
1527 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1528 	struct radeon_connector_atom_dig *radeon_dig_connector = radeon_connector->con_priv;
1529 	struct drm_encoder *encoder = radeon_best_single_encoder(connector);
1530 	int ret;
1531 
1532 	if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) ||
1533 	    (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)) {
1534 		struct drm_display_mode *mode;
1535 
1536 		if (connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
1537 			if (!radeon_dig_connector->edp_on)
1538 				atombios_set_edp_panel_power(connector,
1539 							     ATOM_TRANSMITTER_ACTION_POWER_ON);
1540 			radeon_connector_get_edid(connector);
1541 			ret = radeon_ddc_get_modes(connector);
1542 			if (!radeon_dig_connector->edp_on)
1543 				atombios_set_edp_panel_power(connector,
1544 							     ATOM_TRANSMITTER_ACTION_POWER_OFF);
1545 		} else {
1546 			/* need to setup ddc on the bridge */
1547 			if (radeon_connector_encoder_get_dp_bridge_encoder_id(connector) !=
1548 			    ENCODER_OBJECT_ID_NONE) {
1549 				if (encoder)
1550 					radeon_atom_ext_encoder_setup_ddc(encoder);
1551 			}
1552 			radeon_connector_get_edid(connector);
1553 			ret = radeon_ddc_get_modes(connector);
1554 		}
1555 
1556 		if (ret > 0) {
1557 			if (encoder) {
1558 				radeon_fixup_lvds_native_mode(encoder, connector);
1559 				/* add scaled modes */
1560 				radeon_add_common_modes(encoder, connector);
1561 			}
1562 			return ret;
1563 		}
1564 
1565 		if (!encoder)
1566 			return 0;
1567 
1568 		/* we have no EDID modes */
1569 		mode = radeon_fp_native_mode(encoder);
1570 		if (mode) {
1571 			ret = 1;
1572 			drm_mode_probed_add(connector, mode);
1573 			/* add the width/height from vbios tables if available */
1574 			connector->display_info.width_mm = mode->width_mm;
1575 			connector->display_info.height_mm = mode->height_mm;
1576 			/* add scaled modes */
1577 			radeon_add_common_modes(encoder, connector);
1578 		}
1579 	} else {
1580 		/* need to setup ddc on the bridge */
1581 		if (radeon_connector_encoder_get_dp_bridge_encoder_id(connector) !=
1582 			ENCODER_OBJECT_ID_NONE) {
1583 			if (encoder)
1584 				radeon_atom_ext_encoder_setup_ddc(encoder);
1585 		}
1586 		radeon_connector_get_edid(connector);
1587 		ret = radeon_ddc_get_modes(connector);
1588 
1589 		radeon_get_native_mode(connector);
1590 	}
1591 
1592 	return ret;
1593 }
1594 
1595 u16 radeon_connector_encoder_get_dp_bridge_encoder_id(struct drm_connector *connector)
1596 {
1597 	struct drm_encoder *encoder;
1598 	struct radeon_encoder *radeon_encoder;
1599 
1600 	drm_connector_for_each_possible_encoder(connector, encoder) {
1601 		radeon_encoder = to_radeon_encoder(encoder);
1602 
1603 		switch (radeon_encoder->encoder_id) {
1604 		case ENCODER_OBJECT_ID_TRAVIS:
1605 		case ENCODER_OBJECT_ID_NUTMEG:
1606 			return radeon_encoder->encoder_id;
1607 		default:
1608 			break;
1609 		}
1610 	}
1611 
1612 	return ENCODER_OBJECT_ID_NONE;
1613 }
1614 
1615 static bool radeon_connector_encoder_is_hbr2(struct drm_connector *connector)
1616 {
1617 	struct drm_encoder *encoder;
1618 	struct radeon_encoder *radeon_encoder;
1619 	bool found = false;
1620 
1621 	drm_connector_for_each_possible_encoder(connector, encoder) {
1622 		radeon_encoder = to_radeon_encoder(encoder);
1623 		if (radeon_encoder->caps & ATOM_ENCODER_CAP_RECORD_HBR2)
1624 			found = true;
1625 	}
1626 
1627 	return found;
1628 }
1629 
1630 bool radeon_connector_is_dp12_capable(struct drm_connector *connector)
1631 {
1632 	struct drm_device *dev = connector->dev;
1633 	struct radeon_device *rdev = dev->dev_private;
1634 
1635 	if (ASIC_IS_DCE5(rdev) &&
1636 	    (rdev->clock.default_dispclk >= 53900) &&
1637 	    radeon_connector_encoder_is_hbr2(connector)) {
1638 		return true;
1639 	}
1640 
1641 	return false;
1642 }
1643 
1644 static enum drm_connector_status
1645 radeon_dp_detect(struct drm_connector *connector, bool force)
1646 {
1647 	struct drm_device *dev = connector->dev;
1648 	struct radeon_device *rdev = dev->dev_private;
1649 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1650 	enum drm_connector_status ret = connector_status_disconnected;
1651 	struct radeon_connector_atom_dig *radeon_dig_connector = radeon_connector->con_priv;
1652 	struct drm_encoder *encoder = radeon_best_single_encoder(connector);
1653 	int r;
1654 
1655 	if (radeon_dig_connector->is_mst)
1656 		return connector_status_disconnected;
1657 
1658 	if (!drm_kms_helper_is_poll_worker()) {
1659 		r = pm_runtime_get_sync(connector->dev->dev);
1660 		if (r < 0)
1661 			return connector_status_disconnected;
1662 	}
1663 
1664 	if (!force && radeon_check_hpd_status_unchanged(connector)) {
1665 		ret = connector->status;
1666 		goto out;
1667 	}
1668 
1669 	radeon_connector_free_edid(connector);
1670 
1671 	if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) ||
1672 	    (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)) {
1673 		if (encoder) {
1674 			struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
1675 			struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
1676 
1677 			/* check if panel is valid */
1678 			if (native_mode->hdisplay >= 320 && native_mode->vdisplay >= 240)
1679 				ret = connector_status_connected;
1680 			/* don't fetch the edid from the vbios if ddc fails and runpm is
1681 			 * enabled so we report disconnected.
1682 			 */
1683 			if ((rdev->flags & RADEON_IS_PX) && (radeon_runtime_pm != 0))
1684 				ret = connector_status_disconnected;
1685 		}
1686 		/* eDP is always DP */
1687 		radeon_dig_connector->dp_sink_type = CONNECTOR_OBJECT_ID_DISPLAYPORT;
1688 		if (!radeon_dig_connector->edp_on)
1689 			atombios_set_edp_panel_power(connector,
1690 						     ATOM_TRANSMITTER_ACTION_POWER_ON);
1691 		if (radeon_dp_getdpcd(radeon_connector))
1692 			ret = connector_status_connected;
1693 		if (!radeon_dig_connector->edp_on)
1694 			atombios_set_edp_panel_power(connector,
1695 						     ATOM_TRANSMITTER_ACTION_POWER_OFF);
1696 	} else if (radeon_connector_encoder_get_dp_bridge_encoder_id(connector) !=
1697 		   ENCODER_OBJECT_ID_NONE) {
1698 		/* DP bridges are always DP */
1699 		radeon_dig_connector->dp_sink_type = CONNECTOR_OBJECT_ID_DISPLAYPORT;
1700 		/* get the DPCD from the bridge */
1701 		radeon_dp_getdpcd(radeon_connector);
1702 
1703 		if (encoder) {
1704 			/* setup ddc on the bridge */
1705 			radeon_atom_ext_encoder_setup_ddc(encoder);
1706 			/* bridge chips are always aux */
1707 			if (radeon_ddc_probe(radeon_connector, true)) /* try DDC */
1708 				ret = connector_status_connected;
1709 			else if (radeon_connector->dac_load_detect) { /* try load detection */
1710 				const struct drm_encoder_helper_funcs *encoder_funcs = encoder->helper_private;
1711 				ret = encoder_funcs->detect(encoder, connector);
1712 			}
1713 		}
1714 	} else {
1715 		radeon_dig_connector->dp_sink_type = radeon_dp_getsinktype(radeon_connector);
1716 		if (radeon_hpd_sense(rdev, radeon_connector->hpd.hpd)) {
1717 			ret = connector_status_connected;
1718 			if (radeon_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) {
1719 				radeon_dp_getdpcd(radeon_connector);
1720 				r = radeon_dp_mst_probe(radeon_connector);
1721 				if (r == 1)
1722 					ret = connector_status_disconnected;
1723 			}
1724 		} else {
1725 			if (radeon_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) {
1726 				if (radeon_dp_getdpcd(radeon_connector)) {
1727 					r = radeon_dp_mst_probe(radeon_connector);
1728 					if (r == 1)
1729 						ret = connector_status_disconnected;
1730 					else
1731 						ret = connector_status_connected;
1732 				}
1733 			} else {
1734 				/* try non-aux ddc (DP to DVI/HDMI/etc. adapter) */
1735 				if (radeon_ddc_probe(radeon_connector, false))
1736 					ret = connector_status_connected;
1737 			}
1738 		}
1739 	}
1740 
1741 	radeon_connector_update_scratch_regs(connector, ret);
1742 
1743 	if ((radeon_audio != 0) && encoder) {
1744 		radeon_connector_get_edid(connector);
1745 		radeon_audio_detect(connector, encoder, ret);
1746 	}
1747 
1748 out:
1749 	if (!drm_kms_helper_is_poll_worker()) {
1750 		pm_runtime_mark_last_busy(connector->dev->dev);
1751 		pm_runtime_put_autosuspend(connector->dev->dev);
1752 	}
1753 
1754 	return ret;
1755 }
1756 
1757 static enum drm_mode_status radeon_dp_mode_valid(struct drm_connector *connector,
1758 				  struct drm_display_mode *mode)
1759 {
1760 	struct drm_device *dev = connector->dev;
1761 	struct radeon_device *rdev = dev->dev_private;
1762 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1763 	struct radeon_connector_atom_dig *radeon_dig_connector = radeon_connector->con_priv;
1764 
1765 	/* XXX check mode bandwidth */
1766 
1767 	if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) ||
1768 	    (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)) {
1769 		struct drm_encoder *encoder = radeon_best_single_encoder(connector);
1770 
1771 		if ((mode->hdisplay < 320) || (mode->vdisplay < 240))
1772 			return MODE_PANEL;
1773 
1774 		if (encoder) {
1775 			struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
1776 			struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
1777 
1778 			/* AVIVO hardware supports downscaling modes larger than the panel
1779 			 * to the panel size, but I'm not sure this is desirable.
1780 			 */
1781 			if ((mode->hdisplay > native_mode->hdisplay) ||
1782 			    (mode->vdisplay > native_mode->vdisplay))
1783 				return MODE_PANEL;
1784 
1785 			/* if scaling is disabled, block non-native modes */
1786 			if (radeon_encoder->rmx_type == RMX_OFF) {
1787 				if ((mode->hdisplay != native_mode->hdisplay) ||
1788 				    (mode->vdisplay != native_mode->vdisplay))
1789 					return MODE_PANEL;
1790 			}
1791 		}
1792 	} else {
1793 		if ((radeon_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) ||
1794 		    (radeon_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_eDP)) {
1795 			return radeon_dp_mode_valid_helper(connector, mode);
1796 		} else {
1797 			if (ASIC_IS_DCE6(rdev) && drm_detect_hdmi_monitor(radeon_connector_edid(connector))) {
1798 				/* HDMI 1.3+ supports max clock of 340 Mhz */
1799 				if (mode->clock > 340000)
1800 					return MODE_CLOCK_HIGH;
1801 			} else {
1802 				if (mode->clock > 165000)
1803 					return MODE_CLOCK_HIGH;
1804 			}
1805 		}
1806 	}
1807 
1808 	return MODE_OK;
1809 }
1810 
1811 static const struct drm_connector_helper_funcs radeon_dp_connector_helper_funcs = {
1812 	.get_modes = radeon_dp_get_modes,
1813 	.mode_valid = radeon_dp_mode_valid,
1814 	.best_encoder = radeon_dvi_encoder,
1815 };
1816 
1817 static const struct drm_connector_funcs radeon_dp_connector_funcs = {
1818 	.dpms = drm_helper_connector_dpms,
1819 	.detect = radeon_dp_detect,
1820 	.fill_modes = drm_helper_probe_single_connector_modes,
1821 	.set_property = radeon_connector_set_property,
1822 	.early_unregister = radeon_connector_unregister,
1823 	.destroy = radeon_connector_destroy,
1824 	.force = radeon_dvi_force,
1825 };
1826 
1827 static const struct drm_connector_funcs radeon_edp_connector_funcs = {
1828 	.dpms = drm_helper_connector_dpms,
1829 	.detect = radeon_dp_detect,
1830 	.fill_modes = drm_helper_probe_single_connector_modes,
1831 	.set_property = radeon_lvds_set_property,
1832 	.early_unregister = radeon_connector_unregister,
1833 	.destroy = radeon_connector_destroy,
1834 	.force = radeon_dvi_force,
1835 };
1836 
1837 static const struct drm_connector_funcs radeon_lvds_bridge_connector_funcs = {
1838 	.dpms = drm_helper_connector_dpms,
1839 	.detect = radeon_dp_detect,
1840 	.fill_modes = drm_helper_probe_single_connector_modes,
1841 	.set_property = radeon_lvds_set_property,
1842 	.early_unregister = radeon_connector_unregister,
1843 	.destroy = radeon_connector_destroy,
1844 	.force = radeon_dvi_force,
1845 };
1846 
1847 void
1848 radeon_add_atom_connector(struct drm_device *dev,
1849 			  uint32_t connector_id,
1850 			  uint32_t supported_device,
1851 			  int connector_type,
1852 			  struct radeon_i2c_bus_rec *i2c_bus,
1853 			  uint32_t igp_lane_info,
1854 			  uint16_t connector_object_id,
1855 			  struct radeon_hpd *hpd,
1856 			  struct radeon_router *router)
1857 {
1858 	struct radeon_device *rdev = dev->dev_private;
1859 	struct drm_connector *connector;
1860 	struct radeon_connector *radeon_connector;
1861 	struct radeon_connector_atom_dig *radeon_dig_connector;
1862 	struct drm_encoder *encoder;
1863 	struct radeon_encoder *radeon_encoder;
1864 	struct i2c_adapter *ddc = NULL;
1865 	uint32_t subpixel_order = SubPixelNone;
1866 	bool shared_ddc = false;
1867 	bool is_dp_bridge = false;
1868 	bool has_aux = false;
1869 
1870 	if (connector_type == DRM_MODE_CONNECTOR_Unknown)
1871 		return;
1872 
1873 	/* if the user selected tv=0 don't try and add the connector */
1874 	if (((connector_type == DRM_MODE_CONNECTOR_SVIDEO) ||
1875 	     (connector_type == DRM_MODE_CONNECTOR_Composite) ||
1876 	     (connector_type == DRM_MODE_CONNECTOR_9PinDIN)) &&
1877 	    (radeon_tv == 0))
1878 		return;
1879 
1880 	/* see if we already added it */
1881 	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
1882 		radeon_connector = to_radeon_connector(connector);
1883 		if (radeon_connector->connector_id == connector_id) {
1884 			radeon_connector->devices |= supported_device;
1885 			return;
1886 		}
1887 		if (radeon_connector->ddc_bus && i2c_bus->valid) {
1888 			if (radeon_connector->ddc_bus->rec.i2c_id == i2c_bus->i2c_id) {
1889 				radeon_connector->shared_ddc = true;
1890 				shared_ddc = true;
1891 			}
1892 			if (radeon_connector->router_bus && router->ddc_valid &&
1893 			    (radeon_connector->router.router_id == router->router_id)) {
1894 				radeon_connector->shared_ddc = false;
1895 				shared_ddc = false;
1896 			}
1897 		}
1898 	}
1899 
1900 	/* check if it's a dp bridge */
1901 	list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
1902 		radeon_encoder = to_radeon_encoder(encoder);
1903 		if (radeon_encoder->devices & supported_device) {
1904 			switch (radeon_encoder->encoder_id) {
1905 			case ENCODER_OBJECT_ID_TRAVIS:
1906 			case ENCODER_OBJECT_ID_NUTMEG:
1907 				is_dp_bridge = true;
1908 				break;
1909 			default:
1910 				break;
1911 			}
1912 		}
1913 	}
1914 
1915 	radeon_connector = kzalloc(sizeof(struct radeon_connector), GFP_KERNEL);
1916 	if (!radeon_connector)
1917 		return;
1918 
1919 	connector = &radeon_connector->base;
1920 
1921 	radeon_connector->connector_id = connector_id;
1922 	radeon_connector->devices = supported_device;
1923 	radeon_connector->shared_ddc = shared_ddc;
1924 	radeon_connector->connector_object_id = connector_object_id;
1925 	radeon_connector->hpd = *hpd;
1926 
1927 	radeon_connector->router = *router;
1928 	if (router->ddc_valid || router->cd_valid) {
1929 		radeon_connector->router_bus = radeon_i2c_lookup(rdev, &router->i2c_info);
1930 		if (!radeon_connector->router_bus)
1931 			DRM_ERROR("Failed to assign router i2c bus! Check dmesg for i2c errors.\n");
1932 	}
1933 
1934 	if (is_dp_bridge) {
1935 		radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
1936 		if (!radeon_dig_connector)
1937 			goto failed;
1938 		radeon_dig_connector->igp_lane_info = igp_lane_info;
1939 		radeon_connector->con_priv = radeon_dig_connector;
1940 		if (i2c_bus->valid) {
1941 			radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1942 			if (radeon_connector->ddc_bus) {
1943 				has_aux = true;
1944 				ddc = &radeon_connector->ddc_bus->adapter;
1945 			} else {
1946 				DRM_ERROR("DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1947 			}
1948 		}
1949 		switch (connector_type) {
1950 		case DRM_MODE_CONNECTOR_VGA:
1951 		case DRM_MODE_CONNECTOR_DVIA:
1952 		default:
1953 			drm_connector_init_with_ddc(dev, &radeon_connector->base,
1954 						    &radeon_dp_connector_funcs,
1955 						    connector_type,
1956 						    ddc);
1957 			drm_connector_helper_add(&radeon_connector->base,
1958 						 &radeon_dp_connector_helper_funcs);
1959 			connector->interlace_allowed = true;
1960 			connector->doublescan_allowed = true;
1961 			radeon_connector->dac_load_detect = true;
1962 			drm_object_attach_property(&radeon_connector->base.base,
1963 						      rdev->mode_info.load_detect_property,
1964 						      1);
1965 			drm_object_attach_property(&radeon_connector->base.base,
1966 						   dev->mode_config.scaling_mode_property,
1967 						   DRM_MODE_SCALE_NONE);
1968 			if (ASIC_IS_DCE5(rdev))
1969 				drm_object_attach_property(&radeon_connector->base.base,
1970 							   rdev->mode_info.output_csc_property,
1971 							   RADEON_OUTPUT_CSC_BYPASS);
1972 			break;
1973 		case DRM_MODE_CONNECTOR_DVII:
1974 		case DRM_MODE_CONNECTOR_DVID:
1975 		case DRM_MODE_CONNECTOR_HDMIA:
1976 		case DRM_MODE_CONNECTOR_HDMIB:
1977 		case DRM_MODE_CONNECTOR_DisplayPort:
1978 			drm_connector_init_with_ddc(dev, &radeon_connector->base,
1979 						    &radeon_dp_connector_funcs,
1980 						    connector_type,
1981 						    ddc);
1982 			drm_connector_helper_add(&radeon_connector->base,
1983 						 &radeon_dp_connector_helper_funcs);
1984 			drm_object_attach_property(&radeon_connector->base.base,
1985 						      rdev->mode_info.underscan_property,
1986 						      UNDERSCAN_OFF);
1987 			drm_object_attach_property(&radeon_connector->base.base,
1988 						      rdev->mode_info.underscan_hborder_property,
1989 						      0);
1990 			drm_object_attach_property(&radeon_connector->base.base,
1991 						      rdev->mode_info.underscan_vborder_property,
1992 						      0);
1993 
1994 			drm_object_attach_property(&radeon_connector->base.base,
1995 						      dev->mode_config.scaling_mode_property,
1996 						      DRM_MODE_SCALE_NONE);
1997 
1998 			drm_object_attach_property(&radeon_connector->base.base,
1999 						   rdev->mode_info.dither_property,
2000 						   RADEON_FMT_DITHER_DISABLE);
2001 
2002 			if (radeon_audio != 0) {
2003 				drm_object_attach_property(&radeon_connector->base.base,
2004 							   rdev->mode_info.audio_property,
2005 							   RADEON_AUDIO_AUTO);
2006 				radeon_connector->audio = RADEON_AUDIO_AUTO;
2007 			}
2008 			if (ASIC_IS_DCE5(rdev))
2009 				drm_object_attach_property(&radeon_connector->base.base,
2010 							   rdev->mode_info.output_csc_property,
2011 							   RADEON_OUTPUT_CSC_BYPASS);
2012 
2013 			subpixel_order = SubPixelHorizontalRGB;
2014 			connector->interlace_allowed = true;
2015 			if (connector_type == DRM_MODE_CONNECTOR_HDMIB)
2016 				connector->doublescan_allowed = true;
2017 			else
2018 				connector->doublescan_allowed = false;
2019 			if (connector_type == DRM_MODE_CONNECTOR_DVII) {
2020 				radeon_connector->dac_load_detect = true;
2021 				drm_object_attach_property(&radeon_connector->base.base,
2022 							      rdev->mode_info.load_detect_property,
2023 							      1);
2024 			}
2025 			break;
2026 		case DRM_MODE_CONNECTOR_LVDS:
2027 		case DRM_MODE_CONNECTOR_eDP:
2028 			drm_connector_init_with_ddc(dev, &radeon_connector->base,
2029 						    &radeon_lvds_bridge_connector_funcs,
2030 						    connector_type,
2031 						    ddc);
2032 			drm_connector_helper_add(&radeon_connector->base,
2033 						 &radeon_dp_connector_helper_funcs);
2034 			drm_object_attach_property(&radeon_connector->base.base,
2035 						      dev->mode_config.scaling_mode_property,
2036 						      DRM_MODE_SCALE_FULLSCREEN);
2037 			subpixel_order = SubPixelHorizontalRGB;
2038 			connector->interlace_allowed = false;
2039 			connector->doublescan_allowed = false;
2040 			break;
2041 		}
2042 	} else {
2043 		switch (connector_type) {
2044 		case DRM_MODE_CONNECTOR_VGA:
2045 			if (i2c_bus->valid) {
2046 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2047 				if (!radeon_connector->ddc_bus)
2048 					DRM_ERROR("VGA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2049 				else
2050 					ddc = &radeon_connector->ddc_bus->adapter;
2051 			}
2052 			drm_connector_init_with_ddc(dev, &radeon_connector->base,
2053 						    &radeon_vga_connector_funcs,
2054 						    connector_type,
2055 						    ddc);
2056 			drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
2057 			radeon_connector->dac_load_detect = true;
2058 			drm_object_attach_property(&radeon_connector->base.base,
2059 						      rdev->mode_info.load_detect_property,
2060 						      1);
2061 			if (ASIC_IS_AVIVO(rdev))
2062 				drm_object_attach_property(&radeon_connector->base.base,
2063 							   dev->mode_config.scaling_mode_property,
2064 							   DRM_MODE_SCALE_NONE);
2065 			if (ASIC_IS_DCE5(rdev))
2066 				drm_object_attach_property(&radeon_connector->base.base,
2067 							   rdev->mode_info.output_csc_property,
2068 							   RADEON_OUTPUT_CSC_BYPASS);
2069 			/* no HPD on analog connectors */
2070 			radeon_connector->hpd.hpd = RADEON_HPD_NONE;
2071 			connector->interlace_allowed = true;
2072 			connector->doublescan_allowed = true;
2073 			break;
2074 		case DRM_MODE_CONNECTOR_DVIA:
2075 			if (i2c_bus->valid) {
2076 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2077 				if (!radeon_connector->ddc_bus)
2078 					DRM_ERROR("DVIA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2079 				else
2080 					ddc = &radeon_connector->ddc_bus->adapter;
2081 			}
2082 			drm_connector_init_with_ddc(dev, &radeon_connector->base,
2083 						    &radeon_vga_connector_funcs,
2084 						    connector_type,
2085 						    ddc);
2086 			drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
2087 			radeon_connector->dac_load_detect = true;
2088 			drm_object_attach_property(&radeon_connector->base.base,
2089 						      rdev->mode_info.load_detect_property,
2090 						      1);
2091 			if (ASIC_IS_AVIVO(rdev))
2092 				drm_object_attach_property(&radeon_connector->base.base,
2093 							   dev->mode_config.scaling_mode_property,
2094 							   DRM_MODE_SCALE_NONE);
2095 			if (ASIC_IS_DCE5(rdev))
2096 				drm_object_attach_property(&radeon_connector->base.base,
2097 							   rdev->mode_info.output_csc_property,
2098 							   RADEON_OUTPUT_CSC_BYPASS);
2099 			/* no HPD on analog connectors */
2100 			radeon_connector->hpd.hpd = RADEON_HPD_NONE;
2101 			connector->interlace_allowed = true;
2102 			connector->doublescan_allowed = true;
2103 			break;
2104 		case DRM_MODE_CONNECTOR_DVII:
2105 		case DRM_MODE_CONNECTOR_DVID:
2106 			radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
2107 			if (!radeon_dig_connector)
2108 				goto failed;
2109 			radeon_dig_connector->igp_lane_info = igp_lane_info;
2110 			radeon_connector->con_priv = radeon_dig_connector;
2111 			if (i2c_bus->valid) {
2112 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2113 				if (!radeon_connector->ddc_bus)
2114 					DRM_ERROR("DVI: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2115 				else
2116 					ddc = &radeon_connector->ddc_bus->adapter;
2117 			}
2118 			drm_connector_init_with_ddc(dev, &radeon_connector->base,
2119 						    &radeon_dvi_connector_funcs,
2120 						    connector_type,
2121 						    ddc);
2122 			drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
2123 			subpixel_order = SubPixelHorizontalRGB;
2124 			drm_object_attach_property(&radeon_connector->base.base,
2125 						      rdev->mode_info.coherent_mode_property,
2126 						      1);
2127 			if (ASIC_IS_AVIVO(rdev)) {
2128 				drm_object_attach_property(&radeon_connector->base.base,
2129 							      rdev->mode_info.underscan_property,
2130 							      UNDERSCAN_OFF);
2131 				drm_object_attach_property(&radeon_connector->base.base,
2132 							      rdev->mode_info.underscan_hborder_property,
2133 							      0);
2134 				drm_object_attach_property(&radeon_connector->base.base,
2135 							      rdev->mode_info.underscan_vborder_property,
2136 							      0);
2137 				drm_object_attach_property(&radeon_connector->base.base,
2138 							   rdev->mode_info.dither_property,
2139 							   RADEON_FMT_DITHER_DISABLE);
2140 				drm_object_attach_property(&radeon_connector->base.base,
2141 							   dev->mode_config.scaling_mode_property,
2142 							   DRM_MODE_SCALE_NONE);
2143 			}
2144 			if (ASIC_IS_DCE2(rdev) && (radeon_audio != 0)) {
2145 				drm_object_attach_property(&radeon_connector->base.base,
2146 							   rdev->mode_info.audio_property,
2147 							   RADEON_AUDIO_AUTO);
2148 				radeon_connector->audio = RADEON_AUDIO_AUTO;
2149 			}
2150 			if (connector_type == DRM_MODE_CONNECTOR_DVII) {
2151 				radeon_connector->dac_load_detect = true;
2152 				drm_object_attach_property(&radeon_connector->base.base,
2153 							      rdev->mode_info.load_detect_property,
2154 							      1);
2155 			}
2156 			if (ASIC_IS_DCE5(rdev))
2157 				drm_object_attach_property(&radeon_connector->base.base,
2158 							   rdev->mode_info.output_csc_property,
2159 							   RADEON_OUTPUT_CSC_BYPASS);
2160 			connector->interlace_allowed = true;
2161 			if (connector_type == DRM_MODE_CONNECTOR_DVII)
2162 				connector->doublescan_allowed = true;
2163 			else
2164 				connector->doublescan_allowed = false;
2165 			break;
2166 		case DRM_MODE_CONNECTOR_HDMIA:
2167 		case DRM_MODE_CONNECTOR_HDMIB:
2168 			radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
2169 			if (!radeon_dig_connector)
2170 				goto failed;
2171 			radeon_dig_connector->igp_lane_info = igp_lane_info;
2172 			radeon_connector->con_priv = radeon_dig_connector;
2173 			if (i2c_bus->valid) {
2174 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2175 				if (!radeon_connector->ddc_bus)
2176 					DRM_ERROR("HDMI: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2177 				else
2178 					ddc = &radeon_connector->ddc_bus->adapter;
2179 			}
2180 			drm_connector_init_with_ddc(dev, &radeon_connector->base,
2181 						    &radeon_dvi_connector_funcs,
2182 						    connector_type,
2183 						    ddc);
2184 			drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
2185 			drm_object_attach_property(&radeon_connector->base.base,
2186 						      rdev->mode_info.coherent_mode_property,
2187 						      1);
2188 			if (ASIC_IS_AVIVO(rdev)) {
2189 				drm_object_attach_property(&radeon_connector->base.base,
2190 							      rdev->mode_info.underscan_property,
2191 							      UNDERSCAN_OFF);
2192 				drm_object_attach_property(&radeon_connector->base.base,
2193 							      rdev->mode_info.underscan_hborder_property,
2194 							      0);
2195 				drm_object_attach_property(&radeon_connector->base.base,
2196 							      rdev->mode_info.underscan_vborder_property,
2197 							      0);
2198 				drm_object_attach_property(&radeon_connector->base.base,
2199 							   rdev->mode_info.dither_property,
2200 							   RADEON_FMT_DITHER_DISABLE);
2201 				drm_object_attach_property(&radeon_connector->base.base,
2202 							   dev->mode_config.scaling_mode_property,
2203 							   DRM_MODE_SCALE_NONE);
2204 			}
2205 			if (ASIC_IS_DCE2(rdev) && (radeon_audio != 0)) {
2206 				drm_object_attach_property(&radeon_connector->base.base,
2207 							   rdev->mode_info.audio_property,
2208 							   RADEON_AUDIO_AUTO);
2209 				radeon_connector->audio = RADEON_AUDIO_AUTO;
2210 			}
2211 			if (ASIC_IS_DCE5(rdev))
2212 				drm_object_attach_property(&radeon_connector->base.base,
2213 							   rdev->mode_info.output_csc_property,
2214 							   RADEON_OUTPUT_CSC_BYPASS);
2215 			subpixel_order = SubPixelHorizontalRGB;
2216 			connector->interlace_allowed = true;
2217 			if (connector_type == DRM_MODE_CONNECTOR_HDMIB)
2218 				connector->doublescan_allowed = true;
2219 			else
2220 				connector->doublescan_allowed = false;
2221 			break;
2222 		case DRM_MODE_CONNECTOR_DisplayPort:
2223 			radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
2224 			if (!radeon_dig_connector)
2225 				goto failed;
2226 			radeon_dig_connector->igp_lane_info = igp_lane_info;
2227 			radeon_connector->con_priv = radeon_dig_connector;
2228 			if (i2c_bus->valid) {
2229 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2230 				if (radeon_connector->ddc_bus) {
2231 					has_aux = true;
2232 					ddc = &radeon_connector->ddc_bus->adapter;
2233 				} else {
2234 					DRM_ERROR("DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2235 				}
2236 			}
2237 			drm_connector_init_with_ddc(dev, &radeon_connector->base,
2238 						    &radeon_dp_connector_funcs,
2239 						    connector_type,
2240 						    ddc);
2241 			drm_connector_helper_add(&radeon_connector->base, &radeon_dp_connector_helper_funcs);
2242 			subpixel_order = SubPixelHorizontalRGB;
2243 			drm_object_attach_property(&radeon_connector->base.base,
2244 						      rdev->mode_info.coherent_mode_property,
2245 						      1);
2246 			if (ASIC_IS_AVIVO(rdev)) {
2247 				drm_object_attach_property(&radeon_connector->base.base,
2248 							      rdev->mode_info.underscan_property,
2249 							      UNDERSCAN_OFF);
2250 				drm_object_attach_property(&radeon_connector->base.base,
2251 							      rdev->mode_info.underscan_hborder_property,
2252 							      0);
2253 				drm_object_attach_property(&radeon_connector->base.base,
2254 							      rdev->mode_info.underscan_vborder_property,
2255 							      0);
2256 				drm_object_attach_property(&radeon_connector->base.base,
2257 							   rdev->mode_info.dither_property,
2258 							   RADEON_FMT_DITHER_DISABLE);
2259 				drm_object_attach_property(&radeon_connector->base.base,
2260 							   dev->mode_config.scaling_mode_property,
2261 							   DRM_MODE_SCALE_NONE);
2262 			}
2263 			if (ASIC_IS_DCE2(rdev) && (radeon_audio != 0)) {
2264 				drm_object_attach_property(&radeon_connector->base.base,
2265 							   rdev->mode_info.audio_property,
2266 							   RADEON_AUDIO_AUTO);
2267 				radeon_connector->audio = RADEON_AUDIO_AUTO;
2268 			}
2269 			if (ASIC_IS_DCE5(rdev))
2270 				drm_object_attach_property(&radeon_connector->base.base,
2271 							   rdev->mode_info.output_csc_property,
2272 							   RADEON_OUTPUT_CSC_BYPASS);
2273 			connector->interlace_allowed = true;
2274 			/* in theory with a DP to VGA converter... */
2275 			connector->doublescan_allowed = false;
2276 			break;
2277 		case DRM_MODE_CONNECTOR_eDP:
2278 			radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
2279 			if (!radeon_dig_connector)
2280 				goto failed;
2281 			radeon_dig_connector->igp_lane_info = igp_lane_info;
2282 			radeon_connector->con_priv = radeon_dig_connector;
2283 			if (i2c_bus->valid) {
2284 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2285 				if (radeon_connector->ddc_bus) {
2286 					has_aux = true;
2287 					ddc = &radeon_connector->ddc_bus->adapter;
2288 				} else {
2289 					DRM_ERROR("DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2290 				}
2291 			}
2292 			drm_connector_init_with_ddc(dev, &radeon_connector->base,
2293 						    &radeon_edp_connector_funcs,
2294 						    connector_type,
2295 						    ddc);
2296 			drm_connector_helper_add(&radeon_connector->base, &radeon_dp_connector_helper_funcs);
2297 			drm_object_attach_property(&radeon_connector->base.base,
2298 						      dev->mode_config.scaling_mode_property,
2299 						      DRM_MODE_SCALE_FULLSCREEN);
2300 			subpixel_order = SubPixelHorizontalRGB;
2301 			connector->interlace_allowed = false;
2302 			connector->doublescan_allowed = false;
2303 			break;
2304 		case DRM_MODE_CONNECTOR_SVIDEO:
2305 		case DRM_MODE_CONNECTOR_Composite:
2306 		case DRM_MODE_CONNECTOR_9PinDIN:
2307 			drm_connector_init_with_ddc(dev, &radeon_connector->base,
2308 						    &radeon_tv_connector_funcs,
2309 						    connector_type,
2310 						    ddc);
2311 			drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
2312 			radeon_connector->dac_load_detect = true;
2313 			drm_object_attach_property(&radeon_connector->base.base,
2314 						      rdev->mode_info.load_detect_property,
2315 						      1);
2316 			drm_object_attach_property(&radeon_connector->base.base,
2317 						      rdev->mode_info.tv_std_property,
2318 						      radeon_atombios_get_tv_info(rdev));
2319 			/* no HPD on analog connectors */
2320 			radeon_connector->hpd.hpd = RADEON_HPD_NONE;
2321 			connector->interlace_allowed = false;
2322 			connector->doublescan_allowed = false;
2323 			break;
2324 		case DRM_MODE_CONNECTOR_LVDS:
2325 			radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
2326 			if (!radeon_dig_connector)
2327 				goto failed;
2328 			radeon_dig_connector->igp_lane_info = igp_lane_info;
2329 			radeon_connector->con_priv = radeon_dig_connector;
2330 			if (i2c_bus->valid) {
2331 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2332 				if (!radeon_connector->ddc_bus)
2333 					DRM_ERROR("LVDS: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2334 				else
2335 					ddc = &radeon_connector->ddc_bus->adapter;
2336 			}
2337 			drm_connector_init_with_ddc(dev, &radeon_connector->base,
2338 						    &radeon_lvds_connector_funcs,
2339 						    connector_type,
2340 						    ddc);
2341 			drm_connector_helper_add(&radeon_connector->base, &radeon_lvds_connector_helper_funcs);
2342 			drm_object_attach_property(&radeon_connector->base.base,
2343 						      dev->mode_config.scaling_mode_property,
2344 						      DRM_MODE_SCALE_FULLSCREEN);
2345 			subpixel_order = SubPixelHorizontalRGB;
2346 			connector->interlace_allowed = false;
2347 			connector->doublescan_allowed = false;
2348 			break;
2349 		}
2350 	}
2351 
2352 	if (radeon_connector->hpd.hpd == RADEON_HPD_NONE) {
2353 		if (i2c_bus->valid) {
2354 			connector->polled = DRM_CONNECTOR_POLL_CONNECT |
2355 			                    DRM_CONNECTOR_POLL_DISCONNECT;
2356 		}
2357 	} else
2358 		connector->polled = DRM_CONNECTOR_POLL_HPD;
2359 
2360 	connector->display_info.subpixel_order = subpixel_order;
2361 	drm_connector_register(connector);
2362 
2363 	if (has_aux)
2364 		radeon_dp_aux_init(radeon_connector);
2365 
2366 	return;
2367 
2368 failed:
2369 	drm_connector_cleanup(connector);
2370 	kfree(connector);
2371 }
2372 
2373 void
2374 radeon_add_legacy_connector(struct drm_device *dev,
2375 			    uint32_t connector_id,
2376 			    uint32_t supported_device,
2377 			    int connector_type,
2378 			    struct radeon_i2c_bus_rec *i2c_bus,
2379 			    uint16_t connector_object_id,
2380 			    struct radeon_hpd *hpd)
2381 {
2382 	struct radeon_device *rdev = dev->dev_private;
2383 	struct drm_connector *connector;
2384 	struct radeon_connector *radeon_connector;
2385 	struct i2c_adapter *ddc = NULL;
2386 	uint32_t subpixel_order = SubPixelNone;
2387 
2388 	if (connector_type == DRM_MODE_CONNECTOR_Unknown)
2389 		return;
2390 
2391 	/* if the user selected tv=0 don't try and add the connector */
2392 	if (((connector_type == DRM_MODE_CONNECTOR_SVIDEO) ||
2393 	     (connector_type == DRM_MODE_CONNECTOR_Composite) ||
2394 	     (connector_type == DRM_MODE_CONNECTOR_9PinDIN)) &&
2395 	    (radeon_tv == 0))
2396 		return;
2397 
2398 	/* see if we already added it */
2399 	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
2400 		radeon_connector = to_radeon_connector(connector);
2401 		if (radeon_connector->connector_id == connector_id) {
2402 			radeon_connector->devices |= supported_device;
2403 			return;
2404 		}
2405 	}
2406 
2407 	radeon_connector = kzalloc(sizeof(struct radeon_connector), GFP_KERNEL);
2408 	if (!radeon_connector)
2409 		return;
2410 
2411 	connector = &radeon_connector->base;
2412 
2413 	radeon_connector->connector_id = connector_id;
2414 	radeon_connector->devices = supported_device;
2415 	radeon_connector->connector_object_id = connector_object_id;
2416 	radeon_connector->hpd = *hpd;
2417 
2418 	switch (connector_type) {
2419 	case DRM_MODE_CONNECTOR_VGA:
2420 		if (i2c_bus->valid) {
2421 			radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2422 			if (!radeon_connector->ddc_bus)
2423 				DRM_ERROR("VGA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2424 			else
2425 				ddc = &radeon_connector->ddc_bus->adapter;
2426 		}
2427 		drm_connector_init_with_ddc(dev, &radeon_connector->base,
2428 					    &radeon_vga_connector_funcs,
2429 					    connector_type,
2430 					    ddc);
2431 		drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
2432 		radeon_connector->dac_load_detect = true;
2433 		drm_object_attach_property(&radeon_connector->base.base,
2434 					      rdev->mode_info.load_detect_property,
2435 					      1);
2436 		/* no HPD on analog connectors */
2437 		radeon_connector->hpd.hpd = RADEON_HPD_NONE;
2438 		connector->interlace_allowed = true;
2439 		connector->doublescan_allowed = true;
2440 		break;
2441 	case DRM_MODE_CONNECTOR_DVIA:
2442 		if (i2c_bus->valid) {
2443 			radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2444 			if (!radeon_connector->ddc_bus)
2445 				DRM_ERROR("DVIA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2446 			else
2447 				ddc = &radeon_connector->ddc_bus->adapter;
2448 		}
2449 		drm_connector_init_with_ddc(dev, &radeon_connector->base,
2450 					    &radeon_vga_connector_funcs,
2451 					    connector_type,
2452 					    ddc);
2453 		drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
2454 		radeon_connector->dac_load_detect = true;
2455 		drm_object_attach_property(&radeon_connector->base.base,
2456 					      rdev->mode_info.load_detect_property,
2457 					      1);
2458 		/* no HPD on analog connectors */
2459 		radeon_connector->hpd.hpd = RADEON_HPD_NONE;
2460 		connector->interlace_allowed = true;
2461 		connector->doublescan_allowed = true;
2462 		break;
2463 	case DRM_MODE_CONNECTOR_DVII:
2464 	case DRM_MODE_CONNECTOR_DVID:
2465 		if (i2c_bus->valid) {
2466 			radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2467 			if (!radeon_connector->ddc_bus)
2468 				DRM_ERROR("DVI: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2469 			else
2470 				ddc = &radeon_connector->ddc_bus->adapter;
2471 		}
2472 		drm_connector_init_with_ddc(dev, &radeon_connector->base,
2473 					    &radeon_dvi_connector_funcs,
2474 					    connector_type,
2475 					    ddc);
2476 		drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
2477 		if (connector_type == DRM_MODE_CONNECTOR_DVII) {
2478 			radeon_connector->dac_load_detect = true;
2479 			drm_object_attach_property(&radeon_connector->base.base,
2480 						      rdev->mode_info.load_detect_property,
2481 						      1);
2482 		}
2483 		subpixel_order = SubPixelHorizontalRGB;
2484 		connector->interlace_allowed = true;
2485 		if (connector_type == DRM_MODE_CONNECTOR_DVII)
2486 			connector->doublescan_allowed = true;
2487 		else
2488 			connector->doublescan_allowed = false;
2489 		break;
2490 	case DRM_MODE_CONNECTOR_SVIDEO:
2491 	case DRM_MODE_CONNECTOR_Composite:
2492 	case DRM_MODE_CONNECTOR_9PinDIN:
2493 		drm_connector_init_with_ddc(dev, &radeon_connector->base,
2494 					    &radeon_tv_connector_funcs,
2495 					    connector_type,
2496 					    ddc);
2497 		drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
2498 		radeon_connector->dac_load_detect = true;
2499 		/* RS400,RC410,RS480 chipset seems to report a lot
2500 		 * of false positive on load detect, we haven't yet
2501 		 * found a way to make load detect reliable on those
2502 		 * chipset, thus just disable it for TV.
2503 		 */
2504 		if (rdev->family == CHIP_RS400 || rdev->family == CHIP_RS480)
2505 			radeon_connector->dac_load_detect = false;
2506 		drm_object_attach_property(&radeon_connector->base.base,
2507 					      rdev->mode_info.load_detect_property,
2508 					      radeon_connector->dac_load_detect);
2509 		drm_object_attach_property(&radeon_connector->base.base,
2510 					      rdev->mode_info.tv_std_property,
2511 					      radeon_combios_get_tv_info(rdev));
2512 		/* no HPD on analog connectors */
2513 		radeon_connector->hpd.hpd = RADEON_HPD_NONE;
2514 		connector->interlace_allowed = false;
2515 		connector->doublescan_allowed = false;
2516 		break;
2517 	case DRM_MODE_CONNECTOR_LVDS:
2518 		if (i2c_bus->valid) {
2519 			radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2520 			if (!radeon_connector->ddc_bus)
2521 				DRM_ERROR("LVDS: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2522 			else
2523 				ddc = &radeon_connector->ddc_bus->adapter;
2524 		}
2525 		drm_connector_init_with_ddc(dev, &radeon_connector->base,
2526 					    &radeon_lvds_connector_funcs,
2527 					    connector_type,
2528 					    ddc);
2529 		drm_connector_helper_add(&radeon_connector->base, &radeon_lvds_connector_helper_funcs);
2530 		drm_object_attach_property(&radeon_connector->base.base,
2531 					      dev->mode_config.scaling_mode_property,
2532 					      DRM_MODE_SCALE_FULLSCREEN);
2533 		subpixel_order = SubPixelHorizontalRGB;
2534 		connector->interlace_allowed = false;
2535 		connector->doublescan_allowed = false;
2536 		break;
2537 	}
2538 
2539 	if (radeon_connector->hpd.hpd == RADEON_HPD_NONE) {
2540 		if (i2c_bus->valid) {
2541 			connector->polled = DRM_CONNECTOR_POLL_CONNECT |
2542 			                    DRM_CONNECTOR_POLL_DISCONNECT;
2543 		}
2544 	} else
2545 		connector->polled = DRM_CONNECTOR_POLL_HPD;
2546 
2547 	connector->display_info.subpixel_order = subpixel_order;
2548 	drm_connector_register(connector);
2549 }
2550 
2551 void radeon_setup_mst_connector(struct drm_device *dev)
2552 {
2553 	struct radeon_device *rdev = dev->dev_private;
2554 	struct drm_connector *connector;
2555 	struct radeon_connector *radeon_connector;
2556 
2557 	if (!ASIC_IS_DCE5(rdev))
2558 		return;
2559 
2560 	if (radeon_mst == 0)
2561 		return;
2562 
2563 	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
2564 		int ret;
2565 
2566 		radeon_connector = to_radeon_connector(connector);
2567 
2568 		if (connector->connector_type != DRM_MODE_CONNECTOR_DisplayPort)
2569 			continue;
2570 
2571 		ret = radeon_dp_mst_init(radeon_connector);
2572 	}
2573 }
2574