xref: /linux/drivers/input/keyboard/cros_ec_keyb.c (revision e7a35f12)
1 /*
2  * ChromeOS EC keyboard driver
3  *
4  * Copyright (C) 2012 Google, Inc
5  *
6  * This software is licensed under the terms of the GNU General Public
7  * License version 2, as published by the Free Software Foundation, and
8  * may be copied, distributed, and modified under those terms.
9  *
10  * This program is distributed in the hope that it will be useful,
11  * but WITHOUT ANY WARRANTY; without even the implied warranty of
12  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
13  * GNU General Public License for more details.
14  *
15  * This driver uses the Chrome OS EC byte-level message-based protocol for
16  * communicating the keyboard state (which keys are pressed) from a keyboard EC
17  * to the AP over some bus (such as i2c, lpc, spi).  The EC does debouncing,
18  * but everything else (including deghosting) is done here.  The main
19  * motivation for this is to keep the EC firmware as simple as possible, since
20  * it cannot be easily upgraded and EC flash/IRAM space is relatively
21  * expensive.
22  */
23 
24 #include <linux/module.h>
25 #include <linux/bitops.h>
26 #include <linux/i2c.h>
27 #include <linux/input.h>
28 #include <linux/interrupt.h>
29 #include <linux/kernel.h>
30 #include <linux/notifier.h>
31 #include <linux/platform_device.h>
32 #include <linux/slab.h>
33 #include <linux/sysrq.h>
34 #include <linux/input/matrix_keypad.h>
35 #include <linux/mfd/cros_ec.h>
36 #include <linux/mfd/cros_ec_commands.h>
37 
38 #include <asm/unaligned.h>
39 
40 /*
41  * @rows: Number of rows in the keypad
42  * @cols: Number of columns in the keypad
43  * @row_shift: log2 or number of rows, rounded up
44  * @keymap_data: Matrix keymap data used to convert to keyscan values
45  * @ghost_filter: true to enable the matrix key-ghosting filter
46  * @valid_keys: bitmap of existing keys for each matrix column
47  * @old_kb_state: bitmap of keys pressed last scan
48  * @dev: Device pointer
49  * @ec: Top level ChromeOS device to use to talk to EC
50  * @idev: The input device for the matrix keys.
51  * @bs_idev: The input device for non-matrix buttons and switches (or NULL).
52  * @notifier: interrupt event notifier for transport devices
53  */
54 struct cros_ec_keyb {
55 	unsigned int rows;
56 	unsigned int cols;
57 	int row_shift;
58 	const struct matrix_keymap_data *keymap_data;
59 	bool ghost_filter;
60 	uint8_t *valid_keys;
61 	uint8_t *old_kb_state;
62 
63 	struct device *dev;
64 	struct cros_ec_device *ec;
65 
66 	struct input_dev *idev;
67 	struct input_dev *bs_idev;
68 	struct notifier_block notifier;
69 };
70 
71 
72 /**
73  * cros_ec_bs_map - Struct mapping Linux keycodes to EC button/switch bitmap
74  * #defines
75  *
76  * @ev_type: The type of the input event to generate (e.g., EV_KEY).
77  * @code: A linux keycode
78  * @bit: A #define like EC_MKBP_POWER_BUTTON or EC_MKBP_LID_OPEN
79  * @inverted: If the #define and EV_SW have opposite meanings, this is true.
80  *            Only applicable to switches.
81  */
82 struct cros_ec_bs_map {
83 	unsigned int ev_type;
84 	unsigned int code;
85 	u8 bit;
86 	bool inverted;
87 };
88 
89 /* cros_ec_keyb_bs - Map EC button/switch #defines into kernel ones */
90 static const struct cros_ec_bs_map cros_ec_keyb_bs[] = {
91 	/* Buttons */
92 	{
93 		.ev_type	= EV_KEY,
94 		.code		= KEY_POWER,
95 		.bit		= EC_MKBP_POWER_BUTTON,
96 	},
97 	{
98 		.ev_type	= EV_KEY,
99 		.code		= KEY_VOLUMEUP,
100 		.bit		= EC_MKBP_VOL_UP,
101 	},
102 	{
103 		.ev_type	= EV_KEY,
104 		.code		= KEY_VOLUMEDOWN,
105 		.bit		= EC_MKBP_VOL_DOWN,
106 	},
107 
108 	/* Switches */
109 	{
110 		.ev_type	= EV_SW,
111 		.code		= SW_LID,
112 		.bit		= EC_MKBP_LID_OPEN,
113 		.inverted	= true,
114 	},
115 	{
116 		.ev_type	= EV_SW,
117 		.code		= SW_TABLET_MODE,
118 		.bit		= EC_MKBP_TABLET_MODE,
119 	},
120 };
121 
122 /*
123  * Returns true when there is at least one combination of pressed keys that
124  * results in ghosting.
125  */
126 static bool cros_ec_keyb_has_ghosting(struct cros_ec_keyb *ckdev, uint8_t *buf)
127 {
128 	int col1, col2, buf1, buf2;
129 	struct device *dev = ckdev->dev;
130 	uint8_t *valid_keys = ckdev->valid_keys;
131 
132 	/*
133 	 * Ghosting happens if for any pressed key X there are other keys
134 	 * pressed both in the same row and column of X as, for instance,
135 	 * in the following diagram:
136 	 *
137 	 * . . Y . g .
138 	 * . . . . . .
139 	 * . . . . . .
140 	 * . . X . Z .
141 	 *
142 	 * In this case only X, Y, and Z are pressed, but g appears to be
143 	 * pressed too (see Wikipedia).
144 	 */
145 	for (col1 = 0; col1 < ckdev->cols; col1++) {
146 		buf1 = buf[col1] & valid_keys[col1];
147 		for (col2 = col1 + 1; col2 < ckdev->cols; col2++) {
148 			buf2 = buf[col2] & valid_keys[col2];
149 			if (hweight8(buf1 & buf2) > 1) {
150 				dev_dbg(dev, "ghost found at: B[%02d]:0x%02x & B[%02d]:0x%02x",
151 					col1, buf1, col2, buf2);
152 				return true;
153 			}
154 		}
155 	}
156 
157 	return false;
158 }
159 
160 
161 /*
162  * Compares the new keyboard state to the old one and produces key
163  * press/release events accordingly.  The keyboard state is 13 bytes (one byte
164  * per column)
165  */
166 static void cros_ec_keyb_process(struct cros_ec_keyb *ckdev,
167 			 uint8_t *kb_state, int len)
168 {
169 	struct input_dev *idev = ckdev->idev;
170 	int col, row;
171 	int new_state;
172 	int old_state;
173 	int num_cols;
174 
175 	num_cols = len;
176 
177 	if (ckdev->ghost_filter && cros_ec_keyb_has_ghosting(ckdev, kb_state)) {
178 		/*
179 		 * Simple-minded solution: ignore this state. The obvious
180 		 * improvement is to only ignore changes to keys involved in
181 		 * the ghosting, but process the other changes.
182 		 */
183 		dev_dbg(ckdev->dev, "ghosting found\n");
184 		return;
185 	}
186 
187 	for (col = 0; col < ckdev->cols; col++) {
188 		for (row = 0; row < ckdev->rows; row++) {
189 			int pos = MATRIX_SCAN_CODE(row, col, ckdev->row_shift);
190 			const unsigned short *keycodes = idev->keycode;
191 
192 			new_state = kb_state[col] & (1 << row);
193 			old_state = ckdev->old_kb_state[col] & (1 << row);
194 			if (new_state != old_state) {
195 				dev_dbg(ckdev->dev,
196 					"changed: [r%d c%d]: byte %02x\n",
197 					row, col, new_state);
198 
199 				input_report_key(idev, keycodes[pos],
200 						 new_state);
201 			}
202 		}
203 		ckdev->old_kb_state[col] = kb_state[col];
204 	}
205 	input_sync(ckdev->idev);
206 }
207 
208 /**
209  * cros_ec_keyb_report_bs - Report non-matrixed buttons or switches
210  *
211  * This takes a bitmap of buttons or switches from the EC and reports events,
212  * syncing at the end.
213  *
214  * @ckdev: The keyboard device.
215  * @ev_type: The input event type (e.g., EV_KEY).
216  * @mask: A bitmap of buttons from the EC.
217  */
218 static void cros_ec_keyb_report_bs(struct cros_ec_keyb *ckdev,
219 				   unsigned int ev_type, u32 mask)
220 
221 {
222 	struct input_dev *idev = ckdev->bs_idev;
223 	int i;
224 
225 	for (i = 0; i < ARRAY_SIZE(cros_ec_keyb_bs); i++) {
226 		const struct cros_ec_bs_map *map = &cros_ec_keyb_bs[i];
227 
228 		if (map->ev_type != ev_type)
229 			continue;
230 
231 		input_event(idev, ev_type, map->code,
232 			    !!(mask & BIT(map->bit)) ^ map->inverted);
233 	}
234 	input_sync(idev);
235 }
236 
237 static int cros_ec_keyb_work(struct notifier_block *nb,
238 			     unsigned long queued_during_suspend, void *_notify)
239 {
240 	struct cros_ec_keyb *ckdev = container_of(nb, struct cros_ec_keyb,
241 						  notifier);
242 	u32 val;
243 	unsigned int ev_type;
244 
245 	switch (ckdev->ec->event_data.event_type) {
246 	case EC_MKBP_EVENT_KEY_MATRIX:
247 		if (device_may_wakeup(ckdev->dev)) {
248 			pm_wakeup_event(ckdev->dev, 0);
249 		} else {
250 			/*
251 			 * If keyboard is not wake enabled, discard key state
252 			 * changes during suspend. Switches will be re-checked
253 			 * in cros_ec_keyb_resume() to be sure nothing is lost.
254 			 */
255 			if (queued_during_suspend)
256 				return NOTIFY_OK;
257 		}
258 
259 		if (ckdev->ec->event_size != ckdev->cols) {
260 			dev_err(ckdev->dev,
261 				"Discarded incomplete key matrix event.\n");
262 			return NOTIFY_OK;
263 		}
264 
265 		cros_ec_keyb_process(ckdev,
266 				     ckdev->ec->event_data.data.key_matrix,
267 				     ckdev->ec->event_size);
268 		break;
269 
270 	case EC_MKBP_EVENT_SYSRQ:
271 		if (device_may_wakeup(ckdev->dev))
272 			pm_wakeup_event(ckdev->dev, 0);
273 		else if (queued_during_suspend)
274 			return NOTIFY_OK;
275 
276 		val = get_unaligned_le32(&ckdev->ec->event_data.data.sysrq);
277 		dev_dbg(ckdev->dev, "sysrq code from EC: %#x\n", val);
278 		handle_sysrq(val);
279 		break;
280 
281 	case EC_MKBP_EVENT_BUTTON:
282 	case EC_MKBP_EVENT_SWITCH:
283 		if (device_may_wakeup(ckdev->dev))
284 			pm_wakeup_event(ckdev->dev, 0);
285 		else if (queued_during_suspend)
286 			return NOTIFY_OK;
287 
288 		if (ckdev->ec->event_data.event_type == EC_MKBP_EVENT_BUTTON) {
289 			val = get_unaligned_le32(
290 					&ckdev->ec->event_data.data.buttons);
291 			ev_type = EV_KEY;
292 		} else {
293 			val = get_unaligned_le32(
294 					&ckdev->ec->event_data.data.switches);
295 			ev_type = EV_SW;
296 		}
297 		cros_ec_keyb_report_bs(ckdev, ev_type, val);
298 		break;
299 
300 	default:
301 		return NOTIFY_DONE;
302 	}
303 
304 	return NOTIFY_OK;
305 }
306 
307 /*
308  * Walks keycodes flipping bit in buffer COLUMNS deep where bit is ROW.  Used by
309  * ghosting logic to ignore NULL or virtual keys.
310  */
311 static void cros_ec_keyb_compute_valid_keys(struct cros_ec_keyb *ckdev)
312 {
313 	int row, col;
314 	int row_shift = ckdev->row_shift;
315 	unsigned short *keymap = ckdev->idev->keycode;
316 	unsigned short code;
317 
318 	BUG_ON(ckdev->idev->keycodesize != sizeof(*keymap));
319 
320 	for (col = 0; col < ckdev->cols; col++) {
321 		for (row = 0; row < ckdev->rows; row++) {
322 			code = keymap[MATRIX_SCAN_CODE(row, col, row_shift)];
323 			if (code && (code != KEY_BATTERY))
324 				ckdev->valid_keys[col] |= 1 << row;
325 		}
326 		dev_dbg(ckdev->dev, "valid_keys[%02d] = 0x%02x\n",
327 			col, ckdev->valid_keys[col]);
328 	}
329 }
330 
331 /**
332  * cros_ec_keyb_info - Wrap the EC command EC_CMD_MKBP_INFO
333  *
334  * This wraps the EC_CMD_MKBP_INFO, abstracting out all of the marshalling and
335  * unmarshalling and different version nonsense into something simple.
336  *
337  * @ec_dev: The EC device
338  * @info_type: Either EC_MKBP_INFO_SUPPORTED or EC_MKBP_INFO_CURRENT.
339  * @event_type: Either EC_MKBP_EVENT_BUTTON or EC_MKBP_EVENT_SWITCH.  Actually
340  *              in some cases this could be EC_MKBP_EVENT_KEY_MATRIX or
341  *              EC_MKBP_EVENT_HOST_EVENT too but we don't use in this driver.
342  * @result: Where we'll store the result; a union
343  * @result_size: The size of the result.  Expected to be the size of one of
344  *               the elements in the union.
345  *
346  * Returns 0 if no error or -error upon error.
347  */
348 static int cros_ec_keyb_info(struct cros_ec_device *ec_dev,
349 			     enum ec_mkbp_info_type info_type,
350 			     enum ec_mkbp_event event_type,
351 			     union ec_response_get_next_data *result,
352 			     size_t result_size)
353 {
354 	struct ec_params_mkbp_info *params;
355 	struct cros_ec_command *msg;
356 	int ret;
357 
358 	msg = kzalloc(sizeof(*msg) + max_t(size_t, result_size,
359 					   sizeof(*params)), GFP_KERNEL);
360 	if (!msg)
361 		return -ENOMEM;
362 
363 	msg->command = EC_CMD_MKBP_INFO;
364 	msg->version = 1;
365 	msg->outsize = sizeof(*params);
366 	msg->insize = result_size;
367 	params = (struct ec_params_mkbp_info *)msg->data;
368 	params->info_type = info_type;
369 	params->event_type = event_type;
370 
371 	ret = cros_ec_cmd_xfer(ec_dev, msg);
372 	if (ret < 0) {
373 		dev_warn(ec_dev->dev, "Transfer error %d/%d: %d\n",
374 			 (int)info_type, (int)event_type, ret);
375 	} else if (msg->result == EC_RES_INVALID_VERSION) {
376 		/* With older ECs we just return 0 for everything */
377 		memset(result, 0, result_size);
378 		ret = 0;
379 	} else if (msg->result != EC_RES_SUCCESS) {
380 		dev_warn(ec_dev->dev, "Error getting info %d/%d: %d\n",
381 			 (int)info_type, (int)event_type, msg->result);
382 		ret = -EPROTO;
383 	} else if (ret != result_size) {
384 		dev_warn(ec_dev->dev, "Wrong size %d/%d: %d != %zu\n",
385 			 (int)info_type, (int)event_type,
386 			 ret, result_size);
387 		ret = -EPROTO;
388 	} else {
389 		memcpy(result, msg->data, result_size);
390 		ret = 0;
391 	}
392 
393 	kfree(msg);
394 
395 	return ret;
396 }
397 
398 /**
399  * cros_ec_keyb_query_switches - Query the state of switches and report
400  *
401  * This will ask the EC about the current state of switches and report to the
402  * kernel.  Note that we don't query for buttons because they are more
403  * transitory and we'll get an update on the next release / press.
404  *
405  * @ckdev: The keyboard device
406  *
407  * Returns 0 if no error or -error upon error.
408  */
409 static int cros_ec_keyb_query_switches(struct cros_ec_keyb *ckdev)
410 {
411 	struct cros_ec_device *ec_dev = ckdev->ec;
412 	union ec_response_get_next_data event_data = {};
413 	int ret;
414 
415 	ret = cros_ec_keyb_info(ec_dev, EC_MKBP_INFO_CURRENT,
416 				EC_MKBP_EVENT_SWITCH, &event_data,
417 				sizeof(event_data.switches));
418 	if (ret)
419 		return ret;
420 
421 	cros_ec_keyb_report_bs(ckdev, EV_SW,
422 			       get_unaligned_le32(&event_data.switches));
423 
424 	return 0;
425 }
426 
427 /**
428  * cros_ec_keyb_resume - Resume the keyboard
429  *
430  * We use the resume notification as a chance to query the EC for switches.
431  *
432  * @dev: The keyboard device
433  *
434  * Returns 0 if no error or -error upon error.
435  */
436 static __maybe_unused int cros_ec_keyb_resume(struct device *dev)
437 {
438 	struct cros_ec_keyb *ckdev = dev_get_drvdata(dev);
439 
440 	if (ckdev->bs_idev)
441 		return cros_ec_keyb_query_switches(ckdev);
442 
443 	return 0;
444 }
445 
446 /**
447  * cros_ec_keyb_register_bs - Register non-matrix buttons/switches
448  *
449  * Handles all the bits of the keyboard driver related to non-matrix buttons
450  * and switches, including asking the EC about which are present and telling
451  * the kernel to expect them.
452  *
453  * If this device has no support for buttons and switches we'll return no error
454  * but the ckdev->bs_idev will remain NULL when this function exits.
455  *
456  * @ckdev: The keyboard device
457  *
458  * Returns 0 if no error or -error upon error.
459  */
460 static int cros_ec_keyb_register_bs(struct cros_ec_keyb *ckdev)
461 {
462 	struct cros_ec_device *ec_dev = ckdev->ec;
463 	struct device *dev = ckdev->dev;
464 	struct input_dev *idev;
465 	union ec_response_get_next_data event_data = {};
466 	const char *phys;
467 	u32 buttons;
468 	u32 switches;
469 	int ret;
470 	int i;
471 
472 	ret = cros_ec_keyb_info(ec_dev, EC_MKBP_INFO_SUPPORTED,
473 				EC_MKBP_EVENT_BUTTON, &event_data,
474 				sizeof(event_data.buttons));
475 	if (ret)
476 		return ret;
477 	buttons = get_unaligned_le32(&event_data.buttons);
478 
479 	ret = cros_ec_keyb_info(ec_dev, EC_MKBP_INFO_SUPPORTED,
480 				EC_MKBP_EVENT_SWITCH, &event_data,
481 				sizeof(event_data.switches));
482 	if (ret)
483 		return ret;
484 	switches = get_unaligned_le32(&event_data.switches);
485 
486 	if (!buttons && !switches)
487 		return 0;
488 
489 	/*
490 	 * We call the non-matrix buttons/switches 'input1', if present.
491 	 * Allocate phys before input dev, to ensure correct tear-down
492 	 * ordering.
493 	 */
494 	phys = devm_kasprintf(dev, GFP_KERNEL, "%s/input1", ec_dev->phys_name);
495 	if (!phys)
496 		return -ENOMEM;
497 
498 	idev = devm_input_allocate_device(dev);
499 	if (!idev)
500 		return -ENOMEM;
501 
502 	idev->name = "cros_ec_buttons";
503 	idev->phys = phys;
504 	__set_bit(EV_REP, idev->evbit);
505 
506 	idev->id.bustype = BUS_VIRTUAL;
507 	idev->id.version = 1;
508 	idev->id.product = 0;
509 	idev->dev.parent = dev;
510 
511 	input_set_drvdata(idev, ckdev);
512 	ckdev->bs_idev = idev;
513 
514 	for (i = 0; i < ARRAY_SIZE(cros_ec_keyb_bs); i++) {
515 		const struct cros_ec_bs_map *map = &cros_ec_keyb_bs[i];
516 
517 		if (buttons & BIT(map->bit))
518 			input_set_capability(idev, map->ev_type, map->code);
519 	}
520 
521 	ret = cros_ec_keyb_query_switches(ckdev);
522 	if (ret) {
523 		dev_err(dev, "cannot query switches\n");
524 		return ret;
525 	}
526 
527 	ret = input_register_device(ckdev->bs_idev);
528 	if (ret) {
529 		dev_err(dev, "cannot register input device\n");
530 		return ret;
531 	}
532 
533 	return 0;
534 }
535 
536 /**
537  * cros_ec_keyb_register_bs - Register matrix keys
538  *
539  * Handles all the bits of the keyboard driver related to matrix keys.
540  *
541  * @ckdev: The keyboard device
542  *
543  * Returns 0 if no error or -error upon error.
544  */
545 static int cros_ec_keyb_register_matrix(struct cros_ec_keyb *ckdev)
546 {
547 	struct cros_ec_device *ec_dev = ckdev->ec;
548 	struct device *dev = ckdev->dev;
549 	struct input_dev *idev;
550 	const char *phys;
551 	int err;
552 
553 	err = matrix_keypad_parse_properties(dev, &ckdev->rows, &ckdev->cols);
554 	if (err)
555 		return err;
556 
557 	ckdev->valid_keys = devm_kzalloc(dev, ckdev->cols, GFP_KERNEL);
558 	if (!ckdev->valid_keys)
559 		return -ENOMEM;
560 
561 	ckdev->old_kb_state = devm_kzalloc(dev, ckdev->cols, GFP_KERNEL);
562 	if (!ckdev->old_kb_state)
563 		return -ENOMEM;
564 
565 	/*
566 	 * We call the keyboard matrix 'input0'. Allocate phys before input
567 	 * dev, to ensure correct tear-down ordering.
568 	 */
569 	phys = devm_kasprintf(dev, GFP_KERNEL, "%s/input0", ec_dev->phys_name);
570 	if (!phys)
571 		return -ENOMEM;
572 
573 	idev = devm_input_allocate_device(dev);
574 	if (!idev)
575 		return -ENOMEM;
576 
577 	idev->name = CROS_EC_DEV_NAME;
578 	idev->phys = phys;
579 	__set_bit(EV_REP, idev->evbit);
580 
581 	idev->id.bustype = BUS_VIRTUAL;
582 	idev->id.version = 1;
583 	idev->id.product = 0;
584 	idev->dev.parent = dev;
585 
586 	ckdev->ghost_filter = of_property_read_bool(dev->of_node,
587 					"google,needs-ghost-filter");
588 
589 	err = matrix_keypad_build_keymap(NULL, NULL, ckdev->rows, ckdev->cols,
590 					 NULL, idev);
591 	if (err) {
592 		dev_err(dev, "cannot build key matrix\n");
593 		return err;
594 	}
595 
596 	ckdev->row_shift = get_count_order(ckdev->cols);
597 
598 	input_set_capability(idev, EV_MSC, MSC_SCAN);
599 	input_set_drvdata(idev, ckdev);
600 	ckdev->idev = idev;
601 	cros_ec_keyb_compute_valid_keys(ckdev);
602 
603 	err = input_register_device(ckdev->idev);
604 	if (err) {
605 		dev_err(dev, "cannot register input device\n");
606 		return err;
607 	}
608 
609 	return 0;
610 }
611 
612 static int cros_ec_keyb_probe(struct platform_device *pdev)
613 {
614 	struct cros_ec_device *ec = dev_get_drvdata(pdev->dev.parent);
615 	struct device *dev = &pdev->dev;
616 	struct cros_ec_keyb *ckdev;
617 	int err;
618 
619 	if (!dev->of_node)
620 		return -ENODEV;
621 
622 	ckdev = devm_kzalloc(dev, sizeof(*ckdev), GFP_KERNEL);
623 	if (!ckdev)
624 		return -ENOMEM;
625 
626 	ckdev->ec = ec;
627 	ckdev->dev = dev;
628 	dev_set_drvdata(dev, ckdev);
629 
630 	err = cros_ec_keyb_register_matrix(ckdev);
631 	if (err) {
632 		dev_err(dev, "cannot register matrix inputs: %d\n", err);
633 		return err;
634 	}
635 
636 	err = cros_ec_keyb_register_bs(ckdev);
637 	if (err) {
638 		dev_err(dev, "cannot register non-matrix inputs: %d\n", err);
639 		return err;
640 	}
641 
642 	ckdev->notifier.notifier_call = cros_ec_keyb_work;
643 	err = blocking_notifier_chain_register(&ckdev->ec->event_notifier,
644 					       &ckdev->notifier);
645 	if (err) {
646 		dev_err(dev, "cannot register notifier: %d\n", err);
647 		return err;
648 	}
649 
650 	device_init_wakeup(ckdev->dev, true);
651 	return 0;
652 }
653 
654 static int cros_ec_keyb_remove(struct platform_device *pdev)
655 {
656 	struct cros_ec_keyb *ckdev = dev_get_drvdata(&pdev->dev);
657 
658 	blocking_notifier_chain_unregister(&ckdev->ec->event_notifier,
659 					   &ckdev->notifier);
660 
661 	return 0;
662 }
663 
664 #ifdef CONFIG_OF
665 static const struct of_device_id cros_ec_keyb_of_match[] = {
666 	{ .compatible = "google,cros-ec-keyb" },
667 	{},
668 };
669 MODULE_DEVICE_TABLE(of, cros_ec_keyb_of_match);
670 #endif
671 
672 static SIMPLE_DEV_PM_OPS(cros_ec_keyb_pm_ops, NULL, cros_ec_keyb_resume);
673 
674 static struct platform_driver cros_ec_keyb_driver = {
675 	.probe = cros_ec_keyb_probe,
676 	.remove = cros_ec_keyb_remove,
677 	.driver = {
678 		.name = "cros-ec-keyb",
679 		.of_match_table = of_match_ptr(cros_ec_keyb_of_match),
680 		.pm = &cros_ec_keyb_pm_ops,
681 	},
682 };
683 
684 module_platform_driver(cros_ec_keyb_driver);
685 
686 MODULE_LICENSE("GPL v2");
687 MODULE_DESCRIPTION("ChromeOS EC keyboard driver");
688 MODULE_ALIAS("platform:cros-ec-keyb");
689