xref: /linux/drivers/net/dsa/b53/b53_common.c (revision 1e525507)
1 /*
2  * B53 switch driver main logic
3  *
4  * Copyright (C) 2011-2013 Jonas Gorski <jogo@openwrt.org>
5  * Copyright (C) 2016 Florian Fainelli <f.fainelli@gmail.com>
6  *
7  * Permission to use, copy, modify, and/or distribute this software for any
8  * purpose with or without fee is hereby granted, provided that the above
9  * copyright notice and this permission notice appear in all copies.
10  *
11  * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
12  * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
13  * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
14  * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
15  * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
16  * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
17  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
18  */
19 
20 #include <linux/delay.h>
21 #include <linux/export.h>
22 #include <linux/gpio.h>
23 #include <linux/kernel.h>
24 #include <linux/module.h>
25 #include <linux/platform_data/b53.h>
26 #include <linux/phy.h>
27 #include <linux/phylink.h>
28 #include <linux/etherdevice.h>
29 #include <linux/if_bridge.h>
30 #include <net/dsa.h>
31 
32 #include "b53_regs.h"
33 #include "b53_priv.h"
34 
35 struct b53_mib_desc {
36 	u8 size;
37 	u8 offset;
38 	const char *name;
39 };
40 
41 /* BCM5365 MIB counters */
42 static const struct b53_mib_desc b53_mibs_65[] = {
43 	{ 8, 0x00, "TxOctets" },
44 	{ 4, 0x08, "TxDropPkts" },
45 	{ 4, 0x10, "TxBroadcastPkts" },
46 	{ 4, 0x14, "TxMulticastPkts" },
47 	{ 4, 0x18, "TxUnicastPkts" },
48 	{ 4, 0x1c, "TxCollisions" },
49 	{ 4, 0x20, "TxSingleCollision" },
50 	{ 4, 0x24, "TxMultipleCollision" },
51 	{ 4, 0x28, "TxDeferredTransmit" },
52 	{ 4, 0x2c, "TxLateCollision" },
53 	{ 4, 0x30, "TxExcessiveCollision" },
54 	{ 4, 0x38, "TxPausePkts" },
55 	{ 8, 0x44, "RxOctets" },
56 	{ 4, 0x4c, "RxUndersizePkts" },
57 	{ 4, 0x50, "RxPausePkts" },
58 	{ 4, 0x54, "Pkts64Octets" },
59 	{ 4, 0x58, "Pkts65to127Octets" },
60 	{ 4, 0x5c, "Pkts128to255Octets" },
61 	{ 4, 0x60, "Pkts256to511Octets" },
62 	{ 4, 0x64, "Pkts512to1023Octets" },
63 	{ 4, 0x68, "Pkts1024to1522Octets" },
64 	{ 4, 0x6c, "RxOversizePkts" },
65 	{ 4, 0x70, "RxJabbers" },
66 	{ 4, 0x74, "RxAlignmentErrors" },
67 	{ 4, 0x78, "RxFCSErrors" },
68 	{ 8, 0x7c, "RxGoodOctets" },
69 	{ 4, 0x84, "RxDropPkts" },
70 	{ 4, 0x88, "RxUnicastPkts" },
71 	{ 4, 0x8c, "RxMulticastPkts" },
72 	{ 4, 0x90, "RxBroadcastPkts" },
73 	{ 4, 0x94, "RxSAChanges" },
74 	{ 4, 0x98, "RxFragments" },
75 };
76 
77 #define B53_MIBS_65_SIZE	ARRAY_SIZE(b53_mibs_65)
78 
79 /* BCM63xx MIB counters */
80 static const struct b53_mib_desc b53_mibs_63xx[] = {
81 	{ 8, 0x00, "TxOctets" },
82 	{ 4, 0x08, "TxDropPkts" },
83 	{ 4, 0x0c, "TxQoSPkts" },
84 	{ 4, 0x10, "TxBroadcastPkts" },
85 	{ 4, 0x14, "TxMulticastPkts" },
86 	{ 4, 0x18, "TxUnicastPkts" },
87 	{ 4, 0x1c, "TxCollisions" },
88 	{ 4, 0x20, "TxSingleCollision" },
89 	{ 4, 0x24, "TxMultipleCollision" },
90 	{ 4, 0x28, "TxDeferredTransmit" },
91 	{ 4, 0x2c, "TxLateCollision" },
92 	{ 4, 0x30, "TxExcessiveCollision" },
93 	{ 4, 0x38, "TxPausePkts" },
94 	{ 8, 0x3c, "TxQoSOctets" },
95 	{ 8, 0x44, "RxOctets" },
96 	{ 4, 0x4c, "RxUndersizePkts" },
97 	{ 4, 0x50, "RxPausePkts" },
98 	{ 4, 0x54, "Pkts64Octets" },
99 	{ 4, 0x58, "Pkts65to127Octets" },
100 	{ 4, 0x5c, "Pkts128to255Octets" },
101 	{ 4, 0x60, "Pkts256to511Octets" },
102 	{ 4, 0x64, "Pkts512to1023Octets" },
103 	{ 4, 0x68, "Pkts1024to1522Octets" },
104 	{ 4, 0x6c, "RxOversizePkts" },
105 	{ 4, 0x70, "RxJabbers" },
106 	{ 4, 0x74, "RxAlignmentErrors" },
107 	{ 4, 0x78, "RxFCSErrors" },
108 	{ 8, 0x7c, "RxGoodOctets" },
109 	{ 4, 0x84, "RxDropPkts" },
110 	{ 4, 0x88, "RxUnicastPkts" },
111 	{ 4, 0x8c, "RxMulticastPkts" },
112 	{ 4, 0x90, "RxBroadcastPkts" },
113 	{ 4, 0x94, "RxSAChanges" },
114 	{ 4, 0x98, "RxFragments" },
115 	{ 4, 0xa0, "RxSymbolErrors" },
116 	{ 4, 0xa4, "RxQoSPkts" },
117 	{ 8, 0xa8, "RxQoSOctets" },
118 	{ 4, 0xb0, "Pkts1523to2047Octets" },
119 	{ 4, 0xb4, "Pkts2048to4095Octets" },
120 	{ 4, 0xb8, "Pkts4096to8191Octets" },
121 	{ 4, 0xbc, "Pkts8192to9728Octets" },
122 	{ 4, 0xc0, "RxDiscarded" },
123 };
124 
125 #define B53_MIBS_63XX_SIZE	ARRAY_SIZE(b53_mibs_63xx)
126 
127 /* MIB counters */
128 static const struct b53_mib_desc b53_mibs[] = {
129 	{ 8, 0x00, "TxOctets" },
130 	{ 4, 0x08, "TxDropPkts" },
131 	{ 4, 0x10, "TxBroadcastPkts" },
132 	{ 4, 0x14, "TxMulticastPkts" },
133 	{ 4, 0x18, "TxUnicastPkts" },
134 	{ 4, 0x1c, "TxCollisions" },
135 	{ 4, 0x20, "TxSingleCollision" },
136 	{ 4, 0x24, "TxMultipleCollision" },
137 	{ 4, 0x28, "TxDeferredTransmit" },
138 	{ 4, 0x2c, "TxLateCollision" },
139 	{ 4, 0x30, "TxExcessiveCollision" },
140 	{ 4, 0x38, "TxPausePkts" },
141 	{ 8, 0x50, "RxOctets" },
142 	{ 4, 0x58, "RxUndersizePkts" },
143 	{ 4, 0x5c, "RxPausePkts" },
144 	{ 4, 0x60, "Pkts64Octets" },
145 	{ 4, 0x64, "Pkts65to127Octets" },
146 	{ 4, 0x68, "Pkts128to255Octets" },
147 	{ 4, 0x6c, "Pkts256to511Octets" },
148 	{ 4, 0x70, "Pkts512to1023Octets" },
149 	{ 4, 0x74, "Pkts1024to1522Octets" },
150 	{ 4, 0x78, "RxOversizePkts" },
151 	{ 4, 0x7c, "RxJabbers" },
152 	{ 4, 0x80, "RxAlignmentErrors" },
153 	{ 4, 0x84, "RxFCSErrors" },
154 	{ 8, 0x88, "RxGoodOctets" },
155 	{ 4, 0x90, "RxDropPkts" },
156 	{ 4, 0x94, "RxUnicastPkts" },
157 	{ 4, 0x98, "RxMulticastPkts" },
158 	{ 4, 0x9c, "RxBroadcastPkts" },
159 	{ 4, 0xa0, "RxSAChanges" },
160 	{ 4, 0xa4, "RxFragments" },
161 	{ 4, 0xa8, "RxJumboPkts" },
162 	{ 4, 0xac, "RxSymbolErrors" },
163 	{ 4, 0xc0, "RxDiscarded" },
164 };
165 
166 #define B53_MIBS_SIZE	ARRAY_SIZE(b53_mibs)
167 
168 static const struct b53_mib_desc b53_mibs_58xx[] = {
169 	{ 8, 0x00, "TxOctets" },
170 	{ 4, 0x08, "TxDropPkts" },
171 	{ 4, 0x0c, "TxQPKTQ0" },
172 	{ 4, 0x10, "TxBroadcastPkts" },
173 	{ 4, 0x14, "TxMulticastPkts" },
174 	{ 4, 0x18, "TxUnicastPKts" },
175 	{ 4, 0x1c, "TxCollisions" },
176 	{ 4, 0x20, "TxSingleCollision" },
177 	{ 4, 0x24, "TxMultipleCollision" },
178 	{ 4, 0x28, "TxDeferredCollision" },
179 	{ 4, 0x2c, "TxLateCollision" },
180 	{ 4, 0x30, "TxExcessiveCollision" },
181 	{ 4, 0x34, "TxFrameInDisc" },
182 	{ 4, 0x38, "TxPausePkts" },
183 	{ 4, 0x3c, "TxQPKTQ1" },
184 	{ 4, 0x40, "TxQPKTQ2" },
185 	{ 4, 0x44, "TxQPKTQ3" },
186 	{ 4, 0x48, "TxQPKTQ4" },
187 	{ 4, 0x4c, "TxQPKTQ5" },
188 	{ 8, 0x50, "RxOctets" },
189 	{ 4, 0x58, "RxUndersizePkts" },
190 	{ 4, 0x5c, "RxPausePkts" },
191 	{ 4, 0x60, "RxPkts64Octets" },
192 	{ 4, 0x64, "RxPkts65to127Octets" },
193 	{ 4, 0x68, "RxPkts128to255Octets" },
194 	{ 4, 0x6c, "RxPkts256to511Octets" },
195 	{ 4, 0x70, "RxPkts512to1023Octets" },
196 	{ 4, 0x74, "RxPkts1024toMaxPktsOctets" },
197 	{ 4, 0x78, "RxOversizePkts" },
198 	{ 4, 0x7c, "RxJabbers" },
199 	{ 4, 0x80, "RxAlignmentErrors" },
200 	{ 4, 0x84, "RxFCSErrors" },
201 	{ 8, 0x88, "RxGoodOctets" },
202 	{ 4, 0x90, "RxDropPkts" },
203 	{ 4, 0x94, "RxUnicastPkts" },
204 	{ 4, 0x98, "RxMulticastPkts" },
205 	{ 4, 0x9c, "RxBroadcastPkts" },
206 	{ 4, 0xa0, "RxSAChanges" },
207 	{ 4, 0xa4, "RxFragments" },
208 	{ 4, 0xa8, "RxJumboPkt" },
209 	{ 4, 0xac, "RxSymblErr" },
210 	{ 4, 0xb0, "InRangeErrCount" },
211 	{ 4, 0xb4, "OutRangeErrCount" },
212 	{ 4, 0xb8, "EEELpiEvent" },
213 	{ 4, 0xbc, "EEELpiDuration" },
214 	{ 4, 0xc0, "RxDiscard" },
215 	{ 4, 0xc8, "TxQPKTQ6" },
216 	{ 4, 0xcc, "TxQPKTQ7" },
217 	{ 4, 0xd0, "TxPkts64Octets" },
218 	{ 4, 0xd4, "TxPkts65to127Octets" },
219 	{ 4, 0xd8, "TxPkts128to255Octets" },
220 	{ 4, 0xdc, "TxPkts256to511Ocets" },
221 	{ 4, 0xe0, "TxPkts512to1023Ocets" },
222 	{ 4, 0xe4, "TxPkts1024toMaxPktOcets" },
223 };
224 
225 #define B53_MIBS_58XX_SIZE	ARRAY_SIZE(b53_mibs_58xx)
226 
227 static int b53_do_vlan_op(struct b53_device *dev, u8 op)
228 {
229 	unsigned int i;
230 
231 	b53_write8(dev, B53_ARLIO_PAGE, dev->vta_regs[0], VTA_START_CMD | op);
232 
233 	for (i = 0; i < 10; i++) {
234 		u8 vta;
235 
236 		b53_read8(dev, B53_ARLIO_PAGE, dev->vta_regs[0], &vta);
237 		if (!(vta & VTA_START_CMD))
238 			return 0;
239 
240 		usleep_range(100, 200);
241 	}
242 
243 	return -EIO;
244 }
245 
246 static void b53_set_vlan_entry(struct b53_device *dev, u16 vid,
247 			       struct b53_vlan *vlan)
248 {
249 	if (is5325(dev)) {
250 		u32 entry = 0;
251 
252 		if (vlan->members) {
253 			entry = ((vlan->untag & VA_UNTAG_MASK_25) <<
254 				 VA_UNTAG_S_25) | vlan->members;
255 			if (dev->core_rev >= 3)
256 				entry |= VA_VALID_25_R4 | vid << VA_VID_HIGH_S;
257 			else
258 				entry |= VA_VALID_25;
259 		}
260 
261 		b53_write32(dev, B53_VLAN_PAGE, B53_VLAN_WRITE_25, entry);
262 		b53_write16(dev, B53_VLAN_PAGE, B53_VLAN_TABLE_ACCESS_25, vid |
263 			    VTA_RW_STATE_WR | VTA_RW_OP_EN);
264 	} else if (is5365(dev)) {
265 		u16 entry = 0;
266 
267 		if (vlan->members)
268 			entry = ((vlan->untag & VA_UNTAG_MASK_65) <<
269 				 VA_UNTAG_S_65) | vlan->members | VA_VALID_65;
270 
271 		b53_write16(dev, B53_VLAN_PAGE, B53_VLAN_WRITE_65, entry);
272 		b53_write16(dev, B53_VLAN_PAGE, B53_VLAN_TABLE_ACCESS_65, vid |
273 			    VTA_RW_STATE_WR | VTA_RW_OP_EN);
274 	} else {
275 		b53_write16(dev, B53_ARLIO_PAGE, dev->vta_regs[1], vid);
276 		b53_write32(dev, B53_ARLIO_PAGE, dev->vta_regs[2],
277 			    (vlan->untag << VTE_UNTAG_S) | vlan->members);
278 
279 		b53_do_vlan_op(dev, VTA_CMD_WRITE);
280 	}
281 
282 	dev_dbg(dev->ds->dev, "VID: %d, members: 0x%04x, untag: 0x%04x\n",
283 		vid, vlan->members, vlan->untag);
284 }
285 
286 static void b53_get_vlan_entry(struct b53_device *dev, u16 vid,
287 			       struct b53_vlan *vlan)
288 {
289 	if (is5325(dev)) {
290 		u32 entry = 0;
291 
292 		b53_write16(dev, B53_VLAN_PAGE, B53_VLAN_TABLE_ACCESS_25, vid |
293 			    VTA_RW_STATE_RD | VTA_RW_OP_EN);
294 		b53_read32(dev, B53_VLAN_PAGE, B53_VLAN_WRITE_25, &entry);
295 
296 		if (dev->core_rev >= 3)
297 			vlan->valid = !!(entry & VA_VALID_25_R4);
298 		else
299 			vlan->valid = !!(entry & VA_VALID_25);
300 		vlan->members = entry & VA_MEMBER_MASK;
301 		vlan->untag = (entry >> VA_UNTAG_S_25) & VA_UNTAG_MASK_25;
302 
303 	} else if (is5365(dev)) {
304 		u16 entry = 0;
305 
306 		b53_write16(dev, B53_VLAN_PAGE, B53_VLAN_TABLE_ACCESS_65, vid |
307 			    VTA_RW_STATE_WR | VTA_RW_OP_EN);
308 		b53_read16(dev, B53_VLAN_PAGE, B53_VLAN_WRITE_65, &entry);
309 
310 		vlan->valid = !!(entry & VA_VALID_65);
311 		vlan->members = entry & VA_MEMBER_MASK;
312 		vlan->untag = (entry >> VA_UNTAG_S_65) & VA_UNTAG_MASK_65;
313 	} else {
314 		u32 entry = 0;
315 
316 		b53_write16(dev, B53_ARLIO_PAGE, dev->vta_regs[1], vid);
317 		b53_do_vlan_op(dev, VTA_CMD_READ);
318 		b53_read32(dev, B53_ARLIO_PAGE, dev->vta_regs[2], &entry);
319 		vlan->members = entry & VTE_MEMBERS;
320 		vlan->untag = (entry >> VTE_UNTAG_S) & VTE_MEMBERS;
321 		vlan->valid = true;
322 	}
323 }
324 
325 static void b53_set_forwarding(struct b53_device *dev, int enable)
326 {
327 	u8 mgmt;
328 
329 	b53_read8(dev, B53_CTRL_PAGE, B53_SWITCH_MODE, &mgmt);
330 
331 	if (enable)
332 		mgmt |= SM_SW_FWD_EN;
333 	else
334 		mgmt &= ~SM_SW_FWD_EN;
335 
336 	b53_write8(dev, B53_CTRL_PAGE, B53_SWITCH_MODE, mgmt);
337 
338 	/* Include IMP port in dumb forwarding mode
339 	 */
340 	b53_read8(dev, B53_CTRL_PAGE, B53_SWITCH_CTRL, &mgmt);
341 	mgmt |= B53_MII_DUMB_FWDG_EN;
342 	b53_write8(dev, B53_CTRL_PAGE, B53_SWITCH_CTRL, mgmt);
343 
344 	/* Look at B53_UC_FWD_EN and B53_MC_FWD_EN to decide whether
345 	 * frames should be flooded or not.
346 	 */
347 	b53_read8(dev, B53_CTRL_PAGE, B53_IP_MULTICAST_CTRL, &mgmt);
348 	mgmt |= B53_UC_FWD_EN | B53_MC_FWD_EN | B53_IPMC_FWD_EN;
349 	b53_write8(dev, B53_CTRL_PAGE, B53_IP_MULTICAST_CTRL, mgmt);
350 }
351 
352 static void b53_enable_vlan(struct b53_device *dev, int port, bool enable,
353 			    bool enable_filtering)
354 {
355 	u8 mgmt, vc0, vc1, vc4 = 0, vc5;
356 
357 	b53_read8(dev, B53_CTRL_PAGE, B53_SWITCH_MODE, &mgmt);
358 	b53_read8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL0, &vc0);
359 	b53_read8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL1, &vc1);
360 
361 	if (is5325(dev) || is5365(dev)) {
362 		b53_read8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL4_25, &vc4);
363 		b53_read8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL5_25, &vc5);
364 	} else if (is63xx(dev)) {
365 		b53_read8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL4_63XX, &vc4);
366 		b53_read8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL5_63XX, &vc5);
367 	} else {
368 		b53_read8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL4, &vc4);
369 		b53_read8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL5, &vc5);
370 	}
371 
372 	if (enable) {
373 		vc0 |= VC0_VLAN_EN | VC0_VID_CHK_EN | VC0_VID_HASH_VID;
374 		vc1 |= VC1_RX_MCST_UNTAG_EN | VC1_RX_MCST_FWD_EN;
375 		vc4 &= ~VC4_ING_VID_CHECK_MASK;
376 		if (enable_filtering) {
377 			vc4 |= VC4_ING_VID_VIO_DROP << VC4_ING_VID_CHECK_S;
378 			vc5 |= VC5_DROP_VTABLE_MISS;
379 		} else {
380 			vc4 |= VC4_ING_VID_VIO_FWD << VC4_ING_VID_CHECK_S;
381 			vc5 &= ~VC5_DROP_VTABLE_MISS;
382 		}
383 
384 		if (is5325(dev))
385 			vc0 &= ~VC0_RESERVED_1;
386 
387 		if (is5325(dev) || is5365(dev))
388 			vc1 |= VC1_RX_MCST_TAG_EN;
389 
390 	} else {
391 		vc0 &= ~(VC0_VLAN_EN | VC0_VID_CHK_EN | VC0_VID_HASH_VID);
392 		vc1 &= ~(VC1_RX_MCST_UNTAG_EN | VC1_RX_MCST_FWD_EN);
393 		vc4 &= ~VC4_ING_VID_CHECK_MASK;
394 		vc5 &= ~VC5_DROP_VTABLE_MISS;
395 
396 		if (is5325(dev) || is5365(dev))
397 			vc4 |= VC4_ING_VID_VIO_FWD << VC4_ING_VID_CHECK_S;
398 		else
399 			vc4 |= VC4_ING_VID_VIO_TO_IMP << VC4_ING_VID_CHECK_S;
400 
401 		if (is5325(dev) || is5365(dev))
402 			vc1 &= ~VC1_RX_MCST_TAG_EN;
403 	}
404 
405 	if (!is5325(dev) && !is5365(dev))
406 		vc5 &= ~VC5_VID_FFF_EN;
407 
408 	b53_write8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL0, vc0);
409 	b53_write8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL1, vc1);
410 
411 	if (is5325(dev) || is5365(dev)) {
412 		/* enable the high 8 bit vid check on 5325 */
413 		if (is5325(dev) && enable)
414 			b53_write8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL3,
415 				   VC3_HIGH_8BIT_EN);
416 		else
417 			b53_write8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL3, 0);
418 
419 		b53_write8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL4_25, vc4);
420 		b53_write8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL5_25, vc5);
421 	} else if (is63xx(dev)) {
422 		b53_write16(dev, B53_VLAN_PAGE, B53_VLAN_CTRL3_63XX, 0);
423 		b53_write8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL4_63XX, vc4);
424 		b53_write8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL5_63XX, vc5);
425 	} else {
426 		b53_write16(dev, B53_VLAN_PAGE, B53_VLAN_CTRL3, 0);
427 		b53_write8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL4, vc4);
428 		b53_write8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL5, vc5);
429 	}
430 
431 	b53_write8(dev, B53_CTRL_PAGE, B53_SWITCH_MODE, mgmt);
432 
433 	dev->vlan_enabled = enable;
434 
435 	dev_dbg(dev->dev, "Port %d VLAN enabled: %d, filtering: %d\n",
436 		port, enable, enable_filtering);
437 }
438 
439 static int b53_set_jumbo(struct b53_device *dev, bool enable, bool allow_10_100)
440 {
441 	u32 port_mask = 0;
442 	u16 max_size = JMS_MIN_SIZE;
443 
444 	if (is5325(dev) || is5365(dev))
445 		return -EINVAL;
446 
447 	if (enable) {
448 		port_mask = dev->enabled_ports;
449 		max_size = JMS_MAX_SIZE;
450 		if (allow_10_100)
451 			port_mask |= JPM_10_100_JUMBO_EN;
452 	}
453 
454 	b53_write32(dev, B53_JUMBO_PAGE, dev->jumbo_pm_reg, port_mask);
455 	return b53_write16(dev, B53_JUMBO_PAGE, dev->jumbo_size_reg, max_size);
456 }
457 
458 static int b53_flush_arl(struct b53_device *dev, u8 mask)
459 {
460 	unsigned int i;
461 
462 	b53_write8(dev, B53_CTRL_PAGE, B53_FAST_AGE_CTRL,
463 		   FAST_AGE_DONE | FAST_AGE_DYNAMIC | mask);
464 
465 	for (i = 0; i < 10; i++) {
466 		u8 fast_age_ctrl;
467 
468 		b53_read8(dev, B53_CTRL_PAGE, B53_FAST_AGE_CTRL,
469 			  &fast_age_ctrl);
470 
471 		if (!(fast_age_ctrl & FAST_AGE_DONE))
472 			goto out;
473 
474 		msleep(1);
475 	}
476 
477 	return -ETIMEDOUT;
478 out:
479 	/* Only age dynamic entries (default behavior) */
480 	b53_write8(dev, B53_CTRL_PAGE, B53_FAST_AGE_CTRL, FAST_AGE_DYNAMIC);
481 	return 0;
482 }
483 
484 static int b53_fast_age_port(struct b53_device *dev, int port)
485 {
486 	b53_write8(dev, B53_CTRL_PAGE, B53_FAST_AGE_PORT_CTRL, port);
487 
488 	return b53_flush_arl(dev, FAST_AGE_PORT);
489 }
490 
491 static int b53_fast_age_vlan(struct b53_device *dev, u16 vid)
492 {
493 	b53_write16(dev, B53_CTRL_PAGE, B53_FAST_AGE_VID_CTRL, vid);
494 
495 	return b53_flush_arl(dev, FAST_AGE_VLAN);
496 }
497 
498 void b53_imp_vlan_setup(struct dsa_switch *ds, int cpu_port)
499 {
500 	struct b53_device *dev = ds->priv;
501 	unsigned int i;
502 	u16 pvlan;
503 
504 	/* Enable the IMP port to be in the same VLAN as the other ports
505 	 * on a per-port basis such that we only have Port i and IMP in
506 	 * the same VLAN.
507 	 */
508 	b53_for_each_port(dev, i) {
509 		b53_read16(dev, B53_PVLAN_PAGE, B53_PVLAN_PORT_MASK(i), &pvlan);
510 		pvlan |= BIT(cpu_port);
511 		b53_write16(dev, B53_PVLAN_PAGE, B53_PVLAN_PORT_MASK(i), pvlan);
512 	}
513 }
514 EXPORT_SYMBOL(b53_imp_vlan_setup);
515 
516 static void b53_port_set_ucast_flood(struct b53_device *dev, int port,
517 				     bool unicast)
518 {
519 	u16 uc;
520 
521 	b53_read16(dev, B53_CTRL_PAGE, B53_UC_FLOOD_MASK, &uc);
522 	if (unicast)
523 		uc |= BIT(port);
524 	else
525 		uc &= ~BIT(port);
526 	b53_write16(dev, B53_CTRL_PAGE, B53_UC_FLOOD_MASK, uc);
527 }
528 
529 static void b53_port_set_mcast_flood(struct b53_device *dev, int port,
530 				     bool multicast)
531 {
532 	u16 mc;
533 
534 	b53_read16(dev, B53_CTRL_PAGE, B53_MC_FLOOD_MASK, &mc);
535 	if (multicast)
536 		mc |= BIT(port);
537 	else
538 		mc &= ~BIT(port);
539 	b53_write16(dev, B53_CTRL_PAGE, B53_MC_FLOOD_MASK, mc);
540 
541 	b53_read16(dev, B53_CTRL_PAGE, B53_IPMC_FLOOD_MASK, &mc);
542 	if (multicast)
543 		mc |= BIT(port);
544 	else
545 		mc &= ~BIT(port);
546 	b53_write16(dev, B53_CTRL_PAGE, B53_IPMC_FLOOD_MASK, mc);
547 }
548 
549 static void b53_port_set_learning(struct b53_device *dev, int port,
550 				  bool learning)
551 {
552 	u16 reg;
553 
554 	b53_read16(dev, B53_CTRL_PAGE, B53_DIS_LEARNING, &reg);
555 	if (learning)
556 		reg &= ~BIT(port);
557 	else
558 		reg |= BIT(port);
559 	b53_write16(dev, B53_CTRL_PAGE, B53_DIS_LEARNING, reg);
560 }
561 
562 static void b53_eee_enable_set(struct dsa_switch *ds, int port, bool enable)
563 {
564 	struct b53_device *dev = ds->priv;
565 	u16 reg;
566 
567 	b53_read16(dev, B53_EEE_PAGE, B53_EEE_EN_CTRL, &reg);
568 	if (enable)
569 		reg |= BIT(port);
570 	else
571 		reg &= ~BIT(port);
572 	b53_write16(dev, B53_EEE_PAGE, B53_EEE_EN_CTRL, reg);
573 }
574 
575 int b53_enable_port(struct dsa_switch *ds, int port, struct phy_device *phy)
576 {
577 	struct b53_device *dev = ds->priv;
578 	unsigned int cpu_port;
579 	int ret = 0;
580 	u16 pvlan;
581 
582 	if (!dsa_is_user_port(ds, port))
583 		return 0;
584 
585 	cpu_port = dsa_to_port(ds, port)->cpu_dp->index;
586 
587 	b53_port_set_ucast_flood(dev, port, true);
588 	b53_port_set_mcast_flood(dev, port, true);
589 	b53_port_set_learning(dev, port, false);
590 
591 	if (dev->ops->irq_enable)
592 		ret = dev->ops->irq_enable(dev, port);
593 	if (ret)
594 		return ret;
595 
596 	/* Clear the Rx and Tx disable bits and set to no spanning tree */
597 	b53_write8(dev, B53_CTRL_PAGE, B53_PORT_CTRL(port), 0);
598 
599 	/* Set this port, and only this one to be in the default VLAN,
600 	 * if member of a bridge, restore its membership prior to
601 	 * bringing down this port.
602 	 */
603 	b53_read16(dev, B53_PVLAN_PAGE, B53_PVLAN_PORT_MASK(port), &pvlan);
604 	pvlan &= ~0x1ff;
605 	pvlan |= BIT(port);
606 	pvlan |= dev->ports[port].vlan_ctl_mask;
607 	b53_write16(dev, B53_PVLAN_PAGE, B53_PVLAN_PORT_MASK(port), pvlan);
608 
609 	b53_imp_vlan_setup(ds, cpu_port);
610 
611 	/* If EEE was enabled, restore it */
612 	if (dev->ports[port].eee.eee_enabled)
613 		b53_eee_enable_set(ds, port, true);
614 
615 	return 0;
616 }
617 EXPORT_SYMBOL(b53_enable_port);
618 
619 void b53_disable_port(struct dsa_switch *ds, int port)
620 {
621 	struct b53_device *dev = ds->priv;
622 	u8 reg;
623 
624 	/* Disable Tx/Rx for the port */
625 	b53_read8(dev, B53_CTRL_PAGE, B53_PORT_CTRL(port), &reg);
626 	reg |= PORT_CTRL_RX_DISABLE | PORT_CTRL_TX_DISABLE;
627 	b53_write8(dev, B53_CTRL_PAGE, B53_PORT_CTRL(port), reg);
628 
629 	if (dev->ops->irq_disable)
630 		dev->ops->irq_disable(dev, port);
631 }
632 EXPORT_SYMBOL(b53_disable_port);
633 
634 void b53_brcm_hdr_setup(struct dsa_switch *ds, int port)
635 {
636 	struct b53_device *dev = ds->priv;
637 	bool tag_en = !(dev->tag_protocol == DSA_TAG_PROTO_NONE);
638 	u8 hdr_ctl, val;
639 	u16 reg;
640 
641 	/* Resolve which bit controls the Broadcom tag */
642 	switch (port) {
643 	case 8:
644 		val = BRCM_HDR_P8_EN;
645 		break;
646 	case 7:
647 		val = BRCM_HDR_P7_EN;
648 		break;
649 	case 5:
650 		val = BRCM_HDR_P5_EN;
651 		break;
652 	default:
653 		val = 0;
654 		break;
655 	}
656 
657 	/* Enable management mode if tagging is requested */
658 	b53_read8(dev, B53_CTRL_PAGE, B53_SWITCH_MODE, &hdr_ctl);
659 	if (tag_en)
660 		hdr_ctl |= SM_SW_FWD_MODE;
661 	else
662 		hdr_ctl &= ~SM_SW_FWD_MODE;
663 	b53_write8(dev, B53_CTRL_PAGE, B53_SWITCH_MODE, hdr_ctl);
664 
665 	/* Configure the appropriate IMP port */
666 	b53_read8(dev, B53_MGMT_PAGE, B53_GLOBAL_CONFIG, &hdr_ctl);
667 	if (port == 8)
668 		hdr_ctl |= GC_FRM_MGMT_PORT_MII;
669 	else if (port == 5)
670 		hdr_ctl |= GC_FRM_MGMT_PORT_M;
671 	b53_write8(dev, B53_MGMT_PAGE, B53_GLOBAL_CONFIG, hdr_ctl);
672 
673 	/* Enable Broadcom tags for IMP port */
674 	b53_read8(dev, B53_MGMT_PAGE, B53_BRCM_HDR, &hdr_ctl);
675 	if (tag_en)
676 		hdr_ctl |= val;
677 	else
678 		hdr_ctl &= ~val;
679 	b53_write8(dev, B53_MGMT_PAGE, B53_BRCM_HDR, hdr_ctl);
680 
681 	/* Registers below are only accessible on newer devices */
682 	if (!is58xx(dev))
683 		return;
684 
685 	/* Enable reception Broadcom tag for CPU TX (switch RX) to
686 	 * allow us to tag outgoing frames
687 	 */
688 	b53_read16(dev, B53_MGMT_PAGE, B53_BRCM_HDR_RX_DIS, &reg);
689 	if (tag_en)
690 		reg &= ~BIT(port);
691 	else
692 		reg |= BIT(port);
693 	b53_write16(dev, B53_MGMT_PAGE, B53_BRCM_HDR_RX_DIS, reg);
694 
695 	/* Enable transmission of Broadcom tags from the switch (CPU RX) to
696 	 * allow delivering frames to the per-port net_devices
697 	 */
698 	b53_read16(dev, B53_MGMT_PAGE, B53_BRCM_HDR_TX_DIS, &reg);
699 	if (tag_en)
700 		reg &= ~BIT(port);
701 	else
702 		reg |= BIT(port);
703 	b53_write16(dev, B53_MGMT_PAGE, B53_BRCM_HDR_TX_DIS, reg);
704 }
705 EXPORT_SYMBOL(b53_brcm_hdr_setup);
706 
707 static void b53_enable_cpu_port(struct b53_device *dev, int port)
708 {
709 	u8 port_ctrl;
710 
711 	/* BCM5325 CPU port is at 8 */
712 	if ((is5325(dev) || is5365(dev)) && port == B53_CPU_PORT_25)
713 		port = B53_CPU_PORT;
714 
715 	port_ctrl = PORT_CTRL_RX_BCST_EN |
716 		    PORT_CTRL_RX_MCST_EN |
717 		    PORT_CTRL_RX_UCST_EN;
718 	b53_write8(dev, B53_CTRL_PAGE, B53_PORT_CTRL(port), port_ctrl);
719 
720 	b53_brcm_hdr_setup(dev->ds, port);
721 
722 	b53_port_set_ucast_flood(dev, port, true);
723 	b53_port_set_mcast_flood(dev, port, true);
724 	b53_port_set_learning(dev, port, false);
725 }
726 
727 static void b53_enable_mib(struct b53_device *dev)
728 {
729 	u8 gc;
730 
731 	b53_read8(dev, B53_MGMT_PAGE, B53_GLOBAL_CONFIG, &gc);
732 	gc &= ~(GC_RESET_MIB | GC_MIB_AC_EN);
733 	b53_write8(dev, B53_MGMT_PAGE, B53_GLOBAL_CONFIG, gc);
734 }
735 
736 static u16 b53_default_pvid(struct b53_device *dev)
737 {
738 	if (is5325(dev) || is5365(dev))
739 		return 1;
740 	else
741 		return 0;
742 }
743 
744 static bool b53_vlan_port_needs_forced_tagged(struct dsa_switch *ds, int port)
745 {
746 	struct b53_device *dev = ds->priv;
747 
748 	return dev->tag_protocol == DSA_TAG_PROTO_NONE && dsa_is_cpu_port(ds, port);
749 }
750 
751 int b53_configure_vlan(struct dsa_switch *ds)
752 {
753 	struct b53_device *dev = ds->priv;
754 	struct b53_vlan vl = { 0 };
755 	struct b53_vlan *v;
756 	int i, def_vid;
757 	u16 vid;
758 
759 	def_vid = b53_default_pvid(dev);
760 
761 	/* clear all vlan entries */
762 	if (is5325(dev) || is5365(dev)) {
763 		for (i = def_vid; i < dev->num_vlans; i++)
764 			b53_set_vlan_entry(dev, i, &vl);
765 	} else {
766 		b53_do_vlan_op(dev, VTA_CMD_CLEAR);
767 	}
768 
769 	b53_enable_vlan(dev, -1, dev->vlan_enabled, ds->vlan_filtering);
770 
771 	/* Create an untagged VLAN entry for the default PVID in case
772 	 * CONFIG_VLAN_8021Q is disabled and there are no calls to
773 	 * dsa_user_vlan_rx_add_vid() to create the default VLAN
774 	 * entry. Do this only when the tagging protocol is not
775 	 * DSA_TAG_PROTO_NONE
776 	 */
777 	b53_for_each_port(dev, i) {
778 		v = &dev->vlans[def_vid];
779 		v->members |= BIT(i);
780 		if (!b53_vlan_port_needs_forced_tagged(ds, i))
781 			v->untag = v->members;
782 		b53_write16(dev, B53_VLAN_PAGE,
783 			    B53_VLAN_PORT_DEF_TAG(i), def_vid);
784 	}
785 
786 	/* Upon initial call we have not set-up any VLANs, but upon
787 	 * system resume, we need to restore all VLAN entries.
788 	 */
789 	for (vid = def_vid; vid < dev->num_vlans; vid++) {
790 		v = &dev->vlans[vid];
791 
792 		if (!v->members)
793 			continue;
794 
795 		b53_set_vlan_entry(dev, vid, v);
796 		b53_fast_age_vlan(dev, vid);
797 	}
798 
799 	return 0;
800 }
801 EXPORT_SYMBOL(b53_configure_vlan);
802 
803 static void b53_switch_reset_gpio(struct b53_device *dev)
804 {
805 	int gpio = dev->reset_gpio;
806 
807 	if (gpio < 0)
808 		return;
809 
810 	/* Reset sequence: RESET low(50ms)->high(20ms)
811 	 */
812 	gpio_set_value(gpio, 0);
813 	mdelay(50);
814 
815 	gpio_set_value(gpio, 1);
816 	mdelay(20);
817 
818 	dev->current_page = 0xff;
819 }
820 
821 static int b53_switch_reset(struct b53_device *dev)
822 {
823 	unsigned int timeout = 1000;
824 	u8 mgmt, reg;
825 
826 	b53_switch_reset_gpio(dev);
827 
828 	if (is539x(dev)) {
829 		b53_write8(dev, B53_CTRL_PAGE, B53_SOFTRESET, 0x83);
830 		b53_write8(dev, B53_CTRL_PAGE, B53_SOFTRESET, 0x00);
831 	}
832 
833 	/* This is specific to 58xx devices here, do not use is58xx() which
834 	 * covers the larger Starfigther 2 family, including 7445/7278 which
835 	 * still use this driver as a library and need to perform the reset
836 	 * earlier.
837 	 */
838 	if (dev->chip_id == BCM58XX_DEVICE_ID ||
839 	    dev->chip_id == BCM583XX_DEVICE_ID) {
840 		b53_read8(dev, B53_CTRL_PAGE, B53_SOFTRESET, &reg);
841 		reg |= SW_RST | EN_SW_RST | EN_CH_RST;
842 		b53_write8(dev, B53_CTRL_PAGE, B53_SOFTRESET, reg);
843 
844 		do {
845 			b53_read8(dev, B53_CTRL_PAGE, B53_SOFTRESET, &reg);
846 			if (!(reg & SW_RST))
847 				break;
848 
849 			usleep_range(1000, 2000);
850 		} while (timeout-- > 0);
851 
852 		if (timeout == 0) {
853 			dev_err(dev->dev,
854 				"Timeout waiting for SW_RST to clear!\n");
855 			return -ETIMEDOUT;
856 		}
857 	}
858 
859 	b53_read8(dev, B53_CTRL_PAGE, B53_SWITCH_MODE, &mgmt);
860 
861 	if (!(mgmt & SM_SW_FWD_EN)) {
862 		mgmt &= ~SM_SW_FWD_MODE;
863 		mgmt |= SM_SW_FWD_EN;
864 
865 		b53_write8(dev, B53_CTRL_PAGE, B53_SWITCH_MODE, mgmt);
866 		b53_read8(dev, B53_CTRL_PAGE, B53_SWITCH_MODE, &mgmt);
867 
868 		if (!(mgmt & SM_SW_FWD_EN)) {
869 			dev_err(dev->dev, "Failed to enable switch!\n");
870 			return -EINVAL;
871 		}
872 	}
873 
874 	b53_enable_mib(dev);
875 
876 	return b53_flush_arl(dev, FAST_AGE_STATIC);
877 }
878 
879 static int b53_phy_read16(struct dsa_switch *ds, int addr, int reg)
880 {
881 	struct b53_device *priv = ds->priv;
882 	u16 value = 0;
883 	int ret;
884 
885 	if (priv->ops->phy_read16)
886 		ret = priv->ops->phy_read16(priv, addr, reg, &value);
887 	else
888 		ret = b53_read16(priv, B53_PORT_MII_PAGE(addr),
889 				 reg * 2, &value);
890 
891 	return ret ? ret : value;
892 }
893 
894 static int b53_phy_write16(struct dsa_switch *ds, int addr, int reg, u16 val)
895 {
896 	struct b53_device *priv = ds->priv;
897 
898 	if (priv->ops->phy_write16)
899 		return priv->ops->phy_write16(priv, addr, reg, val);
900 
901 	return b53_write16(priv, B53_PORT_MII_PAGE(addr), reg * 2, val);
902 }
903 
904 static int b53_reset_switch(struct b53_device *priv)
905 {
906 	/* reset vlans */
907 	memset(priv->vlans, 0, sizeof(*priv->vlans) * priv->num_vlans);
908 	memset(priv->ports, 0, sizeof(*priv->ports) * priv->num_ports);
909 
910 	priv->serdes_lane = B53_INVALID_LANE;
911 
912 	return b53_switch_reset(priv);
913 }
914 
915 static int b53_apply_config(struct b53_device *priv)
916 {
917 	/* disable switching */
918 	b53_set_forwarding(priv, 0);
919 
920 	b53_configure_vlan(priv->ds);
921 
922 	/* enable switching */
923 	b53_set_forwarding(priv, 1);
924 
925 	return 0;
926 }
927 
928 static void b53_reset_mib(struct b53_device *priv)
929 {
930 	u8 gc;
931 
932 	b53_read8(priv, B53_MGMT_PAGE, B53_GLOBAL_CONFIG, &gc);
933 
934 	b53_write8(priv, B53_MGMT_PAGE, B53_GLOBAL_CONFIG, gc | GC_RESET_MIB);
935 	msleep(1);
936 	b53_write8(priv, B53_MGMT_PAGE, B53_GLOBAL_CONFIG, gc & ~GC_RESET_MIB);
937 	msleep(1);
938 }
939 
940 static const struct b53_mib_desc *b53_get_mib(struct b53_device *dev)
941 {
942 	if (is5365(dev))
943 		return b53_mibs_65;
944 	else if (is63xx(dev))
945 		return b53_mibs_63xx;
946 	else if (is58xx(dev))
947 		return b53_mibs_58xx;
948 	else
949 		return b53_mibs;
950 }
951 
952 static unsigned int b53_get_mib_size(struct b53_device *dev)
953 {
954 	if (is5365(dev))
955 		return B53_MIBS_65_SIZE;
956 	else if (is63xx(dev))
957 		return B53_MIBS_63XX_SIZE;
958 	else if (is58xx(dev))
959 		return B53_MIBS_58XX_SIZE;
960 	else
961 		return B53_MIBS_SIZE;
962 }
963 
964 static struct phy_device *b53_get_phy_device(struct dsa_switch *ds, int port)
965 {
966 	/* These ports typically do not have built-in PHYs */
967 	switch (port) {
968 	case B53_CPU_PORT_25:
969 	case 7:
970 	case B53_CPU_PORT:
971 		return NULL;
972 	}
973 
974 	return mdiobus_get_phy(ds->user_mii_bus, port);
975 }
976 
977 void b53_get_strings(struct dsa_switch *ds, int port, u32 stringset,
978 		     uint8_t *data)
979 {
980 	struct b53_device *dev = ds->priv;
981 	const struct b53_mib_desc *mibs = b53_get_mib(dev);
982 	unsigned int mib_size = b53_get_mib_size(dev);
983 	struct phy_device *phydev;
984 	unsigned int i;
985 
986 	if (stringset == ETH_SS_STATS) {
987 		for (i = 0; i < mib_size; i++)
988 			strscpy(data + i * ETH_GSTRING_LEN,
989 				mibs[i].name, ETH_GSTRING_LEN);
990 	} else if (stringset == ETH_SS_PHY_STATS) {
991 		phydev = b53_get_phy_device(ds, port);
992 		if (!phydev)
993 			return;
994 
995 		phy_ethtool_get_strings(phydev, data);
996 	}
997 }
998 EXPORT_SYMBOL(b53_get_strings);
999 
1000 void b53_get_ethtool_stats(struct dsa_switch *ds, int port, uint64_t *data)
1001 {
1002 	struct b53_device *dev = ds->priv;
1003 	const struct b53_mib_desc *mibs = b53_get_mib(dev);
1004 	unsigned int mib_size = b53_get_mib_size(dev);
1005 	const struct b53_mib_desc *s;
1006 	unsigned int i;
1007 	u64 val = 0;
1008 
1009 	if (is5365(dev) && port == 5)
1010 		port = 8;
1011 
1012 	mutex_lock(&dev->stats_mutex);
1013 
1014 	for (i = 0; i < mib_size; i++) {
1015 		s = &mibs[i];
1016 
1017 		if (s->size == 8) {
1018 			b53_read64(dev, B53_MIB_PAGE(port), s->offset, &val);
1019 		} else {
1020 			u32 val32;
1021 
1022 			b53_read32(dev, B53_MIB_PAGE(port), s->offset,
1023 				   &val32);
1024 			val = val32;
1025 		}
1026 		data[i] = (u64)val;
1027 	}
1028 
1029 	mutex_unlock(&dev->stats_mutex);
1030 }
1031 EXPORT_SYMBOL(b53_get_ethtool_stats);
1032 
1033 void b53_get_ethtool_phy_stats(struct dsa_switch *ds, int port, uint64_t *data)
1034 {
1035 	struct phy_device *phydev;
1036 
1037 	phydev = b53_get_phy_device(ds, port);
1038 	if (!phydev)
1039 		return;
1040 
1041 	phy_ethtool_get_stats(phydev, NULL, data);
1042 }
1043 EXPORT_SYMBOL(b53_get_ethtool_phy_stats);
1044 
1045 int b53_get_sset_count(struct dsa_switch *ds, int port, int sset)
1046 {
1047 	struct b53_device *dev = ds->priv;
1048 	struct phy_device *phydev;
1049 
1050 	if (sset == ETH_SS_STATS) {
1051 		return b53_get_mib_size(dev);
1052 	} else if (sset == ETH_SS_PHY_STATS) {
1053 		phydev = b53_get_phy_device(ds, port);
1054 		if (!phydev)
1055 			return 0;
1056 
1057 		return phy_ethtool_get_sset_count(phydev);
1058 	}
1059 
1060 	return 0;
1061 }
1062 EXPORT_SYMBOL(b53_get_sset_count);
1063 
1064 enum b53_devlink_resource_id {
1065 	B53_DEVLINK_PARAM_ID_VLAN_TABLE,
1066 };
1067 
1068 static u64 b53_devlink_vlan_table_get(void *priv)
1069 {
1070 	struct b53_device *dev = priv;
1071 	struct b53_vlan *vl;
1072 	unsigned int i;
1073 	u64 count = 0;
1074 
1075 	for (i = 0; i < dev->num_vlans; i++) {
1076 		vl = &dev->vlans[i];
1077 		if (vl->members)
1078 			count++;
1079 	}
1080 
1081 	return count;
1082 }
1083 
1084 int b53_setup_devlink_resources(struct dsa_switch *ds)
1085 {
1086 	struct devlink_resource_size_params size_params;
1087 	struct b53_device *dev = ds->priv;
1088 	int err;
1089 
1090 	devlink_resource_size_params_init(&size_params, dev->num_vlans,
1091 					  dev->num_vlans,
1092 					  1, DEVLINK_RESOURCE_UNIT_ENTRY);
1093 
1094 	err = dsa_devlink_resource_register(ds, "VLAN", dev->num_vlans,
1095 					    B53_DEVLINK_PARAM_ID_VLAN_TABLE,
1096 					    DEVLINK_RESOURCE_ID_PARENT_TOP,
1097 					    &size_params);
1098 	if (err)
1099 		goto out;
1100 
1101 	dsa_devlink_resource_occ_get_register(ds,
1102 					      B53_DEVLINK_PARAM_ID_VLAN_TABLE,
1103 					      b53_devlink_vlan_table_get, dev);
1104 
1105 	return 0;
1106 out:
1107 	dsa_devlink_resources_unregister(ds);
1108 	return err;
1109 }
1110 EXPORT_SYMBOL(b53_setup_devlink_resources);
1111 
1112 static int b53_setup(struct dsa_switch *ds)
1113 {
1114 	struct b53_device *dev = ds->priv;
1115 	unsigned int port;
1116 	int ret;
1117 
1118 	/* Request bridge PVID untagged when DSA_TAG_PROTO_NONE is set
1119 	 * which forces the CPU port to be tagged in all VLANs.
1120 	 */
1121 	ds->untag_bridge_pvid = dev->tag_protocol == DSA_TAG_PROTO_NONE;
1122 
1123 	ret = b53_reset_switch(dev);
1124 	if (ret) {
1125 		dev_err(ds->dev, "failed to reset switch\n");
1126 		return ret;
1127 	}
1128 
1129 	b53_reset_mib(dev);
1130 
1131 	ret = b53_apply_config(dev);
1132 	if (ret) {
1133 		dev_err(ds->dev, "failed to apply configuration\n");
1134 		return ret;
1135 	}
1136 
1137 	/* Configure IMP/CPU port, disable all other ports. Enabled
1138 	 * ports will be configured with .port_enable
1139 	 */
1140 	for (port = 0; port < dev->num_ports; port++) {
1141 		if (dsa_is_cpu_port(ds, port))
1142 			b53_enable_cpu_port(dev, port);
1143 		else
1144 			b53_disable_port(ds, port);
1145 	}
1146 
1147 	return b53_setup_devlink_resources(ds);
1148 }
1149 
1150 static void b53_teardown(struct dsa_switch *ds)
1151 {
1152 	dsa_devlink_resources_unregister(ds);
1153 }
1154 
1155 static void b53_force_link(struct b53_device *dev, int port, int link)
1156 {
1157 	u8 reg, val, off;
1158 
1159 	/* Override the port settings */
1160 	if (port == dev->imp_port) {
1161 		off = B53_PORT_OVERRIDE_CTRL;
1162 		val = PORT_OVERRIDE_EN;
1163 	} else {
1164 		off = B53_GMII_PORT_OVERRIDE_CTRL(port);
1165 		val = GMII_PO_EN;
1166 	}
1167 
1168 	b53_read8(dev, B53_CTRL_PAGE, off, &reg);
1169 	reg |= val;
1170 	if (link)
1171 		reg |= PORT_OVERRIDE_LINK;
1172 	else
1173 		reg &= ~PORT_OVERRIDE_LINK;
1174 	b53_write8(dev, B53_CTRL_PAGE, off, reg);
1175 }
1176 
1177 static void b53_force_port_config(struct b53_device *dev, int port,
1178 				  int speed, int duplex,
1179 				  bool tx_pause, bool rx_pause)
1180 {
1181 	u8 reg, val, off;
1182 
1183 	/* Override the port settings */
1184 	if (port == dev->imp_port) {
1185 		off = B53_PORT_OVERRIDE_CTRL;
1186 		val = PORT_OVERRIDE_EN;
1187 	} else {
1188 		off = B53_GMII_PORT_OVERRIDE_CTRL(port);
1189 		val = GMII_PO_EN;
1190 	}
1191 
1192 	b53_read8(dev, B53_CTRL_PAGE, off, &reg);
1193 	reg |= val;
1194 	if (duplex == DUPLEX_FULL)
1195 		reg |= PORT_OVERRIDE_FULL_DUPLEX;
1196 	else
1197 		reg &= ~PORT_OVERRIDE_FULL_DUPLEX;
1198 
1199 	switch (speed) {
1200 	case 2000:
1201 		reg |= PORT_OVERRIDE_SPEED_2000M;
1202 		fallthrough;
1203 	case SPEED_1000:
1204 		reg |= PORT_OVERRIDE_SPEED_1000M;
1205 		break;
1206 	case SPEED_100:
1207 		reg |= PORT_OVERRIDE_SPEED_100M;
1208 		break;
1209 	case SPEED_10:
1210 		reg |= PORT_OVERRIDE_SPEED_10M;
1211 		break;
1212 	default:
1213 		dev_err(dev->dev, "unknown speed: %d\n", speed);
1214 		return;
1215 	}
1216 
1217 	if (rx_pause)
1218 		reg |= PORT_OVERRIDE_RX_FLOW;
1219 	if (tx_pause)
1220 		reg |= PORT_OVERRIDE_TX_FLOW;
1221 
1222 	b53_write8(dev, B53_CTRL_PAGE, off, reg);
1223 }
1224 
1225 static void b53_adjust_63xx_rgmii(struct dsa_switch *ds, int port,
1226 				  phy_interface_t interface)
1227 {
1228 	struct b53_device *dev = ds->priv;
1229 	u8 rgmii_ctrl = 0, off;
1230 
1231 	if (port == dev->imp_port)
1232 		off = B53_RGMII_CTRL_IMP;
1233 	else
1234 		off = B53_RGMII_CTRL_P(port);
1235 
1236 	b53_read8(dev, B53_CTRL_PAGE, off, &rgmii_ctrl);
1237 
1238 	switch (interface) {
1239 	case PHY_INTERFACE_MODE_RGMII_ID:
1240 		rgmii_ctrl |= (RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC);
1241 		break;
1242 	case PHY_INTERFACE_MODE_RGMII_RXID:
1243 		rgmii_ctrl &= ~(RGMII_CTRL_DLL_TXC);
1244 		rgmii_ctrl |= RGMII_CTRL_DLL_RXC;
1245 		break;
1246 	case PHY_INTERFACE_MODE_RGMII_TXID:
1247 		rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC);
1248 		rgmii_ctrl |= RGMII_CTRL_DLL_TXC;
1249 		break;
1250 	case PHY_INTERFACE_MODE_RGMII:
1251 	default:
1252 		rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC);
1253 		break;
1254 	}
1255 
1256 	if (port != dev->imp_port) {
1257 		if (is63268(dev))
1258 			rgmii_ctrl |= RGMII_CTRL_MII_OVERRIDE;
1259 
1260 		rgmii_ctrl |= RGMII_CTRL_ENABLE_GMII;
1261 	}
1262 
1263 	b53_write8(dev, B53_CTRL_PAGE, off, rgmii_ctrl);
1264 
1265 	dev_dbg(ds->dev, "Configured port %d for %s\n", port,
1266 		phy_modes(interface));
1267 }
1268 
1269 static void b53_adjust_link(struct dsa_switch *ds, int port,
1270 			    struct phy_device *phydev)
1271 {
1272 	struct b53_device *dev = ds->priv;
1273 	struct ethtool_keee *p = &dev->ports[port].eee;
1274 	u8 rgmii_ctrl = 0, reg = 0, off;
1275 	bool tx_pause = false;
1276 	bool rx_pause = false;
1277 
1278 	if (!phy_is_pseudo_fixed_link(phydev))
1279 		return;
1280 
1281 	/* Enable flow control on BCM5301x's CPU port */
1282 	if (is5301x(dev) && dsa_is_cpu_port(ds, port))
1283 		tx_pause = rx_pause = true;
1284 
1285 	if (phydev->pause) {
1286 		if (phydev->asym_pause)
1287 			tx_pause = true;
1288 		rx_pause = true;
1289 	}
1290 
1291 	b53_force_port_config(dev, port, phydev->speed, phydev->duplex,
1292 			      tx_pause, rx_pause);
1293 	b53_force_link(dev, port, phydev->link);
1294 
1295 	if (is63xx(dev) && port >= B53_63XX_RGMII0)
1296 		b53_adjust_63xx_rgmii(ds, port, phydev->interface);
1297 
1298 	if (is531x5(dev) && phy_interface_is_rgmii(phydev)) {
1299 		if (port == dev->imp_port)
1300 			off = B53_RGMII_CTRL_IMP;
1301 		else
1302 			off = B53_RGMII_CTRL_P(port);
1303 
1304 		/* Configure the port RGMII clock delay by DLL disabled and
1305 		 * tx_clk aligned timing (restoring to reset defaults)
1306 		 */
1307 		b53_read8(dev, B53_CTRL_PAGE, off, &rgmii_ctrl);
1308 		rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC |
1309 				RGMII_CTRL_TIMING_SEL);
1310 
1311 		/* PHY_INTERFACE_MODE_RGMII_TXID means TX internal delay, make
1312 		 * sure that we enable the port TX clock internal delay to
1313 		 * account for this internal delay that is inserted, otherwise
1314 		 * the switch won't be able to receive correctly.
1315 		 *
1316 		 * PHY_INTERFACE_MODE_RGMII means that we are not introducing
1317 		 * any delay neither on transmission nor reception, so the
1318 		 * BCM53125 must also be configured accordingly to account for
1319 		 * the lack of delay and introduce
1320 		 *
1321 		 * The BCM53125 switch has its RX clock and TX clock control
1322 		 * swapped, hence the reason why we modify the TX clock path in
1323 		 * the "RGMII" case
1324 		 */
1325 		if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID)
1326 			rgmii_ctrl |= RGMII_CTRL_DLL_TXC;
1327 		if (phydev->interface == PHY_INTERFACE_MODE_RGMII)
1328 			rgmii_ctrl |= RGMII_CTRL_DLL_TXC | RGMII_CTRL_DLL_RXC;
1329 		rgmii_ctrl |= RGMII_CTRL_TIMING_SEL;
1330 		b53_write8(dev, B53_CTRL_PAGE, off, rgmii_ctrl);
1331 
1332 		dev_info(ds->dev, "Configured port %d for %s\n", port,
1333 			 phy_modes(phydev->interface));
1334 	}
1335 
1336 	/* configure MII port if necessary */
1337 	if (is5325(dev)) {
1338 		b53_read8(dev, B53_CTRL_PAGE, B53_PORT_OVERRIDE_CTRL,
1339 			  &reg);
1340 
1341 		/* reverse mii needs to be enabled */
1342 		if (!(reg & PORT_OVERRIDE_RV_MII_25)) {
1343 			b53_write8(dev, B53_CTRL_PAGE, B53_PORT_OVERRIDE_CTRL,
1344 				   reg | PORT_OVERRIDE_RV_MII_25);
1345 			b53_read8(dev, B53_CTRL_PAGE, B53_PORT_OVERRIDE_CTRL,
1346 				  &reg);
1347 
1348 			if (!(reg & PORT_OVERRIDE_RV_MII_25)) {
1349 				dev_err(ds->dev,
1350 					"Failed to enable reverse MII mode\n");
1351 				return;
1352 			}
1353 		}
1354 	}
1355 
1356 	/* Re-negotiate EEE if it was enabled already */
1357 	p->eee_enabled = b53_eee_init(ds, port, phydev);
1358 }
1359 
1360 void b53_port_event(struct dsa_switch *ds, int port)
1361 {
1362 	struct b53_device *dev = ds->priv;
1363 	bool link;
1364 	u16 sts;
1365 
1366 	b53_read16(dev, B53_STAT_PAGE, B53_LINK_STAT, &sts);
1367 	link = !!(sts & BIT(port));
1368 	dsa_port_phylink_mac_change(ds, port, link);
1369 }
1370 EXPORT_SYMBOL(b53_port_event);
1371 
1372 static void b53_phylink_get_caps(struct dsa_switch *ds, int port,
1373 				 struct phylink_config *config)
1374 {
1375 	struct b53_device *dev = ds->priv;
1376 
1377 	/* Internal ports need GMII for PHYLIB */
1378 	__set_bit(PHY_INTERFACE_MODE_GMII, config->supported_interfaces);
1379 
1380 	/* These switches appear to support MII and RevMII too, but beyond
1381 	 * this, the code gives very few clues. FIXME: We probably need more
1382 	 * interface modes here.
1383 	 *
1384 	 * According to b53_srab_mux_init(), ports 3..5 can support:
1385 	 *  SGMII, MII, GMII, RGMII or INTERNAL depending on the MUX setting.
1386 	 * However, the interface mode read from the MUX configuration is
1387 	 * not passed back to DSA, so phylink uses NA.
1388 	 * DT can specify RGMII for ports 0, 1.
1389 	 * For MDIO, port 8 can be RGMII_TXID.
1390 	 */
1391 	__set_bit(PHY_INTERFACE_MODE_MII, config->supported_interfaces);
1392 	__set_bit(PHY_INTERFACE_MODE_REVMII, config->supported_interfaces);
1393 
1394 	config->mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE |
1395 		MAC_10 | MAC_100;
1396 
1397 	/* 5325/5365 are not capable of gigabit speeds, everything else is.
1398 	 * Note: the original code also exclulded Gigagbit for MII, RevMII
1399 	 * and 802.3z modes. MII and RevMII are not able to work above 100M,
1400 	 * so will be excluded by the generic validator implementation.
1401 	 * However, the exclusion of Gigabit for 802.3z just seems wrong.
1402 	 */
1403 	if (!(is5325(dev) || is5365(dev)))
1404 		config->mac_capabilities |= MAC_1000;
1405 
1406 	/* Get the implementation specific capabilities */
1407 	if (dev->ops->phylink_get_caps)
1408 		dev->ops->phylink_get_caps(dev, port, config);
1409 }
1410 
1411 static struct phylink_pcs *b53_phylink_mac_select_pcs(struct dsa_switch *ds,
1412 						      int port,
1413 						      phy_interface_t interface)
1414 {
1415 	struct b53_device *dev = ds->priv;
1416 
1417 	if (!dev->ops->phylink_mac_select_pcs)
1418 		return NULL;
1419 
1420 	return dev->ops->phylink_mac_select_pcs(dev, port, interface);
1421 }
1422 
1423 void b53_phylink_mac_config(struct dsa_switch *ds, int port,
1424 			    unsigned int mode,
1425 			    const struct phylink_link_state *state)
1426 {
1427 }
1428 EXPORT_SYMBOL(b53_phylink_mac_config);
1429 
1430 void b53_phylink_mac_link_down(struct dsa_switch *ds, int port,
1431 			       unsigned int mode,
1432 			       phy_interface_t interface)
1433 {
1434 	struct b53_device *dev = ds->priv;
1435 
1436 	if (mode == MLO_AN_PHY)
1437 		return;
1438 
1439 	if (mode == MLO_AN_FIXED) {
1440 		b53_force_link(dev, port, false);
1441 		return;
1442 	}
1443 
1444 	if (phy_interface_mode_is_8023z(interface) &&
1445 	    dev->ops->serdes_link_set)
1446 		dev->ops->serdes_link_set(dev, port, mode, interface, false);
1447 }
1448 EXPORT_SYMBOL(b53_phylink_mac_link_down);
1449 
1450 void b53_phylink_mac_link_up(struct dsa_switch *ds, int port,
1451 			     unsigned int mode,
1452 			     phy_interface_t interface,
1453 			     struct phy_device *phydev,
1454 			     int speed, int duplex,
1455 			     bool tx_pause, bool rx_pause)
1456 {
1457 	struct b53_device *dev = ds->priv;
1458 
1459 	if (is63xx(dev) && port >= B53_63XX_RGMII0)
1460 		b53_adjust_63xx_rgmii(ds, port, interface);
1461 
1462 	if (mode == MLO_AN_PHY)
1463 		return;
1464 
1465 	if (mode == MLO_AN_FIXED) {
1466 		b53_force_port_config(dev, port, speed, duplex,
1467 				      tx_pause, rx_pause);
1468 		b53_force_link(dev, port, true);
1469 		return;
1470 	}
1471 
1472 	if (phy_interface_mode_is_8023z(interface) &&
1473 	    dev->ops->serdes_link_set)
1474 		dev->ops->serdes_link_set(dev, port, mode, interface, true);
1475 }
1476 EXPORT_SYMBOL(b53_phylink_mac_link_up);
1477 
1478 int b53_vlan_filtering(struct dsa_switch *ds, int port, bool vlan_filtering,
1479 		       struct netlink_ext_ack *extack)
1480 {
1481 	struct b53_device *dev = ds->priv;
1482 
1483 	b53_enable_vlan(dev, port, dev->vlan_enabled, vlan_filtering);
1484 
1485 	return 0;
1486 }
1487 EXPORT_SYMBOL(b53_vlan_filtering);
1488 
1489 static int b53_vlan_prepare(struct dsa_switch *ds, int port,
1490 			    const struct switchdev_obj_port_vlan *vlan)
1491 {
1492 	struct b53_device *dev = ds->priv;
1493 
1494 	if ((is5325(dev) || is5365(dev)) && vlan->vid == 0)
1495 		return -EOPNOTSUPP;
1496 
1497 	/* Port 7 on 7278 connects to the ASP's UniMAC which is not capable of
1498 	 * receiving VLAN tagged frames at all, we can still allow the port to
1499 	 * be configured for egress untagged.
1500 	 */
1501 	if (dev->chip_id == BCM7278_DEVICE_ID && port == 7 &&
1502 	    !(vlan->flags & BRIDGE_VLAN_INFO_UNTAGGED))
1503 		return -EINVAL;
1504 
1505 	if (vlan->vid >= dev->num_vlans)
1506 		return -ERANGE;
1507 
1508 	b53_enable_vlan(dev, port, true, ds->vlan_filtering);
1509 
1510 	return 0;
1511 }
1512 
1513 int b53_vlan_add(struct dsa_switch *ds, int port,
1514 		 const struct switchdev_obj_port_vlan *vlan,
1515 		 struct netlink_ext_ack *extack)
1516 {
1517 	struct b53_device *dev = ds->priv;
1518 	bool untagged = vlan->flags & BRIDGE_VLAN_INFO_UNTAGGED;
1519 	bool pvid = vlan->flags & BRIDGE_VLAN_INFO_PVID;
1520 	struct b53_vlan *vl;
1521 	int err;
1522 
1523 	err = b53_vlan_prepare(ds, port, vlan);
1524 	if (err)
1525 		return err;
1526 
1527 	vl = &dev->vlans[vlan->vid];
1528 
1529 	b53_get_vlan_entry(dev, vlan->vid, vl);
1530 
1531 	if (vlan->vid == 0 && vlan->vid == b53_default_pvid(dev))
1532 		untagged = true;
1533 
1534 	vl->members |= BIT(port);
1535 	if (untagged && !b53_vlan_port_needs_forced_tagged(ds, port))
1536 		vl->untag |= BIT(port);
1537 	else
1538 		vl->untag &= ~BIT(port);
1539 
1540 	b53_set_vlan_entry(dev, vlan->vid, vl);
1541 	b53_fast_age_vlan(dev, vlan->vid);
1542 
1543 	if (pvid && !dsa_is_cpu_port(ds, port)) {
1544 		b53_write16(dev, B53_VLAN_PAGE, B53_VLAN_PORT_DEF_TAG(port),
1545 			    vlan->vid);
1546 		b53_fast_age_vlan(dev, vlan->vid);
1547 	}
1548 
1549 	return 0;
1550 }
1551 EXPORT_SYMBOL(b53_vlan_add);
1552 
1553 int b53_vlan_del(struct dsa_switch *ds, int port,
1554 		 const struct switchdev_obj_port_vlan *vlan)
1555 {
1556 	struct b53_device *dev = ds->priv;
1557 	bool untagged = vlan->flags & BRIDGE_VLAN_INFO_UNTAGGED;
1558 	struct b53_vlan *vl;
1559 	u16 pvid;
1560 
1561 	b53_read16(dev, B53_VLAN_PAGE, B53_VLAN_PORT_DEF_TAG(port), &pvid);
1562 
1563 	vl = &dev->vlans[vlan->vid];
1564 
1565 	b53_get_vlan_entry(dev, vlan->vid, vl);
1566 
1567 	vl->members &= ~BIT(port);
1568 
1569 	if (pvid == vlan->vid)
1570 		pvid = b53_default_pvid(dev);
1571 
1572 	if (untagged && !b53_vlan_port_needs_forced_tagged(ds, port))
1573 		vl->untag &= ~(BIT(port));
1574 
1575 	b53_set_vlan_entry(dev, vlan->vid, vl);
1576 	b53_fast_age_vlan(dev, vlan->vid);
1577 
1578 	b53_write16(dev, B53_VLAN_PAGE, B53_VLAN_PORT_DEF_TAG(port), pvid);
1579 	b53_fast_age_vlan(dev, pvid);
1580 
1581 	return 0;
1582 }
1583 EXPORT_SYMBOL(b53_vlan_del);
1584 
1585 /* Address Resolution Logic routines. Caller must hold &dev->arl_mutex. */
1586 static int b53_arl_op_wait(struct b53_device *dev)
1587 {
1588 	unsigned int timeout = 10;
1589 	u8 reg;
1590 
1591 	do {
1592 		b53_read8(dev, B53_ARLIO_PAGE, B53_ARLTBL_RW_CTRL, &reg);
1593 		if (!(reg & ARLTBL_START_DONE))
1594 			return 0;
1595 
1596 		usleep_range(1000, 2000);
1597 	} while (timeout--);
1598 
1599 	dev_warn(dev->dev, "timeout waiting for ARL to finish: 0x%02x\n", reg);
1600 
1601 	return -ETIMEDOUT;
1602 }
1603 
1604 static int b53_arl_rw_op(struct b53_device *dev, unsigned int op)
1605 {
1606 	u8 reg;
1607 
1608 	if (op > ARLTBL_RW)
1609 		return -EINVAL;
1610 
1611 	b53_read8(dev, B53_ARLIO_PAGE, B53_ARLTBL_RW_CTRL, &reg);
1612 	reg |= ARLTBL_START_DONE;
1613 	if (op)
1614 		reg |= ARLTBL_RW;
1615 	else
1616 		reg &= ~ARLTBL_RW;
1617 	if (dev->vlan_enabled)
1618 		reg &= ~ARLTBL_IVL_SVL_SELECT;
1619 	else
1620 		reg |= ARLTBL_IVL_SVL_SELECT;
1621 	b53_write8(dev, B53_ARLIO_PAGE, B53_ARLTBL_RW_CTRL, reg);
1622 
1623 	return b53_arl_op_wait(dev);
1624 }
1625 
1626 static int b53_arl_read(struct b53_device *dev, u64 mac,
1627 			u16 vid, struct b53_arl_entry *ent, u8 *idx)
1628 {
1629 	DECLARE_BITMAP(free_bins, B53_ARLTBL_MAX_BIN_ENTRIES);
1630 	unsigned int i;
1631 	int ret;
1632 
1633 	ret = b53_arl_op_wait(dev);
1634 	if (ret)
1635 		return ret;
1636 
1637 	bitmap_zero(free_bins, dev->num_arl_bins);
1638 
1639 	/* Read the bins */
1640 	for (i = 0; i < dev->num_arl_bins; i++) {
1641 		u64 mac_vid;
1642 		u32 fwd_entry;
1643 
1644 		b53_read64(dev, B53_ARLIO_PAGE,
1645 			   B53_ARLTBL_MAC_VID_ENTRY(i), &mac_vid);
1646 		b53_read32(dev, B53_ARLIO_PAGE,
1647 			   B53_ARLTBL_DATA_ENTRY(i), &fwd_entry);
1648 		b53_arl_to_entry(ent, mac_vid, fwd_entry);
1649 
1650 		if (!(fwd_entry & ARLTBL_VALID)) {
1651 			set_bit(i, free_bins);
1652 			continue;
1653 		}
1654 		if ((mac_vid & ARLTBL_MAC_MASK) != mac)
1655 			continue;
1656 		if (dev->vlan_enabled &&
1657 		    ((mac_vid >> ARLTBL_VID_S) & ARLTBL_VID_MASK) != vid)
1658 			continue;
1659 		*idx = i;
1660 		return 0;
1661 	}
1662 
1663 	*idx = find_first_bit(free_bins, dev->num_arl_bins);
1664 	return *idx >= dev->num_arl_bins ? -ENOSPC : -ENOENT;
1665 }
1666 
1667 static int b53_arl_op(struct b53_device *dev, int op, int port,
1668 		      const unsigned char *addr, u16 vid, bool is_valid)
1669 {
1670 	struct b53_arl_entry ent;
1671 	u32 fwd_entry;
1672 	u64 mac, mac_vid = 0;
1673 	u8 idx = 0;
1674 	int ret;
1675 
1676 	/* Convert the array into a 64-bit MAC */
1677 	mac = ether_addr_to_u64(addr);
1678 
1679 	/* Perform a read for the given MAC and VID */
1680 	b53_write48(dev, B53_ARLIO_PAGE, B53_MAC_ADDR_IDX, mac);
1681 	b53_write16(dev, B53_ARLIO_PAGE, B53_VLAN_ID_IDX, vid);
1682 
1683 	/* Issue a read operation for this MAC */
1684 	ret = b53_arl_rw_op(dev, 1);
1685 	if (ret)
1686 		return ret;
1687 
1688 	ret = b53_arl_read(dev, mac, vid, &ent, &idx);
1689 
1690 	/* If this is a read, just finish now */
1691 	if (op)
1692 		return ret;
1693 
1694 	switch (ret) {
1695 	case -ETIMEDOUT:
1696 		return ret;
1697 	case -ENOSPC:
1698 		dev_dbg(dev->dev, "{%pM,%.4d} no space left in ARL\n",
1699 			addr, vid);
1700 		return is_valid ? ret : 0;
1701 	case -ENOENT:
1702 		/* We could not find a matching MAC, so reset to a new entry */
1703 		dev_dbg(dev->dev, "{%pM,%.4d} not found, using idx: %d\n",
1704 			addr, vid, idx);
1705 		fwd_entry = 0;
1706 		break;
1707 	default:
1708 		dev_dbg(dev->dev, "{%pM,%.4d} found, using idx: %d\n",
1709 			addr, vid, idx);
1710 		break;
1711 	}
1712 
1713 	/* For multicast address, the port is a bitmask and the validity
1714 	 * is determined by having at least one port being still active
1715 	 */
1716 	if (!is_multicast_ether_addr(addr)) {
1717 		ent.port = port;
1718 		ent.is_valid = is_valid;
1719 	} else {
1720 		if (is_valid)
1721 			ent.port |= BIT(port);
1722 		else
1723 			ent.port &= ~BIT(port);
1724 
1725 		ent.is_valid = !!(ent.port);
1726 	}
1727 
1728 	ent.vid = vid;
1729 	ent.is_static = true;
1730 	ent.is_age = false;
1731 	memcpy(ent.mac, addr, ETH_ALEN);
1732 	b53_arl_from_entry(&mac_vid, &fwd_entry, &ent);
1733 
1734 	b53_write64(dev, B53_ARLIO_PAGE,
1735 		    B53_ARLTBL_MAC_VID_ENTRY(idx), mac_vid);
1736 	b53_write32(dev, B53_ARLIO_PAGE,
1737 		    B53_ARLTBL_DATA_ENTRY(idx), fwd_entry);
1738 
1739 	return b53_arl_rw_op(dev, 0);
1740 }
1741 
1742 int b53_fdb_add(struct dsa_switch *ds, int port,
1743 		const unsigned char *addr, u16 vid,
1744 		struct dsa_db db)
1745 {
1746 	struct b53_device *priv = ds->priv;
1747 	int ret;
1748 
1749 	/* 5325 and 5365 require some more massaging, but could
1750 	 * be supported eventually
1751 	 */
1752 	if (is5325(priv) || is5365(priv))
1753 		return -EOPNOTSUPP;
1754 
1755 	mutex_lock(&priv->arl_mutex);
1756 	ret = b53_arl_op(priv, 0, port, addr, vid, true);
1757 	mutex_unlock(&priv->arl_mutex);
1758 
1759 	return ret;
1760 }
1761 EXPORT_SYMBOL(b53_fdb_add);
1762 
1763 int b53_fdb_del(struct dsa_switch *ds, int port,
1764 		const unsigned char *addr, u16 vid,
1765 		struct dsa_db db)
1766 {
1767 	struct b53_device *priv = ds->priv;
1768 	int ret;
1769 
1770 	mutex_lock(&priv->arl_mutex);
1771 	ret = b53_arl_op(priv, 0, port, addr, vid, false);
1772 	mutex_unlock(&priv->arl_mutex);
1773 
1774 	return ret;
1775 }
1776 EXPORT_SYMBOL(b53_fdb_del);
1777 
1778 static int b53_arl_search_wait(struct b53_device *dev)
1779 {
1780 	unsigned int timeout = 1000;
1781 	u8 reg;
1782 
1783 	do {
1784 		b53_read8(dev, B53_ARLIO_PAGE, B53_ARL_SRCH_CTL, &reg);
1785 		if (!(reg & ARL_SRCH_STDN))
1786 			return 0;
1787 
1788 		if (reg & ARL_SRCH_VLID)
1789 			return 0;
1790 
1791 		usleep_range(1000, 2000);
1792 	} while (timeout--);
1793 
1794 	return -ETIMEDOUT;
1795 }
1796 
1797 static void b53_arl_search_rd(struct b53_device *dev, u8 idx,
1798 			      struct b53_arl_entry *ent)
1799 {
1800 	u64 mac_vid;
1801 	u32 fwd_entry;
1802 
1803 	b53_read64(dev, B53_ARLIO_PAGE,
1804 		   B53_ARL_SRCH_RSTL_MACVID(idx), &mac_vid);
1805 	b53_read32(dev, B53_ARLIO_PAGE,
1806 		   B53_ARL_SRCH_RSTL(idx), &fwd_entry);
1807 	b53_arl_to_entry(ent, mac_vid, fwd_entry);
1808 }
1809 
1810 static int b53_fdb_copy(int port, const struct b53_arl_entry *ent,
1811 			dsa_fdb_dump_cb_t *cb, void *data)
1812 {
1813 	if (!ent->is_valid)
1814 		return 0;
1815 
1816 	if (port != ent->port)
1817 		return 0;
1818 
1819 	return cb(ent->mac, ent->vid, ent->is_static, data);
1820 }
1821 
1822 int b53_fdb_dump(struct dsa_switch *ds, int port,
1823 		 dsa_fdb_dump_cb_t *cb, void *data)
1824 {
1825 	struct b53_device *priv = ds->priv;
1826 	struct b53_arl_entry results[2];
1827 	unsigned int count = 0;
1828 	int ret;
1829 	u8 reg;
1830 
1831 	mutex_lock(&priv->arl_mutex);
1832 
1833 	/* Start search operation */
1834 	reg = ARL_SRCH_STDN;
1835 	b53_write8(priv, B53_ARLIO_PAGE, B53_ARL_SRCH_CTL, reg);
1836 
1837 	do {
1838 		ret = b53_arl_search_wait(priv);
1839 		if (ret)
1840 			break;
1841 
1842 		b53_arl_search_rd(priv, 0, &results[0]);
1843 		ret = b53_fdb_copy(port, &results[0], cb, data);
1844 		if (ret)
1845 			break;
1846 
1847 		if (priv->num_arl_bins > 2) {
1848 			b53_arl_search_rd(priv, 1, &results[1]);
1849 			ret = b53_fdb_copy(port, &results[1], cb, data);
1850 			if (ret)
1851 				break;
1852 
1853 			if (!results[0].is_valid && !results[1].is_valid)
1854 				break;
1855 		}
1856 
1857 	} while (count++ < b53_max_arl_entries(priv) / 2);
1858 
1859 	mutex_unlock(&priv->arl_mutex);
1860 
1861 	return 0;
1862 }
1863 EXPORT_SYMBOL(b53_fdb_dump);
1864 
1865 int b53_mdb_add(struct dsa_switch *ds, int port,
1866 		const struct switchdev_obj_port_mdb *mdb,
1867 		struct dsa_db db)
1868 {
1869 	struct b53_device *priv = ds->priv;
1870 	int ret;
1871 
1872 	/* 5325 and 5365 require some more massaging, but could
1873 	 * be supported eventually
1874 	 */
1875 	if (is5325(priv) || is5365(priv))
1876 		return -EOPNOTSUPP;
1877 
1878 	mutex_lock(&priv->arl_mutex);
1879 	ret = b53_arl_op(priv, 0, port, mdb->addr, mdb->vid, true);
1880 	mutex_unlock(&priv->arl_mutex);
1881 
1882 	return ret;
1883 }
1884 EXPORT_SYMBOL(b53_mdb_add);
1885 
1886 int b53_mdb_del(struct dsa_switch *ds, int port,
1887 		const struct switchdev_obj_port_mdb *mdb,
1888 		struct dsa_db db)
1889 {
1890 	struct b53_device *priv = ds->priv;
1891 	int ret;
1892 
1893 	mutex_lock(&priv->arl_mutex);
1894 	ret = b53_arl_op(priv, 0, port, mdb->addr, mdb->vid, false);
1895 	mutex_unlock(&priv->arl_mutex);
1896 	if (ret)
1897 		dev_err(ds->dev, "failed to delete MDB entry\n");
1898 
1899 	return ret;
1900 }
1901 EXPORT_SYMBOL(b53_mdb_del);
1902 
1903 int b53_br_join(struct dsa_switch *ds, int port, struct dsa_bridge bridge,
1904 		bool *tx_fwd_offload, struct netlink_ext_ack *extack)
1905 {
1906 	struct b53_device *dev = ds->priv;
1907 	s8 cpu_port = dsa_to_port(ds, port)->cpu_dp->index;
1908 	u16 pvlan, reg;
1909 	unsigned int i;
1910 
1911 	/* On 7278, port 7 which connects to the ASP should only receive
1912 	 * traffic from matching CFP rules.
1913 	 */
1914 	if (dev->chip_id == BCM7278_DEVICE_ID && port == 7)
1915 		return -EINVAL;
1916 
1917 	/* Make this port leave the all VLANs join since we will have proper
1918 	 * VLAN entries from now on
1919 	 */
1920 	if (is58xx(dev)) {
1921 		b53_read16(dev, B53_VLAN_PAGE, B53_JOIN_ALL_VLAN_EN, &reg);
1922 		reg &= ~BIT(port);
1923 		if ((reg & BIT(cpu_port)) == BIT(cpu_port))
1924 			reg &= ~BIT(cpu_port);
1925 		b53_write16(dev, B53_VLAN_PAGE, B53_JOIN_ALL_VLAN_EN, reg);
1926 	}
1927 
1928 	b53_read16(dev, B53_PVLAN_PAGE, B53_PVLAN_PORT_MASK(port), &pvlan);
1929 
1930 	b53_for_each_port(dev, i) {
1931 		if (!dsa_port_offloads_bridge(dsa_to_port(ds, i), &bridge))
1932 			continue;
1933 
1934 		/* Add this local port to the remote port VLAN control
1935 		 * membership and update the remote port bitmask
1936 		 */
1937 		b53_read16(dev, B53_PVLAN_PAGE, B53_PVLAN_PORT_MASK(i), &reg);
1938 		reg |= BIT(port);
1939 		b53_write16(dev, B53_PVLAN_PAGE, B53_PVLAN_PORT_MASK(i), reg);
1940 		dev->ports[i].vlan_ctl_mask = reg;
1941 
1942 		pvlan |= BIT(i);
1943 	}
1944 
1945 	/* Configure the local port VLAN control membership to include
1946 	 * remote ports and update the local port bitmask
1947 	 */
1948 	b53_write16(dev, B53_PVLAN_PAGE, B53_PVLAN_PORT_MASK(port), pvlan);
1949 	dev->ports[port].vlan_ctl_mask = pvlan;
1950 
1951 	return 0;
1952 }
1953 EXPORT_SYMBOL(b53_br_join);
1954 
1955 void b53_br_leave(struct dsa_switch *ds, int port, struct dsa_bridge bridge)
1956 {
1957 	struct b53_device *dev = ds->priv;
1958 	struct b53_vlan *vl = &dev->vlans[0];
1959 	s8 cpu_port = dsa_to_port(ds, port)->cpu_dp->index;
1960 	unsigned int i;
1961 	u16 pvlan, reg, pvid;
1962 
1963 	b53_read16(dev, B53_PVLAN_PAGE, B53_PVLAN_PORT_MASK(port), &pvlan);
1964 
1965 	b53_for_each_port(dev, i) {
1966 		/* Don't touch the remaining ports */
1967 		if (!dsa_port_offloads_bridge(dsa_to_port(ds, i), &bridge))
1968 			continue;
1969 
1970 		b53_read16(dev, B53_PVLAN_PAGE, B53_PVLAN_PORT_MASK(i), &reg);
1971 		reg &= ~BIT(port);
1972 		b53_write16(dev, B53_PVLAN_PAGE, B53_PVLAN_PORT_MASK(i), reg);
1973 		dev->ports[port].vlan_ctl_mask = reg;
1974 
1975 		/* Prevent self removal to preserve isolation */
1976 		if (port != i)
1977 			pvlan &= ~BIT(i);
1978 	}
1979 
1980 	b53_write16(dev, B53_PVLAN_PAGE, B53_PVLAN_PORT_MASK(port), pvlan);
1981 	dev->ports[port].vlan_ctl_mask = pvlan;
1982 
1983 	pvid = b53_default_pvid(dev);
1984 
1985 	/* Make this port join all VLANs without VLAN entries */
1986 	if (is58xx(dev)) {
1987 		b53_read16(dev, B53_VLAN_PAGE, B53_JOIN_ALL_VLAN_EN, &reg);
1988 		reg |= BIT(port);
1989 		if (!(reg & BIT(cpu_port)))
1990 			reg |= BIT(cpu_port);
1991 		b53_write16(dev, B53_VLAN_PAGE, B53_JOIN_ALL_VLAN_EN, reg);
1992 	} else {
1993 		b53_get_vlan_entry(dev, pvid, vl);
1994 		vl->members |= BIT(port) | BIT(cpu_port);
1995 		vl->untag |= BIT(port) | BIT(cpu_port);
1996 		b53_set_vlan_entry(dev, pvid, vl);
1997 	}
1998 }
1999 EXPORT_SYMBOL(b53_br_leave);
2000 
2001 void b53_br_set_stp_state(struct dsa_switch *ds, int port, u8 state)
2002 {
2003 	struct b53_device *dev = ds->priv;
2004 	u8 hw_state;
2005 	u8 reg;
2006 
2007 	switch (state) {
2008 	case BR_STATE_DISABLED:
2009 		hw_state = PORT_CTRL_DIS_STATE;
2010 		break;
2011 	case BR_STATE_LISTENING:
2012 		hw_state = PORT_CTRL_LISTEN_STATE;
2013 		break;
2014 	case BR_STATE_LEARNING:
2015 		hw_state = PORT_CTRL_LEARN_STATE;
2016 		break;
2017 	case BR_STATE_FORWARDING:
2018 		hw_state = PORT_CTRL_FWD_STATE;
2019 		break;
2020 	case BR_STATE_BLOCKING:
2021 		hw_state = PORT_CTRL_BLOCK_STATE;
2022 		break;
2023 	default:
2024 		dev_err(ds->dev, "invalid STP state: %d\n", state);
2025 		return;
2026 	}
2027 
2028 	b53_read8(dev, B53_CTRL_PAGE, B53_PORT_CTRL(port), &reg);
2029 	reg &= ~PORT_CTRL_STP_STATE_MASK;
2030 	reg |= hw_state;
2031 	b53_write8(dev, B53_CTRL_PAGE, B53_PORT_CTRL(port), reg);
2032 }
2033 EXPORT_SYMBOL(b53_br_set_stp_state);
2034 
2035 void b53_br_fast_age(struct dsa_switch *ds, int port)
2036 {
2037 	struct b53_device *dev = ds->priv;
2038 
2039 	if (b53_fast_age_port(dev, port))
2040 		dev_err(ds->dev, "fast ageing failed\n");
2041 }
2042 EXPORT_SYMBOL(b53_br_fast_age);
2043 
2044 int b53_br_flags_pre(struct dsa_switch *ds, int port,
2045 		     struct switchdev_brport_flags flags,
2046 		     struct netlink_ext_ack *extack)
2047 {
2048 	if (flags.mask & ~(BR_FLOOD | BR_MCAST_FLOOD | BR_LEARNING))
2049 		return -EINVAL;
2050 
2051 	return 0;
2052 }
2053 EXPORT_SYMBOL(b53_br_flags_pre);
2054 
2055 int b53_br_flags(struct dsa_switch *ds, int port,
2056 		 struct switchdev_brport_flags flags,
2057 		 struct netlink_ext_ack *extack)
2058 {
2059 	if (flags.mask & BR_FLOOD)
2060 		b53_port_set_ucast_flood(ds->priv, port,
2061 					 !!(flags.val & BR_FLOOD));
2062 	if (flags.mask & BR_MCAST_FLOOD)
2063 		b53_port_set_mcast_flood(ds->priv, port,
2064 					 !!(flags.val & BR_MCAST_FLOOD));
2065 	if (flags.mask & BR_LEARNING)
2066 		b53_port_set_learning(ds->priv, port,
2067 				      !!(flags.val & BR_LEARNING));
2068 
2069 	return 0;
2070 }
2071 EXPORT_SYMBOL(b53_br_flags);
2072 
2073 static bool b53_possible_cpu_port(struct dsa_switch *ds, int port)
2074 {
2075 	/* Broadcom switches will accept enabling Broadcom tags on the
2076 	 * following ports: 5, 7 and 8, any other port is not supported
2077 	 */
2078 	switch (port) {
2079 	case B53_CPU_PORT_25:
2080 	case 7:
2081 	case B53_CPU_PORT:
2082 		return true;
2083 	}
2084 
2085 	return false;
2086 }
2087 
2088 static bool b53_can_enable_brcm_tags(struct dsa_switch *ds, int port,
2089 				     enum dsa_tag_protocol tag_protocol)
2090 {
2091 	bool ret = b53_possible_cpu_port(ds, port);
2092 
2093 	if (!ret) {
2094 		dev_warn(ds->dev, "Port %d is not Broadcom tag capable\n",
2095 			 port);
2096 		return ret;
2097 	}
2098 
2099 	switch (tag_protocol) {
2100 	case DSA_TAG_PROTO_BRCM:
2101 	case DSA_TAG_PROTO_BRCM_PREPEND:
2102 		dev_warn(ds->dev,
2103 			 "Port %d is stacked to Broadcom tag switch\n", port);
2104 		ret = false;
2105 		break;
2106 	default:
2107 		ret = true;
2108 		break;
2109 	}
2110 
2111 	return ret;
2112 }
2113 
2114 enum dsa_tag_protocol b53_get_tag_protocol(struct dsa_switch *ds, int port,
2115 					   enum dsa_tag_protocol mprot)
2116 {
2117 	struct b53_device *dev = ds->priv;
2118 
2119 	if (!b53_can_enable_brcm_tags(ds, port, mprot)) {
2120 		dev->tag_protocol = DSA_TAG_PROTO_NONE;
2121 		goto out;
2122 	}
2123 
2124 	/* Older models require a different 6 byte tag */
2125 	if (is5325(dev) || is5365(dev) || is63xx(dev)) {
2126 		dev->tag_protocol = DSA_TAG_PROTO_BRCM_LEGACY;
2127 		goto out;
2128 	}
2129 
2130 	/* Broadcom BCM58xx chips have a flow accelerator on Port 8
2131 	 * which requires us to use the prepended Broadcom tag type
2132 	 */
2133 	if (dev->chip_id == BCM58XX_DEVICE_ID && port == B53_CPU_PORT) {
2134 		dev->tag_protocol = DSA_TAG_PROTO_BRCM_PREPEND;
2135 		goto out;
2136 	}
2137 
2138 	dev->tag_protocol = DSA_TAG_PROTO_BRCM;
2139 out:
2140 	return dev->tag_protocol;
2141 }
2142 EXPORT_SYMBOL(b53_get_tag_protocol);
2143 
2144 int b53_mirror_add(struct dsa_switch *ds, int port,
2145 		   struct dsa_mall_mirror_tc_entry *mirror, bool ingress,
2146 		   struct netlink_ext_ack *extack)
2147 {
2148 	struct b53_device *dev = ds->priv;
2149 	u16 reg, loc;
2150 
2151 	if (ingress)
2152 		loc = B53_IG_MIR_CTL;
2153 	else
2154 		loc = B53_EG_MIR_CTL;
2155 
2156 	b53_read16(dev, B53_MGMT_PAGE, loc, &reg);
2157 	reg |= BIT(port);
2158 	b53_write16(dev, B53_MGMT_PAGE, loc, reg);
2159 
2160 	b53_read16(dev, B53_MGMT_PAGE, B53_MIR_CAP_CTL, &reg);
2161 	reg &= ~CAP_PORT_MASK;
2162 	reg |= mirror->to_local_port;
2163 	reg |= MIRROR_EN;
2164 	b53_write16(dev, B53_MGMT_PAGE, B53_MIR_CAP_CTL, reg);
2165 
2166 	return 0;
2167 }
2168 EXPORT_SYMBOL(b53_mirror_add);
2169 
2170 void b53_mirror_del(struct dsa_switch *ds, int port,
2171 		    struct dsa_mall_mirror_tc_entry *mirror)
2172 {
2173 	struct b53_device *dev = ds->priv;
2174 	bool loc_disable = false, other_loc_disable = false;
2175 	u16 reg, loc;
2176 
2177 	if (mirror->ingress)
2178 		loc = B53_IG_MIR_CTL;
2179 	else
2180 		loc = B53_EG_MIR_CTL;
2181 
2182 	/* Update the desired ingress/egress register */
2183 	b53_read16(dev, B53_MGMT_PAGE, loc, &reg);
2184 	reg &= ~BIT(port);
2185 	if (!(reg & MIRROR_MASK))
2186 		loc_disable = true;
2187 	b53_write16(dev, B53_MGMT_PAGE, loc, reg);
2188 
2189 	/* Now look at the other one to know if we can disable mirroring
2190 	 * entirely
2191 	 */
2192 	if (mirror->ingress)
2193 		b53_read16(dev, B53_MGMT_PAGE, B53_EG_MIR_CTL, &reg);
2194 	else
2195 		b53_read16(dev, B53_MGMT_PAGE, B53_IG_MIR_CTL, &reg);
2196 	if (!(reg & MIRROR_MASK))
2197 		other_loc_disable = true;
2198 
2199 	b53_read16(dev, B53_MGMT_PAGE, B53_MIR_CAP_CTL, &reg);
2200 	/* Both no longer have ports, let's disable mirroring */
2201 	if (loc_disable && other_loc_disable) {
2202 		reg &= ~MIRROR_EN;
2203 		reg &= ~mirror->to_local_port;
2204 	}
2205 	b53_write16(dev, B53_MGMT_PAGE, B53_MIR_CAP_CTL, reg);
2206 }
2207 EXPORT_SYMBOL(b53_mirror_del);
2208 
2209 /* Returns 0 if EEE was not enabled, or 1 otherwise
2210  */
2211 int b53_eee_init(struct dsa_switch *ds, int port, struct phy_device *phy)
2212 {
2213 	int ret;
2214 
2215 	ret = phy_init_eee(phy, false);
2216 	if (ret)
2217 		return 0;
2218 
2219 	b53_eee_enable_set(ds, port, true);
2220 
2221 	return 1;
2222 }
2223 EXPORT_SYMBOL(b53_eee_init);
2224 
2225 int b53_get_mac_eee(struct dsa_switch *ds, int port, struct ethtool_keee *e)
2226 {
2227 	struct b53_device *dev = ds->priv;
2228 
2229 	if (is5325(dev) || is5365(dev))
2230 		return -EOPNOTSUPP;
2231 
2232 	return 0;
2233 }
2234 EXPORT_SYMBOL(b53_get_mac_eee);
2235 
2236 int b53_set_mac_eee(struct dsa_switch *ds, int port, struct ethtool_keee *e)
2237 {
2238 	struct b53_device *dev = ds->priv;
2239 	struct ethtool_keee *p = &dev->ports[port].eee;
2240 
2241 	if (is5325(dev) || is5365(dev))
2242 		return -EOPNOTSUPP;
2243 
2244 	p->eee_enabled = e->eee_enabled;
2245 	b53_eee_enable_set(ds, port, e->eee_enabled);
2246 
2247 	return 0;
2248 }
2249 EXPORT_SYMBOL(b53_set_mac_eee);
2250 
2251 static int b53_change_mtu(struct dsa_switch *ds, int port, int mtu)
2252 {
2253 	struct b53_device *dev = ds->priv;
2254 	bool enable_jumbo;
2255 	bool allow_10_100;
2256 
2257 	if (is5325(dev) || is5365(dev))
2258 		return -EOPNOTSUPP;
2259 
2260 	enable_jumbo = (mtu >= JMS_MIN_SIZE);
2261 	allow_10_100 = (dev->chip_id == BCM583XX_DEVICE_ID);
2262 
2263 	return b53_set_jumbo(dev, enable_jumbo, allow_10_100);
2264 }
2265 
2266 static int b53_get_max_mtu(struct dsa_switch *ds, int port)
2267 {
2268 	return JMS_MAX_SIZE;
2269 }
2270 
2271 static const struct dsa_switch_ops b53_switch_ops = {
2272 	.get_tag_protocol	= b53_get_tag_protocol,
2273 	.setup			= b53_setup,
2274 	.teardown		= b53_teardown,
2275 	.get_strings		= b53_get_strings,
2276 	.get_ethtool_stats	= b53_get_ethtool_stats,
2277 	.get_sset_count		= b53_get_sset_count,
2278 	.get_ethtool_phy_stats	= b53_get_ethtool_phy_stats,
2279 	.phy_read		= b53_phy_read16,
2280 	.phy_write		= b53_phy_write16,
2281 	.adjust_link		= b53_adjust_link,
2282 	.phylink_get_caps	= b53_phylink_get_caps,
2283 	.phylink_mac_select_pcs	= b53_phylink_mac_select_pcs,
2284 	.phylink_mac_config	= b53_phylink_mac_config,
2285 	.phylink_mac_link_down	= b53_phylink_mac_link_down,
2286 	.phylink_mac_link_up	= b53_phylink_mac_link_up,
2287 	.port_enable		= b53_enable_port,
2288 	.port_disable		= b53_disable_port,
2289 	.get_mac_eee		= b53_get_mac_eee,
2290 	.set_mac_eee		= b53_set_mac_eee,
2291 	.port_bridge_join	= b53_br_join,
2292 	.port_bridge_leave	= b53_br_leave,
2293 	.port_pre_bridge_flags	= b53_br_flags_pre,
2294 	.port_bridge_flags	= b53_br_flags,
2295 	.port_stp_state_set	= b53_br_set_stp_state,
2296 	.port_fast_age		= b53_br_fast_age,
2297 	.port_vlan_filtering	= b53_vlan_filtering,
2298 	.port_vlan_add		= b53_vlan_add,
2299 	.port_vlan_del		= b53_vlan_del,
2300 	.port_fdb_dump		= b53_fdb_dump,
2301 	.port_fdb_add		= b53_fdb_add,
2302 	.port_fdb_del		= b53_fdb_del,
2303 	.port_mirror_add	= b53_mirror_add,
2304 	.port_mirror_del	= b53_mirror_del,
2305 	.port_mdb_add		= b53_mdb_add,
2306 	.port_mdb_del		= b53_mdb_del,
2307 	.port_max_mtu		= b53_get_max_mtu,
2308 	.port_change_mtu	= b53_change_mtu,
2309 };
2310 
2311 struct b53_chip_data {
2312 	u32 chip_id;
2313 	const char *dev_name;
2314 	u16 vlans;
2315 	u16 enabled_ports;
2316 	u8 imp_port;
2317 	u8 cpu_port;
2318 	u8 vta_regs[3];
2319 	u8 arl_bins;
2320 	u16 arl_buckets;
2321 	u8 duplex_reg;
2322 	u8 jumbo_pm_reg;
2323 	u8 jumbo_size_reg;
2324 };
2325 
2326 #define B53_VTA_REGS	\
2327 	{ B53_VT_ACCESS, B53_VT_INDEX, B53_VT_ENTRY }
2328 #define B53_VTA_REGS_9798 \
2329 	{ B53_VT_ACCESS_9798, B53_VT_INDEX_9798, B53_VT_ENTRY_9798 }
2330 #define B53_VTA_REGS_63XX \
2331 	{ B53_VT_ACCESS_63XX, B53_VT_INDEX_63XX, B53_VT_ENTRY_63XX }
2332 
2333 static const struct b53_chip_data b53_switch_chips[] = {
2334 	{
2335 		.chip_id = BCM5325_DEVICE_ID,
2336 		.dev_name = "BCM5325",
2337 		.vlans = 16,
2338 		.enabled_ports = 0x3f,
2339 		.arl_bins = 2,
2340 		.arl_buckets = 1024,
2341 		.imp_port = 5,
2342 		.duplex_reg = B53_DUPLEX_STAT_FE,
2343 	},
2344 	{
2345 		.chip_id = BCM5365_DEVICE_ID,
2346 		.dev_name = "BCM5365",
2347 		.vlans = 256,
2348 		.enabled_ports = 0x3f,
2349 		.arl_bins = 2,
2350 		.arl_buckets = 1024,
2351 		.imp_port = 5,
2352 		.duplex_reg = B53_DUPLEX_STAT_FE,
2353 	},
2354 	{
2355 		.chip_id = BCM5389_DEVICE_ID,
2356 		.dev_name = "BCM5389",
2357 		.vlans = 4096,
2358 		.enabled_ports = 0x11f,
2359 		.arl_bins = 4,
2360 		.arl_buckets = 1024,
2361 		.imp_port = 8,
2362 		.vta_regs = B53_VTA_REGS,
2363 		.duplex_reg = B53_DUPLEX_STAT_GE,
2364 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
2365 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE,
2366 	},
2367 	{
2368 		.chip_id = BCM5395_DEVICE_ID,
2369 		.dev_name = "BCM5395",
2370 		.vlans = 4096,
2371 		.enabled_ports = 0x11f,
2372 		.arl_bins = 4,
2373 		.arl_buckets = 1024,
2374 		.imp_port = 8,
2375 		.vta_regs = B53_VTA_REGS,
2376 		.duplex_reg = B53_DUPLEX_STAT_GE,
2377 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
2378 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE,
2379 	},
2380 	{
2381 		.chip_id = BCM5397_DEVICE_ID,
2382 		.dev_name = "BCM5397",
2383 		.vlans = 4096,
2384 		.enabled_ports = 0x11f,
2385 		.arl_bins = 4,
2386 		.arl_buckets = 1024,
2387 		.imp_port = 8,
2388 		.vta_regs = B53_VTA_REGS_9798,
2389 		.duplex_reg = B53_DUPLEX_STAT_GE,
2390 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
2391 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE,
2392 	},
2393 	{
2394 		.chip_id = BCM5398_DEVICE_ID,
2395 		.dev_name = "BCM5398",
2396 		.vlans = 4096,
2397 		.enabled_ports = 0x17f,
2398 		.arl_bins = 4,
2399 		.arl_buckets = 1024,
2400 		.imp_port = 8,
2401 		.vta_regs = B53_VTA_REGS_9798,
2402 		.duplex_reg = B53_DUPLEX_STAT_GE,
2403 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
2404 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE,
2405 	},
2406 	{
2407 		.chip_id = BCM53115_DEVICE_ID,
2408 		.dev_name = "BCM53115",
2409 		.vlans = 4096,
2410 		.enabled_ports = 0x11f,
2411 		.arl_bins = 4,
2412 		.arl_buckets = 1024,
2413 		.vta_regs = B53_VTA_REGS,
2414 		.imp_port = 8,
2415 		.duplex_reg = B53_DUPLEX_STAT_GE,
2416 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
2417 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE,
2418 	},
2419 	{
2420 		.chip_id = BCM53125_DEVICE_ID,
2421 		.dev_name = "BCM53125",
2422 		.vlans = 4096,
2423 		.enabled_ports = 0x1ff,
2424 		.arl_bins = 4,
2425 		.arl_buckets = 1024,
2426 		.imp_port = 8,
2427 		.vta_regs = B53_VTA_REGS,
2428 		.duplex_reg = B53_DUPLEX_STAT_GE,
2429 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
2430 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE,
2431 	},
2432 	{
2433 		.chip_id = BCM53128_DEVICE_ID,
2434 		.dev_name = "BCM53128",
2435 		.vlans = 4096,
2436 		.enabled_ports = 0x1ff,
2437 		.arl_bins = 4,
2438 		.arl_buckets = 1024,
2439 		.imp_port = 8,
2440 		.vta_regs = B53_VTA_REGS,
2441 		.duplex_reg = B53_DUPLEX_STAT_GE,
2442 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
2443 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE,
2444 	},
2445 	{
2446 		.chip_id = BCM63XX_DEVICE_ID,
2447 		.dev_name = "BCM63xx",
2448 		.vlans = 4096,
2449 		.enabled_ports = 0, /* pdata must provide them */
2450 		.arl_bins = 4,
2451 		.arl_buckets = 1024,
2452 		.imp_port = 8,
2453 		.vta_regs = B53_VTA_REGS_63XX,
2454 		.duplex_reg = B53_DUPLEX_STAT_63XX,
2455 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK_63XX,
2456 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE_63XX,
2457 	},
2458 	{
2459 		.chip_id = BCM63268_DEVICE_ID,
2460 		.dev_name = "BCM63268",
2461 		.vlans = 4096,
2462 		.enabled_ports = 0, /* pdata must provide them */
2463 		.arl_bins = 4,
2464 		.arl_buckets = 1024,
2465 		.imp_port = 8,
2466 		.vta_regs = B53_VTA_REGS_63XX,
2467 		.duplex_reg = B53_DUPLEX_STAT_63XX,
2468 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK_63XX,
2469 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE_63XX,
2470 	},
2471 	{
2472 		.chip_id = BCM53010_DEVICE_ID,
2473 		.dev_name = "BCM53010",
2474 		.vlans = 4096,
2475 		.enabled_ports = 0x1bf,
2476 		.arl_bins = 4,
2477 		.arl_buckets = 1024,
2478 		.imp_port = 8,
2479 		.vta_regs = B53_VTA_REGS,
2480 		.duplex_reg = B53_DUPLEX_STAT_GE,
2481 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
2482 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE,
2483 	},
2484 	{
2485 		.chip_id = BCM53011_DEVICE_ID,
2486 		.dev_name = "BCM53011",
2487 		.vlans = 4096,
2488 		.enabled_ports = 0x1bf,
2489 		.arl_bins = 4,
2490 		.arl_buckets = 1024,
2491 		.imp_port = 8,
2492 		.vta_regs = B53_VTA_REGS,
2493 		.duplex_reg = B53_DUPLEX_STAT_GE,
2494 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
2495 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE,
2496 	},
2497 	{
2498 		.chip_id = BCM53012_DEVICE_ID,
2499 		.dev_name = "BCM53012",
2500 		.vlans = 4096,
2501 		.enabled_ports = 0x1bf,
2502 		.arl_bins = 4,
2503 		.arl_buckets = 1024,
2504 		.imp_port = 8,
2505 		.vta_regs = B53_VTA_REGS,
2506 		.duplex_reg = B53_DUPLEX_STAT_GE,
2507 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
2508 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE,
2509 	},
2510 	{
2511 		.chip_id = BCM53018_DEVICE_ID,
2512 		.dev_name = "BCM53018",
2513 		.vlans = 4096,
2514 		.enabled_ports = 0x1bf,
2515 		.arl_bins = 4,
2516 		.arl_buckets = 1024,
2517 		.imp_port = 8,
2518 		.vta_regs = B53_VTA_REGS,
2519 		.duplex_reg = B53_DUPLEX_STAT_GE,
2520 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
2521 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE,
2522 	},
2523 	{
2524 		.chip_id = BCM53019_DEVICE_ID,
2525 		.dev_name = "BCM53019",
2526 		.vlans = 4096,
2527 		.enabled_ports = 0x1bf,
2528 		.arl_bins = 4,
2529 		.arl_buckets = 1024,
2530 		.imp_port = 8,
2531 		.vta_regs = B53_VTA_REGS,
2532 		.duplex_reg = B53_DUPLEX_STAT_GE,
2533 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
2534 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE,
2535 	},
2536 	{
2537 		.chip_id = BCM58XX_DEVICE_ID,
2538 		.dev_name = "BCM585xx/586xx/88312",
2539 		.vlans	= 4096,
2540 		.enabled_ports = 0x1ff,
2541 		.arl_bins = 4,
2542 		.arl_buckets = 1024,
2543 		.imp_port = 8,
2544 		.vta_regs = B53_VTA_REGS,
2545 		.duplex_reg = B53_DUPLEX_STAT_GE,
2546 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
2547 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE,
2548 	},
2549 	{
2550 		.chip_id = BCM583XX_DEVICE_ID,
2551 		.dev_name = "BCM583xx/11360",
2552 		.vlans = 4096,
2553 		.enabled_ports = 0x103,
2554 		.arl_bins = 4,
2555 		.arl_buckets = 1024,
2556 		.imp_port = 8,
2557 		.vta_regs = B53_VTA_REGS,
2558 		.duplex_reg = B53_DUPLEX_STAT_GE,
2559 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
2560 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE,
2561 	},
2562 	/* Starfighter 2 */
2563 	{
2564 		.chip_id = BCM4908_DEVICE_ID,
2565 		.dev_name = "BCM4908",
2566 		.vlans = 4096,
2567 		.enabled_ports = 0x1bf,
2568 		.arl_bins = 4,
2569 		.arl_buckets = 256,
2570 		.imp_port = 8,
2571 		.vta_regs = B53_VTA_REGS,
2572 		.duplex_reg = B53_DUPLEX_STAT_GE,
2573 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
2574 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE,
2575 	},
2576 	{
2577 		.chip_id = BCM7445_DEVICE_ID,
2578 		.dev_name = "BCM7445",
2579 		.vlans	= 4096,
2580 		.enabled_ports = 0x1ff,
2581 		.arl_bins = 4,
2582 		.arl_buckets = 1024,
2583 		.imp_port = 8,
2584 		.vta_regs = B53_VTA_REGS,
2585 		.duplex_reg = B53_DUPLEX_STAT_GE,
2586 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
2587 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE,
2588 	},
2589 	{
2590 		.chip_id = BCM7278_DEVICE_ID,
2591 		.dev_name = "BCM7278",
2592 		.vlans = 4096,
2593 		.enabled_ports = 0x1ff,
2594 		.arl_bins = 4,
2595 		.arl_buckets = 256,
2596 		.imp_port = 8,
2597 		.vta_regs = B53_VTA_REGS,
2598 		.duplex_reg = B53_DUPLEX_STAT_GE,
2599 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
2600 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE,
2601 	},
2602 	{
2603 		.chip_id = BCM53134_DEVICE_ID,
2604 		.dev_name = "BCM53134",
2605 		.vlans = 4096,
2606 		.enabled_ports = 0x12f,
2607 		.imp_port = 8,
2608 		.cpu_port = B53_CPU_PORT,
2609 		.vta_regs = B53_VTA_REGS,
2610 		.arl_bins = 4,
2611 		.arl_buckets = 1024,
2612 		.duplex_reg = B53_DUPLEX_STAT_GE,
2613 		.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
2614 		.jumbo_size_reg = B53_JUMBO_MAX_SIZE,
2615 	},
2616 };
2617 
2618 static int b53_switch_init(struct b53_device *dev)
2619 {
2620 	unsigned int i;
2621 	int ret;
2622 
2623 	for (i = 0; i < ARRAY_SIZE(b53_switch_chips); i++) {
2624 		const struct b53_chip_data *chip = &b53_switch_chips[i];
2625 
2626 		if (chip->chip_id == dev->chip_id) {
2627 			if (!dev->enabled_ports)
2628 				dev->enabled_ports = chip->enabled_ports;
2629 			dev->name = chip->dev_name;
2630 			dev->duplex_reg = chip->duplex_reg;
2631 			dev->vta_regs[0] = chip->vta_regs[0];
2632 			dev->vta_regs[1] = chip->vta_regs[1];
2633 			dev->vta_regs[2] = chip->vta_regs[2];
2634 			dev->jumbo_pm_reg = chip->jumbo_pm_reg;
2635 			dev->imp_port = chip->imp_port;
2636 			dev->num_vlans = chip->vlans;
2637 			dev->num_arl_bins = chip->arl_bins;
2638 			dev->num_arl_buckets = chip->arl_buckets;
2639 			break;
2640 		}
2641 	}
2642 
2643 	/* check which BCM5325x version we have */
2644 	if (is5325(dev)) {
2645 		u8 vc4;
2646 
2647 		b53_read8(dev, B53_VLAN_PAGE, B53_VLAN_CTRL4_25, &vc4);
2648 
2649 		/* check reserved bits */
2650 		switch (vc4 & 3) {
2651 		case 1:
2652 			/* BCM5325E */
2653 			break;
2654 		case 3:
2655 			/* BCM5325F - do not use port 4 */
2656 			dev->enabled_ports &= ~BIT(4);
2657 			break;
2658 		default:
2659 /* On the BCM47XX SoCs this is the supported internal switch.*/
2660 #ifndef CONFIG_BCM47XX
2661 			/* BCM5325M */
2662 			return -EINVAL;
2663 #else
2664 			break;
2665 #endif
2666 		}
2667 	}
2668 
2669 	dev->num_ports = fls(dev->enabled_ports);
2670 
2671 	dev->ds->num_ports = min_t(unsigned int, dev->num_ports, DSA_MAX_PORTS);
2672 
2673 	/* Include non standard CPU port built-in PHYs to be probed */
2674 	if (is539x(dev) || is531x5(dev)) {
2675 		for (i = 0; i < dev->num_ports; i++) {
2676 			if (!(dev->ds->phys_mii_mask & BIT(i)) &&
2677 			    !b53_possible_cpu_port(dev->ds, i))
2678 				dev->ds->phys_mii_mask |= BIT(i);
2679 		}
2680 	}
2681 
2682 	dev->ports = devm_kcalloc(dev->dev,
2683 				  dev->num_ports, sizeof(struct b53_port),
2684 				  GFP_KERNEL);
2685 	if (!dev->ports)
2686 		return -ENOMEM;
2687 
2688 	dev->vlans = devm_kcalloc(dev->dev,
2689 				  dev->num_vlans, sizeof(struct b53_vlan),
2690 				  GFP_KERNEL);
2691 	if (!dev->vlans)
2692 		return -ENOMEM;
2693 
2694 	dev->reset_gpio = b53_switch_get_reset_gpio(dev);
2695 	if (dev->reset_gpio >= 0) {
2696 		ret = devm_gpio_request_one(dev->dev, dev->reset_gpio,
2697 					    GPIOF_OUT_INIT_HIGH, "robo_reset");
2698 		if (ret)
2699 			return ret;
2700 	}
2701 
2702 	return 0;
2703 }
2704 
2705 struct b53_device *b53_switch_alloc(struct device *base,
2706 				    const struct b53_io_ops *ops,
2707 				    void *priv)
2708 {
2709 	struct dsa_switch *ds;
2710 	struct b53_device *dev;
2711 
2712 	ds = devm_kzalloc(base, sizeof(*ds), GFP_KERNEL);
2713 	if (!ds)
2714 		return NULL;
2715 
2716 	ds->dev = base;
2717 
2718 	dev = devm_kzalloc(base, sizeof(*dev), GFP_KERNEL);
2719 	if (!dev)
2720 		return NULL;
2721 
2722 	ds->priv = dev;
2723 	dev->dev = base;
2724 
2725 	dev->ds = ds;
2726 	dev->priv = priv;
2727 	dev->ops = ops;
2728 	ds->ops = &b53_switch_ops;
2729 	dev->vlan_enabled = true;
2730 	/* Let DSA handle the case were multiple bridges span the same switch
2731 	 * device and different VLAN awareness settings are requested, which
2732 	 * would be breaking filtering semantics for any of the other bridge
2733 	 * devices. (not hardware supported)
2734 	 */
2735 	ds->vlan_filtering_is_global = true;
2736 
2737 	mutex_init(&dev->reg_mutex);
2738 	mutex_init(&dev->stats_mutex);
2739 	mutex_init(&dev->arl_mutex);
2740 
2741 	return dev;
2742 }
2743 EXPORT_SYMBOL(b53_switch_alloc);
2744 
2745 int b53_switch_detect(struct b53_device *dev)
2746 {
2747 	u32 id32;
2748 	u16 tmp;
2749 	u8 id8;
2750 	int ret;
2751 
2752 	ret = b53_read8(dev, B53_MGMT_PAGE, B53_DEVICE_ID, &id8);
2753 	if (ret)
2754 		return ret;
2755 
2756 	switch (id8) {
2757 	case 0:
2758 		/* BCM5325 and BCM5365 do not have this register so reads
2759 		 * return 0. But the read operation did succeed, so assume this
2760 		 * is one of them.
2761 		 *
2762 		 * Next check if we can write to the 5325's VTA register; for
2763 		 * 5365 it is read only.
2764 		 */
2765 		b53_write16(dev, B53_VLAN_PAGE, B53_VLAN_TABLE_ACCESS_25, 0xf);
2766 		b53_read16(dev, B53_VLAN_PAGE, B53_VLAN_TABLE_ACCESS_25, &tmp);
2767 
2768 		if (tmp == 0xf)
2769 			dev->chip_id = BCM5325_DEVICE_ID;
2770 		else
2771 			dev->chip_id = BCM5365_DEVICE_ID;
2772 		break;
2773 	case BCM5389_DEVICE_ID:
2774 	case BCM5395_DEVICE_ID:
2775 	case BCM5397_DEVICE_ID:
2776 	case BCM5398_DEVICE_ID:
2777 		dev->chip_id = id8;
2778 		break;
2779 	default:
2780 		ret = b53_read32(dev, B53_MGMT_PAGE, B53_DEVICE_ID, &id32);
2781 		if (ret)
2782 			return ret;
2783 
2784 		switch (id32) {
2785 		case BCM53115_DEVICE_ID:
2786 		case BCM53125_DEVICE_ID:
2787 		case BCM53128_DEVICE_ID:
2788 		case BCM53010_DEVICE_ID:
2789 		case BCM53011_DEVICE_ID:
2790 		case BCM53012_DEVICE_ID:
2791 		case BCM53018_DEVICE_ID:
2792 		case BCM53019_DEVICE_ID:
2793 		case BCM53134_DEVICE_ID:
2794 			dev->chip_id = id32;
2795 			break;
2796 		default:
2797 			dev_err(dev->dev,
2798 				"unsupported switch detected (BCM53%02x/BCM%x)\n",
2799 				id8, id32);
2800 			return -ENODEV;
2801 		}
2802 	}
2803 
2804 	if (dev->chip_id == BCM5325_DEVICE_ID)
2805 		return b53_read8(dev, B53_STAT_PAGE, B53_REV_ID_25,
2806 				 &dev->core_rev);
2807 	else
2808 		return b53_read8(dev, B53_MGMT_PAGE, B53_REV_ID,
2809 				 &dev->core_rev);
2810 }
2811 EXPORT_SYMBOL(b53_switch_detect);
2812 
2813 int b53_switch_register(struct b53_device *dev)
2814 {
2815 	int ret;
2816 
2817 	if (dev->pdata) {
2818 		dev->chip_id = dev->pdata->chip_id;
2819 		dev->enabled_ports = dev->pdata->enabled_ports;
2820 	}
2821 
2822 	if (!dev->chip_id && b53_switch_detect(dev))
2823 		return -EINVAL;
2824 
2825 	ret = b53_switch_init(dev);
2826 	if (ret)
2827 		return ret;
2828 
2829 	dev_info(dev->dev, "found switch: %s, rev %i\n",
2830 		 dev->name, dev->core_rev);
2831 
2832 	return dsa_register_switch(dev->ds);
2833 }
2834 EXPORT_SYMBOL(b53_switch_register);
2835 
2836 MODULE_AUTHOR("Jonas Gorski <jogo@openwrt.org>");
2837 MODULE_DESCRIPTION("B53 switch library");
2838 MODULE_LICENSE("Dual BSD/GPL");
2839