xref: /linux/fs/gfs2/trans.c (revision 1a5a2cfd)
17336d0e6SThomas Gleixner // SPDX-License-Identifier: GPL-2.0-only
2b3b94faaSDavid Teigland /*
3b3b94faaSDavid Teigland  * Copyright (C) Sistina Software, Inc.  1997-2003 All rights reserved.
43a8a9a10SSteven Whitehouse  * Copyright (C) 2004-2006 Red Hat, Inc.  All rights reserved.
5b3b94faaSDavid Teigland  */
6b3b94faaSDavid Teigland 
7d77d1b58SJoe Perches #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
8d77d1b58SJoe Perches 
9b3b94faaSDavid Teigland #include <linux/sched.h>
10b3b94faaSDavid Teigland #include <linux/slab.h>
11b3b94faaSDavid Teigland #include <linux/spinlock.h>
12b3b94faaSDavid Teigland #include <linux/completion.h>
13b3b94faaSDavid Teigland #include <linux/buffer_head.h>
14d0dc80dbSSteven Whitehouse #include <linux/kallsyms.h>
15f057f6cdSSteven Whitehouse #include <linux/gfs2_ondisk.h>
16b3b94faaSDavid Teigland 
17b3b94faaSDavid Teigland #include "gfs2.h"
185c676f6dSSteven Whitehouse #include "incore.h"
19b3b94faaSDavid Teigland #include "glock.h"
20767f433fSSteven Whitehouse #include "inode.h"
21b3b94faaSDavid Teigland #include "log.h"
22b3b94faaSDavid Teigland #include "lops.h"
23b3b94faaSDavid Teigland #include "meta_io.h"
24b3b94faaSDavid Teigland #include "trans.h"
255c676f6dSSteven Whitehouse #include "util.h"
265e687eacSBenjamin Marzinski #include "trace_gfs2.h"
27b3b94faaSDavid Teigland 
28b0be23b2SBob Peterson static void gfs2_print_trans(struct gfs2_sbd *sdp, const struct gfs2_trans *tr)
29b0be23b2SBob Peterson {
30b0be23b2SBob Peterson 	fs_warn(sdp, "Transaction created at: %pSR\n", (void *)tr->tr_ip);
31b0be23b2SBob Peterson 	fs_warn(sdp, "blocks=%u revokes=%u reserved=%u touched=%u\n",
32b0be23b2SBob Peterson 		tr->tr_blocks, tr->tr_revokes, tr->tr_reserved,
33b0be23b2SBob Peterson 		test_bit(TR_TOUCHED, &tr->tr_flags));
342129b428SAndreas Gruenbacher 	fs_warn(sdp, "Buf %u/%u Databuf %u/%u Revoke %u\n",
35b0be23b2SBob Peterson 		tr->tr_num_buf_new, tr->tr_num_buf_rm,
36b0be23b2SBob Peterson 		tr->tr_num_databuf_new, tr->tr_num_databuf_rm,
372129b428SAndreas Gruenbacher 		tr->tr_num_revoke);
38b0be23b2SBob Peterson }
39b0be23b2SBob Peterson 
40c968f578SAndreas Gruenbacher int __gfs2_trans_begin(struct gfs2_trans *tr, struct gfs2_sbd *sdp,
41c968f578SAndreas Gruenbacher 		       unsigned int blocks, unsigned int revokes,
42c968f578SAndreas Gruenbacher 		       unsigned long ip)
43b3b94faaSDavid Teigland {
442129b428SAndreas Gruenbacher 	unsigned int extra_revokes;
452129b428SAndreas Gruenbacher 
46b0be23b2SBob Peterson 	if (current->journal_info) {
47b0be23b2SBob Peterson 		gfs2_print_trans(sdp, current->journal_info);
48b0be23b2SBob Peterson 		BUG();
49b0be23b2SBob Peterson 	}
50d0dc80dbSSteven Whitehouse 	BUG_ON(blocks == 0 && revokes == 0);
51b3b94faaSDavid Teigland 
52a1c0643fSSteven Whitehouse 	if (!test_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags))
53a1c0643fSSteven Whitehouse 		return -EROFS;
54a1c0643fSSteven Whitehouse 
55c968f578SAndreas Gruenbacher 	tr->tr_ip = ip;
56b3b94faaSDavid Teigland 	tr->tr_blocks = blocks;
57b3b94faaSDavid Teigland 	tr->tr_revokes = revokes;
58fe3e3976SAndreas Gruenbacher 	tr->tr_reserved = GFS2_LOG_FLUSH_MIN_BLOCKS;
59297de318SAndreas Gruenbacher 	if (blocks) {
60297de318SAndreas Gruenbacher 		/*
61297de318SAndreas Gruenbacher 		 * The reserved blocks are either used for data or metadata.
62297de318SAndreas Gruenbacher 		 * We can have mixed data and metadata, each with its own log
63297de318SAndreas Gruenbacher 		 * descriptor block; see calc_reserved().
64297de318SAndreas Gruenbacher 		 */
65297de318SAndreas Gruenbacher 		tr->tr_reserved += blocks + 1 + DIV_ROUND_UP(blocks - 1, databuf_limit(sdp));
66297de318SAndreas Gruenbacher 	}
67d69a3c65SSteven Whitehouse 	INIT_LIST_HEAD(&tr->tr_databuf);
68d69a3c65SSteven Whitehouse 	INIT_LIST_HEAD(&tr->tr_buf);
69462582b9SBob Peterson 	INIT_LIST_HEAD(&tr->tr_list);
70cbcc89b6SBob Peterson 	INIT_LIST_HEAD(&tr->tr_ail1_list);
71cbcc89b6SBob Peterson 	INIT_LIST_HEAD(&tr->tr_ail2_list);
72d69a3c65SSteven Whitehouse 
73c1eba1b0SAndreas Gruenbacher 	if (gfs2_assert_warn(sdp, tr->tr_reserved <= sdp->sd_jdesc->jd_blocks))
74c1eba1b0SAndreas Gruenbacher 		return -EINVAL;
75c1eba1b0SAndreas Gruenbacher 
7639263d5eSJan Kara 	sb_start_intwrite(sdp->sd_vfs);
77b3b94faaSDavid Teigland 
782129b428SAndreas Gruenbacher 	/*
792129b428SAndreas Gruenbacher 	 * Try the reservations under sd_log_flush_lock to prevent log flushes
802129b428SAndreas Gruenbacher 	 * from creating inconsistencies between the number of allocated and
812129b428SAndreas Gruenbacher 	 * reserved revokes.  If that fails, do a full-block allocation outside
822129b428SAndreas Gruenbacher 	 * of the lock to avoid stalling log flushes.  Then, allot the
832129b428SAndreas Gruenbacher 	 * appropriate number of blocks to revokes, use as many revokes locally
842129b428SAndreas Gruenbacher 	 * as needed, and "release" the surplus into the revokes pool.
852129b428SAndreas Gruenbacher 	 */
86c1eba1b0SAndreas Gruenbacher 
87c1eba1b0SAndreas Gruenbacher 	down_read(&sdp->sd_log_flush_lock);
882129b428SAndreas Gruenbacher 	if (gfs2_log_try_reserve(sdp, tr, &extra_revokes))
892129b428SAndreas Gruenbacher 		goto reserved;
902129b428SAndreas Gruenbacher 	up_read(&sdp->sd_log_flush_lock);
912129b428SAndreas Gruenbacher 	gfs2_log_reserve(sdp, tr, &extra_revokes);
922129b428SAndreas Gruenbacher 	down_read(&sdp->sd_log_flush_lock);
932129b428SAndreas Gruenbacher 
942129b428SAndreas Gruenbacher reserved:
952129b428SAndreas Gruenbacher 	gfs2_log_release_revokes(sdp, extra_revokes);
96c1eba1b0SAndreas Gruenbacher 	if (unlikely(!test_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags))) {
972129b428SAndreas Gruenbacher 		gfs2_log_release_revokes(sdp, tr->tr_revokes);
98c1eba1b0SAndreas Gruenbacher 		up_read(&sdp->sd_log_flush_lock);
995ae8fff8SAndreas Gruenbacher 		gfs2_log_release(sdp, tr->tr_reserved);
100c968f578SAndreas Gruenbacher 		sb_end_intwrite(sdp->sd_vfs);
101c1eba1b0SAndreas Gruenbacher 		return -EROFS;
102c968f578SAndreas Gruenbacher 	}
103b3b94faaSDavid Teigland 
1045c676f6dSSteven Whitehouse 	current->journal_info = tr;
105b3b94faaSDavid Teigland 
106b3b94faaSDavid Teigland 	return 0;
107c968f578SAndreas Gruenbacher }
108b3b94faaSDavid Teigland 
109c968f578SAndreas Gruenbacher int gfs2_trans_begin(struct gfs2_sbd *sdp, unsigned int blocks,
110c968f578SAndreas Gruenbacher 		     unsigned int revokes)
111c968f578SAndreas Gruenbacher {
112c968f578SAndreas Gruenbacher 	struct gfs2_trans *tr;
113c968f578SAndreas Gruenbacher 	int error;
114c968f578SAndreas Gruenbacher 
115c968f578SAndreas Gruenbacher 	tr = kmem_cache_zalloc(gfs2_trans_cachep, GFP_NOFS);
116c968f578SAndreas Gruenbacher 	if (!tr)
117c968f578SAndreas Gruenbacher 		return -ENOMEM;
118c968f578SAndreas Gruenbacher 	error = __gfs2_trans_begin(tr, sdp, blocks, revokes, _RET_IP_);
119c968f578SAndreas Gruenbacher 	if (error)
120b839dadaSBob Peterson 		kmem_cache_free(gfs2_trans_cachep, tr);
121b3b94faaSDavid Teigland 	return error;
122b3b94faaSDavid Teigland }
123b3b94faaSDavid Teigland 
124b3b94faaSDavid Teigland void gfs2_trans_end(struct gfs2_sbd *sdp)
125b3b94faaSDavid Teigland {
126f4154ea0SSteven Whitehouse 	struct gfs2_trans *tr = current->journal_info;
127c50b91c4SSteven Whitehouse 	s64 nbuf;
1282e60d768SBenjamin Marzinski 
1295c676f6dSSteven Whitehouse 	current->journal_info = NULL;
130b3b94faaSDavid Teigland 
1319862ca05SBob Peterson 	if (!test_bit(TR_TOUCHED, &tr->tr_flags)) {
1322129b428SAndreas Gruenbacher 		gfs2_log_release_revokes(sdp, tr->tr_revokes);
133c1eba1b0SAndreas Gruenbacher 		up_read(&sdp->sd_log_flush_lock);
1342129b428SAndreas Gruenbacher 		gfs2_log_release(sdp, tr->tr_reserved);
135c968f578SAndreas Gruenbacher 		if (!test_bit(TR_ONSTACK, &tr->tr_flags))
136b839dadaSBob Peterson 			gfs2_trans_free(sdp, tr);
13739263d5eSJan Kara 		sb_end_intwrite(sdp->sd_vfs);
138b3b94faaSDavid Teigland 		return;
139b3b94faaSDavid Teigland 	}
140b3b94faaSDavid Teigland 
1412129b428SAndreas Gruenbacher 	gfs2_log_release_revokes(sdp, tr->tr_revokes - tr->tr_num_revoke);
1422129b428SAndreas Gruenbacher 
143c50b91c4SSteven Whitehouse 	nbuf = tr->tr_num_buf_new + tr->tr_num_databuf_new;
144c50b91c4SSteven Whitehouse 	nbuf -= tr->tr_num_buf_rm;
145c50b91c4SSteven Whitehouse 	nbuf -= tr->tr_num_databuf_rm;
146c50b91c4SSteven Whitehouse 
147625a8eddSAndreas Gruenbacher 	if (gfs2_assert_withdraw(sdp, nbuf <= tr->tr_blocks) ||
148625a8eddSAndreas Gruenbacher 	    gfs2_assert_withdraw(sdp, tr->tr_num_revoke <= tr->tr_revokes))
149e54c78a2SBob Peterson 		gfs2_print_trans(sdp, tr);
150b3b94faaSDavid Teigland 
151b3b94faaSDavid Teigland 	gfs2_log_commit(sdp, tr);
152c968f578SAndreas Gruenbacher 	if (!test_bit(TR_ONSTACK, &tr->tr_flags) &&
153c968f578SAndreas Gruenbacher 	    !test_bit(TR_ATTACHED, &tr->tr_flags))
154b839dadaSBob Peterson 		gfs2_trans_free(sdp, tr);
15516ca9412SBenjamin Marzinski 	up_read(&sdp->sd_log_flush_lock);
156b3b94faaSDavid Teigland 
1571751e8a6SLinus Torvalds 	if (sdp->sd_vfs->s_flags & SB_SYNCHRONOUS)
158805c0907SBob Peterson 		gfs2_log_flush(sdp, NULL, GFS2_LOG_HEAD_FLUSH_NORMAL |
159805c0907SBob Peterson 			       GFS2_LFC_TRANS_END);
16039263d5eSJan Kara 	sb_end_intwrite(sdp->sd_vfs);
161b3b94faaSDavid Teigland }
162b3b94faaSDavid Teigland 
163c76c4d96SSteven Whitehouse static struct gfs2_bufdata *gfs2_alloc_bufdata(struct gfs2_glock *gl,
164cbbe76c8SBob Peterson 					       struct buffer_head *bh)
165c76c4d96SSteven Whitehouse {
166c76c4d96SSteven Whitehouse 	struct gfs2_bufdata *bd;
167c76c4d96SSteven Whitehouse 
168c76c4d96SSteven Whitehouse 	bd = kmem_cache_zalloc(gfs2_bufdata_cachep, GFP_NOFS | __GFP_NOFAIL);
169c76c4d96SSteven Whitehouse 	bd->bd_bh = bh;
170c76c4d96SSteven Whitehouse 	bd->bd_gl = gl;
171c76c4d96SSteven Whitehouse 	INIT_LIST_HEAD(&bd->bd_list);
172*1a5a2cfdSBob Peterson 	INIT_LIST_HEAD(&bd->bd_ail_st_list);
173*1a5a2cfdSBob Peterson 	INIT_LIST_HEAD(&bd->bd_ail_gl_list);
174c76c4d96SSteven Whitehouse 	bh->b_private = bd;
175c76c4d96SSteven Whitehouse 	return bd;
176c76c4d96SSteven Whitehouse }
177c76c4d96SSteven Whitehouse 
178b3b94faaSDavid Teigland /**
17945138990SSteven Whitehouse  * gfs2_trans_add_data - Add a databuf to the transaction.
18045138990SSteven Whitehouse  * @gl: The inode glock associated with the buffer
18145138990SSteven Whitehouse  * @bh: The buffer to add
182b3b94faaSDavid Teigland  *
183845802b1SAndreas Gruenbacher  * This is used in journaled data mode.
184767f433fSSteven Whitehouse  * We need to journal the data block in the same way as metadata in
185767f433fSSteven Whitehouse  * the functions above. The difference is that here we have a tag
186767f433fSSteven Whitehouse  * which is two __be64's being the block number (as per meta data)
187767f433fSSteven Whitehouse  * and a flag which says whether the data block needs escaping or
188767f433fSSteven Whitehouse  * not. This means we need a new log entry for each 251 or so data
189767f433fSSteven Whitehouse  * blocks, which isn't an enormous overhead but twice as much as
190767f433fSSteven Whitehouse  * for normal metadata blocks.
191b3b94faaSDavid Teigland  */
192767f433fSSteven Whitehouse void gfs2_trans_add_data(struct gfs2_glock *gl, struct buffer_head *bh)
193767f433fSSteven Whitehouse {
19445138990SSteven Whitehouse 	struct gfs2_trans *tr = current->journal_info;
19515562c43SBob Peterson 	struct gfs2_sbd *sdp = gl->gl_name.ln_sbd;
196b3b94faaSDavid Teigland 	struct gfs2_bufdata *bd;
197b3b94faaSDavid Teigland 
19896e5d1d3SBenjamin Marzinski 	lock_buffer(bh);
199aacee720SBob Peterson 	if (buffer_pinned(bh)) {
200aacee720SBob Peterson 		set_bit(TR_TOUCHED, &tr->tr_flags);
201aacee720SBob Peterson 		goto out;
202aacee720SBob Peterson 	}
20396e5d1d3SBenjamin Marzinski 	gfs2_log_lock(sdp);
2045c676f6dSSteven Whitehouse 	bd = bh->b_private;
205c76c4d96SSteven Whitehouse 	if (bd == NULL) {
20696e5d1d3SBenjamin Marzinski 		gfs2_log_unlock(sdp);
20796e5d1d3SBenjamin Marzinski 		unlock_buffer(bh);
208c76c4d96SSteven Whitehouse 		if (bh->b_private == NULL)
209cbbe76c8SBob Peterson 			bd = gfs2_alloc_bufdata(gl, bh);
210491e94f7SBob Peterson 		else
211491e94f7SBob Peterson 			bd = bh->b_private;
21296e5d1d3SBenjamin Marzinski 		lock_buffer(bh);
21396e5d1d3SBenjamin Marzinski 		gfs2_log_lock(sdp);
214b3b94faaSDavid Teigland 	}
215c76c4d96SSteven Whitehouse 	gfs2_assert(sdp, bd->bd_gl == gl);
2169862ca05SBob Peterson 	set_bit(TR_TOUCHED, &tr->tr_flags);
21745138990SSteven Whitehouse 	if (list_empty(&bd->bd_list)) {
21845138990SSteven Whitehouse 		set_bit(GLF_LFLUSH, &bd->bd_gl->gl_flags);
21945138990SSteven Whitehouse 		set_bit(GLF_DIRTY, &bd->bd_gl->gl_flags);
22045138990SSteven Whitehouse 		gfs2_pin(sdp, bd->bd_bh);
22145138990SSteven Whitehouse 		tr->tr_num_databuf_new++;
222d69a3c65SSteven Whitehouse 		list_add_tail(&bd->bd_list, &tr->tr_databuf);
22345138990SSteven Whitehouse 	}
22496e5d1d3SBenjamin Marzinski 	gfs2_log_unlock(sdp);
225aacee720SBob Peterson out:
22696e5d1d3SBenjamin Marzinski 	unlock_buffer(bh);
227b3b94faaSDavid Teigland }
228b3b94faaSDavid Teigland 
229350a9b0aSSteven Whitehouse void gfs2_trans_add_meta(struct gfs2_glock *gl, struct buffer_head *bh)
230350a9b0aSSteven Whitehouse {
231767f433fSSteven Whitehouse 
23215562c43SBob Peterson 	struct gfs2_sbd *sdp = gl->gl_name.ln_sbd;
233767f433fSSteven Whitehouse 	struct gfs2_bufdata *bd;
234192738b7SBob Peterson 	struct gfs2_meta_header *mh;
235aacee720SBob Peterson 	struct gfs2_trans *tr = current->journal_info;
236192738b7SBob Peterson 	enum gfs2_freeze_state state = atomic_read(&sdp->sd_freeze_state);
237767f433fSSteven Whitehouse 
238767f433fSSteven Whitehouse 	lock_buffer(bh);
239aacee720SBob Peterson 	if (buffer_pinned(bh)) {
240aacee720SBob Peterson 		set_bit(TR_TOUCHED, &tr->tr_flags);
241aacee720SBob Peterson 		goto out;
242aacee720SBob Peterson 	}
243767f433fSSteven Whitehouse 	gfs2_log_lock(sdp);
244767f433fSSteven Whitehouse 	bd = bh->b_private;
245c76c4d96SSteven Whitehouse 	if (bd == NULL) {
246767f433fSSteven Whitehouse 		gfs2_log_unlock(sdp);
247767f433fSSteven Whitehouse 		unlock_buffer(bh);
248c76c4d96SSteven Whitehouse 		lock_page(bh->b_page);
249c76c4d96SSteven Whitehouse 		if (bh->b_private == NULL)
250cbbe76c8SBob Peterson 			bd = gfs2_alloc_bufdata(gl, bh);
251491e94f7SBob Peterson 		else
252491e94f7SBob Peterson 			bd = bh->b_private;
253c76c4d96SSteven Whitehouse 		unlock_page(bh->b_page);
254767f433fSSteven Whitehouse 		lock_buffer(bh);
255767f433fSSteven Whitehouse 		gfs2_log_lock(sdp);
256767f433fSSteven Whitehouse 	}
257c76c4d96SSteven Whitehouse 	gfs2_assert(sdp, bd->bd_gl == gl);
258192738b7SBob Peterson 	set_bit(TR_TOUCHED, &tr->tr_flags);
259192738b7SBob Peterson 	if (!list_empty(&bd->bd_list))
260192738b7SBob Peterson 		goto out_unlock;
261192738b7SBob Peterson 	set_bit(GLF_LFLUSH, &bd->bd_gl->gl_flags);
262192738b7SBob Peterson 	set_bit(GLF_DIRTY, &bd->bd_gl->gl_flags);
263192738b7SBob Peterson 	mh = (struct gfs2_meta_header *)bd->bd_bh->b_data;
264192738b7SBob Peterson 	if (unlikely(mh->mh_magic != cpu_to_be32(GFS2_MAGIC))) {
265e54c78a2SBob Peterson 		fs_err(sdp, "Attempting to add uninitialised block to "
266e54c78a2SBob Peterson 		       "journal (inplace block=%lld)\n",
267192738b7SBob Peterson 		       (unsigned long long)bd->bd_bh->b_blocknr);
268192738b7SBob Peterson 		BUG();
269192738b7SBob Peterson 	}
270192738b7SBob Peterson 	if (unlikely(state == SFS_FROZEN)) {
271e54c78a2SBob Peterson 		fs_info(sdp, "GFS2:adding buf while frozen\n");
272192738b7SBob Peterson 		gfs2_assert_withdraw(sdp, 0);
273192738b7SBob Peterson 	}
2742ca0c2fbSBob Peterson 	if (unlikely(gfs2_withdrawn(sdp))) {
2752ca0c2fbSBob Peterson 		fs_info(sdp, "GFS2:adding buf while withdrawn! 0x%llx\n",
2762ca0c2fbSBob Peterson 			(unsigned long long)bd->bd_bh->b_blocknr);
2772ca0c2fbSBob Peterson 	}
278192738b7SBob Peterson 	gfs2_pin(sdp, bd->bd_bh);
279192738b7SBob Peterson 	mh->__pad0 = cpu_to_be64(0);
280192738b7SBob Peterson 	mh->mh_jid = cpu_to_be32(sdp->sd_jdesc->jd_jid);
281192738b7SBob Peterson 	list_add(&bd->bd_list, &tr->tr_buf);
282192738b7SBob Peterson 	tr->tr_num_buf_new++;
283192738b7SBob Peterson out_unlock:
284767f433fSSteven Whitehouse 	gfs2_log_unlock(sdp);
285aacee720SBob Peterson out:
286767f433fSSteven Whitehouse 	unlock_buffer(bh);
287350a9b0aSSteven Whitehouse }
288350a9b0aSSteven Whitehouse 
2891ad38c43SSteven Whitehouse void gfs2_trans_add_revoke(struct gfs2_sbd *sdp, struct gfs2_bufdata *bd)
290b3b94faaSDavid Teigland {
29175f2b879SSteven Whitehouse 	struct gfs2_trans *tr = current->journal_info;
29275f2b879SSteven Whitehouse 
293c0752aa7SBob Peterson 	BUG_ON(!list_empty(&bd->bd_list));
2945d054964SBenjamin Marzinski 	gfs2_add_revoke(sdp, bd);
2959862ca05SBob Peterson 	set_bit(TR_TOUCHED, &tr->tr_flags);
29675f2b879SSteven Whitehouse 	tr->tr_num_revoke++;
297b3b94faaSDavid Teigland }
298b3b94faaSDavid Teigland 
299fbb27873SAndreas Gruenbacher void gfs2_trans_remove_revoke(struct gfs2_sbd *sdp, u64 blkno, unsigned int len)
300b3b94faaSDavid Teigland {
3015731be53SSteven Whitehouse 	struct gfs2_bufdata *bd, *tmp;
3025731be53SSteven Whitehouse 	unsigned int n = len;
303b3b94faaSDavid Teigland 
304b3b94faaSDavid Teigland 	gfs2_log_lock(sdp);
305a5b1d3fcSAndreas Gruenbacher 	list_for_each_entry_safe(bd, tmp, &sdp->sd_log_revokes, bd_list) {
3065731be53SSteven Whitehouse 		if ((bd->bd_blkno >= blkno) && (bd->bd_blkno < (blkno + len))) {
307c0752aa7SBob Peterson 			list_del_init(&bd->bd_list);
308b3b94faaSDavid Teigland 			gfs2_assert_withdraw(sdp, sdp->sd_log_num_revoke);
309b3b94faaSDavid Teigland 			sdp->sd_log_num_revoke--;
310fe5e7ba1SBob Peterson 			if (bd->bd_gl)
311fe5e7ba1SBob Peterson 				gfs2_glock_remove_revoke(bd->bd_gl);
3125731be53SSteven Whitehouse 			kmem_cache_free(gfs2_bufdata_cachep, bd);
3132129b428SAndreas Gruenbacher 			gfs2_log_release_revokes(sdp, 1);
3145731be53SSteven Whitehouse 			if (--n == 0)
315b3b94faaSDavid Teigland 				break;
316b3b94faaSDavid Teigland 		}
317b3b94faaSDavid Teigland 	}
318b3b94faaSDavid Teigland 	gfs2_log_unlock(sdp);
319b3b94faaSDavid Teigland }
320b3b94faaSDavid Teigland 
321b839dadaSBob Peterson void gfs2_trans_free(struct gfs2_sbd *sdp, struct gfs2_trans *tr)
322b839dadaSBob Peterson {
323b839dadaSBob Peterson 	if (tr == NULL)
324b839dadaSBob Peterson 		return;
325b839dadaSBob Peterson 
326b839dadaSBob Peterson 	gfs2_assert_warn(sdp, list_empty(&tr->tr_ail1_list));
327b839dadaSBob Peterson 	gfs2_assert_warn(sdp, list_empty(&tr->tr_ail2_list));
328b839dadaSBob Peterson 	gfs2_assert_warn(sdp, list_empty(&tr->tr_databuf));
329b839dadaSBob Peterson 	gfs2_assert_warn(sdp, list_empty(&tr->tr_buf));
330b839dadaSBob Peterson 	kmem_cache_free(gfs2_trans_cachep, tr);
331b839dadaSBob Peterson }
332