1 /* 	$OpenBSD: test_sshbuf_getput_crypto.c,v 1.3 2021/12/14 21:25:27 deraadt Exp $ */
2 /*
3  * Regress test for sshbuf.h buffer API
4  *
5  * Placed in the public domain
6  */
7 
8 #include <sys/types.h>
9 #include <stdio.h>
10 #include <stdint.h>
11 #include <stdlib.h>
12 #include <string.h>
13 
14 #include <openssl/bn.h>
15 #include <openssl/ec.h>
16 #include <openssl/objects.h>
17 
18 #include "test_helper.h"
19 #include "ssherr.h"
20 #include "sshbuf.h"
21 
22 void sshbuf_getput_crypto_tests(void);
23 
24 void
sshbuf_getput_crypto_tests(void)25 sshbuf_getput_crypto_tests(void)
26 {
27 	struct sshbuf *p1;
28 	const u_char *d;
29 	size_t s;
30 	BIGNUM *bn, *bn2, *bn_x, *bn_y;
31 	const char *hexbn1 = "0102030405060708090a0b0c0d0e0f10";
32 	/* This one has MSB set to test bignum2 encoding negative-avoidance */
33 	const char *hexbn2 = "f0e0d0c0b0a0908070605040302010007fff11";
34 	u_char expbn1[] = {
35 		0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08,
36 		0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f, 0x10,
37 	};
38 	u_char expbn2[] = {
39 		0xf0, 0xe0, 0xd0, 0xc0, 0xb0, 0xa0, 0x90, 0x80,
40 		0x70, 0x60, 0x50, 0x40, 0x30, 0x20, 0x10, 0x00,
41 		0x7f, 0xff, 0x11
42 	};
43 	int ec256_nid = NID_X9_62_prime256v1;
44 	char *ec256_x = "0C828004839D0106AA59575216191357"
45 		        "34B451459DADB586677EF9DF55784999";
46 	char *ec256_y = "4D196B50F0B4E94B3C73E3A9D4CD9DF2"
47 	                "C8F9A35E42BDD047550F69D80EC23CD4";
48 	u_char expec256[] = {
49 		0x04,
50 		0x0c, 0x82, 0x80, 0x04, 0x83, 0x9d, 0x01, 0x06,
51 		0xaa, 0x59, 0x57, 0x52, 0x16, 0x19, 0x13, 0x57,
52 		0x34, 0xb4, 0x51, 0x45, 0x9d, 0xad, 0xb5, 0x86,
53 		0x67, 0x7e, 0xf9, 0xdf, 0x55, 0x78, 0x49, 0x99,
54 		0x4d, 0x19, 0x6b, 0x50, 0xf0, 0xb4, 0xe9, 0x4b,
55 		0x3c, 0x73, 0xe3, 0xa9, 0xd4, 0xcd, 0x9d, 0xf2,
56 		0xc8, 0xf9, 0xa3, 0x5e, 0x42, 0xbd, 0xd0, 0x47,
57 		0x55, 0x0f, 0x69, 0xd8, 0x0e, 0xc2, 0x3c, 0xd4
58 	};
59 	EC_KEY *eck;
60 	EC_POINT *ecp;
61 	int r;
62 
63 #define MKBN(b, bnn) \
64 	do { \
65 		bnn = NULL; \
66 		ASSERT_INT_GT(BN_hex2bn(&bnn, b), 0); \
67 	} while (0)
68 
69 	TEST_START("sshbuf_put_bignum2");
70 	MKBN(hexbn1, bn);
71 	p1 = sshbuf_new();
72 	ASSERT_PTR_NE(p1, NULL);
73 	ASSERT_INT_EQ(sshbuf_put_bignum2(p1, bn), 0);
74 	ASSERT_SIZE_T_EQ(sshbuf_len(p1), sizeof(expbn1) + 4);
75 	ASSERT_U32_EQ(PEEK_U32(sshbuf_ptr(p1)), (u_int32_t)BN_num_bytes(bn));
76 	ASSERT_MEM_EQ(sshbuf_ptr(p1) + 4, expbn1, sizeof(expbn1));
77 	BN_free(bn);
78 	sshbuf_free(p1);
79 	TEST_DONE();
80 
81 	TEST_START("sshbuf_put_bignum2 limited");
82 	MKBN(hexbn1, bn);
83 	p1 = sshbuf_new();
84 	ASSERT_PTR_NE(p1, NULL);
85 	ASSERT_INT_EQ(sshbuf_set_max_size(p1, sizeof(expbn1) + 3), 0);
86 	r = sshbuf_put_bignum2(p1, bn);
87 	ASSERT_INT_EQ(r, SSH_ERR_NO_BUFFER_SPACE);
88 	ASSERT_SIZE_T_EQ(sshbuf_len(p1), 0);
89 	BN_free(bn);
90 	sshbuf_free(p1);
91 	TEST_DONE();
92 
93 	TEST_START("sshbuf_put_bignum2 bn2");
94 	MKBN(hexbn2, bn);
95 	p1 = sshbuf_new();
96 	ASSERT_PTR_NE(p1, NULL);
97 	ASSERT_INT_EQ(sshbuf_put_bignum2(p1, bn), 0);
98 	ASSERT_SIZE_T_EQ(sshbuf_len(p1), sizeof(expbn2) + 4 + 1); /* MSB */
99 	ASSERT_U32_EQ(PEEK_U32(sshbuf_ptr(p1)), (u_int32_t)BN_num_bytes(bn) + 1);
100 	ASSERT_U8_EQ(*(sshbuf_ptr(p1) + 4), 0x00);
101 	ASSERT_MEM_EQ(sshbuf_ptr(p1) + 5, expbn2, sizeof(expbn2));
102 	BN_free(bn);
103 	sshbuf_free(p1);
104 	TEST_DONE();
105 
106 	TEST_START("sshbuf_put_bignum2 bn2 limited");
107 	MKBN(hexbn2, bn);
108 	p1 = sshbuf_new();
109 	ASSERT_PTR_NE(p1, NULL);
110 	ASSERT_INT_EQ(sshbuf_set_max_size(p1, sizeof(expbn2) + 3), 0);
111 	r = sshbuf_put_bignum2(p1, bn);
112 	ASSERT_INT_EQ(r, SSH_ERR_NO_BUFFER_SPACE);
113 	ASSERT_SIZE_T_EQ(sshbuf_len(p1), 0);
114 	BN_free(bn);
115 	sshbuf_free(p1);
116 	TEST_DONE();
117 
118 	TEST_START("sshbuf_get_bignum2");
119 	MKBN(hexbn1, bn);
120 	p1 = sshbuf_new();
121 	ASSERT_PTR_NE(p1, NULL);
122 	ASSERT_INT_EQ(sshbuf_put_u32(p1, BN_num_bytes(bn)), 0);
123 	ASSERT_INT_EQ(sshbuf_put(p1, expbn1, sizeof(expbn1)), 0);
124 	ASSERT_SIZE_T_EQ(sshbuf_len(p1), 4 + sizeof(expbn1));
125 	ASSERT_INT_EQ(sshbuf_put_u16(p1, 0xd00f), 0);
126 	bn2 = NULL;
127 	ASSERT_INT_EQ(sshbuf_get_bignum2(p1, &bn2), 0);
128 	ASSERT_BIGNUM_EQ(bn, bn2);
129 	ASSERT_SIZE_T_EQ(sshbuf_len(p1), 2);
130 	BN_free(bn);
131 	BN_free(bn2);
132 	sshbuf_free(p1);
133 	TEST_DONE();
134 
135 	TEST_START("sshbuf_get_bignum2 truncated");
136 	MKBN(hexbn1, bn);
137 	p1 = sshbuf_new();
138 	ASSERT_PTR_NE(p1, NULL);
139 	ASSERT_INT_EQ(sshbuf_put_u32(p1, BN_num_bytes(bn)), 0);
140 	ASSERT_INT_EQ(sshbuf_put(p1, expbn1, sizeof(expbn1) - 1), 0);
141 	bn2 = NULL;
142 	r = sshbuf_get_bignum2(p1, &bn2);
143 	ASSERT_INT_EQ(r, SSH_ERR_MESSAGE_INCOMPLETE);
144 	ASSERT_SIZE_T_EQ(sshbuf_len(p1), sizeof(expbn1) + 3);
145 	BN_free(bn);
146 	BN_free(bn2);
147 	sshbuf_free(p1);
148 	TEST_DONE();
149 
150 	TEST_START("sshbuf_get_bignum2 giant");
151 	MKBN(hexbn1, bn);
152 	p1 = sshbuf_new();
153 	ASSERT_PTR_NE(p1, NULL);
154 	ASSERT_INT_EQ(sshbuf_put_u32(p1, 65536), 0);
155 	ASSERT_INT_EQ(sshbuf_reserve(p1, 65536, NULL), 0);
156 	bn2 = NULL;
157 	r = sshbuf_get_bignum2(p1, &bn2);
158 	ASSERT_INT_EQ(r, SSH_ERR_BIGNUM_TOO_LARGE);
159 	ASSERT_SIZE_T_EQ(sshbuf_len(p1), 65536 + 4);
160 	BN_free(bn);
161 	BN_free(bn2);
162 	sshbuf_free(p1);
163 	TEST_DONE();
164 
165 	TEST_START("sshbuf_get_bignum2 bn2");
166 	MKBN(hexbn2, bn);
167 	p1 = sshbuf_new();
168 	ASSERT_PTR_NE(p1, NULL);
169 	ASSERT_INT_EQ(sshbuf_put_u32(p1, BN_num_bytes(bn) + 1), 0); /* MSB */
170 	ASSERT_INT_EQ(sshbuf_put_u8(p1, 0x00), 0);
171 	ASSERT_INT_EQ(sshbuf_put(p1, expbn2, sizeof(expbn2)), 0);
172 	ASSERT_SIZE_T_EQ(sshbuf_len(p1), 4 + 1 + sizeof(expbn2));
173 	ASSERT_INT_EQ(sshbuf_put_u16(p1, 0xd00f), 0);
174 	bn2 = NULL;
175 	ASSERT_INT_EQ(sshbuf_get_bignum2(p1, &bn2), 0);
176 	ASSERT_BIGNUM_EQ(bn, bn2);
177 	ASSERT_SIZE_T_EQ(sshbuf_len(p1), 2);
178 	BN_free(bn);
179 	BN_free(bn2);
180 	sshbuf_free(p1);
181 	TEST_DONE();
182 
183 	TEST_START("sshbuf_get_bignum2 bn2 truncated");
184 	MKBN(hexbn2, bn);
185 	p1 = sshbuf_new();
186 	ASSERT_PTR_NE(p1, NULL);
187 	ASSERT_INT_EQ(sshbuf_put_u32(p1, BN_num_bytes(bn) + 1), 0);
188 	ASSERT_INT_EQ(sshbuf_put_u8(p1, 0x00), 0);
189 	ASSERT_INT_EQ(sshbuf_put(p1, expbn2, sizeof(expbn2) - 1), 0);
190 	bn2 = NULL;
191 	r = sshbuf_get_bignum2(p1, &bn2);
192 	ASSERT_INT_EQ(r, SSH_ERR_MESSAGE_INCOMPLETE);
193 	ASSERT_SIZE_T_EQ(sshbuf_len(p1), sizeof(expbn2) + 1 + 4 - 1);
194 	BN_free(bn);
195 	BN_free(bn2);
196 	sshbuf_free(p1);
197 	TEST_DONE();
198 
199 	TEST_START("sshbuf_get_bignum2 bn2 negative");
200 	MKBN(hexbn2, bn);
201 	p1 = sshbuf_new();
202 	ASSERT_PTR_NE(p1, NULL);
203 	ASSERT_INT_EQ(sshbuf_put_u32(p1, BN_num_bytes(bn)), 0);
204 	ASSERT_INT_EQ(sshbuf_put(p1, expbn2, sizeof(expbn2)), 0);
205 	bn2 = NULL;
206 	r = sshbuf_get_bignum2(p1, &bn2);
207 	ASSERT_INT_EQ(r, SSH_ERR_BIGNUM_IS_NEGATIVE);
208 	ASSERT_SIZE_T_EQ(sshbuf_len(p1), sizeof(expbn2) + 4);
209 	BN_free(bn);
210 	BN_free(bn2);
211 	sshbuf_free(p1);
212 	TEST_DONE();
213 
214 	TEST_START("sshbuf_put_ec");
215 	eck = EC_KEY_new_by_curve_name(ec256_nid);
216 	ASSERT_PTR_NE(eck, NULL);
217 	ecp = EC_POINT_new(EC_KEY_get0_group(eck));
218 	ASSERT_PTR_NE(ecp, NULL);
219 	MKBN(ec256_x, bn_x);
220 	MKBN(ec256_y, bn_y);
221 	ASSERT_INT_EQ(EC_POINT_set_affine_coordinates_GFp(
222 	    EC_KEY_get0_group(eck), ecp, bn_x, bn_y, NULL), 1);
223 	ASSERT_INT_EQ(EC_KEY_set_public_key(eck, ecp), 1);
224 	BN_free(bn_x);
225 	BN_free(bn_y);
226 	EC_POINT_free(ecp);
227 	p1 = sshbuf_new();
228 	ASSERT_PTR_NE(p1, NULL);
229 	ASSERT_INT_EQ(sshbuf_put_eckey(p1, eck), 0);
230 	ASSERT_INT_EQ(sshbuf_get_string_direct(p1, &d, &s), 0);
231 	ASSERT_SIZE_T_EQ(s, sizeof(expec256));
232 	ASSERT_MEM_EQ(d, expec256, sizeof(expec256));
233 	sshbuf_free(p1);
234 	EC_KEY_free(eck);
235 	TEST_DONE();
236 
237 	TEST_START("sshbuf_get_ec");
238 	eck = EC_KEY_new_by_curve_name(ec256_nid);
239 	ASSERT_PTR_NE(eck, NULL);
240 	p1 = sshbuf_new();
241 	ASSERT_PTR_NE(p1, NULL);
242 	ASSERT_INT_EQ(sshbuf_put_string(p1, expec256, sizeof(expec256)), 0);
243 	ASSERT_SIZE_T_EQ(sshbuf_len(p1), sizeof(expec256) + 4);
244 	ASSERT_INT_EQ(sshbuf_put_u8(p1, 0x00), 0);
245 	ASSERT_INT_EQ(sshbuf_get_eckey(p1, eck), 0);
246 	bn_x = BN_new();
247 	bn_y = BN_new();
248 	ASSERT_PTR_NE(bn_x, NULL);
249 	ASSERT_PTR_NE(bn_y, NULL);
250 	ASSERT_INT_EQ(EC_POINT_get_affine_coordinates_GFp(
251 	    EC_KEY_get0_group(eck), EC_KEY_get0_public_key(eck),
252 	    bn_x, bn_y, NULL), 1);
253 	MKBN(ec256_x, bn);
254 	MKBN(ec256_y, bn2);
255 	ASSERT_INT_EQ(BN_cmp(bn_x, bn), 0);
256 	ASSERT_INT_EQ(BN_cmp(bn_y, bn2), 0);
257 	ASSERT_SIZE_T_EQ(sshbuf_len(p1), 1);
258 	sshbuf_free(p1);
259 	EC_KEY_free(eck);
260 	BN_free(bn_x);
261 	BN_free(bn_y);
262 	BN_free(bn);
263 	BN_free(bn2);
264 	TEST_DONE();
265 }
266 
267