xref: /qemu/qemu-bridge-helper.c (revision d38ea87a)
17b93fadfSCorey Bryant /*
27b93fadfSCorey Bryant  * QEMU Bridge Helper
37b93fadfSCorey Bryant  *
47b93fadfSCorey Bryant  * Copyright IBM, Corp. 2011
57b93fadfSCorey Bryant  *
67b93fadfSCorey Bryant  * Authors:
77b93fadfSCorey Bryant  * Anthony Liguori   <aliguori@us.ibm.com>
87b93fadfSCorey Bryant  * Richa Marwaha     <rmarwah@linux.vnet.ibm.com>
97b93fadfSCorey Bryant  * Corey Bryant      <coreyb@linux.vnet.ibm.com>
107b93fadfSCorey Bryant  *
117b93fadfSCorey Bryant  * This work is licensed under the terms of the GNU GPL, version 2.  See
127b93fadfSCorey Bryant  * the COPYING file in the top-level directory.
137b93fadfSCorey Bryant  *
147b93fadfSCorey Bryant  */
157b93fadfSCorey Bryant 
16*d38ea87aSPeter Maydell #include "qemu/osdep.h"
177b93fadfSCorey Bryant 
18bdef79a2SCorey Bryant #include <glib.h>
197b93fadfSCorey Bryant 
207b93fadfSCorey Bryant #include <sys/ioctl.h>
217b93fadfSCorey Bryant #include <sys/socket.h>
227b93fadfSCorey Bryant #include <sys/un.h>
237b93fadfSCorey Bryant #include <sys/prctl.h>
247b93fadfSCorey Bryant 
257b93fadfSCorey Bryant #include <net/if.h>
267b93fadfSCorey Bryant 
277b93fadfSCorey Bryant #include <linux/sockios.h>
287b93fadfSCorey Bryant 
2934309d2bSCorey Bryant #ifndef SIOCBRADDIF
3034309d2bSCorey Bryant #include <linux/if_bridge.h>
3134309d2bSCorey Bryant #endif
3234309d2bSCorey Bryant 
331de7afc9SPaolo Bonzini #include "qemu/queue.h"
34bdef79a2SCorey Bryant 
357b93fadfSCorey Bryant #include "net/tap-linux.h"
367b93fadfSCorey Bryant 
3747e98658SCorey Bryant #ifdef CONFIG_LIBCAP
3847e98658SCorey Bryant #include <cap-ng.h>
3947e98658SCorey Bryant #endif
4047e98658SCorey Bryant 
41bdef79a2SCorey Bryant #define DEFAULT_ACL_FILE CONFIG_QEMU_CONFDIR "/bridge.conf"
42bdef79a2SCorey Bryant 
43bdef79a2SCorey Bryant enum {
44bdef79a2SCorey Bryant     ACL_ALLOW = 0,
45bdef79a2SCorey Bryant     ACL_ALLOW_ALL,
46bdef79a2SCorey Bryant     ACL_DENY,
47bdef79a2SCorey Bryant     ACL_DENY_ALL,
48bdef79a2SCorey Bryant };
49bdef79a2SCorey Bryant 
50bdef79a2SCorey Bryant typedef struct ACLRule {
51bdef79a2SCorey Bryant     int type;
52bdef79a2SCorey Bryant     char iface[IFNAMSIZ];
53bdef79a2SCorey Bryant     QSIMPLEQ_ENTRY(ACLRule) entry;
54bdef79a2SCorey Bryant } ACLRule;
55bdef79a2SCorey Bryant 
56bdef79a2SCorey Bryant typedef QSIMPLEQ_HEAD(ACLList, ACLRule) ACLList;
57bdef79a2SCorey Bryant 
587b93fadfSCorey Bryant static void usage(void)
597b93fadfSCorey Bryant {
607b93fadfSCorey Bryant     fprintf(stderr,
617b93fadfSCorey Bryant             "Usage: qemu-bridge-helper [--use-vnet] --br=bridge --fd=unixfd\n");
627b93fadfSCorey Bryant }
637b93fadfSCorey Bryant 
64bdef79a2SCorey Bryant static int parse_acl_file(const char *filename, ACLList *acl_list)
65bdef79a2SCorey Bryant {
66bdef79a2SCorey Bryant     FILE *f;
67bdef79a2SCorey Bryant     char line[4096];
68bdef79a2SCorey Bryant     ACLRule *acl_rule;
69bdef79a2SCorey Bryant 
70bdef79a2SCorey Bryant     f = fopen(filename, "r");
71bdef79a2SCorey Bryant     if (f == NULL) {
72bdef79a2SCorey Bryant         return -1;
73bdef79a2SCorey Bryant     }
74bdef79a2SCorey Bryant 
75bdef79a2SCorey Bryant     while (fgets(line, sizeof(line), f) != NULL) {
76bdef79a2SCorey Bryant         char *ptr = line;
77bdef79a2SCorey Bryant         char *cmd, *arg, *argend;
78bdef79a2SCorey Bryant 
79bdef79a2SCorey Bryant         while (isspace(*ptr)) {
80bdef79a2SCorey Bryant             ptr++;
81bdef79a2SCorey Bryant         }
82bdef79a2SCorey Bryant 
83bdef79a2SCorey Bryant         /* skip comments and empty lines */
84bdef79a2SCorey Bryant         if (*ptr == '#' || *ptr == 0) {
85bdef79a2SCorey Bryant             continue;
86bdef79a2SCorey Bryant         }
87bdef79a2SCorey Bryant 
88bdef79a2SCorey Bryant         cmd = ptr;
89bdef79a2SCorey Bryant         arg = strchr(cmd, ' ');
90bdef79a2SCorey Bryant         if (arg == NULL) {
91bdef79a2SCorey Bryant             arg = strchr(cmd, '\t');
92bdef79a2SCorey Bryant         }
93bdef79a2SCorey Bryant 
94bdef79a2SCorey Bryant         if (arg == NULL) {
95bdef79a2SCorey Bryant             fprintf(stderr, "Invalid config line:\n  %s\n", line);
96bdef79a2SCorey Bryant             fclose(f);
97bdef79a2SCorey Bryant             errno = EINVAL;
98bdef79a2SCorey Bryant             return -1;
99bdef79a2SCorey Bryant         }
100bdef79a2SCorey Bryant 
101bdef79a2SCorey Bryant         *arg = 0;
102bdef79a2SCorey Bryant         arg++;
103bdef79a2SCorey Bryant         while (isspace(*arg)) {
104bdef79a2SCorey Bryant             arg++;
105bdef79a2SCorey Bryant         }
106bdef79a2SCorey Bryant 
107bdef79a2SCorey Bryant         argend = arg + strlen(arg);
108bdef79a2SCorey Bryant         while (arg != argend && isspace(*(argend - 1))) {
109bdef79a2SCorey Bryant             argend--;
110bdef79a2SCorey Bryant         }
111bdef79a2SCorey Bryant         *argend = 0;
112bdef79a2SCorey Bryant 
113bdef79a2SCorey Bryant         if (strcmp(cmd, "deny") == 0) {
114bdef79a2SCorey Bryant             acl_rule = g_malloc(sizeof(*acl_rule));
115bdef79a2SCorey Bryant             if (strcmp(arg, "all") == 0) {
116bdef79a2SCorey Bryant                 acl_rule->type = ACL_DENY_ALL;
117bdef79a2SCorey Bryant             } else {
118bdef79a2SCorey Bryant                 acl_rule->type = ACL_DENY;
119bdef79a2SCorey Bryant                 snprintf(acl_rule->iface, IFNAMSIZ, "%s", arg);
120bdef79a2SCorey Bryant             }
121bdef79a2SCorey Bryant             QSIMPLEQ_INSERT_TAIL(acl_list, acl_rule, entry);
122bdef79a2SCorey Bryant         } else if (strcmp(cmd, "allow") == 0) {
123bdef79a2SCorey Bryant             acl_rule = g_malloc(sizeof(*acl_rule));
124bdef79a2SCorey Bryant             if (strcmp(arg, "all") == 0) {
125bdef79a2SCorey Bryant                 acl_rule->type = ACL_ALLOW_ALL;
126bdef79a2SCorey Bryant             } else {
127bdef79a2SCorey Bryant                 acl_rule->type = ACL_ALLOW;
128bdef79a2SCorey Bryant                 snprintf(acl_rule->iface, IFNAMSIZ, "%s", arg);
129bdef79a2SCorey Bryant             }
130bdef79a2SCorey Bryant             QSIMPLEQ_INSERT_TAIL(acl_list, acl_rule, entry);
131bdef79a2SCorey Bryant         } else if (strcmp(cmd, "include") == 0) {
132bdef79a2SCorey Bryant             /* ignore errors */
133bdef79a2SCorey Bryant             parse_acl_file(arg, acl_list);
134bdef79a2SCorey Bryant         } else {
135bdef79a2SCorey Bryant             fprintf(stderr, "Unknown command `%s'\n", cmd);
136bdef79a2SCorey Bryant             fclose(f);
137bdef79a2SCorey Bryant             errno = EINVAL;
138bdef79a2SCorey Bryant             return -1;
139bdef79a2SCorey Bryant         }
140bdef79a2SCorey Bryant     }
141bdef79a2SCorey Bryant 
142bdef79a2SCorey Bryant     fclose(f);
143bdef79a2SCorey Bryant 
144bdef79a2SCorey Bryant     return 0;
145bdef79a2SCorey Bryant }
146bdef79a2SCorey Bryant 
1477b93fadfSCorey Bryant static bool has_vnet_hdr(int fd)
1487b93fadfSCorey Bryant {
1497b93fadfSCorey Bryant     unsigned int features = 0;
1507b93fadfSCorey Bryant 
1517b93fadfSCorey Bryant     if (ioctl(fd, TUNGETFEATURES, &features) == -1) {
1527b93fadfSCorey Bryant         return false;
1537b93fadfSCorey Bryant     }
1547b93fadfSCorey Bryant 
1557b93fadfSCorey Bryant     if (!(features & IFF_VNET_HDR)) {
1567b93fadfSCorey Bryant         return false;
1577b93fadfSCorey Bryant     }
1587b93fadfSCorey Bryant 
1597b93fadfSCorey Bryant     return true;
1607b93fadfSCorey Bryant }
1617b93fadfSCorey Bryant 
1627b93fadfSCorey Bryant static void prep_ifreq(struct ifreq *ifr, const char *ifname)
1637b93fadfSCorey Bryant {
1647b93fadfSCorey Bryant     memset(ifr, 0, sizeof(*ifr));
1657b93fadfSCorey Bryant     snprintf(ifr->ifr_name, IFNAMSIZ, "%s", ifname);
1667b93fadfSCorey Bryant }
1677b93fadfSCorey Bryant 
1687b93fadfSCorey Bryant static int send_fd(int c, int fd)
1697b93fadfSCorey Bryant {
1707b93fadfSCorey Bryant     char msgbuf[CMSG_SPACE(sizeof(fd))];
1717b93fadfSCorey Bryant     struct msghdr msg = {
1727b93fadfSCorey Bryant         .msg_control = msgbuf,
1737b93fadfSCorey Bryant         .msg_controllen = sizeof(msgbuf),
1747b93fadfSCorey Bryant     };
1757b93fadfSCorey Bryant     struct cmsghdr *cmsg;
1767b93fadfSCorey Bryant     struct iovec iov;
1777b93fadfSCorey Bryant     char req[1] = { 0x00 };
1787b93fadfSCorey Bryant 
1797b93fadfSCorey Bryant     cmsg = CMSG_FIRSTHDR(&msg);
1807b93fadfSCorey Bryant     cmsg->cmsg_level = SOL_SOCKET;
1817b93fadfSCorey Bryant     cmsg->cmsg_type = SCM_RIGHTS;
1827b93fadfSCorey Bryant     cmsg->cmsg_len = CMSG_LEN(sizeof(fd));
1837b93fadfSCorey Bryant     msg.msg_controllen = cmsg->cmsg_len;
1847b93fadfSCorey Bryant 
1857b93fadfSCorey Bryant     iov.iov_base = req;
1867b93fadfSCorey Bryant     iov.iov_len = sizeof(req);
1877b93fadfSCorey Bryant 
1887b93fadfSCorey Bryant     msg.msg_iov = &iov;
1897b93fadfSCorey Bryant     msg.msg_iovlen = 1;
1907b93fadfSCorey Bryant     memcpy(CMSG_DATA(cmsg), &fd, sizeof(fd));
1917b93fadfSCorey Bryant 
1927b93fadfSCorey Bryant     return sendmsg(c, &msg, 0);
1937b93fadfSCorey Bryant }
1947b93fadfSCorey Bryant 
19547e98658SCorey Bryant #ifdef CONFIG_LIBCAP
19647e98658SCorey Bryant static int drop_privileges(void)
19747e98658SCorey Bryant {
19847e98658SCorey Bryant     /* clear all capabilities */
19947e98658SCorey Bryant     capng_clear(CAPNG_SELECT_BOTH);
20047e98658SCorey Bryant 
20147e98658SCorey Bryant     if (capng_update(CAPNG_ADD, CAPNG_EFFECTIVE | CAPNG_PERMITTED,
20247e98658SCorey Bryant                      CAP_NET_ADMIN) < 0) {
20347e98658SCorey Bryant         return -1;
20447e98658SCorey Bryant     }
20547e98658SCorey Bryant 
20647e98658SCorey Bryant     /* change to calling user's real uid and gid, retaining supplemental
20747e98658SCorey Bryant      * groups and CAP_NET_ADMIN */
20847e98658SCorey Bryant     if (capng_change_id(getuid(), getgid(), CAPNG_CLEAR_BOUNDING)) {
20947e98658SCorey Bryant         return -1;
21047e98658SCorey Bryant     }
21147e98658SCorey Bryant 
21247e98658SCorey Bryant     return 0;
21347e98658SCorey Bryant }
21447e98658SCorey Bryant #endif
21547e98658SCorey Bryant 
2167b93fadfSCorey Bryant int main(int argc, char **argv)
2177b93fadfSCorey Bryant {
2187b93fadfSCorey Bryant     struct ifreq ifr;
21934309d2bSCorey Bryant #ifndef SIOCBRADDIF
22034309d2bSCorey Bryant     unsigned long ifargs[4];
22134309d2bSCorey Bryant #endif
22234309d2bSCorey Bryant     int ifindex;
223eb3f45c5SGonglei     int fd = -1, ctlfd = -1, unixfd = -1;
2247b93fadfSCorey Bryant     int use_vnet = 0;
2257b93fadfSCorey Bryant     int mtu;
2267b93fadfSCorey Bryant     const char *bridge = NULL;
2277b93fadfSCorey Bryant     char iface[IFNAMSIZ];
2287b93fadfSCorey Bryant     int index;
229bdef79a2SCorey Bryant     ACLRule *acl_rule;
230bdef79a2SCorey Bryant     ACLList acl_list;
231bdef79a2SCorey Bryant     int access_allowed, access_denied;
2327b93fadfSCorey Bryant     int ret = EXIT_SUCCESS;
2337b93fadfSCorey Bryant 
23447e98658SCorey Bryant #ifdef CONFIG_LIBCAP
23547e98658SCorey Bryant     /* if we're run from an suid binary, immediately drop privileges preserving
23647e98658SCorey Bryant      * cap_net_admin */
23747e98658SCorey Bryant     if (geteuid() == 0 && getuid() != geteuid()) {
23847e98658SCorey Bryant         if (drop_privileges() == -1) {
23947e98658SCorey Bryant             fprintf(stderr, "failed to drop privileges\n");
24047e98658SCorey Bryant             return 1;
24147e98658SCorey Bryant         }
24247e98658SCorey Bryant     }
24347e98658SCorey Bryant #endif
24447e98658SCorey Bryant 
2457b93fadfSCorey Bryant     /* parse arguments */
2467b93fadfSCorey Bryant     for (index = 1; index < argc; index++) {
2477b93fadfSCorey Bryant         if (strcmp(argv[index], "--use-vnet") == 0) {
2487b93fadfSCorey Bryant             use_vnet = 1;
2497b93fadfSCorey Bryant         } else if (strncmp(argv[index], "--br=", 5) == 0) {
2507b93fadfSCorey Bryant             bridge = &argv[index][5];
2517b93fadfSCorey Bryant         } else if (strncmp(argv[index], "--fd=", 5) == 0) {
2527b93fadfSCorey Bryant             unixfd = atoi(&argv[index][5]);
2537b93fadfSCorey Bryant         } else {
2547b93fadfSCorey Bryant             usage();
2557b93fadfSCorey Bryant             return EXIT_FAILURE;
2567b93fadfSCorey Bryant         }
2577b93fadfSCorey Bryant     }
2587b93fadfSCorey Bryant 
2597b93fadfSCorey Bryant     if (bridge == NULL || unixfd == -1) {
2607b93fadfSCorey Bryant         usage();
2617b93fadfSCorey Bryant         return EXIT_FAILURE;
2627b93fadfSCorey Bryant     }
2637b93fadfSCorey Bryant 
264bdef79a2SCorey Bryant     /* parse default acl file */
265bdef79a2SCorey Bryant     QSIMPLEQ_INIT(&acl_list);
266bdef79a2SCorey Bryant     if (parse_acl_file(DEFAULT_ACL_FILE, &acl_list) == -1) {
267bdef79a2SCorey Bryant         fprintf(stderr, "failed to parse default acl file `%s'\n",
268bdef79a2SCorey Bryant                 DEFAULT_ACL_FILE);
269bdef79a2SCorey Bryant         ret = EXIT_FAILURE;
270bdef79a2SCorey Bryant         goto cleanup;
271bdef79a2SCorey Bryant     }
272bdef79a2SCorey Bryant 
273bdef79a2SCorey Bryant     /* validate bridge against acl -- default policy is to deny
274bdef79a2SCorey Bryant      * according acl policy if we have a deny and allow both
275bdef79a2SCorey Bryant      * then deny should always win over allow
276bdef79a2SCorey Bryant      */
277bdef79a2SCorey Bryant     access_allowed = 0;
278bdef79a2SCorey Bryant     access_denied = 0;
279bdef79a2SCorey Bryant     QSIMPLEQ_FOREACH(acl_rule, &acl_list, entry) {
280bdef79a2SCorey Bryant         switch (acl_rule->type) {
281bdef79a2SCorey Bryant         case ACL_ALLOW_ALL:
282bdef79a2SCorey Bryant             access_allowed = 1;
283bdef79a2SCorey Bryant             break;
284bdef79a2SCorey Bryant         case ACL_ALLOW:
285bdef79a2SCorey Bryant             if (strcmp(bridge, acl_rule->iface) == 0) {
286bdef79a2SCorey Bryant                 access_allowed = 1;
287bdef79a2SCorey Bryant             }
288bdef79a2SCorey Bryant             break;
289bdef79a2SCorey Bryant         case ACL_DENY_ALL:
290bdef79a2SCorey Bryant             access_denied = 1;
291bdef79a2SCorey Bryant             break;
292bdef79a2SCorey Bryant         case ACL_DENY:
293bdef79a2SCorey Bryant             if (strcmp(bridge, acl_rule->iface) == 0) {
294bdef79a2SCorey Bryant                 access_denied = 1;
295bdef79a2SCorey Bryant             }
296bdef79a2SCorey Bryant             break;
297bdef79a2SCorey Bryant         }
298bdef79a2SCorey Bryant     }
299bdef79a2SCorey Bryant 
300bdef79a2SCorey Bryant     if ((access_allowed == 0) || (access_denied == 1)) {
301bdef79a2SCorey Bryant         fprintf(stderr, "access denied by acl file\n");
302bdef79a2SCorey Bryant         ret = EXIT_FAILURE;
303bdef79a2SCorey Bryant         goto cleanup;
304bdef79a2SCorey Bryant     }
305bdef79a2SCorey Bryant 
3067b93fadfSCorey Bryant     /* open a socket to use to control the network interfaces */
3077b93fadfSCorey Bryant     ctlfd = socket(AF_INET, SOCK_STREAM, 0);
3087b93fadfSCorey Bryant     if (ctlfd == -1) {
3097b93fadfSCorey Bryant         fprintf(stderr, "failed to open control socket: %s\n", strerror(errno));
3107b93fadfSCorey Bryant         ret = EXIT_FAILURE;
3117b93fadfSCorey Bryant         goto cleanup;
3127b93fadfSCorey Bryant     }
3137b93fadfSCorey Bryant 
3147b93fadfSCorey Bryant     /* open the tap device */
3157b93fadfSCorey Bryant     fd = open("/dev/net/tun", O_RDWR);
3167b93fadfSCorey Bryant     if (fd == -1) {
3177b93fadfSCorey Bryant         fprintf(stderr, "failed to open /dev/net/tun: %s\n", strerror(errno));
3187b93fadfSCorey Bryant         ret = EXIT_FAILURE;
3197b93fadfSCorey Bryant         goto cleanup;
3207b93fadfSCorey Bryant     }
3217b93fadfSCorey Bryant 
3227b93fadfSCorey Bryant     /* request a tap device, disable PI, and add vnet header support if
3237b93fadfSCorey Bryant      * requested and it's available. */
3247b93fadfSCorey Bryant     prep_ifreq(&ifr, "tap%d");
3257b93fadfSCorey Bryant     ifr.ifr_flags = IFF_TAP|IFF_NO_PI;
3267b93fadfSCorey Bryant     if (use_vnet && has_vnet_hdr(fd)) {
3277b93fadfSCorey Bryant         ifr.ifr_flags |= IFF_VNET_HDR;
3287b93fadfSCorey Bryant     }
3297b93fadfSCorey Bryant 
3307b93fadfSCorey Bryant     if (ioctl(fd, TUNSETIFF, &ifr) == -1) {
3317b93fadfSCorey Bryant         fprintf(stderr, "failed to create tun device: %s\n", strerror(errno));
3327b93fadfSCorey Bryant         ret = EXIT_FAILURE;
3337b93fadfSCorey Bryant         goto cleanup;
3347b93fadfSCorey Bryant     }
3357b93fadfSCorey Bryant 
3367b93fadfSCorey Bryant     /* save tap device name */
3377b93fadfSCorey Bryant     snprintf(iface, sizeof(iface), "%s", ifr.ifr_name);
3387b93fadfSCorey Bryant 
3397b93fadfSCorey Bryant     /* get the mtu of the bridge */
3407b93fadfSCorey Bryant     prep_ifreq(&ifr, bridge);
3417b93fadfSCorey Bryant     if (ioctl(ctlfd, SIOCGIFMTU, &ifr) == -1) {
3427b93fadfSCorey Bryant         fprintf(stderr, "failed to get mtu of bridge `%s': %s\n",
3437b93fadfSCorey Bryant                 bridge, strerror(errno));
3447b93fadfSCorey Bryant         ret = EXIT_FAILURE;
3457b93fadfSCorey Bryant         goto cleanup;
3467b93fadfSCorey Bryant     }
3477b93fadfSCorey Bryant 
3487b93fadfSCorey Bryant     /* save mtu */
3497b93fadfSCorey Bryant     mtu = ifr.ifr_mtu;
3507b93fadfSCorey Bryant 
3517b93fadfSCorey Bryant     /* set the mtu of the interface based on the bridge */
3527b93fadfSCorey Bryant     prep_ifreq(&ifr, iface);
3537b93fadfSCorey Bryant     ifr.ifr_mtu = mtu;
3547b93fadfSCorey Bryant     if (ioctl(ctlfd, SIOCSIFMTU, &ifr) == -1) {
3557b93fadfSCorey Bryant         fprintf(stderr, "failed to set mtu of device `%s' to %d: %s\n",
3567b93fadfSCorey Bryant                 iface, mtu, strerror(errno));
3577b93fadfSCorey Bryant         ret = EXIT_FAILURE;
3587b93fadfSCorey Bryant         goto cleanup;
3597b93fadfSCorey Bryant     }
3607b93fadfSCorey Bryant 
361226ecabfSPaolo Bonzini     /* Linux uses the lowest enslaved MAC address as the MAC address of
362226ecabfSPaolo Bonzini      * the bridge.  Set MAC address to a high value so that it doesn't
363226ecabfSPaolo Bonzini      * affect the MAC address of the bridge.
364226ecabfSPaolo Bonzini      */
365226ecabfSPaolo Bonzini     if (ioctl(ctlfd, SIOCGIFHWADDR, &ifr) < 0) {
366226ecabfSPaolo Bonzini         fprintf(stderr, "failed to get MAC address of device `%s': %s\n",
367226ecabfSPaolo Bonzini                 iface, strerror(errno));
368226ecabfSPaolo Bonzini         ret = EXIT_FAILURE;
369226ecabfSPaolo Bonzini         goto cleanup;
370226ecabfSPaolo Bonzini     }
371226ecabfSPaolo Bonzini     ifr.ifr_hwaddr.sa_data[0] = 0xFE;
372226ecabfSPaolo Bonzini     if (ioctl(ctlfd, SIOCSIFHWADDR, &ifr) < 0) {
373226ecabfSPaolo Bonzini         fprintf(stderr, "failed to set MAC address of device `%s': %s\n",
374226ecabfSPaolo Bonzini                 iface, strerror(errno));
375226ecabfSPaolo Bonzini         ret = EXIT_FAILURE;
376226ecabfSPaolo Bonzini         goto cleanup;
377226ecabfSPaolo Bonzini     }
378226ecabfSPaolo Bonzini 
3797b93fadfSCorey Bryant     /* add the interface to the bridge */
3807b93fadfSCorey Bryant     prep_ifreq(&ifr, bridge);
38134309d2bSCorey Bryant     ifindex = if_nametoindex(iface);
38234309d2bSCorey Bryant #ifndef SIOCBRADDIF
38334309d2bSCorey Bryant     ifargs[0] = BRCTL_ADD_IF;
38434309d2bSCorey Bryant     ifargs[1] = ifindex;
38534309d2bSCorey Bryant     ifargs[2] = 0;
38634309d2bSCorey Bryant     ifargs[3] = 0;
38734309d2bSCorey Bryant     ifr.ifr_data = (void *)ifargs;
38834309d2bSCorey Bryant     ret = ioctl(ctlfd, SIOCDEVPRIVATE, &ifr);
38934309d2bSCorey Bryant #else
39034309d2bSCorey Bryant     ifr.ifr_ifindex = ifindex;
39134309d2bSCorey Bryant     ret = ioctl(ctlfd, SIOCBRADDIF, &ifr);
39234309d2bSCorey Bryant #endif
39334309d2bSCorey Bryant     if (ret == -1) {
3947b93fadfSCorey Bryant         fprintf(stderr, "failed to add interface `%s' to bridge `%s': %s\n",
3957b93fadfSCorey Bryant                 iface, bridge, strerror(errno));
3967b93fadfSCorey Bryant         ret = EXIT_FAILURE;
3977b93fadfSCorey Bryant         goto cleanup;
3987b93fadfSCorey Bryant     }
3997b93fadfSCorey Bryant 
4007b93fadfSCorey Bryant     /* bring the interface up */
4017b93fadfSCorey Bryant     prep_ifreq(&ifr, iface);
4027b93fadfSCorey Bryant     if (ioctl(ctlfd, SIOCGIFFLAGS, &ifr) == -1) {
4037b93fadfSCorey Bryant         fprintf(stderr, "failed to get interface flags for `%s': %s\n",
4047b93fadfSCorey Bryant                 iface, strerror(errno));
4057b93fadfSCorey Bryant         ret = EXIT_FAILURE;
4067b93fadfSCorey Bryant         goto cleanup;
4077b93fadfSCorey Bryant     }
4087b93fadfSCorey Bryant 
4097b93fadfSCorey Bryant     ifr.ifr_flags |= IFF_UP;
4107b93fadfSCorey Bryant     if (ioctl(ctlfd, SIOCSIFFLAGS, &ifr) == -1) {
4117b93fadfSCorey Bryant         fprintf(stderr, "failed to bring up interface `%s': %s\n",
4127b93fadfSCorey Bryant                 iface, strerror(errno));
4137b93fadfSCorey Bryant         ret = EXIT_FAILURE;
4147b93fadfSCorey Bryant         goto cleanup;
4157b93fadfSCorey Bryant     }
4167b93fadfSCorey Bryant 
4177b93fadfSCorey Bryant     /* write fd to the domain socket */
4187b93fadfSCorey Bryant     if (send_fd(unixfd, fd) == -1) {
4197b93fadfSCorey Bryant         fprintf(stderr, "failed to write fd to unix socket: %s\n",
4207b93fadfSCorey Bryant                 strerror(errno));
4217b93fadfSCorey Bryant         ret = EXIT_FAILURE;
4227b93fadfSCorey Bryant         goto cleanup;
4237b93fadfSCorey Bryant     }
4247b93fadfSCorey Bryant 
4257b93fadfSCorey Bryant     /* ... */
4267b93fadfSCorey Bryant 
4277b93fadfSCorey Bryant     /* profit! */
4287b93fadfSCorey Bryant 
4297b93fadfSCorey Bryant cleanup:
430eb3f45c5SGonglei     if (fd >= 0) {
431eb3f45c5SGonglei         close(fd);
432eb3f45c5SGonglei     }
433eb3f45c5SGonglei     if (ctlfd >= 0) {
434eb3f45c5SGonglei         close(ctlfd);
435eb3f45c5SGonglei     }
436bdef79a2SCorey Bryant     while ((acl_rule = QSIMPLEQ_FIRST(&acl_list)) != NULL) {
437bdef79a2SCorey Bryant         QSIMPLEQ_REMOVE_HEAD(&acl_list, entry);
438bdef79a2SCorey Bryant         g_free(acl_rule);
439bdef79a2SCorey Bryant     }
440bdef79a2SCorey Bryant 
4417b93fadfSCorey Bryant     return ret;
4427b93fadfSCorey Bryant }
443