1b7d5a9c2SKamil Rytarowski#!/usr/bin/env perl 21ec3f6f9SBlue Swirl# (c) 2001, Dave Jones. (the file handling bit) 31ec3f6f9SBlue Swirl# (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit) 41ec3f6f9SBlue Swirl# (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite) 51ec3f6f9SBlue Swirl# (c) 2008-2010 Andy Whitcroft <apw@canonical.com> 61ec3f6f9SBlue Swirl# Licensed under the terms of the GNU GPL License version 2 71ec3f6f9SBlue Swirl 81ec3f6f9SBlue Swirluse strict; 9b7d5a9c2SKamil Rytarowskiuse warnings; 101ec3f6f9SBlue Swirl 111ec3f6f9SBlue Swirlmy $P = $0; 121ec3f6f9SBlue Swirl$P =~ s@.*/@@g; 131ec3f6f9SBlue Swirl 14777d05baSPaolo Bonziniour $SrcFile = qr{\.(?:h|c|cpp|s|S|pl|py|sh)$}; 15777d05baSPaolo Bonzini 161ec3f6f9SBlue Swirlmy $V = '0.31'; 171ec3f6f9SBlue Swirl 181ec3f6f9SBlue Swirluse Getopt::Long qw(:config no_auto_abbrev); 191ec3f6f9SBlue Swirl 201ec3f6f9SBlue Swirlmy $quiet = 0; 211ec3f6f9SBlue Swirlmy $tree = 1; 221ec3f6f9SBlue Swirlmy $chk_signoff = 1; 238e1fe175SDaniel P. Berrangemy $chk_patch = undef; 248e1fe175SDaniel P. Berrangemy $chk_branch = undef; 251ec3f6f9SBlue Swirlmy $tst_only; 261ec3f6f9SBlue Swirlmy $emacs = 0; 271ec3f6f9SBlue Swirlmy $terse = 0; 288e1fe175SDaniel P. Berrangemy $file = undef; 29141de886SPaolo Bonzinimy $no_warnings = 0; 301ec3f6f9SBlue Swirlmy $summary = 1; 311ec3f6f9SBlue Swirlmy $mailback = 0; 321ec3f6f9SBlue Swirlmy $summary_file = 0; 331ec3f6f9SBlue Swirlmy $root; 341ec3f6f9SBlue Swirlmy %debug; 351ec3f6f9SBlue Swirlmy $help = 0; 361ec3f6f9SBlue Swirl 371ec3f6f9SBlue Swirlsub help { 381ec3f6f9SBlue Swirl my ($exitcode) = @_; 391ec3f6f9SBlue Swirl 401ec3f6f9SBlue Swirl print << "EOM"; 418e1fe175SDaniel P. BerrangeUsage: 428e1fe175SDaniel P. Berrange 438e1fe175SDaniel P. Berrange $P [OPTION]... [FILE]... 448e1fe175SDaniel P. Berrange $P [OPTION]... [GIT-REV-LIST] 458e1fe175SDaniel P. Berrange 461ec3f6f9SBlue SwirlVersion: $V 471ec3f6f9SBlue Swirl 481ec3f6f9SBlue SwirlOptions: 491ec3f6f9SBlue Swirl -q, --quiet quiet 501ec3f6f9SBlue Swirl --no-tree run without a kernel tree 511ec3f6f9SBlue Swirl --no-signoff do not check for 'Signed-off-by' line 528e1fe175SDaniel P. Berrange --patch treat FILE as patchfile 538e1fe175SDaniel P. Berrange --branch treat args as GIT revision list 541ec3f6f9SBlue Swirl --emacs emacs compile window format 551ec3f6f9SBlue Swirl --terse one line per report 561ec3f6f9SBlue Swirl -f, --file treat FILE as regular source file 57141de886SPaolo Bonzini --strict fail if only warnings are found 581ec3f6f9SBlue Swirl --root=PATH PATH to the kernel tree root 591ec3f6f9SBlue Swirl --no-summary suppress the per-file summary 601ec3f6f9SBlue Swirl --mailback only produce a report in case of warnings/errors 611ec3f6f9SBlue Swirl --summary-file include the filename in summary 621ec3f6f9SBlue Swirl --debug KEY=[0|1] turn on/off debugging of KEY, where KEY is one of 631ec3f6f9SBlue Swirl 'values', 'possible', 'type', and 'attr' (default 641ec3f6f9SBlue Swirl is all off) 651ec3f6f9SBlue Swirl --test-only=WORD report only warnings/errors containing WORD 661ec3f6f9SBlue Swirl literally 671ec3f6f9SBlue Swirl -h, --help, --version display this help and exit 681ec3f6f9SBlue Swirl 691ec3f6f9SBlue SwirlWhen FILE is - read standard input. 701ec3f6f9SBlue SwirlEOM 711ec3f6f9SBlue Swirl 721ec3f6f9SBlue Swirl exit($exitcode); 731ec3f6f9SBlue Swirl} 741ec3f6f9SBlue Swirl 751ec3f6f9SBlue SwirlGetOptions( 761ec3f6f9SBlue Swirl 'q|quiet+' => \$quiet, 771ec3f6f9SBlue Swirl 'tree!' => \$tree, 781ec3f6f9SBlue Swirl 'signoff!' => \$chk_signoff, 791ec3f6f9SBlue Swirl 'patch!' => \$chk_patch, 808e1fe175SDaniel P. Berrange 'branch!' => \$chk_branch, 811ec3f6f9SBlue Swirl 'emacs!' => \$emacs, 821ec3f6f9SBlue Swirl 'terse!' => \$terse, 831ec3f6f9SBlue Swirl 'f|file!' => \$file, 84141de886SPaolo Bonzini 'strict!' => \$no_warnings, 851ec3f6f9SBlue Swirl 'root=s' => \$root, 861ec3f6f9SBlue Swirl 'summary!' => \$summary, 871ec3f6f9SBlue Swirl 'mailback!' => \$mailback, 881ec3f6f9SBlue Swirl 'summary-file!' => \$summary_file, 891ec3f6f9SBlue Swirl 901ec3f6f9SBlue Swirl 'debug=s' => \%debug, 911ec3f6f9SBlue Swirl 'test-only=s' => \$tst_only, 921ec3f6f9SBlue Swirl 'h|help' => \$help, 931ec3f6f9SBlue Swirl 'version' => \$help 941ec3f6f9SBlue Swirl) or help(1); 951ec3f6f9SBlue Swirl 961ec3f6f9SBlue Swirlhelp(0) if ($help); 971ec3f6f9SBlue Swirl 981ec3f6f9SBlue Swirlmy $exit = 0; 991ec3f6f9SBlue Swirl 1001ec3f6f9SBlue Swirlif ($#ARGV < 0) { 1011ec3f6f9SBlue Swirl print "$P: no input files\n"; 1021ec3f6f9SBlue Swirl exit(1); 1031ec3f6f9SBlue Swirl} 1041ec3f6f9SBlue Swirl 1058e1fe175SDaniel P. Berrangeif (!defined $chk_branch && !defined $chk_patch && !defined $file) { 106777d05baSPaolo Bonzini $chk_branch = $ARGV[0] =~ /.\.\./ ? 1 : 0; 107777d05baSPaolo Bonzini $file = $ARGV[0] =~ /$SrcFile/ ? 1 : 0; 108777d05baSPaolo Bonzini $chk_patch = $chk_branch || $file ? 0 : 1; 1098e1fe175SDaniel P. Berrange} elsif (!defined $chk_branch && !defined $chk_patch) { 1108e1fe175SDaniel P. Berrange if ($file) { 1118e1fe175SDaniel P. Berrange $chk_branch = $chk_patch = 0; 1128e1fe175SDaniel P. Berrange } else { 113777d05baSPaolo Bonzini $chk_branch = $ARGV[0] =~ /.\.\./ ? 1 : 0; 1148e1fe175SDaniel P. Berrange $chk_patch = $chk_branch ? 0 : 1; 1158e1fe175SDaniel P. Berrange } 1168e1fe175SDaniel P. Berrange} elsif (!defined $chk_branch && !defined $file) { 1178e1fe175SDaniel P. Berrange if ($chk_patch) { 1188e1fe175SDaniel P. Berrange $chk_branch = $file = 0; 1198e1fe175SDaniel P. Berrange } else { 120777d05baSPaolo Bonzini $chk_branch = $ARGV[0] =~ /.\.\./ ? 1 : 0; 1218e1fe175SDaniel P. Berrange $file = $chk_branch ? 0 : 1; 1228e1fe175SDaniel P. Berrange } 1238e1fe175SDaniel P. Berrange} elsif (!defined $chk_patch && !defined $file) { 1248e1fe175SDaniel P. Berrange if ($chk_branch) { 1258e1fe175SDaniel P. Berrange $chk_patch = $file = 0; 1268e1fe175SDaniel P. Berrange } else { 127777d05baSPaolo Bonzini $file = $ARGV[0] =~ /$SrcFile/ ? 1 : 0; 128777d05baSPaolo Bonzini $chk_patch = $file ? 0 : 1; 1298e1fe175SDaniel P. Berrange } 1308e1fe175SDaniel P. Berrange} elsif (!defined $chk_branch) { 1318e1fe175SDaniel P. Berrange $chk_branch = $chk_patch || $file ? 0 : 1; 1328e1fe175SDaniel P. Berrange} elsif (!defined $chk_patch) { 1338e1fe175SDaniel P. Berrange $chk_patch = $chk_branch || $file ? 0 : 1; 1348e1fe175SDaniel P. Berrange} elsif (!defined $file) { 1358e1fe175SDaniel P. Berrange $file = $chk_patch || $chk_branch ? 0 : 1; 1368e1fe175SDaniel P. Berrange} 1378e1fe175SDaniel P. Berrange 1388e1fe175SDaniel P. Berrangeif (($chk_patch && $chk_branch) || 1398e1fe175SDaniel P. Berrange ($chk_patch && $file) || 1408e1fe175SDaniel P. Berrange ($chk_branch && $file)) { 1418e1fe175SDaniel P. Berrange die "Only one of --file, --branch, --patch is permitted\n"; 1428e1fe175SDaniel P. Berrange} 1438e1fe175SDaniel P. Berrangeif (!$chk_patch && !$chk_branch && !$file) { 1448e1fe175SDaniel P. Berrange die "One of --file, --branch, --patch is required\n"; 1458e1fe175SDaniel P. Berrange} 1468e1fe175SDaniel P. Berrange 1471ec3f6f9SBlue Swirlmy $dbg_values = 0; 1481ec3f6f9SBlue Swirlmy $dbg_possible = 0; 1491ec3f6f9SBlue Swirlmy $dbg_type = 0; 1501ec3f6f9SBlue Swirlmy $dbg_attr = 0; 151a99ac041SDon Slutzmy $dbg_adv_dcs = 0; 1525424302eSDon Slutzmy $dbg_adv_checking = 0; 15369402a69SDon Slutzmy $dbg_adv_apw = 0; 1541ec3f6f9SBlue Swirlfor my $key (keys %debug) { 1551ec3f6f9SBlue Swirl ## no critic 1561ec3f6f9SBlue Swirl eval "\${dbg_$key} = '$debug{$key}';"; 1571ec3f6f9SBlue Swirl die "$@" if ($@); 1581ec3f6f9SBlue Swirl} 1591ec3f6f9SBlue Swirl 1601ec3f6f9SBlue Swirlmy $rpt_cleaners = 0; 1611ec3f6f9SBlue Swirl 1621ec3f6f9SBlue Swirlif ($terse) { 1631ec3f6f9SBlue Swirl $emacs = 1; 1641ec3f6f9SBlue Swirl $quiet++; 1651ec3f6f9SBlue Swirl} 1661ec3f6f9SBlue Swirl 1671ec3f6f9SBlue Swirlif ($tree) { 1681ec3f6f9SBlue Swirl if (defined $root) { 1691ec3f6f9SBlue Swirl if (!top_of_kernel_tree($root)) { 1701ec3f6f9SBlue Swirl die "$P: $root: --root does not point at a valid tree\n"; 1711ec3f6f9SBlue Swirl } 1721ec3f6f9SBlue Swirl } else { 1731ec3f6f9SBlue Swirl if (top_of_kernel_tree('.')) { 1741ec3f6f9SBlue Swirl $root = '.'; 1751ec3f6f9SBlue Swirl } elsif ($0 =~ m@(.*)/scripts/[^/]*$@ && 1761ec3f6f9SBlue Swirl top_of_kernel_tree($1)) { 1771ec3f6f9SBlue Swirl $root = $1; 1781ec3f6f9SBlue Swirl } 1791ec3f6f9SBlue Swirl } 1801ec3f6f9SBlue Swirl 1811ec3f6f9SBlue Swirl if (!defined $root) { 1821ec3f6f9SBlue Swirl print "Must be run from the top-level dir. of a kernel tree\n"; 1831ec3f6f9SBlue Swirl exit(2); 1841ec3f6f9SBlue Swirl } 1851ec3f6f9SBlue Swirl} 1861ec3f6f9SBlue Swirl 1871ec3f6f9SBlue Swirlmy $emitted_corrupt = 0; 1881ec3f6f9SBlue Swirl 1891ec3f6f9SBlue Swirlour $Ident = qr{ 1901ec3f6f9SBlue Swirl [A-Za-z_][A-Za-z\d_]* 1911ec3f6f9SBlue Swirl (?:\s*\#\#\s*[A-Za-z_][A-Za-z\d_]*)* 1921ec3f6f9SBlue Swirl }x; 1931ec3f6f9SBlue Swirlour $Storage = qr{extern|static|asmlinkage}; 1941ec3f6f9SBlue Swirlour $Sparse = qr{ 195f1e155bbSPaolo Bonzini __force 1961ec3f6f9SBlue Swirl }x; 1971ec3f6f9SBlue Swirl 1981ec3f6f9SBlue Swirl# Notes to $Attribute: 1991ec3f6f9SBlue Swirlour $Attribute = qr{ 2001ec3f6f9SBlue Swirl const| 20171c47b01SPaolo Bonzini volatile| 20271c47b01SPaolo Bonzini QEMU_NORETURN| 20371c47b01SPaolo Bonzini QEMU_WARN_UNUSED_RESULT| 20471c47b01SPaolo Bonzini QEMU_SENTINEL| 20571c47b01SPaolo Bonzini QEMU_ARTIFICIAL| 20671c47b01SPaolo Bonzini QEMU_PACKED| 20771c47b01SPaolo Bonzini GCC_FMT_ATTR 2081ec3f6f9SBlue Swirl }x; 2091ec3f6f9SBlue Swirlour $Modifier; 21071c47b01SPaolo Bonziniour $Inline = qr{inline}; 2111ec3f6f9SBlue Swirlour $Member = qr{->$Ident|\.$Ident|\[[^]]*\]}; 2121ec3f6f9SBlue Swirlour $Lval = qr{$Ident(?:$Member)*}; 2131ec3f6f9SBlue Swirl 2141ec3f6f9SBlue Swirlour $Constant = qr{(?:[0-9]+|0x[0-9a-fA-F]+)[UL]*}; 2151ec3f6f9SBlue Swirlour $Assignment = qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)}; 2161ec3f6f9SBlue Swirlour $Compare = qr{<=|>=|==|!=|<|>}; 2171ec3f6f9SBlue Swirlour $Operators = qr{ 2181ec3f6f9SBlue Swirl <=|>=|==|!=| 2191ec3f6f9SBlue Swirl =>|->|<<|>>|<|>|!|~| 2201ec3f6f9SBlue Swirl &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|% 2211ec3f6f9SBlue Swirl }x; 2221ec3f6f9SBlue Swirl 2231ec3f6f9SBlue Swirlour $NonptrType; 2241ec3f6f9SBlue Swirlour $Type; 2251ec3f6f9SBlue Swirlour $Declare; 2261ec3f6f9SBlue Swirl 2271ec3f6f9SBlue Swirlour $UTF8 = qr { 2281ec3f6f9SBlue Swirl [\x09\x0A\x0D\x20-\x7E] # ASCII 2291ec3f6f9SBlue Swirl | [\xC2-\xDF][\x80-\xBF] # non-overlong 2-byte 2301ec3f6f9SBlue Swirl | \xE0[\xA0-\xBF][\x80-\xBF] # excluding overlongs 2311ec3f6f9SBlue Swirl | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2} # straight 3-byte 2321ec3f6f9SBlue Swirl | \xED[\x80-\x9F][\x80-\xBF] # excluding surrogates 2331ec3f6f9SBlue Swirl | \xF0[\x90-\xBF][\x80-\xBF]{2} # planes 1-3 2341ec3f6f9SBlue Swirl | [\xF1-\xF3][\x80-\xBF]{3} # planes 4-15 2351ec3f6f9SBlue Swirl | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16 2361ec3f6f9SBlue Swirl}x; 2371ec3f6f9SBlue Swirl 238a6859debSPaolo Bonzini# There are still some false positives, but this catches most 239a6859debSPaolo Bonzini# common cases. 2401ec3f6f9SBlue Swirlour $typeTypedefs = qr{(?x: 241a6859debSPaolo Bonzini [A-Z][A-Z\d_]*[a-z][A-Za-z\d_]* # camelcase 242a6859debSPaolo Bonzini | [A-Z][A-Z\d_]*AIOCB # all uppercase 243a6859debSPaolo Bonzini | [A-Z][A-Z\d_]*CPU # all uppercase 244a6859debSPaolo Bonzini | QEMUBH # all uppercase 2451ec3f6f9SBlue Swirl)}; 2461ec3f6f9SBlue Swirl 2471ec3f6f9SBlue Swirlour @typeList = ( 2481ec3f6f9SBlue Swirl qr{void}, 2491ec3f6f9SBlue Swirl qr{(?:unsigned\s+)?char}, 2501ec3f6f9SBlue Swirl qr{(?:unsigned\s+)?short}, 2511ec3f6f9SBlue Swirl qr{(?:unsigned\s+)?int}, 2521ec3f6f9SBlue Swirl qr{(?:unsigned\s+)?long}, 2531ec3f6f9SBlue Swirl qr{(?:unsigned\s+)?long\s+int}, 2541ec3f6f9SBlue Swirl qr{(?:unsigned\s+)?long\s+long}, 2551ec3f6f9SBlue Swirl qr{(?:unsigned\s+)?long\s+long\s+int}, 2561ec3f6f9SBlue Swirl qr{unsigned}, 2571ec3f6f9SBlue Swirl qr{float}, 2581ec3f6f9SBlue Swirl qr{double}, 2591ec3f6f9SBlue Swirl qr{bool}, 2601ec3f6f9SBlue Swirl qr{struct\s+$Ident}, 2611ec3f6f9SBlue Swirl qr{union\s+$Ident}, 2621ec3f6f9SBlue Swirl qr{enum\s+$Ident}, 2631ec3f6f9SBlue Swirl qr{${Ident}_t}, 2641ec3f6f9SBlue Swirl qr{${Ident}_handler}, 2651ec3f6f9SBlue Swirl qr{${Ident}_handler_fn}, 266f0707d2eSCédric Le Goater qr{target_(?:u)?long}, 267825bfa00SGreg Kurz qr{hwaddr}, 268ed279a06SKlim Kireev qr{xml${Ident}}, 269*5ac067a2SIan Jackson qr{xendevicemodel_handle}, 2701ec3f6f9SBlue Swirl); 271f1e155bbSPaolo Bonzini 272f1e155bbSPaolo Bonzini# This can be modified by sub possible. Since it can be empty, be careful 273f1e155bbSPaolo Bonzini# about regexes that always match, because they can cause infinite loops. 2741ec3f6f9SBlue Swirlour @modifierList = ( 2751ec3f6f9SBlue Swirl); 2761ec3f6f9SBlue Swirl 2771ec3f6f9SBlue Swirlsub build_types { 2781ec3f6f9SBlue Swirl my $all = "(?x: \n" . join("|\n ", @typeList) . "\n)"; 279f1e155bbSPaolo Bonzini if (@modifierList > 0) { 280f1e155bbSPaolo Bonzini my $mods = "(?x: \n" . join("|\n ", @modifierList) . "\n)"; 2811ec3f6f9SBlue Swirl $Modifier = qr{(?:$Attribute|$Sparse|$mods)}; 282f1e155bbSPaolo Bonzini } else { 283f1e155bbSPaolo Bonzini $Modifier = qr{(?:$Attribute|$Sparse)}; 284f1e155bbSPaolo Bonzini } 2851ec3f6f9SBlue Swirl $NonptrType = qr{ 2861ec3f6f9SBlue Swirl (?:$Modifier\s+|const\s+)* 2871ec3f6f9SBlue Swirl (?: 2881ec3f6f9SBlue Swirl (?:typeof|__typeof__)\s*\(\s*\**\s*$Ident\s*\)| 2891ec3f6f9SBlue Swirl (?:$typeTypedefs\b)| 2901ec3f6f9SBlue Swirl (?:${all}\b) 2911ec3f6f9SBlue Swirl ) 2921ec3f6f9SBlue Swirl (?:\s+$Modifier|\s+const)* 2931ec3f6f9SBlue Swirl }x; 2941ec3f6f9SBlue Swirl $Type = qr{ 2951ec3f6f9SBlue Swirl $NonptrType 2961ec3f6f9SBlue Swirl (?:[\s\*]+\s*const|[\s\*]+|(?:\s*\[\s*\])+)? 2971ec3f6f9SBlue Swirl (?:\s+$Inline|\s+$Modifier)* 2981ec3f6f9SBlue Swirl }x; 2991ec3f6f9SBlue Swirl $Declare = qr{(?:$Storage\s+)?$Type}; 3001ec3f6f9SBlue Swirl} 3011ec3f6f9SBlue Swirlbuild_types(); 3021ec3f6f9SBlue Swirl 3031ec3f6f9SBlue Swirl$chk_signoff = 0 if ($file); 3041ec3f6f9SBlue Swirl 3051ec3f6f9SBlue Swirlmy @rawlines = (); 3061ec3f6f9SBlue Swirlmy @lines = (); 3071ec3f6f9SBlue Swirlmy $vname; 3088e1fe175SDaniel P. Berrangeif ($chk_branch) { 3098e1fe175SDaniel P. Berrange my @patches; 3108e1fe175SDaniel P. Berrange my $HASH; 3118e1fe175SDaniel P. Berrange open($HASH, "-|", "git", "log", "--format=%H", $ARGV[0]) || 3128e1fe175SDaniel P. Berrange die "$P: git log --format=%H $ARGV[0] failed - $!\n"; 3138e1fe175SDaniel P. Berrange 3148e1fe175SDaniel P. Berrange while (<$HASH>) { 3158e1fe175SDaniel P. Berrange chomp; 3168e1fe175SDaniel P. Berrange push @patches, $_; 3178e1fe175SDaniel P. Berrange } 3188e1fe175SDaniel P. Berrange 3198e1fe175SDaniel P. Berrange close $HASH; 3208e1fe175SDaniel P. Berrange 3218e1fe175SDaniel P. Berrange die "$P: no revisions returned for revlist '$chk_branch'\n" 3228e1fe175SDaniel P. Berrange unless @patches; 3238e1fe175SDaniel P. Berrange 3248e1fe175SDaniel P. Berrange for my $hash (@patches) { 3258e1fe175SDaniel P. Berrange my $FILE; 3268e1fe175SDaniel P. Berrange open($FILE, '-|', "git", "show", $hash) || 3278e1fe175SDaniel P. Berrange die "$P: git show $hash - $!\n"; 3288e1fe175SDaniel P. Berrange $vname = $hash; 3298e1fe175SDaniel P. Berrange while (<$FILE>) { 3308e1fe175SDaniel P. Berrange chomp; 3318e1fe175SDaniel P. Berrange push(@rawlines, $_); 3328e1fe175SDaniel P. Berrange } 3338e1fe175SDaniel P. Berrange close($FILE); 3348e1fe175SDaniel P. Berrange if (!process($hash)) { 3358e1fe175SDaniel P. Berrange $exit = 1; 3368e1fe175SDaniel P. Berrange } 3378e1fe175SDaniel P. Berrange @rawlines = (); 3388e1fe175SDaniel P. Berrange @lines = (); 3398e1fe175SDaniel P. Berrange } 3408e1fe175SDaniel P. Berrange} else { 3411ec3f6f9SBlue Swirl for my $filename (@ARGV) { 3421ec3f6f9SBlue Swirl my $FILE; 3431ec3f6f9SBlue Swirl if ($file) { 3441ec3f6f9SBlue Swirl open($FILE, '-|', "diff -u /dev/null $filename") || 3451ec3f6f9SBlue Swirl die "$P: $filename: diff failed - $!\n"; 3461ec3f6f9SBlue Swirl } elsif ($filename eq '-') { 3471ec3f6f9SBlue Swirl open($FILE, '<&STDIN'); 3481ec3f6f9SBlue Swirl } else { 3491ec3f6f9SBlue Swirl open($FILE, '<', "$filename") || 3501ec3f6f9SBlue Swirl die "$P: $filename: open failed - $!\n"; 3511ec3f6f9SBlue Swirl } 3521ec3f6f9SBlue Swirl if ($filename eq '-') { 3531ec3f6f9SBlue Swirl $vname = 'Your patch'; 3541ec3f6f9SBlue Swirl } else { 3551ec3f6f9SBlue Swirl $vname = $filename; 3561ec3f6f9SBlue Swirl } 3571ec3f6f9SBlue Swirl while (<$FILE>) { 3581ec3f6f9SBlue Swirl chomp; 3591ec3f6f9SBlue Swirl push(@rawlines, $_); 3601ec3f6f9SBlue Swirl } 3611ec3f6f9SBlue Swirl close($FILE); 3621ec3f6f9SBlue Swirl if (!process($filename)) { 3631ec3f6f9SBlue Swirl $exit = 1; 3641ec3f6f9SBlue Swirl } 3651ec3f6f9SBlue Swirl @rawlines = (); 3661ec3f6f9SBlue Swirl @lines = (); 3671ec3f6f9SBlue Swirl } 3688e1fe175SDaniel P. Berrange} 3691ec3f6f9SBlue Swirl 3701ec3f6f9SBlue Swirlexit($exit); 3711ec3f6f9SBlue Swirl 3721ec3f6f9SBlue Swirlsub top_of_kernel_tree { 3731ec3f6f9SBlue Swirl my ($root) = @_; 3741ec3f6f9SBlue Swirl 3751ec3f6f9SBlue Swirl my @tree_check = ( 376b6469683SBlue Swirl "COPYING", "MAINTAINERS", "Makefile", 377b6469683SBlue Swirl "README", "docs", "VERSION", 378b6469683SBlue Swirl "vl.c" 3791ec3f6f9SBlue Swirl ); 3801ec3f6f9SBlue Swirl 3811ec3f6f9SBlue Swirl foreach my $check (@tree_check) { 3821ec3f6f9SBlue Swirl if (! -e $root . '/' . $check) { 3831ec3f6f9SBlue Swirl return 0; 3841ec3f6f9SBlue Swirl } 3851ec3f6f9SBlue Swirl } 3861ec3f6f9SBlue Swirl return 1; 3871ec3f6f9SBlue Swirl} 3881ec3f6f9SBlue Swirl 3891ec3f6f9SBlue Swirlsub expand_tabs { 3901ec3f6f9SBlue Swirl my ($str) = @_; 3911ec3f6f9SBlue Swirl 3921ec3f6f9SBlue Swirl my $res = ''; 3931ec3f6f9SBlue Swirl my $n = 0; 3941ec3f6f9SBlue Swirl for my $c (split(//, $str)) { 3951ec3f6f9SBlue Swirl if ($c eq "\t") { 3961ec3f6f9SBlue Swirl $res .= ' '; 3971ec3f6f9SBlue Swirl $n++; 3981ec3f6f9SBlue Swirl for (; ($n % 8) != 0; $n++) { 3991ec3f6f9SBlue Swirl $res .= ' '; 4001ec3f6f9SBlue Swirl } 4011ec3f6f9SBlue Swirl next; 4021ec3f6f9SBlue Swirl } 4031ec3f6f9SBlue Swirl $res .= $c; 4041ec3f6f9SBlue Swirl $n++; 4051ec3f6f9SBlue Swirl } 4061ec3f6f9SBlue Swirl 4071ec3f6f9SBlue Swirl return $res; 4081ec3f6f9SBlue Swirl} 4091ec3f6f9SBlue Swirlsub copy_spacing { 4101ec3f6f9SBlue Swirl (my $res = shift) =~ tr/\t/ /c; 4111ec3f6f9SBlue Swirl return $res; 4121ec3f6f9SBlue Swirl} 4131ec3f6f9SBlue Swirl 4141ec3f6f9SBlue Swirlsub line_stats { 4151ec3f6f9SBlue Swirl my ($line) = @_; 4161ec3f6f9SBlue Swirl 4171ec3f6f9SBlue Swirl # Drop the diff line leader and expand tabs 4181ec3f6f9SBlue Swirl $line =~ s/^.//; 4191ec3f6f9SBlue Swirl $line = expand_tabs($line); 4201ec3f6f9SBlue Swirl 4211ec3f6f9SBlue Swirl # Pick the indent from the front of the line. 4221ec3f6f9SBlue Swirl my ($white) = ($line =~ /^(\s*)/); 4231ec3f6f9SBlue Swirl 4241ec3f6f9SBlue Swirl return (length($line), length($white)); 4251ec3f6f9SBlue Swirl} 4261ec3f6f9SBlue Swirl 4271ec3f6f9SBlue Swirlmy $sanitise_quote = ''; 4281ec3f6f9SBlue Swirl 4291ec3f6f9SBlue Swirlsub sanitise_line_reset { 4301ec3f6f9SBlue Swirl my ($in_comment) = @_; 4311ec3f6f9SBlue Swirl 4321ec3f6f9SBlue Swirl if ($in_comment) { 4331ec3f6f9SBlue Swirl $sanitise_quote = '*/'; 4341ec3f6f9SBlue Swirl } else { 4351ec3f6f9SBlue Swirl $sanitise_quote = ''; 4361ec3f6f9SBlue Swirl } 4371ec3f6f9SBlue Swirl} 4381ec3f6f9SBlue Swirlsub sanitise_line { 4391ec3f6f9SBlue Swirl my ($line) = @_; 4401ec3f6f9SBlue Swirl 4411ec3f6f9SBlue Swirl my $res = ''; 4421ec3f6f9SBlue Swirl my $l = ''; 4431ec3f6f9SBlue Swirl 4441ec3f6f9SBlue Swirl my $qlen = 0; 4451ec3f6f9SBlue Swirl my $off = 0; 4461ec3f6f9SBlue Swirl my $c; 4471ec3f6f9SBlue Swirl 4481ec3f6f9SBlue Swirl # Always copy over the diff marker. 4491ec3f6f9SBlue Swirl $res = substr($line, 0, 1); 4501ec3f6f9SBlue Swirl 4511ec3f6f9SBlue Swirl for ($off = 1; $off < length($line); $off++) { 4521ec3f6f9SBlue Swirl $c = substr($line, $off, 1); 4531ec3f6f9SBlue Swirl 454cb8d4c8fSStefan Weil # Comments we are wacking completely including the begin 4551ec3f6f9SBlue Swirl # and end, all to $;. 4561ec3f6f9SBlue Swirl if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') { 4571ec3f6f9SBlue Swirl $sanitise_quote = '*/'; 4581ec3f6f9SBlue Swirl 4591ec3f6f9SBlue Swirl substr($res, $off, 2, "$;$;"); 4601ec3f6f9SBlue Swirl $off++; 4611ec3f6f9SBlue Swirl next; 4621ec3f6f9SBlue Swirl } 4631ec3f6f9SBlue Swirl if ($sanitise_quote eq '*/' && substr($line, $off, 2) eq '*/') { 4641ec3f6f9SBlue Swirl $sanitise_quote = ''; 4651ec3f6f9SBlue Swirl substr($res, $off, 2, "$;$;"); 4661ec3f6f9SBlue Swirl $off++; 4671ec3f6f9SBlue Swirl next; 4681ec3f6f9SBlue Swirl } 4691ec3f6f9SBlue Swirl if ($sanitise_quote eq '' && substr($line, $off, 2) eq '//') { 4701ec3f6f9SBlue Swirl $sanitise_quote = '//'; 4711ec3f6f9SBlue Swirl 4721ec3f6f9SBlue Swirl substr($res, $off, 2, $sanitise_quote); 4731ec3f6f9SBlue Swirl $off++; 4741ec3f6f9SBlue Swirl next; 4751ec3f6f9SBlue Swirl } 4761ec3f6f9SBlue Swirl 4771ec3f6f9SBlue Swirl # A \ in a string means ignore the next character. 4781ec3f6f9SBlue Swirl if (($sanitise_quote eq "'" || $sanitise_quote eq '"') && 4791ec3f6f9SBlue Swirl $c eq "\\") { 4801ec3f6f9SBlue Swirl substr($res, $off, 2, 'XX'); 4811ec3f6f9SBlue Swirl $off++; 4821ec3f6f9SBlue Swirl next; 4831ec3f6f9SBlue Swirl } 4841ec3f6f9SBlue Swirl # Regular quotes. 4851ec3f6f9SBlue Swirl if ($c eq "'" || $c eq '"') { 4861ec3f6f9SBlue Swirl if ($sanitise_quote eq '') { 4871ec3f6f9SBlue Swirl $sanitise_quote = $c; 4881ec3f6f9SBlue Swirl 4891ec3f6f9SBlue Swirl substr($res, $off, 1, $c); 4901ec3f6f9SBlue Swirl next; 4911ec3f6f9SBlue Swirl } elsif ($sanitise_quote eq $c) { 4921ec3f6f9SBlue Swirl $sanitise_quote = ''; 4931ec3f6f9SBlue Swirl } 4941ec3f6f9SBlue Swirl } 4951ec3f6f9SBlue Swirl 4961ec3f6f9SBlue Swirl #print "c<$c> SQ<$sanitise_quote>\n"; 4971ec3f6f9SBlue Swirl if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") { 4981ec3f6f9SBlue Swirl substr($res, $off, 1, $;); 4991ec3f6f9SBlue Swirl } elsif ($off != 0 && $sanitise_quote eq '//' && $c ne "\t") { 5001ec3f6f9SBlue Swirl substr($res, $off, 1, $;); 5011ec3f6f9SBlue Swirl } elsif ($off != 0 && $sanitise_quote && $c ne "\t") { 5021ec3f6f9SBlue Swirl substr($res, $off, 1, 'X'); 5031ec3f6f9SBlue Swirl } else { 5041ec3f6f9SBlue Swirl substr($res, $off, 1, $c); 5051ec3f6f9SBlue Swirl } 5061ec3f6f9SBlue Swirl } 5071ec3f6f9SBlue Swirl 5081ec3f6f9SBlue Swirl if ($sanitise_quote eq '//') { 5091ec3f6f9SBlue Swirl $sanitise_quote = ''; 5101ec3f6f9SBlue Swirl } 5111ec3f6f9SBlue Swirl 5121ec3f6f9SBlue Swirl # The pathname on a #include may be surrounded by '<' and '>'. 5131ec3f6f9SBlue Swirl if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) { 5141ec3f6f9SBlue Swirl my $clean = 'X' x length($1); 5151ec3f6f9SBlue Swirl $res =~ s@\<.*\>@<$clean>@; 5161ec3f6f9SBlue Swirl 5171ec3f6f9SBlue Swirl # The whole of a #error is a string. 5181ec3f6f9SBlue Swirl } elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) { 5191ec3f6f9SBlue Swirl my $clean = 'X' x length($1); 5201ec3f6f9SBlue Swirl $res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@; 5211ec3f6f9SBlue Swirl } 5221ec3f6f9SBlue Swirl 5231ec3f6f9SBlue Swirl return $res; 5241ec3f6f9SBlue Swirl} 5251ec3f6f9SBlue Swirl 5261ec3f6f9SBlue Swirlsub ctx_statement_block { 5271ec3f6f9SBlue Swirl my ($linenr, $remain, $off) = @_; 5281ec3f6f9SBlue Swirl my $line = $linenr - 1; 5291ec3f6f9SBlue Swirl my $blk = ''; 5301ec3f6f9SBlue Swirl my $soff = $off; 5311ec3f6f9SBlue Swirl my $coff = $off - 1; 5321ec3f6f9SBlue Swirl my $coff_set = 0; 5331ec3f6f9SBlue Swirl 5341ec3f6f9SBlue Swirl my $loff = 0; 5351ec3f6f9SBlue Swirl 5361ec3f6f9SBlue Swirl my $type = ''; 5371ec3f6f9SBlue Swirl my $level = 0; 5381ec3f6f9SBlue Swirl my @stack = (); 5391ec3f6f9SBlue Swirl my $p; 5401ec3f6f9SBlue Swirl my $c; 5411ec3f6f9SBlue Swirl my $len = 0; 5421ec3f6f9SBlue Swirl 5431ec3f6f9SBlue Swirl my $remainder; 5441ec3f6f9SBlue Swirl while (1) { 5451ec3f6f9SBlue Swirl @stack = (['', 0]) if ($#stack == -1); 5461ec3f6f9SBlue Swirl 5471ec3f6f9SBlue Swirl #warn "CSB: blk<$blk> remain<$remain>\n"; 5481ec3f6f9SBlue Swirl # If we are about to drop off the end, pull in more 5491ec3f6f9SBlue Swirl # context. 5501ec3f6f9SBlue Swirl if ($off >= $len) { 5511ec3f6f9SBlue Swirl for (; $remain > 0; $line++) { 5521ec3f6f9SBlue Swirl last if (!defined $lines[$line]); 5531ec3f6f9SBlue Swirl next if ($lines[$line] =~ /^-/); 5541ec3f6f9SBlue Swirl $remain--; 5551ec3f6f9SBlue Swirl $loff = $len; 5561ec3f6f9SBlue Swirl $blk .= $lines[$line] . "\n"; 5571ec3f6f9SBlue Swirl $len = length($blk); 5581ec3f6f9SBlue Swirl $line++; 5591ec3f6f9SBlue Swirl last; 5601ec3f6f9SBlue Swirl } 5611ec3f6f9SBlue Swirl # Bail if there is no further context. 5621ec3f6f9SBlue Swirl #warn "CSB: blk<$blk> off<$off> len<$len>\n"; 5631ec3f6f9SBlue Swirl if ($off >= $len) { 5641ec3f6f9SBlue Swirl last; 5651ec3f6f9SBlue Swirl } 5661ec3f6f9SBlue Swirl } 5671ec3f6f9SBlue Swirl $p = $c; 5681ec3f6f9SBlue Swirl $c = substr($blk, $off, 1); 5691ec3f6f9SBlue Swirl $remainder = substr($blk, $off); 5701ec3f6f9SBlue Swirl 5711ec3f6f9SBlue Swirl #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n"; 5721ec3f6f9SBlue Swirl 5731ec3f6f9SBlue Swirl # Handle nested #if/#else. 5741ec3f6f9SBlue Swirl if ($remainder =~ /^#\s*(?:ifndef|ifdef|if)\s/) { 5751ec3f6f9SBlue Swirl push(@stack, [ $type, $level ]); 5761ec3f6f9SBlue Swirl } elsif ($remainder =~ /^#\s*(?:else|elif)\b/) { 5771ec3f6f9SBlue Swirl ($type, $level) = @{$stack[$#stack - 1]}; 5781ec3f6f9SBlue Swirl } elsif ($remainder =~ /^#\s*endif\b/) { 5791ec3f6f9SBlue Swirl ($type, $level) = @{pop(@stack)}; 5801ec3f6f9SBlue Swirl } 5811ec3f6f9SBlue Swirl 5821ec3f6f9SBlue Swirl # Statement ends at the ';' or a close '}' at the 5831ec3f6f9SBlue Swirl # outermost level. 5841ec3f6f9SBlue Swirl if ($level == 0 && $c eq ';') { 5851ec3f6f9SBlue Swirl last; 5861ec3f6f9SBlue Swirl } 5871ec3f6f9SBlue Swirl 5881ec3f6f9SBlue Swirl # An else is really a conditional as long as its not else if 5891ec3f6f9SBlue Swirl if ($level == 0 && $coff_set == 0 && 5901ec3f6f9SBlue Swirl (!defined($p) || $p =~ /(?:\s|\}|\+)/) && 5911ec3f6f9SBlue Swirl $remainder =~ /^(else)(?:\s|{)/ && 5921ec3f6f9SBlue Swirl $remainder !~ /^else\s+if\b/) { 5931ec3f6f9SBlue Swirl $coff = $off + length($1) - 1; 5941ec3f6f9SBlue Swirl $coff_set = 1; 5951ec3f6f9SBlue Swirl #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n"; 5961ec3f6f9SBlue Swirl #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n"; 5971ec3f6f9SBlue Swirl } 5981ec3f6f9SBlue Swirl 5991ec3f6f9SBlue Swirl if (($type eq '' || $type eq '(') && $c eq '(') { 6001ec3f6f9SBlue Swirl $level++; 6011ec3f6f9SBlue Swirl $type = '('; 6021ec3f6f9SBlue Swirl } 6031ec3f6f9SBlue Swirl if ($type eq '(' && $c eq ')') { 6041ec3f6f9SBlue Swirl $level--; 6051ec3f6f9SBlue Swirl $type = ($level != 0)? '(' : ''; 6061ec3f6f9SBlue Swirl 6071ec3f6f9SBlue Swirl if ($level == 0 && $coff < $soff) { 6081ec3f6f9SBlue Swirl $coff = $off; 6091ec3f6f9SBlue Swirl $coff_set = 1; 6101ec3f6f9SBlue Swirl #warn "CSB: mark coff<$coff>\n"; 6111ec3f6f9SBlue Swirl } 6121ec3f6f9SBlue Swirl } 6131ec3f6f9SBlue Swirl if (($type eq '' || $type eq '{') && $c eq '{') { 6141ec3f6f9SBlue Swirl $level++; 6151ec3f6f9SBlue Swirl $type = '{'; 6161ec3f6f9SBlue Swirl } 6171ec3f6f9SBlue Swirl if ($type eq '{' && $c eq '}') { 6181ec3f6f9SBlue Swirl $level--; 6191ec3f6f9SBlue Swirl $type = ($level != 0)? '{' : ''; 6201ec3f6f9SBlue Swirl 6211ec3f6f9SBlue Swirl if ($level == 0) { 6221ec3f6f9SBlue Swirl if (substr($blk, $off + 1, 1) eq ';') { 6231ec3f6f9SBlue Swirl $off++; 6241ec3f6f9SBlue Swirl } 6251ec3f6f9SBlue Swirl last; 6261ec3f6f9SBlue Swirl } 6271ec3f6f9SBlue Swirl } 6281ec3f6f9SBlue Swirl $off++; 6291ec3f6f9SBlue Swirl } 6301ec3f6f9SBlue Swirl # We are truly at the end, so shuffle to the next line. 6311ec3f6f9SBlue Swirl if ($off == $len) { 6321ec3f6f9SBlue Swirl $loff = $len + 1; 6331ec3f6f9SBlue Swirl $line++; 6341ec3f6f9SBlue Swirl $remain--; 6351ec3f6f9SBlue Swirl } 6361ec3f6f9SBlue Swirl 6371ec3f6f9SBlue Swirl my $statement = substr($blk, $soff, $off - $soff + 1); 6381ec3f6f9SBlue Swirl my $condition = substr($blk, $soff, $coff - $soff + 1); 6391ec3f6f9SBlue Swirl 6401ec3f6f9SBlue Swirl #warn "STATEMENT<$statement>\n"; 6411ec3f6f9SBlue Swirl #warn "CONDITION<$condition>\n"; 6421ec3f6f9SBlue Swirl 6431ec3f6f9SBlue Swirl #print "coff<$coff> soff<$off> loff<$loff>\n"; 6441ec3f6f9SBlue Swirl 6451ec3f6f9SBlue Swirl return ($statement, $condition, 6461ec3f6f9SBlue Swirl $line, $remain + 1, $off - $loff + 1, $level); 6471ec3f6f9SBlue Swirl} 6481ec3f6f9SBlue Swirl 6491ec3f6f9SBlue Swirlsub statement_lines { 6501ec3f6f9SBlue Swirl my ($stmt) = @_; 6511ec3f6f9SBlue Swirl 6521ec3f6f9SBlue Swirl # Strip the diff line prefixes and rip blank lines at start and end. 6531ec3f6f9SBlue Swirl $stmt =~ s/(^|\n)./$1/g; 6541ec3f6f9SBlue Swirl $stmt =~ s/^\s*//; 6551ec3f6f9SBlue Swirl $stmt =~ s/\s*$//; 6561ec3f6f9SBlue Swirl 6571ec3f6f9SBlue Swirl my @stmt_lines = ($stmt =~ /\n/g); 6581ec3f6f9SBlue Swirl 6591ec3f6f9SBlue Swirl return $#stmt_lines + 2; 6601ec3f6f9SBlue Swirl} 6611ec3f6f9SBlue Swirl 6621ec3f6f9SBlue Swirlsub statement_rawlines { 6631ec3f6f9SBlue Swirl my ($stmt) = @_; 6641ec3f6f9SBlue Swirl 6651ec3f6f9SBlue Swirl my @stmt_lines = ($stmt =~ /\n/g); 6661ec3f6f9SBlue Swirl 6671ec3f6f9SBlue Swirl return $#stmt_lines + 2; 6681ec3f6f9SBlue Swirl} 6691ec3f6f9SBlue Swirl 6701ec3f6f9SBlue Swirlsub statement_block_size { 6711ec3f6f9SBlue Swirl my ($stmt) = @_; 6721ec3f6f9SBlue Swirl 6731ec3f6f9SBlue Swirl $stmt =~ s/(^|\n)./$1/g; 67404f2562fSFam Zheng $stmt =~ s/^\s*\{//; 6751ec3f6f9SBlue Swirl $stmt =~ s/}\s*$//; 6761ec3f6f9SBlue Swirl $stmt =~ s/^\s*//; 6771ec3f6f9SBlue Swirl $stmt =~ s/\s*$//; 6781ec3f6f9SBlue Swirl 6791ec3f6f9SBlue Swirl my @stmt_lines = ($stmt =~ /\n/g); 6801ec3f6f9SBlue Swirl my @stmt_statements = ($stmt =~ /;/g); 6811ec3f6f9SBlue Swirl 6821ec3f6f9SBlue Swirl my $stmt_lines = $#stmt_lines + 2; 6831ec3f6f9SBlue Swirl my $stmt_statements = $#stmt_statements + 1; 6841ec3f6f9SBlue Swirl 6851ec3f6f9SBlue Swirl if ($stmt_lines > $stmt_statements) { 6861ec3f6f9SBlue Swirl return $stmt_lines; 6871ec3f6f9SBlue Swirl } else { 6881ec3f6f9SBlue Swirl return $stmt_statements; 6891ec3f6f9SBlue Swirl } 6901ec3f6f9SBlue Swirl} 6911ec3f6f9SBlue Swirl 6921ec3f6f9SBlue Swirlsub ctx_statement_full { 6931ec3f6f9SBlue Swirl my ($linenr, $remain, $off) = @_; 6941ec3f6f9SBlue Swirl my ($statement, $condition, $level); 6951ec3f6f9SBlue Swirl 6961ec3f6f9SBlue Swirl my (@chunks); 6971ec3f6f9SBlue Swirl 6981ec3f6f9SBlue Swirl # Grab the first conditional/block pair. 6991ec3f6f9SBlue Swirl ($statement, $condition, $linenr, $remain, $off, $level) = 7001ec3f6f9SBlue Swirl ctx_statement_block($linenr, $remain, $off); 7011ec3f6f9SBlue Swirl #print "F: c<$condition> s<$statement> remain<$remain>\n"; 7021ec3f6f9SBlue Swirl push(@chunks, [ $condition, $statement ]); 7031ec3f6f9SBlue Swirl if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) { 7041ec3f6f9SBlue Swirl return ($level, $linenr, @chunks); 7051ec3f6f9SBlue Swirl } 7061ec3f6f9SBlue Swirl 7071ec3f6f9SBlue Swirl # Pull in the following conditional/block pairs and see if they 7081ec3f6f9SBlue Swirl # could continue the statement. 7091ec3f6f9SBlue Swirl for (;;) { 7101ec3f6f9SBlue Swirl ($statement, $condition, $linenr, $remain, $off, $level) = 7111ec3f6f9SBlue Swirl ctx_statement_block($linenr, $remain, $off); 7121ec3f6f9SBlue Swirl #print "C: c<$condition> s<$statement> remain<$remain>\n"; 7131ec3f6f9SBlue Swirl last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s)); 7141ec3f6f9SBlue Swirl #print "C: push\n"; 7151ec3f6f9SBlue Swirl push(@chunks, [ $condition, $statement ]); 7161ec3f6f9SBlue Swirl } 7171ec3f6f9SBlue Swirl 7181ec3f6f9SBlue Swirl return ($level, $linenr, @chunks); 7191ec3f6f9SBlue Swirl} 7201ec3f6f9SBlue Swirl 7211ec3f6f9SBlue Swirlsub ctx_block_get { 7221ec3f6f9SBlue Swirl my ($linenr, $remain, $outer, $open, $close, $off) = @_; 7231ec3f6f9SBlue Swirl my $line; 7241ec3f6f9SBlue Swirl my $start = $linenr - 1; 7251ec3f6f9SBlue Swirl my $blk = ''; 7261ec3f6f9SBlue Swirl my @o; 7271ec3f6f9SBlue Swirl my @c; 7281ec3f6f9SBlue Swirl my @res = (); 7291ec3f6f9SBlue Swirl 7301ec3f6f9SBlue Swirl my $level = 0; 7311ec3f6f9SBlue Swirl my @stack = ($level); 7321ec3f6f9SBlue Swirl for ($line = $start; $remain > 0; $line++) { 7331ec3f6f9SBlue Swirl next if ($rawlines[$line] =~ /^-/); 7341ec3f6f9SBlue Swirl $remain--; 7351ec3f6f9SBlue Swirl 7361ec3f6f9SBlue Swirl $blk .= $rawlines[$line]; 7371ec3f6f9SBlue Swirl 7381ec3f6f9SBlue Swirl # Handle nested #if/#else. 7391ec3f6f9SBlue Swirl if ($lines[$line] =~ /^.\s*#\s*(?:ifndef|ifdef|if)\s/) { 7401ec3f6f9SBlue Swirl push(@stack, $level); 7411ec3f6f9SBlue Swirl } elsif ($lines[$line] =~ /^.\s*#\s*(?:else|elif)\b/) { 7421ec3f6f9SBlue Swirl $level = $stack[$#stack - 1]; 7431ec3f6f9SBlue Swirl } elsif ($lines[$line] =~ /^.\s*#\s*endif\b/) { 7441ec3f6f9SBlue Swirl $level = pop(@stack); 7451ec3f6f9SBlue Swirl } 7461ec3f6f9SBlue Swirl 7471ec3f6f9SBlue Swirl foreach my $c (split(//, $lines[$line])) { 7481ec3f6f9SBlue Swirl ##print "C<$c>L<$level><$open$close>O<$off>\n"; 7491ec3f6f9SBlue Swirl if ($off > 0) { 7501ec3f6f9SBlue Swirl $off--; 7511ec3f6f9SBlue Swirl next; 7521ec3f6f9SBlue Swirl } 7531ec3f6f9SBlue Swirl 7541ec3f6f9SBlue Swirl if ($c eq $close && $level > 0) { 7551ec3f6f9SBlue Swirl $level--; 7561ec3f6f9SBlue Swirl last if ($level == 0); 7571ec3f6f9SBlue Swirl } elsif ($c eq $open) { 7581ec3f6f9SBlue Swirl $level++; 7591ec3f6f9SBlue Swirl } 7601ec3f6f9SBlue Swirl } 7611ec3f6f9SBlue Swirl 7621ec3f6f9SBlue Swirl if (!$outer || $level <= 1) { 7631ec3f6f9SBlue Swirl push(@res, $rawlines[$line]); 7641ec3f6f9SBlue Swirl } 7651ec3f6f9SBlue Swirl 7661ec3f6f9SBlue Swirl last if ($level == 0); 7671ec3f6f9SBlue Swirl } 7681ec3f6f9SBlue Swirl 7691ec3f6f9SBlue Swirl return ($level, @res); 7701ec3f6f9SBlue Swirl} 7711ec3f6f9SBlue Swirlsub ctx_block_outer { 7721ec3f6f9SBlue Swirl my ($linenr, $remain) = @_; 7731ec3f6f9SBlue Swirl 7741ec3f6f9SBlue Swirl my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0); 7751ec3f6f9SBlue Swirl return @r; 7761ec3f6f9SBlue Swirl} 7771ec3f6f9SBlue Swirlsub ctx_block { 7781ec3f6f9SBlue Swirl my ($linenr, $remain) = @_; 7791ec3f6f9SBlue Swirl 7801ec3f6f9SBlue Swirl my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0); 7811ec3f6f9SBlue Swirl return @r; 7821ec3f6f9SBlue Swirl} 7831ec3f6f9SBlue Swirlsub ctx_statement { 7841ec3f6f9SBlue Swirl my ($linenr, $remain, $off) = @_; 7851ec3f6f9SBlue Swirl 7861ec3f6f9SBlue Swirl my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off); 7871ec3f6f9SBlue Swirl return @r; 7881ec3f6f9SBlue Swirl} 7891ec3f6f9SBlue Swirlsub ctx_block_level { 7901ec3f6f9SBlue Swirl my ($linenr, $remain) = @_; 7911ec3f6f9SBlue Swirl 7921ec3f6f9SBlue Swirl return ctx_block_get($linenr, $remain, 0, '{', '}', 0); 7931ec3f6f9SBlue Swirl} 7941ec3f6f9SBlue Swirlsub ctx_statement_level { 7951ec3f6f9SBlue Swirl my ($linenr, $remain, $off) = @_; 7961ec3f6f9SBlue Swirl 7971ec3f6f9SBlue Swirl return ctx_block_get($linenr, $remain, 0, '(', ')', $off); 7981ec3f6f9SBlue Swirl} 7991ec3f6f9SBlue Swirl 8001ec3f6f9SBlue Swirlsub ctx_locate_comment { 8011ec3f6f9SBlue Swirl my ($first_line, $end_line) = @_; 8021ec3f6f9SBlue Swirl 8031ec3f6f9SBlue Swirl # Catch a comment on the end of the line itself. 8041ec3f6f9SBlue Swirl my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@); 8051ec3f6f9SBlue Swirl return $current_comment if (defined $current_comment); 8061ec3f6f9SBlue Swirl 8071ec3f6f9SBlue Swirl # Look through the context and try and figure out if there is a 8081ec3f6f9SBlue Swirl # comment. 8091ec3f6f9SBlue Swirl my $in_comment = 0; 8101ec3f6f9SBlue Swirl $current_comment = ''; 8111ec3f6f9SBlue Swirl for (my $linenr = $first_line; $linenr < $end_line; $linenr++) { 8121ec3f6f9SBlue Swirl my $line = $rawlines[$linenr - 1]; 8131ec3f6f9SBlue Swirl #warn " $line\n"; 8141ec3f6f9SBlue Swirl if ($linenr == $first_line and $line =~ m@^.\s*\*@) { 8151ec3f6f9SBlue Swirl $in_comment = 1; 8161ec3f6f9SBlue Swirl } 8171ec3f6f9SBlue Swirl if ($line =~ m@/\*@) { 8181ec3f6f9SBlue Swirl $in_comment = 1; 8191ec3f6f9SBlue Swirl } 8201ec3f6f9SBlue Swirl if (!$in_comment && $current_comment ne '') { 8211ec3f6f9SBlue Swirl $current_comment = ''; 8221ec3f6f9SBlue Swirl } 8231ec3f6f9SBlue Swirl $current_comment .= $line . "\n" if ($in_comment); 8241ec3f6f9SBlue Swirl if ($line =~ m@\*/@) { 8251ec3f6f9SBlue Swirl $in_comment = 0; 8261ec3f6f9SBlue Swirl } 8271ec3f6f9SBlue Swirl } 8281ec3f6f9SBlue Swirl 8291ec3f6f9SBlue Swirl chomp($current_comment); 8301ec3f6f9SBlue Swirl return($current_comment); 8311ec3f6f9SBlue Swirl} 8321ec3f6f9SBlue Swirlsub ctx_has_comment { 8331ec3f6f9SBlue Swirl my ($first_line, $end_line) = @_; 8341ec3f6f9SBlue Swirl my $cmt = ctx_locate_comment($first_line, $end_line); 8351ec3f6f9SBlue Swirl 8361ec3f6f9SBlue Swirl ##print "LINE: $rawlines[$end_line - 1 ]\n"; 8371ec3f6f9SBlue Swirl ##print "CMMT: $cmt\n"; 8381ec3f6f9SBlue Swirl 8391ec3f6f9SBlue Swirl return ($cmt ne ''); 8401ec3f6f9SBlue Swirl} 8411ec3f6f9SBlue Swirl 8421ec3f6f9SBlue Swirlsub raw_line { 8431ec3f6f9SBlue Swirl my ($linenr, $cnt) = @_; 8441ec3f6f9SBlue Swirl 8451ec3f6f9SBlue Swirl my $offset = $linenr - 1; 8461ec3f6f9SBlue Swirl $cnt++; 8471ec3f6f9SBlue Swirl 8481ec3f6f9SBlue Swirl my $line; 8491ec3f6f9SBlue Swirl while ($cnt) { 8501ec3f6f9SBlue Swirl $line = $rawlines[$offset++]; 8511ec3f6f9SBlue Swirl next if (defined($line) && $line =~ /^-/); 8521ec3f6f9SBlue Swirl $cnt--; 8531ec3f6f9SBlue Swirl } 8541ec3f6f9SBlue Swirl 8551ec3f6f9SBlue Swirl return $line; 8561ec3f6f9SBlue Swirl} 8571ec3f6f9SBlue Swirl 8581ec3f6f9SBlue Swirlsub cat_vet { 8591ec3f6f9SBlue Swirl my ($vet) = @_; 8601ec3f6f9SBlue Swirl my ($res, $coded); 8611ec3f6f9SBlue Swirl 8621ec3f6f9SBlue Swirl $res = ''; 8631ec3f6f9SBlue Swirl while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) { 8641ec3f6f9SBlue Swirl $res .= $1; 8651ec3f6f9SBlue Swirl if ($2 ne '') { 8661ec3f6f9SBlue Swirl $coded = sprintf("^%c", unpack('C', $2) + 64); 8671ec3f6f9SBlue Swirl $res .= $coded; 8681ec3f6f9SBlue Swirl } 8691ec3f6f9SBlue Swirl } 8701ec3f6f9SBlue Swirl $res =~ s/$/\$/; 8711ec3f6f9SBlue Swirl 8721ec3f6f9SBlue Swirl return $res; 8731ec3f6f9SBlue Swirl} 8741ec3f6f9SBlue Swirl 8751ec3f6f9SBlue Swirlmy $av_preprocessor = 0; 8761ec3f6f9SBlue Swirlmy $av_pending; 8771ec3f6f9SBlue Swirlmy @av_paren_type; 8781ec3f6f9SBlue Swirlmy $av_pend_colon; 8791ec3f6f9SBlue Swirl 8801ec3f6f9SBlue Swirlsub annotate_reset { 8811ec3f6f9SBlue Swirl $av_preprocessor = 0; 8821ec3f6f9SBlue Swirl $av_pending = '_'; 8831ec3f6f9SBlue Swirl @av_paren_type = ('E'); 8841ec3f6f9SBlue Swirl $av_pend_colon = 'O'; 8851ec3f6f9SBlue Swirl} 8861ec3f6f9SBlue Swirl 8871ec3f6f9SBlue Swirlsub annotate_values { 8881ec3f6f9SBlue Swirl my ($stream, $type) = @_; 8891ec3f6f9SBlue Swirl 8901ec3f6f9SBlue Swirl my $res; 8911ec3f6f9SBlue Swirl my $var = '_' x length($stream); 8921ec3f6f9SBlue Swirl my $cur = $stream; 8931ec3f6f9SBlue Swirl 8941ec3f6f9SBlue Swirl print "$stream\n" if ($dbg_values > 1); 8951ec3f6f9SBlue Swirl 8961ec3f6f9SBlue Swirl while (length($cur)) { 8971ec3f6f9SBlue Swirl @av_paren_type = ('E') if ($#av_paren_type < 0); 8981ec3f6f9SBlue Swirl print " <" . join('', @av_paren_type) . 8991ec3f6f9SBlue Swirl "> <$type> <$av_pending>" if ($dbg_values > 1); 9001ec3f6f9SBlue Swirl if ($cur =~ /^(\s+)/o) { 9011ec3f6f9SBlue Swirl print "WS($1)\n" if ($dbg_values > 1); 9021ec3f6f9SBlue Swirl if ($1 =~ /\n/ && $av_preprocessor) { 9031ec3f6f9SBlue Swirl $type = pop(@av_paren_type); 9041ec3f6f9SBlue Swirl $av_preprocessor = 0; 9051ec3f6f9SBlue Swirl } 9061ec3f6f9SBlue Swirl 90761669f9aSFlorian Mickler } elsif ($cur =~ /^(\(\s*$Type\s*)\)/ && $av_pending eq '_') { 9081ec3f6f9SBlue Swirl print "CAST($1)\n" if ($dbg_values > 1); 9091ec3f6f9SBlue Swirl push(@av_paren_type, $type); 9101ec3f6f9SBlue Swirl $type = 'C'; 9111ec3f6f9SBlue Swirl 9121ec3f6f9SBlue Swirl } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\(|\s*$)/) { 9131ec3f6f9SBlue Swirl print "DECLARE($1)\n" if ($dbg_values > 1); 9141ec3f6f9SBlue Swirl $type = 'T'; 9151ec3f6f9SBlue Swirl 9161ec3f6f9SBlue Swirl } elsif ($cur =~ /^($Modifier)\s*/) { 9171ec3f6f9SBlue Swirl print "MODIFIER($1)\n" if ($dbg_values > 1); 9181ec3f6f9SBlue Swirl $type = 'T'; 9191ec3f6f9SBlue Swirl 9201ec3f6f9SBlue Swirl } elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) { 9211ec3f6f9SBlue Swirl print "DEFINE($1,$2)\n" if ($dbg_values > 1); 9221ec3f6f9SBlue Swirl $av_preprocessor = 1; 9231ec3f6f9SBlue Swirl push(@av_paren_type, $type); 9241ec3f6f9SBlue Swirl if ($2 ne '') { 9251ec3f6f9SBlue Swirl $av_pending = 'N'; 9261ec3f6f9SBlue Swirl } 9271ec3f6f9SBlue Swirl $type = 'E'; 9281ec3f6f9SBlue Swirl 9291ec3f6f9SBlue Swirl } elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) { 9301ec3f6f9SBlue Swirl print "UNDEF($1)\n" if ($dbg_values > 1); 9311ec3f6f9SBlue Swirl $av_preprocessor = 1; 9321ec3f6f9SBlue Swirl push(@av_paren_type, $type); 9331ec3f6f9SBlue Swirl 9341ec3f6f9SBlue Swirl } elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) { 9351ec3f6f9SBlue Swirl print "PRE_START($1)\n" if ($dbg_values > 1); 9361ec3f6f9SBlue Swirl $av_preprocessor = 1; 9371ec3f6f9SBlue Swirl 9381ec3f6f9SBlue Swirl push(@av_paren_type, $type); 9391ec3f6f9SBlue Swirl push(@av_paren_type, $type); 9401ec3f6f9SBlue Swirl $type = 'E'; 9411ec3f6f9SBlue Swirl 9421ec3f6f9SBlue Swirl } elsif ($cur =~ /^(\#\s*(?:else|elif))/o) { 9431ec3f6f9SBlue Swirl print "PRE_RESTART($1)\n" if ($dbg_values > 1); 9441ec3f6f9SBlue Swirl $av_preprocessor = 1; 9451ec3f6f9SBlue Swirl 9461ec3f6f9SBlue Swirl push(@av_paren_type, $av_paren_type[$#av_paren_type]); 9471ec3f6f9SBlue Swirl 9481ec3f6f9SBlue Swirl $type = 'E'; 9491ec3f6f9SBlue Swirl 9501ec3f6f9SBlue Swirl } elsif ($cur =~ /^(\#\s*(?:endif))/o) { 9511ec3f6f9SBlue Swirl print "PRE_END($1)\n" if ($dbg_values > 1); 9521ec3f6f9SBlue Swirl 9531ec3f6f9SBlue Swirl $av_preprocessor = 1; 9541ec3f6f9SBlue Swirl 9551ec3f6f9SBlue Swirl # Assume all arms of the conditional end as this 9561ec3f6f9SBlue Swirl # one does, and continue as if the #endif was not here. 9571ec3f6f9SBlue Swirl pop(@av_paren_type); 9581ec3f6f9SBlue Swirl push(@av_paren_type, $type); 9591ec3f6f9SBlue Swirl $type = 'E'; 9601ec3f6f9SBlue Swirl 9611ec3f6f9SBlue Swirl } elsif ($cur =~ /^(\\\n)/o) { 9621ec3f6f9SBlue Swirl print "PRECONT($1)\n" if ($dbg_values > 1); 9631ec3f6f9SBlue Swirl 9641ec3f6f9SBlue Swirl } elsif ($cur =~ /^(__attribute__)\s*\(?/o) { 9651ec3f6f9SBlue Swirl print "ATTR($1)\n" if ($dbg_values > 1); 9661ec3f6f9SBlue Swirl $av_pending = $type; 9671ec3f6f9SBlue Swirl $type = 'N'; 9681ec3f6f9SBlue Swirl 9691ec3f6f9SBlue Swirl } elsif ($cur =~ /^(sizeof)\s*(\()?/o) { 9701ec3f6f9SBlue Swirl print "SIZEOF($1)\n" if ($dbg_values > 1); 9711ec3f6f9SBlue Swirl if (defined $2) { 9721ec3f6f9SBlue Swirl $av_pending = 'V'; 9731ec3f6f9SBlue Swirl } 9741ec3f6f9SBlue Swirl $type = 'N'; 9751ec3f6f9SBlue Swirl 9761ec3f6f9SBlue Swirl } elsif ($cur =~ /^(if|while|for)\b/o) { 9771ec3f6f9SBlue Swirl print "COND($1)\n" if ($dbg_values > 1); 9781ec3f6f9SBlue Swirl $av_pending = 'E'; 9791ec3f6f9SBlue Swirl $type = 'N'; 9801ec3f6f9SBlue Swirl 9811ec3f6f9SBlue Swirl } elsif ($cur =~/^(case)/o) { 9821ec3f6f9SBlue Swirl print "CASE($1)\n" if ($dbg_values > 1); 9831ec3f6f9SBlue Swirl $av_pend_colon = 'C'; 9841ec3f6f9SBlue Swirl $type = 'N'; 9851ec3f6f9SBlue Swirl 9861ec3f6f9SBlue Swirl } elsif ($cur =~/^(return|else|goto|typeof|__typeof__)\b/o) { 9871ec3f6f9SBlue Swirl print "KEYWORD($1)\n" if ($dbg_values > 1); 9881ec3f6f9SBlue Swirl $type = 'N'; 9891ec3f6f9SBlue Swirl 9901ec3f6f9SBlue Swirl } elsif ($cur =~ /^(\()/o) { 9911ec3f6f9SBlue Swirl print "PAREN('$1')\n" if ($dbg_values > 1); 9921ec3f6f9SBlue Swirl push(@av_paren_type, $av_pending); 9931ec3f6f9SBlue Swirl $av_pending = '_'; 9941ec3f6f9SBlue Swirl $type = 'N'; 9951ec3f6f9SBlue Swirl 9961ec3f6f9SBlue Swirl } elsif ($cur =~ /^(\))/o) { 9971ec3f6f9SBlue Swirl my $new_type = pop(@av_paren_type); 9981ec3f6f9SBlue Swirl if ($new_type ne '_') { 9991ec3f6f9SBlue Swirl $type = $new_type; 10001ec3f6f9SBlue Swirl print "PAREN('$1') -> $type\n" 10011ec3f6f9SBlue Swirl if ($dbg_values > 1); 10021ec3f6f9SBlue Swirl } else { 10031ec3f6f9SBlue Swirl print "PAREN('$1')\n" if ($dbg_values > 1); 10041ec3f6f9SBlue Swirl } 10051ec3f6f9SBlue Swirl 10061ec3f6f9SBlue Swirl } elsif ($cur =~ /^($Ident)\s*\(/o) { 10071ec3f6f9SBlue Swirl print "FUNC($1)\n" if ($dbg_values > 1); 10081ec3f6f9SBlue Swirl $type = 'V'; 10091ec3f6f9SBlue Swirl $av_pending = 'V'; 10101ec3f6f9SBlue Swirl 10111ec3f6f9SBlue Swirl } elsif ($cur =~ /^($Ident\s*):(?:\s*\d+\s*(,|=|;))?/) { 10121ec3f6f9SBlue Swirl if (defined $2 && $type eq 'C' || $type eq 'T') { 10131ec3f6f9SBlue Swirl $av_pend_colon = 'B'; 10141ec3f6f9SBlue Swirl } elsif ($type eq 'E') { 10151ec3f6f9SBlue Swirl $av_pend_colon = 'L'; 10161ec3f6f9SBlue Swirl } 10171ec3f6f9SBlue Swirl print "IDENT_COLON($1,$type>$av_pend_colon)\n" if ($dbg_values > 1); 10181ec3f6f9SBlue Swirl $type = 'V'; 10191ec3f6f9SBlue Swirl 10201ec3f6f9SBlue Swirl } elsif ($cur =~ /^($Ident|$Constant)/o) { 10211ec3f6f9SBlue Swirl print "IDENT($1)\n" if ($dbg_values > 1); 10221ec3f6f9SBlue Swirl $type = 'V'; 10231ec3f6f9SBlue Swirl 10241ec3f6f9SBlue Swirl } elsif ($cur =~ /^($Assignment)/o) { 10251ec3f6f9SBlue Swirl print "ASSIGN($1)\n" if ($dbg_values > 1); 10261ec3f6f9SBlue Swirl $type = 'N'; 10271ec3f6f9SBlue Swirl 10281ec3f6f9SBlue Swirl } elsif ($cur =~/^(;|{|})/) { 10291ec3f6f9SBlue Swirl print "END($1)\n" if ($dbg_values > 1); 10301ec3f6f9SBlue Swirl $type = 'E'; 10311ec3f6f9SBlue Swirl $av_pend_colon = 'O'; 10321ec3f6f9SBlue Swirl 10331ec3f6f9SBlue Swirl } elsif ($cur =~/^(,)/) { 10341ec3f6f9SBlue Swirl print "COMMA($1)\n" if ($dbg_values > 1); 10351ec3f6f9SBlue Swirl $type = 'C'; 10361ec3f6f9SBlue Swirl 10371ec3f6f9SBlue Swirl } elsif ($cur =~ /^(\?)/o) { 10381ec3f6f9SBlue Swirl print "QUESTION($1)\n" if ($dbg_values > 1); 10391ec3f6f9SBlue Swirl $type = 'N'; 10401ec3f6f9SBlue Swirl 10411ec3f6f9SBlue Swirl } elsif ($cur =~ /^(:)/o) { 10421ec3f6f9SBlue Swirl print "COLON($1,$av_pend_colon)\n" if ($dbg_values > 1); 10431ec3f6f9SBlue Swirl 10441ec3f6f9SBlue Swirl substr($var, length($res), 1, $av_pend_colon); 10451ec3f6f9SBlue Swirl if ($av_pend_colon eq 'C' || $av_pend_colon eq 'L') { 10461ec3f6f9SBlue Swirl $type = 'E'; 10471ec3f6f9SBlue Swirl } else { 10481ec3f6f9SBlue Swirl $type = 'N'; 10491ec3f6f9SBlue Swirl } 10501ec3f6f9SBlue Swirl $av_pend_colon = 'O'; 10511ec3f6f9SBlue Swirl 10521ec3f6f9SBlue Swirl } elsif ($cur =~ /^(\[)/o) { 10531ec3f6f9SBlue Swirl print "CLOSE($1)\n" if ($dbg_values > 1); 10541ec3f6f9SBlue Swirl $type = 'N'; 10551ec3f6f9SBlue Swirl 10561ec3f6f9SBlue Swirl } elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) { 10571ec3f6f9SBlue Swirl my $variant; 10581ec3f6f9SBlue Swirl 10591ec3f6f9SBlue Swirl print "OPV($1)\n" if ($dbg_values > 1); 10601ec3f6f9SBlue Swirl if ($type eq 'V') { 10611ec3f6f9SBlue Swirl $variant = 'B'; 10621ec3f6f9SBlue Swirl } else { 10631ec3f6f9SBlue Swirl $variant = 'U'; 10641ec3f6f9SBlue Swirl } 10651ec3f6f9SBlue Swirl 10661ec3f6f9SBlue Swirl substr($var, length($res), 1, $variant); 10671ec3f6f9SBlue Swirl $type = 'N'; 10681ec3f6f9SBlue Swirl 10691ec3f6f9SBlue Swirl } elsif ($cur =~ /^($Operators)/o) { 10701ec3f6f9SBlue Swirl print "OP($1)\n" if ($dbg_values > 1); 10711ec3f6f9SBlue Swirl if ($1 ne '++' && $1 ne '--') { 10721ec3f6f9SBlue Swirl $type = 'N'; 10731ec3f6f9SBlue Swirl } 10741ec3f6f9SBlue Swirl 10751ec3f6f9SBlue Swirl } elsif ($cur =~ /(^.)/o) { 10761ec3f6f9SBlue Swirl print "C($1)\n" if ($dbg_values > 1); 10771ec3f6f9SBlue Swirl } 10781ec3f6f9SBlue Swirl if (defined $1) { 10791ec3f6f9SBlue Swirl $cur = substr($cur, length($1)); 10801ec3f6f9SBlue Swirl $res .= $type x length($1); 10811ec3f6f9SBlue Swirl } 10821ec3f6f9SBlue Swirl } 10831ec3f6f9SBlue Swirl 10841ec3f6f9SBlue Swirl return ($res, $var); 10851ec3f6f9SBlue Swirl} 10861ec3f6f9SBlue Swirl 10871ec3f6f9SBlue Swirlsub possible { 10881ec3f6f9SBlue Swirl my ($possible, $line) = @_; 10891ec3f6f9SBlue Swirl my $notPermitted = qr{(?: 10901ec3f6f9SBlue Swirl ^(?: 10911ec3f6f9SBlue Swirl $Modifier| 10921ec3f6f9SBlue Swirl $Storage| 10931ec3f6f9SBlue Swirl $Type| 10941ec3f6f9SBlue Swirl DEFINE_\S+ 10951ec3f6f9SBlue Swirl )$| 10961ec3f6f9SBlue Swirl ^(?: 10971ec3f6f9SBlue Swirl goto| 10981ec3f6f9SBlue Swirl return| 10991ec3f6f9SBlue Swirl case| 11001ec3f6f9SBlue Swirl else| 11011ec3f6f9SBlue Swirl asm|__asm__| 11023e5385fcSAndy Whitcroft do| 11033e5385fcSAndy Whitcroft \#| 11043e5385fcSAndy Whitcroft \#\# 11051ec3f6f9SBlue Swirl )(?:\s|$)| 11061ec3f6f9SBlue Swirl ^(?:typedef|struct|enum)\b 11071ec3f6f9SBlue Swirl )}x; 11081ec3f6f9SBlue Swirl warn "CHECK<$possible> ($line)\n" if ($dbg_possible > 2); 11091ec3f6f9SBlue Swirl if ($possible !~ $notPermitted) { 11101ec3f6f9SBlue Swirl # Check for modifiers. 11111ec3f6f9SBlue Swirl $possible =~ s/\s*$Storage\s*//g; 11121ec3f6f9SBlue Swirl $possible =~ s/\s*$Sparse\s*//g; 11131ec3f6f9SBlue Swirl if ($possible =~ /^\s*$/) { 11141ec3f6f9SBlue Swirl 11151ec3f6f9SBlue Swirl } elsif ($possible =~ /\s/) { 11161ec3f6f9SBlue Swirl $possible =~ s/\s*$Type\s*//g; 11171ec3f6f9SBlue Swirl for my $modifier (split(' ', $possible)) { 11181ec3f6f9SBlue Swirl if ($modifier !~ $notPermitted) { 11191ec3f6f9SBlue Swirl warn "MODIFIER: $modifier ($possible) ($line)\n" if ($dbg_possible); 11201ec3f6f9SBlue Swirl push(@modifierList, $modifier); 11211ec3f6f9SBlue Swirl } 11221ec3f6f9SBlue Swirl } 11231ec3f6f9SBlue Swirl 11241ec3f6f9SBlue Swirl } else { 11251ec3f6f9SBlue Swirl warn "POSSIBLE: $possible ($line)\n" if ($dbg_possible); 11261ec3f6f9SBlue Swirl push(@typeList, $possible); 11271ec3f6f9SBlue Swirl } 11281ec3f6f9SBlue Swirl build_types(); 11291ec3f6f9SBlue Swirl } else { 11301ec3f6f9SBlue Swirl warn "NOTPOSS: $possible ($line)\n" if ($dbg_possible > 1); 11311ec3f6f9SBlue Swirl } 11321ec3f6f9SBlue Swirl} 11331ec3f6f9SBlue Swirl 11341ec3f6f9SBlue Swirlmy $prefix = ''; 11351ec3f6f9SBlue Swirl 11361ec3f6f9SBlue Swirlsub report { 11371ec3f6f9SBlue Swirl if (defined $tst_only && $_[0] !~ /\Q$tst_only\E/) { 11381ec3f6f9SBlue Swirl return 0; 11391ec3f6f9SBlue Swirl } 11401ec3f6f9SBlue Swirl my $line = $prefix . $_[0]; 11411ec3f6f9SBlue Swirl 11421ec3f6f9SBlue Swirl $line = (split('\n', $line))[0] . "\n" if ($terse); 11431ec3f6f9SBlue Swirl 11441ec3f6f9SBlue Swirl push(our @report, $line); 11451ec3f6f9SBlue Swirl 11461ec3f6f9SBlue Swirl return 1; 11471ec3f6f9SBlue Swirl} 11481ec3f6f9SBlue Swirlsub report_dump { 11491ec3f6f9SBlue Swirl our @report; 11501ec3f6f9SBlue Swirl} 11511ec3f6f9SBlue Swirlsub ERROR { 11521ec3f6f9SBlue Swirl if (report("ERROR: $_[0]\n")) { 11531ec3f6f9SBlue Swirl our $clean = 0; 11541ec3f6f9SBlue Swirl our $cnt_error++; 11551ec3f6f9SBlue Swirl } 11561ec3f6f9SBlue Swirl} 11571ec3f6f9SBlue Swirlsub WARN { 11581ec3f6f9SBlue Swirl if (report("WARNING: $_[0]\n")) { 11591ec3f6f9SBlue Swirl our $clean = 0; 11601ec3f6f9SBlue Swirl our $cnt_warn++; 11611ec3f6f9SBlue Swirl } 11621ec3f6f9SBlue Swirl} 11631ec3f6f9SBlue Swirl 11641ec3f6f9SBlue Swirlsub process { 11651ec3f6f9SBlue Swirl my $filename = shift; 11661ec3f6f9SBlue Swirl 11671ec3f6f9SBlue Swirl my $linenr=0; 11681ec3f6f9SBlue Swirl my $prevline=""; 11691ec3f6f9SBlue Swirl my $prevrawline=""; 11701ec3f6f9SBlue Swirl my $stashline=""; 11711ec3f6f9SBlue Swirl my $stashrawline=""; 11721ec3f6f9SBlue Swirl 11731ec3f6f9SBlue Swirl my $length; 11741ec3f6f9SBlue Swirl my $indent; 11751ec3f6f9SBlue Swirl my $previndent=0; 11761ec3f6f9SBlue Swirl my $stashindent=0; 11771ec3f6f9SBlue Swirl 11781ec3f6f9SBlue Swirl our $clean = 1; 11791ec3f6f9SBlue Swirl my $signoff = 0; 11801ec3f6f9SBlue Swirl my $is_patch = 0; 11811ec3f6f9SBlue Swirl 11821ec3f6f9SBlue Swirl our @report = (); 11831ec3f6f9SBlue Swirl our $cnt_lines = 0; 11841ec3f6f9SBlue Swirl our $cnt_error = 0; 11851ec3f6f9SBlue Swirl our $cnt_warn = 0; 11861ec3f6f9SBlue Swirl our $cnt_chk = 0; 11871ec3f6f9SBlue Swirl 11881ec3f6f9SBlue Swirl # Trace the real file/line as we go. 11891ec3f6f9SBlue Swirl my $realfile = ''; 11901ec3f6f9SBlue Swirl my $realline = 0; 11911ec3f6f9SBlue Swirl my $realcnt = 0; 11921ec3f6f9SBlue Swirl my $here = ''; 11931ec3f6f9SBlue Swirl my $in_comment = 0; 11941ec3f6f9SBlue Swirl my $comment_edge = 0; 11951ec3f6f9SBlue Swirl my $first_line = 0; 11961ec3f6f9SBlue Swirl my $p1_prefix = ''; 11971ec3f6f9SBlue Swirl 11981ec3f6f9SBlue Swirl my $prev_values = 'E'; 11991ec3f6f9SBlue Swirl 12001ec3f6f9SBlue Swirl # suppression flags 12011ec3f6f9SBlue Swirl my %suppress_ifbraces; 12021ec3f6f9SBlue Swirl my %suppress_whiletrailers; 12031ec3f6f9SBlue Swirl my %suppress_export; 12041ec3f6f9SBlue Swirl 12051ec3f6f9SBlue Swirl # Pre-scan the patch sanitizing the lines. 12061ec3f6f9SBlue Swirl 12071ec3f6f9SBlue Swirl sanitise_line_reset(); 12081ec3f6f9SBlue Swirl my $line; 12091ec3f6f9SBlue Swirl foreach my $rawline (@rawlines) { 12101ec3f6f9SBlue Swirl $linenr++; 12111ec3f6f9SBlue Swirl $line = $rawline; 12121ec3f6f9SBlue Swirl 12131ec3f6f9SBlue Swirl if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) { 12141ec3f6f9SBlue Swirl $realline=$1-1; 12151ec3f6f9SBlue Swirl if (defined $2) { 12161ec3f6f9SBlue Swirl $realcnt=$3+1; 12171ec3f6f9SBlue Swirl } else { 12181ec3f6f9SBlue Swirl $realcnt=1+1; 12191ec3f6f9SBlue Swirl } 12201ec3f6f9SBlue Swirl $in_comment = 0; 12211ec3f6f9SBlue Swirl 12221ec3f6f9SBlue Swirl # Guestimate if this is a continuing comment. Run 12231ec3f6f9SBlue Swirl # the context looking for a comment "edge". If this 12241ec3f6f9SBlue Swirl # edge is a close comment then we must be in a comment 12251ec3f6f9SBlue Swirl # at context start. 12261ec3f6f9SBlue Swirl my $edge; 12271ec3f6f9SBlue Swirl my $cnt = $realcnt; 12281ec3f6f9SBlue Swirl for (my $ln = $linenr + 1; $cnt > 0; $ln++) { 12291ec3f6f9SBlue Swirl next if (defined $rawlines[$ln - 1] && 12301ec3f6f9SBlue Swirl $rawlines[$ln - 1] =~ /^-/); 12311ec3f6f9SBlue Swirl $cnt--; 12321ec3f6f9SBlue Swirl #print "RAW<$rawlines[$ln - 1]>\n"; 12331ec3f6f9SBlue Swirl last if (!defined $rawlines[$ln - 1]); 12341ec3f6f9SBlue Swirl if ($rawlines[$ln - 1] =~ m@(/\*|\*/)@ && 12351ec3f6f9SBlue Swirl $rawlines[$ln - 1] !~ m@"[^"]*(?:/\*|\*/)[^"]*"@) { 12361ec3f6f9SBlue Swirl ($edge) = $1; 12371ec3f6f9SBlue Swirl last; 12381ec3f6f9SBlue Swirl } 12391ec3f6f9SBlue Swirl } 12401ec3f6f9SBlue Swirl if (defined $edge && $edge eq '*/') { 12411ec3f6f9SBlue Swirl $in_comment = 1; 12421ec3f6f9SBlue Swirl } 12431ec3f6f9SBlue Swirl 12441ec3f6f9SBlue Swirl # Guestimate if this is a continuing comment. If this 12451ec3f6f9SBlue Swirl # is the start of a diff block and this line starts 12461ec3f6f9SBlue Swirl # ' *' then it is very likely a comment. 12471ec3f6f9SBlue Swirl if (!defined $edge && 12481ec3f6f9SBlue Swirl $rawlines[$linenr] =~ m@^.\s*(?:\*\*+| \*)(?:\s|$)@) 12491ec3f6f9SBlue Swirl { 12501ec3f6f9SBlue Swirl $in_comment = 1; 12511ec3f6f9SBlue Swirl } 12521ec3f6f9SBlue Swirl 12531ec3f6f9SBlue Swirl ##print "COMMENT:$in_comment edge<$edge> $rawline\n"; 12541ec3f6f9SBlue Swirl sanitise_line_reset($in_comment); 12551ec3f6f9SBlue Swirl 12561ec3f6f9SBlue Swirl } elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) { 12571ec3f6f9SBlue Swirl # Standardise the strings and chars within the input to 12581ec3f6f9SBlue Swirl # simplify matching -- only bother with positive lines. 12591ec3f6f9SBlue Swirl $line = sanitise_line($rawline); 12601ec3f6f9SBlue Swirl } 12611ec3f6f9SBlue Swirl push(@lines, $line); 12621ec3f6f9SBlue Swirl 12631ec3f6f9SBlue Swirl if ($realcnt > 1) { 12641ec3f6f9SBlue Swirl $realcnt-- if ($line =~ /^(?:\+| |$)/); 12651ec3f6f9SBlue Swirl } else { 12661ec3f6f9SBlue Swirl $realcnt = 0; 12671ec3f6f9SBlue Swirl } 12681ec3f6f9SBlue Swirl 12691ec3f6f9SBlue Swirl #print "==>$rawline\n"; 12701ec3f6f9SBlue Swirl #print "-->$line\n"; 12711ec3f6f9SBlue Swirl } 12721ec3f6f9SBlue Swirl 12731ec3f6f9SBlue Swirl $prefix = ''; 12741ec3f6f9SBlue Swirl 12751ec3f6f9SBlue Swirl $realcnt = 0; 12761ec3f6f9SBlue Swirl $linenr = 0; 12771ec3f6f9SBlue Swirl foreach my $line (@lines) { 12781ec3f6f9SBlue Swirl $linenr++; 12791ec3f6f9SBlue Swirl 12801ec3f6f9SBlue Swirl my $rawline = $rawlines[$linenr - 1]; 12811ec3f6f9SBlue Swirl 12821ec3f6f9SBlue Swirl#extract the line range in the file after the patch is applied 12831ec3f6f9SBlue Swirl if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) { 12841ec3f6f9SBlue Swirl $is_patch = 1; 12851ec3f6f9SBlue Swirl $first_line = $linenr + 1; 12861ec3f6f9SBlue Swirl $realline=$1-1; 12871ec3f6f9SBlue Swirl if (defined $2) { 12881ec3f6f9SBlue Swirl $realcnt=$3+1; 12891ec3f6f9SBlue Swirl } else { 12901ec3f6f9SBlue Swirl $realcnt=1+1; 12911ec3f6f9SBlue Swirl } 12921ec3f6f9SBlue Swirl annotate_reset(); 12931ec3f6f9SBlue Swirl $prev_values = 'E'; 12941ec3f6f9SBlue Swirl 12951ec3f6f9SBlue Swirl %suppress_ifbraces = (); 12961ec3f6f9SBlue Swirl %suppress_whiletrailers = (); 12971ec3f6f9SBlue Swirl %suppress_export = (); 12981ec3f6f9SBlue Swirl next; 12991ec3f6f9SBlue Swirl 13001ec3f6f9SBlue Swirl# track the line number as we move through the hunk, note that 13011ec3f6f9SBlue Swirl# new versions of GNU diff omit the leading space on completely 13021ec3f6f9SBlue Swirl# blank context lines so we need to count that too. 13031ec3f6f9SBlue Swirl } elsif ($line =~ /^( |\+|$)/) { 13041ec3f6f9SBlue Swirl $realline++; 13051ec3f6f9SBlue Swirl $realcnt-- if ($realcnt != 0); 13061ec3f6f9SBlue Swirl 13071ec3f6f9SBlue Swirl # Measure the line length and indent. 13081ec3f6f9SBlue Swirl ($length, $indent) = line_stats($rawline); 13091ec3f6f9SBlue Swirl 13101ec3f6f9SBlue Swirl # Track the previous line. 13111ec3f6f9SBlue Swirl ($prevline, $stashline) = ($stashline, $line); 13121ec3f6f9SBlue Swirl ($previndent, $stashindent) = ($stashindent, $indent); 13131ec3f6f9SBlue Swirl ($prevrawline, $stashrawline) = ($stashrawline, $rawline); 13141ec3f6f9SBlue Swirl 13151ec3f6f9SBlue Swirl #warn "line<$line>\n"; 13161ec3f6f9SBlue Swirl 13171ec3f6f9SBlue Swirl } elsif ($realcnt == 1) { 13181ec3f6f9SBlue Swirl $realcnt--; 13191ec3f6f9SBlue Swirl } 13201ec3f6f9SBlue Swirl 13211ec3f6f9SBlue Swirl my $hunk_line = ($realcnt != 0); 13221ec3f6f9SBlue Swirl 13231ec3f6f9SBlue Swirl#make up the handle for any error we report on this line 13241ec3f6f9SBlue Swirl $prefix = "$filename:$realline: " if ($emacs && $file); 13251ec3f6f9SBlue Swirl $prefix = "$filename:$linenr: " if ($emacs && !$file); 13261ec3f6f9SBlue Swirl 13271ec3f6f9SBlue Swirl $here = "#$linenr: " if (!$file); 13281ec3f6f9SBlue Swirl $here = "#$realline: " if ($file); 13291ec3f6f9SBlue Swirl 13301ec3f6f9SBlue Swirl # extract the filename as it passes 13311ec3f6f9SBlue Swirl if ($line =~ /^diff --git.*?(\S+)$/) { 13321ec3f6f9SBlue Swirl $realfile = $1; 13331ec3f6f9SBlue Swirl $realfile =~ s@^([^/]*)/@@; 13341ec3f6f9SBlue Swirl 13351ec3f6f9SBlue Swirl } elsif ($line =~ /^\+\+\+\s+(\S+)/) { 13361ec3f6f9SBlue Swirl $realfile = $1; 13371ec3f6f9SBlue Swirl $realfile =~ s@^([^/]*)/@@; 13381ec3f6f9SBlue Swirl 13391ec3f6f9SBlue Swirl $p1_prefix = $1; 13401ec3f6f9SBlue Swirl if (!$file && $tree && $p1_prefix ne '' && 13411ec3f6f9SBlue Swirl -e "$root/$p1_prefix") { 13421ec3f6f9SBlue Swirl WARN("patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n"); 13431ec3f6f9SBlue Swirl } 13441ec3f6f9SBlue Swirl 13451ec3f6f9SBlue Swirl next; 13461ec3f6f9SBlue Swirl } 13471ec3f6f9SBlue Swirl 13481ec3f6f9SBlue Swirl $here .= "FILE: $realfile:$realline:" if ($realcnt != 0); 13491ec3f6f9SBlue Swirl 13501ec3f6f9SBlue Swirl my $hereline = "$here\n$rawline\n"; 13511ec3f6f9SBlue Swirl my $herecurr = "$here\n$rawline\n"; 13521ec3f6f9SBlue Swirl my $hereprev = "$here\n$prevrawline\n$rawline\n"; 13531ec3f6f9SBlue Swirl 13541ec3f6f9SBlue Swirl $cnt_lines++ if ($realcnt != 0); 13551ec3f6f9SBlue Swirl 13561ec3f6f9SBlue Swirl# Check for incorrect file permissions 13571ec3f6f9SBlue Swirl if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) { 13581ec3f6f9SBlue Swirl my $permhere = $here . "FILE: $realfile\n"; 135971c47b01SPaolo Bonzini if ($realfile =~ /(\bMakefile(?:\.objs)?|\.c|\.cc|\.cpp|\.h|\.mak|\.[sS])$/) { 13601ec3f6f9SBlue Swirl ERROR("do not set execute permissions for source files\n" . $permhere); 13611ec3f6f9SBlue Swirl } 13621ec3f6f9SBlue Swirl } 13631ec3f6f9SBlue Swirl 1364f8dccbb6SStefan Hajnoczi# Accept git diff extended headers as valid patches 1365f8dccbb6SStefan Hajnoczi if ($line =~ /^(?:rename|copy) (?:from|to) [\w\/\.\-]+\s*$/) { 1366f8dccbb6SStefan Hajnoczi $is_patch = 1; 1367f8dccbb6SStefan Hajnoczi } 1368f8dccbb6SStefan Hajnoczi 13691ec3f6f9SBlue Swirl#check the patch for a signoff: 13701ec3f6f9SBlue Swirl if ($line =~ /^\s*signed-off-by:/i) { 13711ec3f6f9SBlue Swirl # This is a signoff, if ugly, so do not double report. 13721ec3f6f9SBlue Swirl $signoff++; 13731ec3f6f9SBlue Swirl if (!($line =~ /^\s*Signed-off-by:/)) { 1374c2df8783SPaolo Bonzini ERROR("The correct form is \"Signed-off-by\"\n" . 13751ec3f6f9SBlue Swirl $herecurr); 13761ec3f6f9SBlue Swirl } 13771ec3f6f9SBlue Swirl if ($line =~ /^\s*signed-off-by:\S/i) { 1378c2df8783SPaolo Bonzini ERROR("space required after Signed-off-by:\n" . 13791ec3f6f9SBlue Swirl $herecurr); 13801ec3f6f9SBlue Swirl } 13811ec3f6f9SBlue Swirl } 13821ec3f6f9SBlue Swirl 13831ec3f6f9SBlue Swirl# Check for wrappage within a valid hunk of the file 13841ec3f6f9SBlue Swirl if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) { 13851ec3f6f9SBlue Swirl ERROR("patch seems to be corrupt (line wrapped?)\n" . 13861ec3f6f9SBlue Swirl $herecurr) if (!$emitted_corrupt++); 13871ec3f6f9SBlue Swirl } 13881ec3f6f9SBlue Swirl 13891ec3f6f9SBlue Swirl# UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php 13901ec3f6f9SBlue Swirl if (($realfile =~ /^$/ || $line =~ /^\+/) && 13911ec3f6f9SBlue Swirl $rawline !~ m/^$UTF8*$/) { 13921ec3f6f9SBlue Swirl my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/); 13931ec3f6f9SBlue Swirl 13941ec3f6f9SBlue Swirl my $blank = copy_spacing($rawline); 13951ec3f6f9SBlue Swirl my $ptr = substr($blank, 0, length($utf8_prefix)) . "^"; 13961ec3f6f9SBlue Swirl my $hereptr = "$hereline$ptr\n"; 13971ec3f6f9SBlue Swirl 13981ec3f6f9SBlue Swirl ERROR("Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr); 13991ec3f6f9SBlue Swirl } 14001ec3f6f9SBlue Swirl 14011ec3f6f9SBlue Swirl# ignore non-hunk lines and lines being removed 14021ec3f6f9SBlue Swirl next if (!$hunk_line || $line =~ /^-/); 14031ec3f6f9SBlue Swirl 140493bf13c6SRadim Krčmář# ignore files that are being periodically imported from Linux 140593bf13c6SRadim Krčmář next if ($realfile =~ /^(linux-headers|include\/standard-headers)\//); 140693bf13c6SRadim Krčmář 14071ec3f6f9SBlue Swirl#trailing whitespace 14081ec3f6f9SBlue Swirl if ($line =~ /^\+.*\015/) { 14091ec3f6f9SBlue Swirl my $herevet = "$here\n" . cat_vet($rawline) . "\n"; 14101ec3f6f9SBlue Swirl ERROR("DOS line endings\n" . $herevet); 14111ec3f6f9SBlue Swirl 14120cebabd5SLluís Vilanova } elsif ($realfile =~ /^docs\/.+\.txt/ || 14130cebabd5SLluís Vilanova $realfile =~ /^docs\/.+\.md/) { 14140cebabd5SLluís Vilanova if ($rawline =~ /^\+\s+$/ && $rawline !~ /^\+ {4}$/) { 14150cebabd5SLluís Vilanova # TODO: properly check we're in a code block 14160cebabd5SLluís Vilanova # (surrounding text is 4-column aligned) 14170cebabd5SLluís Vilanova my $herevet = "$here\n" . cat_vet($rawline) . "\n"; 14180cebabd5SLluís Vilanova ERROR("code blocks in documentation should have " . 14190cebabd5SLluís Vilanova "empty lines with exactly 4 columns of " . 14200cebabd5SLluís Vilanova "whitespace\n" . $herevet); 14210cebabd5SLluís Vilanova } 14221ec3f6f9SBlue Swirl } elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) { 14231ec3f6f9SBlue Swirl my $herevet = "$here\n" . cat_vet($rawline) . "\n"; 14241ec3f6f9SBlue Swirl ERROR("trailing whitespace\n" . $herevet); 14251ec3f6f9SBlue Swirl $rpt_cleaners = 1; 14261ec3f6f9SBlue Swirl } 14271ec3f6f9SBlue Swirl 1428c3e5875aSVladimir Sementsov-Ogievskiy# checks for trace-events files 1429c3e5875aSVladimir Sementsov-Ogievskiy if ($realfile =~ /trace-events$/ && $line =~ /^\+/) { 1430c3e5875aSVladimir Sementsov-Ogievskiy if ($rawline =~ /%[-+ 0]*#/) { 1431c3e5875aSVladimir Sementsov-Ogievskiy ERROR("Don't use '#' flag of printf format ('%#') in " . 1432c3e5875aSVladimir Sementsov-Ogievskiy "trace-events, use '0x' prefix instead\n" . $herecurr); 1433c3e5875aSVladimir Sementsov-Ogievskiy } else { 1434c3e5875aSVladimir Sementsov-Ogievskiy my $hex = 1435c3e5875aSVladimir Sementsov-Ogievskiy qr/%[-+ *.0-9]*([hljztL]|ll|hh)?(x|X|"\s*PRI[xX][^"]*"?)/; 1436c3e5875aSVladimir Sementsov-Ogievskiy 1437c3e5875aSVladimir Sementsov-Ogievskiy # don't consider groups splitted by [.:/ ], like 2A.20:12ab 143845042732SVladimir Sementsov-Ogievskiy my $tmpline = $rawline; 143945042732SVladimir Sementsov-Ogievskiy $tmpline =~ s/($hex[.:\/ ])+$hex//g; 1440c3e5875aSVladimir Sementsov-Ogievskiy 1441c3e5875aSVladimir Sementsov-Ogievskiy if ($tmpline =~ /(?<!0x)$hex/) { 1442c3e5875aSVladimir Sementsov-Ogievskiy ERROR("Hex numbers must be prefixed with '0x'\n" . 1443c3e5875aSVladimir Sementsov-Ogievskiy $herecurr); 1444c3e5875aSVladimir Sementsov-Ogievskiy } 1445c3e5875aSVladimir Sementsov-Ogievskiy } 1446c3e5875aSVladimir Sementsov-Ogievskiy } 1447c3e5875aSVladimir Sementsov-Ogievskiy 14481ec3f6f9SBlue Swirl# check we are in a valid source file if not then ignore this hunk 1449777d05baSPaolo Bonzini next if ($realfile !~ /$SrcFile/); 14501ec3f6f9SBlue Swirl 1451205f31a8SEric Blake#90 column limit; exempt URLs, if no other words on line 1452f1e155bbSPaolo Bonzini if ($line =~ /^\+/ && 1453f1e155bbSPaolo Bonzini !($line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) && 1454205f31a8SEric Blake !($rawline =~ /^[^[:alnum:]]*https?:\S*$/) && 14551ec3f6f9SBlue Swirl $length > 80) 14561ec3f6f9SBlue Swirl { 14578fbe3d1fSPaolo Bonzini if ($length > 90) { 14588fbe3d1fSPaolo Bonzini ERROR("line over 90 characters\n" . $herecurr); 14598fbe3d1fSPaolo Bonzini } else { 14601ec3f6f9SBlue Swirl WARN("line over 80 characters\n" . $herecurr); 14611ec3f6f9SBlue Swirl } 14628fbe3d1fSPaolo Bonzini } 14631ec3f6f9SBlue Swirl 14641ec3f6f9SBlue Swirl# check for spaces before a quoted newline 14651ec3f6f9SBlue Swirl if ($rawline =~ /^.*\".*\s\\n/) { 1466c2df8783SPaolo Bonzini ERROR("unnecessary whitespace before a quoted newline\n" . $herecurr); 14671ec3f6f9SBlue Swirl } 14681ec3f6f9SBlue Swirl 14691ec3f6f9SBlue Swirl# check for adding lines without a newline. 14701ec3f6f9SBlue Swirl if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) { 1471c2df8783SPaolo Bonzini ERROR("adding a line without newline at end of file\n" . $herecurr); 14721ec3f6f9SBlue Swirl } 14731ec3f6f9SBlue Swirl 147493eb8e31SPaolo Bonzini# check for RCS/CVS revision markers 147593eb8e31SPaolo Bonzini if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|\b)/) { 1476c2df8783SPaolo Bonzini ERROR("CVS style keyword markers, these will _not_ be updated\n". $herecurr); 147793eb8e31SPaolo Bonzini } 147893eb8e31SPaolo Bonzini 1479906fb135SPaolo Bonzini# tabs are only allowed in assembly source code, and in 1480906fb135SPaolo Bonzini# some scripts we imported from other projects. 1481906fb135SPaolo Bonzini next if ($realfile =~ /\.(s|S)$/); 1482906fb135SPaolo Bonzini next if ($realfile =~ /(checkpatch|get_maintainer|texi2pod)\.pl$/); 14831ec3f6f9SBlue Swirl 1484ad36ce8bSBlue Swirl if ($rawline =~ /^\+.*\t/) { 14851ec3f6f9SBlue Swirl my $herevet = "$here\n" . cat_vet($rawline) . "\n"; 1486b6469683SBlue Swirl ERROR("code indent should never use tabs\n" . $herevet); 14871ec3f6f9SBlue Swirl $rpt_cleaners = 1; 14881ec3f6f9SBlue Swirl } 14891ec3f6f9SBlue Swirl 14901ec3f6f9SBlue Swirl# check we are in a valid C source file if not then ignore this hunk 149169d5d21fSTomoki Sekiyama next if ($realfile !~ /\.(h|c|cpp)$/); 14921ec3f6f9SBlue Swirl 14931ec3f6f9SBlue Swirl# Check for potential 'bare' types 14941ec3f6f9SBlue Swirl my ($stat, $cond, $line_nr_next, $remain_next, $off_next, 14951ec3f6f9SBlue Swirl $realline_next); 14961ec3f6f9SBlue Swirl if ($realcnt && $line =~ /.\s*\S/) { 14971ec3f6f9SBlue Swirl ($stat, $cond, $line_nr_next, $remain_next, $off_next) = 14981ec3f6f9SBlue Swirl ctx_statement_block($linenr, $realcnt, 0); 14991ec3f6f9SBlue Swirl $stat =~ s/\n./\n /g; 15001ec3f6f9SBlue Swirl $cond =~ s/\n./\n /g; 15011ec3f6f9SBlue Swirl 15021ec3f6f9SBlue Swirl # Find the real next line. 15031ec3f6f9SBlue Swirl $realline_next = $line_nr_next; 15041ec3f6f9SBlue Swirl if (defined $realline_next && 15051ec3f6f9SBlue Swirl (!defined $lines[$realline_next - 1] || 15061ec3f6f9SBlue Swirl substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) { 15071ec3f6f9SBlue Swirl $realline_next++; 15081ec3f6f9SBlue Swirl } 15091ec3f6f9SBlue Swirl 15101ec3f6f9SBlue Swirl my $s = $stat; 15111ec3f6f9SBlue Swirl $s =~ s/{.*$//s; 15121ec3f6f9SBlue Swirl 15131ec3f6f9SBlue Swirl # Ignore goto labels. 15141ec3f6f9SBlue Swirl if ($s =~ /$Ident:\*$/s) { 15151ec3f6f9SBlue Swirl 15161ec3f6f9SBlue Swirl # Ignore functions being called 15171ec3f6f9SBlue Swirl } elsif ($s =~ /^.\s*$Ident\s*\(/s) { 15181ec3f6f9SBlue Swirl 15191ec3f6f9SBlue Swirl } elsif ($s =~ /^.\s*else\b/s) { 15201ec3f6f9SBlue Swirl 15211ec3f6f9SBlue Swirl # declarations always start with types 15221ec3f6f9SBlue Swirl } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) { 15231ec3f6f9SBlue Swirl my $type = $1; 15241ec3f6f9SBlue Swirl $type =~ s/\s+/ /g; 15251ec3f6f9SBlue Swirl possible($type, "A:" . $s); 15261ec3f6f9SBlue Swirl 15271ec3f6f9SBlue Swirl # definitions in global scope can only start with types 15281ec3f6f9SBlue Swirl } elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b\s*(?!:)/s) { 15291ec3f6f9SBlue Swirl possible($1, "B:" . $s); 15301ec3f6f9SBlue Swirl } 15311ec3f6f9SBlue Swirl 15321ec3f6f9SBlue Swirl # any (foo ... *) is a pointer cast, and foo is a type 15331ec3f6f9SBlue Swirl while ($s =~ /\(($Ident)(?:\s+$Sparse)*[\s\*]+\s*\)/sg) { 15341ec3f6f9SBlue Swirl possible($1, "C:" . $s); 15351ec3f6f9SBlue Swirl } 15361ec3f6f9SBlue Swirl 15371ec3f6f9SBlue Swirl # Check for any sort of function declaration. 15381ec3f6f9SBlue Swirl # int foo(something bar, other baz); 15391ec3f6f9SBlue Swirl # void (*store_gdt)(x86_descr_ptr *); 15401ec3f6f9SBlue Swirl if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) { 15411ec3f6f9SBlue Swirl my ($name_len) = length($1); 15421ec3f6f9SBlue Swirl 15431ec3f6f9SBlue Swirl my $ctx = $s; 15441ec3f6f9SBlue Swirl substr($ctx, 0, $name_len + 1, ''); 15451ec3f6f9SBlue Swirl $ctx =~ s/\)[^\)]*$//; 15461ec3f6f9SBlue Swirl 15471ec3f6f9SBlue Swirl for my $arg (split(/\s*,\s*/, $ctx)) { 15481ec3f6f9SBlue Swirl if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) { 15491ec3f6f9SBlue Swirl 15501ec3f6f9SBlue Swirl possible($1, "D:" . $s); 15511ec3f6f9SBlue Swirl } 15521ec3f6f9SBlue Swirl } 15531ec3f6f9SBlue Swirl } 15541ec3f6f9SBlue Swirl 15551ec3f6f9SBlue Swirl } 15561ec3f6f9SBlue Swirl 15571ec3f6f9SBlue Swirl# 15581ec3f6f9SBlue Swirl# Checks which may be anchored in the context. 15591ec3f6f9SBlue Swirl# 15601ec3f6f9SBlue Swirl 15611ec3f6f9SBlue Swirl# Check for switch () and associated case and default 15621ec3f6f9SBlue Swirl# statements should be at the same indent. 15631ec3f6f9SBlue Swirl if ($line=~/\bswitch\s*\(.*\)/) { 15641ec3f6f9SBlue Swirl my $err = ''; 15651ec3f6f9SBlue Swirl my $sep = ''; 15661ec3f6f9SBlue Swirl my @ctx = ctx_block_outer($linenr, $realcnt); 15671ec3f6f9SBlue Swirl shift(@ctx); 15681ec3f6f9SBlue Swirl for my $ctx (@ctx) { 15691ec3f6f9SBlue Swirl my ($clen, $cindent) = line_stats($ctx); 15701ec3f6f9SBlue Swirl if ($ctx =~ /^\+\s*(case\s+|default:)/ && 15711ec3f6f9SBlue Swirl $indent != $cindent) { 15721ec3f6f9SBlue Swirl $err .= "$sep$ctx\n"; 15731ec3f6f9SBlue Swirl $sep = ''; 15741ec3f6f9SBlue Swirl } else { 15751ec3f6f9SBlue Swirl $sep = "[...]\n"; 15761ec3f6f9SBlue Swirl } 15771ec3f6f9SBlue Swirl } 15781ec3f6f9SBlue Swirl if ($err ne '') { 15791ec3f6f9SBlue Swirl ERROR("switch and case should be at the same indent\n$hereline$err"); 15801ec3f6f9SBlue Swirl } 15811ec3f6f9SBlue Swirl } 15821ec3f6f9SBlue Swirl 15831ec3f6f9SBlue Swirl# if/while/etc brace do not go on next line, unless defining a do while loop, 15841ec3f6f9SBlue Swirl# or if that brace on the next line is for something else 15851ec3f6f9SBlue Swirl if ($line =~ /(.*)\b((?:if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) { 15861ec3f6f9SBlue Swirl my $pre_ctx = "$1$2"; 15871ec3f6f9SBlue Swirl 15881ec3f6f9SBlue Swirl my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0); 15891ec3f6f9SBlue Swirl my $ctx_cnt = $realcnt - $#ctx - 1; 15901ec3f6f9SBlue Swirl my $ctx = join("\n", @ctx); 15911ec3f6f9SBlue Swirl 15921ec3f6f9SBlue Swirl my $ctx_ln = $linenr; 15931ec3f6f9SBlue Swirl my $ctx_skip = $realcnt; 15941ec3f6f9SBlue Swirl 15951ec3f6f9SBlue Swirl while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt && 15961ec3f6f9SBlue Swirl defined $lines[$ctx_ln - 1] && 15971ec3f6f9SBlue Swirl $lines[$ctx_ln - 1] =~ /^-/)) { 15981ec3f6f9SBlue Swirl ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n"; 15991ec3f6f9SBlue Swirl $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/); 16001ec3f6f9SBlue Swirl $ctx_ln++; 16011ec3f6f9SBlue Swirl } 16021ec3f6f9SBlue Swirl 16031ec3f6f9SBlue Swirl #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n"; 16041ec3f6f9SBlue Swirl #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n"; 16051ec3f6f9SBlue Swirl 1606a97ceca5SMax Reitz # The length of the "previous line" is checked against 80 because it 1607a97ceca5SMax Reitz # includes the + at the beginning of the line (if the actual line has 1608a97ceca5SMax Reitz # 79 or 80 characters, it is no longer possible to add a space and an 1609a97ceca5SMax Reitz # opening brace there) 1610a97ceca5SMax Reitz if ($#ctx == 0 && $ctx !~ /{\s*/ && 161104f2562fSFam Zheng defined($lines[$ctx_ln - 1]) && $lines[$ctx_ln - 1] =~ /^\+\s*\{/ && 1612a97ceca5SMax Reitz defined($lines[$ctx_ln - 2]) && length($lines[$ctx_ln - 2]) < 80) { 16131ec3f6f9SBlue Swirl ERROR("that open brace { should be on the previous line\n" . 16141ec3f6f9SBlue Swirl "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n"); 16151ec3f6f9SBlue Swirl } 16161ec3f6f9SBlue Swirl if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ && 16171ec3f6f9SBlue Swirl $ctx =~ /\)\s*\;\s*$/ && 16181ec3f6f9SBlue Swirl defined $lines[$ctx_ln - 1]) 16191ec3f6f9SBlue Swirl { 16201ec3f6f9SBlue Swirl my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]); 16211ec3f6f9SBlue Swirl if ($nindent > $indent) { 1622c2df8783SPaolo Bonzini ERROR("trailing semicolon indicates no statements, indent implies otherwise\n" . 16231ec3f6f9SBlue Swirl "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n"); 16241ec3f6f9SBlue Swirl } 16251ec3f6f9SBlue Swirl } 16261ec3f6f9SBlue Swirl } 16271ec3f6f9SBlue Swirl 1628f4bdc13eSEric Blake# 'do ... while (0/false)' only makes sense in macros, without trailing ';' 1629f4bdc13eSEric Blake if ($line =~ /while\s*\((0|false)\);/) { 1630f4bdc13eSEric Blake ERROR("suspicious ; after while (0)\n" . $herecurr); 1631f4bdc13eSEric Blake } 1632f4bdc13eSEric Blake 16331ec3f6f9SBlue Swirl# Check relative indent for conditionals and blocks. 16341ec3f6f9SBlue Swirl if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) { 16351ec3f6f9SBlue Swirl my ($s, $c) = ($stat, $cond); 16361ec3f6f9SBlue Swirl 16371ec3f6f9SBlue Swirl substr($s, 0, length($c), ''); 16381ec3f6f9SBlue Swirl 16391ec3f6f9SBlue Swirl # Make sure we remove the line prefixes as we have 16401ec3f6f9SBlue Swirl # none on the first line, and are going to readd them 16411ec3f6f9SBlue Swirl # where necessary. 16421ec3f6f9SBlue Swirl $s =~ s/\n./\n/gs; 16431ec3f6f9SBlue Swirl 16441ec3f6f9SBlue Swirl # Find out how long the conditional actually is. 16451ec3f6f9SBlue Swirl my @newlines = ($c =~ /\n/gs); 16461ec3f6f9SBlue Swirl my $cond_lines = 1 + $#newlines; 16471ec3f6f9SBlue Swirl 16481ec3f6f9SBlue Swirl # We want to check the first line inside the block 16491ec3f6f9SBlue Swirl # starting at the end of the conditional, so remove: 16501ec3f6f9SBlue Swirl # 1) any blank line termination 16511ec3f6f9SBlue Swirl # 2) any opening brace { on end of the line 16521ec3f6f9SBlue Swirl # 3) any do (...) { 16531ec3f6f9SBlue Swirl my $continuation = 0; 16541ec3f6f9SBlue Swirl my $check = 0; 16551ec3f6f9SBlue Swirl $s =~ s/^.*\bdo\b//; 165604f2562fSFam Zheng $s =~ s/^\s*\{//; 16571ec3f6f9SBlue Swirl if ($s =~ s/^\s*\\//) { 16581ec3f6f9SBlue Swirl $continuation = 1; 16591ec3f6f9SBlue Swirl } 16601ec3f6f9SBlue Swirl if ($s =~ s/^\s*?\n//) { 16611ec3f6f9SBlue Swirl $check = 1; 16621ec3f6f9SBlue Swirl $cond_lines++; 16631ec3f6f9SBlue Swirl } 16641ec3f6f9SBlue Swirl 16651ec3f6f9SBlue Swirl # Also ignore a loop construct at the end of a 16661ec3f6f9SBlue Swirl # preprocessor statement. 16671ec3f6f9SBlue Swirl if (($prevline =~ /^.\s*#\s*define\s/ || 16681ec3f6f9SBlue Swirl $prevline =~ /\\\s*$/) && $continuation == 0) { 16691ec3f6f9SBlue Swirl $check = 0; 16701ec3f6f9SBlue Swirl } 16711ec3f6f9SBlue Swirl 16721ec3f6f9SBlue Swirl my $cond_ptr = -1; 16731ec3f6f9SBlue Swirl $continuation = 0; 16741ec3f6f9SBlue Swirl while ($cond_ptr != $cond_lines) { 16751ec3f6f9SBlue Swirl $cond_ptr = $cond_lines; 16761ec3f6f9SBlue Swirl 16771ec3f6f9SBlue Swirl # If we see an #else/#elif then the code 16781ec3f6f9SBlue Swirl # is not linear. 16791ec3f6f9SBlue Swirl if ($s =~ /^\s*\#\s*(?:else|elif)/) { 16801ec3f6f9SBlue Swirl $check = 0; 16811ec3f6f9SBlue Swirl } 16821ec3f6f9SBlue Swirl 16831ec3f6f9SBlue Swirl # Ignore: 16841ec3f6f9SBlue Swirl # 1) blank lines, they should be at 0, 16851ec3f6f9SBlue Swirl # 2) preprocessor lines, and 16861ec3f6f9SBlue Swirl # 3) labels. 16871ec3f6f9SBlue Swirl if ($continuation || 16881ec3f6f9SBlue Swirl $s =~ /^\s*?\n/ || 16891ec3f6f9SBlue Swirl $s =~ /^\s*#\s*?/ || 16901ec3f6f9SBlue Swirl $s =~ /^\s*$Ident\s*:/) { 16911ec3f6f9SBlue Swirl $continuation = ($s =~ /^.*?\\\n/) ? 1 : 0; 16921ec3f6f9SBlue Swirl if ($s =~ s/^.*?\n//) { 16931ec3f6f9SBlue Swirl $cond_lines++; 16941ec3f6f9SBlue Swirl } 16951ec3f6f9SBlue Swirl } 16961ec3f6f9SBlue Swirl } 16971ec3f6f9SBlue Swirl 16981ec3f6f9SBlue Swirl my (undef, $sindent) = line_stats("+" . $s); 16991ec3f6f9SBlue Swirl my $stat_real = raw_line($linenr, $cond_lines); 17001ec3f6f9SBlue Swirl 17011ec3f6f9SBlue Swirl # Check if either of these lines are modified, else 17021ec3f6f9SBlue Swirl # this is not this patch's fault. 17031ec3f6f9SBlue Swirl if (!defined($stat_real) || 17041ec3f6f9SBlue Swirl $stat !~ /^\+/ && $stat_real !~ /^\+/) { 17051ec3f6f9SBlue Swirl $check = 0; 17061ec3f6f9SBlue Swirl } 17071ec3f6f9SBlue Swirl if (defined($stat_real) && $cond_lines > 1) { 17081ec3f6f9SBlue Swirl $stat_real = "[...]\n$stat_real"; 17091ec3f6f9SBlue Swirl } 17101ec3f6f9SBlue Swirl 17111ec3f6f9SBlue Swirl #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n"; 17121ec3f6f9SBlue Swirl 1713b6469683SBlue Swirl if ($check && (($sindent % 4) != 0 || 17141ec3f6f9SBlue Swirl ($sindent <= $indent && $s ne ''))) { 1715c2df8783SPaolo Bonzini ERROR("suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n"); 17161ec3f6f9SBlue Swirl } 17171ec3f6f9SBlue Swirl } 17181ec3f6f9SBlue Swirl 17191ec3f6f9SBlue Swirl # Track the 'values' across context and added lines. 17201ec3f6f9SBlue Swirl my $opline = $line; $opline =~ s/^./ /; 17211ec3f6f9SBlue Swirl my ($curr_values, $curr_vars) = 17221ec3f6f9SBlue Swirl annotate_values($opline . "\n", $prev_values); 17231ec3f6f9SBlue Swirl $curr_values = $prev_values . $curr_values; 17241ec3f6f9SBlue Swirl if ($dbg_values) { 17251ec3f6f9SBlue Swirl my $outline = $opline; $outline =~ s/\t/ /g; 17261ec3f6f9SBlue Swirl print "$linenr > .$outline\n"; 17271ec3f6f9SBlue Swirl print "$linenr > $curr_values\n"; 17281ec3f6f9SBlue Swirl print "$linenr > $curr_vars\n"; 17291ec3f6f9SBlue Swirl } 17301ec3f6f9SBlue Swirl $prev_values = substr($curr_values, -1); 17311ec3f6f9SBlue Swirl 17321ec3f6f9SBlue Swirl#ignore lines not being added 17331ec3f6f9SBlue Swirl if ($line=~/^[^\+]/) {next;} 17341ec3f6f9SBlue Swirl 17351ec3f6f9SBlue Swirl# TEST: allow direct testing of the type matcher. 17361ec3f6f9SBlue Swirl if ($dbg_type) { 17371ec3f6f9SBlue Swirl if ($line =~ /^.\s*$Declare\s*$/) { 17381ec3f6f9SBlue Swirl ERROR("TEST: is type\n" . $herecurr); 17391ec3f6f9SBlue Swirl } elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) { 17401ec3f6f9SBlue Swirl ERROR("TEST: is not type ($1 is)\n". $herecurr); 17411ec3f6f9SBlue Swirl } 17421ec3f6f9SBlue Swirl next; 17431ec3f6f9SBlue Swirl } 17441ec3f6f9SBlue Swirl# TEST: allow direct testing of the attribute matcher. 17451ec3f6f9SBlue Swirl if ($dbg_attr) { 17461ec3f6f9SBlue Swirl if ($line =~ /^.\s*$Modifier\s*$/) { 17471ec3f6f9SBlue Swirl ERROR("TEST: is attr\n" . $herecurr); 17481ec3f6f9SBlue Swirl } elsif ($dbg_attr > 1 && $line =~ /^.+($Modifier)/) { 17491ec3f6f9SBlue Swirl ERROR("TEST: is not attr ($1 is)\n". $herecurr); 17501ec3f6f9SBlue Swirl } 17511ec3f6f9SBlue Swirl next; 17521ec3f6f9SBlue Swirl } 17531ec3f6f9SBlue Swirl 17541ec3f6f9SBlue Swirl# check for initialisation to aggregates open brace on the next line 175504f2562fSFam Zheng if ($line =~ /^.\s*\{/ && 17561ec3f6f9SBlue Swirl $prevline =~ /(?:^|[^=])=\s*$/) { 17571ec3f6f9SBlue Swirl ERROR("that open brace { should be on the previous line\n" . $hereprev); 17581ec3f6f9SBlue Swirl } 17591ec3f6f9SBlue Swirl 17601ec3f6f9SBlue Swirl# 17611ec3f6f9SBlue Swirl# Checks which are anchored on the added line. 17621ec3f6f9SBlue Swirl# 17631ec3f6f9SBlue Swirl 17641ec3f6f9SBlue Swirl# check for malformed paths in #include statements (uses RAW line) 17651ec3f6f9SBlue Swirl if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) { 17661ec3f6f9SBlue Swirl my $path = $1; 17671ec3f6f9SBlue Swirl if ($path =~ m{//}) { 17681ec3f6f9SBlue Swirl ERROR("malformed #include filename\n" . 17691ec3f6f9SBlue Swirl $herecurr); 17701ec3f6f9SBlue Swirl } 17711ec3f6f9SBlue Swirl } 17721ec3f6f9SBlue Swirl 17731ec3f6f9SBlue Swirl# no C99 // comments 17741ec3f6f9SBlue Swirl if ($line =~ m{//}) { 17751ec3f6f9SBlue Swirl ERROR("do not use C99 // comments\n" . $herecurr); 17761ec3f6f9SBlue Swirl } 17771ec3f6f9SBlue Swirl # Remove C99 comments. 17781ec3f6f9SBlue Swirl $line =~ s@//.*@@; 17791ec3f6f9SBlue Swirl $opline =~ s@//.*@@; 17801ec3f6f9SBlue Swirl 17811ec3f6f9SBlue Swirl# check for global initialisers. 17821ec3f6f9SBlue Swirl if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) { 17831ec3f6f9SBlue Swirl ERROR("do not initialise globals to 0 or NULL\n" . 17841ec3f6f9SBlue Swirl $herecurr); 17851ec3f6f9SBlue Swirl } 17861ec3f6f9SBlue Swirl# check for static initialisers. 17871ec3f6f9SBlue Swirl if ($line =~ /\bstatic\s.*=\s*(0|NULL|false)\s*;/) { 17881ec3f6f9SBlue Swirl ERROR("do not initialise statics to 0 or NULL\n" . 17891ec3f6f9SBlue Swirl $herecurr); 17901ec3f6f9SBlue Swirl } 17911ec3f6f9SBlue Swirl 17921ec3f6f9SBlue Swirl# * goes on variable not on type 17931ec3f6f9SBlue Swirl # (char*[ const]) 17941ec3f6f9SBlue Swirl if ($line =~ m{\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\)}) { 17951ec3f6f9SBlue Swirl my ($from, $to) = ($1, $1); 17961ec3f6f9SBlue Swirl 17971ec3f6f9SBlue Swirl # Should start with a space. 17981ec3f6f9SBlue Swirl $to =~ s/^(\S)/ $1/; 17991ec3f6f9SBlue Swirl # Should not end with a space. 18001ec3f6f9SBlue Swirl $to =~ s/\s+$//; 18011ec3f6f9SBlue Swirl # '*'s should not have spaces between. 18021ec3f6f9SBlue Swirl while ($to =~ s/\*\s+\*/\*\*/) { 18031ec3f6f9SBlue Swirl } 18041ec3f6f9SBlue Swirl 18051ec3f6f9SBlue Swirl #print "from<$from> to<$to>\n"; 18061ec3f6f9SBlue Swirl if ($from ne $to) { 18071ec3f6f9SBlue Swirl ERROR("\"(foo$from)\" should be \"(foo$to)\"\n" . $herecurr); 18081ec3f6f9SBlue Swirl } 18091ec3f6f9SBlue Swirl } elsif ($line =~ m{\b$NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)($Ident)}) { 18101ec3f6f9SBlue Swirl my ($from, $to, $ident) = ($1, $1, $2); 18111ec3f6f9SBlue Swirl 18121ec3f6f9SBlue Swirl # Should start with a space. 18131ec3f6f9SBlue Swirl $to =~ s/^(\S)/ $1/; 18141ec3f6f9SBlue Swirl # Should not end with a space. 18151ec3f6f9SBlue Swirl $to =~ s/\s+$//; 18161ec3f6f9SBlue Swirl # '*'s should not have spaces between. 18171ec3f6f9SBlue Swirl while ($to =~ s/\*\s+\*/\*\*/) { 18181ec3f6f9SBlue Swirl } 18191ec3f6f9SBlue Swirl # Modifiers should have spaces. 18201ec3f6f9SBlue Swirl $to =~ s/(\b$Modifier$)/$1 /; 18211ec3f6f9SBlue Swirl 18221ec3f6f9SBlue Swirl #print "from<$from> to<$to> ident<$ident>\n"; 18231ec3f6f9SBlue Swirl if ($from ne $to && $ident !~ /^$Modifier$/) { 18241ec3f6f9SBlue Swirl ERROR("\"foo${from}bar\" should be \"foo${to}bar\"\n" . $herecurr); 18251ec3f6f9SBlue Swirl } 18261ec3f6f9SBlue Swirl } 18271ec3f6f9SBlue Swirl 18281ec3f6f9SBlue Swirl# function brace can't be on same line, except for #defines of do while, 18291ec3f6f9SBlue Swirl# or if closed on same line 183004f2562fSFam Zheng if (($line=~/$Type\s*$Ident\(.*\).*\s\{/) and 183104f2562fSFam Zheng !($line=~/\#\s*define.*do\s\{/) and !($line=~/}/)) { 18321ec3f6f9SBlue Swirl ERROR("open brace '{' following function declarations go on the next line\n" . $herecurr); 18331ec3f6f9SBlue Swirl } 18341ec3f6f9SBlue Swirl 18351ec3f6f9SBlue Swirl# open braces for enum, union and struct go on the same line. 183604f2562fSFam Zheng if ($line =~ /^.\s*\{/ && 18371ec3f6f9SBlue Swirl $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) { 18381ec3f6f9SBlue Swirl ERROR("open brace '{' following $1 go on the same line\n" . $hereprev); 18391ec3f6f9SBlue Swirl } 18401ec3f6f9SBlue Swirl 18411ec3f6f9SBlue Swirl# missing space after union, struct or enum definition 18421ec3f6f9SBlue Swirl if ($line =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?(?:\s+$Ident)?[=\{]/) { 184371c47b01SPaolo Bonzini ERROR("missing space after $1 definition\n" . $herecurr); 18441ec3f6f9SBlue Swirl } 18451ec3f6f9SBlue Swirl 18461ec3f6f9SBlue Swirl# check for spacing round square brackets; allowed: 18471ec3f6f9SBlue Swirl# 1. with a type on the left -- int [] a; 18481ec3f6f9SBlue Swirl# 2. at the beginning of a line for slice initialisers -- [0...10] = 5, 18491ec3f6f9SBlue Swirl# 3. inside a curly brace -- = { [0...10] = 5 } 1850409db6ebSLeonid Bloch# 4. after a comma -- [1] = 5, [2] = 6 18518800cf0aSLeonid Bloch# 5. in a macro definition -- #define abc(x) [x] = y 18521ec3f6f9SBlue Swirl while ($line =~ /(.*?\s)\[/g) { 18531ec3f6f9SBlue Swirl my ($where, $prefix) = ($-[1], $1); 18541ec3f6f9SBlue Swirl if ($prefix !~ /$Type\s+$/ && 18551ec3f6f9SBlue Swirl ($where != 0 || $prefix !~ /^.\s+$/) && 1856409db6ebSLeonid Bloch $prefix !~ /{\s+$/ && 18578800cf0aSLeonid Bloch $prefix !~ /\#\s*define[^(]*\([^)]*\)\s+$/ && 1858409db6ebSLeonid Bloch $prefix !~ /,\s+$/) { 18591ec3f6f9SBlue Swirl ERROR("space prohibited before open square bracket '['\n" . $herecurr); 18601ec3f6f9SBlue Swirl } 18611ec3f6f9SBlue Swirl } 18621ec3f6f9SBlue Swirl 18631ec3f6f9SBlue Swirl# check for spaces between functions and their parentheses. 18641ec3f6f9SBlue Swirl while ($line =~ /($Ident)\s+\(/g) { 18651ec3f6f9SBlue Swirl my $name = $1; 18661ec3f6f9SBlue Swirl my $ctx_before = substr($line, 0, $-[1]); 18671ec3f6f9SBlue Swirl my $ctx = "$ctx_before$name"; 18681ec3f6f9SBlue Swirl 18691ec3f6f9SBlue Swirl # Ignore those directives where spaces _are_ permitted. 18701ec3f6f9SBlue Swirl if ($name =~ /^(?: 18711ec3f6f9SBlue Swirl if|for|while|switch|return|case| 1872000980cbSJeff Cody volatile|__volatile__|coroutine_fn| 18731ec3f6f9SBlue Swirl __attribute__|format|__extension__| 18741ec3f6f9SBlue Swirl asm|__asm__)$/x) 18751ec3f6f9SBlue Swirl { 18761ec3f6f9SBlue Swirl 187769d5d21fSTomoki Sekiyama # Ignore 'catch (...)' in C++ 187869d5d21fSTomoki Sekiyama } elsif ($name =~ /^catch$/ && $realfile =~ /(\.cpp|\.h)$/) { 187969d5d21fSTomoki Sekiyama 18801ec3f6f9SBlue Swirl # cpp #define statements have non-optional spaces, ie 18811ec3f6f9SBlue Swirl # if there is a space between the name and the open 18821ec3f6f9SBlue Swirl # parenthesis it is simply not a parameter group. 18831ec3f6f9SBlue Swirl } elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) { 18841ec3f6f9SBlue Swirl 18851ec3f6f9SBlue Swirl # cpp #elif statement condition may start with a ( 18861ec3f6f9SBlue Swirl } elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) { 18871ec3f6f9SBlue Swirl 18881ec3f6f9SBlue Swirl # If this whole things ends with a type its most 18891ec3f6f9SBlue Swirl # likely a typedef for a function. 18901ec3f6f9SBlue Swirl } elsif ($ctx =~ /$Type$/) { 18911ec3f6f9SBlue Swirl 18921ec3f6f9SBlue Swirl } else { 1893c2df8783SPaolo Bonzini ERROR("space prohibited between function name and open parenthesis '('\n" . $herecurr); 18941ec3f6f9SBlue Swirl } 18951ec3f6f9SBlue Swirl } 18961ec3f6f9SBlue Swirl# Check operator spacing. 18971ec3f6f9SBlue Swirl if (!($line=~/\#\s*include/)) { 18981ec3f6f9SBlue Swirl my $ops = qr{ 18991ec3f6f9SBlue Swirl <<=|>>=|<=|>=|==|!=| 19001ec3f6f9SBlue Swirl \+=|-=|\*=|\/=|%=|\^=|\|=|&=| 19011ec3f6f9SBlue Swirl =>|->|<<|>>|<|>|=|!|~| 19021ec3f6f9SBlue Swirl &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%| 190369d5d21fSTomoki Sekiyama \?|::|: 19041ec3f6f9SBlue Swirl }x; 19051ec3f6f9SBlue Swirl my @elements = split(/($ops|;)/, $opline); 19061ec3f6f9SBlue Swirl my $off = 0; 19071ec3f6f9SBlue Swirl 19081ec3f6f9SBlue Swirl my $blank = copy_spacing($opline); 19091ec3f6f9SBlue Swirl 19101ec3f6f9SBlue Swirl for (my $n = 0; $n < $#elements; $n += 2) { 19111ec3f6f9SBlue Swirl $off += length($elements[$n]); 19121ec3f6f9SBlue Swirl 1913e7d81004SStefan Weil # Pick up the preceding and succeeding characters. 19141ec3f6f9SBlue Swirl my $ca = substr($opline, 0, $off); 19151ec3f6f9SBlue Swirl my $cc = ''; 19161ec3f6f9SBlue Swirl if (length($opline) >= ($off + length($elements[$n + 1]))) { 19171ec3f6f9SBlue Swirl $cc = substr($opline, $off + length($elements[$n + 1])); 19181ec3f6f9SBlue Swirl } 19191ec3f6f9SBlue Swirl my $cb = "$ca$;$cc"; 19201ec3f6f9SBlue Swirl 19211ec3f6f9SBlue Swirl my $a = ''; 19221ec3f6f9SBlue Swirl $a = 'V' if ($elements[$n] ne ''); 19231ec3f6f9SBlue Swirl $a = 'W' if ($elements[$n] =~ /\s$/); 19241ec3f6f9SBlue Swirl $a = 'C' if ($elements[$n] =~ /$;$/); 19251ec3f6f9SBlue Swirl $a = 'B' if ($elements[$n] =~ /(\[|\()$/); 19261ec3f6f9SBlue Swirl $a = 'O' if ($elements[$n] eq ''); 19271ec3f6f9SBlue Swirl $a = 'E' if ($ca =~ /^\s*$/); 19281ec3f6f9SBlue Swirl 19291ec3f6f9SBlue Swirl my $op = $elements[$n + 1]; 19301ec3f6f9SBlue Swirl 19311ec3f6f9SBlue Swirl my $c = ''; 19321ec3f6f9SBlue Swirl if (defined $elements[$n + 2]) { 19331ec3f6f9SBlue Swirl $c = 'V' if ($elements[$n + 2] ne ''); 19341ec3f6f9SBlue Swirl $c = 'W' if ($elements[$n + 2] =~ /^\s/); 19351ec3f6f9SBlue Swirl $c = 'C' if ($elements[$n + 2] =~ /^$;/); 19361ec3f6f9SBlue Swirl $c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/); 19371ec3f6f9SBlue Swirl $c = 'O' if ($elements[$n + 2] eq ''); 19381ec3f6f9SBlue Swirl $c = 'E' if ($elements[$n + 2] =~ /^\s*\\$/); 19391ec3f6f9SBlue Swirl } else { 19401ec3f6f9SBlue Swirl $c = 'E'; 19411ec3f6f9SBlue Swirl } 19421ec3f6f9SBlue Swirl 19431ec3f6f9SBlue Swirl my $ctx = "${a}x${c}"; 19441ec3f6f9SBlue Swirl 19451ec3f6f9SBlue Swirl my $at = "(ctx:$ctx)"; 19461ec3f6f9SBlue Swirl 19471ec3f6f9SBlue Swirl my $ptr = substr($blank, 0, $off) . "^"; 19481ec3f6f9SBlue Swirl my $hereptr = "$hereline$ptr\n"; 19491ec3f6f9SBlue Swirl 19501ec3f6f9SBlue Swirl # Pull out the value of this operator. 19511ec3f6f9SBlue Swirl my $op_type = substr($curr_values, $off + 1, 1); 19521ec3f6f9SBlue Swirl 19531ec3f6f9SBlue Swirl # Get the full operator variant. 19541ec3f6f9SBlue Swirl my $opv = $op . substr($curr_vars, $off, 1); 19551ec3f6f9SBlue Swirl 19561ec3f6f9SBlue Swirl # Ignore operators passed as parameters. 19571ec3f6f9SBlue Swirl if ($op_type ne 'V' && 19581ec3f6f9SBlue Swirl $ca =~ /\s$/ && $cc =~ /^\s*,/) { 19591ec3f6f9SBlue Swirl 19601ec3f6f9SBlue Swirl# # Ignore comments 19611ec3f6f9SBlue Swirl# } elsif ($op =~ /^$;+$/) { 19621ec3f6f9SBlue Swirl 19631ec3f6f9SBlue Swirl # ; should have either the end of line or a space or \ after it 19641ec3f6f9SBlue Swirl } elsif ($op eq ';') { 19651ec3f6f9SBlue Swirl if ($ctx !~ /.x[WEBC]/ && 19661ec3f6f9SBlue Swirl $cc !~ /^\\/ && $cc !~ /^;/) { 19671ec3f6f9SBlue Swirl ERROR("space required after that '$op' $at\n" . $hereptr); 19681ec3f6f9SBlue Swirl } 19691ec3f6f9SBlue Swirl 19701ec3f6f9SBlue Swirl # // is a comment 19711ec3f6f9SBlue Swirl } elsif ($op eq '//') { 19721ec3f6f9SBlue Swirl 197369d5d21fSTomoki Sekiyama # Ignore : used in class declaration in C++ 197469d5d21fSTomoki Sekiyama } elsif ($opv eq ':B' && $ctx =~ /Wx[WE]/ && 197569d5d21fSTomoki Sekiyama $line =~ /class/ && $realfile =~ /(\.cpp|\.h)$/) { 197669d5d21fSTomoki Sekiyama 19771ec3f6f9SBlue Swirl # No spaces for: 19781ec3f6f9SBlue Swirl # -> 19791ec3f6f9SBlue Swirl # : when part of a bitfield 19801ec3f6f9SBlue Swirl } elsif ($op eq '->' || $opv eq ':B') { 19811ec3f6f9SBlue Swirl if ($ctx =~ /Wx.|.xW/) { 19821ec3f6f9SBlue Swirl ERROR("spaces prohibited around that '$op' $at\n" . $hereptr); 19831ec3f6f9SBlue Swirl } 19841ec3f6f9SBlue Swirl 19851ec3f6f9SBlue Swirl # , must have a space on the right. 19869fbe4784SAlexander Graf # not required when having a single },{ on one line 19871ec3f6f9SBlue Swirl } elsif ($op eq ',') { 19889fbe4784SAlexander Graf if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/ && 198904f2562fSFam Zheng ($elements[$n] . $elements[$n + 2]) !~ " *}\\{") { 19901ec3f6f9SBlue Swirl ERROR("space required after that '$op' $at\n" . $hereptr); 19911ec3f6f9SBlue Swirl } 19921ec3f6f9SBlue Swirl 19931ec3f6f9SBlue Swirl # '*' as part of a type definition -- reported already. 19941ec3f6f9SBlue Swirl } elsif ($opv eq '*_') { 19951ec3f6f9SBlue Swirl #warn "'*' is part of type\n"; 19961ec3f6f9SBlue Swirl 19971ec3f6f9SBlue Swirl # unary operators should have a space before and 19981ec3f6f9SBlue Swirl # none after. May be left adjacent to another 19991ec3f6f9SBlue Swirl # unary operator, or a cast 20001ec3f6f9SBlue Swirl } elsif ($op eq '!' || $op eq '~' || 20011ec3f6f9SBlue Swirl $opv eq '*U' || $opv eq '-U' || 20021ec3f6f9SBlue Swirl $opv eq '&U' || $opv eq '&&U') { 200369d5d21fSTomoki Sekiyama if ($op eq '~' && $ca =~ /::$/ && $realfile =~ /(\.cpp|\.h)$/) { 200469d5d21fSTomoki Sekiyama # '~' used as a name of Destructor 200569d5d21fSTomoki Sekiyama 200669d5d21fSTomoki Sekiyama } elsif ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) { 20071ec3f6f9SBlue Swirl ERROR("space required before that '$op' $at\n" . $hereptr); 20081ec3f6f9SBlue Swirl } 20091ec3f6f9SBlue Swirl if ($op eq '*' && $cc =~/\s*$Modifier\b/) { 20101ec3f6f9SBlue Swirl # A unary '*' may be const 20111ec3f6f9SBlue Swirl 20121ec3f6f9SBlue Swirl } elsif ($ctx =~ /.xW/) { 20131ec3f6f9SBlue Swirl ERROR("space prohibited after that '$op' $at\n" . $hereptr); 20141ec3f6f9SBlue Swirl } 20151ec3f6f9SBlue Swirl 20161ec3f6f9SBlue Swirl # unary ++ and unary -- are allowed no space on one side. 20171ec3f6f9SBlue Swirl } elsif ($op eq '++' or $op eq '--') { 20181ec3f6f9SBlue Swirl if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) { 20191ec3f6f9SBlue Swirl ERROR("space required one side of that '$op' $at\n" . $hereptr); 20201ec3f6f9SBlue Swirl } 20211ec3f6f9SBlue Swirl if ($ctx =~ /Wx[BE]/ || 20221ec3f6f9SBlue Swirl ($ctx =~ /Wx./ && $cc =~ /^;/)) { 20231ec3f6f9SBlue Swirl ERROR("space prohibited before that '$op' $at\n" . $hereptr); 20241ec3f6f9SBlue Swirl } 20251ec3f6f9SBlue Swirl if ($ctx =~ /ExW/) { 20261ec3f6f9SBlue Swirl ERROR("space prohibited after that '$op' $at\n" . $hereptr); 20271ec3f6f9SBlue Swirl } 20281ec3f6f9SBlue Swirl 20291ec3f6f9SBlue Swirl # A colon needs no spaces before when it is 20301ec3f6f9SBlue Swirl # terminating a case value or a label. 20311ec3f6f9SBlue Swirl } elsif ($opv eq ':C' || $opv eq ':L') { 20321ec3f6f9SBlue Swirl if ($ctx =~ /Wx./) { 20331ec3f6f9SBlue Swirl ERROR("space prohibited before that '$op' $at\n" . $hereptr); 20341ec3f6f9SBlue Swirl } 20351ec3f6f9SBlue Swirl 20361ec3f6f9SBlue Swirl # All the others need spaces both sides. 20371ec3f6f9SBlue Swirl } elsif ($ctx !~ /[EWC]x[CWE]/) { 20381ec3f6f9SBlue Swirl my $ok = 0; 20391ec3f6f9SBlue Swirl 204069d5d21fSTomoki Sekiyama if ($realfile =~ /\.cpp|\.h$/) { 204169d5d21fSTomoki Sekiyama # Ignore template arguments <...> in C++ 204269d5d21fSTomoki Sekiyama if (($op eq '<' || $op eq '>') && $line =~ /<.*>/) { 204369d5d21fSTomoki Sekiyama $ok = 1; 204469d5d21fSTomoki Sekiyama } 204569d5d21fSTomoki Sekiyama 204669d5d21fSTomoki Sekiyama # Ignore :: in C++ 204769d5d21fSTomoki Sekiyama if ($op eq '::') { 204869d5d21fSTomoki Sekiyama $ok = 1; 204969d5d21fSTomoki Sekiyama } 205069d5d21fSTomoki Sekiyama } 205169d5d21fSTomoki Sekiyama 20521ec3f6f9SBlue Swirl # Ignore email addresses <foo@bar> 20531ec3f6f9SBlue Swirl if (($op eq '<' && 20541ec3f6f9SBlue Swirl $cc =~ /^\S+\@\S+>/) || 20551ec3f6f9SBlue Swirl ($op eq '>' && 20561ec3f6f9SBlue Swirl $ca =~ /<\S+\@\S+$/)) 20571ec3f6f9SBlue Swirl { 20581ec3f6f9SBlue Swirl $ok = 1; 20591ec3f6f9SBlue Swirl } 20601ec3f6f9SBlue Swirl 20611ec3f6f9SBlue Swirl # Ignore ?: 20621ec3f6f9SBlue Swirl if (($opv eq ':O' && $ca =~ /\?$/) || 20631ec3f6f9SBlue Swirl ($op eq '?' && $cc =~ /^:/)) { 20641ec3f6f9SBlue Swirl $ok = 1; 20651ec3f6f9SBlue Swirl } 20661ec3f6f9SBlue Swirl 20671ec3f6f9SBlue Swirl if ($ok == 0) { 20681ec3f6f9SBlue Swirl ERROR("spaces required around that '$op' $at\n" . $hereptr); 20691ec3f6f9SBlue Swirl } 20701ec3f6f9SBlue Swirl } 20711ec3f6f9SBlue Swirl $off += length($elements[$n + 1]); 20721ec3f6f9SBlue Swirl } 20731ec3f6f9SBlue Swirl } 20741ec3f6f9SBlue Swirl 20751ec3f6f9SBlue Swirl#need space before brace following if, while, etc 207604f2562fSFam Zheng if (($line =~ /\(.*\)\{/ && $line !~ /\($Type\)\{/) || 207704f2562fSFam Zheng $line =~ /do\{/) { 20781ec3f6f9SBlue Swirl ERROR("space required before the open brace '{'\n" . $herecurr); 20791ec3f6f9SBlue Swirl } 20801ec3f6f9SBlue Swirl 20811ec3f6f9SBlue Swirl# closing brace should have a space following it when it has anything 20821ec3f6f9SBlue Swirl# on the line 20831ec3f6f9SBlue Swirl if ($line =~ /}(?!(?:,|;|\)))\S/) { 20841ec3f6f9SBlue Swirl ERROR("space required after that close brace '}'\n" . $herecurr); 20851ec3f6f9SBlue Swirl } 20861ec3f6f9SBlue Swirl 20871ec3f6f9SBlue Swirl# check spacing on square brackets 20881ec3f6f9SBlue Swirl if ($line =~ /\[\s/ && $line !~ /\[\s*$/) { 20891ec3f6f9SBlue Swirl ERROR("space prohibited after that open square bracket '['\n" . $herecurr); 20901ec3f6f9SBlue Swirl } 20911ec3f6f9SBlue Swirl if ($line =~ /\s\]/) { 20921ec3f6f9SBlue Swirl ERROR("space prohibited before that close square bracket ']'\n" . $herecurr); 20931ec3f6f9SBlue Swirl } 20941ec3f6f9SBlue Swirl 20951ec3f6f9SBlue Swirl# check spacing on parentheses 20961ec3f6f9SBlue Swirl if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ && 20971ec3f6f9SBlue Swirl $line !~ /for\s*\(\s+;/) { 20981ec3f6f9SBlue Swirl ERROR("space prohibited after that open parenthesis '('\n" . $herecurr); 20991ec3f6f9SBlue Swirl } 21001ec3f6f9SBlue Swirl if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ && 21011ec3f6f9SBlue Swirl $line !~ /for\s*\(.*;\s+\)/ && 21021ec3f6f9SBlue Swirl $line !~ /:\s+\)/) { 21031ec3f6f9SBlue Swirl ERROR("space prohibited before that close parenthesis ')'\n" . $herecurr); 21041ec3f6f9SBlue Swirl } 21051ec3f6f9SBlue Swirl 21061ec3f6f9SBlue Swirl# Return is not a function. 21071ec3f6f9SBlue Swirl if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) { 21081ec3f6f9SBlue Swirl my $spacing = $1; 21091ec3f6f9SBlue Swirl my $value = $2; 21101ec3f6f9SBlue Swirl 21111ec3f6f9SBlue Swirl # Flatten any parentheses 21121ec3f6f9SBlue Swirl $value =~ s/\(/ \(/g; 21131ec3f6f9SBlue Swirl $value =~ s/\)/\) /g; 21141ec3f6f9SBlue Swirl while ($value =~ s/\[[^\{\}]*\]/1/ || 21151ec3f6f9SBlue Swirl $value !~ /(?:$Ident|-?$Constant)\s* 21161ec3f6f9SBlue Swirl $Compare\s* 21171ec3f6f9SBlue Swirl (?:$Ident|-?$Constant)/x && 21181ec3f6f9SBlue Swirl $value =~ s/\([^\(\)]*\)/1/) { 21191ec3f6f9SBlue Swirl } 21201ec3f6f9SBlue Swirl#print "value<$value>\n"; 21211ec3f6f9SBlue Swirl if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/) { 21221ec3f6f9SBlue Swirl ERROR("return is not a function, parentheses are not required\n" . $herecurr); 21231ec3f6f9SBlue Swirl 21241ec3f6f9SBlue Swirl } elsif ($spacing !~ /\s+/) { 21251ec3f6f9SBlue Swirl ERROR("space required before the open parenthesis '('\n" . $herecurr); 21261ec3f6f9SBlue Swirl } 21271ec3f6f9SBlue Swirl } 21281ec3f6f9SBlue Swirl# Return of what appears to be an errno should normally be -'ve 21291ec3f6f9SBlue Swirl if ($line =~ /^.\s*return\s*(E[A-Z]*)\s*;/) { 21301ec3f6f9SBlue Swirl my $name = $1; 21311ec3f6f9SBlue Swirl if ($name ne 'EOF' && $name ne 'ERROR') { 2132c2df8783SPaolo Bonzini ERROR("return of an errno should typically be -ve (return -$1)\n" . $herecurr); 21331ec3f6f9SBlue Swirl } 21341ec3f6f9SBlue Swirl } 21351ec3f6f9SBlue Swirl 21361ec3f6f9SBlue Swirl# Need a space before open parenthesis after if, while etc 21371ec3f6f9SBlue Swirl if ($line=~/\b(if|while|for|switch)\(/) { 21381ec3f6f9SBlue Swirl ERROR("space required before the open parenthesis '('\n" . $herecurr); 21391ec3f6f9SBlue Swirl } 21401ec3f6f9SBlue Swirl 21411ec3f6f9SBlue Swirl# Check for illegal assignment in if conditional -- and check for trailing 21421ec3f6f9SBlue Swirl# statements after the conditional. 21431ec3f6f9SBlue Swirl if ($line =~ /do\s*(?!{)/) { 21441ec3f6f9SBlue Swirl my ($stat_next) = ctx_statement_block($line_nr_next, 21451ec3f6f9SBlue Swirl $remain_next, $off_next); 21461ec3f6f9SBlue Swirl $stat_next =~ s/\n./\n /g; 21471ec3f6f9SBlue Swirl ##print "stat<$stat> stat_next<$stat_next>\n"; 21481ec3f6f9SBlue Swirl 21491ec3f6f9SBlue Swirl if ($stat_next =~ /^\s*while\b/) { 21501ec3f6f9SBlue Swirl # If the statement carries leading newlines, 21511ec3f6f9SBlue Swirl # then count those as offsets. 21521ec3f6f9SBlue Swirl my ($whitespace) = 21531ec3f6f9SBlue Swirl ($stat_next =~ /^((?:\s*\n[+-])*\s*)/s); 21541ec3f6f9SBlue Swirl my $offset = 21551ec3f6f9SBlue Swirl statement_rawlines($whitespace) - 1; 21561ec3f6f9SBlue Swirl 21571ec3f6f9SBlue Swirl $suppress_whiletrailers{$line_nr_next + 21581ec3f6f9SBlue Swirl $offset} = 1; 21591ec3f6f9SBlue Swirl } 21601ec3f6f9SBlue Swirl } 21611ec3f6f9SBlue Swirl if (!defined $suppress_whiletrailers{$linenr} && 21621ec3f6f9SBlue Swirl $line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) { 21631ec3f6f9SBlue Swirl my ($s, $c) = ($stat, $cond); 21641ec3f6f9SBlue Swirl 21651ec3f6f9SBlue Swirl if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/s) { 21661ec3f6f9SBlue Swirl ERROR("do not use assignment in if condition\n" . $herecurr); 21671ec3f6f9SBlue Swirl } 21681ec3f6f9SBlue Swirl 21691ec3f6f9SBlue Swirl # Find out what is on the end of the line after the 21701ec3f6f9SBlue Swirl # conditional. 21711ec3f6f9SBlue Swirl substr($s, 0, length($c), ''); 21721ec3f6f9SBlue Swirl $s =~ s/\n.*//g; 21731ec3f6f9SBlue Swirl $s =~ s/$;//g; # Remove any comments 21741ec3f6f9SBlue Swirl if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ && 21751ec3f6f9SBlue Swirl $c !~ /}\s*while\s*/) 21761ec3f6f9SBlue Swirl { 21771ec3f6f9SBlue Swirl # Find out how long the conditional actually is. 21781ec3f6f9SBlue Swirl my @newlines = ($c =~ /\n/gs); 21791ec3f6f9SBlue Swirl my $cond_lines = 1 + $#newlines; 21801ec3f6f9SBlue Swirl my $stat_real = ''; 21811ec3f6f9SBlue Swirl 21821ec3f6f9SBlue Swirl $stat_real = raw_line($linenr, $cond_lines) 21831ec3f6f9SBlue Swirl . "\n" if ($cond_lines); 21841ec3f6f9SBlue Swirl if (defined($stat_real) && $cond_lines > 1) { 21851ec3f6f9SBlue Swirl $stat_real = "[...]\n$stat_real"; 21861ec3f6f9SBlue Swirl } 21871ec3f6f9SBlue Swirl 21881ec3f6f9SBlue Swirl ERROR("trailing statements should be on next line\n" . $herecurr . $stat_real); 21891ec3f6f9SBlue Swirl } 21901ec3f6f9SBlue Swirl } 21911ec3f6f9SBlue Swirl 21921ec3f6f9SBlue Swirl# Check for bitwise tests written as boolean 21931ec3f6f9SBlue Swirl if ($line =~ / 21941ec3f6f9SBlue Swirl (?: 21951ec3f6f9SBlue Swirl (?:\[|\(|\&\&|\|\|) 21961ec3f6f9SBlue Swirl \s*0[xX][0-9]+\s* 21971ec3f6f9SBlue Swirl (?:\&\&|\|\|) 21981ec3f6f9SBlue Swirl | 21991ec3f6f9SBlue Swirl (?:\&\&|\|\|) 22001ec3f6f9SBlue Swirl \s*0[xX][0-9]+\s* 22011ec3f6f9SBlue Swirl (?:\&\&|\|\||\)|\]) 22021ec3f6f9SBlue Swirl )/x) 22031ec3f6f9SBlue Swirl { 2204c2df8783SPaolo Bonzini ERROR("boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr); 22051ec3f6f9SBlue Swirl } 22061ec3f6f9SBlue Swirl 22071ec3f6f9SBlue Swirl# if and else should not have general statements after it 22081ec3f6f9SBlue Swirl if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) { 22091ec3f6f9SBlue Swirl my $s = $1; 22101ec3f6f9SBlue Swirl $s =~ s/$;//g; # Remove any comments 22111ec3f6f9SBlue Swirl if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) { 22121ec3f6f9SBlue Swirl ERROR("trailing statements should be on next line\n" . $herecurr); 22131ec3f6f9SBlue Swirl } 22141ec3f6f9SBlue Swirl } 22151ec3f6f9SBlue Swirl# if should not continue a brace 22161ec3f6f9SBlue Swirl if ($line =~ /}\s*if\b/) { 22171ec3f6f9SBlue Swirl ERROR("trailing statements should be on next line\n" . 22181ec3f6f9SBlue Swirl $herecurr); 22191ec3f6f9SBlue Swirl } 22201ec3f6f9SBlue Swirl# case and default should not have general statements after them 22211ec3f6f9SBlue Swirl if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g && 22221ec3f6f9SBlue Swirl $line !~ /\G(?: 22231ec3f6f9SBlue Swirl (?:\s*$;*)(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$| 22241ec3f6f9SBlue Swirl \s*return\s+ 22251ec3f6f9SBlue Swirl )/xg) 22261ec3f6f9SBlue Swirl { 22271ec3f6f9SBlue Swirl ERROR("trailing statements should be on next line\n" . $herecurr); 22281ec3f6f9SBlue Swirl } 22291ec3f6f9SBlue Swirl 22301ec3f6f9SBlue Swirl # Check for }<nl>else {, these must be at the same 22311ec3f6f9SBlue Swirl # indent level to be relevant to each other. 22321ec3f6f9SBlue Swirl if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and 22331ec3f6f9SBlue Swirl $previndent == $indent) { 22341ec3f6f9SBlue Swirl ERROR("else should follow close brace '}'\n" . $hereprev); 22351ec3f6f9SBlue Swirl } 22361ec3f6f9SBlue Swirl 22371ec3f6f9SBlue Swirl if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ and 22381ec3f6f9SBlue Swirl $previndent == $indent) { 22391ec3f6f9SBlue Swirl my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0); 22401ec3f6f9SBlue Swirl 22411ec3f6f9SBlue Swirl # Find out what is on the end of the line after the 22421ec3f6f9SBlue Swirl # conditional. 22431ec3f6f9SBlue Swirl substr($s, 0, length($c), ''); 22441ec3f6f9SBlue Swirl $s =~ s/\n.*//g; 22451ec3f6f9SBlue Swirl 22461ec3f6f9SBlue Swirl if ($s =~ /^\s*;/) { 22471ec3f6f9SBlue Swirl ERROR("while should follow close brace '}'\n" . $hereprev); 22481ec3f6f9SBlue Swirl } 22491ec3f6f9SBlue Swirl } 22501ec3f6f9SBlue Swirl 22511ec3f6f9SBlue Swirl#studly caps, commented out until figure out how to distinguish between use of existing and adding new 22521ec3f6f9SBlue Swirl# if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) { 22531ec3f6f9SBlue Swirl# print "No studly caps, use _\n"; 22541ec3f6f9SBlue Swirl# print "$herecurr"; 22551ec3f6f9SBlue Swirl# $clean = 0; 22561ec3f6f9SBlue Swirl# } 22571ec3f6f9SBlue Swirl 22581ec3f6f9SBlue Swirl#no spaces allowed after \ in define 22591ec3f6f9SBlue Swirl if ($line=~/\#\s*define.*\\\s$/) { 2260c2df8783SPaolo Bonzini ERROR("Whitespace after \\ makes next lines useless\n" . $herecurr); 22611ec3f6f9SBlue Swirl } 22621ec3f6f9SBlue Swirl 22631ec3f6f9SBlue Swirl# multi-statement macros should be enclosed in a do while loop, grab the 22641ec3f6f9SBlue Swirl# first statement and ensure its the whole macro if its not enclosed 22651ec3f6f9SBlue Swirl# in a known good container 22661ec3f6f9SBlue Swirl if ($realfile !~ m@/vmlinux.lds.h$@ && 22671ec3f6f9SBlue Swirl $line =~ /^.\s*\#\s*define\s*$Ident(\()?/) { 22681ec3f6f9SBlue Swirl my $ln = $linenr; 22691ec3f6f9SBlue Swirl my $cnt = $realcnt; 22701ec3f6f9SBlue Swirl my ($off, $dstat, $dcond, $rest); 22711ec3f6f9SBlue Swirl my $ctx = ''; 22721ec3f6f9SBlue Swirl 22731ec3f6f9SBlue Swirl my $args = defined($1); 22741ec3f6f9SBlue Swirl 22751ec3f6f9SBlue Swirl # Find the end of the macro and limit our statement 22761ec3f6f9SBlue Swirl # search to that. 22771ec3f6f9SBlue Swirl while ($cnt > 0 && defined $lines[$ln - 1] && 22781ec3f6f9SBlue Swirl $lines[$ln - 1] =~ /^(?:-|..*\\$)/) 22791ec3f6f9SBlue Swirl { 22801ec3f6f9SBlue Swirl $ctx .= $rawlines[$ln - 1] . "\n"; 22811ec3f6f9SBlue Swirl $cnt-- if ($lines[$ln - 1] !~ /^-/); 22821ec3f6f9SBlue Swirl $ln++; 22831ec3f6f9SBlue Swirl } 22841ec3f6f9SBlue Swirl $ctx .= $rawlines[$ln - 1]; 22851ec3f6f9SBlue Swirl 22861ec3f6f9SBlue Swirl ($dstat, $dcond, $ln, $cnt, $off) = 22871ec3f6f9SBlue Swirl ctx_statement_block($linenr, $ln - $linenr + 1, 0); 22881ec3f6f9SBlue Swirl #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n"; 22891ec3f6f9SBlue Swirl #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n"; 22901ec3f6f9SBlue Swirl 22911ec3f6f9SBlue Swirl # Extract the remainder of the define (if any) and 22921ec3f6f9SBlue Swirl # rip off surrounding spaces, and trailing \'s. 22931ec3f6f9SBlue Swirl $rest = ''; 22941ec3f6f9SBlue Swirl while ($off != 0 || ($cnt > 0 && $rest =~ /\\\s*$/)) { 22951ec3f6f9SBlue Swirl #print "ADDING cnt<$cnt> $off <" . substr($lines[$ln - 1], $off) . "> rest<$rest>\n"; 22961ec3f6f9SBlue Swirl if ($off != 0 || $lines[$ln - 1] !~ /^-/) { 22971ec3f6f9SBlue Swirl $rest .= substr($lines[$ln - 1], $off) . "\n"; 22981ec3f6f9SBlue Swirl $cnt--; 22991ec3f6f9SBlue Swirl } 23001ec3f6f9SBlue Swirl $ln++; 23011ec3f6f9SBlue Swirl $off = 0; 23021ec3f6f9SBlue Swirl } 23031ec3f6f9SBlue Swirl $rest =~ s/\\\n.//g; 23041ec3f6f9SBlue Swirl $rest =~ s/^\s*//s; 23051ec3f6f9SBlue Swirl $rest =~ s/\s*$//s; 23061ec3f6f9SBlue Swirl 23071ec3f6f9SBlue Swirl # Clean up the original statement. 23081ec3f6f9SBlue Swirl if ($args) { 23091ec3f6f9SBlue Swirl substr($dstat, 0, length($dcond), ''); 23101ec3f6f9SBlue Swirl } else { 23111ec3f6f9SBlue Swirl $dstat =~ s/^.\s*\#\s*define\s+$Ident\s*//; 23121ec3f6f9SBlue Swirl } 23131ec3f6f9SBlue Swirl $dstat =~ s/$;//g; 23141ec3f6f9SBlue Swirl $dstat =~ s/\\\n.//g; 23151ec3f6f9SBlue Swirl $dstat =~ s/^\s*//s; 23161ec3f6f9SBlue Swirl $dstat =~ s/\s*$//s; 23171ec3f6f9SBlue Swirl 23181ec3f6f9SBlue Swirl # Flatten any parentheses and braces 23191ec3f6f9SBlue Swirl while ($dstat =~ s/\([^\(\)]*\)/1/ || 23201ec3f6f9SBlue Swirl $dstat =~ s/\{[^\{\}]*\}/1/ || 23211ec3f6f9SBlue Swirl $dstat =~ s/\[[^\{\}]*\]/1/) 23221ec3f6f9SBlue Swirl { 23231ec3f6f9SBlue Swirl } 23241ec3f6f9SBlue Swirl 23251ec3f6f9SBlue Swirl my $exceptions = qr{ 23261ec3f6f9SBlue Swirl $Declare| 23271ec3f6f9SBlue Swirl module_param_named| 23281ec3f6f9SBlue Swirl MODULE_PARAM_DESC| 23291ec3f6f9SBlue Swirl DECLARE_PER_CPU| 23301ec3f6f9SBlue Swirl DEFINE_PER_CPU| 23311ec3f6f9SBlue Swirl __typeof__\(| 23321ec3f6f9SBlue Swirl union| 23331ec3f6f9SBlue Swirl struct| 23341ec3f6f9SBlue Swirl \.$Ident\s*=\s*| 23351ec3f6f9SBlue Swirl ^\"|\"$ 23361ec3f6f9SBlue Swirl }x; 23371ec3f6f9SBlue Swirl #print "REST<$rest> dstat<$dstat> ctx<$ctx>\n"; 23381ec3f6f9SBlue Swirl if ($rest ne '' && $rest ne ',') { 23391ec3f6f9SBlue Swirl if ($rest !~ /while\s*\(/ && 23401ec3f6f9SBlue Swirl $dstat !~ /$exceptions/) 23411ec3f6f9SBlue Swirl { 23421ec3f6f9SBlue Swirl ERROR("Macros with multiple statements should be enclosed in a do - while loop\n" . "$here\n$ctx\n"); 23431ec3f6f9SBlue Swirl } 23441ec3f6f9SBlue Swirl 23451ec3f6f9SBlue Swirl } elsif ($ctx !~ /;/) { 23461ec3f6f9SBlue Swirl if ($dstat ne '' && 23471ec3f6f9SBlue Swirl $dstat !~ /^(?:$Ident|-?$Constant)$/ && 23481ec3f6f9SBlue Swirl $dstat !~ /$exceptions/ && 23491ec3f6f9SBlue Swirl $dstat !~ /^\.$Ident\s*=/ && 23501ec3f6f9SBlue Swirl $dstat =~ /$Operators/) 23511ec3f6f9SBlue Swirl { 23521ec3f6f9SBlue Swirl ERROR("Macros with complex values should be enclosed in parenthesis\n" . "$here\n$ctx\n"); 23531ec3f6f9SBlue Swirl } 23541ec3f6f9SBlue Swirl } 23551ec3f6f9SBlue Swirl } 23561ec3f6f9SBlue Swirl 23572b9aef6fSSu Hang# check for missing bracing around if etc 23582b9aef6fSSu Hang if ($line =~ /(^.*)\b(?:if|while|for)\b/ && 23592b9aef6fSSu Hang $line !~ /\#\s*if/) { 2360053e45d2SSu Hang my $allowed = 0; 2361053e45d2SSu Hang 2362053e45d2SSu Hang # Check the pre-context. 2363053e45d2SSu Hang if ($line =~ /(\}.*?)$/) { 2364053e45d2SSu Hang my $pre = $1; 2365053e45d2SSu Hang 2366053e45d2SSu Hang if ($line !~ /else/) { 2367053e45d2SSu Hang print "APW: ALLOWED: pre<$pre> line<$line>\n" 2368053e45d2SSu Hang if $dbg_adv_apw; 2369053e45d2SSu Hang $allowed = 1; 2370053e45d2SSu Hang } 2371053e45d2SSu Hang } 23721ec3f6f9SBlue Swirl my ($level, $endln, @chunks) = 23731ec3f6f9SBlue Swirl ctx_statement_full($linenr, $realcnt, 1); 237469402a69SDon Slutz if ($dbg_adv_apw) { 237569402a69SDon Slutz print "APW: chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n"; 237669402a69SDon Slutz print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n" 237769402a69SDon Slutz if $#chunks >= 1; 237869402a69SDon Slutz } 2379b6469683SBlue Swirl if ($#chunks >= 0 && $level == 0) { 23801ec3f6f9SBlue Swirl my $seen = 0; 23811ec3f6f9SBlue Swirl my $herectx = $here . "\n"; 23821ec3f6f9SBlue Swirl my $ln = $linenr - 1; 23831ec3f6f9SBlue Swirl for my $chunk (@chunks) { 23841ec3f6f9SBlue Swirl my ($cond, $block) = @{$chunk}; 23851ec3f6f9SBlue Swirl 23861ec3f6f9SBlue Swirl # If the condition carries leading newlines, then count those as offsets. 23871ec3f6f9SBlue Swirl my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s); 23881ec3f6f9SBlue Swirl my $offset = statement_rawlines($whitespace) - 1; 23891ec3f6f9SBlue Swirl 23901ec3f6f9SBlue Swirl #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n"; 23911ec3f6f9SBlue Swirl 23921ec3f6f9SBlue Swirl # We have looked at and allowed this specific line. 23931ec3f6f9SBlue Swirl $suppress_ifbraces{$ln + $offset} = 1; 23941ec3f6f9SBlue Swirl 23951ec3f6f9SBlue Swirl $herectx .= "$rawlines[$ln + $offset]\n[...]\n"; 23961ec3f6f9SBlue Swirl $ln += statement_rawlines($block) - 1; 23971ec3f6f9SBlue Swirl 23981ec3f6f9SBlue Swirl substr($block, 0, length($cond), ''); 23991ec3f6f9SBlue Swirl 2400a97ceca5SMax Reitz my $spaced_block = $block; 2401a97ceca5SMax Reitz $spaced_block =~ s/\n\+/ /g; 2402a97ceca5SMax Reitz 240304f2562fSFam Zheng $seen++ if ($spaced_block =~ /^\s*\{/); 24041ec3f6f9SBlue Swirl 240569402a69SDon Slutz print "APW: cond<$cond> block<$block> allowed<$allowed>\n" 240669402a69SDon Slutz if $dbg_adv_apw; 24071ec3f6f9SBlue Swirl if (statement_lines($cond) > 1) { 240869402a69SDon Slutz print "APW: ALLOWED: cond<$cond>\n" 240969402a69SDon Slutz if $dbg_adv_apw; 24101ec3f6f9SBlue Swirl $allowed = 1; 24111ec3f6f9SBlue Swirl } 24121ec3f6f9SBlue Swirl if ($block =~/\b(?:if|for|while)\b/) { 241369402a69SDon Slutz print "APW: ALLOWED: block<$block>\n" 241469402a69SDon Slutz if $dbg_adv_apw; 24151ec3f6f9SBlue Swirl $allowed = 1; 24161ec3f6f9SBlue Swirl } 24171ec3f6f9SBlue Swirl if (statement_block_size($block) > 1) { 241869402a69SDon Slutz print "APW: ALLOWED: lines block<$block>\n" 241969402a69SDon Slutz if $dbg_adv_apw; 24201ec3f6f9SBlue Swirl $allowed = 1; 24211ec3f6f9SBlue Swirl } 24221ec3f6f9SBlue Swirl } 2423053e45d2SSu Hang if ($seen != ($#chunks + 1) && !$allowed) { 2424c2df8783SPaolo Bonzini ERROR("braces {} are necessary for all arms of this statement\n" . $herectx); 24251ec3f6f9SBlue Swirl } 24261ec3f6f9SBlue Swirl } 24271ec3f6f9SBlue Swirl } 24281ec3f6f9SBlue Swirl if (!defined $suppress_ifbraces{$linenr - 1} && 2429789f88d0SJan Kiszka $line =~ /\b(if|while|for|else)\b/ && 2430d0510af2SBlue Swirl $line !~ /\#\s*if/ && 2431789f88d0SJan Kiszka $line !~ /\#\s*else/) { 24321ec3f6f9SBlue Swirl my $allowed = 0; 24331ec3f6f9SBlue Swirl 24341ec3f6f9SBlue Swirl # Check the pre-context. 24351ec3f6f9SBlue Swirl if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) { 2436dfe7053aSDon Slutz my $pre = $1; 2437dfe7053aSDon Slutz 2438dfe7053aSDon Slutz if ($line !~ /else/) { 243969402a69SDon Slutz print "APW: ALLOWED: pre<$pre> line<$line>\n" 244069402a69SDon Slutz if $dbg_adv_apw; 24411ec3f6f9SBlue Swirl $allowed = 1; 24421ec3f6f9SBlue Swirl } 2443dfe7053aSDon Slutz } 24441ec3f6f9SBlue Swirl 24451ec3f6f9SBlue Swirl my ($level, $endln, @chunks) = 24461ec3f6f9SBlue Swirl ctx_statement_full($linenr, $realcnt, $-[0]); 24471ec3f6f9SBlue Swirl 24481ec3f6f9SBlue Swirl # Check the condition. 24491ec3f6f9SBlue Swirl my ($cond, $block) = @{$chunks[0]}; 24505424302eSDon Slutz print "CHECKING<$linenr> cond<$cond> block<$block>\n" 24515424302eSDon Slutz if $dbg_adv_checking; 24521ec3f6f9SBlue Swirl if (defined $cond) { 24531ec3f6f9SBlue Swirl substr($block, 0, length($cond), ''); 24541ec3f6f9SBlue Swirl } 24551ec3f6f9SBlue Swirl if (statement_lines($cond) > 1) { 245669402a69SDon Slutz print "APW: ALLOWED: cond<$cond>\n" 245769402a69SDon Slutz if $dbg_adv_apw; 24581ec3f6f9SBlue Swirl $allowed = 1; 24591ec3f6f9SBlue Swirl } 24601ec3f6f9SBlue Swirl if ($block =~/\b(?:if|for|while)\b/) { 246169402a69SDon Slutz print "APW: ALLOWED: block<$block>\n" 246269402a69SDon Slutz if $dbg_adv_apw; 24631ec3f6f9SBlue Swirl $allowed = 1; 24641ec3f6f9SBlue Swirl } 24651ec3f6f9SBlue Swirl if (statement_block_size($block) > 1) { 246669402a69SDon Slutz print "APW: ALLOWED: lines block<$block>\n" 246769402a69SDon Slutz if $dbg_adv_apw; 24681ec3f6f9SBlue Swirl $allowed = 1; 24691ec3f6f9SBlue Swirl } 24701ec3f6f9SBlue Swirl # Check the post-context. 24711ec3f6f9SBlue Swirl if (defined $chunks[1]) { 24721ec3f6f9SBlue Swirl my ($cond, $block) = @{$chunks[1]}; 24731ec3f6f9SBlue Swirl if (defined $cond) { 24741ec3f6f9SBlue Swirl substr($block, 0, length($cond), ''); 24751ec3f6f9SBlue Swirl } 24761ec3f6f9SBlue Swirl if ($block =~ /^\s*\{/) { 247769402a69SDon Slutz print "APW: ALLOWED: chunk-1 block<$block>\n" 247869402a69SDon Slutz if $dbg_adv_apw; 24791ec3f6f9SBlue Swirl $allowed = 1; 24801ec3f6f9SBlue Swirl } 24811ec3f6f9SBlue Swirl } 2482a99ac041SDon Slutz print "DCS: level=$level block<$block> allowed=$allowed\n" 2483a99ac041SDon Slutz if $dbg_adv_dcs; 2484b6469683SBlue Swirl if ($level == 0 && $block !~ /^\s*\{/ && !$allowed) { 24851ec3f6f9SBlue Swirl my $herectx = $here . "\n";; 24861ec3f6f9SBlue Swirl my $cnt = statement_rawlines($block); 24871ec3f6f9SBlue Swirl 24881ec3f6f9SBlue Swirl for (my $n = 0; $n < $cnt; $n++) { 24891ec3f6f9SBlue Swirl $herectx .= raw_line($linenr, $n) . "\n";; 24901ec3f6f9SBlue Swirl } 24911ec3f6f9SBlue Swirl 2492c2df8783SPaolo Bonzini ERROR("braces {} are necessary even for single statement blocks\n" . $herectx); 24931ec3f6f9SBlue Swirl } 24941ec3f6f9SBlue Swirl } 24951ec3f6f9SBlue Swirl 24961ec3f6f9SBlue Swirl# no volatiles please 24971ec3f6f9SBlue Swirl my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b}; 24986b012d23SMarc-André Lureau if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/ && 24996b012d23SMarc-André Lureau $line !~ /sig_atomic_t/ && 25006b012d23SMarc-André Lureau !ctx_has_comment($first_line, $linenr)) { 25016b012d23SMarc-André Lureau my $msg = "Use of volatile is usually wrong, please add a comment\n" . $herecurr; 25026b012d23SMarc-André Lureau ERROR($msg); 25031ec3f6f9SBlue Swirl } 25041ec3f6f9SBlue Swirl 25051ec3f6f9SBlue Swirl# warn about #if 0 25061ec3f6f9SBlue Swirl if ($line =~ /^.\s*\#\s*if\s+0\b/) { 2507c2df8783SPaolo Bonzini ERROR("if this code is redundant consider removing it\n" . 25081ec3f6f9SBlue Swirl $herecurr); 25091ec3f6f9SBlue Swirl } 25101ec3f6f9SBlue Swirl 251171c47b01SPaolo Bonzini# check for needless g_free() checks 25121ec3f6f9SBlue Swirl if ($prevline =~ /\bif\s*\(([^\)]*)\)/) { 25131ec3f6f9SBlue Swirl my $expr = $1; 251471c47b01SPaolo Bonzini if ($line =~ /\bg_free\(\Q$expr\E\);/) { 2515c2df8783SPaolo Bonzini ERROR("g_free(NULL) is safe this check is probably not required\n" . $hereprev); 25161ec3f6f9SBlue Swirl } 25171ec3f6f9SBlue Swirl } 25181ec3f6f9SBlue Swirl 25191ec3f6f9SBlue Swirl# warn about #ifdefs in C files 25201ec3f6f9SBlue Swirl# if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) { 25211ec3f6f9SBlue Swirl# print "#ifdef in C files should be avoided\n"; 25221ec3f6f9SBlue Swirl# print "$herecurr"; 25231ec3f6f9SBlue Swirl# $clean = 0; 25241ec3f6f9SBlue Swirl# } 25251ec3f6f9SBlue Swirl 25261ec3f6f9SBlue Swirl# warn about spacing in #ifdefs 25271ec3f6f9SBlue Swirl if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) { 25281ec3f6f9SBlue Swirl ERROR("exactly one space required after that #$1\n" . $herecurr); 25291ec3f6f9SBlue Swirl } 25301ec3f6f9SBlue Swirl# check for memory barriers without a comment. 253171c47b01SPaolo Bonzini if ($line =~ /\b(smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) { 25321ec3f6f9SBlue Swirl if (!ctx_has_comment($first_line, $linenr)) { 2533c2df8783SPaolo Bonzini ERROR("memory barrier without comment\n" . $herecurr); 25341ec3f6f9SBlue Swirl } 25351ec3f6f9SBlue Swirl } 25361ec3f6f9SBlue Swirl# check of hardware specific defines 253771c47b01SPaolo Bonzini# we have e.g. CONFIG_LINUX and CONFIG_WIN32 for common cases 253871c47b01SPaolo Bonzini# where they might be necessary. 253971c47b01SPaolo Bonzini if ($line =~ m@^.\s*\#\s*if.*\b__@) { 254063ae8b94SPaolo Bonzini WARN("architecture specific defines should be avoided\n" . $herecurr); 25411ec3f6f9SBlue Swirl } 25421ec3f6f9SBlue Swirl 25431ec3f6f9SBlue Swirl# Check that the storage class is at the beginning of a declaration 25441ec3f6f9SBlue Swirl if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) { 2545c2df8783SPaolo Bonzini ERROR("storage class should be at the beginning of the declaration\n" . $herecurr) 25461ec3f6f9SBlue Swirl } 25471ec3f6f9SBlue Swirl 25481ec3f6f9SBlue Swirl# check the location of the inline attribute, that it is between 25491ec3f6f9SBlue Swirl# storage class and type. 25501ec3f6f9SBlue Swirl if ($line =~ /\b$Type\s+$Inline\b/ || 25511ec3f6f9SBlue Swirl $line =~ /\b$Inline\s+$Storage\b/) { 25521ec3f6f9SBlue Swirl ERROR("inline keyword should sit between storage class and type\n" . $herecurr); 25531ec3f6f9SBlue Swirl } 25541ec3f6f9SBlue Swirl 25551ec3f6f9SBlue Swirl# check for sizeof(&) 25561ec3f6f9SBlue Swirl if ($line =~ /\bsizeof\s*\(\s*\&/) { 2557c2df8783SPaolo Bonzini ERROR("sizeof(& should be avoided\n" . $herecurr); 25581ec3f6f9SBlue Swirl } 25591ec3f6f9SBlue Swirl 25601ec3f6f9SBlue Swirl# check for new externs in .c files. 25611ec3f6f9SBlue Swirl if ($realfile =~ /\.c$/ && defined $stat && 25621ec3f6f9SBlue Swirl $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s) 25631ec3f6f9SBlue Swirl { 25641ec3f6f9SBlue Swirl my $function_name = $1; 25651ec3f6f9SBlue Swirl my $paren_space = $2; 25661ec3f6f9SBlue Swirl 25671ec3f6f9SBlue Swirl my $s = $stat; 25681ec3f6f9SBlue Swirl if (defined $cond) { 25691ec3f6f9SBlue Swirl substr($s, 0, length($cond), ''); 25701ec3f6f9SBlue Swirl } 25711ec3f6f9SBlue Swirl if ($s =~ /^\s*;/ && 25721ec3f6f9SBlue Swirl $function_name ne 'uninitialized_var') 25731ec3f6f9SBlue Swirl { 2574c2df8783SPaolo Bonzini ERROR("externs should be avoided in .c files\n" . $herecurr); 25751ec3f6f9SBlue Swirl } 25761ec3f6f9SBlue Swirl 25771ec3f6f9SBlue Swirl if ($paren_space =~ /\n/) { 2578c2df8783SPaolo Bonzini ERROR("arguments for function declarations should follow identifier\n" . $herecurr); 25791ec3f6f9SBlue Swirl } 25801ec3f6f9SBlue Swirl 25811ec3f6f9SBlue Swirl } elsif ($realfile =~ /\.c$/ && defined $stat && 25821ec3f6f9SBlue Swirl $stat =~ /^.\s*extern\s+/) 25831ec3f6f9SBlue Swirl { 2584c2df8783SPaolo Bonzini ERROR("externs should be avoided in .c files\n" . $herecurr); 25851ec3f6f9SBlue Swirl } 25861ec3f6f9SBlue Swirl 258771c47b01SPaolo Bonzini# check for pointless casting of g_malloc return 258871c47b01SPaolo Bonzini if ($line =~ /\*\s*\)\s*g_(try)?(m|re)alloc(0?)(_n)?\b/) { 258971c47b01SPaolo Bonzini if ($2 == 'm') { 2590c2df8783SPaolo Bonzini ERROR("unnecessary cast may hide bugs, use g_$1new$3 instead\n" . $herecurr); 259171c47b01SPaolo Bonzini } else { 2592c2df8783SPaolo Bonzini ERROR("unnecessary cast may hide bugs, use g_$1renew$3 instead\n" . $herecurr); 259371c47b01SPaolo Bonzini } 25941ec3f6f9SBlue Swirl } 25951ec3f6f9SBlue Swirl 25961ec3f6f9SBlue Swirl# check for gcc specific __FUNCTION__ 25971ec3f6f9SBlue Swirl if ($line =~ /__FUNCTION__/) { 2598c2df8783SPaolo Bonzini ERROR("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr); 25991ec3f6f9SBlue Swirl } 26001ec3f6f9SBlue Swirl 2601fb8446d9SJulia Suvorova# recommend g_path_get_* over g_strdup(basename/dirname(...)) 2602fb8446d9SJulia Suvorova if ($line =~ /\bg_strdup\s*\(\s*(basename|dirname)\s*\(/) { 2603fb8446d9SJulia Suvorova WARN("consider using g_path_get_$1() in preference to g_strdup($1())\n" . $herecurr); 2604fb8446d9SJulia Suvorova } 2605fb8446d9SJulia Suvorova 26065e43efb2SPaolo Bonzini# recommend qemu_strto* over strto* for numeric conversions 260701fb8e19SEric Blake if ($line =~ /\b(strto[^kd].*?)\s*\(/) { 2608c2df8783SPaolo Bonzini ERROR("consider using qemu_$1 in preference to $1\n" . $herecurr); 26091ec3f6f9SBlue Swirl } 2610e8c2091dSPaolo Bonzini# recommend sigaction over signal for portability, when establishing a handler 2611e8c2091dSPaolo Bonzini if ($line =~ /\bsignal\s*\(/ && !($line =~ /SIG_(?:IGN|DFL)/)) { 2612e8c2091dSPaolo Bonzini ERROR("use sigaction to establish signal handlers; signal is not portable\n" . $herecurr); 2613e8c2091dSPaolo Bonzini } 261471c47b01SPaolo Bonzini# check for module_init(), use category-specific init macros explicitly please 261571c47b01SPaolo Bonzini if ($line =~ /^module_init\s*\(/) { 2616c2df8783SPaolo Bonzini ERROR("please use block_init(), type_init() etc. instead of module_init()\n" . $herecurr); 26171ec3f6f9SBlue Swirl } 26181ec3f6f9SBlue Swirl# check for various ops structs, ensure they are const. 261971c47b01SPaolo Bonzini my $struct_ops = qr{AIOCBInfo| 262071c47b01SPaolo Bonzini BdrvActionOps| 262171c47b01SPaolo Bonzini BlockDevOps| 262271c47b01SPaolo Bonzini BlockJobDriver| 262371c47b01SPaolo Bonzini DisplayChangeListenerOps| 262471c47b01SPaolo Bonzini GraphicHwOps| 262571c47b01SPaolo Bonzini IDEDMAOps| 262671c47b01SPaolo Bonzini KVMCapabilityInfo| 262771c47b01SPaolo Bonzini MemoryRegionIOMMUOps| 262871c47b01SPaolo Bonzini MemoryRegionOps| 262971c47b01SPaolo Bonzini MemoryRegionPortio| 263071c47b01SPaolo Bonzini QEMUFileOps| 263171c47b01SPaolo Bonzini SCSIBusInfo| 263271c47b01SPaolo Bonzini SCSIReqOps| 263371c47b01SPaolo Bonzini Spice[A-Z][a-zA-Z0-9]*Interface| 263471c47b01SPaolo Bonzini USBDesc[A-Z][a-zA-Z0-9]*| 263571c47b01SPaolo Bonzini VhostOps| 263671c47b01SPaolo Bonzini VMStateDescription| 263771c47b01SPaolo Bonzini VMStateInfo}x; 26381ec3f6f9SBlue Swirl if ($line !~ /\bconst\b/ && 2639e20e718cSPaolo Bonzini $line =~ /\b($struct_ops)\b.*=/) { 2640e20e718cSPaolo Bonzini ERROR("initializer for struct $1 should normally be const\n" . 26411ec3f6f9SBlue Swirl $herecurr); 26421ec3f6f9SBlue Swirl } 26431ec3f6f9SBlue Swirl 26441ec3f6f9SBlue Swirl# check for %L{u,d,i} in strings 26451ec3f6f9SBlue Swirl my $string; 26461ec3f6f9SBlue Swirl while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) { 26471ec3f6f9SBlue Swirl $string = substr($rawline, $-[1], $+[1] - $-[1]); 26481ec3f6f9SBlue Swirl $string =~ s/%%/__/g; 26491ec3f6f9SBlue Swirl if ($string =~ /(?<!%)%L[udi]/) { 2650c2df8783SPaolo Bonzini ERROR("\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr); 26511ec3f6f9SBlue Swirl last; 26521ec3f6f9SBlue Swirl } 26531ec3f6f9SBlue Swirl } 26541ec3f6f9SBlue Swirl 26559964d8f9SStefan Weil# QEMU specific tests 26569964d8f9SStefan Weil if ($rawline =~ /\b(?:Qemu|QEmu)\b/) { 2657c2df8783SPaolo Bonzini ERROR("use QEMU instead of Qemu or QEmu\n" . $herecurr); 26589964d8f9SStefan Weil } 26598b6ee9aeSStefan Hajnoczi 26605d596c24SJason J. Herne# Qemu error function tests 26615d596c24SJason J. Herne 26625d596c24SJason J. Herne # Find newlines in error messages 26635d596c24SJason J. Herne my $qemu_error_funcs = qr{error_setg| 26645d596c24SJason J. Herne error_setg_errno| 26655d596c24SJason J. Herne error_setg_win32| 2666a47eb010SMarkus Armbruster error_setg_file_open| 26675d596c24SJason J. Herne error_set| 2668a47eb010SMarkus Armbruster error_prepend| 2669e43ead1dSAlistair Francis warn_reportf_err| 2670a47eb010SMarkus Armbruster error_reportf_err| 26715d596c24SJason J. Herne error_vreport| 267297f40301SAlistair Francis warn_vreport| 267397f40301SAlistair Francis info_vreport| 267497f40301SAlistair Francis error_report| 267597f40301SAlistair Francis warn_report| 267697f40301SAlistair Francis info_report}x; 26775d596c24SJason J. Herne 2678a47eb010SMarkus Armbruster if ($rawline =~ /\b(?:$qemu_error_funcs)\s*\(.*\".*\\n/) { 2679c2df8783SPaolo Bonzini ERROR("Error messages should not contain newlines\n" . $herecurr); 26805d596c24SJason J. Herne } 26815d596c24SJason J. Herne 26825d596c24SJason J. Herne # Continue checking for error messages that contains newlines. This 26835d596c24SJason J. Herne # check handles cases where string literals are spread over multiple lines. 26845d596c24SJason J. Herne # Example: 26855d596c24SJason J. Herne # error_report("Error msg line #1" 26865d596c24SJason J. Herne # "Error msg line #2\n"); 26875d596c24SJason J. Herne my $quoted_newline_regex = qr{\+\s*\".*\\n.*\"}; 26885d596c24SJason J. Herne my $continued_str_literal = qr{\+\s*\".*\"}; 26895d596c24SJason J. Herne 26905d596c24SJason J. Herne if ($rawline =~ /$quoted_newline_regex/) { 26915d596c24SJason J. Herne # Backtrack to first line that does not contain only a quoted literal 26925d596c24SJason J. Herne # and assume that it is the start of the statement. 26935d596c24SJason J. Herne my $i = $linenr - 2; 26945d596c24SJason J. Herne 26955d596c24SJason J. Herne while (($i >= 0) & $rawlines[$i] =~ /$continued_str_literal/) { 26965d596c24SJason J. Herne $i--; 26975d596c24SJason J. Herne } 26985d596c24SJason J. Herne 26995d596c24SJason J. Herne if ($rawlines[$i] =~ /\b(?:$qemu_error_funcs)\s*\(/) { 2700c2df8783SPaolo Bonzini ERROR("Error messages should not contain newlines\n" . $herecurr); 27015d596c24SJason J. Herne } 27025d596c24SJason J. Herne } 27035d596c24SJason J. Herne 27043f822cffSPaolo Bonzini# check for non-portable libc calls that have portable alternatives in QEMU 27058b6ee9aeSStefan Hajnoczi if ($line =~ /\bffs\(/) { 27068b6ee9aeSStefan Hajnoczi ERROR("use ctz32() instead of ffs()\n" . $herecurr); 27078b6ee9aeSStefan Hajnoczi } 27088b6ee9aeSStefan Hajnoczi if ($line =~ /\bffsl\(/) { 27098b6ee9aeSStefan Hajnoczi ERROR("use ctz32() or ctz64() instead of ffsl()\n" . $herecurr); 27108b6ee9aeSStefan Hajnoczi } 27118b6ee9aeSStefan Hajnoczi if ($line =~ /\bffsll\(/) { 27128b6ee9aeSStefan Hajnoczi ERROR("use ctz64() instead of ffsll()\n" . $herecurr); 27138b6ee9aeSStefan Hajnoczi } 27143f822cffSPaolo Bonzini if ($line =~ /\bbzero\(/) { 27153f822cffSPaolo Bonzini ERROR("use memset() instead of bzero()\n" . $herecurr); 27163f822cffSPaolo Bonzini } 27176e938956SDr. David Alan Gilbert my $non_exit_glib_asserts = qr{g_assert_cmpstr| 27186e938956SDr. David Alan Gilbert g_assert_cmpint| 27196e938956SDr. David Alan Gilbert g_assert_cmpuint| 27206e938956SDr. David Alan Gilbert g_assert_cmphex| 27216e938956SDr. David Alan Gilbert g_assert_cmpfloat| 27226e938956SDr. David Alan Gilbert g_assert_true| 27236e938956SDr. David Alan Gilbert g_assert_false| 27246e938956SDr. David Alan Gilbert g_assert_nonnull| 27256e938956SDr. David Alan Gilbert g_assert_null| 27266e938956SDr. David Alan Gilbert g_assert_no_error| 27276e938956SDr. David Alan Gilbert g_assert_error| 27286e938956SDr. David Alan Gilbert g_test_assert_expected_messages| 27296e938956SDr. David Alan Gilbert g_test_trap_assert_passed| 27306e938956SDr. David Alan Gilbert g_test_trap_assert_stdout| 27316e938956SDr. David Alan Gilbert g_test_trap_assert_stdout_unmatched| 27326e938956SDr. David Alan Gilbert g_test_trap_assert_stderr| 27336e938956SDr. David Alan Gilbert g_test_trap_assert_stderr_unmatched}x; 27346e938956SDr. David Alan Gilbert if ($realfile !~ /^tests\// && 27356e938956SDr. David Alan Gilbert $line =~ /\b(?:$non_exit_glib_asserts)\(/) { 27366e938956SDr. David Alan Gilbert ERROR("Use g_assert or g_assert_not_reached\n". $herecurr); 27376e938956SDr. David Alan Gilbert } 27381ec3f6f9SBlue Swirl } 27391ec3f6f9SBlue Swirl 27401ec3f6f9SBlue Swirl # If we have no input at all, then there is nothing to report on 27411ec3f6f9SBlue Swirl # so just keep quiet. 27421ec3f6f9SBlue Swirl if ($#rawlines == -1) { 27431ec3f6f9SBlue Swirl exit(0); 27441ec3f6f9SBlue Swirl } 27451ec3f6f9SBlue Swirl 27461ec3f6f9SBlue Swirl # In mailback mode only produce a report in the negative, for 27471ec3f6f9SBlue Swirl # things that appear to be patches. 27481ec3f6f9SBlue Swirl if ($mailback && ($clean == 1 || !$is_patch)) { 27491ec3f6f9SBlue Swirl exit(0); 27501ec3f6f9SBlue Swirl } 27511ec3f6f9SBlue Swirl 27521ec3f6f9SBlue Swirl # This is not a patch, and we are are in 'no-patch' mode so 27531ec3f6f9SBlue Swirl # just keep quiet. 27541ec3f6f9SBlue Swirl if (!$chk_patch && !$is_patch) { 27551ec3f6f9SBlue Swirl exit(0); 27561ec3f6f9SBlue Swirl } 27571ec3f6f9SBlue Swirl 27581ec3f6f9SBlue Swirl if (!$is_patch) { 27591ec3f6f9SBlue Swirl ERROR("Does not appear to be a unified-diff format patch\n"); 27601ec3f6f9SBlue Swirl } 27611ec3f6f9SBlue Swirl if ($is_patch && $chk_signoff && $signoff == 0) { 27621ec3f6f9SBlue Swirl ERROR("Missing Signed-off-by: line(s)\n"); 27631ec3f6f9SBlue Swirl } 27641ec3f6f9SBlue Swirl 27651ec3f6f9SBlue Swirl print report_dump(); 27661ec3f6f9SBlue Swirl if ($summary && !($clean == 1 && $quiet == 1)) { 27671ec3f6f9SBlue Swirl print "$filename " if ($summary_file); 27681ec3f6f9SBlue Swirl print "total: $cnt_error errors, $cnt_warn warnings, " . 27691ec3f6f9SBlue Swirl "$cnt_lines lines checked\n"; 27701ec3f6f9SBlue Swirl print "\n" if ($quiet == 0); 27711ec3f6f9SBlue Swirl } 27721ec3f6f9SBlue Swirl 27731ec3f6f9SBlue Swirl if ($quiet == 0) { 27741ec3f6f9SBlue Swirl # If there were whitespace errors which cleanpatch can fix 27751ec3f6f9SBlue Swirl # then suggest that. 2776b6469683SBlue Swirl# if ($rpt_cleaners) { 2777b6469683SBlue Swirl# print "NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or\n"; 2778b6469683SBlue Swirl# print " scripts/cleanfile\n\n"; 2779b6469683SBlue Swirl# } 27801ec3f6f9SBlue Swirl } 27811ec3f6f9SBlue Swirl 27821ec3f6f9SBlue Swirl if ($clean == 1 && $quiet == 0) { 27831ec3f6f9SBlue Swirl print "$vname has no obvious style problems and is ready for submission.\n" 27841ec3f6f9SBlue Swirl } 27851ec3f6f9SBlue Swirl if ($clean == 0 && $quiet == 0) { 27861ec3f6f9SBlue Swirl print "$vname has style problems, please review. If any of these errors\n"; 27871ec3f6f9SBlue Swirl print "are false positives report them to the maintainer, see\n"; 27881ec3f6f9SBlue Swirl print "CHECKPATCH in MAINTAINERS.\n"; 27891ec3f6f9SBlue Swirl } 27901ec3f6f9SBlue Swirl 2791141de886SPaolo Bonzini return ($no_warnings ? $clean : $cnt_error == 0); 27921ec3f6f9SBlue Swirl} 2793