xref: /qemu/tests/qemu-iotests/245 (revision 4c5393f1)
1903cb1bfSPhilippe Mathieu-Daudé#!/usr/bin/env python3
29dd003a9SVladimir Sementsov-Ogievskiy# group: rw
3bf3e50f6SAlberto Garcia#
4bf3e50f6SAlberto Garcia# Test cases for the QMP 'x-blockdev-reopen' command
5bf3e50f6SAlberto Garcia#
6bf3e50f6SAlberto Garcia# Copyright (C) 2018-2019 Igalia, S.L.
7bf3e50f6SAlberto Garcia# Author: Alberto Garcia <berto@igalia.com>
8bf3e50f6SAlberto Garcia#
9bf3e50f6SAlberto Garcia# This program is free software; you can redistribute it and/or modify
10bf3e50f6SAlberto Garcia# it under the terms of the GNU General Public License as published by
11bf3e50f6SAlberto Garcia# the Free Software Foundation; either version 2 of the License, or
12bf3e50f6SAlberto Garcia# (at your option) any later version.
13bf3e50f6SAlberto Garcia#
14bf3e50f6SAlberto Garcia# This program is distributed in the hope that it will be useful,
15bf3e50f6SAlberto Garcia# but WITHOUT ANY WARRANTY; without even the implied warranty of
16bf3e50f6SAlberto Garcia# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
17bf3e50f6SAlberto Garcia# GNU General Public License for more details.
18bf3e50f6SAlberto Garcia#
19bf3e50f6SAlberto Garcia# You should have received a copy of the GNU General Public License
20bf3e50f6SAlberto Garcia# along with this program.  If not, see <http://www.gnu.org/licenses/>.
21bf3e50f6SAlberto Garcia#
22bf3e50f6SAlberto Garcia
23bf3e50f6SAlberto Garciaimport os
24bf3e50f6SAlberto Garciaimport re
25bf3e50f6SAlberto Garciaimport iotests
26bf3e50f6SAlberto Garciaimport copy
27bf3e50f6SAlberto Garciaimport json
28bf3e50f6SAlberto Garciafrom iotests import qemu_img, qemu_io
29bf3e50f6SAlberto Garcia
30bf3e50f6SAlberto Garciahd_path = [
31bf3e50f6SAlberto Garcia    os.path.join(iotests.test_dir, 'hd0.img'),
32bf3e50f6SAlberto Garcia    os.path.join(iotests.test_dir, 'hd1.img'),
33bf3e50f6SAlberto Garcia    os.path.join(iotests.test_dir, 'hd2.img')
34bf3e50f6SAlberto Garcia]
35bf3e50f6SAlberto Garcia
36bf3e50f6SAlberto Garciadef hd_opts(idx):
37bf3e50f6SAlberto Garcia    return {'driver': iotests.imgfmt,
38bf3e50f6SAlberto Garcia            'node-name': 'hd%d' % idx,
39bf3e50f6SAlberto Garcia            'file': {'driver': 'file',
40bf3e50f6SAlberto Garcia                     'node-name': 'hd%d-file' % idx,
41bf3e50f6SAlberto Garcia                     'filename':  hd_path[idx] } }
42bf3e50f6SAlberto Garcia
43bf3e50f6SAlberto Garciaclass TestBlockdevReopen(iotests.QMPTestCase):
44bf3e50f6SAlberto Garcia    total_io_cmds = 0
45bf3e50f6SAlberto Garcia
46bf3e50f6SAlberto Garcia    def setUp(self):
47bf3e50f6SAlberto Garcia        qemu_img('create', '-f', iotests.imgfmt, hd_path[0], '3M')
48b66ff2c2SEric Blake        qemu_img('create', '-f', iotests.imgfmt, '-b', hd_path[0],
49b66ff2c2SEric Blake                 '-F', iotests.imgfmt, hd_path[1])
50bf3e50f6SAlberto Garcia        qemu_img('create', '-f', iotests.imgfmt, hd_path[2], '3M')
51bf3e50f6SAlberto Garcia        qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0xa0  0 1M', hd_path[0])
52bf3e50f6SAlberto Garcia        qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0xa1 1M 1M', hd_path[1])
53bf3e50f6SAlberto Garcia        qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0xa2 2M 1M', hd_path[2])
54bf3e50f6SAlberto Garcia        self.vm = iotests.VM()
55bf3e50f6SAlberto Garcia        self.vm.launch()
56bf3e50f6SAlberto Garcia
57bf3e50f6SAlberto Garcia    def tearDown(self):
58bf3e50f6SAlberto Garcia        self.vm.shutdown()
59bf3e50f6SAlberto Garcia        self.check_qemu_io_errors()
60bf3e50f6SAlberto Garcia        os.remove(hd_path[0])
61bf3e50f6SAlberto Garcia        os.remove(hd_path[1])
62bf3e50f6SAlberto Garcia        os.remove(hd_path[2])
63bf3e50f6SAlberto Garcia
64bf3e50f6SAlberto Garcia    # The output of qemu-io is not returned by vm.hmp_qemu_io() but
65bf3e50f6SAlberto Garcia    # it's stored in the log and can only be read when the VM has been
66bf3e50f6SAlberto Garcia    # shut down. This function runs qemu-io and keeps track of the
67bf3e50f6SAlberto Garcia    # number of times it's been called.
68bf3e50f6SAlberto Garcia    def run_qemu_io(self, img, cmd):
69bf3e50f6SAlberto Garcia        result = self.vm.hmp_qemu_io(img, cmd)
70bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', '')
71bf3e50f6SAlberto Garcia        self.total_io_cmds += 1
72bf3e50f6SAlberto Garcia
73bf3e50f6SAlberto Garcia    # Once the VM is shut down we can parse the log and see if qemu-io
74bf3e50f6SAlberto Garcia    # ran without errors.
75bf3e50f6SAlberto Garcia    def check_qemu_io_errors(self):
76bf3e50f6SAlberto Garcia        self.assertFalse(self.vm.is_running())
77bf3e50f6SAlberto Garcia        found = 0
78bf3e50f6SAlberto Garcia        log = self.vm.get_log()
79bf3e50f6SAlberto Garcia        for line in log.split("\n"):
80bf3e50f6SAlberto Garcia            if line.startswith("Pattern verification failed"):
81bf3e50f6SAlberto Garcia                raise Exception("%s (command #%d)" % (line, found))
82*4c5393f1SAlberto Garcia            if re.match("(read|wrote) .*/.* bytes at offset", line):
83bf3e50f6SAlberto Garcia                found += 1
84bf3e50f6SAlberto Garcia        self.assertEqual(found, self.total_io_cmds,
85bf3e50f6SAlberto Garcia                         "Expected output of %d qemu-io commands, found %d" %
86bf3e50f6SAlberto Garcia                         (found, self.total_io_cmds))
87bf3e50f6SAlberto Garcia
88bf3e50f6SAlberto Garcia    # Run x-blockdev-reopen with 'opts' but applying 'newopts'
89bf3e50f6SAlberto Garcia    # on top of it. The original 'opts' dict is unmodified
90bf3e50f6SAlberto Garcia    def reopen(self, opts, newopts = {}, errmsg = None):
91bf3e50f6SAlberto Garcia        opts = copy.deepcopy(opts)
92bf3e50f6SAlberto Garcia
93bf3e50f6SAlberto Garcia        # Apply the changes from 'newopts' on top of 'opts'
94bf3e50f6SAlberto Garcia        for key in newopts:
95bf3e50f6SAlberto Garcia            value = newopts[key]
96bf3e50f6SAlberto Garcia            # If key has the form "foo.bar" then we need to do
97bf3e50f6SAlberto Garcia            # opts["foo"]["bar"] = value, not opts["foo.bar"] = value
98bf3e50f6SAlberto Garcia            subdict = opts
99bf3e50f6SAlberto Garcia            while key.find('.') != -1:
100bf3e50f6SAlberto Garcia                [prefix, key] = key.split('.', 1)
101bf3e50f6SAlberto Garcia                subdict = opts[prefix]
102bf3e50f6SAlberto Garcia            subdict[key] = value
103bf3e50f6SAlberto Garcia
104bf3e50f6SAlberto Garcia        result = self.vm.qmp('x-blockdev-reopen', conv_keys = False, **opts)
105bf3e50f6SAlberto Garcia        if errmsg:
106bf3e50f6SAlberto Garcia            self.assert_qmp(result, 'error/class', 'GenericError')
107bf3e50f6SAlberto Garcia            self.assert_qmp(result, 'error/desc', errmsg)
108bf3e50f6SAlberto Garcia        else:
109bf3e50f6SAlberto Garcia            self.assert_qmp(result, 'return', {})
110bf3e50f6SAlberto Garcia
111bf3e50f6SAlberto Garcia
112bf3e50f6SAlberto Garcia    # Run query-named-block-nodes and return the specified entry
113bf3e50f6SAlberto Garcia    def get_node(self, node_name):
114bf3e50f6SAlberto Garcia        result = self.vm.qmp('query-named-block-nodes')
115bf3e50f6SAlberto Garcia        for node in result['return']:
116bf3e50f6SAlberto Garcia            if node['node-name'] == node_name:
117bf3e50f6SAlberto Garcia                return node
118bf3e50f6SAlberto Garcia        return None
119bf3e50f6SAlberto Garcia
120bf3e50f6SAlberto Garcia    # Run 'query-named-block-nodes' and compare its output with the
121bf3e50f6SAlberto Garcia    # value passed by the user in 'graph'
122bf3e50f6SAlberto Garcia    def check_node_graph(self, graph):
123bf3e50f6SAlberto Garcia        result = self.vm.qmp('query-named-block-nodes')
124bf3e50f6SAlberto Garcia        self.assertEqual(json.dumps(graph,  sort_keys=True),
125bf3e50f6SAlberto Garcia                         json.dumps(result, sort_keys=True))
126bf3e50f6SAlberto Garcia
127bf3e50f6SAlberto Garcia    # This test opens one single disk image (without backing files)
128bf3e50f6SAlberto Garcia    # and tries to reopen it with illegal / incorrect parameters.
129bf3e50f6SAlberto Garcia    def test_incorrect_parameters_single_file(self):
130bf3e50f6SAlberto Garcia        # Open 'hd0' only (no backing files)
131bf3e50f6SAlberto Garcia        opts = hd_opts(0)
132bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
133bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
134bf3e50f6SAlberto Garcia        original_graph = self.vm.qmp('query-named-block-nodes')
135bf3e50f6SAlberto Garcia
136bf3e50f6SAlberto Garcia        # We can reopen the image passing the same options
137bf3e50f6SAlberto Garcia        self.reopen(opts)
138bf3e50f6SAlberto Garcia
139bf3e50f6SAlberto Garcia        # We can also reopen passing a child reference in 'file'
140bf3e50f6SAlberto Garcia        self.reopen(opts, {'file': 'hd0-file'})
141bf3e50f6SAlberto Garcia
142bf3e50f6SAlberto Garcia        # We cannot change any of these
143ef2e38a1SConnor Kuehl        self.reopen(opts, {'node-name': 'not-found'}, "Failed to find node with node-name='not-found'")
144ef2e38a1SConnor Kuehl        self.reopen(opts, {'node-name': ''}, "Failed to find node with node-name=''")
145bf3e50f6SAlberto Garcia        self.reopen(opts, {'node-name': None}, "Invalid parameter type for 'node-name', expected: string")
146bf3e50f6SAlberto Garcia        self.reopen(opts, {'driver': 'raw'}, "Cannot change the option 'driver'")
147bf3e50f6SAlberto Garcia        self.reopen(opts, {'driver': ''}, "Invalid parameter ''")
148bf3e50f6SAlberto Garcia        self.reopen(opts, {'driver': None}, "Invalid parameter type for 'driver', expected: string")
149ecd30d2dSAlberto Garcia        self.reopen(opts, {'file': 'not-found'}, "Cannot find device='' nor node-name='not-found'")
150ecd30d2dSAlberto Garcia        self.reopen(opts, {'file': ''}, "Cannot find device='' nor node-name=''")
151bf3e50f6SAlberto Garcia        self.reopen(opts, {'file': None}, "Invalid parameter type for 'file', expected: BlockdevRef")
152bf3e50f6SAlberto Garcia        self.reopen(opts, {'file.node-name': 'newname'}, "Cannot change the option 'node-name'")
153bf3e50f6SAlberto Garcia        self.reopen(opts, {'file.driver': 'host_device'}, "Cannot change the option 'driver'")
154bf3e50f6SAlberto Garcia        self.reopen(opts, {'file.filename': hd_path[1]}, "Cannot change the option 'filename'")
155bf3e50f6SAlberto Garcia        self.reopen(opts, {'file.aio': 'native'}, "Cannot change the option 'aio'")
156bf3e50f6SAlberto Garcia        self.reopen(opts, {'file.locking': 'off'}, "Cannot change the option 'locking'")
157bf3e50f6SAlberto Garcia        self.reopen(opts, {'file.filename': None}, "Invalid parameter type for 'file.filename', expected: string")
158bf3e50f6SAlberto Garcia
159bf3e50f6SAlberto Garcia        # node-name is optional in BlockdevOptions, but x-blockdev-reopen needs it
160bf3e50f6SAlberto Garcia        del opts['node-name']
161ef2e38a1SConnor Kuehl        self.reopen(opts, {}, "node-name not specified")
162bf3e50f6SAlberto Garcia
163bf3e50f6SAlberto Garcia        # Check that nothing has changed
164bf3e50f6SAlberto Garcia        self.check_node_graph(original_graph)
165bf3e50f6SAlberto Garcia
166bf3e50f6SAlberto Garcia        # Remove the node
167bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0')
168bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
169bf3e50f6SAlberto Garcia
170bf3e50f6SAlberto Garcia    # This test opens an image with a backing file and tries to reopen
171bf3e50f6SAlberto Garcia    # it with illegal / incorrect parameters.
172bf3e50f6SAlberto Garcia    def test_incorrect_parameters_backing_file(self):
173bf3e50f6SAlberto Garcia        # Open hd1 omitting the backing options (hd0 will be opened
174bf3e50f6SAlberto Garcia        # with the default options)
175bf3e50f6SAlberto Garcia        opts = hd_opts(1)
176bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
177bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
178bf3e50f6SAlberto Garcia        original_graph = self.vm.qmp('query-named-block-nodes')
179bf3e50f6SAlberto Garcia
180bf3e50f6SAlberto Garcia        # We can't reopen the image passing the same options, 'backing' is mandatory
181bf3e50f6SAlberto Garcia        self.reopen(opts, {}, "backing is missing for 'hd1'")
182bf3e50f6SAlberto Garcia
183bf3e50f6SAlberto Garcia        # Everything works if we pass 'backing' using the existing node name
184bf3e50f6SAlberto Garcia        for node in original_graph['return']:
185bf3e50f6SAlberto Garcia            if node['drv'] == iotests.imgfmt and node['file'] == hd_path[0]:
186bf3e50f6SAlberto Garcia                backing_node_name = node['node-name']
187bf3e50f6SAlberto Garcia        self.reopen(opts, {'backing': backing_node_name})
188bf3e50f6SAlberto Garcia
189bf3e50f6SAlberto Garcia        # We can't use a non-existing or empty (non-NULL) node as the backing image
190785ec4b1SConnor Kuehl        self.reopen(opts, {'backing': 'not-found'}, "Cannot find device=\'\' nor node-name=\'not-found\'")
191785ec4b1SConnor Kuehl        self.reopen(opts, {'backing': ''}, "Cannot find device=\'\' nor node-name=\'\'")
192bf3e50f6SAlberto Garcia
193bf3e50f6SAlberto Garcia        # We can reopen the image just fine if we specify the backing options
194bf3e50f6SAlberto Garcia        opts['backing'] = {'driver': iotests.imgfmt,
195bf3e50f6SAlberto Garcia                           'file': {'driver': 'file',
196bf3e50f6SAlberto Garcia                                    'filename': hd_path[0]}}
197bf3e50f6SAlberto Garcia        self.reopen(opts)
198bf3e50f6SAlberto Garcia
199bf3e50f6SAlberto Garcia        # We cannot change any of these options
200bf3e50f6SAlberto Garcia        self.reopen(opts, {'backing.node-name': 'newname'}, "Cannot change the option 'node-name'")
201bf3e50f6SAlberto Garcia        self.reopen(opts, {'backing.driver': 'raw'}, "Cannot change the option 'driver'")
202bf3e50f6SAlberto Garcia        self.reopen(opts, {'backing.file.node-name': 'newname'}, "Cannot change the option 'node-name'")
203bf3e50f6SAlberto Garcia        self.reopen(opts, {'backing.file.driver': 'host_device'}, "Cannot change the option 'driver'")
204bf3e50f6SAlberto Garcia
205bf3e50f6SAlberto Garcia        # Check that nothing has changed since the beginning
206bf3e50f6SAlberto Garcia        self.check_node_graph(original_graph)
207bf3e50f6SAlberto Garcia
208bf3e50f6SAlberto Garcia        # Remove the node
209bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd1')
210bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
211bf3e50f6SAlberto Garcia
212bf3e50f6SAlberto Garcia    # Reopen an image several times changing some of its options
213bf3e50f6SAlberto Garcia    def test_reopen(self):
21423e1d054SMax Reitz        # Check whether the filesystem supports O_DIRECT
21523e1d054SMax Reitz        if 'O_DIRECT' in qemu_io('-f', 'raw', '-t', 'none', '-c', 'quit', hd_path[0]):
21623e1d054SMax Reitz            supports_direct = False
21723e1d054SMax Reitz        else:
21823e1d054SMax Reitz            supports_direct = True
21923e1d054SMax Reitz
220bf3e50f6SAlberto Garcia        # Open the hd1 image passing all backing options
221bf3e50f6SAlberto Garcia        opts = hd_opts(1)
222bf3e50f6SAlberto Garcia        opts['backing'] = hd_opts(0)
223bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
224bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
225bf3e50f6SAlberto Garcia        original_graph = self.vm.qmp('query-named-block-nodes')
226bf3e50f6SAlberto Garcia
227bf3e50f6SAlberto Garcia        # We can reopen the image passing the same options
228bf3e50f6SAlberto Garcia        self.reopen(opts)
229bf3e50f6SAlberto Garcia
230bf3e50f6SAlberto Garcia        # Reopen in read-only mode
231bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd1'), 'ro', False)
232bf3e50f6SAlberto Garcia
233bf3e50f6SAlberto Garcia        self.reopen(opts, {'read-only': True})
234bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd1'), 'ro', True)
235bf3e50f6SAlberto Garcia        self.reopen(opts)
236bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd1'), 'ro', False)
237bf3e50f6SAlberto Garcia
238bf3e50f6SAlberto Garcia        # Change the cache options
239bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd1'), 'cache/writeback', True)
240bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd1'), 'cache/direct', False)
241bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd1'), 'cache/no-flush', False)
24223e1d054SMax Reitz        self.reopen(opts, {'cache': { 'direct': supports_direct, 'no-flush': True }})
243bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd1'), 'cache/writeback', True)
24423e1d054SMax Reitz        self.assert_qmp(self.get_node('hd1'), 'cache/direct', supports_direct)
245bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd1'), 'cache/no-flush', True)
246bf3e50f6SAlberto Garcia
247bf3e50f6SAlberto Garcia        # Reopen again with the original options
248bf3e50f6SAlberto Garcia        self.reopen(opts)
249bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd1'), 'cache/writeback', True)
250bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd1'), 'cache/direct', False)
251bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd1'), 'cache/no-flush', False)
252bf3e50f6SAlberto Garcia
253bf3e50f6SAlberto Garcia        # Change 'detect-zeroes' and 'discard'
254bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd1'), 'detect_zeroes', 'off')
255bf3e50f6SAlberto Garcia        self.reopen(opts, {'detect-zeroes': 'on'})
256bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd1'), 'detect_zeroes', 'on')
257bf3e50f6SAlberto Garcia        self.reopen(opts, {'detect-zeroes': 'unmap'},
258bf3e50f6SAlberto Garcia                    "setting detect-zeroes to unmap is not allowed " +
259bf3e50f6SAlberto Garcia                    "without setting discard operation to unmap")
260bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd1'), 'detect_zeroes', 'on')
261bf3e50f6SAlberto Garcia        self.reopen(opts, {'detect-zeroes': 'unmap', 'discard': 'unmap'})
262bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd1'), 'detect_zeroes', 'unmap')
263bf3e50f6SAlberto Garcia        self.reopen(opts)
264bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd1'), 'detect_zeroes', 'off')
265bf3e50f6SAlberto Garcia
266bf3e50f6SAlberto Garcia        # Changing 'force-share' is currently not supported
267bf3e50f6SAlberto Garcia        self.reopen(opts, {'force-share': True}, "Cannot change the option 'force-share'")
268bf3e50f6SAlberto Garcia
269bf3e50f6SAlberto Garcia        # Change some qcow2-specific options
270bf3e50f6SAlberto Garcia        # No way to test for success other than checking the return message
271bf3e50f6SAlberto Garcia        if iotests.imgfmt == 'qcow2':
272bf3e50f6SAlberto Garcia            self.reopen(opts, {'l2-cache-entry-size': 128 * 1024},
273bf3e50f6SAlberto Garcia                        "L2 cache entry size must be a power of two "+
274bf3e50f6SAlberto Garcia                        "between 512 and the cluster size (65536)")
275bf3e50f6SAlberto Garcia            self.reopen(opts, {'l2-cache-size': 1024 * 1024,
276bf3e50f6SAlberto Garcia                               'cache-size':     512 * 1024},
277bf3e50f6SAlberto Garcia                        "l2-cache-size may not exceed cache-size")
278bf3e50f6SAlberto Garcia            self.reopen(opts, {'l2-cache-size':        4 * 1024 * 1024,
279bf3e50f6SAlberto Garcia                               'refcount-cache-size':  4 * 1024 * 1024,
280bf3e50f6SAlberto Garcia                               'l2-cache-entry-size': 32 * 1024})
281bf3e50f6SAlberto Garcia            self.reopen(opts, {'pass-discard-request': True})
282bf3e50f6SAlberto Garcia
283bf3e50f6SAlberto Garcia        # Check that nothing has changed since the beginning
284bf3e50f6SAlberto Garcia        # (from the parameters that we can check)
285bf3e50f6SAlberto Garcia        self.check_node_graph(original_graph)
286bf3e50f6SAlberto Garcia
287bf3e50f6SAlberto Garcia        # Check that the node names (other than the top-level one) are optional
288bf3e50f6SAlberto Garcia        del opts['file']['node-name']
289bf3e50f6SAlberto Garcia        del opts['backing']['node-name']
290bf3e50f6SAlberto Garcia        del opts['backing']['file']['node-name']
291bf3e50f6SAlberto Garcia        self.reopen(opts)
292bf3e50f6SAlberto Garcia        self.check_node_graph(original_graph)
293bf3e50f6SAlberto Garcia
294bf3e50f6SAlberto Garcia        # Reopen setting backing = null, this removes the backing image from the chain
295bf3e50f6SAlberto Garcia        self.reopen(opts, {'backing': None})
296bf3e50f6SAlberto Garcia        self.assert_qmp_absent(self.get_node('hd1'), 'image/backing-image')
297bf3e50f6SAlberto Garcia
298bf3e50f6SAlberto Garcia        # Open the 'hd0' image
299bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **hd_opts(0))
300bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
301bf3e50f6SAlberto Garcia
302bf3e50f6SAlberto Garcia        # Reopen the hd1 image setting 'hd0' as its backing image
303bf3e50f6SAlberto Garcia        self.reopen(opts, {'backing': 'hd0'})
304bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd1'), 'image/backing-image/filename', hd_path[0])
305bf3e50f6SAlberto Garcia
306bf3e50f6SAlberto Garcia        # Check that nothing has changed since the beginning
307bf3e50f6SAlberto Garcia        self.reopen(hd_opts(0), {'read-only': True})
308bf3e50f6SAlberto Garcia        self.check_node_graph(original_graph)
309bf3e50f6SAlberto Garcia
310bf3e50f6SAlberto Garcia        # The backing file (hd0) is now a reference, we cannot change backing.* anymore
311bf3e50f6SAlberto Garcia        self.reopen(opts, {}, "Cannot change the option 'backing.driver'")
312bf3e50f6SAlberto Garcia
313bf3e50f6SAlberto Garcia        # We can't remove 'hd0' while it's a backing image of 'hd1'
314bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0')
315bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'error/class', 'GenericError')
316bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'error/desc', "Node 'hd0' is busy: node is used as backing hd of 'hd1'")
317bf3e50f6SAlberto Garcia
318bf3e50f6SAlberto Garcia        # But we can remove both nodes if done in the proper order
319bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd1')
320bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
321bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0')
322bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
323bf3e50f6SAlberto Garcia
324bf3e50f6SAlberto Garcia    # Reopen a raw image and see the effect of changing the 'offset' option
325bf3e50f6SAlberto Garcia    def test_reopen_raw(self):
326bf3e50f6SAlberto Garcia        opts = {'driver': 'raw', 'node-name': 'hd0',
327bf3e50f6SAlberto Garcia                'file': { 'driver': 'file',
328bf3e50f6SAlberto Garcia                          'filename': hd_path[0],
329bf3e50f6SAlberto Garcia                          'node-name': 'hd0-file' } }
330bf3e50f6SAlberto Garcia
331bf3e50f6SAlberto Garcia        # First we create a 2MB raw file, and fill each half with a
332bf3e50f6SAlberto Garcia        # different value
333bf3e50f6SAlberto Garcia        qemu_img('create', '-f', 'raw', hd_path[0], '2M')
334bf3e50f6SAlberto Garcia        qemu_io('-f', 'raw', '-c', 'write -P 0xa0  0 1M', hd_path[0])
335bf3e50f6SAlberto Garcia        qemu_io('-f', 'raw', '-c', 'write -P 0xa1 1M 1M', hd_path[0])
336bf3e50f6SAlberto Garcia
337bf3e50f6SAlberto Garcia        # Open the raw file with QEMU
338bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
339bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
340bf3e50f6SAlberto Garcia
341bf3e50f6SAlberto Garcia        # Read 1MB from offset 0
342bf3e50f6SAlberto Garcia        self.run_qemu_io("hd0", "read -P 0xa0  0 1M")
343bf3e50f6SAlberto Garcia
344bf3e50f6SAlberto Garcia        # Reopen the image with a 1MB offset.
345bf3e50f6SAlberto Garcia        # Now the results are different
346bf3e50f6SAlberto Garcia        self.reopen(opts, {'offset': 1024*1024})
347bf3e50f6SAlberto Garcia        self.run_qemu_io("hd0", "read -P 0xa1  0 1M")
348bf3e50f6SAlberto Garcia
349bf3e50f6SAlberto Garcia        # Reopen again with the original options.
350bf3e50f6SAlberto Garcia        # We get the original results again
351bf3e50f6SAlberto Garcia        self.reopen(opts)
352bf3e50f6SAlberto Garcia        self.run_qemu_io("hd0", "read -P 0xa0  0 1M")
353bf3e50f6SAlberto Garcia
354bf3e50f6SAlberto Garcia        # Remove the block device
355bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0')
356bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
357bf3e50f6SAlberto Garcia
358bf3e50f6SAlberto Garcia    # Omitting an option should reset it to the default value, but if
359bf3e50f6SAlberto Garcia    # an option cannot be changed it shouldn't be possible to reset it
360bf3e50f6SAlberto Garcia    # to its default value either
361bf3e50f6SAlberto Garcia    def test_reset_default_values(self):
362bf3e50f6SAlberto Garcia        opts = {'driver': 'qcow2', 'node-name': 'hd0',
363bf3e50f6SAlberto Garcia                'file': { 'driver': 'file',
364bf3e50f6SAlberto Garcia                          'filename': hd_path[0],
365bf3e50f6SAlberto Garcia                          'x-check-cache-dropped': True, # This one can be changed
366bf3e50f6SAlberto Garcia                          'locking': 'off',              # This one can NOT be changed
367bf3e50f6SAlberto Garcia                          'node-name': 'hd0-file' } }
368bf3e50f6SAlberto Garcia
369bf3e50f6SAlberto Garcia        # Open the file with QEMU
370bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
371bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
372bf3e50f6SAlberto Garcia
373bf3e50f6SAlberto Garcia        # file.x-check-cache-dropped can be changed...
374bf3e50f6SAlberto Garcia        self.reopen(opts, { 'file.x-check-cache-dropped': False })
375bf3e50f6SAlberto Garcia        # ...and dropped completely (resetting to the default value)
376bf3e50f6SAlberto Garcia        del opts['file']['x-check-cache-dropped']
377bf3e50f6SAlberto Garcia        self.reopen(opts)
378bf3e50f6SAlberto Garcia
379bf3e50f6SAlberto Garcia        # file.locking cannot be changed nor reset to the default value
380bf3e50f6SAlberto Garcia        self.reopen(opts, { 'file.locking': 'on' }, "Cannot change the option 'locking'")
381bf3e50f6SAlberto Garcia        del opts['file']['locking']
382bf3e50f6SAlberto Garcia        self.reopen(opts, {}, "Option 'locking' cannot be reset to its default value")
383bf3e50f6SAlberto Garcia        # But we can reopen it if we maintain its previous value
384bf3e50f6SAlberto Garcia        self.reopen(opts, { 'file.locking': 'off' })
385bf3e50f6SAlberto Garcia
386bf3e50f6SAlberto Garcia        # Remove the block device
387bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0')
388bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
389bf3e50f6SAlberto Garcia
390bf3e50f6SAlberto Garcia    # This test modifies the node graph a few times by changing the
391bf3e50f6SAlberto Garcia    # 'backing' option on reopen and verifies that the guest data that
392bf3e50f6SAlberto Garcia    # is read afterwards is consistent with the graph changes.
393bf3e50f6SAlberto Garcia    def test_io_with_graph_changes(self):
394bf3e50f6SAlberto Garcia        opts = []
395bf3e50f6SAlberto Garcia
396bf3e50f6SAlberto Garcia        # Open hd0, hd1 and hd2 without any backing image
397bf3e50f6SAlberto Garcia        for i in range(3):
398bf3e50f6SAlberto Garcia            opts.append(hd_opts(i))
399bf3e50f6SAlberto Garcia            opts[i]['backing'] = None
400bf3e50f6SAlberto Garcia            result = self.vm.qmp('blockdev-add', conv_keys = False, **opts[i])
401bf3e50f6SAlberto Garcia            self.assert_qmp(result, 'return', {})
402bf3e50f6SAlberto Garcia
403bf3e50f6SAlberto Garcia        # hd0
404bf3e50f6SAlberto Garcia        self.run_qemu_io("hd0", "read -P 0xa0  0 1M")
405bf3e50f6SAlberto Garcia        self.run_qemu_io("hd0", "read -P 0    1M 1M")
406bf3e50f6SAlberto Garcia        self.run_qemu_io("hd0", "read -P 0    2M 1M")
407bf3e50f6SAlberto Garcia
408bf3e50f6SAlberto Garcia        # hd1 <- hd0
409bf3e50f6SAlberto Garcia        self.reopen(opts[0], {'backing': 'hd1'})
410bf3e50f6SAlberto Garcia
411bf3e50f6SAlberto Garcia        self.run_qemu_io("hd0", "read -P 0xa0  0 1M")
412bf3e50f6SAlberto Garcia        self.run_qemu_io("hd0", "read -P 0xa1 1M 1M")
413bf3e50f6SAlberto Garcia        self.run_qemu_io("hd0", "read -P 0    2M 1M")
414bf3e50f6SAlberto Garcia
415bf3e50f6SAlberto Garcia        # hd1 <- hd0 , hd1 <- hd2
416bf3e50f6SAlberto Garcia        self.reopen(opts[2], {'backing': 'hd1'})
417bf3e50f6SAlberto Garcia
418bf3e50f6SAlberto Garcia        self.run_qemu_io("hd2", "read -P 0     0 1M")
419bf3e50f6SAlberto Garcia        self.run_qemu_io("hd2", "read -P 0xa1 1M 1M")
420bf3e50f6SAlberto Garcia        self.run_qemu_io("hd2", "read -P 0xa2 2M 1M")
421bf3e50f6SAlberto Garcia
422bf3e50f6SAlberto Garcia        # hd1 <- hd2 <- hd0
423bf3e50f6SAlberto Garcia        self.reopen(opts[0], {'backing': 'hd2'})
424bf3e50f6SAlberto Garcia
425bf3e50f6SAlberto Garcia        self.run_qemu_io("hd0", "read -P 0xa0  0 1M")
426bf3e50f6SAlberto Garcia        self.run_qemu_io("hd0", "read -P 0xa1 1M 1M")
427bf3e50f6SAlberto Garcia        self.run_qemu_io("hd0", "read -P 0xa2 2M 1M")
428bf3e50f6SAlberto Garcia
429bf3e50f6SAlberto Garcia        # hd2 <- hd0
430bf3e50f6SAlberto Garcia        self.reopen(opts[2], {'backing': None})
431bf3e50f6SAlberto Garcia
432bf3e50f6SAlberto Garcia        self.run_qemu_io("hd0", "read -P 0xa0  0 1M")
433bf3e50f6SAlberto Garcia        self.run_qemu_io("hd0", "read -P 0    1M 1M")
434bf3e50f6SAlberto Garcia        self.run_qemu_io("hd0", "read -P 0xa2 2M 1M")
435bf3e50f6SAlberto Garcia
436bf3e50f6SAlberto Garcia        # hd2 <- hd1 <- hd0
437bf3e50f6SAlberto Garcia        self.reopen(opts[1], {'backing': 'hd2'})
438bf3e50f6SAlberto Garcia        self.reopen(opts[0], {'backing': 'hd1'})
439bf3e50f6SAlberto Garcia
440bf3e50f6SAlberto Garcia        self.run_qemu_io("hd0", "read -P 0xa0  0 1M")
441bf3e50f6SAlberto Garcia        self.run_qemu_io("hd0", "read -P 0xa1 1M 1M")
442bf3e50f6SAlberto Garcia        self.run_qemu_io("hd0", "read -P 0xa2 2M 1M")
443bf3e50f6SAlberto Garcia
444bf3e50f6SAlberto Garcia        # Illegal operation: hd2 is a child of hd1
445bf3e50f6SAlberto Garcia        self.reopen(opts[2], {'backing': 'hd1'},
446ecd30d2dSAlberto Garcia                    "Making 'hd1' a backing child of 'hd2' would create a cycle")
447bf3e50f6SAlberto Garcia
448bf3e50f6SAlberto Garcia        # hd2 <- hd0, hd2 <- hd1
449bf3e50f6SAlberto Garcia        self.reopen(opts[0], {'backing': 'hd2'})
450bf3e50f6SAlberto Garcia
451bf3e50f6SAlberto Garcia        self.run_qemu_io("hd1", "read -P 0     0 1M")
452bf3e50f6SAlberto Garcia        self.run_qemu_io("hd1", "read -P 0xa1 1M 1M")
453bf3e50f6SAlberto Garcia        self.run_qemu_io("hd1", "read -P 0xa2 2M 1M")
454bf3e50f6SAlberto Garcia
455bf3e50f6SAlberto Garcia        # More illegal operations
456bf3e50f6SAlberto Garcia        self.reopen(opts[2], {'backing': 'hd1'},
457ecd30d2dSAlberto Garcia                    "Making 'hd1' a backing child of 'hd2' would create a cycle")
458ecd30d2dSAlberto Garcia        self.reopen(opts[2], {'file': 'hd0-file'},
459ecd30d2dSAlberto Garcia                    "Permission conflict on node 'hd0-file': permissions 'write, resize' are both required by node 'hd0' (uses node 'hd0-file' as 'file' child) and unshared by node 'hd2' (uses node 'hd0-file' as 'file' child).")
460bf3e50f6SAlberto Garcia
461bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd2')
462bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'error/class', 'GenericError')
463bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'error/desc', "Node 'hd2' is busy: node is used as backing hd of 'hd0'")
464bf3e50f6SAlberto Garcia
465bf3e50f6SAlberto Garcia        # hd1 doesn't have a backing file now
466bf3e50f6SAlberto Garcia        self.reopen(opts[1], {'backing': None})
467bf3e50f6SAlberto Garcia
468bf3e50f6SAlberto Garcia        self.run_qemu_io("hd1", "read -P 0     0 1M")
469bf3e50f6SAlberto Garcia        self.run_qemu_io("hd1", "read -P 0xa1 1M 1M")
470bf3e50f6SAlberto Garcia        self.run_qemu_io("hd1", "read -P 0    2M 1M")
471bf3e50f6SAlberto Garcia
472bf3e50f6SAlberto Garcia        # We can't remove the 'backing' option if the image has a
473bf3e50f6SAlberto Garcia        # default backing file
474bf3e50f6SAlberto Garcia        del opts[1]['backing']
475bf3e50f6SAlberto Garcia        self.reopen(opts[1], {}, "backing is missing for 'hd1'")
476bf3e50f6SAlberto Garcia
477bf3e50f6SAlberto Garcia        self.run_qemu_io("hd1", "read -P 0     0 1M")
478bf3e50f6SAlberto Garcia        self.run_qemu_io("hd1", "read -P 0xa1 1M 1M")
479bf3e50f6SAlberto Garcia        self.run_qemu_io("hd1", "read -P 0    2M 1M")
480bf3e50f6SAlberto Garcia
481bf3e50f6SAlberto Garcia    # This test verifies that we can't change the children of a block
482bf3e50f6SAlberto Garcia    # device during a reopen operation in a way that would create
483bf3e50f6SAlberto Garcia    # cycles in the node graph
4849442bebeSThomas Huth    @iotests.skip_if_unsupported(['blkverify'])
485bf3e50f6SAlberto Garcia    def test_graph_cycles(self):
486bf3e50f6SAlberto Garcia        opts = []
487bf3e50f6SAlberto Garcia
488bf3e50f6SAlberto Garcia        # Open all three images without backing file
489bf3e50f6SAlberto Garcia        for i in range(3):
490bf3e50f6SAlberto Garcia            opts.append(hd_opts(i))
491bf3e50f6SAlberto Garcia            opts[i]['backing'] = None
492bf3e50f6SAlberto Garcia            result = self.vm.qmp('blockdev-add', conv_keys = False, **opts[i])
493bf3e50f6SAlberto Garcia            self.assert_qmp(result, 'return', {})
494bf3e50f6SAlberto Garcia
495bf3e50f6SAlberto Garcia        # hd1 <- hd0, hd1 <- hd2
496bf3e50f6SAlberto Garcia        self.reopen(opts[0], {'backing': 'hd1'})
497bf3e50f6SAlberto Garcia        self.reopen(opts[2], {'backing': 'hd1'})
498bf3e50f6SAlberto Garcia
499bf3e50f6SAlberto Garcia        # Illegal: hd2 is backed by hd1
500bf3e50f6SAlberto Garcia        self.reopen(opts[1], {'backing': 'hd2'},
501ecd30d2dSAlberto Garcia                    "Making 'hd2' a backing child of 'hd1' would create a cycle")
502bf3e50f6SAlberto Garcia
503bf3e50f6SAlberto Garcia        # hd1 <- hd0 <- hd2
504bf3e50f6SAlberto Garcia        self.reopen(opts[2], {'backing': 'hd0'})
505bf3e50f6SAlberto Garcia
506bf3e50f6SAlberto Garcia        # Illegal: hd2 is backed by hd0, which is backed by hd1
507bf3e50f6SAlberto Garcia        self.reopen(opts[1], {'backing': 'hd2'},
508ecd30d2dSAlberto Garcia                    "Making 'hd2' a backing child of 'hd1' would create a cycle")
509bf3e50f6SAlberto Garcia
510bf3e50f6SAlberto Garcia        # Illegal: hd1 cannot point to itself
511bf3e50f6SAlberto Garcia        self.reopen(opts[1], {'backing': 'hd1'},
512ecd30d2dSAlberto Garcia                    "Making 'hd1' a backing child of 'hd1' would create a cycle")
513bf3e50f6SAlberto Garcia
514bf3e50f6SAlberto Garcia        # Remove all backing files
515bf3e50f6SAlberto Garcia        self.reopen(opts[0])
516bf3e50f6SAlberto Garcia        self.reopen(opts[2])
517bf3e50f6SAlberto Garcia
518bf3e50f6SAlberto Garcia        ##########################################
519bf3e50f6SAlberto Garcia        # Add a blkverify node using hd0 and hd1 #
520bf3e50f6SAlberto Garcia        ##########################################
521bf3e50f6SAlberto Garcia        bvopts = {'driver': 'blkverify',
522bf3e50f6SAlberto Garcia                  'node-name': 'bv',
523bf3e50f6SAlberto Garcia                  'test': 'hd0',
524bf3e50f6SAlberto Garcia                  'raw': 'hd1'}
525bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **bvopts)
526bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
527bf3e50f6SAlberto Garcia
528bf3e50f6SAlberto Garcia        # blkverify doesn't currently allow reopening. TODO: implement this
529bf3e50f6SAlberto Garcia        self.reopen(bvopts, {}, "Block format 'blkverify' used by node 'bv'" +
530bf3e50f6SAlberto Garcia                    " does not support reopening files")
531bf3e50f6SAlberto Garcia
532bf3e50f6SAlberto Garcia        # Illegal: hd0 is a child of the blkverify node
533bf3e50f6SAlberto Garcia        self.reopen(opts[0], {'backing': 'bv'},
534ecd30d2dSAlberto Garcia                    "Making 'bv' a backing child of 'hd0' would create a cycle")
535bf3e50f6SAlberto Garcia
536bf3e50f6SAlberto Garcia        # Delete the blkverify node
537bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'bv')
538bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
539bf3e50f6SAlberto Garcia
540*4c5393f1SAlberto Garcia    # Replace the protocol layer ('file' parameter) of a disk image
541*4c5393f1SAlberto Garcia    def test_replace_file(self):
542*4c5393f1SAlberto Garcia        # Create two small raw images and add them to a running VM
543*4c5393f1SAlberto Garcia        qemu_img('create', '-f', 'raw', hd_path[0], '10k')
544*4c5393f1SAlberto Garcia        qemu_img('create', '-f', 'raw', hd_path[1], '10k')
545*4c5393f1SAlberto Garcia
546*4c5393f1SAlberto Garcia        hd0_opts = {'driver': 'file', 'node-name': 'hd0-file', 'filename':  hd_path[0] }
547*4c5393f1SAlberto Garcia        hd1_opts = {'driver': 'file', 'node-name': 'hd1-file', 'filename':  hd_path[1] }
548*4c5393f1SAlberto Garcia
549*4c5393f1SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **hd0_opts)
550*4c5393f1SAlberto Garcia        self.assert_qmp(result, 'return', {})
551*4c5393f1SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **hd1_opts)
552*4c5393f1SAlberto Garcia        self.assert_qmp(result, 'return', {})
553*4c5393f1SAlberto Garcia
554*4c5393f1SAlberto Garcia        # Add a raw format layer that uses hd0-file as its protocol layer
555*4c5393f1SAlberto Garcia        opts = {'driver': 'raw', 'node-name': 'hd', 'file': 'hd0-file'}
556*4c5393f1SAlberto Garcia
557*4c5393f1SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
558*4c5393f1SAlberto Garcia        self.assert_qmp(result, 'return', {})
559*4c5393f1SAlberto Garcia
560*4c5393f1SAlberto Garcia        # Fill the image with data
561*4c5393f1SAlberto Garcia        self.run_qemu_io("hd", "read  -P 0 0 10k")
562*4c5393f1SAlberto Garcia        self.run_qemu_io("hd", "write -P 0xa0 0 10k")
563*4c5393f1SAlberto Garcia
564*4c5393f1SAlberto Garcia        # Replace hd0-file with hd1-file and fill it with (different) data
565*4c5393f1SAlberto Garcia        self.reopen(opts, {'file': 'hd1-file'})
566*4c5393f1SAlberto Garcia        self.run_qemu_io("hd", "read  -P 0 0 10k")
567*4c5393f1SAlberto Garcia        self.run_qemu_io("hd", "write -P 0xa1 0 10k")
568*4c5393f1SAlberto Garcia
569*4c5393f1SAlberto Garcia        # Use hd0-file again and check that it contains the expected data
570*4c5393f1SAlberto Garcia        self.reopen(opts, {'file': 'hd0-file'})
571*4c5393f1SAlberto Garcia        self.run_qemu_io("hd", "read  -P 0xa0 0 10k")
572*4c5393f1SAlberto Garcia
573*4c5393f1SAlberto Garcia        # And finally do the same with hd1-file
574*4c5393f1SAlberto Garcia        self.reopen(opts, {'file': 'hd1-file'})
575*4c5393f1SAlberto Garcia        self.run_qemu_io("hd", "read  -P 0xa1 0 10k")
576*4c5393f1SAlberto Garcia
577*4c5393f1SAlberto Garcia    # Insert (and remove) a throttle filter
578*4c5393f1SAlberto Garcia    def test_insert_throttle_filter(self):
579*4c5393f1SAlberto Garcia        # Add an image to the VM
580*4c5393f1SAlberto Garcia        hd0_opts = hd_opts(0)
581*4c5393f1SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **hd0_opts)
582*4c5393f1SAlberto Garcia        self.assert_qmp(result, 'return', {})
583*4c5393f1SAlberto Garcia
584*4c5393f1SAlberto Garcia        # Create a throttle-group object
585*4c5393f1SAlberto Garcia        opts = { 'qom-type': 'throttle-group', 'id': 'group0',
586*4c5393f1SAlberto Garcia                 'limits': { 'iops-total': 1000 } }
587*4c5393f1SAlberto Garcia        result = self.vm.qmp('object-add', conv_keys = False, **opts)
588*4c5393f1SAlberto Garcia        self.assert_qmp(result, 'return', {})
589*4c5393f1SAlberto Garcia
590*4c5393f1SAlberto Garcia        # Add a throttle filter with the group that we just created.
591*4c5393f1SAlberto Garcia        # The filter is not used by anyone yet
592*4c5393f1SAlberto Garcia        opts = { 'driver': 'throttle', 'node-name': 'throttle0',
593*4c5393f1SAlberto Garcia                 'throttle-group': 'group0', 'file': 'hd0-file' }
594*4c5393f1SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
595*4c5393f1SAlberto Garcia        self.assert_qmp(result, 'return', {})
596*4c5393f1SAlberto Garcia
597*4c5393f1SAlberto Garcia        # Insert the throttle filter between hd0 and hd0-file
598*4c5393f1SAlberto Garcia        self.reopen(hd0_opts, {'file': 'throttle0'})
599*4c5393f1SAlberto Garcia
600*4c5393f1SAlberto Garcia        # Remove the throttle filter from hd0
601*4c5393f1SAlberto Garcia        self.reopen(hd0_opts, {'file': 'hd0-file'})
602*4c5393f1SAlberto Garcia
603*4c5393f1SAlberto Garcia    # Insert (and remove) a compress filter
604*4c5393f1SAlberto Garcia    def test_insert_compress_filter(self):
605*4c5393f1SAlberto Garcia        # Add an image to the VM: hd (raw) -> hd0 (qcow2) -> hd0-file (file)
606*4c5393f1SAlberto Garcia        opts = {'driver': 'raw', 'node-name': 'hd', 'file': hd_opts(0)}
607*4c5393f1SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
608*4c5393f1SAlberto Garcia        self.assert_qmp(result, 'return', {})
609*4c5393f1SAlberto Garcia
610*4c5393f1SAlberto Garcia        # Add a 'compress' filter
611*4c5393f1SAlberto Garcia        filter_opts = {'driver': 'compress',
612*4c5393f1SAlberto Garcia                       'node-name': 'compress0',
613*4c5393f1SAlberto Garcia                       'file': 'hd0'}
614*4c5393f1SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **filter_opts)
615*4c5393f1SAlberto Garcia        self.assert_qmp(result, 'return', {})
616*4c5393f1SAlberto Garcia
617*4c5393f1SAlberto Garcia        # Unmap the beginning of the image (we cannot write compressed
618*4c5393f1SAlberto Garcia        # data to an allocated cluster)
619*4c5393f1SAlberto Garcia        self.run_qemu_io("hd", "write -z -u 0 128k")
620*4c5393f1SAlberto Garcia
621*4c5393f1SAlberto Garcia        # Write data to the first cluster
622*4c5393f1SAlberto Garcia        self.run_qemu_io("hd", "write -P 0xa0 0 64k")
623*4c5393f1SAlberto Garcia
624*4c5393f1SAlberto Garcia        # Insert the filter then write to the second cluster
625*4c5393f1SAlberto Garcia        # hd -> compress0 -> hd0 -> hd0-file
626*4c5393f1SAlberto Garcia        self.reopen(opts, {'file': 'compress0'})
627*4c5393f1SAlberto Garcia        self.run_qemu_io("hd", "write -P 0xa1 64k 64k")
628*4c5393f1SAlberto Garcia
629*4c5393f1SAlberto Garcia        # Remove the filter then write to the third cluster
630*4c5393f1SAlberto Garcia        # hd -> hd0 -> hd0-file
631*4c5393f1SAlberto Garcia        self.reopen(opts, {'file': 'hd0'})
632*4c5393f1SAlberto Garcia        self.run_qemu_io("hd", "write -P 0xa2 128k 64k")
633*4c5393f1SAlberto Garcia
634*4c5393f1SAlberto Garcia        # Verify the data that we just wrote
635*4c5393f1SAlberto Garcia        self.run_qemu_io("hd", "read -P 0xa0    0 64k")
636*4c5393f1SAlberto Garcia        self.run_qemu_io("hd", "read -P 0xa1  64k 64k")
637*4c5393f1SAlberto Garcia        self.run_qemu_io("hd", "read -P 0xa2 128k 64k")
638*4c5393f1SAlberto Garcia
639*4c5393f1SAlberto Garcia        self.vm.shutdown()
640*4c5393f1SAlberto Garcia
641*4c5393f1SAlberto Garcia        # Check the first byte of the first three L2 entries and verify that
642*4c5393f1SAlberto Garcia        # the second one is compressed (0x40) while the others are not (0x80)
643*4c5393f1SAlberto Garcia        iotests.qemu_io_log('-f', 'raw', '-c', 'read -P 0x80 0x40000 1',
644*4c5393f1SAlberto Garcia                                         '-c', 'read -P 0x40 0x40008 1',
645*4c5393f1SAlberto Garcia                                         '-c', 'read -P 0x80 0x40010 1', hd_path[0])
646*4c5393f1SAlberto Garcia
647bf3e50f6SAlberto Garcia    # Misc reopen tests with different block drivers
6489442bebeSThomas Huth    @iotests.skip_if_unsupported(['quorum', 'throttle'])
649bf3e50f6SAlberto Garcia    def test_misc_drivers(self):
650bf3e50f6SAlberto Garcia        ####################
651bf3e50f6SAlberto Garcia        ###### quorum ######
652bf3e50f6SAlberto Garcia        ####################
653bf3e50f6SAlberto Garcia        for i in range(3):
654bf3e50f6SAlberto Garcia            opts = hd_opts(i)
655bf3e50f6SAlberto Garcia            # Open all three images without backing file
656bf3e50f6SAlberto Garcia            opts['backing'] = None
657bf3e50f6SAlberto Garcia            result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
658bf3e50f6SAlberto Garcia            self.assert_qmp(result, 'return', {})
659bf3e50f6SAlberto Garcia
660bf3e50f6SAlberto Garcia        opts = {'driver': 'quorum',
661bf3e50f6SAlberto Garcia                'node-name': 'quorum0',
662bf3e50f6SAlberto Garcia                'children': ['hd0', 'hd1', 'hd2'],
663bf3e50f6SAlberto Garcia                'vote-threshold': 2}
664bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
665bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
666bf3e50f6SAlberto Garcia
667bf3e50f6SAlberto Garcia        # Quorum doesn't currently allow reopening. TODO: implement this
668bf3e50f6SAlberto Garcia        self.reopen(opts, {}, "Block format 'quorum' used by node 'quorum0'" +
669bf3e50f6SAlberto Garcia                    " does not support reopening files")
670bf3e50f6SAlberto Garcia
671bf3e50f6SAlberto Garcia        # You can't make quorum0 a backing file of hd0:
672bf3e50f6SAlberto Garcia        # hd0 is already a child of quorum0.
673bf3e50f6SAlberto Garcia        self.reopen(hd_opts(0), {'backing': 'quorum0'},
674ecd30d2dSAlberto Garcia                    "Making 'quorum0' a backing child of 'hd0' would create a cycle")
675bf3e50f6SAlberto Garcia
676bf3e50f6SAlberto Garcia        # Delete quorum0
677bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'quorum0')
678bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
679bf3e50f6SAlberto Garcia
680bf3e50f6SAlberto Garcia        # Delete hd0, hd1 and hd2
681bf3e50f6SAlberto Garcia        for i in range(3):
682bf3e50f6SAlberto Garcia            result = self.vm.qmp('blockdev-del', conv_keys = True,
683bf3e50f6SAlberto Garcia                                 node_name = 'hd%d' % i)
684bf3e50f6SAlberto Garcia            self.assert_qmp(result, 'return', {})
685bf3e50f6SAlberto Garcia
686bf3e50f6SAlberto Garcia        ######################
687bf3e50f6SAlberto Garcia        ###### blkdebug ######
688bf3e50f6SAlberto Garcia        ######################
689bf3e50f6SAlberto Garcia        opts = {'driver': 'blkdebug',
690bf3e50f6SAlberto Garcia                'node-name': 'bd',
691bf3e50f6SAlberto Garcia                'config': '/dev/null',
692bf3e50f6SAlberto Garcia                'image': hd_opts(0)}
693bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
694bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
695bf3e50f6SAlberto Garcia
696bf3e50f6SAlberto Garcia        # blkdebug allows reopening if we keep the same options
697bf3e50f6SAlberto Garcia        self.reopen(opts)
698bf3e50f6SAlberto Garcia
699bf3e50f6SAlberto Garcia        # but it currently does not allow changes
700bf3e50f6SAlberto Garcia        self.reopen(opts, {'image': 'hd1'}, "Cannot change the option 'image'")
701bf3e50f6SAlberto Garcia        self.reopen(opts, {'align': 33554432}, "Cannot change the option 'align'")
702bf3e50f6SAlberto Garcia        self.reopen(opts, {'config': '/non/existent'}, "Cannot change the option 'config'")
703bf3e50f6SAlberto Garcia        del opts['config']
704bf3e50f6SAlberto Garcia        self.reopen(opts, {}, "Option 'config' cannot be reset to its default value")
705bf3e50f6SAlberto Garcia
706bf3e50f6SAlberto Garcia        # Delete the blkdebug node
707bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'bd')
708bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
709bf3e50f6SAlberto Garcia
710bf3e50f6SAlberto Garcia        ##################
711bf3e50f6SAlberto Garcia        ###### null ######
712bf3e50f6SAlberto Garcia        ##################
713a6f8f9f8SMax Reitz        opts = {'driver': 'null-co', 'node-name': 'root', 'size': 1024}
714bf3e50f6SAlberto Garcia
715bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
716bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
717bf3e50f6SAlberto Garcia
718bf3e50f6SAlberto Garcia        # 1 << 30 is the default value, but we cannot change it explicitly
719bf3e50f6SAlberto Garcia        self.reopen(opts, {'size': (1 << 30)}, "Cannot change the option 'size'")
720bf3e50f6SAlberto Garcia
721bf3e50f6SAlberto Garcia        # We cannot change 'size' back to its default value either
722bf3e50f6SAlberto Garcia        del opts['size']
723bf3e50f6SAlberto Garcia        self.reopen(opts, {}, "Option 'size' cannot be reset to its default value")
724bf3e50f6SAlberto Garcia
725bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'root')
726bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
727bf3e50f6SAlberto Garcia
728bf3e50f6SAlberto Garcia        ##################
729bf3e50f6SAlberto Garcia        ###### file ######
730bf3e50f6SAlberto Garcia        ##################
731bf3e50f6SAlberto Garcia        opts = hd_opts(0)
732bf3e50f6SAlberto Garcia        opts['file']['locking'] = 'on'
733bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
734bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
735bf3e50f6SAlberto Garcia
736bf3e50f6SAlberto Garcia        # 'locking' cannot be changed
737bf3e50f6SAlberto Garcia        del opts['file']['locking']
738bf3e50f6SAlberto Garcia        self.reopen(opts, {'file.locking': 'on'})
739bf3e50f6SAlberto Garcia        self.reopen(opts, {'file.locking': 'off'}, "Cannot change the option 'locking'")
740bf3e50f6SAlberto Garcia        self.reopen(opts, {}, "Option 'locking' cannot be reset to its default value")
741bf3e50f6SAlberto Garcia
742bf3e50f6SAlberto Garcia        # Trying to reopen the 'file' node directly does not make a difference
743bf3e50f6SAlberto Garcia        opts = opts['file']
744bf3e50f6SAlberto Garcia        self.reopen(opts, {'locking': 'on'})
745bf3e50f6SAlberto Garcia        self.reopen(opts, {'locking': 'off'}, "Cannot change the option 'locking'")
746bf3e50f6SAlberto Garcia        self.reopen(opts, {}, "Option 'locking' cannot be reset to its default value")
747bf3e50f6SAlberto Garcia
748bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0')
749bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
750bf3e50f6SAlberto Garcia
751bf3e50f6SAlberto Garcia        ######################
752bf3e50f6SAlberto Garcia        ###### throttle ######
753bf3e50f6SAlberto Garcia        ######################
754bf3e50f6SAlberto Garcia        opts = { 'qom-type': 'throttle-group', 'id': 'group0',
755fa818b2fSAlberto Garcia                 'limits': { 'iops-total': 1000 } }
756bf3e50f6SAlberto Garcia        result = self.vm.qmp('object-add', conv_keys = False, **opts)
757bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
758bf3e50f6SAlberto Garcia
759bf3e50f6SAlberto Garcia        opts = { 'qom-type': 'throttle-group', 'id': 'group1',
760fa818b2fSAlberto Garcia                 'limits': { 'iops-total': 2000 } }
761bf3e50f6SAlberto Garcia        result = self.vm.qmp('object-add', conv_keys = False, **opts)
762bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
763bf3e50f6SAlberto Garcia
764bf3e50f6SAlberto Garcia        # Add a throttle filter with group = group0
765bf3e50f6SAlberto Garcia        opts = { 'driver': 'throttle', 'node-name': 'throttle0',
766bf3e50f6SAlberto Garcia                 'throttle-group': 'group0', 'file': hd_opts(0) }
767bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
768bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
769bf3e50f6SAlberto Garcia
770bf3e50f6SAlberto Garcia        # We can reopen it if we keep the same options
771bf3e50f6SAlberto Garcia        self.reopen(opts)
772bf3e50f6SAlberto Garcia
773bf3e50f6SAlberto Garcia        # We can also reopen if 'file' is a reference to the child
774bf3e50f6SAlberto Garcia        self.reopen(opts, {'file': 'hd0'})
775bf3e50f6SAlberto Garcia
776bf3e50f6SAlberto Garcia        # This is illegal
777bf3e50f6SAlberto Garcia        self.reopen(opts, {'throttle-group': 'notfound'}, "Throttle group 'notfound' does not exist")
778bf3e50f6SAlberto Garcia
779bf3e50f6SAlberto Garcia        # But it's possible to change the group to group1
780bf3e50f6SAlberto Garcia        self.reopen(opts, {'throttle-group': 'group1'})
781bf3e50f6SAlberto Garcia
782bf3e50f6SAlberto Garcia        # Now group1 is in use, it cannot be deleted
783bf3e50f6SAlberto Garcia        result = self.vm.qmp('object-del', id = 'group1')
784bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'error/class', 'GenericError')
785bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'error/desc', "object 'group1' is in use, can not be deleted")
786bf3e50f6SAlberto Garcia
787bf3e50f6SAlberto Garcia        # Default options, this switches the group back to group0
788bf3e50f6SAlberto Garcia        self.reopen(opts)
789bf3e50f6SAlberto Garcia
790bf3e50f6SAlberto Garcia        # So now we cannot delete group0
791bf3e50f6SAlberto Garcia        result = self.vm.qmp('object-del', id = 'group0')
792bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'error/class', 'GenericError')
793bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'error/desc', "object 'group0' is in use, can not be deleted")
794bf3e50f6SAlberto Garcia
795bf3e50f6SAlberto Garcia        # But group1 is free this time, and it can be deleted
796bf3e50f6SAlberto Garcia        result = self.vm.qmp('object-del', id = 'group1')
797bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
798bf3e50f6SAlberto Garcia
799bf3e50f6SAlberto Garcia        # Let's delete the filter node
800bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'throttle0')
801bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
802bf3e50f6SAlberto Garcia
803bf3e50f6SAlberto Garcia        # And we can finally get rid of group0
804bf3e50f6SAlberto Garcia        result = self.vm.qmp('object-del', id = 'group0')
805bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
806bf3e50f6SAlberto Garcia
807bf3e50f6SAlberto Garcia    # If an image has a backing file then the 'backing' option must be
808bf3e50f6SAlberto Garcia    # passed on reopen. We don't allow leaving the option out in this
809bf3e50f6SAlberto Garcia    # case because it's unclear what the correct semantics would be.
810bf3e50f6SAlberto Garcia    def test_missing_backing_options_1(self):
811bf3e50f6SAlberto Garcia        # hd2
812bf3e50f6SAlberto Garcia        opts = hd_opts(2)
813bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
814bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
815bf3e50f6SAlberto Garcia
816bf3e50f6SAlberto Garcia        # hd0
817bf3e50f6SAlberto Garcia        opts = hd_opts(0)
818bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
819bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
820bf3e50f6SAlberto Garcia
821bf3e50f6SAlberto Garcia        # hd0 has no backing file: we can omit the 'backing' option
822bf3e50f6SAlberto Garcia        self.reopen(opts)
823bf3e50f6SAlberto Garcia
824bf3e50f6SAlberto Garcia        # hd2 <- hd0
825bf3e50f6SAlberto Garcia        self.reopen(opts, {'backing': 'hd2'})
826bf3e50f6SAlberto Garcia
827bf3e50f6SAlberto Garcia        # hd0 has a backing file: we must set the 'backing' option
828bf3e50f6SAlberto Garcia        self.reopen(opts, {}, "backing is missing for 'hd0'")
829bf3e50f6SAlberto Garcia
830bf3e50f6SAlberto Garcia        # hd2 can't be removed because it's the backing file of hd0
831bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd2')
832bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'error/class', 'GenericError')
833bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'error/desc', "Node 'hd2' is busy: node is used as backing hd of 'hd0'")
834bf3e50f6SAlberto Garcia
835bf3e50f6SAlberto Garcia        # Detach hd2 from hd0.
836bf3e50f6SAlberto Garcia        self.reopen(opts, {'backing': None})
8370b877d09SMax Reitz
8380b877d09SMax Reitz        # Without a backing file, we can omit 'backing' again
8390b877d09SMax Reitz        self.reopen(opts)
840bf3e50f6SAlberto Garcia
841bf3e50f6SAlberto Garcia        # Remove both hd0 and hd2
842bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0')
843bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
844bf3e50f6SAlberto Garcia
845bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd2')
846bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
847bf3e50f6SAlberto Garcia
848bf3e50f6SAlberto Garcia    # If an image has default backing file (as part of its metadata)
849bf3e50f6SAlberto Garcia    # then the 'backing' option must be passed on reopen. We don't
850bf3e50f6SAlberto Garcia    # allow leaving the option out in this case because it's unclear
851bf3e50f6SAlberto Garcia    # what the correct semantics would be.
852bf3e50f6SAlberto Garcia    def test_missing_backing_options_2(self):
853bf3e50f6SAlberto Garcia        # hd0 <- hd1
854bf3e50f6SAlberto Garcia        # (hd0 is hd1's default backing file)
855bf3e50f6SAlberto Garcia        opts = hd_opts(1)
856bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
857bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
858bf3e50f6SAlberto Garcia
859bf3e50f6SAlberto Garcia        # hd1 has a backing file: we can't omit the 'backing' option
860bf3e50f6SAlberto Garcia        self.reopen(opts, {}, "backing is missing for 'hd1'")
861bf3e50f6SAlberto Garcia
862bf3e50f6SAlberto Garcia        # Let's detach the backing file
863bf3e50f6SAlberto Garcia        self.reopen(opts, {'backing': None})
864bf3e50f6SAlberto Garcia
865bf3e50f6SAlberto Garcia        # No backing file attached to hd1 now, but we still can't omit the 'backing' option
866bf3e50f6SAlberto Garcia        self.reopen(opts, {}, "backing is missing for 'hd1'")
867bf3e50f6SAlberto Garcia
868bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd1')
869bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
870bf3e50f6SAlberto Garcia
871bf3e50f6SAlberto Garcia    # Test that making 'backing' a reference to an existing child
872bf3e50f6SAlberto Garcia    # keeps its current options
873bf3e50f6SAlberto Garcia    def test_backing_reference(self):
874bf3e50f6SAlberto Garcia        # hd2 <- hd1 <- hd0
875bf3e50f6SAlberto Garcia        opts = hd_opts(0)
876bf3e50f6SAlberto Garcia        opts['backing'] = hd_opts(1)
877bf3e50f6SAlberto Garcia        opts['backing']['backing'] = hd_opts(2)
878bf3e50f6SAlberto Garcia        # Enable 'detect-zeroes' on all three nodes
879bf3e50f6SAlberto Garcia        opts['detect-zeroes'] = 'on'
880bf3e50f6SAlberto Garcia        opts['backing']['detect-zeroes'] = 'on'
881bf3e50f6SAlberto Garcia        opts['backing']['backing']['detect-zeroes'] = 'on'
882bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
883bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
884bf3e50f6SAlberto Garcia
885bf3e50f6SAlberto Garcia        # Reopen the chain passing the minimum amount of required options.
886bf3e50f6SAlberto Garcia        # By making 'backing' a reference to hd1 (instead of a sub-dict)
887bf3e50f6SAlberto Garcia        # we tell QEMU to keep its current set of options.
888bf3e50f6SAlberto Garcia        opts = {'driver': iotests.imgfmt,
889bf3e50f6SAlberto Garcia                'node-name': 'hd0',
890bf3e50f6SAlberto Garcia                'file': 'hd0-file',
891bf3e50f6SAlberto Garcia                'backing': 'hd1' }
892bf3e50f6SAlberto Garcia        self.reopen(opts)
893bf3e50f6SAlberto Garcia
894bf3e50f6SAlberto Garcia        # This has reset 'detect-zeroes' on hd0, but not on hd1 and hd2.
895bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd0'), 'detect_zeroes', 'off')
896bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd1'), 'detect_zeroes', 'on')
897bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd2'), 'detect_zeroes', 'on')
898bf3e50f6SAlberto Garcia
899bf3e50f6SAlberto Garcia    # Test what happens if the graph changes due to other operations
900bf3e50f6SAlberto Garcia    # such as block-stream
901bf3e50f6SAlberto Garcia    def test_block_stream_1(self):
902bf3e50f6SAlberto Garcia        # hd1 <- hd0
903bf3e50f6SAlberto Garcia        opts = hd_opts(0)
904bf3e50f6SAlberto Garcia        opts['backing'] = hd_opts(1)
905bf3e50f6SAlberto Garcia        opts['backing']['backing'] = None
906bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
907bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
908bf3e50f6SAlberto Garcia
909bf3e50f6SAlberto Garcia        # Stream hd1 into hd0 and wait until it's done
910bf3e50f6SAlberto Garcia        result = self.vm.qmp('block-stream', conv_keys = True, job_id = 'stream0', device = 'hd0')
911bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
912bf3e50f6SAlberto Garcia        self.wait_until_completed(drive = 'stream0')
913bf3e50f6SAlberto Garcia
914bf3e50f6SAlberto Garcia        # Now we have only hd0
915bf3e50f6SAlberto Garcia        self.assertEqual(self.get_node('hd1'), None)
916bf3e50f6SAlberto Garcia
917bf3e50f6SAlberto Garcia        # We have backing.* options but there's no backing file anymore
918bf3e50f6SAlberto Garcia        self.reopen(opts, {}, "Cannot change the option 'backing.driver'")
919bf3e50f6SAlberto Garcia
920bf3e50f6SAlberto Garcia        # If we remove the 'backing' option then we can reopen hd0 just fine
921bf3e50f6SAlberto Garcia        del opts['backing']
922bf3e50f6SAlberto Garcia        self.reopen(opts)
923bf3e50f6SAlberto Garcia
924bf3e50f6SAlberto Garcia        # We can also reopen hd0 if we set 'backing' to null
925bf3e50f6SAlberto Garcia        self.reopen(opts, {'backing': None})
926bf3e50f6SAlberto Garcia
927bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0')
928bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
929bf3e50f6SAlberto Garcia
930bf3e50f6SAlberto Garcia    # Another block_stream test
931bf3e50f6SAlberto Garcia    def test_block_stream_2(self):
932bf3e50f6SAlberto Garcia        # hd2 <- hd1 <- hd0
933bf3e50f6SAlberto Garcia        opts = hd_opts(0)
934bf3e50f6SAlberto Garcia        opts['backing'] = hd_opts(1)
935bf3e50f6SAlberto Garcia        opts['backing']['backing'] = hd_opts(2)
936bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
937bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
938bf3e50f6SAlberto Garcia
939bf3e50f6SAlberto Garcia        # Stream hd1 into hd0 and wait until it's done
940bf3e50f6SAlberto Garcia        result = self.vm.qmp('block-stream', conv_keys = True, job_id = 'stream0',
941bf3e50f6SAlberto Garcia                             device = 'hd0', base_node = 'hd2')
942bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
943bf3e50f6SAlberto Garcia        self.wait_until_completed(drive = 'stream0')
944bf3e50f6SAlberto Garcia
945bf3e50f6SAlberto Garcia        # The chain is hd2 <- hd0 now. hd1 is missing
946bf3e50f6SAlberto Garcia        self.assertEqual(self.get_node('hd1'), None)
947bf3e50f6SAlberto Garcia
948bf3e50f6SAlberto Garcia        # The backing options in the dict were meant for hd1, but we cannot
949bf3e50f6SAlberto Garcia        # use them with hd2 because hd1 had a backing file while hd2 does not.
950bf3e50f6SAlberto Garcia        self.reopen(opts, {}, "Cannot change the option 'backing.driver'")
951bf3e50f6SAlberto Garcia
952bf3e50f6SAlberto Garcia        # If we remove hd1's options from the dict then things work fine
953bf3e50f6SAlberto Garcia        opts['backing'] = opts['backing']['backing']
954bf3e50f6SAlberto Garcia        self.reopen(opts)
955bf3e50f6SAlberto Garcia
956bf3e50f6SAlberto Garcia        # We can also reopen hd0 if we use a reference to the backing file
957bf3e50f6SAlberto Garcia        self.reopen(opts, {'backing': 'hd2'})
958bf3e50f6SAlberto Garcia
959bf3e50f6SAlberto Garcia        # But we cannot leave the option out
960bf3e50f6SAlberto Garcia        del opts['backing']
961bf3e50f6SAlberto Garcia        self.reopen(opts, {}, "backing is missing for 'hd0'")
962bf3e50f6SAlberto Garcia
963bf3e50f6SAlberto Garcia        # Now we can delete hd0 (and hd2)
964bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0')
965bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
966bf3e50f6SAlberto Garcia        self.assertEqual(self.get_node('hd2'), None)
967bf3e50f6SAlberto Garcia
968bf3e50f6SAlberto Garcia    # Reopen the chain during a block-stream job (from hd1 to hd0)
969bf3e50f6SAlberto Garcia    def test_block_stream_3(self):
970bf3e50f6SAlberto Garcia        # hd2 <- hd1 <- hd0
971bf3e50f6SAlberto Garcia        opts = hd_opts(0)
972bf3e50f6SAlberto Garcia        opts['backing'] = hd_opts(1)
973bf3e50f6SAlberto Garcia        opts['backing']['backing'] = hd_opts(2)
974bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
975bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
976bf3e50f6SAlberto Garcia
977bf3e50f6SAlberto Garcia        # hd2 <- hd0
978bf3e50f6SAlberto Garcia        result = self.vm.qmp('block-stream', conv_keys = True, job_id = 'stream0',
979c423a6afSMax Reitz                             device = 'hd0', base_node = 'hd2',
980c423a6afSMax Reitz                             auto_finalize = False)
981bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
982bf3e50f6SAlberto Garcia
983c624b015SAndrey Shinkevich        # We can remove hd2 while the stream job is ongoing
984bf3e50f6SAlberto Garcia        opts['backing']['backing'] = None
985c624b015SAndrey Shinkevich        self.reopen(opts, {})
986bf3e50f6SAlberto Garcia
987bf3e50f6SAlberto Garcia        # We can't remove hd1 while the stream job is ongoing
988bf3e50f6SAlberto Garcia        opts['backing'] = None
989bfae052aSVladimir Sementsov-Ogievskiy        self.reopen(opts, {}, "Cannot change frozen 'backing' link from 'hd0' to 'hd1'")
990bf3e50f6SAlberto Garcia
991c423a6afSMax Reitz        self.vm.run_job('stream0', auto_finalize = False, auto_dismiss = True)
992bf3e50f6SAlberto Garcia
993bf3e50f6SAlberto Garcia    # Reopen the chain during a block-stream job (from hd2 to hd1)
994bf3e50f6SAlberto Garcia    def test_block_stream_4(self):
995bf3e50f6SAlberto Garcia        # hd2 <- hd1 <- hd0
996bf3e50f6SAlberto Garcia        opts = hd_opts(0)
997bf3e50f6SAlberto Garcia        opts['backing'] = hd_opts(1)
998bf3e50f6SAlberto Garcia        opts['backing']['backing'] = hd_opts(2)
999bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
1000bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
1001bf3e50f6SAlberto Garcia
1002bf3e50f6SAlberto Garcia        # hd1 <- hd0
1003bf3e50f6SAlberto Garcia        result = self.vm.qmp('block-stream', conv_keys = True, job_id = 'stream0',
1004205736f4SAndrey Shinkevich                             device = 'hd1', filter_node_name='cor',
1005205736f4SAndrey Shinkevich                             auto_finalize = False)
1006bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
1007bf3e50f6SAlberto Garcia
1008205736f4SAndrey Shinkevich        # We can't reopen with the original options because there is a filter
1009205736f4SAndrey Shinkevich        # inserted by stream job above hd1.
1010c423a6afSMax Reitz        self.reopen(opts, {},
1011205736f4SAndrey Shinkevich                    "Cannot change the option 'backing.backing.file.node-name'")
1012205736f4SAndrey Shinkevich
1013205736f4SAndrey Shinkevich        # We can't reopen hd1 to read-only, as block-stream requires it to be
1014205736f4SAndrey Shinkevich        # read-write
1015205736f4SAndrey Shinkevich        self.reopen(opts['backing'], {'read-only': True},
1016c20555e1SVladimir Sementsov-Ogievskiy                    "Read-only block node 'hd1' cannot support read-write users")
1017bf3e50f6SAlberto Garcia
1018bf3e50f6SAlberto Garcia        # We can't remove hd2 while the stream job is ongoing
1019bf3e50f6SAlberto Garcia        opts['backing']['backing'] = None
1020205736f4SAndrey Shinkevich        self.reopen(opts['backing'], {'read-only': False},
1021bfae052aSVladimir Sementsov-Ogievskiy                    "Cannot change frozen 'backing' link from 'hd1' to 'hd2'")
1022bf3e50f6SAlberto Garcia
1023bf3e50f6SAlberto Garcia        # We can detach hd1 from hd0 because it doesn't affect the stream job
1024bf3e50f6SAlberto Garcia        opts['backing'] = None
1025bf3e50f6SAlberto Garcia        self.reopen(opts)
1026bf3e50f6SAlberto Garcia
1027c423a6afSMax Reitz        self.vm.run_job('stream0', auto_finalize = False, auto_dismiss = True)
1028bf3e50f6SAlberto Garcia
1029bf3e50f6SAlberto Garcia    # Reopen the chain during a block-commit job (from hd0 to hd2)
1030bf3e50f6SAlberto Garcia    def test_block_commit_1(self):
1031bf3e50f6SAlberto Garcia        # hd2 <- hd1 <- hd0
1032bf3e50f6SAlberto Garcia        opts = hd_opts(0)
1033bf3e50f6SAlberto Garcia        opts['backing'] = hd_opts(1)
1034bf3e50f6SAlberto Garcia        opts['backing']['backing'] = hd_opts(2)
1035bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
1036bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
1037bf3e50f6SAlberto Garcia
1038bf3e50f6SAlberto Garcia        result = self.vm.qmp('block-commit', conv_keys = True, job_id = 'commit0',
1039c423a6afSMax Reitz                             device = 'hd0')
1040bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
1041bf3e50f6SAlberto Garcia
1042bf3e50f6SAlberto Garcia        # We can't remove hd2 while the commit job is ongoing
1043bf3e50f6SAlberto Garcia        opts['backing']['backing'] = None
1044bfae052aSVladimir Sementsov-Ogievskiy        self.reopen(opts, {}, "Cannot change frozen 'backing' link from 'hd1' to 'hd2'")
1045bf3e50f6SAlberto Garcia
1046bf3e50f6SAlberto Garcia        # We can't remove hd1 while the commit job is ongoing
1047bf3e50f6SAlberto Garcia        opts['backing'] = None
1048bfae052aSVladimir Sementsov-Ogievskiy        self.reopen(opts, {}, "Cannot change frozen 'backing' link from 'hd0' to 'hd1'")
1049bf3e50f6SAlberto Garcia
1050bf3e50f6SAlberto Garcia        event = self.vm.event_wait(name='BLOCK_JOB_READY')
1051bf3e50f6SAlberto Garcia        self.assert_qmp(event, 'data/device', 'commit0')
1052bf3e50f6SAlberto Garcia        self.assert_qmp(event, 'data/type', 'commit')
1053bf3e50f6SAlberto Garcia        self.assert_qmp_absent(event, 'data/error')
1054bf3e50f6SAlberto Garcia
1055bf3e50f6SAlberto Garcia        result = self.vm.qmp('block-job-complete', device='commit0')
1056bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
1057bf3e50f6SAlberto Garcia
1058bf3e50f6SAlberto Garcia        self.wait_until_completed(drive = 'commit0')
1059bf3e50f6SAlberto Garcia
1060bf3e50f6SAlberto Garcia    # Reopen the chain during a block-commit job (from hd1 to hd2)
1061bf3e50f6SAlberto Garcia    def test_block_commit_2(self):
1062bf3e50f6SAlberto Garcia        # hd2 <- hd1 <- hd0
1063bf3e50f6SAlberto Garcia        opts = hd_opts(0)
1064bf3e50f6SAlberto Garcia        opts['backing'] = hd_opts(1)
1065bf3e50f6SAlberto Garcia        opts['backing']['backing'] = hd_opts(2)
1066bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
1067bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
1068bf3e50f6SAlberto Garcia
1069bf3e50f6SAlberto Garcia        result = self.vm.qmp('block-commit', conv_keys = True, job_id = 'commit0',
1070c423a6afSMax Reitz                             device = 'hd0', top_node = 'hd1',
1071c423a6afSMax Reitz                             auto_finalize = False)
1072bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
1073bf3e50f6SAlberto Garcia
1074bf3e50f6SAlberto Garcia        # We can't remove hd2 while the commit job is ongoing
1075bf3e50f6SAlberto Garcia        opts['backing']['backing'] = None
1076bf3e50f6SAlberto Garcia        self.reopen(opts, {}, "Cannot change the option 'backing.driver'")
1077bf3e50f6SAlberto Garcia
1078bf3e50f6SAlberto Garcia        # We can't remove hd1 while the commit job is ongoing
1079bf3e50f6SAlberto Garcia        opts['backing'] = None
1080ecd30d2dSAlberto Garcia        self.reopen(opts, {}, "Cannot replace implicit backing child of hd0")
1081bf3e50f6SAlberto Garcia
1082bf3e50f6SAlberto Garcia        # hd2 <- hd0
1083c423a6afSMax Reitz        self.vm.run_job('commit0', auto_finalize = False, auto_dismiss = True)
1084bf3e50f6SAlberto Garcia
1085bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd0'), 'ro', False)
1086bf3e50f6SAlberto Garcia        self.assertEqual(self.get_node('hd1'), None)
1087bf3e50f6SAlberto Garcia        self.assert_qmp(self.get_node('hd2'), 'ro', True)
1088bf3e50f6SAlberto Garcia
108997518e11SKevin Wolf    def run_test_iothreads(self, iothread_a, iothread_b, errmsg = None):
1090bf3e50f6SAlberto Garcia        opts = hd_opts(0)
1091bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
1092bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
1093bf3e50f6SAlberto Garcia
1094bf3e50f6SAlberto Garcia        opts2 = hd_opts(2)
1095bf3e50f6SAlberto Garcia        result = self.vm.qmp('blockdev-add', conv_keys = False, **opts2)
1096bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
1097bf3e50f6SAlberto Garcia
1098bf3e50f6SAlberto Garcia        result = self.vm.qmp('object-add', qom_type='iothread', id='iothread0')
1099bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
1100bf3e50f6SAlberto Garcia
1101bf3e50f6SAlberto Garcia        result = self.vm.qmp('object-add', qom_type='iothread', id='iothread1')
1102bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
1103bf3e50f6SAlberto Garcia
110497518e11SKevin Wolf        result = self.vm.qmp('device_add', driver='virtio-scsi', id='scsi0',
110597518e11SKevin Wolf                             iothread=iothread_a)
1106bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
1107bf3e50f6SAlberto Garcia
110897518e11SKevin Wolf        result = self.vm.qmp('device_add', driver='virtio-scsi', id='scsi1',
110997518e11SKevin Wolf                             iothread=iothread_b)
1110bf3e50f6SAlberto Garcia        self.assert_qmp(result, 'return', {})
1111bf3e50f6SAlberto Garcia
111297518e11SKevin Wolf        if iothread_a:
111397518e11SKevin Wolf            result = self.vm.qmp('device_add', driver='scsi-hd', drive='hd0',
111497518e11SKevin Wolf                                 share_rw=True, bus="scsi0.0")
1115bf3e50f6SAlberto Garcia            self.assert_qmp(result, 'return', {})
1116bf3e50f6SAlberto Garcia
111797518e11SKevin Wolf        if iothread_b:
111897518e11SKevin Wolf            result = self.vm.qmp('device_add', driver='scsi-hd', drive='hd2',
111997518e11SKevin Wolf                                 share_rw=True, bus="scsi1.0")
112097518e11SKevin Wolf            self.assert_qmp(result, 'return', {})
112197518e11SKevin Wolf
112297518e11SKevin Wolf        # Attaching the backing file may or may not work
112397518e11SKevin Wolf        self.reopen(opts, {'backing': 'hd2'}, errmsg)
112497518e11SKevin Wolf
112597518e11SKevin Wolf        # But removing the backing file should always work
112697518e11SKevin Wolf        self.reopen(opts, {'backing': None})
112797518e11SKevin Wolf
112897518e11SKevin Wolf        self.vm.shutdown()
112997518e11SKevin Wolf
113097518e11SKevin Wolf    # We don't allow setting a backing file that uses a different AioContext if
113197518e11SKevin Wolf    # neither of them can switch to the other AioContext
113297518e11SKevin Wolf    def test_iothreads_error(self):
113397518e11SKevin Wolf        self.run_test_iothreads('iothread0', 'iothread1',
11341de6b45fSKevin Wolf                                "Cannot change iothread of active block backend")
113597518e11SKevin Wolf
113697518e11SKevin Wolf    def test_iothreads_compatible_users(self):
113797518e11SKevin Wolf        self.run_test_iothreads('iothread0', 'iothread0')
113897518e11SKevin Wolf
113997518e11SKevin Wolf    def test_iothreads_switch_backing(self):
11401de6b45fSKevin Wolf        self.run_test_iothreads('iothread0', None)
114197518e11SKevin Wolf
114297518e11SKevin Wolf    def test_iothreads_switch_overlay(self):
11431de6b45fSKevin Wolf        self.run_test_iothreads(None, 'iothread0')
1144bf3e50f6SAlberto Garcia
1145bf3e50f6SAlberto Garciaif __name__ == '__main__':
114652ea799eSJohn Snow    iotests.activate_logging()
1147103cbc77SMax Reitz    iotests.main(supported_fmts=["qcow2"],
1148103cbc77SMax Reitz                 supported_protocols=["file"])
1149