1903cb1bfSPhilippe Mathieu-Daudé#!/usr/bin/env python3 2bf3e50f6SAlberto Garcia# 3bf3e50f6SAlberto Garcia# Test cases for the QMP 'x-blockdev-reopen' command 4bf3e50f6SAlberto Garcia# 5bf3e50f6SAlberto Garcia# Copyright (C) 2018-2019 Igalia, S.L. 6bf3e50f6SAlberto Garcia# Author: Alberto Garcia <berto@igalia.com> 7bf3e50f6SAlberto Garcia# 8bf3e50f6SAlberto Garcia# This program is free software; you can redistribute it and/or modify 9bf3e50f6SAlberto Garcia# it under the terms of the GNU General Public License as published by 10bf3e50f6SAlberto Garcia# the Free Software Foundation; either version 2 of the License, or 11bf3e50f6SAlberto Garcia# (at your option) any later version. 12bf3e50f6SAlberto Garcia# 13bf3e50f6SAlberto Garcia# This program is distributed in the hope that it will be useful, 14bf3e50f6SAlberto Garcia# but WITHOUT ANY WARRANTY; without even the implied warranty of 15bf3e50f6SAlberto Garcia# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 16bf3e50f6SAlberto Garcia# GNU General Public License for more details. 17bf3e50f6SAlberto Garcia# 18bf3e50f6SAlberto Garcia# You should have received a copy of the GNU General Public License 19bf3e50f6SAlberto Garcia# along with this program. If not, see <http://www.gnu.org/licenses/>. 20bf3e50f6SAlberto Garcia# 21bf3e50f6SAlberto Garcia 22bf3e50f6SAlberto Garciaimport os 23bf3e50f6SAlberto Garciaimport re 24bf3e50f6SAlberto Garciaimport iotests 25bf3e50f6SAlberto Garciaimport copy 26bf3e50f6SAlberto Garciaimport json 27bf3e50f6SAlberto Garciafrom iotests import qemu_img, qemu_io 28bf3e50f6SAlberto Garcia 29bf3e50f6SAlberto Garciahd_path = [ 30bf3e50f6SAlberto Garcia os.path.join(iotests.test_dir, 'hd0.img'), 31bf3e50f6SAlberto Garcia os.path.join(iotests.test_dir, 'hd1.img'), 32bf3e50f6SAlberto Garcia os.path.join(iotests.test_dir, 'hd2.img') 33bf3e50f6SAlberto Garcia] 34bf3e50f6SAlberto Garcia 35bf3e50f6SAlberto Garciadef hd_opts(idx): 36bf3e50f6SAlberto Garcia return {'driver': iotests.imgfmt, 37bf3e50f6SAlberto Garcia 'node-name': 'hd%d' % idx, 38bf3e50f6SAlberto Garcia 'file': {'driver': 'file', 39bf3e50f6SAlberto Garcia 'node-name': 'hd%d-file' % idx, 40bf3e50f6SAlberto Garcia 'filename': hd_path[idx] } } 41bf3e50f6SAlberto Garcia 42bf3e50f6SAlberto Garciaclass TestBlockdevReopen(iotests.QMPTestCase): 43bf3e50f6SAlberto Garcia total_io_cmds = 0 44bf3e50f6SAlberto Garcia 45bf3e50f6SAlberto Garcia def setUp(self): 46bf3e50f6SAlberto Garcia qemu_img('create', '-f', iotests.imgfmt, hd_path[0], '3M') 47*b66ff2c2SEric Blake qemu_img('create', '-f', iotests.imgfmt, '-b', hd_path[0], 48*b66ff2c2SEric Blake '-F', iotests.imgfmt, hd_path[1]) 49bf3e50f6SAlberto Garcia qemu_img('create', '-f', iotests.imgfmt, hd_path[2], '3M') 50bf3e50f6SAlberto Garcia qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0xa0 0 1M', hd_path[0]) 51bf3e50f6SAlberto Garcia qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0xa1 1M 1M', hd_path[1]) 52bf3e50f6SAlberto Garcia qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0xa2 2M 1M', hd_path[2]) 53bf3e50f6SAlberto Garcia self.vm = iotests.VM() 54bf3e50f6SAlberto Garcia self.vm.launch() 55bf3e50f6SAlberto Garcia 56bf3e50f6SAlberto Garcia def tearDown(self): 57bf3e50f6SAlberto Garcia self.vm.shutdown() 58bf3e50f6SAlberto Garcia self.check_qemu_io_errors() 59bf3e50f6SAlberto Garcia os.remove(hd_path[0]) 60bf3e50f6SAlberto Garcia os.remove(hd_path[1]) 61bf3e50f6SAlberto Garcia os.remove(hd_path[2]) 62bf3e50f6SAlberto Garcia 63bf3e50f6SAlberto Garcia # The output of qemu-io is not returned by vm.hmp_qemu_io() but 64bf3e50f6SAlberto Garcia # it's stored in the log and can only be read when the VM has been 65bf3e50f6SAlberto Garcia # shut down. This function runs qemu-io and keeps track of the 66bf3e50f6SAlberto Garcia # number of times it's been called. 67bf3e50f6SAlberto Garcia def run_qemu_io(self, img, cmd): 68bf3e50f6SAlberto Garcia result = self.vm.hmp_qemu_io(img, cmd) 69bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', '') 70bf3e50f6SAlberto Garcia self.total_io_cmds += 1 71bf3e50f6SAlberto Garcia 72bf3e50f6SAlberto Garcia # Once the VM is shut down we can parse the log and see if qemu-io 73bf3e50f6SAlberto Garcia # ran without errors. 74bf3e50f6SAlberto Garcia def check_qemu_io_errors(self): 75bf3e50f6SAlberto Garcia self.assertFalse(self.vm.is_running()) 76bf3e50f6SAlberto Garcia found = 0 77bf3e50f6SAlberto Garcia log = self.vm.get_log() 78bf3e50f6SAlberto Garcia for line in log.split("\n"): 79bf3e50f6SAlberto Garcia if line.startswith("Pattern verification failed"): 80bf3e50f6SAlberto Garcia raise Exception("%s (command #%d)" % (line, found)) 81bf3e50f6SAlberto Garcia if re.match("read .*/.* bytes at offset", line): 82bf3e50f6SAlberto Garcia found += 1 83bf3e50f6SAlberto Garcia self.assertEqual(found, self.total_io_cmds, 84bf3e50f6SAlberto Garcia "Expected output of %d qemu-io commands, found %d" % 85bf3e50f6SAlberto Garcia (found, self.total_io_cmds)) 86bf3e50f6SAlberto Garcia 87bf3e50f6SAlberto Garcia # Run x-blockdev-reopen with 'opts' but applying 'newopts' 88bf3e50f6SAlberto Garcia # on top of it. The original 'opts' dict is unmodified 89bf3e50f6SAlberto Garcia def reopen(self, opts, newopts = {}, errmsg = None): 90bf3e50f6SAlberto Garcia opts = copy.deepcopy(opts) 91bf3e50f6SAlberto Garcia 92bf3e50f6SAlberto Garcia # Apply the changes from 'newopts' on top of 'opts' 93bf3e50f6SAlberto Garcia for key in newopts: 94bf3e50f6SAlberto Garcia value = newopts[key] 95bf3e50f6SAlberto Garcia # If key has the form "foo.bar" then we need to do 96bf3e50f6SAlberto Garcia # opts["foo"]["bar"] = value, not opts["foo.bar"] = value 97bf3e50f6SAlberto Garcia subdict = opts 98bf3e50f6SAlberto Garcia while key.find('.') != -1: 99bf3e50f6SAlberto Garcia [prefix, key] = key.split('.', 1) 100bf3e50f6SAlberto Garcia subdict = opts[prefix] 101bf3e50f6SAlberto Garcia subdict[key] = value 102bf3e50f6SAlberto Garcia 103bf3e50f6SAlberto Garcia result = self.vm.qmp('x-blockdev-reopen', conv_keys = False, **opts) 104bf3e50f6SAlberto Garcia if errmsg: 105bf3e50f6SAlberto Garcia self.assert_qmp(result, 'error/class', 'GenericError') 106bf3e50f6SAlberto Garcia self.assert_qmp(result, 'error/desc', errmsg) 107bf3e50f6SAlberto Garcia else: 108bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 109bf3e50f6SAlberto Garcia 110bf3e50f6SAlberto Garcia 111bf3e50f6SAlberto Garcia # Run query-named-block-nodes and return the specified entry 112bf3e50f6SAlberto Garcia def get_node(self, node_name): 113bf3e50f6SAlberto Garcia result = self.vm.qmp('query-named-block-nodes') 114bf3e50f6SAlberto Garcia for node in result['return']: 115bf3e50f6SAlberto Garcia if node['node-name'] == node_name: 116bf3e50f6SAlberto Garcia return node 117bf3e50f6SAlberto Garcia return None 118bf3e50f6SAlberto Garcia 119bf3e50f6SAlberto Garcia # Run 'query-named-block-nodes' and compare its output with the 120bf3e50f6SAlberto Garcia # value passed by the user in 'graph' 121bf3e50f6SAlberto Garcia def check_node_graph(self, graph): 122bf3e50f6SAlberto Garcia result = self.vm.qmp('query-named-block-nodes') 123bf3e50f6SAlberto Garcia self.assertEqual(json.dumps(graph, sort_keys=True), 124bf3e50f6SAlberto Garcia json.dumps(result, sort_keys=True)) 125bf3e50f6SAlberto Garcia 126bf3e50f6SAlberto Garcia # This test opens one single disk image (without backing files) 127bf3e50f6SAlberto Garcia # and tries to reopen it with illegal / incorrect parameters. 128bf3e50f6SAlberto Garcia def test_incorrect_parameters_single_file(self): 129bf3e50f6SAlberto Garcia # Open 'hd0' only (no backing files) 130bf3e50f6SAlberto Garcia opts = hd_opts(0) 131bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 132bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 133bf3e50f6SAlberto Garcia original_graph = self.vm.qmp('query-named-block-nodes') 134bf3e50f6SAlberto Garcia 135bf3e50f6SAlberto Garcia # We can reopen the image passing the same options 136bf3e50f6SAlberto Garcia self.reopen(opts) 137bf3e50f6SAlberto Garcia 138bf3e50f6SAlberto Garcia # We can also reopen passing a child reference in 'file' 139bf3e50f6SAlberto Garcia self.reopen(opts, {'file': 'hd0-file'}) 140bf3e50f6SAlberto Garcia 141bf3e50f6SAlberto Garcia # We cannot change any of these 142bf3e50f6SAlberto Garcia self.reopen(opts, {'node-name': 'not-found'}, "Cannot find node named 'not-found'") 143bf3e50f6SAlberto Garcia self.reopen(opts, {'node-name': ''}, "Cannot find node named ''") 144bf3e50f6SAlberto Garcia self.reopen(opts, {'node-name': None}, "Invalid parameter type for 'node-name', expected: string") 145bf3e50f6SAlberto Garcia self.reopen(opts, {'driver': 'raw'}, "Cannot change the option 'driver'") 146bf3e50f6SAlberto Garcia self.reopen(opts, {'driver': ''}, "Invalid parameter ''") 147bf3e50f6SAlberto Garcia self.reopen(opts, {'driver': None}, "Invalid parameter type for 'driver', expected: string") 148bf3e50f6SAlberto Garcia self.reopen(opts, {'file': 'not-found'}, "Cannot change the option 'file'") 149bf3e50f6SAlberto Garcia self.reopen(opts, {'file': ''}, "Cannot change the option 'file'") 150bf3e50f6SAlberto Garcia self.reopen(opts, {'file': None}, "Invalid parameter type for 'file', expected: BlockdevRef") 151bf3e50f6SAlberto Garcia self.reopen(opts, {'file.node-name': 'newname'}, "Cannot change the option 'node-name'") 152bf3e50f6SAlberto Garcia self.reopen(opts, {'file.driver': 'host_device'}, "Cannot change the option 'driver'") 153bf3e50f6SAlberto Garcia self.reopen(opts, {'file.filename': hd_path[1]}, "Cannot change the option 'filename'") 154bf3e50f6SAlberto Garcia self.reopen(opts, {'file.aio': 'native'}, "Cannot change the option 'aio'") 155bf3e50f6SAlberto Garcia self.reopen(opts, {'file.locking': 'off'}, "Cannot change the option 'locking'") 156bf3e50f6SAlberto Garcia self.reopen(opts, {'file.filename': None}, "Invalid parameter type for 'file.filename', expected: string") 157bf3e50f6SAlberto Garcia 158bf3e50f6SAlberto Garcia # node-name is optional in BlockdevOptions, but x-blockdev-reopen needs it 159bf3e50f6SAlberto Garcia del opts['node-name'] 160bf3e50f6SAlberto Garcia self.reopen(opts, {}, "Node name not specified") 161bf3e50f6SAlberto Garcia 162bf3e50f6SAlberto Garcia # Check that nothing has changed 163bf3e50f6SAlberto Garcia self.check_node_graph(original_graph) 164bf3e50f6SAlberto Garcia 165bf3e50f6SAlberto Garcia # Remove the node 166bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0') 167bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 168bf3e50f6SAlberto Garcia 169bf3e50f6SAlberto Garcia # This test opens an image with a backing file and tries to reopen 170bf3e50f6SAlberto Garcia # it with illegal / incorrect parameters. 171bf3e50f6SAlberto Garcia def test_incorrect_parameters_backing_file(self): 172bf3e50f6SAlberto Garcia # Open hd1 omitting the backing options (hd0 will be opened 173bf3e50f6SAlberto Garcia # with the default options) 174bf3e50f6SAlberto Garcia opts = hd_opts(1) 175bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 176bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 177bf3e50f6SAlberto Garcia original_graph = self.vm.qmp('query-named-block-nodes') 178bf3e50f6SAlberto Garcia 179bf3e50f6SAlberto Garcia # We can't reopen the image passing the same options, 'backing' is mandatory 180bf3e50f6SAlberto Garcia self.reopen(opts, {}, "backing is missing for 'hd1'") 181bf3e50f6SAlberto Garcia 182bf3e50f6SAlberto Garcia # Everything works if we pass 'backing' using the existing node name 183bf3e50f6SAlberto Garcia for node in original_graph['return']: 184bf3e50f6SAlberto Garcia if node['drv'] == iotests.imgfmt and node['file'] == hd_path[0]: 185bf3e50f6SAlberto Garcia backing_node_name = node['node-name'] 186bf3e50f6SAlberto Garcia self.reopen(opts, {'backing': backing_node_name}) 187bf3e50f6SAlberto Garcia 188bf3e50f6SAlberto Garcia # We can't use a non-existing or empty (non-NULL) node as the backing image 189bf3e50f6SAlberto Garcia self.reopen(opts, {'backing': 'not-found'}, "Cannot find device= nor node_name=not-found") 190bf3e50f6SAlberto Garcia self.reopen(opts, {'backing': ''}, "Cannot find device= nor node_name=") 191bf3e50f6SAlberto Garcia 192bf3e50f6SAlberto Garcia # We can reopen the image just fine if we specify the backing options 193bf3e50f6SAlberto Garcia opts['backing'] = {'driver': iotests.imgfmt, 194bf3e50f6SAlberto Garcia 'file': {'driver': 'file', 195bf3e50f6SAlberto Garcia 'filename': hd_path[0]}} 196bf3e50f6SAlberto Garcia self.reopen(opts) 197bf3e50f6SAlberto Garcia 198bf3e50f6SAlberto Garcia # We cannot change any of these options 199bf3e50f6SAlberto Garcia self.reopen(opts, {'backing.node-name': 'newname'}, "Cannot change the option 'node-name'") 200bf3e50f6SAlberto Garcia self.reopen(opts, {'backing.driver': 'raw'}, "Cannot change the option 'driver'") 201bf3e50f6SAlberto Garcia self.reopen(opts, {'backing.file.node-name': 'newname'}, "Cannot change the option 'node-name'") 202bf3e50f6SAlberto Garcia self.reopen(opts, {'backing.file.driver': 'host_device'}, "Cannot change the option 'driver'") 203bf3e50f6SAlberto Garcia 204bf3e50f6SAlberto Garcia # Check that nothing has changed since the beginning 205bf3e50f6SAlberto Garcia self.check_node_graph(original_graph) 206bf3e50f6SAlberto Garcia 207bf3e50f6SAlberto Garcia # Remove the node 208bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd1') 209bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 210bf3e50f6SAlberto Garcia 211bf3e50f6SAlberto Garcia # Reopen an image several times changing some of its options 212bf3e50f6SAlberto Garcia def test_reopen(self): 21323e1d054SMax Reitz # Check whether the filesystem supports O_DIRECT 21423e1d054SMax Reitz if 'O_DIRECT' in qemu_io('-f', 'raw', '-t', 'none', '-c', 'quit', hd_path[0]): 21523e1d054SMax Reitz supports_direct = False 21623e1d054SMax Reitz else: 21723e1d054SMax Reitz supports_direct = True 21823e1d054SMax Reitz 219bf3e50f6SAlberto Garcia # Open the hd1 image passing all backing options 220bf3e50f6SAlberto Garcia opts = hd_opts(1) 221bf3e50f6SAlberto Garcia opts['backing'] = hd_opts(0) 222bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 223bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 224bf3e50f6SAlberto Garcia original_graph = self.vm.qmp('query-named-block-nodes') 225bf3e50f6SAlberto Garcia 226bf3e50f6SAlberto Garcia # We can reopen the image passing the same options 227bf3e50f6SAlberto Garcia self.reopen(opts) 228bf3e50f6SAlberto Garcia 229bf3e50f6SAlberto Garcia # Reopen in read-only mode 230bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd1'), 'ro', False) 231bf3e50f6SAlberto Garcia 232bf3e50f6SAlberto Garcia self.reopen(opts, {'read-only': True}) 233bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd1'), 'ro', True) 234bf3e50f6SAlberto Garcia self.reopen(opts) 235bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd1'), 'ro', False) 236bf3e50f6SAlberto Garcia 237bf3e50f6SAlberto Garcia # Change the cache options 238bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd1'), 'cache/writeback', True) 239bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd1'), 'cache/direct', False) 240bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd1'), 'cache/no-flush', False) 24123e1d054SMax Reitz self.reopen(opts, {'cache': { 'direct': supports_direct, 'no-flush': True }}) 242bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd1'), 'cache/writeback', True) 24323e1d054SMax Reitz self.assert_qmp(self.get_node('hd1'), 'cache/direct', supports_direct) 244bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd1'), 'cache/no-flush', True) 245bf3e50f6SAlberto Garcia 246bf3e50f6SAlberto Garcia # Reopen again with the original options 247bf3e50f6SAlberto Garcia self.reopen(opts) 248bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd1'), 'cache/writeback', True) 249bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd1'), 'cache/direct', False) 250bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd1'), 'cache/no-flush', False) 251bf3e50f6SAlberto Garcia 252bf3e50f6SAlberto Garcia # Change 'detect-zeroes' and 'discard' 253bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd1'), 'detect_zeroes', 'off') 254bf3e50f6SAlberto Garcia self.reopen(opts, {'detect-zeroes': 'on'}) 255bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd1'), 'detect_zeroes', 'on') 256bf3e50f6SAlberto Garcia self.reopen(opts, {'detect-zeroes': 'unmap'}, 257bf3e50f6SAlberto Garcia "setting detect-zeroes to unmap is not allowed " + 258bf3e50f6SAlberto Garcia "without setting discard operation to unmap") 259bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd1'), 'detect_zeroes', 'on') 260bf3e50f6SAlberto Garcia self.reopen(opts, {'detect-zeroes': 'unmap', 'discard': 'unmap'}) 261bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd1'), 'detect_zeroes', 'unmap') 262bf3e50f6SAlberto Garcia self.reopen(opts) 263bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd1'), 'detect_zeroes', 'off') 264bf3e50f6SAlberto Garcia 265bf3e50f6SAlberto Garcia # Changing 'force-share' is currently not supported 266bf3e50f6SAlberto Garcia self.reopen(opts, {'force-share': True}, "Cannot change the option 'force-share'") 267bf3e50f6SAlberto Garcia 268bf3e50f6SAlberto Garcia # Change some qcow2-specific options 269bf3e50f6SAlberto Garcia # No way to test for success other than checking the return message 270bf3e50f6SAlberto Garcia if iotests.imgfmt == 'qcow2': 271bf3e50f6SAlberto Garcia self.reopen(opts, {'l2-cache-entry-size': 128 * 1024}, 272bf3e50f6SAlberto Garcia "L2 cache entry size must be a power of two "+ 273bf3e50f6SAlberto Garcia "between 512 and the cluster size (65536)") 274bf3e50f6SAlberto Garcia self.reopen(opts, {'l2-cache-size': 1024 * 1024, 275bf3e50f6SAlberto Garcia 'cache-size': 512 * 1024}, 276bf3e50f6SAlberto Garcia "l2-cache-size may not exceed cache-size") 277bf3e50f6SAlberto Garcia self.reopen(opts, {'l2-cache-size': 4 * 1024 * 1024, 278bf3e50f6SAlberto Garcia 'refcount-cache-size': 4 * 1024 * 1024, 279bf3e50f6SAlberto Garcia 'l2-cache-entry-size': 32 * 1024}) 280bf3e50f6SAlberto Garcia self.reopen(opts, {'pass-discard-request': True}) 281bf3e50f6SAlberto Garcia 282bf3e50f6SAlberto Garcia # Check that nothing has changed since the beginning 283bf3e50f6SAlberto Garcia # (from the parameters that we can check) 284bf3e50f6SAlberto Garcia self.check_node_graph(original_graph) 285bf3e50f6SAlberto Garcia 286bf3e50f6SAlberto Garcia # Check that the node names (other than the top-level one) are optional 287bf3e50f6SAlberto Garcia del opts['file']['node-name'] 288bf3e50f6SAlberto Garcia del opts['backing']['node-name'] 289bf3e50f6SAlberto Garcia del opts['backing']['file']['node-name'] 290bf3e50f6SAlberto Garcia self.reopen(opts) 291bf3e50f6SAlberto Garcia self.check_node_graph(original_graph) 292bf3e50f6SAlberto Garcia 293bf3e50f6SAlberto Garcia # Reopen setting backing = null, this removes the backing image from the chain 294bf3e50f6SAlberto Garcia self.reopen(opts, {'backing': None}) 295bf3e50f6SAlberto Garcia self.assert_qmp_absent(self.get_node('hd1'), 'image/backing-image') 296bf3e50f6SAlberto Garcia 297bf3e50f6SAlberto Garcia # Open the 'hd0' image 298bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **hd_opts(0)) 299bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 300bf3e50f6SAlberto Garcia 301bf3e50f6SAlberto Garcia # Reopen the hd1 image setting 'hd0' as its backing image 302bf3e50f6SAlberto Garcia self.reopen(opts, {'backing': 'hd0'}) 303bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd1'), 'image/backing-image/filename', hd_path[0]) 304bf3e50f6SAlberto Garcia 305bf3e50f6SAlberto Garcia # Check that nothing has changed since the beginning 306bf3e50f6SAlberto Garcia self.reopen(hd_opts(0), {'read-only': True}) 307bf3e50f6SAlberto Garcia self.check_node_graph(original_graph) 308bf3e50f6SAlberto Garcia 309bf3e50f6SAlberto Garcia # The backing file (hd0) is now a reference, we cannot change backing.* anymore 310bf3e50f6SAlberto Garcia self.reopen(opts, {}, "Cannot change the option 'backing.driver'") 311bf3e50f6SAlberto Garcia 312bf3e50f6SAlberto Garcia # We can't remove 'hd0' while it's a backing image of 'hd1' 313bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0') 314bf3e50f6SAlberto Garcia self.assert_qmp(result, 'error/class', 'GenericError') 315bf3e50f6SAlberto Garcia self.assert_qmp(result, 'error/desc', "Node 'hd0' is busy: node is used as backing hd of 'hd1'") 316bf3e50f6SAlberto Garcia 317bf3e50f6SAlberto Garcia # But we can remove both nodes if done in the proper order 318bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd1') 319bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 320bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0') 321bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 322bf3e50f6SAlberto Garcia 323bf3e50f6SAlberto Garcia # Reopen a raw image and see the effect of changing the 'offset' option 324bf3e50f6SAlberto Garcia def test_reopen_raw(self): 325bf3e50f6SAlberto Garcia opts = {'driver': 'raw', 'node-name': 'hd0', 326bf3e50f6SAlberto Garcia 'file': { 'driver': 'file', 327bf3e50f6SAlberto Garcia 'filename': hd_path[0], 328bf3e50f6SAlberto Garcia 'node-name': 'hd0-file' } } 329bf3e50f6SAlberto Garcia 330bf3e50f6SAlberto Garcia # First we create a 2MB raw file, and fill each half with a 331bf3e50f6SAlberto Garcia # different value 332bf3e50f6SAlberto Garcia qemu_img('create', '-f', 'raw', hd_path[0], '2M') 333bf3e50f6SAlberto Garcia qemu_io('-f', 'raw', '-c', 'write -P 0xa0 0 1M', hd_path[0]) 334bf3e50f6SAlberto Garcia qemu_io('-f', 'raw', '-c', 'write -P 0xa1 1M 1M', hd_path[0]) 335bf3e50f6SAlberto Garcia 336bf3e50f6SAlberto Garcia # Open the raw file with QEMU 337bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 338bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 339bf3e50f6SAlberto Garcia 340bf3e50f6SAlberto Garcia # Read 1MB from offset 0 341bf3e50f6SAlberto Garcia self.run_qemu_io("hd0", "read -P 0xa0 0 1M") 342bf3e50f6SAlberto Garcia 343bf3e50f6SAlberto Garcia # Reopen the image with a 1MB offset. 344bf3e50f6SAlberto Garcia # Now the results are different 345bf3e50f6SAlberto Garcia self.reopen(opts, {'offset': 1024*1024}) 346bf3e50f6SAlberto Garcia self.run_qemu_io("hd0", "read -P 0xa1 0 1M") 347bf3e50f6SAlberto Garcia 348bf3e50f6SAlberto Garcia # Reopen again with the original options. 349bf3e50f6SAlberto Garcia # We get the original results again 350bf3e50f6SAlberto Garcia self.reopen(opts) 351bf3e50f6SAlberto Garcia self.run_qemu_io("hd0", "read -P 0xa0 0 1M") 352bf3e50f6SAlberto Garcia 353bf3e50f6SAlberto Garcia # Remove the block device 354bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0') 355bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 356bf3e50f6SAlberto Garcia 357bf3e50f6SAlberto Garcia # Omitting an option should reset it to the default value, but if 358bf3e50f6SAlberto Garcia # an option cannot be changed it shouldn't be possible to reset it 359bf3e50f6SAlberto Garcia # to its default value either 360bf3e50f6SAlberto Garcia def test_reset_default_values(self): 361bf3e50f6SAlberto Garcia opts = {'driver': 'qcow2', 'node-name': 'hd0', 362bf3e50f6SAlberto Garcia 'file': { 'driver': 'file', 363bf3e50f6SAlberto Garcia 'filename': hd_path[0], 364bf3e50f6SAlberto Garcia 'x-check-cache-dropped': True, # This one can be changed 365bf3e50f6SAlberto Garcia 'locking': 'off', # This one can NOT be changed 366bf3e50f6SAlberto Garcia 'node-name': 'hd0-file' } } 367bf3e50f6SAlberto Garcia 368bf3e50f6SAlberto Garcia # Open the file with QEMU 369bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 370bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 371bf3e50f6SAlberto Garcia 372bf3e50f6SAlberto Garcia # file.x-check-cache-dropped can be changed... 373bf3e50f6SAlberto Garcia self.reopen(opts, { 'file.x-check-cache-dropped': False }) 374bf3e50f6SAlberto Garcia # ...and dropped completely (resetting to the default value) 375bf3e50f6SAlberto Garcia del opts['file']['x-check-cache-dropped'] 376bf3e50f6SAlberto Garcia self.reopen(opts) 377bf3e50f6SAlberto Garcia 378bf3e50f6SAlberto Garcia # file.locking cannot be changed nor reset to the default value 379bf3e50f6SAlberto Garcia self.reopen(opts, { 'file.locking': 'on' }, "Cannot change the option 'locking'") 380bf3e50f6SAlberto Garcia del opts['file']['locking'] 381bf3e50f6SAlberto Garcia self.reopen(opts, {}, "Option 'locking' cannot be reset to its default value") 382bf3e50f6SAlberto Garcia # But we can reopen it if we maintain its previous value 383bf3e50f6SAlberto Garcia self.reopen(opts, { 'file.locking': 'off' }) 384bf3e50f6SAlberto Garcia 385bf3e50f6SAlberto Garcia # Remove the block device 386bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0') 387bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 388bf3e50f6SAlberto Garcia 389bf3e50f6SAlberto Garcia # This test modifies the node graph a few times by changing the 390bf3e50f6SAlberto Garcia # 'backing' option on reopen and verifies that the guest data that 391bf3e50f6SAlberto Garcia # is read afterwards is consistent with the graph changes. 392bf3e50f6SAlberto Garcia def test_io_with_graph_changes(self): 393bf3e50f6SAlberto Garcia opts = [] 394bf3e50f6SAlberto Garcia 395bf3e50f6SAlberto Garcia # Open hd0, hd1 and hd2 without any backing image 396bf3e50f6SAlberto Garcia for i in range(3): 397bf3e50f6SAlberto Garcia opts.append(hd_opts(i)) 398bf3e50f6SAlberto Garcia opts[i]['backing'] = None 399bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts[i]) 400bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 401bf3e50f6SAlberto Garcia 402bf3e50f6SAlberto Garcia # hd0 403bf3e50f6SAlberto Garcia self.run_qemu_io("hd0", "read -P 0xa0 0 1M") 404bf3e50f6SAlberto Garcia self.run_qemu_io("hd0", "read -P 0 1M 1M") 405bf3e50f6SAlberto Garcia self.run_qemu_io("hd0", "read -P 0 2M 1M") 406bf3e50f6SAlberto Garcia 407bf3e50f6SAlberto Garcia # hd1 <- hd0 408bf3e50f6SAlberto Garcia self.reopen(opts[0], {'backing': 'hd1'}) 409bf3e50f6SAlberto Garcia 410bf3e50f6SAlberto Garcia self.run_qemu_io("hd0", "read -P 0xa0 0 1M") 411bf3e50f6SAlberto Garcia self.run_qemu_io("hd0", "read -P 0xa1 1M 1M") 412bf3e50f6SAlberto Garcia self.run_qemu_io("hd0", "read -P 0 2M 1M") 413bf3e50f6SAlberto Garcia 414bf3e50f6SAlberto Garcia # hd1 <- hd0 , hd1 <- hd2 415bf3e50f6SAlberto Garcia self.reopen(opts[2], {'backing': 'hd1'}) 416bf3e50f6SAlberto Garcia 417bf3e50f6SAlberto Garcia self.run_qemu_io("hd2", "read -P 0 0 1M") 418bf3e50f6SAlberto Garcia self.run_qemu_io("hd2", "read -P 0xa1 1M 1M") 419bf3e50f6SAlberto Garcia self.run_qemu_io("hd2", "read -P 0xa2 2M 1M") 420bf3e50f6SAlberto Garcia 421bf3e50f6SAlberto Garcia # hd1 <- hd2 <- hd0 422bf3e50f6SAlberto Garcia self.reopen(opts[0], {'backing': 'hd2'}) 423bf3e50f6SAlberto Garcia 424bf3e50f6SAlberto Garcia self.run_qemu_io("hd0", "read -P 0xa0 0 1M") 425bf3e50f6SAlberto Garcia self.run_qemu_io("hd0", "read -P 0xa1 1M 1M") 426bf3e50f6SAlberto Garcia self.run_qemu_io("hd0", "read -P 0xa2 2M 1M") 427bf3e50f6SAlberto Garcia 428bf3e50f6SAlberto Garcia # hd2 <- hd0 429bf3e50f6SAlberto Garcia self.reopen(opts[2], {'backing': None}) 430bf3e50f6SAlberto Garcia 431bf3e50f6SAlberto Garcia self.run_qemu_io("hd0", "read -P 0xa0 0 1M") 432bf3e50f6SAlberto Garcia self.run_qemu_io("hd0", "read -P 0 1M 1M") 433bf3e50f6SAlberto Garcia self.run_qemu_io("hd0", "read -P 0xa2 2M 1M") 434bf3e50f6SAlberto Garcia 435bf3e50f6SAlberto Garcia # hd2 <- hd1 <- hd0 436bf3e50f6SAlberto Garcia self.reopen(opts[1], {'backing': 'hd2'}) 437bf3e50f6SAlberto Garcia self.reopen(opts[0], {'backing': 'hd1'}) 438bf3e50f6SAlberto Garcia 439bf3e50f6SAlberto Garcia self.run_qemu_io("hd0", "read -P 0xa0 0 1M") 440bf3e50f6SAlberto Garcia self.run_qemu_io("hd0", "read -P 0xa1 1M 1M") 441bf3e50f6SAlberto Garcia self.run_qemu_io("hd0", "read -P 0xa2 2M 1M") 442bf3e50f6SAlberto Garcia 443bf3e50f6SAlberto Garcia # Illegal operation: hd2 is a child of hd1 444bf3e50f6SAlberto Garcia self.reopen(opts[2], {'backing': 'hd1'}, 445bf3e50f6SAlberto Garcia "Making 'hd1' a backing file of 'hd2' would create a cycle") 446bf3e50f6SAlberto Garcia 447bf3e50f6SAlberto Garcia # hd2 <- hd0, hd2 <- hd1 448bf3e50f6SAlberto Garcia self.reopen(opts[0], {'backing': 'hd2'}) 449bf3e50f6SAlberto Garcia 450bf3e50f6SAlberto Garcia self.run_qemu_io("hd1", "read -P 0 0 1M") 451bf3e50f6SAlberto Garcia self.run_qemu_io("hd1", "read -P 0xa1 1M 1M") 452bf3e50f6SAlberto Garcia self.run_qemu_io("hd1", "read -P 0xa2 2M 1M") 453bf3e50f6SAlberto Garcia 454bf3e50f6SAlberto Garcia # More illegal operations 455bf3e50f6SAlberto Garcia self.reopen(opts[2], {'backing': 'hd1'}, 456bf3e50f6SAlberto Garcia "Making 'hd1' a backing file of 'hd2' would create a cycle") 457bf3e50f6SAlberto Garcia self.reopen(opts[2], {'file': 'hd0-file'}, "Cannot change the option 'file'") 458bf3e50f6SAlberto Garcia 459bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd2') 460bf3e50f6SAlberto Garcia self.assert_qmp(result, 'error/class', 'GenericError') 461bf3e50f6SAlberto Garcia self.assert_qmp(result, 'error/desc', "Node 'hd2' is busy: node is used as backing hd of 'hd0'") 462bf3e50f6SAlberto Garcia 463bf3e50f6SAlberto Garcia # hd1 doesn't have a backing file now 464bf3e50f6SAlberto Garcia self.reopen(opts[1], {'backing': None}) 465bf3e50f6SAlberto Garcia 466bf3e50f6SAlberto Garcia self.run_qemu_io("hd1", "read -P 0 0 1M") 467bf3e50f6SAlberto Garcia self.run_qemu_io("hd1", "read -P 0xa1 1M 1M") 468bf3e50f6SAlberto Garcia self.run_qemu_io("hd1", "read -P 0 2M 1M") 469bf3e50f6SAlberto Garcia 470bf3e50f6SAlberto Garcia # We can't remove the 'backing' option if the image has a 471bf3e50f6SAlberto Garcia # default backing file 472bf3e50f6SAlberto Garcia del opts[1]['backing'] 473bf3e50f6SAlberto Garcia self.reopen(opts[1], {}, "backing is missing for 'hd1'") 474bf3e50f6SAlberto Garcia 475bf3e50f6SAlberto Garcia self.run_qemu_io("hd1", "read -P 0 0 1M") 476bf3e50f6SAlberto Garcia self.run_qemu_io("hd1", "read -P 0xa1 1M 1M") 477bf3e50f6SAlberto Garcia self.run_qemu_io("hd1", "read -P 0 2M 1M") 478bf3e50f6SAlberto Garcia 479bf3e50f6SAlberto Garcia # This test verifies that we can't change the children of a block 480bf3e50f6SAlberto Garcia # device during a reopen operation in a way that would create 481bf3e50f6SAlberto Garcia # cycles in the node graph 4829442bebeSThomas Huth @iotests.skip_if_unsupported(['blkverify']) 483bf3e50f6SAlberto Garcia def test_graph_cycles(self): 484bf3e50f6SAlberto Garcia opts = [] 485bf3e50f6SAlberto Garcia 486bf3e50f6SAlberto Garcia # Open all three images without backing file 487bf3e50f6SAlberto Garcia for i in range(3): 488bf3e50f6SAlberto Garcia opts.append(hd_opts(i)) 489bf3e50f6SAlberto Garcia opts[i]['backing'] = None 490bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts[i]) 491bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 492bf3e50f6SAlberto Garcia 493bf3e50f6SAlberto Garcia # hd1 <- hd0, hd1 <- hd2 494bf3e50f6SAlberto Garcia self.reopen(opts[0], {'backing': 'hd1'}) 495bf3e50f6SAlberto Garcia self.reopen(opts[2], {'backing': 'hd1'}) 496bf3e50f6SAlberto Garcia 497bf3e50f6SAlberto Garcia # Illegal: hd2 is backed by hd1 498bf3e50f6SAlberto Garcia self.reopen(opts[1], {'backing': 'hd2'}, 499bf3e50f6SAlberto Garcia "Making 'hd2' a backing file of 'hd1' would create a cycle") 500bf3e50f6SAlberto Garcia 501bf3e50f6SAlberto Garcia # hd1 <- hd0 <- hd2 502bf3e50f6SAlberto Garcia self.reopen(opts[2], {'backing': 'hd0'}) 503bf3e50f6SAlberto Garcia 504bf3e50f6SAlberto Garcia # Illegal: hd2 is backed by hd0, which is backed by hd1 505bf3e50f6SAlberto Garcia self.reopen(opts[1], {'backing': 'hd2'}, 506bf3e50f6SAlberto Garcia "Making 'hd2' a backing file of 'hd1' would create a cycle") 507bf3e50f6SAlberto Garcia 508bf3e50f6SAlberto Garcia # Illegal: hd1 cannot point to itself 509bf3e50f6SAlberto Garcia self.reopen(opts[1], {'backing': 'hd1'}, 510bf3e50f6SAlberto Garcia "Making 'hd1' a backing file of 'hd1' would create a cycle") 511bf3e50f6SAlberto Garcia 512bf3e50f6SAlberto Garcia # Remove all backing files 513bf3e50f6SAlberto Garcia self.reopen(opts[0]) 514bf3e50f6SAlberto Garcia self.reopen(opts[2]) 515bf3e50f6SAlberto Garcia 516bf3e50f6SAlberto Garcia ########################################## 517bf3e50f6SAlberto Garcia # Add a blkverify node using hd0 and hd1 # 518bf3e50f6SAlberto Garcia ########################################## 519bf3e50f6SAlberto Garcia bvopts = {'driver': 'blkverify', 520bf3e50f6SAlberto Garcia 'node-name': 'bv', 521bf3e50f6SAlberto Garcia 'test': 'hd0', 522bf3e50f6SAlberto Garcia 'raw': 'hd1'} 523bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **bvopts) 524bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 525bf3e50f6SAlberto Garcia 526bf3e50f6SAlberto Garcia # blkverify doesn't currently allow reopening. TODO: implement this 527bf3e50f6SAlberto Garcia self.reopen(bvopts, {}, "Block format 'blkverify' used by node 'bv'" + 528bf3e50f6SAlberto Garcia " does not support reopening files") 529bf3e50f6SAlberto Garcia 530bf3e50f6SAlberto Garcia # Illegal: hd0 is a child of the blkverify node 531bf3e50f6SAlberto Garcia self.reopen(opts[0], {'backing': 'bv'}, 532bf3e50f6SAlberto Garcia "Making 'bv' a backing file of 'hd0' would create a cycle") 533bf3e50f6SAlberto Garcia 534bf3e50f6SAlberto Garcia # Delete the blkverify node 535bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'bv') 536bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 537bf3e50f6SAlberto Garcia 538bf3e50f6SAlberto Garcia # Misc reopen tests with different block drivers 5399442bebeSThomas Huth @iotests.skip_if_unsupported(['quorum', 'throttle']) 540bf3e50f6SAlberto Garcia def test_misc_drivers(self): 541bf3e50f6SAlberto Garcia #################### 542bf3e50f6SAlberto Garcia ###### quorum ###### 543bf3e50f6SAlberto Garcia #################### 544bf3e50f6SAlberto Garcia for i in range(3): 545bf3e50f6SAlberto Garcia opts = hd_opts(i) 546bf3e50f6SAlberto Garcia # Open all three images without backing file 547bf3e50f6SAlberto Garcia opts['backing'] = None 548bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 549bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 550bf3e50f6SAlberto Garcia 551bf3e50f6SAlberto Garcia opts = {'driver': 'quorum', 552bf3e50f6SAlberto Garcia 'node-name': 'quorum0', 553bf3e50f6SAlberto Garcia 'children': ['hd0', 'hd1', 'hd2'], 554bf3e50f6SAlberto Garcia 'vote-threshold': 2} 555bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 556bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 557bf3e50f6SAlberto Garcia 558bf3e50f6SAlberto Garcia # Quorum doesn't currently allow reopening. TODO: implement this 559bf3e50f6SAlberto Garcia self.reopen(opts, {}, "Block format 'quorum' used by node 'quorum0'" + 560bf3e50f6SAlberto Garcia " does not support reopening files") 561bf3e50f6SAlberto Garcia 562bf3e50f6SAlberto Garcia # You can't make quorum0 a backing file of hd0: 563bf3e50f6SAlberto Garcia # hd0 is already a child of quorum0. 564bf3e50f6SAlberto Garcia self.reopen(hd_opts(0), {'backing': 'quorum0'}, 565bf3e50f6SAlberto Garcia "Making 'quorum0' a backing file of 'hd0' would create a cycle") 566bf3e50f6SAlberto Garcia 567bf3e50f6SAlberto Garcia # Delete quorum0 568bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'quorum0') 569bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 570bf3e50f6SAlberto Garcia 571bf3e50f6SAlberto Garcia # Delete hd0, hd1 and hd2 572bf3e50f6SAlberto Garcia for i in range(3): 573bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, 574bf3e50f6SAlberto Garcia node_name = 'hd%d' % i) 575bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 576bf3e50f6SAlberto Garcia 577bf3e50f6SAlberto Garcia ###################### 578bf3e50f6SAlberto Garcia ###### blkdebug ###### 579bf3e50f6SAlberto Garcia ###################### 580bf3e50f6SAlberto Garcia opts = {'driver': 'blkdebug', 581bf3e50f6SAlberto Garcia 'node-name': 'bd', 582bf3e50f6SAlberto Garcia 'config': '/dev/null', 583bf3e50f6SAlberto Garcia 'image': hd_opts(0)} 584bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 585bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 586bf3e50f6SAlberto Garcia 587bf3e50f6SAlberto Garcia # blkdebug allows reopening if we keep the same options 588bf3e50f6SAlberto Garcia self.reopen(opts) 589bf3e50f6SAlberto Garcia 590bf3e50f6SAlberto Garcia # but it currently does not allow changes 591bf3e50f6SAlberto Garcia self.reopen(opts, {'image': 'hd1'}, "Cannot change the option 'image'") 592bf3e50f6SAlberto Garcia self.reopen(opts, {'align': 33554432}, "Cannot change the option 'align'") 593bf3e50f6SAlberto Garcia self.reopen(opts, {'config': '/non/existent'}, "Cannot change the option 'config'") 594bf3e50f6SAlberto Garcia del opts['config'] 595bf3e50f6SAlberto Garcia self.reopen(opts, {}, "Option 'config' cannot be reset to its default value") 596bf3e50f6SAlberto Garcia 597bf3e50f6SAlberto Garcia # Delete the blkdebug node 598bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'bd') 599bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 600bf3e50f6SAlberto Garcia 601bf3e50f6SAlberto Garcia ################## 602bf3e50f6SAlberto Garcia ###### null ###### 603bf3e50f6SAlberto Garcia ################## 604a6f8f9f8SMax Reitz opts = {'driver': 'null-co', 'node-name': 'root', 'size': 1024} 605bf3e50f6SAlberto Garcia 606bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 607bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 608bf3e50f6SAlberto Garcia 609bf3e50f6SAlberto Garcia # 1 << 30 is the default value, but we cannot change it explicitly 610bf3e50f6SAlberto Garcia self.reopen(opts, {'size': (1 << 30)}, "Cannot change the option 'size'") 611bf3e50f6SAlberto Garcia 612bf3e50f6SAlberto Garcia # We cannot change 'size' back to its default value either 613bf3e50f6SAlberto Garcia del opts['size'] 614bf3e50f6SAlberto Garcia self.reopen(opts, {}, "Option 'size' cannot be reset to its default value") 615bf3e50f6SAlberto Garcia 616bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'root') 617bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 618bf3e50f6SAlberto Garcia 619bf3e50f6SAlberto Garcia ################## 620bf3e50f6SAlberto Garcia ###### file ###### 621bf3e50f6SAlberto Garcia ################## 622bf3e50f6SAlberto Garcia opts = hd_opts(0) 623bf3e50f6SAlberto Garcia opts['file']['locking'] = 'on' 624bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 625bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 626bf3e50f6SAlberto Garcia 627bf3e50f6SAlberto Garcia # 'locking' cannot be changed 628bf3e50f6SAlberto Garcia del opts['file']['locking'] 629bf3e50f6SAlberto Garcia self.reopen(opts, {'file.locking': 'on'}) 630bf3e50f6SAlberto Garcia self.reopen(opts, {'file.locking': 'off'}, "Cannot change the option 'locking'") 631bf3e50f6SAlberto Garcia self.reopen(opts, {}, "Option 'locking' cannot be reset to its default value") 632bf3e50f6SAlberto Garcia 633bf3e50f6SAlberto Garcia # Trying to reopen the 'file' node directly does not make a difference 634bf3e50f6SAlberto Garcia opts = opts['file'] 635bf3e50f6SAlberto Garcia self.reopen(opts, {'locking': 'on'}) 636bf3e50f6SAlberto Garcia self.reopen(opts, {'locking': 'off'}, "Cannot change the option 'locking'") 637bf3e50f6SAlberto Garcia self.reopen(opts, {}, "Option 'locking' cannot be reset to its default value") 638bf3e50f6SAlberto Garcia 639bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0') 640bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 641bf3e50f6SAlberto Garcia 642bf3e50f6SAlberto Garcia ###################### 643bf3e50f6SAlberto Garcia ###### throttle ###### 644bf3e50f6SAlberto Garcia ###################### 645bf3e50f6SAlberto Garcia opts = { 'qom-type': 'throttle-group', 'id': 'group0', 646bf3e50f6SAlberto Garcia 'props': { 'limits': { 'iops-total': 1000 } } } 647bf3e50f6SAlberto Garcia result = self.vm.qmp('object-add', conv_keys = False, **opts) 648bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 649bf3e50f6SAlberto Garcia 650bf3e50f6SAlberto Garcia opts = { 'qom-type': 'throttle-group', 'id': 'group1', 651bf3e50f6SAlberto Garcia 'props': { 'limits': { 'iops-total': 2000 } } } 652bf3e50f6SAlberto Garcia result = self.vm.qmp('object-add', conv_keys = False, **opts) 653bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 654bf3e50f6SAlberto Garcia 655bf3e50f6SAlberto Garcia # Add a throttle filter with group = group0 656bf3e50f6SAlberto Garcia opts = { 'driver': 'throttle', 'node-name': 'throttle0', 657bf3e50f6SAlberto Garcia 'throttle-group': 'group0', 'file': hd_opts(0) } 658bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 659bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 660bf3e50f6SAlberto Garcia 661bf3e50f6SAlberto Garcia # We can reopen it if we keep the same options 662bf3e50f6SAlberto Garcia self.reopen(opts) 663bf3e50f6SAlberto Garcia 664bf3e50f6SAlberto Garcia # We can also reopen if 'file' is a reference to the child 665bf3e50f6SAlberto Garcia self.reopen(opts, {'file': 'hd0'}) 666bf3e50f6SAlberto Garcia 667bf3e50f6SAlberto Garcia # This is illegal 668bf3e50f6SAlberto Garcia self.reopen(opts, {'throttle-group': 'notfound'}, "Throttle group 'notfound' does not exist") 669bf3e50f6SAlberto Garcia 670bf3e50f6SAlberto Garcia # But it's possible to change the group to group1 671bf3e50f6SAlberto Garcia self.reopen(opts, {'throttle-group': 'group1'}) 672bf3e50f6SAlberto Garcia 673bf3e50f6SAlberto Garcia # Now group1 is in use, it cannot be deleted 674bf3e50f6SAlberto Garcia result = self.vm.qmp('object-del', id = 'group1') 675bf3e50f6SAlberto Garcia self.assert_qmp(result, 'error/class', 'GenericError') 676bf3e50f6SAlberto Garcia self.assert_qmp(result, 'error/desc', "object 'group1' is in use, can not be deleted") 677bf3e50f6SAlberto Garcia 678bf3e50f6SAlberto Garcia # Default options, this switches the group back to group0 679bf3e50f6SAlberto Garcia self.reopen(opts) 680bf3e50f6SAlberto Garcia 681bf3e50f6SAlberto Garcia # So now we cannot delete group0 682bf3e50f6SAlberto Garcia result = self.vm.qmp('object-del', id = 'group0') 683bf3e50f6SAlberto Garcia self.assert_qmp(result, 'error/class', 'GenericError') 684bf3e50f6SAlberto Garcia self.assert_qmp(result, 'error/desc', "object 'group0' is in use, can not be deleted") 685bf3e50f6SAlberto Garcia 686bf3e50f6SAlberto Garcia # But group1 is free this time, and it can be deleted 687bf3e50f6SAlberto Garcia result = self.vm.qmp('object-del', id = 'group1') 688bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 689bf3e50f6SAlberto Garcia 690bf3e50f6SAlberto Garcia # Let's delete the filter node 691bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'throttle0') 692bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 693bf3e50f6SAlberto Garcia 694bf3e50f6SAlberto Garcia # And we can finally get rid of group0 695bf3e50f6SAlberto Garcia result = self.vm.qmp('object-del', id = 'group0') 696bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 697bf3e50f6SAlberto Garcia 698bf3e50f6SAlberto Garcia # If an image has a backing file then the 'backing' option must be 699bf3e50f6SAlberto Garcia # passed on reopen. We don't allow leaving the option out in this 700bf3e50f6SAlberto Garcia # case because it's unclear what the correct semantics would be. 701bf3e50f6SAlberto Garcia def test_missing_backing_options_1(self): 702bf3e50f6SAlberto Garcia # hd2 703bf3e50f6SAlberto Garcia opts = hd_opts(2) 704bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 705bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 706bf3e50f6SAlberto Garcia 707bf3e50f6SAlberto Garcia # hd0 708bf3e50f6SAlberto Garcia opts = hd_opts(0) 709bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 710bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 711bf3e50f6SAlberto Garcia 712bf3e50f6SAlberto Garcia # hd0 has no backing file: we can omit the 'backing' option 713bf3e50f6SAlberto Garcia self.reopen(opts) 714bf3e50f6SAlberto Garcia 715bf3e50f6SAlberto Garcia # hd2 <- hd0 716bf3e50f6SAlberto Garcia self.reopen(opts, {'backing': 'hd2'}) 717bf3e50f6SAlberto Garcia 718bf3e50f6SAlberto Garcia # hd0 has a backing file: we must set the 'backing' option 719bf3e50f6SAlberto Garcia self.reopen(opts, {}, "backing is missing for 'hd0'") 720bf3e50f6SAlberto Garcia 721bf3e50f6SAlberto Garcia # hd2 can't be removed because it's the backing file of hd0 722bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd2') 723bf3e50f6SAlberto Garcia self.assert_qmp(result, 'error/class', 'GenericError') 724bf3e50f6SAlberto Garcia self.assert_qmp(result, 'error/desc', "Node 'hd2' is busy: node is used as backing hd of 'hd0'") 725bf3e50f6SAlberto Garcia 726bf3e50f6SAlberto Garcia # Detach hd2 from hd0. 727bf3e50f6SAlberto Garcia self.reopen(opts, {'backing': None}) 728bf3e50f6SAlberto Garcia self.reopen(opts, {}, "backing is missing for 'hd0'") 729bf3e50f6SAlberto Garcia 730bf3e50f6SAlberto Garcia # Remove both hd0 and hd2 731bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0') 732bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 733bf3e50f6SAlberto Garcia 734bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd2') 735bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 736bf3e50f6SAlberto Garcia 737bf3e50f6SAlberto Garcia # If an image has default backing file (as part of its metadata) 738bf3e50f6SAlberto Garcia # then the 'backing' option must be passed on reopen. We don't 739bf3e50f6SAlberto Garcia # allow leaving the option out in this case because it's unclear 740bf3e50f6SAlberto Garcia # what the correct semantics would be. 741bf3e50f6SAlberto Garcia def test_missing_backing_options_2(self): 742bf3e50f6SAlberto Garcia # hd0 <- hd1 743bf3e50f6SAlberto Garcia # (hd0 is hd1's default backing file) 744bf3e50f6SAlberto Garcia opts = hd_opts(1) 745bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 746bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 747bf3e50f6SAlberto Garcia 748bf3e50f6SAlberto Garcia # hd1 has a backing file: we can't omit the 'backing' option 749bf3e50f6SAlberto Garcia self.reopen(opts, {}, "backing is missing for 'hd1'") 750bf3e50f6SAlberto Garcia 751bf3e50f6SAlberto Garcia # Let's detach the backing file 752bf3e50f6SAlberto Garcia self.reopen(opts, {'backing': None}) 753bf3e50f6SAlberto Garcia 754bf3e50f6SAlberto Garcia # No backing file attached to hd1 now, but we still can't omit the 'backing' option 755bf3e50f6SAlberto Garcia self.reopen(opts, {}, "backing is missing for 'hd1'") 756bf3e50f6SAlberto Garcia 757bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd1') 758bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 759bf3e50f6SAlberto Garcia 760bf3e50f6SAlberto Garcia # Test that making 'backing' a reference to an existing child 761bf3e50f6SAlberto Garcia # keeps its current options 762bf3e50f6SAlberto Garcia def test_backing_reference(self): 763bf3e50f6SAlberto Garcia # hd2 <- hd1 <- hd0 764bf3e50f6SAlberto Garcia opts = hd_opts(0) 765bf3e50f6SAlberto Garcia opts['backing'] = hd_opts(1) 766bf3e50f6SAlberto Garcia opts['backing']['backing'] = hd_opts(2) 767bf3e50f6SAlberto Garcia # Enable 'detect-zeroes' on all three nodes 768bf3e50f6SAlberto Garcia opts['detect-zeroes'] = 'on' 769bf3e50f6SAlberto Garcia opts['backing']['detect-zeroes'] = 'on' 770bf3e50f6SAlberto Garcia opts['backing']['backing']['detect-zeroes'] = 'on' 771bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 772bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 773bf3e50f6SAlberto Garcia 774bf3e50f6SAlberto Garcia # Reopen the chain passing the minimum amount of required options. 775bf3e50f6SAlberto Garcia # By making 'backing' a reference to hd1 (instead of a sub-dict) 776bf3e50f6SAlberto Garcia # we tell QEMU to keep its current set of options. 777bf3e50f6SAlberto Garcia opts = {'driver': iotests.imgfmt, 778bf3e50f6SAlberto Garcia 'node-name': 'hd0', 779bf3e50f6SAlberto Garcia 'file': 'hd0-file', 780bf3e50f6SAlberto Garcia 'backing': 'hd1' } 781bf3e50f6SAlberto Garcia self.reopen(opts) 782bf3e50f6SAlberto Garcia 783bf3e50f6SAlberto Garcia # This has reset 'detect-zeroes' on hd0, but not on hd1 and hd2. 784bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd0'), 'detect_zeroes', 'off') 785bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd1'), 'detect_zeroes', 'on') 786bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd2'), 'detect_zeroes', 'on') 787bf3e50f6SAlberto Garcia 788bf3e50f6SAlberto Garcia # Test what happens if the graph changes due to other operations 789bf3e50f6SAlberto Garcia # such as block-stream 790bf3e50f6SAlberto Garcia def test_block_stream_1(self): 791bf3e50f6SAlberto Garcia # hd1 <- hd0 792bf3e50f6SAlberto Garcia opts = hd_opts(0) 793bf3e50f6SAlberto Garcia opts['backing'] = hd_opts(1) 794bf3e50f6SAlberto Garcia opts['backing']['backing'] = None 795bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 796bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 797bf3e50f6SAlberto Garcia 798bf3e50f6SAlberto Garcia # Stream hd1 into hd0 and wait until it's done 799bf3e50f6SAlberto Garcia result = self.vm.qmp('block-stream', conv_keys = True, job_id = 'stream0', device = 'hd0') 800bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 801bf3e50f6SAlberto Garcia self.wait_until_completed(drive = 'stream0') 802bf3e50f6SAlberto Garcia 803bf3e50f6SAlberto Garcia # Now we have only hd0 804bf3e50f6SAlberto Garcia self.assertEqual(self.get_node('hd1'), None) 805bf3e50f6SAlberto Garcia 806bf3e50f6SAlberto Garcia # We have backing.* options but there's no backing file anymore 807bf3e50f6SAlberto Garcia self.reopen(opts, {}, "Cannot change the option 'backing.driver'") 808bf3e50f6SAlberto Garcia 809bf3e50f6SAlberto Garcia # If we remove the 'backing' option then we can reopen hd0 just fine 810bf3e50f6SAlberto Garcia del opts['backing'] 811bf3e50f6SAlberto Garcia self.reopen(opts) 812bf3e50f6SAlberto Garcia 813bf3e50f6SAlberto Garcia # We can also reopen hd0 if we set 'backing' to null 814bf3e50f6SAlberto Garcia self.reopen(opts, {'backing': None}) 815bf3e50f6SAlberto Garcia 816bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0') 817bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 818bf3e50f6SAlberto Garcia 819bf3e50f6SAlberto Garcia # Another block_stream test 820bf3e50f6SAlberto Garcia def test_block_stream_2(self): 821bf3e50f6SAlberto Garcia # hd2 <- hd1 <- hd0 822bf3e50f6SAlberto Garcia opts = hd_opts(0) 823bf3e50f6SAlberto Garcia opts['backing'] = hd_opts(1) 824bf3e50f6SAlberto Garcia opts['backing']['backing'] = hd_opts(2) 825bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 826bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 827bf3e50f6SAlberto Garcia 828bf3e50f6SAlberto Garcia # Stream hd1 into hd0 and wait until it's done 829bf3e50f6SAlberto Garcia result = self.vm.qmp('block-stream', conv_keys = True, job_id = 'stream0', 830bf3e50f6SAlberto Garcia device = 'hd0', base_node = 'hd2') 831bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 832bf3e50f6SAlberto Garcia self.wait_until_completed(drive = 'stream0') 833bf3e50f6SAlberto Garcia 834bf3e50f6SAlberto Garcia # The chain is hd2 <- hd0 now. hd1 is missing 835bf3e50f6SAlberto Garcia self.assertEqual(self.get_node('hd1'), None) 836bf3e50f6SAlberto Garcia 837bf3e50f6SAlberto Garcia # The backing options in the dict were meant for hd1, but we cannot 838bf3e50f6SAlberto Garcia # use them with hd2 because hd1 had a backing file while hd2 does not. 839bf3e50f6SAlberto Garcia self.reopen(opts, {}, "Cannot change the option 'backing.driver'") 840bf3e50f6SAlberto Garcia 841bf3e50f6SAlberto Garcia # If we remove hd1's options from the dict then things work fine 842bf3e50f6SAlberto Garcia opts['backing'] = opts['backing']['backing'] 843bf3e50f6SAlberto Garcia self.reopen(opts) 844bf3e50f6SAlberto Garcia 845bf3e50f6SAlberto Garcia # We can also reopen hd0 if we use a reference to the backing file 846bf3e50f6SAlberto Garcia self.reopen(opts, {'backing': 'hd2'}) 847bf3e50f6SAlberto Garcia 848bf3e50f6SAlberto Garcia # But we cannot leave the option out 849bf3e50f6SAlberto Garcia del opts['backing'] 850bf3e50f6SAlberto Garcia self.reopen(opts, {}, "backing is missing for 'hd0'") 851bf3e50f6SAlberto Garcia 852bf3e50f6SAlberto Garcia # Now we can delete hd0 (and hd2) 853bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0') 854bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 855bf3e50f6SAlberto Garcia self.assertEqual(self.get_node('hd2'), None) 856bf3e50f6SAlberto Garcia 857bf3e50f6SAlberto Garcia # Reopen the chain during a block-stream job (from hd1 to hd0) 858bf3e50f6SAlberto Garcia def test_block_stream_3(self): 859bf3e50f6SAlberto Garcia # hd2 <- hd1 <- hd0 860bf3e50f6SAlberto Garcia opts = hd_opts(0) 861bf3e50f6SAlberto Garcia opts['backing'] = hd_opts(1) 862bf3e50f6SAlberto Garcia opts['backing']['backing'] = hd_opts(2) 863bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 864bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 865bf3e50f6SAlberto Garcia 866bf3e50f6SAlberto Garcia # hd2 <- hd0 867bf3e50f6SAlberto Garcia result = self.vm.qmp('block-stream', conv_keys = True, job_id = 'stream0', 868c423a6afSMax Reitz device = 'hd0', base_node = 'hd2', 869c423a6afSMax Reitz auto_finalize = False) 870bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 871bf3e50f6SAlberto Garcia 872c624b015SAndrey Shinkevich # We can remove hd2 while the stream job is ongoing 873bf3e50f6SAlberto Garcia opts['backing']['backing'] = None 874c624b015SAndrey Shinkevich self.reopen(opts, {}) 875bf3e50f6SAlberto Garcia 876bf3e50f6SAlberto Garcia # We can't remove hd1 while the stream job is ongoing 877bf3e50f6SAlberto Garcia opts['backing'] = None 878bf3e50f6SAlberto Garcia self.reopen(opts, {}, "Cannot change 'backing' link from 'hd0' to 'hd1'") 879bf3e50f6SAlberto Garcia 880c423a6afSMax Reitz self.vm.run_job('stream0', auto_finalize = False, auto_dismiss = True) 881bf3e50f6SAlberto Garcia 882bf3e50f6SAlberto Garcia # Reopen the chain during a block-stream job (from hd2 to hd1) 883bf3e50f6SAlberto Garcia def test_block_stream_4(self): 884bf3e50f6SAlberto Garcia # hd2 <- hd1 <- hd0 885bf3e50f6SAlberto Garcia opts = hd_opts(0) 886bf3e50f6SAlberto Garcia opts['backing'] = hd_opts(1) 887bf3e50f6SAlberto Garcia opts['backing']['backing'] = hd_opts(2) 888bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 889bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 890bf3e50f6SAlberto Garcia 891bf3e50f6SAlberto Garcia # hd1 <- hd0 892bf3e50f6SAlberto Garcia result = self.vm.qmp('block-stream', conv_keys = True, job_id = 'stream0', 893c423a6afSMax Reitz device = 'hd1', auto_finalize = False) 894bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 895bf3e50f6SAlberto Garcia 896bf3e50f6SAlberto Garcia # We can't reopen with the original options because that would 897bf3e50f6SAlberto Garcia # make hd1 read-only and block-stream requires it to be read-write 898c423a6afSMax Reitz # (Which error message appears depends on whether the stream job is 899c423a6afSMax Reitz # already done with copying at this point.) 900c423a6afSMax Reitz self.reopen(opts, {}, 901c423a6afSMax Reitz ["Can't set node 'hd1' to r/o with copy-on-read enabled", 902c423a6afSMax Reitz "Cannot make block node read-only, there is a writer on it"]) 903bf3e50f6SAlberto Garcia 904bf3e50f6SAlberto Garcia # We can't remove hd2 while the stream job is ongoing 905bf3e50f6SAlberto Garcia opts['backing']['backing'] = None 906bf3e50f6SAlberto Garcia self.reopen(opts, {'backing.read-only': False}, "Cannot change 'backing' link from 'hd1' to 'hd2'") 907bf3e50f6SAlberto Garcia 908bf3e50f6SAlberto Garcia # We can detach hd1 from hd0 because it doesn't affect the stream job 909bf3e50f6SAlberto Garcia opts['backing'] = None 910bf3e50f6SAlberto Garcia self.reopen(opts) 911bf3e50f6SAlberto Garcia 912c423a6afSMax Reitz self.vm.run_job('stream0', auto_finalize = False, auto_dismiss = True) 913bf3e50f6SAlberto Garcia 914bf3e50f6SAlberto Garcia # Reopen the chain during a block-commit job (from hd0 to hd2) 915bf3e50f6SAlberto Garcia def test_block_commit_1(self): 916bf3e50f6SAlberto Garcia # hd2 <- hd1 <- hd0 917bf3e50f6SAlberto Garcia opts = hd_opts(0) 918bf3e50f6SAlberto Garcia opts['backing'] = hd_opts(1) 919bf3e50f6SAlberto Garcia opts['backing']['backing'] = hd_opts(2) 920bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 921bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 922bf3e50f6SAlberto Garcia 923bf3e50f6SAlberto Garcia result = self.vm.qmp('block-commit', conv_keys = True, job_id = 'commit0', 924c423a6afSMax Reitz device = 'hd0') 925bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 926bf3e50f6SAlberto Garcia 927bf3e50f6SAlberto Garcia # We can't remove hd2 while the commit job is ongoing 928bf3e50f6SAlberto Garcia opts['backing']['backing'] = None 929bf3e50f6SAlberto Garcia self.reopen(opts, {}, "Cannot change 'backing' link from 'hd1' to 'hd2'") 930bf3e50f6SAlberto Garcia 931bf3e50f6SAlberto Garcia # We can't remove hd1 while the commit job is ongoing 932bf3e50f6SAlberto Garcia opts['backing'] = None 933bf3e50f6SAlberto Garcia self.reopen(opts, {}, "Cannot change 'backing' link from 'hd0' to 'hd1'") 934bf3e50f6SAlberto Garcia 935bf3e50f6SAlberto Garcia event = self.vm.event_wait(name='BLOCK_JOB_READY') 936bf3e50f6SAlberto Garcia self.assert_qmp(event, 'data/device', 'commit0') 937bf3e50f6SAlberto Garcia self.assert_qmp(event, 'data/type', 'commit') 938bf3e50f6SAlberto Garcia self.assert_qmp_absent(event, 'data/error') 939bf3e50f6SAlberto Garcia 940bf3e50f6SAlberto Garcia result = self.vm.qmp('block-job-complete', device='commit0') 941bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 942bf3e50f6SAlberto Garcia 943bf3e50f6SAlberto Garcia self.wait_until_completed(drive = 'commit0') 944bf3e50f6SAlberto Garcia 945bf3e50f6SAlberto Garcia # Reopen the chain during a block-commit job (from hd1 to hd2) 946bf3e50f6SAlberto Garcia def test_block_commit_2(self): 947bf3e50f6SAlberto Garcia # hd2 <- hd1 <- hd0 948bf3e50f6SAlberto Garcia opts = hd_opts(0) 949bf3e50f6SAlberto Garcia opts['backing'] = hd_opts(1) 950bf3e50f6SAlberto Garcia opts['backing']['backing'] = hd_opts(2) 951bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 952bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 953bf3e50f6SAlberto Garcia 954bf3e50f6SAlberto Garcia result = self.vm.qmp('block-commit', conv_keys = True, job_id = 'commit0', 955c423a6afSMax Reitz device = 'hd0', top_node = 'hd1', 956c423a6afSMax Reitz auto_finalize = False) 957bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 958bf3e50f6SAlberto Garcia 959bf3e50f6SAlberto Garcia # We can't remove hd2 while the commit job is ongoing 960bf3e50f6SAlberto Garcia opts['backing']['backing'] = None 961bf3e50f6SAlberto Garcia self.reopen(opts, {}, "Cannot change the option 'backing.driver'") 962bf3e50f6SAlberto Garcia 963bf3e50f6SAlberto Garcia # We can't remove hd1 while the commit job is ongoing 964bf3e50f6SAlberto Garcia opts['backing'] = None 965bf3e50f6SAlberto Garcia self.reopen(opts, {}, "Cannot change backing link if 'hd0' has an implicit backing file") 966bf3e50f6SAlberto Garcia 967bf3e50f6SAlberto Garcia # hd2 <- hd0 968c423a6afSMax Reitz self.vm.run_job('commit0', auto_finalize = False, auto_dismiss = True) 969bf3e50f6SAlberto Garcia 970bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd0'), 'ro', False) 971bf3e50f6SAlberto Garcia self.assertEqual(self.get_node('hd1'), None) 972bf3e50f6SAlberto Garcia self.assert_qmp(self.get_node('hd2'), 'ro', True) 973bf3e50f6SAlberto Garcia 97497518e11SKevin Wolf def run_test_iothreads(self, iothread_a, iothread_b, errmsg = None): 975bf3e50f6SAlberto Garcia opts = hd_opts(0) 976bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) 977bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 978bf3e50f6SAlberto Garcia 979bf3e50f6SAlberto Garcia opts2 = hd_opts(2) 980bf3e50f6SAlberto Garcia result = self.vm.qmp('blockdev-add', conv_keys = False, **opts2) 981bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 982bf3e50f6SAlberto Garcia 983bf3e50f6SAlberto Garcia result = self.vm.qmp('object-add', qom_type='iothread', id='iothread0') 984bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 985bf3e50f6SAlberto Garcia 986bf3e50f6SAlberto Garcia result = self.vm.qmp('object-add', qom_type='iothread', id='iothread1') 987bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 988bf3e50f6SAlberto Garcia 98997518e11SKevin Wolf result = self.vm.qmp('device_add', driver='virtio-scsi', id='scsi0', 99097518e11SKevin Wolf iothread=iothread_a) 991bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 992bf3e50f6SAlberto Garcia 99397518e11SKevin Wolf result = self.vm.qmp('device_add', driver='virtio-scsi', id='scsi1', 99497518e11SKevin Wolf iothread=iothread_b) 995bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 996bf3e50f6SAlberto Garcia 99797518e11SKevin Wolf if iothread_a: 99897518e11SKevin Wolf result = self.vm.qmp('device_add', driver='scsi-hd', drive='hd0', 99997518e11SKevin Wolf share_rw=True, bus="scsi0.0") 1000bf3e50f6SAlberto Garcia self.assert_qmp(result, 'return', {}) 1001bf3e50f6SAlberto Garcia 100297518e11SKevin Wolf if iothread_b: 100397518e11SKevin Wolf result = self.vm.qmp('device_add', driver='scsi-hd', drive='hd2', 100497518e11SKevin Wolf share_rw=True, bus="scsi1.0") 100597518e11SKevin Wolf self.assert_qmp(result, 'return', {}) 100697518e11SKevin Wolf 100797518e11SKevin Wolf # Attaching the backing file may or may not work 100897518e11SKevin Wolf self.reopen(opts, {'backing': 'hd2'}, errmsg) 100997518e11SKevin Wolf 101097518e11SKevin Wolf # But removing the backing file should always work 101197518e11SKevin Wolf self.reopen(opts, {'backing': None}) 101297518e11SKevin Wolf 101397518e11SKevin Wolf self.vm.shutdown() 101497518e11SKevin Wolf 101597518e11SKevin Wolf # We don't allow setting a backing file that uses a different AioContext if 101697518e11SKevin Wolf # neither of them can switch to the other AioContext 101797518e11SKevin Wolf def test_iothreads_error(self): 101897518e11SKevin Wolf self.run_test_iothreads('iothread0', 'iothread1', 10191de6b45fSKevin Wolf "Cannot change iothread of active block backend") 102097518e11SKevin Wolf 102197518e11SKevin Wolf def test_iothreads_compatible_users(self): 102297518e11SKevin Wolf self.run_test_iothreads('iothread0', 'iothread0') 102397518e11SKevin Wolf 102497518e11SKevin Wolf def test_iothreads_switch_backing(self): 10251de6b45fSKevin Wolf self.run_test_iothreads('iothread0', None) 102697518e11SKevin Wolf 102797518e11SKevin Wolf def test_iothreads_switch_overlay(self): 10281de6b45fSKevin Wolf self.run_test_iothreads(None, 'iothread0') 1029bf3e50f6SAlberto Garcia 1030bf3e50f6SAlberto Garciaif __name__ == '__main__': 103152ea799eSJohn Snow iotests.activate_logging() 1032103cbc77SMax Reitz iotests.main(supported_fmts=["qcow2"], 1033103cbc77SMax Reitz supported_protocols=["file"]) 1034