1c25e0a5fSrscproc.c: 2c25e0a5fSrsc as a consequence of the implementation of proc_kill, 3c25e0a5fSrsc any loop calling sleep should check for p->killed 4c25e0a5fSrsc and be able to break out with an error return. 5*42494902Srsc it is better if you check *before* sleep. 6c25e0a5fSrsc 7c25e0a5fSrsc can swap procdump up after proc_kill 8c25e0a5fSrsc and then have proc_exit and proc_wait on same sheet 9c25e0a5fSrsc 10f8ac6396Skaashoek sched -> switch2scheduler? or just switch? 11f8ac6396Skaashoek 127356f26aSkaashoek factor out switching and scheduling code from process code 137356f26aSkaashoek 14c25e0a5fSrsctrap.c 15c25e0a5fSrsc if spin locks are ever held without cli, 16c25e0a5fSrsc trap should call yield() only if nlock == 0 17c25e0a5fSrsc 187356f26aSkaashoekide.c: synchronous disk write -> polling disk write. search for 197356f26aSkaashoek (a)synchronous; xv6 doesn't have asynchronous writes. 207356f26aSkaashoek 217356f26aSkaashoekfs.c: split all name operations off in name.c? (starting with namei but move 227356f26aSkaashoek wdir keep in fs.c) 23*42494902Srsc 24*42494902Srscpipe.c: 25*42494902Srsc more comments? 26*42494902Srsc comment how functions get called? 27*42494902Srsc 28*42494902Srscsysfile.c: 29*42494902Srsc is the sys_exec picture upside down? 30*42494902Srsc can sys_open and sys_exec be simplified any? 31*42494902Srsc 32*42494902Srscgeneral: 33*42494902Srsc sizeof parens? 34*42494902Srsc 35