1index: 2 SEG_NULL, SEG_ASM not in the index 3 4mmu.h: 5 funny \ alignment in mmu.h 6 7main.c: 8 should use static int bcpu to avoid having live 9 stack variable across the asm volatile that 10 changes %esp and %ebp. 11 12 cpus[0] -> cpus[bcpu] 13 14proc.c: 15 as a consequence of the implementation of proc_kill, 16 any loop calling sleep should check for p->killed 17 and be able to break out with an error return. 18 19 can swap procdump up after proc_kill 20 and then have proc_exit and proc_wait on same sheet 21 22 sched -> switch2scheduler? or just switch? 23 24 factor out switching and scheduling code from process code 25 26trap.c 27 if spin locks are ever held without cli, 28 trap should call yield() only if nlock == 0 29 30main.c, proc.c, trap.c: 31 use a constant for 3 (USER). 32 33ide.c: synchronous disk write -> polling disk write. search for 34 (a)synchronous; xv6 doesn't have asynchronous writes. 35 36fs.c: split all name operations off in name.c? (starting with namei but move 37 wdir keep in fs.c) 38 39 unlink . and .. should be disallowed 40 41ls.c: apply tim's patch 42 43