1index: 2 SEG_NULL, SEG_ASM not in the index 3 4mmu.h: 5 funny \ alignment in mmu.h 6 7main.c: 8 should use static int bcpu to avoid having live 9 stack variable across the asm volatile that 10 changes %esp and %ebp. 11 12 cpus[0] -> cpus[bcpu] 13 14proc.c: 15 comment at top of scheduler() should say 16 via longjmp back to the scheduler 17 not 18 via longjmp back to the top of scheduler 19 20 sched should panic if state == RUNNING. 21 22 forkret comment should say "Return" not "return" 23 24 as a consequence of the implementation of proc_kill, 25 any loop calling sleep should check for p->killed 26 and be able to break out with an error return. 27 28 can swap procdump up after proc_kill 29 and then have proc_exit and proc_wait on same sheet 30 31 proc_exit should wake up proc[1] if any 32 reparenting was done. 33 34 sched -> switch2scheduler? or just switch? 35 36 factor out switching and scheduling code from process code 37 38trap.c 39 if spin locks are ever held without cli, 40 trap should call yield() only if nlock == 0 41 42main.c, proc.c, trap.c: 43 use a constant for 3 (USER). 44 45ide.c: synchronous disk write -> polling disk write. search for 46 (a)synchronous; xv6 doesn't have asynchronous writes. 47 48fs.c: split all name operations off in name.c? (starting with namei but move 49 wdir keep in fs.c) 50 51 unlink . and .. should be disallowed 52 53ls.c: apply tim's patch 54 55