1proc.c: 2 as a consequence of the implementation of proc_kill, 3 any loop calling sleep should check for p->killed 4 and be able to break out with an error return. 5 it is better if you check *before* sleep. 6 7 can swap procdump up after proc_kill 8 and then have proc_exit and proc_wait on same sheet 9 10 sched -> switch2scheduler? or just switch? 11 12 factor out switching and scheduling code from process code 13 14trap.c 15 if spin locks are ever held without cli, 16 trap should call yield() only if nlock == 0 17 18ide.c: synchronous disk write -> polling disk write. search for 19 (a)synchronous; xv6 doesn't have asynchronous writes. 20 21fs.c: split all name operations off in name.c? (starting with namei but move 22 wdir keep in fs.c) 23 24pipe.c: 25 more comments? 26 comment how functions get called? 27 28sysfile.c: 29 is the sys_exec picture upside down? 30 can sys_open and sys_exec be simplified any? 31 32general: 33 sizeof parens? 34 35