1missing bootmain.c from printout 2funny \ alignment in mmu.h 3 4main.c: 5 should use static int bcpu to avoid having live 6 stack variable across the asm volatile that 7 changes %esp and %ebp. 8 9init.c: 10 should while(wait() >= 0); 11 not just wait(); 12 13proc.c: 14 comment at top of scheduler() should say 15 via longjmp back to the scheduler 16 not 17 via longjmp back to the top of scheduler 18 19 sched should panic if state == RUNNING. 20 21 forkret comment should say "Return" not "return" 22 23 as a consequence of the implementation of proc_kill, 24 any loop calling sleep should check for p->killed 25 and be able to break out with an error return. 26 27 can swap procdump up after proc_kill 28 and then have proc_exit and proc_wait on same sheet 29 30 proc_exit should wake up proc[1] if any 31 reparenting was done. 32 33trap.c 34 if spin locks are ever held without cli, 35 trap should call yield() only if nlock == 0 36 37