1runoff.list: 2 bootmain.c missing 3 4mmu.h: 5 funny \ alignment in mmu.h 6 7main.c: 8 should use static int bcpu to avoid having live 9 stack variable across the asm volatile that 10 changes %esp and %ebp. 11 12 cpus[0] -> cpus[bcpu] 13 14init.c: 15 should while(wait() >= 0); 16 not just wait(); 17 18proc.c: 19 comment at top of scheduler() should say 20 via longjmp back to the scheduler 21 not 22 via longjmp back to the top of scheduler 23 24 sched should panic if state == RUNNING. 25 26 forkret comment should say "Return" not "return" 27 28 as a consequence of the implementation of proc_kill, 29 any loop calling sleep should check for p->killed 30 and be able to break out with an error return. 31 32 can swap procdump up after proc_kill 33 and then have proc_exit and proc_wait on same sheet 34 35 proc_exit should wake up proc[1] if any 36 reparenting was done. 37 38 sched -> switch2scheduler? or just switch? 39 40trap.c 41 if spin locks are ever held without cli, 42 trap should call yield() only if nlock == 0 43 44main.c, proc.c, trap.c: 45 use a constant for 3 (USER). 46 47