kernel - quiet repeated DA/CD probes for removable devices

* Don't print errors when repeated probes for cards in sdcard
readers fail, beyond the first instance.

* Fixes console spam when usb car

kernel - quiet repeated DA/CD probes for removable devices

* Don't print errors when repeated probes for cards in sdcard
readers fail, beyond the first instance.

* Fixes console spam when usb card readers are plugged in.

show more ...

kernel - Change callout in struct ccb_hdr

* Change the callout declaration in struct ccb_hdr from an embedded
structure to a pointer, add padding to get the whole structure to its
original size

kernel - Change callout in struct ccb_hdr

* Change the callout declaration in struct ccb_hdr from an embedded
structure to a pointer, add padding to get the whole structure to its
original size (prior to the recent callout patch).

* This removes an improper ABI dependency on the kernel struct callout
structure which was causing 'camcontrol', and 'smartctl' (from
smartmontools) to fail.

Testing: dillon, tuxillo

show more ...

kernel: Remove numerous #include <sys/thread2.h>.

Most of them were added when we converted spl*() calls to
crit_enter()/crit_exit(), almost 14 years ago. We can now
remove a good chunk of them agai

kernel: Remove numerous #include <sys/thread2.h>.

Most of them were added when we converted spl*() calls to
crit_enter()/crit_exit(), almost 14 years ago. We can now
remove a good chunk of them again for where crit_*() are
no longer used.

I had to adjust some files that were relying on thread2.h
or headers that it includes coming in via other headers
that it was removed from.

show more ...

kernel - Fix CAM peripheral error handling

* cam_periph.c was bcopy()ing the *ENTIRE* saved ccb back to the
original when working through certain error results. This completely
destroys linked

kernel - Fix CAM peripheral error handling

* cam_periph.c was bcopy()ing the *ENTIRE* saved ccb back to the
original when working through certain error results. This completely
destroys linked list entry fields.

* Refactor by hacking a restore_ccb() function which does not copy
over the link list entry fields or the callout structure.

* Fixes panics with CDs, particularly audio CDs, and can also fix
other panics.

Panics are related to situations where an AHCI error or errors occur
while multiple CCBs are queued.

* Also always initialize the state tracking field for various scsi
periphals to ensure that stale data does not result in improper
processing in scsi/*.c's *done() functions.

Reported-by: htse

show more ...

kernel - Fix CAM unit allocation race

* Fix an issue where multiple targets can sometimes allocate the
same unit when probed asynchronously. The search and insertion
functions were being indepe

kernel - Fix CAM unit allocation race

* Fix an issue where multiple targets can sometimes allocate the
same unit when probed asynchronously. The search and insertion
functions were being independently locked.

show more ...

kernel - Remove B_MALLOC

* Remove B_MALLOC buffer support. All primary buffer cache buffer
operations should now use pages. B_VMIO is required for all
vnode-centric operations like allocbuf(),

kernel - Remove B_MALLOC

* Remove B_MALLOC buffer support. All primary buffer cache buffer
operations should now use pages. B_VMIO is required for all
vnode-centric operations like allocbuf(), but does not have to be set
for nominal I/O.

* Remove vm_hold_load_pages() and vm_hold_free_pages(). This code was
used to support mapping ad-hoc data buffers into buf structures, but
the only remaining use case in the CAM periph code can just use
getpbuf_mem() instead. So this code is no longer used.

show more ...

kernel - Add missing bus lock to CAM

* cam_periph_alloc() was missing a bus lock / unlock sequence around
a list operation.

kernel: Fix the type of 'cmd' in various ioctl functions (int -> u_long).

These were all found by clang's -Wswitch option.

kernel - Remove direct mapping of user buffers to CAM

* Remove direct mappings, always bounce. Nothing uses this code any
more and vmapbuf/vunmapbuf are about to go away, so just bounce.

cam: Disable verbose "Unretryable error" log for probe pseudo device.

Discussed-with: swildner@

kernel: Sync resource_string_value() with FreeBSD

Kernel - Completely remove DFLTPHYS

* There is no need to have two different macros define the maximum
allowed IO size for low-level operations; replace DFLTPHYS by
MAXPHYS in the entire kernel.

Kernel - Completely remove DFLTPHYS

* There is no need to have two different macros define the maximum
allowed IO size for low-level operations; replace DFLTPHYS by
MAXPHYS in the entire kernel.

* Old drivers typically used DFLTPHYS without a second thought,
assuming it would always be the same value; they may have hard
limitations and break if bigger I/O sizes are suddenly used.
Be sure to explicitely limit their maximum allowed I/O size to
64KB and keep them working.

show more ...

Initial import of binutils 2.22 on the new vendor branch

Future versions of binutils will also reside on this branch rather
than continuing to create new binutils branches for each new version.

CAM - Fix missing SIM lock in cam_periph_release()

* When releasing the last reference on a CAM peripheral which has been
marked invalid, the peripheral is then freed. Freeing the peripheral
re

CAM - Fix missing SIM lock in cam_periph_release()

* When releasing the last reference on a CAM peripheral which has been
marked invalid, the peripheral is then freed. Freeing the peripheral
requires the SIM lock.

Go through necessary tribulations to acquire the SIM lock. The lock order
is important (SIM lock first, XPT lock second), and the SIM lock may or
may not already be held by the thread.

* The bug could cause a crash after burning a CD as the CD becomes invalid
after the burn completes in order to reload its state.

show more ...

CAM - Auto unit number start based on device

If no SCSI devices are wired CAM now automatically starts any umass sim
attachments at unit #8 instead of unit #0. This reduces interference
between usb

CAM - Auto unit number start based on device

If no SCSI devices are wired CAM now automatically starts any umass sim
attachments at unit #8 instead of unit #0. This reduces interference
between usb mass storage attachments and ahci/sili attachments. Otherwise
the usb mass storage can steal "da0" away from ahci/sili.

show more ...

Add code similar to what was done in physio to use a bounce buffer
if user data supplied to the CAM pass-throug device is not 16-byte aligned.
The user data was previously unconditionally vmapbuf()'d

Add code similar to what was done in physio to use a bounce buffer
if user data supplied to the CAM pass-throug device is not 16-byte aligned.
The user data was previously unconditionally vmapbuf()'d and the unaligned
pointer passed through to the device layer, causing NATA to barf badly on
SATA devices.

This fixes numerous dvd burning issues on SATA-based DVD burners.

Reported-by: Hasso Tepper <hasso@estpak.ee>

show more ...

Fix multiple bugs in CAM related devices which go away unexpectedly. This
fixes numerous panics when pulling a USB mass media device in the midst of
heavy I/O.

* The SIM lock was being unlocked via

Fix multiple bugs in CAM related devices which go away unexpectedly. This
fixes numerous panics when pulling a USB mass media device in the midst of
heavy I/O.

* The SIM lock was being unlocked via the periph->sim path after periph
was unheld. periph can become free and blow up the unlock, so get
the sim into a local variable first, then release periph.

* The code which waits for CCB completion needs to be a while loop, not
an if. It worked anyway, but wasn't very robust.

* Add CAM_SIM_DEREGISTERED to flag when a sim is undergoing deregistration.

* Beef up cam_dead_sim so it works more like a real sim.

* Properly install &cam_dead_sim in the device and periph structures
related to a SCSI bus, when deregistering the bus.

* Disallow the addition of new devices when deregistering a bus.

* NULL out periph->softc when freeing it.

show more ...

Sync CAM with FreeBSD using lockmgr locks instead of mutexes.
Note: This is mostly a code sync with FreeBSD which improves stability
in addition to the items listed below. This provides a framework

Sync CAM with FreeBSD using lockmgr locks instead of mutexes.
Note: This is mostly a code sync with FreeBSD which improves stability
in addition to the items listed below. This provides a framework for
releasing the mplock, but for now it's still there.

Add an xpt_print function to reduce most of the xpt_print_path/printf
pairs. Convert the core code to use it.

Initial cut at Basic Domain Validation.

Make cam_xpt's pronouncements match camcontrol (Tagged -> Command) Queueing.

Pay attention to return value from xpt_bus_register in xpt_init.

Add an xpt_rescan function and a thread that will field rescan requests.
The purpose of this is to allow a SIM (or other entities) to request a bus
rescan and have it then fielded in a different (process) context from the
caller.

Check the return value from cam_periph_acquire.

Drop the periph/sim lock when calling disk_destroy().

Drop the topology lock before calling the periph oninvalidate and dtor
vectors.

For the XPT_SASYNC_CB operation, only decouple the broadcast to the bus
and device lists instead of decoupling the whole operation. This avoids
problems with SIMs going away.

Split the camisr into per-SIM done queues. This optimizes the locking a
little bit and allows for direct dispatch of the doneq from certain
contexts that would otherwise face recursive locking problems.

Zero the CCBs when mallocing them.

Only schedule the xpt_finishconfig_task once.

Eliminate the use of M_TEMP.

Add a helper function for registering async callbacks.

Release the bus reference that is acquired when doing a CAMIOCOMMAND ioctl.

Zero scsi_readcapacity allocations so we can really tell if there has
been data returned.

Remove duplicate includes and fix typos.

Add a bunch of definitions and structures to support newer drivers.

When probing a newly found device, don't automatically assume that the
device supports retrieving a serial number. Instead, first query the
list of VPD pages it does support, and only query the serial number if
it's supported, else silently move on. This eliminates a lot of noise
during verbose booting, and will likely eliminate the need for most
NOSERIAL quirks.

Reduce diffs from FreeBSD.

Obtained-from: FreeBSD

show more ...

Put a bit of hysteresis into both BUSY SCSI status returns
and CAM_RESRC_UNAVAIL returns. Delay a tunable amount for
either between retries.

This came up because the MPT IOC was returning "IOC out o

Put a bit of hysteresis into both BUSY SCSI status returns
and CAM_RESRC_UNAVAIL returns. Delay a tunable amount for
either between retries.

This came up because the MPT IOC was returning "IOC out of
resources" for some FreeBSD users and this caused a CAM_RESRC_UNAVAIL
return. Putting a bit of delay between retries helped them
out.

Obtained-from: FreeBSD

show more ...

There should be no need to retry when the CCB status code is
CAM_LUN_INVALID or CAM_TID_INVALID.

This avoids crashes in camisr() when umass devices are
unplugged during probing.

Obtained-from: Free

There should be no need to retry when the CCB status code is
CAM_LUN_INVALID or CAM_TID_INVALID.

This avoids crashes in camisr() when umass devices are
unplugged during probing.

Obtained-from: FreeBSD

show more ...

Fine-grained malloc statistics - replace some M_DEVBUF with module-specific
types.

Obtained-from: FreeBSD

Fix typo in comment.

Obtained-from: FreeBSD

Don't be so chatty when performing manual sense.

Obtained-from: FreeBSD

In camperiphdone(), make sure we check for fatal errors and bail out
instead of retrying them blindly.

Obtained-from: FreeBSD

(camperiphdone): When the cam_periph layer performs sense recovery,
completion of recovery is indicated by positioning the CAM_AUTOSNS_VALID
bit in the status field of the CCB, not in the flags fie

(camperiphdone): When the cam_periph layer performs sense recovery,
completion of recovery is indicated by positioning the CAM_AUTOSNS_VALID
bit in the status field of the CCB, not in the flags field.
This fixes an endless loop of sense recovery actions.

Obtained-from: FreeBSD

show more ...