tests/unix_passfd: add a comment for send_a_lot

Explain why SOCK_DGRAM and SOCK_STREAM differ in this edge case. While
here improve output in case of a failure.

tests/unix_passfd: test that control mixed with data creates records

If socket has data interleaved with control it would never allow to read
two pieces of data, neither two pieces of control with o

tests/unix_passfd: test that control mixed with data creates records

If socket has data interleaved with control it would never allow to read
two pieces of data, neither two pieces of control with one recvmsg(2). In
other words, presence of control makes a SOCK_STREAM socket behave like
SOCK_SEQPACKET, where control marks the records. This is not a documented
or specified behavior, but this is how it worked always for BSD sockets.
If you look closer at it, this actually makes a lot of sense, as if it
were the opposite both the kernel code and an application code would
become way more complex.

The change made recvfd_payload() to return received length and requires
caller to do ATF_REQUIRE() itself. This required a small change to
existing test rights_creds_payload. It also refactors a bit f28532a0f363,
pushing two identical calls out of TEST_PROTO ifdef.

Reviwed by: markj
Differential Revision: https://reviews.freebsd.org/D43724

show more ...

tests/unix_passfd: fix typos - assignment instead of comparison

This typos were actually hiding a kernel bug, see 541e6a989cae.

Reviewed by: markj
Differential Revision: https://reviews.freebsd.or

tests/unix_passfd: fix typos - assignment instead of comparison

This typos were actually hiding a kernel bug, see 541e6a989cae.

Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D43734

show more ...

tests: Automated cleanup of cdefs and other formatting

Apply the following automated changes to try to eliminate
no-longer-needed sys/cdefs.h includes as well as now-empty
blank lines in a row.

Rem

tests: Automated cleanup of cdefs and other formatting

Apply the following automated changes to try to eliminate
no-longer-needed sys/cdefs.h includes as well as now-empty
blank lines in a row.

Remove /^#if.*\n#endif.*\n#include\s+<sys/cdefs.h>.*\n/
Remove /\n+#include\s+<sys/cdefs.h>.*\n+#if.*\n#endif.*\n+/
Remove /\n+#if.*\n#endif.*\n+/
Remove /^#if.*\n#endif.*\n/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/types.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/param.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/capsicum.h>/

Sponsored by: Netflix

show more ...

unix tests: Use the right type for sendmsg(2) return values

MFC after: 1 week

Remove $FreeBSD$: one-line .c pattern

Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/

unix/dgram tests: match the kernel behavior

In CURRENT for some time an overflowed unix/dgram socket would
return EAGAIN if it has O_NONBLOCK set. This proved to be
undesired. See 71e70c25c00 for

unix/dgram tests: match the kernel behavior

In CURRENT for some time an overflowed unix/dgram socket would
return EAGAIN if it has O_NONBLOCK set. This proved to be
undesired. See 71e70c25c00 for details. Update tests to match
the "new" behavior, which actually is the historical behavior.

show more ...

tests/unix_passfd: add test case against 636420bde36

tests/unix_passfd: factor out sysctl(3) read into separate function

tests: fix unix_passfd_dgram:rights_creds_payload after be1f485d7d6b

The test was failing due to the assert on lack of MSG_TRUNC flag in the
output flags of recvmsg().
The code passed MSG_TRUNC, al

tests: fix unix_passfd_dgram:rights_creds_payload after be1f485d7d6b

The test was failing due to the assert on lack of MSG_TRUNC flag in the
output flags of recvmsg().
The code passed MSG_TRUNC, along with sufficient-size buffer to hold the
message to-be-received to the recvmsg(), and expected MSG_TRUNC to be
returned as well.

This is not exactly correct as a) MSG_TRUNC was not even a supported
recvmsg() flag before be1f485d7d6b and b) it violates POSIX, as
POSIX states it should be set only "If a message is too long to fit in
the supplied buffers,".
The test was working before as the kernel copied input flags to the
output flags. be1f485d7d6b changed that behaviour to clear MSG_TRUNC
if it was present on the input.

Fix the test by checking POSIX-defined behaviour.

Discussed with: glebius

show more ...

unix: change error code for recvmsg() failed due to RLIMIT_NOFILE

Instead of returning EMSGSIZE pass the error code from fdallocn() directly
to userland. That would be EMFILE, which makes much more

unix: change error code for recvmsg() failed due to RLIMIT_NOFILE

Instead of returning EMSGSIZE pass the error code from fdallocn() directly
to userland. That would be EMFILE, which makes much more sense. This
error code is not listed in the specification[1], but the specification
doesn't cover such edge case at all. Meanwhile the specification lists
EMSGSIZE as the error code for invalid value of msg_iovlen, and FreeBSD
follows that, see sys_recmsg(). Differentiating these two cases will make
a developer/admin life much easier when debugging.

[1] https://pubs.opengroup.org/onlinepubs/9699919799/functions/recvmsg.html

Reviewed by: markj
Differential revision: https://reviews.freebsd.org/D35640

show more ...

tests/unix_passfd: compile SOCK_STREAM and SOCK_DGRAM versions

Most test pass identically on different kinds of sockets. However,
few edge cases work differently on stream and datagram sockets. We
w

tests/unix_passfd: compile SOCK_STREAM and SOCK_DGRAM versions

Most test pass identically on different kinds of sockets. However,
few edge cases work differently on stream and datagram sockets. We
want to exercise this and document.

Differential revision: https://reviews.freebsd.org/D35420

show more ...

unix/*: rewrite unp_internalize() cmsg parsing cycle

Make it a complex, but a single for(;;) statement. The previous cycle
with some loop logic in the beginning and some loop logic at the end
was c

unix/*: rewrite unp_internalize() cmsg parsing cycle

Make it a complex, but a single for(;;) statement. The previous cycle
with some loop logic in the beginning and some loop logic at the end
was confusing. Both me and markj@ were misleaded to a conclusion that
some checks are unnecessary, while they actually were necessary.

While here, handle an edge case found by Mark, when on 64-bit platform
an incorrect message from userland would underflow length counter, but
return without any error. Provide a test case for such message.

Reviewed by: markj
Differential revision: https://reviews.freebsd.org/D35375

show more ...

tests: Fix i386 and powerpc build

Fix:

tests/sys/kern/unix_passfd_test.c:414:24: error: comparison of integers
of different signs: 'int' and 'unsigned int' [-Werror,-Wsign-compare]
ATF_REQU

tests: Fix i386 and powerpc build

Fix:

tests/sys/kern/unix_passfd_test.c:414:24: error: comparison of integers
of different signs: 'int' and 'unsigned int' [-Werror,-Wsign-compare]
ATF_REQUIRE(getnfds() == nfds + MAXFDS);
~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
powerpc.powerpc/tmp/usr/include/atf-c/macros.h:144:15: note: expanded
from macro 'ATF_REQUIRE'
if (!(expression)) \
^~~~~~~~~~
1 error generated.
--- unix_passfd_test.o ---

show more ...

tests/unix_passfd: sending many and too many SCM_RIGHTS

o Exercise bounds checking when sending large set of file descriptors,
that can't fit into single control mbuf.
o Exercise resource limits c

tests/unix_passfd: sending many and too many SCM_RIGHTS

o Exercise bounds checking when sending large set of file descriptors,
that can't fit into single control mbuf.
o Exercise resource limits checks when receiving a large sets.
o Check that socket isn't left in a completely stuck state when we can't
receive SCM_RIGHTS due to limits. Current SOCK_STREAM socket would
free the control, but leave the data in. This seems to be a legit
behavior for a stream socket, as we don't want holes in the data.

PR: 239250
Reviewed by: markj
Differential revision: https://reviews.freebsd.org/D35315

show more ...

tests/unix_passfd: add test for shutdown(2) on a buffer with an fd

This has two goals:
- Exercize call to unp_dispose() via soshutdown() instead of sofree()
- Make sure that shutdown indeed derefere

tests/unix_passfd: add test for shutdown(2) on a buffer with an fd

This has two goals:
- Exercize call to unp_dispose() via soshutdown() instead of sofree()
- Make sure that shutdown indeed dereferences the fd stored

Reviewed by: markj
Differential revision: https://reviews.freebsd.org/D35122

show more ...

Unbreak MSG_CMSG_CLOEXEC

MSG_CMSG_CLOEXEC has not been working since 2015 (SVN r284380) because
_finstall expects O_CLOEXEC and not UF_EXCLOSE as the flags argument.
This was probably not noticed be

Unbreak MSG_CMSG_CLOEXEC

MSG_CMSG_CLOEXEC has not been working since 2015 (SVN r284380) because
_finstall expects O_CLOEXEC and not UF_EXCLOSE as the flags argument.
This was probably not noticed because we don't have a test for this flag
so this commit adds one. I found this problem because one of the
libwayland tests was failing.

Fixes: ea31808c3b07 ("fd: move out actual fp installation to _finstall")
MFC after: 3 days
Reviewed By: mjg, kib
Differential Revision: https://reviews.freebsd.org/D29328

show more ...

Fix a bug in r353332 that snuck in with a last-minute adjustment.

Reported by: Jenkins
MFC with: r353332
Sponsored by: The FreeBSD Foundation

Add a regression test for r353331.

MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Revert r337929

FreeBSD's mkstemp sets the temporary file's permissions to 600, and has ever
since mkstemp was added in 1987. Coverity's warning is still relevant for
portable programs since OpenGro

Revert r337929

FreeBSD's mkstemp sets the temporary file's permissions to 600, and has ever
since mkstemp was added in 1987. Coverity's warning is still relevant for
portable programs since OpenGroup does not require that behavior, and POSIX
didn't until 2008. But none of these programs are portable.

show more ...

Fix Coverity warnings about mkstemp in tests

umask(2) should always be used prior to mkstemp(3) so the temporary file
won't be created with insecure permissions.

Reported by: Coverity
CID: 1331605

Fix Coverity warnings about mkstemp in tests

umask(2) should always be used prior to mkstemp(3) so the temporary file
won't be created with insecure permissions.

Reported by: Coverity
CID: 1331605 1347173 1375366 1339800 1331604 1296056 1296060
CID: 1296057 1296062
MFC after: 2 weeks

show more ...

Update PR 131876 regression tests after r337423.

- Add some more cases to the truncation test.
- Remove the "expect fail" annotations.

PR: 131876
MFC after: 1 month
Sponsored by: The FreeBSD Found

Update PR 131876 regression tests after r337423.

- Add some more cases to the truncation test.
- Remove the "expect fail" annotations.

PR: 131876
MFC after: 1 month
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D16562

show more ...

Fix the regression test for PR 181741.

With r337328, the test hangs becase the sendmsg() call will block until
the receive buffer is at least partially drained. Fix the problem by
using a non-block

Fix the regression test for PR 181741.

With r337328, the test hangs becase the sendmsg() call will block until
the receive buffer is at least partially drained. Fix the problem by
using a non-blocking socket and allowing short writes. Also assert
that a SCM_CREDS message was received if one was expected.

PR: 181741
MFC after: 1 month
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D16516

show more ...

Fix some nits in the unix_passfd tests.

- Remove return statements in functions with a void return type.
- Allocate enough space for the SCM_CREDS and SCM_RIGHTS messages
received in the rights_cr

Fix some nits in the unix_passfd tests.

- Remove return statements in functions with a void return type.
- Allocate enough space for the SCM_CREDS and SCM_RIGHTS messages
received in the rights_creds_payload test.

MFC after: 1 week
Sponsored by: The FreeBSD Foundation

show more ...

Add a regression test related to PR 131876.

If an error occurs while copying a SCM_RIGHTS message to userspace,
we free the mbuf containing externalized rights, leaking them.

PR: 131876
MFC after:

Add a regression test related to PR 131876.

If an error occurs while copying a SCM_RIGHTS message to userspace,
we free the mbuf containing externalized rights, leaking them.

PR: 131876
MFC after: 1 week
Sponsored by: The FreeBSD Foundation

show more ...