Clean up trailing whitespace

MFC after: 3 days

Use strlcpy() instead of strncpy() when copying ifname to ensure
that it is NUL terminated. Additional NUL padding is not required
for short names.

Reported by: Coverity
CID: 1009974
MFC after: 1

Use strlcpy() instead of strncpy() when copying ifname to ensure
that it is NUL terminated. Additional NUL padding is not required
for short names.

Reported by: Coverity
CID: 1009974
MFC after: 1 week

show more ...

route6d(8): Fix potential double-free

In the case that the subsequent sysctl(3) call failed, 'buf' could be free(3)ed
repeatedly. It isn't clear to me that that case is possible, but be clear and
d

route6d(8): Fix potential double-free

In the case that the subsequent sysctl(3) call failed, 'buf' could be free(3)ed
repeatedly. It isn't clear to me that that case is possible, but be clear and
do the right thing in case it is.

Reported by: Coverity
CID: 272537
Sponsored by: EMC / Isilon Storage Division

show more ...

Stop including if_var.h from userland.

Sponsored by: Nginx, Inc.

Recover sin6_scope_id of gateway addresses in riprecv() by using the if_index
where a RIP packet was received. This fixes a bug which prevented gateway
addresses in fe80::/64 from being added.

Remove unneeded fake _KERNEL definition.

Garbage collect long time obsoleted (or never used) stuff from routing API.

Axe IFF_SMART. Fortunately this layering violating flag was never used,
it was just declared.

- Increase the number of retry for NET_RT_DUMP from 5 to 15.
- Use 2001:db8:: as an example instead of deprecated 3ffe:: address block.
- Add check for connected routes.
- Add support of RTM_IFANNOUN

- Increase the number of retry for NET_RT_DUMP from 5 to 15.
- Use 2001:db8:: as an example instead of deprecated 3ffe:: address block.
- Add check for connected routes.
- Add support of RTM_IFANNOUNCE for dyanmically-added/removed interfaces.
- Add support of *, ?, and [ in the interface list.
- Add -P number to specify route flag which will never expire.
- Add -Q number to specify route flag which route6d will add to routes via RIP.
- Add -p pidfile to specify the process ID file.

show more ...

Overhaul of route6d(8):

- Use queue(3) for linked-list.
- Use a consistent naming scheme for struct members.
- Use ANSI C style function declaration.
- Add check of RTM_VERSION mismatch.

There is n

Overhaul of route6d(8):

- Use queue(3) for linked-list.
- Use a consistent naming scheme for struct members.
- Use ANSI C style function declaration.
- Add check of RTM_VERSION mismatch.

There is no functional change.

show more ...

Use sin6_scope_id instead of KAME-specific embedded scope id.

Spelling fixes for usr.sbin/

In usr.sbin/route6d/route6d.c, use the correct printf length modifier
for an ssize_t.

MFC after: 1 week

This main goals of this project are:
1. separating L2 tables (ARP, NDP) from the L3 routing tables
2. removing as much locking dependencies among these layers as
possible to allow for some paralle

This main goals of this project are:
1. separating L2 tables (ARP, NDP) from the L3 routing tables
2. removing as much locking dependencies among these layers as
possible to allow for some parallelism in the search operations
3. simplify the logic in the routing code,

The most notable end result is the obsolescent of the route
cloning (RTF_CLONING) concept, which translated into code reduction
in both IPv4 ARP and IPv6 NDP related modules, and size reduction in
struct rtentry{}. The change in design obsoletes the semantics of
RTF_CLONING, RTF_WASCLONE and RTF_LLINFO routing flags. The userland
applications such as "arp" and "ndp" have been modified to reflect
those changes. The output from "netstat -r" shows only the routing
entries.

Quite a few developers have contributed to this project in the
past: Glebius Smirnoff, Luigi Rizzo, Alessandro Cerri, and
Andre Oppermann. And most recently:

- Kip Macy revised the locking code completely, thus completing
the last piece of the puzzle, Kip has also been conducting
active functional testing
- Sam Leffler has helped me improving/refactoring the code, and
provided valuable reviews
- Julian Elischer setup the perforce tree for me and has helped
me maintaining that branch before the svn conversion

show more ...

Cleanup of userland __P use

implemented more validation checks about incoming responses per RFC2080, and one additional heuristic check for safer operation.

Obtained from: KAME
MFC after: 1 week

- need_trigger/idx should be u_int, not ssize_t.
- realloc pedant.
- set sin6_scope_id before sending (link-local/multicast) packets
- removed an incorrect comment
- don't age non-gateway host routes

- need_trigger/idx should be u_int, not ssize_t.
- realloc pedant.
- set sin6_scope_id before sending (link-local/multicast) packets
- removed an incorrect comment
- don't age non-gateway host routes.
- not remove global addresses on loopback interface from routing table
by route aging.

Obtained from: KAME

show more ...

fixe remote panic on short packet

Obtained from: KAME

remove unused variable

Supported by: FreeBSD Foundation

rtm_seq is int, so seq/myseq should be int.

Obtained from: KAME
MFC after: 1 week

suppress outpt on dump request if -q is specified.

Obtained from: KAME
MFC after: 1 week

atoi -> strtoul

Obtained from: KAME
MFC after: 1 week

- port numbers are unsigned. use %u.
- %d is not 10 chars, but 12 chars.

Obtained from: KAME
MFC after: 1 week

explicitly specify IPPROTO_UDP when calling getaddrinfo().

Obtained from: KAME
MFC after: 1 week

remove a variable that is never used.

Obtained from: KAME
MFC after: 1 week