#
cb3871b1 |
| 11-Oct-2023 |
Kees Cook <keescook@chromium.org> |
Bluetooth: hci_sock: Correctly bounds check and pad HCI_MON_NEW_INDEX name
The code pattern of memcpy(dst, src, strlen(src)) is almost always wrong. In this case it is wrong because it leaves memory
Bluetooth: hci_sock: Correctly bounds check and pad HCI_MON_NEW_INDEX name
The code pattern of memcpy(dst, src, strlen(src)) is almost always wrong. In this case it is wrong because it leaves memory uninitialized if it is less than sizeof(ni->name), and overflows ni->name when longer.
Normally strtomem_pad() could be used here, but since ni->name is a trailing array in struct hci_mon_new_index, compilers that don't support -fstrict-flex-arrays=3 can't tell how large this array is via __builtin_object_size(). Instead, open-code the helper and use sizeof() since it will work correctly.
Additionally mark ni->name as __nonstring since it appears to not be a %NUL terminated C string.
Cc: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Cc: Edward AD <twuufnxlz@gmail.com> Cc: Marcel Holtmann <marcel@holtmann.org> Cc: Johan Hedberg <johan.hedberg@gmail.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> Cc: linux-bluetooth@vger.kernel.org Cc: netdev@vger.kernel.org Fixes: 18f547f3fc07 ("Bluetooth: hci_sock: fix slab oob read in create_monitor_event") Link: https://lore.kernel.org/lkml/202310110908.F2639D3276@keescook/ Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
show more ...
|
#
f9a619db |
| 15-Jan-2020 |
Luiz Augusto von Dentz <luiz.von.dentz@intel.com> |
Bluetooth: monitor: Add support for ISO packets
This enables passing ISO packets to the monitor socket.
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Signed-off-by: Marcel Holtma
Bluetooth: monitor: Add support for ISO packets
This enables passing ISO packets to the monitor socket.
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
show more ...
|
#
38ceaa00 |
| 27-Aug-2016 |
Marcel Holtmann <marcel@holtmann.org> |
Bluetooth: Add support for sending MGMT commands and events to monitor
This adds support for tracing all management commands and events via the monitor interface.
Signed-off-by: Marcel Holtmann <ma
Bluetooth: Add support for sending MGMT commands and events to monitor
This adds support for tracing all management commands and events via the monitor interface.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
show more ...
|
#
249fa169 |
| 27-Aug-2016 |
Marcel Holtmann <marcel@holtmann.org> |
Bluetooth: Add support for sending MGMT open and close to monitor
This sends new notifications to the monitor support whenever a management channel has been opened or closed. This allows tracing of
Bluetooth: Add support for sending MGMT open and close to monitor
This sends new notifications to the monitor support whenever a management channel has been opened or closed. This allows tracing of control channels really easily.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
show more ...
|
#
ac714949 |
| 08-Nov-2015 |
Marcel Holtmann <marcel@holtmann.org> |
Bluetooth: Add support for controller specific logging
To enable controller specific logging, the userspace daemon has to have the ability to log per controller. To facilitate this support, provide
Bluetooth: Add support for controller specific logging
To enable controller specific logging, the userspace daemon has to have the ability to log per controller. To facilitate this support, provide a dedicated logging channel. Messages in this channel will be included in the monitor queue and with that also forwarded to monitoring tools along with the actual hardware traces.
All messages from the logging channel are timestamped and with that allow an easy correlation between userspace messages and hardware events. This will increase the ability to debug problems faster.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
show more ...
|
#
dd31506d |
| 08-Nov-2015 |
Marcel Holtmann <marcel@holtmann.org> |
Bluetooth: Add support for sending system notes to monitor channel
The monitor channel can be used to send generic system notes as text strings for debugging purposes. This adds the system note moni
Bluetooth: Add support for sending system notes to monitor channel
The monitor channel can be used to send generic system notes as text strings for debugging purposes. This adds the system note monitor code and uses it for including kernel and subsystem version into traces.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
show more ...
|
#
e875ff84 |
| 07-Oct-2015 |
Marcel Holtmann <marcel@holtmann.org> |
Bluetooth: Add support for vendor specific diagnostic channel
Introduce hci_recv_diag function for HCI drivers to allow sending vendor specific diagnostic messages into the Bluetooth core stack. The
Bluetooth: Add support for vendor specific diagnostic channel
Introduce hci_recv_diag function for HCI drivers to allow sending vendor specific diagnostic messages into the Bluetooth core stack. The messages are not processed, but they are forwarded to the monitor channel and can be retrieved by user space diagnostic tools.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
show more ...
|
#
6c566dd5 |
| 07-Oct-2015 |
Marcel Holtmann <marcel@holtmann.org> |
Bluetooth: Send index information updates to monitor channel
The Bluetooth public device address might change during controller setup and it makes it a lot simpler for monitoring tools if they just
Bluetooth: Send index information updates to monitor channel
The Bluetooth public device address might change during controller setup and it makes it a lot simpler for monitoring tools if they just get told what the new address is. In addition include the manufacturer / company information of the controller. That allows for easy vendor specific HCI command and event handling.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
show more ...
|
#
22db3cbc |
| 04-Oct-2015 |
Marcel Holtmann <marcel@holtmann.org> |
Bluetooth: Send transport open and close monitor events
When the core starts or shuts down the actual HCI transport, send a new monitor event that indicates that this is happening. These new events
Bluetooth: Send transport open and close monitor events
When the core starts or shuts down the actual HCI transport, send a new monitor event that indicates that this is happening. These new events correspond to HCI_DEV_OPEN and HCI_DEV_CLOSE events.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
show more ...
|
#
f64b993f |
| 07-Mar-2012 |
Gustavo F. Padovan <padovan@profusion.mobi> |
Bluetooth: Fix coding style in all .h files
Proper align the struct definitions.
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
|
#
cd82e61c |
| 20-Feb-2012 |
Marcel Holtmann <marcel@holtmann.org> |
Bluetooth: Add support for HCI monitor channel
The HCI monitor channel can be used to monitor all packets and events from the Bluetooth subsystem. The monitor is not bound to any specific HCI device
Bluetooth: Add support for HCI monitor channel
The HCI monitor channel can be used to monitor all packets and events from the Bluetooth subsystem. The monitor is not bound to any specific HCI device and allows even capturing multiple devices at the same time.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
show more ...
|