Flush input to EOL correctly in games/fish.

PR 54885 from Mouse, with a somewhat different patch.

fish: remove trailing whitespace

fish: use arc4random_uniform for drawing random numbers

Thanks nia@ for the hint.

fish: remove modulo bias from random number generation

It probably doesn't matter in practice, but omitting this piece of code
always looks like an oversight.

[fish] don't allow users to request cards they have made books for

While here, don't re-renter pro mode

PR bin/52973

ok maya@ dh@

reinstate NULL cast by request, where the NULL was being passed as a vararg

NULL does not need a cast

sprinkle static

Remove the \n and tabs from the __COPYRIGHT() strings.

convert __attribute__s to applicable cdefs.h macros

KNF conversion

Cast last argument of execl to (char *).

Reviewed by <hubertf>.

Remove uses of __P.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Use setgid(), not setregid().

Use an equal probability single draw algorithm to get card from deck.
Patch supplied by John Darrow in PR bin/9651.

Use the function usage().

Security improvements for games (largely from or inspired by OpenBSD).

Games which run setgid from dm, but don't need to, should drop their
privileges at startup.

Games which have a scorefile shoul

Security improvements for games (largely from or inspired by OpenBSD).

Games which run setgid from dm, but don't need to, should drop their
privileges at startup.

Games which have a scorefile should open it at startup, then drop all
privileges leaving just the open writable file descriptor. If the
game can invoke subprocesses, this should be made close-on-exec.

Games with scorefiles should make sure they do not get a file
descriptor < 3. (Otherwise, they could get confused and corrupt the
scorefile when using stdin, stdout or stderr.)

Some old setuid revokes from the days of setuid games change into gid
revokes.

show more ...

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to b

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

show more ...

This patch makes fish(6) honour PAGER for viewing the instructions.
The detailed behaviour follows POSIX.2. A similar patch for wump(6)
which was accepted is in bin/6699. Fish does not need any set

This patch makes fish(6) honour PAGER for viewing the instructions.
The detailed behaviour follows POSIX.2. A similar patch for wump(6)
which was accepted is in bin/6699. Fish does not need any setgid
privileges it gets from dm, so this patch also moves the gid resetting
earlier.

Reported in PR 7986 by Joseph Myers <jsm28@cam.ac.uk>

show more ...

Buffer overflow fix (from OpenBSD)

mark non-returning functions (PR#6144 by Joseph Myers <jsm28@cam.ac.uk>)

PR/4489: Mika Nystroem: Security hole exec'ing more in fish instructions.

WARNSify

merge with Lite, new RCS id conventions, etc.