games: remove trailing whitespace in *.c and *.h

WARNS=5, and make WARNS=5 the default for src/games.

reinstate NULL cast by request, where the NULL was being passed as a vararg

NULL does not need a cast

Fix some additional typos/grammar slips.

Fix dog-Latin. The plural of wumpus could be wumpi, wumpus, or even wumpora,
but not 'wumpii'. Where does this -ii crap come from?

remove unnecessary cast

sprinkle static

Remove the \n and tabs from the __COPYRIGHT() strings.

Build with WARNS=4.

convert __attribute__s to applicable cdefs.h macros

Fix some minor buglets in wump:
1) Don't put two pits in the same room.
2) Don't put bats and pits in the same room. (you will never hit the bat)
3) Don't start the player in a room with a pit or ba

Fix some minor buglets in wump:
1) Don't put two pits in the same room.
2) Don't put bats and pits in the same room. (you will never hit the bat)
3) Don't start the player in a room with a pit or bad, if possible. Some
caves are so crowded the loop may go on forever, so we give up after 100
tries to put them in a safe location (as long as it's not with the wumpus).
4) Make the manpage reflect reality WRT the default number of rooms.

Bug #3 pointed out by salo.

show more ...

Apply patch from PR bin/26501 to fix hang in wump if you play too many
games in a row. Also modify change made in rev 1.18 to work correctly.
take_action() returns 1 if the player dies, causing the

Apply patch from PR bin/26501 to fix hang in wump if you play too many
games in a row. Also modify change made in rev 1.18 to work correctly.
take_action() returns 1 if the player dies, causing the game to allways
exit after any death, now the game correctly asks if the player would
like to play again.

show more ...

Fix a long-standing bug in wump(6) whereby hitting ^d to exit would first
print ``Care to play another game? (y-n)'' (but then exit anyway without
waiting for an answer).

Cast last argument of execl to (char *).

Reviewed by <hubertf>.

Remove uses of __P.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Ensure that the random hop delta does make the cave connected. Based
on bug report and patch from <afghan@afghanhound.org.uk>.

Use setgid(), not setregid().

Security improvements for games (largely from or inspired by OpenBSD).

Games which run setgid from dm, but don't need to, should drop their
privileges at startup.

Games which have a scorefile shoul

Security improvements for games (largely from or inspired by OpenBSD).

Games which run setgid from dm, but don't need to, should drop their
privileges at startup.

Games which have a scorefile should open it at startup, then drop all
privileges leaving just the open writable file descriptor. If the
game can invoke subprocesses, this should be made close-on-exec.

Games with scorefiles should make sure they do not get a file
descriptor < 3. (Otherwise, they could get confused and corrupt the
scorefile when using stdin, stdout or stderr.)

Some old setuid revokes from the days of setuid games change into gid
revokes.

show more ...

Use STD*_FILENO.

Include <time.h> in various places in the games where time() or time_t
are used.

This patch fixes a -Wcast-qual warning in wump(6).
Submitted in 7994 by Joseph Myers <jsm28@cam.ac.uk>

Only invoke pager given in $PAGER if output goes to a tty, feed pager
via stdin, per PR 6699 by Joseph Myers <jsm28@cam.ac.uk>

mark non-returning functions (PR#6144 by Joseph Myers <jsm28@cam.ac.uk>)