#
132587bf |
| 04-Jan-2021 |
thorpej <thorpej@NetBSD.org> |
malloc(9) -> kmem(9)
|
#
70747dc1 |
| 10-Nov-2019 |
chs <chs@NetBSD.org> |
in many device attach paths, allocate memory with M_WAITOK instead of M_NOWAIT and remove code to handle failures that can no longer happen.
|
#
a8a5c538 |
| 03-Sep-2018 |
riastradh <riastradh@NetBSD.org> |
Rename min/max -> uimin/uimax for better honesty.
These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a n
Rename min/max -> uimin/uimax for better honesty.
These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a name change -- no functional change intended.
HOWEVER! Some subsystems have
#define min(a, b) ((a) < (b) ? (a) : (b)) #define max(a, b) ((a) > (b) ? (a) : (b))
even though our standard name for that is MIN/MAX. Although these may invite multiple evaluation bugs, these do _not_ cause integer truncation.
To avoid `fixing' these cases, I first changed the name in libkern, and then compile-tested every file where min/max occurred in order to confirm that it failed -- and thus confirm that nothing shadowed min/max -- before changing it.
I have left a handful of bootloaders that are too annoying to compile-test, and some dead code:
cobalt ews4800mips hp300 hppa ia64 luna68k vax acorn32/if_ie.c (not included in any kernels) macppc/if_gm.c (superseded by gem(4))
It should be easy to fix the fallout once identified -- this way of doing things fails safe, and the goal here, after all, is to _avoid_ silent integer truncations, not introduce them.
Maybe one day we can reintroduce min/max as type-generic things that never silently truncate. But we should avoid doing that for a while, so that existing code has a chance to be detected by the compiler for conversion to uimin/uimax without changing the semantics until we can properly audit it all. (Who knows, maybe in some cases integer truncation is actually intended!)
show more ...
|
#
b50db235 |
| 09-Jun-2015 |
matt <matt@NetBSD.org> |
#include <sys/cpu.h> or <mips/cpuregs.h> as needed
|
#
1a918832 |
| 25-Jul-2014 |
dholland <dholland@NetBSD.org> |
Add d_discard to all struct cdevsw instances I could find.
All have been set to "nodiscard"; some should get a real implementation.
|
#
76258fa0 |
| 16-Mar-2014 |
dholland <dholland@NetBSD.org> |
Change (mostly mechanically) every cdevsw/bdevsw I can find to use designated initializers.
I have not built every extant kernel so I have probably broken at least one build; however I've also found
Change (mostly mechanically) every cdevsw/bdevsw I can find to use designated initializers.
I have not built every extant kernel so I have probably broken at least one build; however I've also found and fixed some wrong cdevsw/bdevsw entries so even if so I think we come out ahead.
show more ...
|
#
5f819ca3 |
| 27-Oct-2012 |
chs <chs@NetBSD.org> |
split device_t/softc for all remaining drivers. replace "struct device *" with "device_t". use device_xname(), device_unit(), etc.
|
#
59e893d2 |
| 25-Aug-2011 |
dyoung <dyoung@NetBSD.org> |
Use humanize_number() instead of the buggy code that GCC 4.5 caught. Compiles. Not tested.
|
#
7bec7338 |
| 01-Jul-2011 |
dyoung <dyoung@NetBSD.org> |
#include <sys/bus.h> instead of <machine/bus.h>.
|
#
3d8fe45f |
| 11-Jun-2008 |
cegger <cegger@NetBSD.org> |
use device_lookup_private to get softc
|
#
ce099b40 |
| 28-Apr-2008 |
martin <martin@NetBSD.org> |
Remove clause 3 and 4 from TNF licenses
|
#
60a298a6 |
| 25-May-2006 |
gdamore <gdamore@NetBSD.org> |
Rename flash to athflash to reflect MD nature. Approved by simon@ and dyoung@
|