#
647e93ed |
| 19-Dec-2021 |
andvar <andvar@NetBSD.org> |
fix various typos in bktr driver comments.
|
#
14b4bbb2 |
| 23-May-2020 |
ad <ad@NetBSD.org> |
Move proc_lock into the data segment. It was dynamically allocated because at the time we had mutex_obj_alloc() but not __cacheline_aligned.
|
#
d5aa2bea |
| 23-Feb-2020 |
skrll <skrll@NetBSD.org> |
typo in comment
|
#
78876854 |
| 03-Feb-2019 |
mrg <mrg@NetBSD.org> |
- add or adjust /* FALLTHROUGH */ where appropriate - add __unreachable() after functions that can return but won't in this case, and thus can't be marked __dead easily
|
#
a8a5c538 |
| 03-Sep-2018 |
riastradh <riastradh@NetBSD.org> |
Rename min/max -> uimin/uimax for better honesty.
These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a n
Rename min/max -> uimin/uimax for better honesty.
These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a name change -- no functional change intended.
HOWEVER! Some subsystems have
#define min(a, b) ((a) < (b) ? (a) : (b)) #define max(a, b) ((a) > (b) ? (a) : (b))
even though our standard name for that is MIN/MAX. Although these may invite multiple evaluation bugs, these do _not_ cause integer truncation.
To avoid `fixing' these cases, I first changed the name in libkern, and then compile-tested every file where min/max occurred in order to confirm that it failed -- and thus confirm that nothing shadowed min/max -- before changing it.
I have left a handful of bootloaders that are too annoying to compile-test, and some dead code:
cobalt ews4800mips hp300 hppa ia64 luna68k vax acorn32/if_ie.c (not included in any kernels) macppc/if_gm.c (superseded by gem(4))
It should be easy to fix the fallout once identified -- this way of doing things fails safe, and the goal here, after all, is to _avoid_ silent integer truncations, not introduce them.
Maybe one day we can reintroduce min/max as type-generic things that never silently truncate. But we should avoid doing that for a while, so that existing code has a chance to be detected by the compiler for conversion to uimin/uimax without changing the semantics until we can properly audit it all. (Who knows, maybe in some cases integer truncation is actually intended!)
show more ...
|
#
494270e7 |
| 14-Dec-2012 |
joerg <joerg@NetBSD.org> |
bt848_format is only defined in a __FreeBSD__ section of bktr_os.c and overriding the local (static) definition with extern is bogus.
|
#
5f819ca3 |
| 27-Oct-2012 |
chs <chs@NetBSD.org> |
split device_t/softc for all remaining drivers. replace "struct device *" with "device_t". use device_xname(), device_unit(), etc.
|
#
fcddf71f |
| 30-Jun-2011 |
wiz <wiz@NetBSD.org> |
dependant -> dependent
|
#
8184d5dc |
| 13-Nov-2010 |
uebayasi <uebayasi@NetBSD.org> |
Don't pull in the whole uvm(9) API to access only PAGE_SIZE and some other constants. These are provided by sys/param.h now.
|
#
c363a9cb |
| 18-Mar-2009 |
cegger <cegger@NetBSD.org> |
bzero -> memset
|
#
6d70f903 |
| 24-Apr-2008 |
ad <ad@NetBSD.org> |
Network protocol interrupts can now block on locks, so merge the globals proclist_mutex and proclist_lock into a single adaptive mutex (proc_lock). Implications:
- Inspecting process state requires
Network protocol interrupts can now block on locks, so merge the globals proclist_mutex and proclist_lock into a single adaptive mutex (proc_lock). Implications:
- Inspecting process state requires thread context, so signals can no longer be sent from a hardware interrupt handler. Signal activity must be deferred to a soft interrupt or kthread.
- As the proc state locking is simplified, it's now safe to take exit() and wait() out from under kernel_lock.
- The system spends less time at IPL_SCHED, and there is less lock activity.
show more ...
|
#
9d57c800 |
| 10-Apr-2008 |
cegger <cegger@NetBSD.org> |
use aprint_*_dev and device_xname
|
#
c6186fac |
| 01-Mar-2008 |
rmind <rmind@NetBSD.org> |
Welcome to 4.99.55:
- Add a lot of missing selinit() and seldestroy() calls.
- Merge selwakeup() and selnotify() calls into a single selnotify().
- Add an additional 'events' argument to selnotify
Welcome to 4.99.55:
- Add a lot of missing selinit() and seldestroy() calls.
- Merge selwakeup() and selnotify() calls into a single selnotify().
- Add an additional 'events' argument to selnotify() call. It will indicate which event (POLL_IN, POLL_OUT, etc) happen. If unknown, zero may be used.
Note: please pass appropriate value of 'events' where possible. Proposed on: <tech-kern>
show more ...
|
#
f4e9b243 |
| 16-Jan-2008 |
jmcneill <jmcneill@NetBSD.org> |
Don't assume that sizeof(long) == sizeof(int); makes bktr work on amd64.
|
#
0664a045 |
| 04-Jan-2008 |
ad <ad@NetBSD.org> |
Start detangling lock.h from intr.h. This is likely to cause short term breakage, but the mess of dependencies has been regularly breaking the build recently anyhow.
|
#
a2a38285 |
| 19-Oct-2007 |
ad <ad@NetBSD.org> |
machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h
|
#
88ab7da9 |
| 09-Jul-2007 |
ad <ad@NetBSD.org> |
Merge some of the less invasive changes from the vmlocking branch:
- kthread, callout, devsw API changes - select()/poll() improvements - miscellaneous MT safety improvements
|
#
53524e44 |
| 04-Mar-2007 |
christos <christos@NetBSD.org> |
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.
|
#
b07ec3fc |
| 09-Feb-2007 |
ad <ad@NetBSD.org> |
Merge newlock2 to head.
|
#
168cd830 |
| 16-Nov-2006 |
christos <christos@NetBSD.org> |
__unused removal on arguments; approved by core.
|
#
4d595fd7 |
| 12-Oct-2006 |
christos <christos@NetBSD.org> |
- sprinkle __unused on function decls. - fix a couple of unused bugs - no more -Wno-unused for i386
|
#
bedc649e |
| 03-Sep-2006 |
bouyer <bouyer@NetBSD.org> |
stop attaching when a bus_dma operation fails, instead of using bogus addresses. Remplace vtophys() with proper bus_dma(9) use. This driver now works properly on Xen
|
#
63f68a89 |
| 28-Aug-2006 |
christos <christos@NetBSD.org> |
remove unreachable code.
|
#
95e1ffb1 |
| 11-Dec-2005 |
christos <christos@NetBSD.org> |
merge ktrace-lwp.
|
#
4b82c3d9 |
| 30-May-2005 |
wiz <wiz@NetBSD.org> |
Fix replaco in comment.
|