History log of /netbsd/sys/netinet/sctp_indata.c (Results 1 – 13 of 13)
Revision Date Author Comments
# b910f349 05-Apr-2023 andvar <andvar@NetBSD.org>

remove some double ee typos in comments.


# 93e1d835 28-May-2022 andvar <andvar@NetBSD.org>

fix various typos in comments.


# 6a7344ab 24-May-2022 andvar <andvar@NetBSD.org>

fix various typos in comment, documentation and log messages.


# cdf42b1a 08-Apr-2022 andvar <andvar@NetBSD.org>

s/postion/position/


# 778f5600 07-Apr-2022 andvar <andvar@NetBSD.org>

fix various typos in comments.


# bc2d92a5 22-Dec-2018 maxv <maxv@NetBSD.org>

Replace: M_MOVE_PKTHDR -> m_move_pkthdr. No functional change, since the
former is a macro to the latter.


# a8a5c538 03-Sep-2018 riastradh <riastradh@NetBSD.org>

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a n

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)

show more ...


# 82000398 01-May-2018 maxv <maxv@NetBSD.org>

Remove now unused net_osdep.h includes, the other BSDs did the same.


# 5a349a09 10-Dec-2017 rjs <rjs@NetBSD.org>

Improve compliance to RFC 6458.


# bc8fd953 25-Apr-2016 rjs <rjs@NetBSD.org>

Fix build when IPSEC enabled.


# 7231b0cd 15-Feb-2016 rtr <rtr@NetBSD.org>

Fix building of IPv4-Mapped IPv6 addresses.

As discussed on tech-net@ use in6_sin_2_v4mapsin6() to build mapped
addresses.


# a296faa8 13-Dec-2015 christos <christos@NetBSD.org>

PR/50528: David Binderman: remove sizeof(sizeof(x))


# c05f20fb 13-Oct-2015 rjs <rjs@NetBSD.org>

Add core networking support for SCTP.