#
70ecd160 |
| 31-Aug-2024 |
tb <tb@openbsd.org> |
Unexport some conf layers unused outside of libcrypto
imodules are called imodules because they contain Information about modules that have been Initialized. Which one of these two I it is is anyone
Unexport some conf layers unused outside of libcrypto
imodules are called imodules because they contain Information about modules that have been Initialized. Which one of these two I it is is anyone's best guess. Why anything outside of libcrypto would ever possibly care will also remain a mystery.
Remove the old way of adding a conf module, user data, stop allowing to set a method (it's opaque now, remember?) and drop a couple bits more from the public api interface.
ok beck jsing
show more ...
|
#
bbdd77aa |
| 09-Apr-2024 |
beck <beck@openbsd.org> |
Hide symbols in conf.h
This guentherizes the public symbols from conf.h
ok tb@
|
#
96025fd0 |
| 26-Mar-2024 |
tb <tb@openbsd.org> |
Clean up conf's module_init()
Immediately error out when no name or value is passed instead of hiding this in a a combination of ternary operator and strdup error check. Use calloc(). Unindent some
Clean up conf's module_init()
Immediately error out when no name or value is passed instead of hiding this in a a combination of ternary operator and strdup error check. Use calloc(). Unindent some stupid, don't pretend this function can return anything but -1 and 1, turn the whole thing into single exit and call the now existing imodule_free() instead of handrolling it.
ok jsing
show more ...
|
#
5c82b5ec |
| 20-Mar-2024 |
tb <tb@openbsd.org> |
Rename the remaining pmod to mod
|
#
482e134a |
| 20-Mar-2024 |
tb <tb@openbsd.org> |
pmod -> mod in CONF_IMODULE
Hungarian notation occasionally helps, but only if it is done consistently. Steve and consistency... cf e.g the last few commits. Accordingly, Hensonian Hungarian notatio
pmod -> mod in CONF_IMODULE
Hungarian notation occasionally helps, but only if it is done consistently. Steve and consistency... cf e.g the last few commits. Accordingly, Hensonian Hungarian notation is a complete disaster. Start cleaning this mess up.
show more ...
|
#
fee7a564 |
| 20-Mar-2024 |
tb <tb@openbsd.org> |
tmod -> mod
requested by jsing
|
#
1d159dde |
| 20-Mar-2024 |
tb <tb@openbsd.org> |
md -> imod for CONF_IMODULEs
A CONF_IMODULE is neither an EVP_MD nor a CONF_MODULE, so call it imod instead of md or mod.
|
#
511ac327 |
| 20-Mar-2024 |
tb <tb@openbsd.org> |
md -> mod for CONF_MODULEs
A CONF_MODULE is no EVP_MD, so call it mod instead of md.
|
#
3cdf45a4 |
| 20-Mar-2024 |
tb <tb@openbsd.org> |
Change return type of module_add()
There is one caller of this function which returns module_add() != NULL. Make the function return an int instead.
suggested by and ok jsing
|
#
1d022c02 |
| 20-Mar-2024 |
tb <tb@openbsd.org> |
Implement imodule_free() and call it from module_finish()
ok jsing
|
#
f06d1561 |
| 20-Mar-2024 |
tb <tb@openbsd.org> |
Make module_free() NULL safe
ok jsing
|
#
e0656bc1 |
| 20-Jul-2023 |
tb <tb@openbsd.org> |
Remove last internal consumer of DSO
It is currently possible to extend libcrypto by having it load a shared object via dlopen() either from a config file on library initialization or when an applic
Remove last internal consumer of DSO
It is currently possible to extend libcrypto by having it load a shared object via dlopen() either from a config file on library initialization or when an application calls the relevant API. Recent and not so recent events showed how dangerous an idea dlopen() is. Independently of such concerns, this should not be handled in the characteristically convoluted way of this toolkit. DSO will go away in the upcoming bump. This commit clears the road for a plain cvs rm of the dso code.
ok jsing
show more ...
|
#
5067ae9f |
| 29-Jan-2017 |
beck <beck@openbsd.org> |
Send the function codes from the error functions to the bit bucket, as was done earlier in libssl. Thanks inoguchi@ for noticing libssl had more reacharounds into this. ok jsing@ inoguchi@
|
#
920ccb62 |
| 11-Apr-2015 |
deraadt <deraadt@openbsd.org> |
Remove all getenv() calls, especially those wrapped by issetugid(). getenv()'s wrapped by issetugid() are safe, but issetugid() is correct difficult to impliment on many operating systems. By accide
Remove all getenv() calls, especially those wrapped by issetugid(). getenv()'s wrapped by issetugid() are safe, but issetugid() is correct difficult to impliment on many operating systems. By accident, a grand experiment was run over the last year, where issetugid() returned 1 (the safe value) on a few operating systems. Noone noticed & complained that certain environment variables were not working....... ok doug beck jsing, discussion with others
show more ...
|
#
69442892 |
| 22-Jul-2014 |
beck <beck@openbsd.org> |
Kill a bunch more BUF_strdup's - these are converted to have a check for NULL before an intrinsic strdup. ok miod@
|
#
74a2cbdc |
| 13-Jul-2014 |
beck <beck@openbsd.org> |
The bell tolls for BUF_strdup - Start the migration to using intrinsics. This is the easy ones, a few left to check one at a time. ok miod@ deraadt@
|
#
b6ab114e |
| 11-Jul-2014 |
jsing <jsing@openbsd.org> |
Only import cryptlib.h in the four source files that actually need it. Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need t
Only import cryptlib.h in the four source files that actually need it. Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need them. While here, also sort/group/tidy the includes.
ok beck@ miod@
show more ...
|
#
a8913c44 |
| 10-Jul-2014 |
jsing <jsing@openbsd.org> |
Stop including standard headers via cryptlib.h - pull in the headers that are needed in the source files that actually require them.
ok beck@ miod@
|
#
75eb8854 |
| 23-Jun-2014 |
deraadt <deraadt@openbsd.org> |
Since this is a library, place issetugid() before every getenv() ok miod
|
#
c3d6a26a |
| 12-Jun-2014 |
deraadt <deraadt@openbsd.org> |
tags as requested by miod and tedu
|
#
79cf10b5 |
| 30-May-2014 |
tedu <tedu@openbsd.org> |
no need for null check before free. from Brendan MacDonell
|
#
0f637b92 |
| 26-Apr-2014 |
beck <beck@openbsd.org> |
Replace all use of ERR_add_error_data with ERR_asprintf_error_data. This avoids a lot of ugly gymnastics to do snprintfs before sending the bag of strings to ERR, and eliminates at least one place in
Replace all use of ERR_add_error_data with ERR_asprintf_error_data. This avoids a lot of ugly gymnastics to do snprintfs before sending the bag of strings to ERR, and eliminates at least one place in dso_dlfctn.c where it was being called with the incorrect number of arguments and using random things off the stack as addresses of strings. ok krw@, jsing@
show more ...
|
#
44486fcb |
| 20-Apr-2014 |
jsing <jsing@openbsd.org> |
KNF.
|
#
5359f6d5 |
| 19-Apr-2014 |
guenther <guenther@openbsd.org> |
We'll interpret a (void) cast on snprintf() to mean it's been verified that truncation is either desirable, not an issue, or is detected and handled later
ok deraadt@
|
#
e1962626 |
| 18-Apr-2014 |
deraadt <deraadt@openbsd.org> |
use the portable construct around asprintf; pointed out by halex
|